mon: simplify PG health checks

Instead of a distinct health check for each possible
PG state, group the states into categories for availability,
degraded, damage, and report on that.

That way, while a PG/pool is suffering from one of those
bad PG states, health conditions don't keep toggling on and
off as we transition from one unavailable state to another
unavailable state.

Signed-off-by: John Spray <john.spray@redhat.com>

mgr/dashboard: update for new style health checks

Signed-off-by: John Spray <john.spray@redhat.com>

mon: demote cluster map prints to DEBUG level

The PaxosService subclasses should be writing out
informative log messages, and not relying on
a stream of map summary prints to communicate
changes.

Signed-off-by: John Spray <john.spray@redhat.com>

mon: prettify health check log messages

Add a "Cluster is now healthy" to give clarity
after a series of "health check cleared" that
they were the last ones.

Convert certain health check messages into
well formed sentences.

Don't print severity in the log string (it's already
expressed in the severity of the log entry.

Signed-off-by: John Spray <john.spray@redhat.com>

mgr: fix spurious PG health messages on mgr restart

Previously, the mgr would send MMonMgrReport indicating
a very unhappy PGMap to the mon right after startup.

This is a change to hold off on sending that report until
all the OSDs have reported in, or until some time has passed.

Signed-off-by: John Spray <john.spray@redhat.com>

mon: don't consider a starting mgr to be an error

The .available flag is there to tell MgrClients whether
to try and connect -- it isn't the right condition
for a health complaint.

Signed-off-by: John Spray <john.spray@redhat.com>

mon: pass new style health to mgr

Signed-off-by: John Spray <john.spray@redhat.com>

mon: prefix periodic health reminder with 'overall'

...so we can whitelist it.

Signed-off-by: Sage Weil <sage@redhat.com>

mon/PGMap: rename a few health checks

Signed-off-by: Sage Weil <sage@redhat.com>

mgr/DaemonServer: debug log health checks

Signed-off-by: Sage Weil <sage@redhat.com>

mon/MgrStatMonitor: show health check count on receipt

Signed-off-by: Sage Weil <sage@redhat.com>

messages/MMonMgrReport: show health check count

Signed-off-by: Sage Weil <sage@redhat.com>

mon/PGMap: only warn about too few pgs after >0 pools exist

Signed-off-by: Sage Weil <sage@redhat.com>

mon/PGMap: some stuck warnings are err, some warn

inactive and stale -> error
degraded, unclean, undersized -> warning

Signed-off-by: Sage Weil <sage@redhat.com>

qa/suites/rados: whitelist health warnings

Signed-off-by: Sage Weil <sage@redhat.com>

mon/PGMap: do not warn about recovering, peering, stale

Wait for stuck before complaining.  These aren't scary in and of
themselves.

Signed-off-by: Sage Weil <sage@redhat.com>

qa/tasks/mon_clock_skew_check: vastly simplify

Signed-off-by: Sage Weil <sage@redhat.com>

mon: shorten 'stuck' threshold from 5m -> 1m

Signed-off-by: Sage Weil <sage@redhat.com>

osd/OSDMap: add per-osd flag OSD_FLAGS check

rename OSD_FLAGS to OSDMAP_FLAGS

Signed-off-by: Sage Weil <sage@redhat.com>

osd/OSDMap: rename a few health checks

Signed-off-by: Sage Weil <sage@redhat.com>

mon: move osd health checks into OSDMap method

...with one check moving into HealthMonitor where it
belongs.

Signed-off-by: Sage Weil <sage@redhat.com>

qa/tasks/ceph: stop logging health on shutdown

Don't log health during actual teardown or we'll see
various scary messages unrelated to our test run.

Signed-off-by: Sage Weil <sage@redhat.com>

mon/MgrMonitor: do not issue MGR_DOWN on new cluster

It is normal for the initial cluster to lack a mgr.  Wait for some
grace period before complaining about a missing mgr.

Default to 30m.

Signed-off-by: Sage Weil <sage@redhat.com>

mon/Monitor: periodically log new-style health warnings to log

Signed-off-by: Sage Weil <sage@redhat.com>

mon/MDSMonitor: implement new-style cephfs health checks

Our detail elements are still strings, so we keep the bit that collapses
the metadata into a string and appends it to the string.

Each MDS-generated item becomes a detail record.

Health checks are consolidated either by MDS_ or FS_, counting the
number of mds servers or file systems affected.

Signed-off-by: Sage Weil <sage@redhat.com>

mon,mgr: pass new-style health checks from mgr's PGMap

Signed-off-by: Sage Weil <sage@redhat.com>

mon/PGMap: implement new-style health checks

Signed-off-by: Sage Weil <sage@redhat.com>

mon/OSDMonitor: implement new health checks

Signed-off-by: Sage Weil <sage@redhat.com>

mon: new health check framework

Signed-off-by: Sage Weil <sage@redhat.com>

mon: HealthMonitor -> OldHealthMonitor

This will go away post-luminous.

Signed-off-by: Sage Weil <sage@redhat.com>

mon: remove Formatter arg to QuorumService::get_health()

This is used to dump extra weirdness to the health detail structured
output, but we are about to remove all of that in luminous.

Signed-off-by: Sage Weil <sage@redhat.com>

mon/Monitor: move time sync status from 'ceph health' to 'time-sync-status' command

Signed-off-by: Sage Weil <sage@redhat.com>

mon: move health_status_t to health.h

Signed-off-by: Sage Weil <sage@redhat.com>

mon: move pool quota health warnings into PGMap

This puts them on the mgr in a context where they can respond to both
osdmap and pgmap updates, and removes one more dependency on pgservice
in osdmon.

We keep the pool quota FULL warning since that is a function of OSDMap
state (the pool flag... not actual usage).

Signed-off-by: Sage Weil <sage@redhat.com>

Merge pull request #15630 from Abhishekvrshny/fix-rgw-multipart-leaks

rgw: fix leaks with incomplete multiparts

Reviewed-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #15669 from rzarzynski/wip-rgw-fix-rgwbucket-error-handling

rgw: fix error handling in the link() method of RGWBucket.

Reviewed-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #15834 from prallabh/wip-20377

rgw: Do not fetch bucket stats by default upon bucket listing

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>

Merge pull request #15887 from rzarzynski/wip-rgw-20394

rgw: /info claims we do support Swift's accounts ACLs.

Reviewed-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #16154 from mikulely/obj-placement-pool

rgw: drop unused rgw_pool parameter, local variables and member variable

Reviewed-by: Jos Collin <jcollin@redhat.com>

Merge pull request #14961 from yehudasa/wip-19739

rgw: verify md5 in post obj

Reviewed-by: Orit Wasserman <owasserm@redhat.com>

Merge pull request #15281 from jimifm/wip-rgw_rados-master

rgw/rgw_rados: Remove duplicate calls in RGWRados::finalize()

Reviewed-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #16287 from liewegas/wip-try-decode

mon/MgrStatMonitor: do not crash on luminous dev version upgrades

Reviewed-by: Yan, Zheng" <zyan@redhat.com>
Reviewed-by: Jos Collin <jcollin@redhat.com>

Merge pull request #16197 from shashalu/fix-RGWRadosRemoveOmapKeysCR

rgw:multisite: fix RGWRadosRemoveOmapKeysCR and change cn to intrusive_ptr

Reviewed-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #15843 from ovh/bp-drop-ping-fields

messages/MOSDPing.h: drop unused fields

Reviewed-by: Greg Farnum <gfarnum@redhat.com>

Merge pull request #15929 from cbodley/wip-vstart-rgw-compression

vstart: add --rgw_compression to set rgw compression plugin

Reviewed-by: Matt Benjamin <mbenjami@redhat.com>
Reviewed-by: Orit Wasserman <owasserm@redhat.com>

mon/MgrStatMonitor: do not crash on luninous dev version upgrades

Signed-off-by: Sage Weil <sage@redhat.com>

Merge pull request #16254 from TsaiJin/wip-rbd-nbd-version

tools/rbd_nbd: add --version show support

Reviewed-by: Jos Collin <jcollin@redhat.com>

rgw:multisite: change raw 'RGWAioCompletionNotifier*' to intrusive_ptr for rgw_cr_rados

Signed-off-by: Shasha Lu <lu.shasha@eisoo.com>

Merge pull request #16074 from smithfarm/wip-obsolete-libcephfs1

build/ops: rpm: obsolete libcephfs1

Reviewed-by: Ken Dreyer <kdreyer@redhat.com>
Reviewed-by: Boris Ranto <branto@redhat.com>

Merge pull request #16224 from liewegas/wip-docs-prune

doc: update intro, quick start docs

Reviewed-by: Alfredo Deza <adeza@redhat.com>

vstart: add --rgw_compression to set rgw compression plugin

Signed-off-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #15632 from aclamk/wip-vstart-20235-multiple-radosgw

vstart: allow to start multiple radosgw when RGW=x

Reviewed-by: Abhishek Lekshmanan <abhishek@suse.com>
Reviewed-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #16265 from dzafman/wip-20470

test: Fix reg11184 test to remove extraneous pg

Reviewed-by: Sage Weil <sage@redhat.com>

Merge pull request #16244 from liewegas/wip-11793

qa/suites/rados/thrash/workload/*: enable rados.py cache tiering ops

Reviewed-by: Josh Durgin <jdurgin@redhat.com>

qa/suites/: enable rados.py cache tiering ops

These weren't being exercised!

See http://tracker.ceph.com/issues/11793

Signed-off-by: Sage Weil <sage@redhat.com>

Merge pull request #15836 from xiexingguo/wip-refactor-try-reuse-blob

os/bluestore: slightly refactor Blob::try_reuse_blob

Reviewed-by: Igor Fedotov <ifedotov@mirantis.com>
Reviewed-by: Sage Weil <sage@redhat.com>

Merge pull request #16245 from cbodley/wip-global-zlib-compressor

compressor/zlib: remove g_ceph_context/g_conf from compressor plugin

Reviewed-by: Matt Benjamin <mbenjami@redhat.com>
Reviewed-by: Adam Kupczyk <akupczyk@redhat.com>

Merge pull request #16091 from runsisi/wip-lock-type

cls_lock: move lock_info_t definition to cls_lock_types.h

Reviewed-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #16158 from majianpeng/bluestore-using-bufferlist-function-do-the-same-function

os/bluestore: use bufferlist functions whenever possible

Reviewed-by: Igor Fedotov <ifedotov@mirantis.com>
Reviewed-by: Sage Weil <sage@redhat.com>

Merge pull request #16227 from tchaikov/wip-kill-clang-analyzer-warnings

mgr,os,test: kill clang analyzer warnings

Reviewed-by: Brad Hubbard <bhubbard@redhat.com>

Merge pull request #16239 from xiexingguo/wip-crush-weight-overflow

mon: a few more upmap (and other) fixes

Reviewed-by: Sage Weil <sage@redhat.com>

Merge pull request #16249 from gregsfortytwo/wip-20562-cluster-stats

mon: maintain the "cluster" PerfCounters when using ceph-mgr

Reviewed-by: Joao Eduardo Luis <joao@suse.de>

test: Fix reg11184 test to remove extraneous pg

Minor cleanups
Remove unused pool to aid future analysis

Signed-off-by: David Zafman <dzafman@redhat.com>

Fixed too big privileges for client.rgw.

Signed-off-by: Adam Kupczyk <akucpzyk@redhat.com>

tools/rbd_nbd: add version show support

Signed-off-by: Jin Cai <caijin.caij@alibaba-inc.com>

Merge pull request #15989 from linuxbox2/wip-nfs-compress

rgw_file: add compression interop to RGW NFS

rgw_file: add large(ish) write test

allows for read-after-write verify

Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>

rgw_file:  compression fix and cleanup from review

A fix and a cleanup from Adam Kupczyk <akupczyk@redhat.com> review.

Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>

rgw_file:  enable compression filter (stores)

Previously NFS clients could access compressed data, but the
RGWWriteDataRequest lacked glue to attach an inbound
compression filter.

Fixes: http://tracker.ceph.com/issues/20462
Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>

Merge pull request #16241 from liewegas/wip-dashboard-default

doc/mgr/dashboard: update dashboard docs to reflect new defaults

Reviewed-by: John Spray <john.spray@redhat.com>

Merge pull request #16034 from guihecheng/rgw_file-policy-read

rgw: rgw_file skip policy read for virtual components

vstart: allow to start multiple radosgw on consecutive ports

Signed-off-by: Adam Kupczyk <akupczyk@mirantis.com>

rgw:multisite: fix RGWRadosRemoveOmapKeysCR

RGWRadosRemoveOmapKeysCR::request_complete return val is wrong. The return val should get from completion.  Some member variables is not used, clear up those variables.

Fixes:http://tracker.ceph.com/issues/20539

Signed-off-by: Shasha Lu <lu.shasha@eisoo.com>

Merge pull request #16229 from Liuchang0812/wip-misc-cleanup

ceph.in, mgr: misc cleanups

Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #16230 from jecluis/wip-20443

mon/Monitor: recreate mon session if features changed

Reviewed-by: Sage Weil <sage@redhat.com>

Merge pull request #16233 from liewegas/wip-osd-create

qa/tasks/ceph.py: no osd id to 'osd create' command

Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #16235 from tchaikov/wip-timer

os/filestore: do not free event if not added

Reviewed-by: Josh Durgin <jdurgin@redhat.com>

Merge pull request #16237 from YankunLi/dev-bluestore0710

os/blueStore: Failure retry for opening file

Reviewed-by: Jos Collin <jcollin@redhat.com>

mon: maintain the "cluster" PerfCounters when using ceph-mgr instead of PGMonitor

Fixes: http://tracker.ceph.com/issues/20562
Signed-off-by: Greg Farnum <gfarnum@redhat.com>

Merge pull request #16246 from gregsfortytwo/wip-fix-mgr-cephx-link

doc: fix link for ceph-mgr cephx authorization

mon/OSDMonitor: dedup pg-upmap[-items]

Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>

osd/OSDMap: fix potential divided-by-zero error

Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>

mon/OSDMonitor: allow user to permanently delete pool

If mon_fake_pool_delete is enabled, "osd pool delete"
will unable to delete pool permanently, as we ask user
to pass in a "--yes-i-really-really-mean-it-no-faking"
string now.

The old "osd pool delete" command won't allow user to do this.

Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>

mon/OSDMonitor: sanity check osd number before applying pg-temp

In case user did something stupid and causing weird results.

Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>

doc: fix link for ceph-mgr cephx authorization

Signed-off-by: Greg Farnum <gfarnum@redhat.com>

zlib: remove g_ceph_context/g_conf from compressor plugin

Signed-off-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #16177 from Synesis-LLC/fix_rgw_crash_ec_data_pool

rgw: fix not initialized vars which cause rgw crash with ec data pool

Reviewed-by: Yehuda Sadeh <yehuda@redhat.com>

Merge pull request #15467 from joke-lee/fix-aws-v2-signature-X-Amz-Date-priority

rgw：fix s3 aws v2 signature priority between header['X-Amz-Date'] and header['Date']

Reviewed-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #16033 from zhaochao/rgw-add-a-new-errcode-for-non-existed-user

rgw: add a new error code for non-existed user.

Reviewed-by: Jos Collin <jcollin@redhat.com>

Merge pull request #16185 from smithfarm/wip-lease-stack-spawn

rgw: lease_stack: use reset method instead of assignment

Reviewed-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #16204 from jimifm/wip-rgw_frontend

rgw/rgw_frontend.h: Return negative value for empty uid in RGWLoadGenFrontend::init()

Reviewed-by: Jos Collin <jcollin@redhat.com>

Merge pull request #16016 from liewegas/wip-osd-df

mon: include device class in tree view; hide shadow hierarchy

Reviewed-by: Kefu Chai <kchai@redhat.com>

qa/tasks/ceph.py: no osd id to 'osd create' command

This isn't recognized by hammer, and we don't need it for jewel.

Fixes: http://tracker.ceph.com/issues/20548
Signed-off-by: Sage Weil <sage@redhat.com>

doc/start/quick-ceph-deploy: fix typos etc

Signed-off-by: Sage Weil <sage@redhat.com>

Merge pull request #15858 from liewegas/wip-mgr-servicemap

mgr,librados: service map

Reviewed-by: John Spray <john.spray@redhat.com>

doc/start/intro: add parens to cephfs section

Signed-off-by: Sage Weil <sage@redhat.com>

doc/mgr/dashboard: update dashboard docs to reflect new defaults

Also add not about load balancer.

Signed-off-by: Sage Weil <sage@redhat.com>

doc/start/quick-deph-deploy: update quick deploy instructions

- include mgr
- simplify
- remove references to old stuff as new

Signed-off-by: Sage Weil <sage@redhat.com>

doc/start/quick-ceph-deploy: drop redundant warning

This is part of preflight.

Signed-off-by: Sage Weil <sage@redhat.com>

doc/start: simplify quick start install process

Signed-off-by: Sage Weil <sage@redhat.com>