]> git.apps.os.sepia.ceph.com Git - ceph.git/log
ceph.git
5 years agocephadm: init config and keyring with None 34108/head
Kefu Chai [Sat, 21 Mar 2020 06:07:40 +0000 (14:07 +0800)]
cephadm: init config and keyring with None

and we should not assume that both `config` and `keying` are specified
when calling this method. because, for instance, `create_daemon_dirs()`
does handle the case where `config` and/or `keyring` is not specified.

this is a follow-up fix of 245d6a5cec9cc0f299613b8cc0415e494a4c3ac5

Signed-off-by: Kefu Chai <kchai@redhat.com>
Signed-off-by: Michael Fritch <mfritch@suse.com>
5 years agoMerge pull request #34071 from badone/wip-docker-test-helper-use-podman-by-default
Kefu Chai [Sun, 22 Mar 2020 02:41:23 +0000 (10:41 +0800)]
Merge pull request #34071 from badone/wip-docker-test-helper-use-podman-by-default

tests: Use podman if available

Reviewed-by: Kefu Chai <kchai@redhat.com>
5 years agoMerge pull request #34048 from tchaikov/wip-test-docker-fc31
Kefu Chai [Sun, 22 Mar 2020 02:40:16 +0000 (10:40 +0800)]
Merge pull request #34048 from tchaikov/wip-test-docker-fc31

tests: update Dockerfile to support fc-31

Reviewed-by: Brad Hubbard <bhubbard@redhat.com>
5 years agotests: Use podman if available 34071/head
Brad Hubbard [Fri, 20 Mar 2020 04:15:14 +0000 (14:15 +1000)]
tests: Use podman if available

Signed-off-by: Brad Hubbard <bhubbard@redhat.com>
5 years agoMerge pull request #34066 from mgfritch/cephadm-mon-b-test
Kefu Chai [Sat, 21 Mar 2020 06:34:28 +0000 (14:34 +0800)]
Merge pull request #34066 from mgfritch/cephadm-mon-b-test

qa/workunits/cephadm/test_cephadm.sh: fix mon.b failure

Reviewed-by: Sebastian Wagner <sebastian.wagner@suse.com>
Reviewed-by: Sage Weil <sage@redhat.com>
5 years agoMerge pull request #34022 from ifed01/wip-ifed-fix-leak-in-expand
Kefu Chai [Sat, 21 Mar 2020 06:32:15 +0000 (14:32 +0800)]
Merge pull request #34022 from ifed01/wip-ifed-fix-leak-in-expand

os/bluestore: fix extent leak after main device expand.

Reviewed-by: Adam Kupczyk <akucpzyk@redhat.com>
5 years agoMerge pull request #33883 from dragonylffly/wip-fix-comments
Kefu Chai [Sat, 21 Mar 2020 06:31:16 +0000 (14:31 +0800)]
Merge pull request #33883 from dragonylffly/wip-fix-comments

msg/async: fix log information

Reviewed-by: Kefu Chai <kchai@redhat.com>
5 years agoMerge pull request #33869 from mgfritch/cephadm-osd-create-test
Kefu Chai [Sat, 21 Mar 2020 06:30:23 +0000 (14:30 +0800)]
Merge pull request #33869 from mgfritch/cephadm-osd-create-test

qa/workunits/cephadm/test_cephadm.sh: move osd test to ceph-volume

Reviewed-by: Sebastian Wagner <sebastian.wagner@suse.com>
5 years agoMerge pull request #34097 from adamemerson/wip-boost-use-valgrind-fix
Kefu Chai [Sat, 21 Mar 2020 06:29:22 +0000 (14:29 +0800)]
Merge pull request #34097 from adamemerson/wip-boost-use-valgrind-fix

cmake: Don't enable BOOST_USE_VALGRIND when not requested

Reviewed-by: Kefu Chai <kchai@redhat.com>
5 years agoMerge pull request #34056 from xiexingguo/wip-44662
Kefu Chai [Sat, 21 Mar 2020 06:27:51 +0000 (14:27 +0800)]
Merge pull request #34056 from xiexingguo/wip-44662

qa/*/osd-markdown.sh: propagate map to osd before testing its reaction

Reviewed-by: Neha Ojha <nojha@redhat.com>
5 years agoMerge pull request #33796 from adamemerson/wip-using-namespace-common
Kefu Chai [Sat, 21 Mar 2020 02:33:16 +0000 (10:33 +0800)]
Merge pull request #33796 from adamemerson/wip-using-namespace-common

Build the target 'common' without relying on using namespace in headers

Reviewed-by: Kefu Chai <kchai@redhat.com>
5 years agoMerge pull request #33903 from tchaikov/wip-rados-object-locator
Kefu Chai [Sat, 21 Mar 2020 02:30:08 +0000 (10:30 +0800)]
Merge pull request #33903 from tchaikov/wip-rados-object-locator

tools/rados: use object-locator in user-visible outputs

Reviewed-by: Neha Ojha <nojha@redhat.com>
5 years agoMerge pull request #33976 from tchaikov/wip-build-doc-on-darwin
Kefu Chai [Sat, 21 Mar 2020 01:27:09 +0000 (09:27 +0800)]
Merge pull request #33976 from tchaikov/wip-build-doc-on-darwin

admin/build-doc, pybind/*/setup.py: support Darwin

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
5 years agoMerge pull request #34070 from bangmingcheng/wip-doc-ceph-chenbm
Xie Xingguo [Sat, 21 Mar 2020 01:01:29 +0000 (09:01 +0800)]
Merge pull request #34070 from bangmingcheng/wip-doc-ceph-chenbm

doc: fix a spelling error at /doc/radosgw/dynamicresharding.rst

Reviewed-by: Kefu Chai <kchai@redhat.com>
5 years agocmake: Don't enable BOOST_USE_VALGRIND when not requested 34097/head
Adam C. Emerson [Fri, 20 Mar 2020 18:10:14 +0000 (14:10 -0400)]
cmake: Don't enable BOOST_USE_VALGRIND when not requested

We were adding the define without support in the library if
WITH_BOOST_VALGRIND was turned off.

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
5 years agoMerge pull request #33841 from xiexingguo/wip-44507
Yuri Weinstein [Fri, 20 Mar 2020 15:23:14 +0000 (08:23 -0700)]
Merge pull request #33841 from xiexingguo/wip-44507

osd/PeeringState: fix pending want_acting vs osd offline race

Reviewed-by: Samuel Just <sjust@redhat.com>
5 years agoMerge pull request #32319 from jan--f/pybind-mgr-util-cephfs-con-pool
Sebastian Wagner [Fri, 20 Mar 2020 15:07:01 +0000 (16:07 +0100)]
Merge pull request #32319 from jan--f/pybind-mgr-util-cephfs-con-pool

mgr_util: add CephfsClient implementation

Reviewed-by: Sebastian Wagner <sebastian.wagner@suse.com>
Reviewed-by: Venky Shankar vshankar@redhat.com
5 years agoMerge pull request #33529 from rhcs-dashboard/wip-42979-fix-hover-issues
Avan [Fri, 20 Mar 2020 14:32:52 +0000 (20:02 +0530)]
Merge pull request #33529 from rhcs-dashboard/wip-42979-fix-hover-issues

mgr/dashboard: add popover list of Stand-by Managers & Metadata Servers (MDS) in landing page

5 years agoMerge pull request #34043 from adamemerson/wip-boost-valgrind
Kefu Chai [Fri, 20 Mar 2020 14:17:46 +0000 (22:17 +0800)]
Merge pull request #34043 from adamemerson/wip-boost-valgrind

cmake: Add WITH_BOOST_VALGRIND option

Reviewed-by: Kefu Chai <kchai@redhat.com>
5 years agoqa/workunits/cephadm/test_cephadm.sh: move osd test to ceph-volume 33869/head
Michael Fritch [Wed, 11 Mar 2020 00:40:07 +0000 (18:40 -0600)]
qa/workunits/cephadm/test_cephadm.sh: move osd test to ceph-volume

instead of via the orchestrator

Signed-off-by: Michael Fritch <mfritch@suse.com>
5 years agocephadm: allow config and keyring args for ceph-volume
Michael Fritch [Wed, 11 Mar 2020 00:38:29 +0000 (18:38 -0600)]
cephadm: allow config and keyring args for ceph-volume

easier to script via the cephadm tests

Signed-off-by: Michael Fritch <mfritch@suse.com>
5 years agoMerge pull request #34080 from sebastian-philipp/doc-osd-create-osd-apply
Sebastian Wagner [Fri, 20 Mar 2020 12:13:00 +0000 (13:13 +0100)]
Merge pull request #34080 from sebastian-philipp/doc-osd-create-osd-apply

doc/cephadm: replace `osd create` with `apply osd`

Reviewed-by: Nathan Cutler <ncutler@suse.com>
5 years agodoc/cephadm: replace `osd create` with `apply osd` 34080/head
Sebastian Wagner [Fri, 20 Mar 2020 11:33:27 +0000 (12:33 +0100)]
doc/cephadm: replace `osd create` with `apply osd`

Fixes: https://tracker.ceph.com/issues/44692
Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
5 years agotests: update Dockerfile to support fc-31 34048/head
Kefu Chai [Thu, 19 Mar 2020 03:21:48 +0000 (11:21 +0800)]
tests: update Dockerfile to support fc-31

Signed-off-by: Kefu Chai <kchai@redhat.com>
5 years agobuild: Add WITH_BOOST_VALGRIND option 34043/head
Adam C. Emerson [Wed, 18 Mar 2020 20:26:30 +0000 (16:26 -0400)]
build: Add WITH_BOOST_VALGRIND option

To build Boost.Context (and other libraries) with support to allow
them to be valground usefully, and to include the define to link
against them.

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
5 years agodoc: fix a spelling error at /doc/radosgw/dynamicresharding.rst 34070/head
bangmingcheng [Fri, 20 Mar 2020 02:23:01 +0000 (10:23 +0800)]
doc: fix a spelling error at /doc/radosgw/dynamicresharding.rst

Signed-off-by: bangmingcheng <bangmingcheng@gmail.com>
5 years agoqa/workunits/cephadm/test_cephadm.sh: fix mon.b failure 34066/head
Michael Fritch [Thu, 19 Mar 2020 19:43:56 +0000 (13:43 -0600)]
qa/workunits/cephadm/test_cephadm.sh: fix mon.b failure

and is_available check to ensure quorum

Signed-off-by: Michael Fritch <mfritch@suse.com>
5 years agoMerge PR #34060 into master
Sage Weil [Thu, 19 Mar 2020 16:07:16 +0000 (11:07 -0500)]
Merge PR #34060 into master

* refs/pull/34060/head:
Merge PR #34027 into octopus
Merge PR #34045 into octopus
Merge pull request #34035 from dillaman/wip-rbd-permissions
mgr/progress: fix duration strings
Merge PR #34014 into octopus
Merge PR #34001 into octopus
Merge PR #34011 into octopus
qa/workunits/rbd: use context managers to control Rados lifespan
Merge pull request #34032 from dillaman/wip-rbd-octopus-docs
doc/releases/octopus: add additional RBD improvements
qa/workunits/cephadm/test_cephadm: mark services unmanaged for test
mgr/cephadm: do not reconfig unmanaged services
Merge PR #33981 into octopus
Merge pull request #34018 from ajarr/octopus-subvolume-clone-cancel
qa/workunits/cephadm/test_cephadm: output file for pub key
Merge PR #33866 into octopus
Merge PR #34005 into octopus
Merge PR #34013 into octopus
mgr/cephadm: pytest: Enable SpecStore
mgr/orchestrator: add test for default implementation for apply()
python-common: validate ServiceSpec.service_type
fixup mgr/cephadm: Fix ceph orch apply -i
mgr/dashbaord: orchestrator service: Revert wait_api_result to a single completion
mgr/orchestrator: `orch daemon add` accepts a yaml
mgr/cephadm: apply_drivegroups() returns a single Completion
mgr/cephadm: remove `trivial_result()`
mgr/cephadm: Fix `ceph orch apply -i`
Merge pull request #33994 from dillaman/wip-librbd-poll-event-race
doc: document `clone cancel` command
test: add `clone cancel` tests
mgr/volumes: introduce "clone cancel" volume command
mgr/volumes: allow canceling a single asynchronous job for a volume
mgr/volumes: helper for looking up a clone entry index
mgr/volumes: periodically check if clone operations should be canceled
mgr/volumes: periodically check if copy operations should be canceled
mgr/volumes: introduce 'canceled' state in clone op state machine
qa/suites/rados/verify/validater/valgrind: tolerate SLOW_OPS
qa/suites/rados/verify/validater/valgrind: less bluestore logging
qa/suites/rados/verify/validater: increase heartbeat grace
Revert "qa/suites/rados/verify: debug_ms = 1, osd_heartbeat_grace = 60"
Revert "qa/suites/rados/verify/validator/valgrind: debug refs = 5"
ceph_test_watch_notify: try notify 10x if ALLOW_TIMEOUTS is set
ceph_test_rados_api_misc: ShutdownRace timeout if ALLOW_TIMEOUTS is set
qa/suites/rados/verify: set ALLOW_TIMEOUTS for workunits
doc/install: edits
doc/cephadm: more edits
doc/cephadm/install: edits
doc/cephadm/adoption: improvements
doc/cephadm/install: a few edits
doc/cephadm/install: do not install ceph-common on host (by default)
doc/cephadm: drop os recs link
doc/cephadm/upgrade: improvements
doc/cephadm/upgrade: document upgrade
doc/cephadm/install: revamp install docs
doc: reorganize cephadm docs
doc/cephadm/administration: update docs on customizing SSH config
doc/cephadm/administration: add a note about the 'removed' dir
mgr/balancer: tolerate pgs outside of target weight map
qa/workunits/cephadm/test_cephadm: --skip-monitoring-stack
Merge PR #33974 into octopus
Merge PR #33442 into octopus
Merge PR #33997 into octopus
Merge PR #34000 into octopus
use quay octopus tip until 15.2 tag is available
python-common: reduce output of ServiceSpec.to_json()
python-common,mgr/cephadm: move assert_valid_host to service_spec
mgr/cephadm: add HostAssignment.validate()
mgr/dashboard: adapt create_osds interface change
mon/MgrMonitor: make 'mgr fail' work with no arguments
cephadm: add allow_ptrace option to enable SYS_PTRACE
update default container images
mgr/cephadm: limit number of times check host is performed in the serve loop
Merge PR #33961 into octopus
Merge PR #33952 into octopus
Merge PR #33990 into octopus
Merge PR #33955 into octopus
Merge PR #33936 into octopus
mgr/orch: add --all-available-devices to 'orch apply osd'
qa/workunits/cephadm: --skip-mon-network when using 127.0.0.1
cephadm: add tests
qa/tasks/cephadm: pass -v to bootstrap
mgr/cephadm: only try to place mons on hosts matching public_network
mgr/cephadm: keep track of host networks, ips
cephadm: automatically infer mon public_network, if we can
cephadm: add list-networks command
cephadm: bootstrap: deploy monitoring stack by default
librbd: defer event socket completion until after callback issued
cephadm: add-repo: add --version
mgr/cephadm: respect 'unmanaged' flag in spec
mgr/orch: orch ls: show <no spec> or <unmanaged> as appropriate
mgr/orch: orch ls: rename SPEC -> PLACEMENT
mgr/orch: add 'unmanaged' property to ServiceSpec
cephadm: rename distro args in repo methods
mgr/orch: combine 'orch daemon add <type> ...' into one command
mgr/orch: combine 'orch apply <type> [<placement>]' into one command

Reviewed-by: Laura Paduano <lpaduano@suse.com>
5 years agoMerge pull request #33925 from tspmelo/wip-update-npm
Lenz Grimmer [Thu, 19 Mar 2020 14:45:09 +0000 (15:45 +0100)]
Merge pull request #33925 from tspmelo/wip-update-npm

mgr/dashboard: Update Angular and fix npm audit

Reviewed-by: Kiefer Chang <kiefer.chang@suse.com>
5 years agoMerge PR #34027 into octopus 34060/head
Sage Weil [Thu, 19 Mar 2020 13:22:40 +0000 (08:22 -0500)]
Merge PR #34027 into octopus

* refs/pull/34027/head:
qa/workunits/cephadm/test_cephadm: mark services unmanaged for test
mgr/cephadm: do not reconfig unmanaged services
qa/workunits/cephadm/test_cephadm: output file for pub key

Reviewed-by: Sebastian Wagner <swagner@suse.com>
5 years agoMerge PR #34045 into octopus
Sage Weil [Thu, 19 Mar 2020 13:07:05 +0000 (08:07 -0500)]
Merge PR #34045 into octopus

* refs/pull/34045/head:
mgr/progress: fix duration strings

Reviewed-by: xie xingguo <xie.xingguo@zte.com.cn>
5 years agoMerge PR #34047 into master
Sage Weil [Thu, 19 Mar 2020 13:02:06 +0000 (08:02 -0500)]
Merge PR #34047 into master

* refs/pull/34047/head:
qa/standalone/osd/osd-backfill-stats.sh: get_latest_osdmap to propagate map change

Reviewed-by: xie xingguo <xie.xingguo@zte.com.cn>
Reviewed-by: Sage Weil <sage@redhat.com>
5 years agoMerge pull request #34017 from xxhdx1985126/wip-crimson-osd-report-failure
Kefu Chai [Thu, 19 Mar 2020 10:32:44 +0000 (18:32 +0800)]
Merge pull request #34017 from xxhdx1985126/wip-crimson-osd-report-failure

crimson/os/heartbeat: make Heartbeat::send_failures() safe

Reviewed-by: Kefu Chai <kchai@redhat.com>
5 years agoqa/*/osd-markdown.sh: propagate map to osd before testing its reaction 34056/head
xie xingguo [Thu, 19 Mar 2020 09:19:46 +0000 (17:19 +0800)]
qa/*/osd-markdown.sh: propagate map to osd before testing its reaction

Mon might fail to share the newest map with any of up osds, e.g.,
due to an injected broken pipe. Since we don't have any client
activities during the osd-markdown tests, osds might be unaware of
the map changes made through CLI. Make sure osds have pulled the
newest map down before we can test its reaction correctly.

Fixes: https://tracker.ceph.com/issues/44662
Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
5 years agoMerge pull request #34035 from dillaman/wip-rbd-permissions
Mykola Golub [Thu, 19 Mar 2020 08:43:57 +0000 (10:43 +0200)]
Merge pull request #34035 from dillaman/wip-rbd-permissions

qa/workunits/rbd: use context managers to control Rados lifespan

Reviewed-by: Mykola Golub <mgolub@suse.com>
5 years agocrimson/os/heartbeat: make Heartbeat::send_failures() safe 34017/head
Xuehan Xu [Wed, 18 Mar 2020 02:32:02 +0000 (10:32 +0800)]
crimson/os/heartbeat: make Heartbeat::send_failures() safe

Currently, Heartbeat::send_failures() invokes monc.send_message() in a
continuation which may be run asynchronously, risking involving a daggling
"monc" reference when OSD shuts down and MonClient is destroyed.

Signed-off-by: Xuehan Xu <xxhdx1985126@163.com>
5 years agoMerge pull request #34016 from tchaikov/wip-44658
Kefu Chai [Thu, 19 Mar 2020 02:10:28 +0000 (10:10 +0800)]
Merge pull request #34016 from tchaikov/wip-44658

ceph.spec.in: add build deps for Debug build of seastar

Reviewed-by: Greg Farnum <gfarnum@redhat.com>
5 years agomgr/progress: fix duration strings 34045/head
Sage Weil [Thu, 19 Mar 2020 00:04:14 +0000 (19:04 -0500)]
mgr/progress: fix duration strings

- simplify the code to just calculate the durations when we need them
(I'm not sure why we had those temporary strings!)
- use a nicer time delta format

Fixes: https://tracker.ceph.com/issues/44672
Signed-off-by: Sage Weil <sage@redhat.com>
5 years agoqa/standalone/osd/osd-backfill-stats.sh: get_latest_osdmap to propagate map change 34047/head
Neha [Wed, 18 Mar 2020 22:57:41 +0000 (22:57 +0000)]
qa/standalone/osd/osd-backfill-stats.sh: get_latest_osdmap to propagate map change

Fixes: https://tracker.ceph.com/issues/44518
Signed-off-by: Neha Ojha <nojha@redhat.com>
5 years agoMerge PR #34014 into octopus
Sage Weil [Wed, 18 Mar 2020 22:42:48 +0000 (17:42 -0500)]
Merge PR #34014 into octopus

* refs/pull/34014/head:
mgr/balancer: tolerate pgs outside of target weight map

Reviewed-by: xie xingguo <xie.xingguo@zte.com.cn>
5 years agoMerge PR #34001 into octopus
Sage Weil [Wed, 18 Mar 2020 22:42:10 +0000 (17:42 -0500)]
Merge PR #34001 into octopus

* refs/pull/34001/head:
mgr/cephadm: pytest: Enable SpecStore
mgr/orchestrator: add test for default implementation for apply()
python-common: validate ServiceSpec.service_type
fixup mgr/cephadm: Fix ceph orch apply -i
mgr/dashbaord: orchestrator service: Revert wait_api_result to a single completion
mgr/orchestrator: `orch daemon add` accepts a yaml
mgr/cephadm: apply_drivegroups() returns a single Completion
mgr/cephadm: remove `trivial_result()`
mgr/cephadm: Fix `ceph orch apply -i`

Reviewed-by: Sage Weil <sage@redhat.com>
5 years agomgr/dashboard: Update Angular and fix npm audits 33925/head
Tiago Melo [Thu, 12 Mar 2020 14:34:56 +0000 (13:34 -0100)]
mgr/dashboard: Update Angular and fix npm audits

This fixes a new audit problem found in older versions of "acorn"
and updates Angular to latest v8 version.

Fixes: https://tracker.ceph.com/issues/44580
Signed-off-by: Tiago Melo <tmelo@suse.com>
5 years agoMerge PR #34011 into octopus
Sage Weil [Wed, 18 Mar 2020 17:12:54 +0000 (12:12 -0500)]
Merge PR #34011 into octopus

* refs/pull/34011/head:
qa/suites/rados/verify/validater/valgrind: tolerate SLOW_OPS
qa/suites/rados/verify/validater/valgrind: less bluestore logging
qa/suites/rados/verify/validater: increase heartbeat grace
Revert "qa/suites/rados/verify: debug_ms = 1, osd_heartbeat_grace = 60"
Revert "qa/suites/rados/verify/validator/valgrind: debug refs = 5"
ceph_test_watch_notify: try notify 10x if ALLOW_TIMEOUTS is set
ceph_test_rados_api_misc: ShutdownRace timeout if ALLOW_TIMEOUTS is set
qa/suites/rados/verify: set ALLOW_TIMEOUTS for workunits

Reviewed-by: Brad Hubbard <bhubbard@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
5 years agoqa/workunits/rbd: use context managers to control Rados lifespan 34035/head
Jason Dillaman [Wed, 18 Mar 2020 16:54:16 +0000 (12:54 -0400)]
qa/workunits/rbd: use context managers to control Rados lifespan

There is a potential race between the expected exceptions being
thrown and Python shutting down racing with librados background
threads. Ensure that librados is properly shut down prior to
exiting Python.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>
5 years agoMerge pull request #34032 from dillaman/wip-rbd-octopus-docs
Mykola Golub [Wed, 18 Mar 2020 16:45:43 +0000 (18:45 +0200)]
Merge pull request #34032 from dillaman/wip-rbd-octopus-docs

doc/releases/octopus: add additional RBD improvements

Reviewed-by: Mykola Golub <mgolub@suse.com>
5 years agodoc/releases/octopus: add additional RBD improvements 34032/head
Jason Dillaman [Wed, 18 Mar 2020 16:16:28 +0000 (12:16 -0400)]
doc/releases/octopus: add additional RBD improvements

Signed-off-by: Jason Dillaman <dillaman@redhat.com>
5 years agoqa/workunits/cephadm/test_cephadm: mark services unmanaged for test 34027/head
Sage Weil [Wed, 18 Mar 2020 15:12:59 +0000 (10:12 -0500)]
qa/workunits/cephadm/test_cephadm: mark services unmanaged for test

We are deploying containers manually.  Mark them unmanaged so that we
do not fight against mgr/cephadm cleaning up orphan daemons.

Signed-off-by: Sage Weil <sage@redhat.com>
5 years agomgr/cephadm: do not reconfig unmanaged services
Sage Weil [Wed, 18 Mar 2020 15:09:00 +0000 (10:09 -0500)]
mgr/cephadm: do not reconfig unmanaged services

Fixes: https://tracker.ceph.com/issues/44615
Signed-off-by: Sage Weil <sage@redhat.com>
5 years agoMerge PR #33981 into octopus
Sage Weil [Wed, 18 Mar 2020 14:45:16 +0000 (09:45 -0500)]
Merge PR #33981 into octopus

* refs/pull/33981/head:
doc/install: edits
doc/cephadm: more edits
doc/cephadm/install: edits
doc/cephadm/adoption: improvements
doc/cephadm/install: a few edits
doc/cephadm/install: do not install ceph-common on host (by default)
doc/cephadm: drop os recs link
doc/cephadm/upgrade: improvements
doc/cephadm/upgrade: document upgrade
doc/cephadm/install: revamp install docs
doc: reorganize cephadm docs
doc/cephadm/administration: update docs on customizing SSH config
doc/cephadm/administration: add a note about the 'removed' dir

Reviewed-by: Sebastian Wagner <swagner@suse.com>
5 years agoMerge pull request #34018 from ajarr/octopus-subvolume-clone-cancel
Ramana Raja [Wed, 18 Mar 2020 13:52:06 +0000 (19:22 +0530)]
Merge pull request #34018 from ajarr/octopus-subvolume-clone-cancel

mgr/volumes: add FS subvolume clone cancel

Reviewed-by: Ramana Raja <rraja@redhat.com>
5 years agoqa/workunits/cephadm/test_cephadm: output file for pub key
Sage Weil [Wed, 18 Mar 2020 13:44:10 +0000 (08:44 -0500)]
qa/workunits/cephadm/test_cephadm: output file for pub key

Signed-off-by: Sage Weil <sage@redhat.com>
5 years agoMerge PR #33866 into octopus
Sage Weil [Wed, 18 Mar 2020 13:14:19 +0000 (08:14 -0500)]
Merge PR #33866 into octopus

* refs/pull/33866/head:
mgr/cephadm: limit number of times check host is performed in the serve loop

Reviewed-by: Sebastian Wagner <swagner@suse.com>
5 years agoMerge PR #34005 into octopus
Sage Weil [Wed, 18 Mar 2020 13:14:06 +0000 (08:14 -0500)]
Merge PR #34005 into octopus

* refs/pull/34005/head:
python-common: reduce output of ServiceSpec.to_json()
python-common,mgr/cephadm: move assert_valid_host to service_spec
mgr/cephadm: add HostAssignment.validate()

Reviewed-by: Sage Weil <sage@redhat.com>
5 years agoMerge PR #34013 into octopus
Sage Weil [Wed, 18 Mar 2020 13:13:56 +0000 (08:13 -0500)]
Merge PR #34013 into octopus

* refs/pull/34013/head:
qa/workunits/cephadm/test_cephadm: --skip-monitoring-stack

Reviewed-by: Michael Fritch <mfritch@suse.com>
5 years agoos/bluestore: fix extent leak after main device expand. 34022/head
Igor Fedotov [Wed, 18 Mar 2020 11:35:55 +0000 (14:35 +0300)]
os/bluestore: fix extent leak after main device expand.

To reproduce the issue one can expand device of 3,147,480,064 bytes to
4,147,480,064 using bluefs-bdev-expand command.
Subsequent fsck will detect the leakage.

Signed-off-by: Igor Fedotov <ifedotov@suse.com>
5 years agomgr/cephadm: pytest: Enable SpecStore 34001/head
Sebastian Wagner [Wed, 18 Mar 2020 12:18:53 +0000 (13:18 +0100)]
mgr/cephadm: pytest: Enable SpecStore

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
5 years agomgr/orchestrator: add test for default implementation for apply()
Sebastian Wagner [Wed, 18 Mar 2020 12:02:12 +0000 (13:02 +0100)]
mgr/orchestrator: add test for default implementation for apply()

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
5 years agopython-common: validate ServiceSpec.service_type
Sebastian Wagner [Wed, 18 Mar 2020 10:25:50 +0000 (11:25 +0100)]
python-common: validate ServiceSpec.service_type

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
5 years agofixup mgr/cephadm: Fix ceph orch apply -i
Sebastian Wagner [Wed, 18 Mar 2020 10:25:11 +0000 (11:25 +0100)]
fixup mgr/cephadm: Fix ceph orch apply -i

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
5 years agoMerge pull request #33787 from jan--f/c-v-prepare-slots
Jan Fajerski [Wed, 18 Mar 2020 12:04:16 +0000 (13:04 +0100)]
Merge pull request #33787 from jan--f/c-v-prepare-slots

ceph-volume: prepare: use *-slots arguments for implicit sizing

5 years agoMerge pull request #33760 from tspmelo/wip-update-prettier
Lenz Grimmer [Wed, 18 Mar 2020 11:24:00 +0000 (12:24 +0100)]
Merge pull request #33760 from tspmelo/wip-update-prettier

mgr/dashboard: Update prettier

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Stephan Müller <smueller@suse.com>
5 years agomgr/dashbaord: orchestrator service: Revert wait_api_result to a single completion
Sebastian Wagner [Wed, 18 Mar 2020 09:52:38 +0000 (10:52 +0100)]
mgr/dashbaord: orchestrator service: Revert wait_api_result to a single completion

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
5 years agomgr/orchestrator: `orch daemon add` accepts a yaml
Sebastian Wagner [Tue, 17 Mar 2020 11:11:36 +0000 (12:11 +0100)]
mgr/orchestrator: `orch daemon add` accepts a yaml

Fixes: https://tracker.ceph.com/issues/44622
Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
5 years agomgr/cephadm: apply_drivegroups() returns a single Completion
Sebastian Wagner [Tue, 17 Mar 2020 10:52:54 +0000 (11:52 +0100)]
mgr/cephadm: apply_drivegroups() returns a single Completion

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
5 years agomgr/cephadm: remove `trivial_result()`
Sebastian Wagner [Tue, 17 Mar 2020 10:44:02 +0000 (11:44 +0100)]
mgr/cephadm: remove `trivial_result()`

Replaced with `@trivial_completion`, otherwise
`self._apply()` would have needed to accept a list
of specs.

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
5 years agomgr/cephadm: Fix `ceph orch apply -i`
Sebastian Wagner [Tue, 17 Mar 2020 10:33:20 +0000 (11:33 +0100)]
mgr/cephadm: Fix `ceph orch apply -i`

* We had two implementations for `ceph orcha apply`
* Remove yaml pasing in `mgr/cephadm`

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
5 years agoMerge pull request #34010 from grinapo/patch-1
Kefu Chai [Wed, 18 Mar 2020 08:27:30 +0000 (16:27 +0800)]
Merge pull request #34010 from grinapo/patch-1

doc/rbd: s/use use/use/

Reviewed-by: Kefu Chai <kchai@redhat.com>
5 years agoMerge pull request #33994 from dillaman/wip-librbd-poll-event-race
Mykola Golub [Wed, 18 Mar 2020 08:08:25 +0000 (10:08 +0200)]
Merge pull request #33994 from dillaman/wip-librbd-poll-event-race

librbd: defer event socket completion until after callback issued

Reviewed-by: Dehao Shang <dehao.shang@intel.com>
Reviewed-by: Mykola Golub <mgolub@suse.com>
5 years agodoc/rbd: s/use use/use/ 34010/head
Peter Gervai [Tue, 17 Mar 2020 17:00:51 +0000 (18:00 +0100)]
doc/rbd: s/use use/use/

just a typo, really.

Signed-off-by: Peter Gervai <grin@grin.hu>
5 years agodoc: document `clone cancel` command 34018/head
Venky Shankar [Tue, 25 Feb 2020 07:29:54 +0000 (02:29 -0500)]
doc: document `clone cancel` command

Fixes: http://tracker.ceph.com/issues/44208
Signed-off-by: Venky Shankar <vshankar@redhat.com>
5 years agotest: add `clone cancel` tests
Venky Shankar [Tue, 4 Feb 2020 10:02:56 +0000 (05:02 -0500)]
test: add `clone cancel` tests

Signed-off-by: Venky Shankar <vshankar@redhat.com>
5 years agomgr/volumes: introduce "clone cancel" volume command
Venky Shankar [Tue, 14 Jan 2020 09:20:50 +0000 (04:20 -0500)]
mgr/volumes: introduce "clone cancel" volume command

Signed-off-by: Venky Shankar <vshankar@redhat.com>
5 years agomgr/volumes: allow canceling a single asynchronous job for a volume
Venky Shankar [Tue, 14 Jan 2020 09:19:42 +0000 (04:19 -0500)]
mgr/volumes: allow canceling a single asynchronous job for a volume

Signed-off-by: Venky Shankar <vshankar@redhat.com>
5 years agomgr/volumes: helper for looking up a clone entry index
Venky Shankar [Tue, 14 Jan 2020 09:10:22 +0000 (04:10 -0500)]
mgr/volumes: helper for looking up a clone entry index

... this would be used when canceling a clone operation to
find the clone index for a given clone.

Signed-off-by: Venky Shankar <vshankar@redhat.com>
5 years agomgr/volumes: periodically check if clone operations should be canceled
Venky Shankar [Wed, 8 Jan 2020 06:07:03 +0000 (01:07 -0500)]
mgr/volumes: periodically check if clone operations should be canceled

Signed-off-by: Venky Shankar <vshankar@redhat.com>
5 years agomgr/volumes: periodically check if copy operations should be canceled
Venky Shankar [Wed, 8 Jan 2020 06:00:20 +0000 (01:00 -0500)]
mgr/volumes: periodically check if copy operations should be canceled

Signed-off-by: Venky Shankar <vshankar@redhat.com>
5 years agomgr/volumes: introduce 'canceled' state in clone op state machine
Venky Shankar [Tue, 14 Jan 2020 09:13:16 +0000 (04:13 -0500)]
mgr/volumes: introduce 'canceled' state in clone op state machine

When fetching the next execution state, -EINTR jumps to 'canceled'
state signifying a canceled (interrupted) operation. Also include
a helper routine to check if a given state machine is in initial
state.

Signed-off-by: Venky Shankar <vshankar@redhat.com>
5 years agoceph.spec.in: add build deps for Debug build of seastar 34016/head
Kefu Chai [Wed, 18 Mar 2020 02:29:54 +0000 (10:29 +0800)]
ceph.spec.in: add build deps for Debug build of seastar

it's a regression introduced by
6158bcfdef91cc2930c57ff2bbe2bfae37da7363, which dropped the change to
make Sanitizers optional

since we've switched from xenial to bionic. there is no need to disable
this anymore. we ran into an issue caused by the ancient linker shipped
by xenial before.

Fixes: https://tracker.ceph.com/issues/44658
Signed-off-by: Kefu Chai <kchai@redhat.com>
5 years agoqa/suites/rados/verify/validater/valgrind: tolerate SLOW_OPS 34011/head
Sage Weil [Tue, 17 Mar 2020 23:10:37 +0000 (18:10 -0500)]
qa/suites/rados/verify/validater/valgrind: tolerate SLOW_OPS

Signed-off-by: Sage Weil <sage@redhat.com>
5 years agoqa/suites/rados/verify/validater/valgrind: less bluestore logging
Sage Weil [Tue, 17 Mar 2020 21:36:46 +0000 (16:36 -0500)]
qa/suites/rados/verify/validater/valgrind: less bluestore logging

Signed-off-by: Sage Weil <sage@redhat.com>
5 years agoqa/suites/rados/verify/validater: increase heartbeat grace
Sage Weil [Tue, 17 Mar 2020 21:35:21 +0000 (16:35 -0500)]
qa/suites/rados/verify/validater: increase heartbeat grace

Signed-off-by: Sage Weil <sage@redhat.com>
5 years agoRevert "qa/suites/rados/verify: debug_ms = 1, osd_heartbeat_grace = 60"
Sage Weil [Tue, 17 Mar 2020 21:34:49 +0000 (16:34 -0500)]
Revert "qa/suites/rados/verify: debug_ms = 1, osd_heartbeat_grace = 60"

This reverts commit 4f742f200df6c91db87bfee1109c37fad3c0548b.

This was in the wrong file.. see valgrind.yaml

Signed-off-by: Sage Weil <sage@redhat.com>
5 years agoRevert "qa/suites/rados/verify/validator/valgrind: debug refs = 5"
Sage Weil [Tue, 17 Mar 2020 21:34:08 +0000 (16:34 -0500)]
Revert "qa/suites/rados/verify/validator/valgrind: debug refs = 5"

This reverts commit 65e81e6eb4f136bf21b67e5de10ab49f028f9e95.

This slows things down too much with valgrind.

Signed-off-by: Sage Weil <sage@redhat.com>
5 years agoceph_test_watch_notify: try notify 10x if ALLOW_TIMEOUTS is set
Sage Weil [Tue, 17 Mar 2020 16:51:56 +0000 (11:51 -0500)]
ceph_test_watch_notify: try notify 10x if ALLOW_TIMEOUTS is set

See https://tracker.ceph.com/issues/44062

Signed-off-by: Sage Weil <sage@redhat.com>
5 years agoceph_test_rados_api_misc: ShutdownRace timeout if ALLOW_TIMEOUTS is set
Sage Weil [Tue, 17 Mar 2020 16:52:32 +0000 (11:52 -0500)]
ceph_test_rados_api_misc: ShutdownRace timeout if ALLOW_TIMEOUTS is set

See https://tracker.ceph.com/issues/44582

Signed-off-by: Sage Weil <sage@redhat.com>
5 years agoqa/suites/rados/verify: set ALLOW_TIMEOUTS for workunits
Sage Weil [Tue, 17 Mar 2020 16:45:17 +0000 (11:45 -0500)]
qa/suites/rados/verify: set ALLOW_TIMEOUTS for workunits

When running under valgrind (and thrashing) things can be slow.  Tell
tests in case they need to tolerate timeouts.

Signed-off-by: Sage Weil <sage@redhat.com>
5 years agodoc/install: edits 33981/head
Sage Weil [Tue, 17 Mar 2020 13:58:57 +0000 (08:58 -0500)]
doc/install: edits

Based on review by Alexandra Settle <asettle@suse.com>

Signed-off-by: Sage Weil <sage@redhat.com>
5 years agodoc/cephadm: more edits
Sage Weil [Tue, 17 Mar 2020 13:54:47 +0000 (08:54 -0500)]
doc/cephadm: more edits

Based on review by Alexandra Settle <asettle@suse.com>

Signed-off-by: Sage Weil <sage@redhat.com>
5 years agodoc/cephadm/install: edits
Sage Weil [Tue, 17 Mar 2020 13:45:10 +0000 (08:45 -0500)]
doc/cephadm/install: edits

Based on review from Alexandra Settle <asettle@suse.com>

Signed-off-by: Sage Weil <sage@redhat.com>
5 years agodoc/cephadm/adoption: improvements
Sage Weil [Tue, 17 Mar 2020 13:23:26 +0000 (08:23 -0500)]
doc/cephadm/adoption: improvements

Signed-off-by: Sage Weil <sage@redhat.com>
5 years agodoc/cephadm/install: a few edits
Sage Weil [Mon, 16 Mar 2020 16:37:04 +0000 (11:37 -0500)]
doc/cephadm/install: a few edits

Signed-off-by: Sage Weil <sage@redhat.com>
5 years agodoc/cephadm/install: do not install ceph-common on host (by default)
Sage Weil [Mon, 16 Mar 2020 13:12:36 +0000 (08:12 -0500)]
doc/cephadm/install: do not install ceph-common on host (by default)

Signed-off-by: Sage Weil <sage@redhat.com>
5 years agodoc/cephadm: drop os recs link
Sage Weil [Mon, 16 Mar 2020 02:27:57 +0000 (21:27 -0500)]
doc/cephadm: drop os recs link

This mostly doesn't quite apply to cephadm because we use containers.

Signed-off-by: Sage Weil <sage@redhat.com>
5 years agodoc/cephadm/upgrade: improvements
Sage Weil [Mon, 16 Mar 2020 02:25:07 +0000 (21:25 -0500)]
doc/cephadm/upgrade: improvements

Signed-off-by: Sage Weil <sage@redhat.com>
5 years agodoc/cephadm/upgrade: document upgrade
Sage Weil [Sun, 15 Mar 2020 21:38:42 +0000 (16:38 -0500)]
doc/cephadm/upgrade: document upgrade

Signed-off-by: Sage Weil <sage@redhat.com>
5 years agodoc/cephadm/install: revamp install docs
Sage Weil [Sun, 15 Mar 2020 16:10:50 +0000 (11:10 -0500)]
doc/cephadm/install: revamp install docs

Signed-off-by: Sage Weil <sage@redhat.com>
5 years agodoc: reorganize cephadm docs
Sage Weil [Sun, 15 Mar 2020 13:45:46 +0000 (08:45 -0500)]
doc: reorganize cephadm docs

- reorganized cephadm into a top-level item with a series of sub-items.
- condensed the 'install' page so that it doesn't create a zillion items
in the toctree on the left
- started updating the cephadm/install sequence (incomplete)

Signed-off-by: Sage Weil <sage@redhat.com>
5 years agodoc/cephadm/administration: update docs on customizing SSH config
Sage Weil [Sat, 14 Mar 2020 14:33:01 +0000 (09:33 -0500)]
doc/cephadm/administration: update docs on customizing SSH config

Signed-off-by: Sage Weil <sage@redhat.com>
5 years agodoc/cephadm/administration: add a note about the 'removed' dir
Sage Weil [Sat, 14 Mar 2020 14:16:38 +0000 (09:16 -0500)]
doc/cephadm/administration: add a note about the 'removed' dir

(and other paths)

Signed-off-by: Sage Weil <sage@redhat.com>
5 years agomgr/balancer: tolerate pgs outside of target weight map 34014/head
Sage Weil [Tue, 17 Mar 2020 20:03:32 +0000 (15:03 -0500)]
mgr/balancer: tolerate pgs outside of target weight map

We build a target weight map based on the primary crush weights, and
ignore weights that are 0.  However, it's possible that existing PGs are
on other OSDs that have weight 0 because the weight-set weight is >0.
That leads to a KeyError exception when we

                     pgs_by_osd[osd] += 1

and the key isn't present.  Fix by simply populating those keys as we
encounter OSDs.  Drop the old initialization loop.  The net of this is
we may have OSDs outside of target_by_root (won't matter, as far as I can
tell) and we won't have keys for osds with weight 0 (also won't matter,
as far as I can tell).

Fixes: https://tracker.ceph.com/issues/42721
Signed-off-by: Sage Weil <sage@redhat.com>