]> git.apps.os.sepia.ceph.com Git - ceph.git/log
ceph.git
22 months agomgr/dashboard: show a message to restart the rgw daemons after moving from single... 53805/head
Aashish Sharma [Tue, 26 Sep 2023 12:27:39 +0000 (17:57 +0530)]
mgr/dashboard: show a message to restart the rgw daemons after moving from single-site to multi-site

Fixes: https://tracker.ceph.com/issues/62984
Signed-off-by: Aashish Sharma <aasharma@redhat.com>
(cherry picked from commit ab06466aa2bb7ddc97ccc33acb3aa6ce35582f05)

22 months agoMerge pull request #53515 from yuvalif/wip-61642-reef
Yuri Weinstein [Tue, 3 Oct 2023 19:47:41 +0000 (12:47 -0700)]
Merge pull request #53515 from yuvalif/wip-61642-reef

reef: rgw/kafka: make sure that destroy is called after connection is removed

Reviewed-by: Casey Bodley <cbodley@redhat.com>
22 months agoMerge pull request #53599 from idryomov/wip-62711-reef
Yuri Weinstein [Tue, 3 Oct 2023 19:45:28 +0000 (12:45 -0700)]
Merge pull request #53599 from idryomov/wip-62711-reef

reef: qa/suites/{rbd,krbd}: disable POOL_APP_NOT_ENABLED health check

Reviewed-by: Ramana Raja <rraja@redhat.com>
22 months agoMerge pull request #53590 from cbodley/wip-62935-reef
Yuri Weinstein [Tue, 3 Oct 2023 19:44:49 +0000 (12:44 -0700)]
Merge pull request #53590 from cbodley/wip-62935-reef

reef: rgw/crypt: don't deref null manifest_bl

Reviewed-by: Shilpa Jagannath <smanjara@redhat.com>
22 months agoMerge pull request #53584 from cbodley/wip-62924-reef
Yuri Weinstein [Tue, 3 Oct 2023 19:44:14 +0000 (12:44 -0700)]
Merge pull request #53584 from cbodley/wip-62924-reef

reef: rgw/sal: get_placement_target_names() returns void

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
22 months agoMerge pull request #53514 from yuvalif/wip-61535-reef
Yuri Weinstein [Tue, 3 Oct 2023 19:43:08 +0000 (12:43 -0700)]
Merge pull request #53514 from yuvalif/wip-61535-reef

reef: RGW:notifications: persistent topics are not deleted via radosgw-admin

Reviewed-by: Shilpa Jagannath <smanjara@redhat.com>
22 months agoMerge pull request #53513 from yuvalif/wip-59496-reef
Yuri Weinstein [Tue, 3 Oct 2023 19:42:38 +0000 (12:42 -0700)]
Merge pull request #53513 from yuvalif/wip-59496-reef

reef: rgw/kafka: failed to reconnect to broker after idle timeout

Reviewed-by: Shilpa Jagannath <smanjara@redhat.com>
22 months agoMerge pull request #53510 from yuvalif/wip-62803-reef
Yuri Weinstein [Tue, 3 Oct 2023 19:42:03 +0000 (12:42 -0700)]
Merge pull request #53510 from yuvalif/wip-62803-reef

reef: rgw/notifications: allow cross tenant notification management

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
22 months agoMerge pull request #53509 from yuvalif/wip-62831-reef
Yuri Weinstein [Tue, 3 Oct 2023 19:41:37 +0000 (12:41 -0700)]
Merge pull request #53509 from yuvalif/wip-62831-reef

reef: RGW: add admin interfaces to get and delete notifications by bucket

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
22 months agoMerge pull request #53507 from yuvalif/wip-61484-reef
Yuri Weinstein [Tue, 3 Oct 2023 19:41:10 +0000 (12:41 -0700)]
Merge pull request #53507 from yuvalif/wip-61484-reef

reef: RGW: bucket notification - hide auto generated topics when listing topics

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
22 months agoMerge pull request #53466 from k0ste/wip-61439-reef
Yuri Weinstein [Tue, 3 Oct 2023 19:40:32 +0000 (12:40 -0700)]
Merge pull request #53466 from k0ste/wip-61439-reef

reef: rgw/multisite[archive zone]: fix storing of bucket instance info in the new bucket entrypoint

Reviewed-by: Shilpa Jagannath <smanjara@redhat.com>
22 months agoMerge pull request #53440 from trociny/wip-61871-reef
Yuri Weinstein [Tue, 3 Oct 2023 19:40:01 +0000 (12:40 -0700)]
Merge pull request #53440 from trociny/wip-61871-reef

reef: rgw: pick http_date in case of http_x_amz_date absence

Reviewed-by: Shilpa Jagannath <smanjara@redhat.com>
22 months agoMerge pull request #53437 from k0ste/wip-62825-reef
Yuri Weinstein [Tue, 3 Oct 2023 19:39:21 +0000 (12:39 -0700)]
Merge pull request #53437 from k0ste/wip-62825-reef

reef: RadosGW API: incorrect bucket quota in response to HEAD /{bucket}/?usage

Reviewed-by: Shilpa Jagannath <smanjara@redhat.com>
22 months agoMerge pull request #53398 from trociny/wip-62752-reef
Yuri Weinstein [Tue, 3 Oct 2023 19:33:43 +0000 (12:33 -0700)]
Merge pull request #53398 from trociny/wip-62752-reef

reef: rgw: fix 2 null versionID after convert_plain_entry_to_versioned

Reviewed-by: J. Eric Ivancich <ivancich@redhat.com>
22 months agoMerge pull request #53395 from trociny/wip-62306-reef
Yuri Weinstein [Tue, 3 Oct 2023 19:33:16 +0000 (12:33 -0700)]
Merge pull request #53395 from trociny/wip-62306-reef

reef: rgw/sync-policy: Correct "sync status" & "sync group" commands

Reviewed-by: J. Eric Ivancich <ivancich@redhat.com>
22 months agoMerge pull request #53377 from jzhu116-bloomberg/wip-59646-reef
Yuri Weinstein [Tue, 3 Oct 2023 19:32:07 +0000 (12:32 -0700)]
Merge pull request #53377 from jzhu116-bloomberg/wip-59646-reef

reef: rgw/notification: pass in bytes_transferred to populate object_size in sync notification

Reviewed-by: Yuval Lifshitz <ylifshit@redhat.com>
22 months agoMerge pull request #53375 from jzhu116-bloomberg/wip-59693-reef
Yuri Weinstein [Tue, 3 Oct 2023 19:31:40 +0000 (12:31 -0700)]
Merge pull request #53375 from jzhu116-bloomberg/wip-59693-reef

reef: rgw/notification: remove non x-amz-meta-* attributes from bucket notifications

Reviewed-by: Yuval Lifshitz <ylifshit@redhat.com>
22 months agoMerge pull request #53034 from galsalomon66/wip-62466-reef
Yuri Weinstein [Tue, 3 Oct 2023 19:30:13 +0000 (12:30 -0700)]
Merge pull request #53034 from galsalomon66/wip-62466-reef

reef: rgw/s3select: s3select fixes related to Trino/TPCDS benchmark and QE tests

Reviewed-by: Shilpa Jagannath <smanjara@redhat.com>
23 months agoMerge pull request #53293 from ajarr/wip-62687-reef
Yuri Weinstein [Tue, 3 Oct 2023 15:39:26 +0000 (08:39 -0700)]
Merge pull request #53293 from ajarr/wip-62687-reef

reef: librbd: kick ExclusiveLock state machine on client being blocklisted when waiting for lock

Reviewed-by: Ilya Dryomov <idryomov@redhat.com>
23 months agoMerge pull request #53276 from idryomov/wip-61707-reef
Yuri Weinstein [Tue, 3 Oct 2023 15:38:43 +0000 (08:38 -0700)]
Merge pull request #53276 from idryomov/wip-61707-reef

reef: librbd: make CreatePrimaryRequest remove any unlinked mirror snapshots

Reviewed-by: Ramana Raja <rraja@redhat.com>
23 months agoMerge pull request #53118 from adk3798/wip-61964-reef
Adam King [Mon, 2 Oct 2023 17:51:52 +0000 (13:51 -0400)]
Merge pull request #53118 from adk3798/wip-61964-reef

reef: mgr/cephadm: add is_host_<status> functions to HostCache

Reviewed-by: John Mulligan <jmulligan@redhat.com>
23 months agoMerge pull request #53748 from zdover23/wip-doc-2023-10-02-backport-53744-to-reef
Anthony D'Atri [Mon, 2 Oct 2023 13:40:18 +0000 (09:40 -0400)]
Merge pull request #53748 from zdover23/wip-doc-2023-10-02-backport-53744-to-reef

reef: doc/architecture: edit "Calculating PG IDs"

23 months agodoc/architecture: edit "Calculating PG IDs" 53748/head
Zac Dover [Sun, 1 Oct 2023 23:43:37 +0000 (09:43 +1000)]
doc/architecture: edit "Calculating PG IDs"

Edit the section "Calcluating PG IDs" in doc/architecture.rst.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 69a585fbf4fbf50eed784a248442f622f01120c9)

23 months agoMerge pull request #53742 from zdover23/wip-doc-2023-10-01-backport-53740-to-reef
Anthony D'Atri [Sun, 1 Oct 2023 13:04:15 +0000 (09:04 -0400)]
Merge pull request #53742 from zdover23/wip-doc-2023-10-01-backport-53740-to-reef

reef: doc/architecture: edit several sections

23 months agodoc/architecture: edit several sections 53742/head
Zac Dover [Sat, 30 Sep 2023 04:58:41 +0000 (14:58 +1000)]
doc/architecture: edit several sections

Edit the following sections in doc/architecture.rst:

 1. Dynamic Cluster Management
 2. About Pools
 3. Mapping PGs to OSDs

The tone of "Dynamic Cluster Management" remains a bit too close to the
tone of marketing material, in my opinion, but I will return to firm it
up when I have finished a once-over of architecture.rst.

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 9657c45fc12cd8522df72c9bb8820320758305e4)

23 months agoMerge pull request #53738 from zdover23/wip-doc-2023-09-30-backport-53726-to-reef
Anthony D'Atri [Sat, 30 Sep 2023 09:43:08 +0000 (05:43 -0400)]
Merge pull request #53738 from zdover23/wip-doc-2023-09-30-backport-53726-to-reef

reef: doc/architecture: edit "Replication"

23 months agodoc/architecture: edit "Replication" 53738/head
Zac Dover [Thu, 28 Sep 2023 21:37:40 +0000 (07:37 +1000)]
doc/architecture: edit "Replication"

Edit "Replication" in the "Smart Daemons Enable Hyperscale" section of
doc/architecture.rst.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 4cf22e195ab367eb65f95c2578d06919ebcd108f)

23 months agoMerge pull request #53730 from zdover23/wip-doc-2023-09-29-backport-53723-to-reef
zdover23 [Sat, 30 Sep 2023 00:09:18 +0000 (10:09 +1000)]
Merge pull request #53730 from zdover23/wip-doc-2023-09-29-backport-53723-to-reef

reef: doc/architecture: edit "Data Scrubbing"

Reviewed-by: Cole Mitchell <cole.mitchell.ceph@gmail.com>
23 months agoMerge pull request #52846 from lxbsz/wip-62201
Yuri Weinstein [Fri, 29 Sep 2023 12:41:53 +0000 (05:41 -0700)]
Merge pull request #52846 from lxbsz/wip-62201

reef: mds: skip forwarding request if the session were removed

Reviewed-by: Venky Shankar <vshankar@redhat.com>
23 months agoMerge pull request #52748 from mchangir/wip-61990-reef
Yuri Weinstein [Fri, 29 Sep 2023 12:41:22 +0000 (05:41 -0700)]
Merge pull request #52748 from mchangir/wip-61990-reef

reef: mgr/snap_schedule: allow retention spec 'n' to be user defined

Reviewed-by: Venky Shankar <vshankar@redhat.com>
23 months agoMerge pull request #52742 from batrick/wip-62269-reef
Yuri Weinstein [Fri, 29 Sep 2023 12:40:46 +0000 (05:40 -0700)]
Merge pull request #52742 from batrick/wip-62269-reef

reef: qa: wait for file to have correct size

Reviewed-by: Venky Shankar <vshankar@redhat.com>
23 months agoMerge pull request #52724 from kotreshhr/wip-62240-reef
Yuri Weinstein [Fri, 29 Sep 2023 12:40:08 +0000 (05:40 -0700)]
Merge pull request #52724 from kotreshhr/wip-62240-reef

reef: mds: Fix the linkmerge assert check

Reviewed-by: Venky Shankar <vshankar@redhat.com>
23 months agoMerge pull request #52681 from batrick/wip-62189-reef
Yuri Weinstein [Fri, 29 Sep 2023 12:39:33 +0000 (05:39 -0700)]
Merge pull request #52681 from batrick/wip-62189-reef

reef: mds: update mdlog perf counters during replay

Reviewed-by: Venky Shankar <vshankar@redhat.com>
23 months agoMerge pull request #52656 from joscollin/wip-62178-reef
Yuri Weinstein [Fri, 29 Sep 2023 12:38:57 +0000 (05:38 -0700)]
Merge pull request #52656 from joscollin/wip-62178-reef

reef: qa: fix cephfs-mirror unwinding and 'fs volume create/rm' order

Reviewed-by: Venky Shankar <vshankar@redhat.com>
23 months agoMerge pull request #52246 from batrick/wip-61800-reef
Yuri Weinstein [Fri, 29 Sep 2023 12:37:26 +0000 (05:37 -0700)]
Merge pull request #52246 from batrick/wip-61800-reef

reef: mon/MDSMonitor: plug paxos when maybe manipulating osdmap

Reviewed-by: Venky Shankar <vshankar@redhat.com>
23 months agodoc/architecture: edit "Data Scrubbing" 53730/head
Zac Dover [Thu, 28 Sep 2023 18:40:08 +0000 (04:40 +1000)]
doc/architecture: edit "Data Scrubbing"

Edit the "Data Scrubbing" listitem in the list of benefits conferred by
the use by OSDs of the aggregate power of the cluster, in the section
"Smart Daemons Enable Hyperscale" in doc/architecture.rst.

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit d7b991646fcd36a1df7456e8e82c9d54a01e50f9)

23 months agoMerge pull request #53727 from zdover23/wip-doc-2023-09-29-backport-53707-to-reef
Anthony D'Atri [Fri, 29 Sep 2023 02:53:24 +0000 (22:53 -0400)]
Merge pull request #53727 from zdover23/wip-doc-2023-09-29-backport-53707-to-reef

reef: doc/architecture: edit "OSD Membership and Status"

23 months agodoc/architecture: edit "OSD Membership and Status" 53727/head
Zac Dover [Thu, 28 Sep 2023 03:55:02 +0000 (13:55 +1000)]
doc/architecture: edit "OSD Membership and Status"

Edit "OSD Membership and Status" in the "Smart Daemons Enable
Hyperscale" section of doc/architecture.rst.

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit dbd85336b1aa3ef42cfc12495b3dc5142d4b8a28)

23 months agoMerge pull request #53506 from yuvalif/wip-62284-reef
Casey Bodley [Thu, 28 Sep 2023 18:36:50 +0000 (19:36 +0100)]
Merge pull request #53506 from yuvalif/wip-62284-reef

reef: rgw/amqp: skip idleness tests since it needs to sleep longer than 30s

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
23 months agoMerge pull request #53686 from zdover23/wip-doc-2023-09-27-backport-53685-to-reef
Anthony D'Atri [Wed, 27 Sep 2023 19:15:43 +0000 (15:15 -0400)]
Merge pull request #53686 from zdover23/wip-doc-2023-09-27-backport-53685-to-reef

reef: doc/architecture: edit "OSDs service clients directly"

23 months agoMerge pull request #53695 from rhcs-dashboard/wip-63002-reef
Avan [Wed, 27 Sep 2023 11:45:44 +0000 (17:15 +0530)]
Merge pull request #53695 from rhcs-dashboard/wip-63002-reef

reef: exporter: add ceph_daemon labels to labeled counters as well

Reviewed-by: Ilya Dryomov <idryomov@redhat.com>
23 months agoexporter: add ceph_daemon labels to labeled counters as well 53695/head
avanthakkar [Tue, 19 Sep 2023 08:18:43 +0000 (13:48 +0530)]
exporter: add ceph_daemon labels to labeled counters as well

Exporter missed adding the `ceph_daemon` or `instance_id`
labels(in case if rgw metrics) to the new labeled performance counters.

Fixes: https://tracker.ceph.com/issues/62874
Signed-off-by: avanthakkar <avanjohn@gmail.com>
(cherry picked from commit f061955f0beabcaa3dca0dbfb6a8c8e56c764a0b)

23 months agoMerge pull request #53669 from rhcs-dashboard/wip-62963-reef
Nizamudeen A [Wed, 27 Sep 2023 05:25:01 +0000 (10:55 +0530)]
Merge pull request #53669 from rhcs-dashboard/wip-62963-reef

reef: mgr/dashboard: fix prometheus queries subscriptions

Reviewed-by: Nizamudeen A <nia@redhat.com>
23 months agodoc/architecture: edit "OSDs service clients directly" 53686/head
Zac Dover [Tue, 26 Sep 2023 20:00:34 +0000 (06:00 +1000)]
doc/architecture: edit "OSDs service clients directly"

Edit "OSDs service clients directly" in the list in
"Smart Daemons Enable Hyperscale" in doc/architecure.rst.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 6f9dfd75b50f7793d2ff9bc3003c35efa6d6da04)

23 months agoMerge pull request #53659 from zdover23/wip-doc-2023-09-26-backport-53657-to-reef
Anthony D'Atri [Tue, 26 Sep 2023 18:36:28 +0000 (14:36 -0400)]
Merge pull request #53659 from zdover23/wip-doc-2023-09-26-backport-53657-to-reef

reef: doc/architecture: edit "SDEH"

23 months agorgw/amqp: skip idleness tests since it needs to sleep longer than 30s 53506/head
Yuval Lifshitz [Wed, 2 Aug 2023 10:19:00 +0000 (10:19 +0000)]
rgw/amqp: skip idleness tests since it needs to sleep longer than 30s

current idle timeout is 30s, so, making the test sleep for 30s may not
be enough. setting sleep time to be longer, and skippign the test so it
won't take too long.

Fixes: https://tracker.ceph.com/issues/62264
Signed-off-by: Yuval Lifshitz <ylifshit@redhat.com>
(cherry picked from commit 11439ecd8957cdf90b80fd52cc500372ffd24685)

23 months agomgr/dashboard: fix prometheus queries subscriptions 53669/head
Pedro Gonzalez Gomez [Mon, 18 Sep 2023 16:34:28 +0000 (18:34 +0200)]
mgr/dashboard: fix prometheus queries subscriptions

Fixes: https://tracker.ceph.com/issues/62868
Signed-off-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
(cherry picked from commit b7f25e63178080800f96f1cdcdd620fea200ea58)

23 months agodoc/architecture: edit "SDEH" 53659/head
Zac Dover [Mon, 25 Sep 2023 21:40:42 +0000 (07:40 +1000)]
doc/architecture: edit "SDEH"

Edit the front matter of the "Smart Daemons Enable Hyperscale" section
of doc/architecture.rst.

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 5054f6c7538e1e3b0ffd3c0badf0fcd3a95c8d92)

23 months agoMerge pull request #53652 from rhcs-dashboard/wip-62967-reef
Nizamudeen A [Mon, 25 Sep 2023 14:27:04 +0000 (19:57 +0530)]
Merge pull request #53652 from rhcs-dashboard/wip-62967-reef

reef: mgr/dashboard: remove empty popover when there are no health warns

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Ankush Behl <cloudbehl@gmail.com>
23 months agomgr/dashboard: remove empty popover when there are no health warns 53652/head
Nizamudeen A [Fri, 15 Sep 2023 06:40:24 +0000 (12:10 +0530)]
mgr/dashboard: remove empty popover when there are no health warns

Fixes: https://tracker.ceph.com/issues/62846
Signed-off-by: Nizamudeen A <nia@redhat.com>
(cherry picked from commit d7d142435863239751fb5e228d80fe4c44490aee)

23 months agoMerge pull request #53632 from zdover23/wip-doc-2023-09-25-backport-53631-to-reef
Anthony D'Atri [Mon, 25 Sep 2023 05:16:59 +0000 (01:16 -0400)]
Merge pull request #53632 from zdover23/wip-doc-2023-09-25-backport-53631-to-reef

reef: doc/architecture: edit "HA Authentication"

23 months agodoc/architecture: edit "HA Authentication" 53632/head
Zac Dover [Mon, 25 Sep 2023 04:34:06 +0000 (14:34 +1000)]
doc/architecture: edit "HA Authentication"

Edit "High Availability Authentication" in doc/architecture.rst.

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit cb680a7865c4766d54d535889ec1517a0e84b5b5)

23 months agoMerge pull request #53619 from zdover23/wip-doc-2023-09-24-backport-53613-to-reef
Anthony D'Atri [Sat, 23 Sep 2023 18:02:19 +0000 (14:02 -0400)]
Merge pull request #53619 from zdover23/wip-doc-2023-09-24-backport-53613-to-reef

reef: doc/architecture: "Edit HA Auth"

23 months agodoc/architecture: "Edit HA Auth" 53619/head
Zac Dover [Sat, 23 Sep 2023 02:26:18 +0000 (12:26 +1000)]
doc/architecture: "Edit HA Auth"

Rewrite the explanation of how a client authenticates against a monitor.
This is a rewrite of a single paragraph, and has been set apart in its
own PR so that it can receive the maximum amount of scrutiny that the
upstream Ceph community can muster.

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit c71cd84ec9e579ba0913c4952570bba6082e03b5)

23 months agoqa/suites/krbd: disable POOL_APP_NOT_ENABLED health check 53599/head
Ilya Dryomov [Fri, 15 Sep 2023 13:33:27 +0000 (15:33 +0200)]
qa/suites/krbd: disable POOL_APP_NOT_ENABLED health check

... same as for rbd suite.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit 0b68a8b4c07d1528190c71cda566b9d1fdb32640)

23 months agoqa/suites/rbd: drop POOL_APP_NOT_ENABLED from ignorelists
Ilya Dryomov [Fri, 15 Sep 2023 13:33:27 +0000 (15:33 +0200)]
qa/suites/rbd: drop POOL_APP_NOT_ENABLED from ignorelists

With "mon warn on pool no app = false" in the config, it's obviously
redundant.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit 9e884ddeecde4a3028803d207b1fab91706ebbf1)

23 months agoqa/suites/rbd: disable POOL_APP_NOT_ENABLED health check
Ilya Dryomov [Fri, 15 Sep 2023 13:33:27 +0000 (15:33 +0200)]
qa/suites/rbd: disable POOL_APP_NOT_ENABLED health check

Commit 990806e635a1 ("mon, qa: issue pool application warning even
if pool is empty") made it impossible to create a pool without raising
a (bogus) health alert.  See [1] for details.

[1] https://lists.ceph.io/hyperkitty/list/dev@ceph.io/thread/ZTDYC5HN677RR26EB4P6PORN6L2IFH4R/

Fixes: https://tracker.ceph.com/issues/62711
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit e64830eb8e94eafa42b0a5f6cacd5359db317a0b)

23 months agoMerge pull request #53543 from rhcs-dashboard/wip-62880-reef
Nizamudeen A [Fri, 22 Sep 2023 06:52:53 +0000 (12:22 +0530)]
Merge pull request #53543 from rhcs-dashboard/wip-62880-reef

reef: mgr/dashboard: align charts of landing page

Reviewed-by: Nizamudeen A <nia@redhat.com>
23 months agorgw/crypt: don't deref null manifest_bl 53590/head
Casey Bodley [Wed, 13 Sep 2023 20:30:03 +0000 (16:30 -0400)]
rgw/crypt: don't deref null manifest_bl

with dbstore, the manifest_bl pointer was null; check for null before
dereferencing for read_manifest_parts()

Fixes: https://tracker.ceph.com/issues/62378
Signed-off-by: Casey Bodley <cbodley@redhat.com>
(cherry picked from commit 04d9ea6dafb9ab0d71888b5ac9b1317c111e41ec)

23 months agoMerge pull request #53585 from zdover23/wip-doc-2023-09-22-backport-53493-to-reef
Anthony D'Atri [Thu, 21 Sep 2023 18:20:59 +0000 (14:20 -0400)]
Merge pull request #53585 from zdover23/wip-doc-2023-09-22-backport-53493-to-reef

reef: doc/architecture: "Edit HA Auth" (one of several)

23 months agodoc/architecture: "Edit HA Auth" (one of several) 53585/head
Zac Dover [Sun, 17 Sep 2023 20:41:28 +0000 (06:41 +1000)]
doc/architecture: "Edit HA Auth" (one of several)

Edit "High Availability Authentication" in doc/architecture.rst.

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 78804e1aadb4d1ad8273ff7dc50b0ea7bc72b686)

23 months agorgw/sal: get_placement_target_names() returns void 53584/head
Casey Bodley [Mon, 18 Sep 2023 15:15:02 +0000 (11:15 -0400)]
rgw/sal: get_placement_target_names() returns void

the function returned an integer error code, but two callers were
incorrectly testing the return value as a boolean

the function just returns placement ids that are in-memory, so none of
the drivers have a failure case; change the return value to void

Fixes: https://tracker.ceph.com/issues/62771
Signed-off-by: Casey Bodley <cbodley@redhat.com>
(cherry picked from commit 3ad17ed3b222701bb6f4e3150989584645789d7c)

23 months agoMerge pull request #53569 from zdover23/wip-doc-2023-09-21-backport-53176-to-reef
zdover23 [Thu, 21 Sep 2023 06:27:24 +0000 (16:27 +1000)]
Merge pull request #53569 from zdover23/wip-doc-2023-09-21-backport-53176-to-reef

reef: doc: add note for removing (automatic) partitioning policy

Reviewed-by: Venky Shankar <vshankar@redhat.com>
23 months agodoc: add note for removing (automatic) partitioning policy 53569/head
Venky Shankar [Mon, 28 Aug 2023 10:42:57 +0000 (16:12 +0530)]
doc: add note for removing (automatic) partitioning policy

Signed-off-by: Venky Shankar <vshankar@redhat.com>
(cherry picked from commit 20d027eb9d54ab4f6ba03dfc17d1c4c42eac1055)

23 months agomgr/dashboard: align charts of landing page 53543/head
Pedro Gonzalez Gomez [Tue, 12 Sep 2023 08:08:38 +0000 (10:08 +0200)]
mgr/dashboard: align charts of landing page

Fixes: https://tracker.ceph.com/issues/62813
Signed-off-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
(cherry picked from commit 2c04e9407152896ffd3cd435812df0221fba57c5)

23 months agoMerge pull request #53536 from zdover23/wip-doc-2023-09-20-backport-53532-to-reef
Anthony D'Atri [Wed, 20 Sep 2023 00:15:09 +0000 (20:15 -0400)]
Merge pull request #53536 from zdover23/wip-doc-2023-09-20-backport-53532-to-reef

reef: doc/man: s/kvstore-tool/monstore-tool/

23 months agodoc/man: s/kvstore-tool/monstore-tool/ 53536/head
Zac Dover [Tue, 19 Sep 2023 13:12:34 +0000 (23:12 +1000)]
doc/man: s/kvstore-tool/monstore-tool/

s/kvstore-tool/monstore-tool/ in accordance with Ilya's remark here:
https://github.com/ceph/ceph/pull/53450#discussion_r1329804085

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 231afc83131c366db46e9d0345f6928c1871ce4d)

23 months agoMerge pull request #52950 from k0ste/wip-61722-reef
Adam Kupczyk [Tue, 19 Sep 2023 13:30:02 +0000 (15:30 +0200)]
Merge pull request #52950 from k0ste/wip-61722-reef

reef: Bluestore: fix bluestore collection_list latency perf counter

23 months agoMerge pull request #53519 from zdover23/wip-doc-2023-09-19-backport-53518-to-reef
Anthony D'Atri [Mon, 18 Sep 2023 23:54:49 +0000 (19:54 -0400)]
Merge pull request #53519 from zdover23/wip-doc-2023-09-19-backport-53518-to-reef

reef: doc/dev: Fix typos in files cephfs-mirroring.rst and deduplication.rst

23 months agodoc/dev: Fix typos in files cephfs-mirroring.rst and deduplication.rst 53519/head
Daniel Parkes [Mon, 18 Sep 2023 21:03:28 +0000 (23:03 +0200)]
doc/dev: Fix typos in files cephfs-mirroring.rst and deduplication.rst

Typo Error in Doc cephfs-mirroring.rst , replace RAODS with RADOS
Typo Error in Doc deduplication.rst , replace RAODS with RADOS

Signed-off-by: Daniel Parkes <dparkes@redhat.com>
(cherry picked from commit 06358e8d17a0e0fbd5d94b14595ade778a4fb5eb)

23 months agorgw/kafka: make sure that destroy is called after connection is removed 53515/head
Yuval Lifshitz [Thu, 1 Jun 2023 06:13:06 +0000 (06:13 +0000)]
rgw/kafka: make sure that destroy is called after connection is removed

in addition. the dtor calls "destroy()", so there is no need to call
it explictly

Fixes: https://tracker.ceph.com/issues/61540
Signed-off-by: Yuval Lifshitz <ylifshit@redhat.com>
(cherry picked from commit 60412d6ab19f2ae42bdfaeaae0ff23dc011176ff)

Conflicts:
src/rgw/rgw_kafka.cc

23 months agoRGW:notifications: persistent topics are not deleted via radosgw-admin 53514/head
Ali Masarwa [Mon, 29 May 2023 14:40:15 +0000 (17:40 +0300)]
RGW:notifications: persistent topics are not deleted via radosgw-admin

Signed-off-by: Ali Masarwa <ali.saed.masarwa@gmail.com>
(cherry picked from commit 8374da4dde710f9e1678c1d2daff895bb084bc20)

23 months agorgw/kafka: failed to reconnect to broker after idle timeout 53513/head
Yuval Lifshitz [Sun, 9 Apr 2023 17:58:18 +0000 (17:58 +0000)]
rgw/kafka: failed to reconnect to broker after idle timeout

This is a regression due to: 8713c3169c0f9df1d2fc23ff2b82ede1e25be282

To reproduce, define a topic and a notification pointing to a kafka broker.
Stop the broker and upload objects to the cluster, wait for 30 seconds, and then start the broker.

Fixes: https://tracker.ceph.com/issues/59383?next_issue_id=59381
Signed-off-by: Yuval Lifshitz <ylifshit@redhat.com>
(cherry picked from commit 054ddb2435d73070f3de717a6ad5a312351f4a45)

Conflicts:
src/rgw/rgw_kafka.cc

23 months agorgw/notifications: allow cross tenant notification management 53510/head
Yuval Lifshitz [Sun, 10 Sep 2023 14:40:37 +0000 (14:40 +0000)]
rgw/notifications: allow cross tenant notification management

testing instructions:
https://gist.github.com/yuvalif/60063dc67d981b387b382ff0f7f88d91

Fixes: https://tracker.ceph.com/issues/62784
Signed-off-by: Yuval Lifshitz <ylifshit@redhat.com>
(cherry picked from commit 25f82210abdcd33695b6330d6a8fc747490aac9d)

23 months agoRGW: add admin interfaces to get and delete notifications from bucket 53509/head
Ali Masarwa [Mon, 8 May 2023 13:55:01 +0000 (16:55 +0300)]
RGW: add admin interfaces to get and delete notifications from bucket

Signed-off-by: Ali Masarwa <ali.saed.masarwa@gmail.com>
(cherry picked from commit b0307db65f30ac4d40cd283bc175229f943d3e82)

23 months agoRGW: notification | hide auto generated topics when listing topics 53507/head
Ali Masarwa [Tue, 18 Apr 2023 11:49:55 +0000 (14:49 +0300)]
RGW: notification | hide auto generated topics when listing topics

Signed-off-by: Ali Masarwa <ali.saed.masarwa@gmail.com>
(cherry picked from commit 1186c477fbafc2e96d903e73349deebbd0b94ab7)

23 months agoMerge pull request #53491 from zdover23/wip-doc-2023-09-18-backport-53490-to-reef
Anthony D'Atri [Sun, 17 Sep 2023 21:11:55 +0000 (17:11 -0400)]
Merge pull request #53491 from zdover23/wip-doc-2023-09-18-backport-53490-to-reef

reef: doc/architecture: "Edit HA Auth" (one of several)

23 months agodoc/architecture: "Edit HA Auth" (one of several) 53491/head
Zac Dover [Sun, 17 Sep 2023 08:56:40 +0000 (18:56 +1000)]
doc/architecture: "Edit HA Auth" (one of several)

Edit "High Availability Authentication" in doc/architecture.rst.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit e50c3e1c08ff09f44bb3a3b6f733b612b9f838d7)

23 months agoMerge pull request #53488 from zdover23/wip-doc-2023-09-17-backport-53487-to-reef
Anthony D'Atri [Sun, 17 Sep 2023 14:44:27 +0000 (10:44 -0400)]
Merge pull request #53488 from zdover23/wip-doc-2023-09-17-backport-53487-to-reef

reef: doc/architecture: Edit "HA Auth"

23 months agodoc/architecture: Edit "HA Auth" 53488/head
Zac Dover [Sat, 16 Sep 2023 12:27:29 +0000 (22:27 +1000)]
doc/architecture: Edit "HA Auth"

Edit "High Availability Authentication" in doc/architecture.rst.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 4cbef54bbaf363dd26a7d1711f3d839f88d4c2a8)

23 months agoMerge pull request #53413 from trociny/wip-62506-reef
Casey Bodley [Fri, 15 Sep 2023 15:35:09 +0000 (16:35 +0100)]
Merge pull request #53413 from trociny/wip-62506-reef

reef: rgw: handle http options CORS with v4 auth

Reviewed-by: Casey Bodley <cbodley@redhat.com>
23 months agoMerge pull request #53476 from zdover23/wip-doc-2023-09-15-backport-53450-to-reef
Anthony D'Atri [Fri, 15 Sep 2023 12:14:20 +0000 (08:14 -0400)]
Merge pull request #53476 from zdover23/wip-doc-2023-09-15-backport-53450-to-reef

reef: doc/man: edit ceph-monstore-tool.rst

23 months agodoc/man: edit ceph-monstore-tool.rst 53476/head
Zac Dover [Thu, 14 Sep 2023 03:24:11 +0000 (13:24 +1000)]
doc/man: edit ceph-monstore-tool.rst

Clean up the English in doc/man/8/ceph-monstore-tool.rst. Put all
commands in the imperative mood; make sentences more direct.

Follows https://github.com/ceph/ceph/pull/52860.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 02177f6368532c14b09f84e22efd64a7f7936b34)

23 months agoMerge pull request #53429 from kamoltat/wip-ksirivad-reef-backport-50334
Kamoltat (Junior) Sirivadhna [Thu, 14 Sep 2023 20:57:59 +0000 (16:57 -0400)]
Merge pull request #53429 from kamoltat/wip-ksirivad-reef-backport-50334

reef: pybind/mgr/pg_autoscaler: Reorderd if statement for the func: _maybe_adjust
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
23 months agorgw/multisite: store the bucket instance info in the new bucket entrypoint in case 53466/head
Shilpa Jagannath [Tue, 25 Apr 2023 21:27:45 +0000 (17:27 -0400)]
rgw/multisite: store the bucket instance info in the new bucket entrypoint in case
of archive zone.

Signed-off-by: Shilpa Jagannath <smanjara@redhat.com>
(cherry picked from commit 81728eeade9d2d12217242b3c5399b02106ea082)

23 months agoMerge pull request #53451 from zdover23/wip-doc-2023-09-14-backport-53444-to-reef
Anthony D'Atri [Thu, 14 Sep 2023 03:42:39 +0000 (23:42 -0400)]
Merge pull request #53451 from zdover23/wip-doc-2023-09-14-backport-53444-to-reef

reef: doc/architecture: edit "High Avail. Monitors"

23 months agodoc/architecture: edit "High Avail. Monitors" 53451/head
Zac Dover [Wed, 13 Sep 2023 14:09:45 +0000 (00:09 +1000)]
doc/architecture: edit "High Avail. Monitors"

Improve the sentence structure in the "High Availability Monitors"
section of doc/architecture.rst.

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 57019c346917e6f155d89452d768bd93bdd2e51c)

23 months agoMerge pull request #53434 from zdover23/wip-doc-2023-09-13-backport-53423-to-reef
zdover23 [Wed, 13 Sep 2023 14:21:51 +0000 (00:21 +1000)]
Merge pull request #53434 from zdover23/wip-doc-2023-09-13-backport-53423-to-reef

reef: doc/architecture: edit "Cluster Map"

Reviewed-by: Cole Mitchell <cole.mitchell.ceph@gmail.com>
23 months agorgw: pick http_date in case of http_x_amz_date absence 53440/head
Seena Fallah [Fri, 9 Jun 2023 12:14:24 +0000 (14:14 +0200)]
rgw: pick http_date in case of http_x_amz_date absence

From the AWS doc:
The request date can be specified by using either the HTTP Date or the x-amz-date header. If both headers are present, x-amz-date takes precedence.
Refs: https://docs.aws.amazon.com/AmazonS3/latest/API/sigv4-auth-using-authorization-header.html

Fixes: https://tracker.ceph.com/issues/61629
Signed-off-by: Seena Fallah <seenafallah@gmail.com>
(cherry picked from commit 912b7745181a221bc8468317c83f4c461933208e)

23 months agorgw: Fix potential null pointer dereferences where `RGWEnv::get()` is called
Mohamed Awnallah [Wed, 1 Mar 2023 16:59:33 +0000 (18:59 +0200)]
rgw: Fix potential null pointer dereferences where `RGWEnv::get()` is called

Here are the changes I've made:
- Added `RGWEnv::get_optional` with the similar implementation to the `RGWHTTPArgs::get_optional`
- Replaced `RGWEnv::get` in the RGW code where null pointer derefence happens with `RGWEnv::get_optional` as long as it accepts `std::string`
- Otherwise if calling function of `RGWEnv::get` accepts `char*` I leave it as it is
- Added null pointer checks to avoid the null pointer dereference

This commit addresses the following Coverity CIDs:
- "1510310"
- "1510928"
- "1511097"
- "1511555"
- "1511760"
- "1511951"
- "1512003"
- "1512138"
- "1512398"

Fixes: https://tracker.ceph.com/issues/57347
Signed-off-by: Mohamed Awnallah <mohamedmohey2352@gmail.com>
(cherry picked from commit b8cb558cc35d9fb5c47372a79c6249207a964245)

23 months agoRadosGW API: incorrect bucket quota in response to HEAD /{bucket}/?usage 53437/head
shreyanshjain7174 [Mon, 11 Sep 2023 10:40:33 +0000 (06:40 -0400)]
RadosGW API: incorrect bucket quota in response to HEAD /{bucket}/?usage

When we try to get the bucket usage via various methods, through curl or while accessing rgw api endpoint at HEAD /{bucket}/?usage doesn't return the updated information. The endpoint was always returning the user quota and not the actual bucket quota which we see after querying the endpoint.

Fixes: https://tracker.ceph.com/issues/62737
Signed-off-by: shreyanshjain7174 <ssanchet@redhat.com>
(cherry picked from commit 78cd82b6e9f36a91f47d44ad2cfae89add335d4c)

23 months agodoc/architecture: edit "Cluster Map" 53434/head
Zac Dover [Tue, 12 Sep 2023 11:17:40 +0000 (21:17 +1000)]
doc/architecture: edit "Cluster Map"

Edit the section "Cluster Map" in doc/architecture.rst.

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit cc8dce2531e8fac64345c4b85087f52149e9a9d0)

23 months agoMerge pull request #53427 from zdover23/wip-doc-2023-09-13-backport-53422-to-reef
Anthony D'Atri [Tue, 12 Sep 2023 18:58:10 +0000 (14:58 -0400)]
Merge pull request #53427 from zdover23/wip-doc-2023-09-13-backport-53422-to-reef

reef: doc/glossary: add "primary affinity" to glossary

23 months agoqa/workunits/mon/pg_autoscaler: Added bug-reproducer/test 53429/head
Kamoltat [Wed, 1 Mar 2023 21:07:54 +0000 (21:07 +0000)]
qa/workunits/mon/pg_autoscaler: Added bug-reproducer/test

Added a bug-reproducer/test to fix:

https://tracker.ceph.com/issues/58894

Signed-off-by: Kamoltat <ksirivad@redhat.com>
(cherry picked from commit 009430b5548db028fe8d48b2469544eca419b526)

23 months agopybind/mgr/pg_autoscaler: Reorderd if statement for the func: _maybe_adjust
Kamoltat [Wed, 1 Mar 2023 20:32:47 +0000 (20:32 +0000)]
pybind/mgr/pg_autoscaler: Reorderd if statement for the func: _maybe_adjust

Problem:

In the func `_maybe_adjust` we have this condition
where `if not p['would_adjust']: continue` which
would get triggered before `if p['pg_autoscale_mode'] == 'warn':`
if we don't have `pg_autoscale_mode` as `on`. This causes:
the autoscaler to not throw any warnings.

Solution:
Move `if p['pg_autoscale_mode'] == 'warn':` to be
higher than `if not p['would_adjust']: continue`.

Fixes: https://tracker.ceph.com/issues/58894
Signed-off-by: Kamoltat <ksirivad@redhat.com>
(cherry picked from commit c43fe7f07631bd0d795b711a100b9220b996ace0)

23 months agodoc/glossary: add "primary affinity" to glossary 53427/head
Zac Dover [Tue, 12 Sep 2023 10:56:03 +0000 (20:56 +1000)]
doc/glossary: add "primary affinity" to glossary

Add "Primary Affinity" to the glossary and link to the information in
the RADOS documentation that (more or less) explains it.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit f3a3f10e9ce0bf96d5eba25a786cdd254340878b)

23 months agoMerge pull request #53420 from zdover23/wip-doc-2023-09-12-backport-53389-to-reef
Anthony D'Atri [Tue, 12 Sep 2023 16:02:01 +0000 (12:02 -0400)]
Merge pull request #53420 from zdover23/wip-doc-2023-09-12-backport-53389-to-reef

doc: Add warning on manual CRUSH rule removal

23 months agoMerge pull request #53402 from rishabh-d-dave/wip-62806-reef
zdover23 [Tue, 12 Sep 2023 10:37:57 +0000 (20:37 +1000)]
Merge pull request #53402 from rishabh-d-dave/wip-62806-reef

reef: doc/cephfs: write cephfs commands fully in docs

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
23 months agodoc: Add warning on manual CRUSH rule removal 53420/head
Alvin Owyong [Mon, 11 Sep 2023 09:15:15 +0000 (17:15 +0800)]
doc: Add warning on manual CRUSH rule removal

Add warning for "osd erasure-code-profile rm" section under rados/operations.

Signed-off-by: Alvin Owyong <70066269+alvinowyong@users.noreply.github.com>
(cherry picked from commit f944fa8ddb022656dac3f1faebe81a7de37380f6)

23 months agorgw/auth: move http options v4 logic to get_v4_canonical_method() 53413/head
Tobias Urdin [Thu, 17 Aug 2023 11:45:06 +0000 (11:45 +0000)]
rgw/auth: move http options v4 logic to get_v4_canonical_method()

Signed-off-by: Tobias Urdin <tobias.urdin@binero.com>
(cherry picked from commit dbc0a4ed2dd6a92d06e585dda25b1325464efefb)