Merge pull request #28581 from Aran85/fix-mtime

osd: copyfrom omitted to set mtime

Reviewed-by: Greg Farnum <gfarnum@redhat.com>

mgr/dashboard: Separate file for icons for refering and reusing (#27376)

mgr/dashboard: Separate file for icons for refering and reusing

Reviewed-by: Tiago Melo <tmelo@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>
Reviewed-by: Alfonso Martínez <almartin@redhat.com>

Merge pull request #28827 from Rjerk/fix-mgr-ansible-doc

doc/mgr/ansible.rst: fix typo

Reviewed-by: Juan Miguel Olmo Martínez <jolmomar@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #28798 from tchaikov/wip-crimson-net

crimson/net: print tx/rx messages using logger().info()

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Yingxin Cheng <yingxincheng@gmail.com>

doc/mgr/ansible.rst: fix typo

Signed-off-by: Lan Liu <liulan@umcloud.com>

Merge pull request #28828 from iotcg/crimson

crimson/common: remove unused file .#log.cc

Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #28818 from tchaikov/wip-ceph-conf-cli-test

test/cli/ceph-conf: fix test

Reviewed-by: Brad Hubbard <bhubbard@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>

Merge pull request #28805 from Rjerk/fix-doc

doc/rados/configuration: fix typos in osd-config-ref.rst

Reviewed-by: Kefu Chai <kchai@redhat.com>

crimson/common: remove unused file .#log.cc

Signed-off-by: Changcheng Liu <changcheng.liu@aliyun.com>

crimson/net: print tx/rx messages using logger().debug()

so we can find them with less efforts.

Signed-off-by: Kefu Chai <kchai@redhat.com>

crimson/net: print trivial logging using "trace"

Signed-off-by: Kefu Chai <kchai@redhat.com>

crimson/net: note down server's peer_id as client

the peer_id is not used at this moment. this change is made just for
the sake of completeness.

Signed-off-by: Kefu Chai <kchai@redhat.com>

crimson/net: use Connection::peer_is_mon()

always prefer using interface over its implementation

Signed-off-by: Kefu Chai <kchai@redhat.com>

crimson: store ticket.peer_global_id in connection

peer_global_id is used by `ProtocolV2::_handle_auth_request()` when
encoding an `AuthDoneFrame`.

Signed-off-by: Kefu Chai <kchai@redhat.com>

doc/rados/configuration: fix typos in osd-config-ref.rst

Signed-off-by: Lan Liu <liulan@umcloud.com>

Merge pull request #28795 from tchaikov/wip-cmake-rbd

CMakeLists.txt: fix typo in error message

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
Reviewed-by: Milind Changire <mchangir@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

Merge pull request #28750 from neha-ojha/wip-40488

doc/rados/operations/erasure-code.rst: allow recovery below min_size

Reviewed-by: xie xingguo <xie.xingguo@zte.com.cn>
Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge PR #27073 into master

* refs/pull/27073/head:
qa/tasks: Check MDS failover during mon_thrash
qa/tasks: Compare two FSStatuses
qa/suites/fs: renamed default.yaml to mds.yaml
qa/suites/fs: mon_thrash test for fs
qa/tasks: Fix typo in the comment

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

Merge PR #28459 into master

* refs/pull/28459/head:
mds: wake up lock waiters after forcibly changing lock state

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

Merge PR #28642 into master

* refs/pull/28642/head:
mds: check last laggy before marking unresponsive client stale
mds: remove the code that skip evicting the only client

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

Merge pull request #28632 from linuxbox2/wip-rgwfile-advexp

rgw_file: advance_mtime() should consider namespace expiration

Merge pull request #27794 from cbodley/wip-39487

rgw: data/bilogs are trimmed when no peers are reading them

Reviewed-by: J. Eric Ivancich <ivancich@redhat.com>

Merge pull request #28743 from dillaman/wip-40417

librbd: prevent concurrent AIO callbacks to external clients

Reviewed-by: Mykola Golub <mgolub@suse.com>

test/cli/ceph-conf: fix test

turns out the libstdc++ on fc30 does not include error_code.message() in
filesystem_error.what(). let's make it optional

Signed-off-by: Kefu Chai <kchai@redhat.com>

Merge pull request #28800 from tchaikov/wip-crimson-mkfs

crimson: use given osd_fsid when mkfs

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>

Merge pull request #28774 from falcon78921/wip-doc-40575

doc: fixed broken link in Swift Settings section

Reviewed-by: Kefu Chai <kchai@redhat.com>

doc: fixed broken link in Swift Settings section

Fixes: https://tracker.ceph.com/issues/40575
Signed-off-by: James McClune <jmcclune@mcclunetechnologies.net>

Merge pull request #28786 from tchaikov/wip-const-head

osd/PrimaryLogPG: more constness

Reviewed-by: xie xingguo <xie.xingguo@zte.com.cn>

crimson: use given osd_fsid when mkfs

MemStore does not have this feature, but CyanStore needs it. because
`qa/tasks/ceph.py` uses following steps when creating/starting an OSD

1. ceph-osd --mkfs --mkkey -i <osd_id> --monmap <monmap>
2. read the osd_fsid of osd.<osd_id>
3. ceph osd new <osd_fsid> <osd_id>

when we mkfs for the OSD, the osd_fsid is still unknown. so we cannot
use the configured one, as it is always empty. in that case, we need to
use a random uuid, and persist it to both ${osd_data}/fsid and
superblock.osd_fsid

Signed-off-by: Kefu Chai <kchai@redhat.com>

Merge pull request #28719 from majianpeng/remove-unused-code-XioMessenger

msg/Message: Remove used code about XioMessenger.

Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #28794 from tchaikov/wip-crimson-option-help-seastar

crimson/osd: add "--help-seastar" command line option

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>

CMakeLists.txt: s/Remote block storage/RADOS Block Device/

RBD is short for RADOS Block Device, not Remote Block Storage.

Signed-off-by: Kefu Chai <kchai@redhat.com>

CMakeLists.txt: fix typo in error message

krbd depends on rbd, so we cannot build krbd without rbd.

Signed-off-by: Kefu Chai <kchai@redhat.com>

doc/dev/crimson.rst: update with stuff related to seastar options

Signed-off-by: Kefu Chai <kchai@redhat.com>

Merge pull request #28792 from tchaikov/wip-crimson-logging

common/config_values: set seastar logging level per that of ceph

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>

Merge pull request #28790 from tchaikov/wip-crimson-unknown-objectstore

crimson/osd: abort on unsupported objectstore type

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>

crimson/osd: add "--help-seastar" command line option

so we can

* have access to the available command line options offered by Seastar.
* tell if the executable we are playing around is ceph-osd or crimson-osd.

Signed-off-by: Kefu Chai <kchai@redhat.com>

doc/dev/crimson.rst: update logging related doc

as crimson's logging levels are now connected those of ceph, there is no
need to note down the difference between them anymore.

Signed-off-by: Kefu Chai <kchai@redhat.com>

common/config_values: set seastar logging level as well

when the logging level of a subsys changes, update seastar accordingly

before this change, seastar logging levels of different logger are not
connected to ceph's logging levels of different subsystem.

after this change, they are connected. whenever a subsys's logging level
changes, the corresponding seastar logger is updated as well.

Signed-off-by: Kefu Chai <kchai@redhat.com>

common/dout.h: extract log level mapping out

so we can reuse it.

Signed-off-by: Kefu Chai <kchai@redhat.com>

crimson/osd: revert 9813f7d6

since we have a proper PeeringState implementation, there is no need to
fake an active+clean PG anymore.

Signed-off-by: Kefu Chai <kchai@redhat.com>

crimson/osd: abort on unsupported objectstore type

Signed-off-by: Kefu Chai <kchai@redhat.com>

crimson/osd: add editor variables/options

Signed-off-by: Kefu Chai <kchai@redhat.com>

crimson/common: implement "__ceph_abortf()"

the macro of `ceph_abort_msgf()` is implemented using it.

Signed-off-by: Kefu Chai <kchai@redhat.com>

crimson/osd: add a space before function name

for better readability

Signed-off-by: Kefu Chai <kchai@redhat.com>

crimson/osd: use get_osdmap_epoch()

always prefer using the interface.

Signed-off-by: Kefu Chai <kchai@redhat.com>

osd/PrimaryLogPG: more constness

use `hobject_t::get_head()` instead of relying on the fact that head
object's snap is `CEPH_NOSNAP`.

Signed-off-by: Kefu Chai <kchai@redhat.com>

Merge pull request #28780 from varshar16/wip-doc-update-sepia-link

doc: Updates link to Sepia lab

Reviewed-by: Sage Weil <sage@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #28664 from linuxbox2/wip-rgwfile-faststats

rgw_file: introduce fast S3 Unix stats (immutable)

doc: update erasure-code.rst with review comments.

Signed-off-by: Greg Farnum <gfarnum@redhat.com>

doc: update erasure code recovery description

Signed-off-by: Greg Farnum <gfarnum@redhat.com>

Merge pull request #28783 from cbodley/wip-rgw-object-lock-get-params

rgw: fix MalformedXML errors in PutBucketObjectLock/PutObjRetention

rgw_file: introduce fast S3 Unix stats (immutable)

For objects originating in S3/Swift, it is frequently acceptable
to synthesize c/mtime and size stats from meta attributes in the RGW
bucket index entry.

Synthetic stat behavior is not compatible with mutation of file
ownership and permissions via SETATTR.  In future, current xattr-based,
mutable, Unix stats may be moved to the bucket index.  For now, use
synthetic stats only when a new option rgw_nfs_s3_fast_attrs is present.

Fixes: http://tracker.ceph.com/issues/40456
Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>

Merge pull request #27964 from Kriechi/fix-rgw-ldap-username

docs: fix rgw_ldap_dnattr username token

Merge pull request #28724 from ivancich/wip-abort-multipart-fix

rgw: multipart upload abort is best-effort

Reviewed-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #28102 from albIN7/liv2

RGW:Listobjectsv2

rgw: fix MalformedXML errors in PutBucketObjectLock/PutObjRetention

RGWPutBucketObjectLock was not calling get_params(), so the 'data' it
was trying to parse was empty

RGWPutObjRetention was calling get_params() a second time, which
overwrote the 'data' from the first call

Signed-off-by: Casey Bodley <cbodley@redhat.com>

Merge PR #28491 into master

* refs/pull/28491/head:
doc/rados/operations: add safe-to-destroy check to OSD replacement workflow

Reviewed-by: Josh Durgin <jdurgin@redhat.com>

Merge pull request #28781 from ivancich/wip-fix-source-permissions

src/: remove execute permissions on nine source files

Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #28775 from neha-ojha/wip-doc-delete-sleep

doc/rados/configuration/osd-config-ref.rst: document osd_delete_sleep

Reviewed-by: Sage Weil <sage@redhat.com>

misc: remove execute permissions on nine source files

Signed-off-by: J. Eric Ivancich <ivancich@redhat.com>

Merge pull request #28565 from linuxbox2/wip-rgwfile-eof

rgw_file: fix readdir eof() calc--caller stop implies !eof

qa/valgrind.supp: drop boost::lockfree::queue suppression

Signed-off-by: Jason Dillaman <dillaman@redhat.com>

cmake: boost valgrind fixes for boost::lockfree::queue

The issue has been fixed upstream under lockfree commit
7e23dac52d08ed1a099de9a6fb8bcdefbb06d2da but is not yet available in
a boost release.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>

doc: Updates link to Sepia lab

Signed-off-by: Varsha Rao <varao@redhat.com>

Merge pull request #28761 from lixiaoy1/pmem_osd

os/bluestore: fix pmem osd build problem

Reviewed-by: Jason Dillaman <dllaman@redhat.com>

Merge pull request #28776 from badone/wip-minimimal-config-no-longer-valid

do_cmake.sh: Add a heading to the minimal config

Reviewed-by: Kefu Chai <kchai@redhat.com>

os/bluestore: fix pmem osd build problem

Signed-off-by: Peterson, Scott <scott.d.peterson@intel.com>
Signed-off-by: Li, Xiaoyan <xiaoyan.li@intel.com>

do_cmake.sh: Add a heading to the minimal config

Post #28634 the minimal ceph config is invalid without a header.

Signed-off-by: Brad Hubbard <bhubbard@redhat.com>

Merge pull request #28771 from athanatos/sjust/wip-schedule-event-on-commit

crimson/osd/pg: start_operation for read_state, schedule_event_on_commit

Reviewed-by: Yingxin Cheng <yingxincheng@gmail.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>

doc/rados/configuration/osd-config-ref.rst: document osd_delete_sleep

Signed-off-by: Neha Ojha <nojha@redhat.com>

crimson/osd/pg: start_operation for read_state, schedule_event_on_commit

This way they'll be holding the appropriate pipeline stage.

Signed-off-by: Samuel Just <sjust@redhat.com>

Merge pull request #28351 from trociny/wip-39968

 journal: add support for aligned appends

Reviewed-by: Jason Dillaman <dillaman@redhat.com>

Merge pull request #28730 from trociny/wip-40519

rbd-mirror: handle duplicates in image sync throttler queue

Reviewed-by: Jason Dillaman <dillaman@redhat.com>

Merge pull request #28748 from trociny/wip-journal-player-handle_cache_rebalanced

journal: fix race between player shut down and cache rebalance

Reviewed-by: Jason Dillaman <dillaman@redhat.com>

doc/rados/operations: add safe-to-destroy check to OSD replacement workflow

Signed-off-by: Sage Weil <sage@redhat.com>

Merge pull request #28706 from ajarr/wip-fs-subvolumes-enhancements

mgr/volumes: minor enhancements and fixes

Merge pull request #28653 from zhangsw/cleanup-doc-sample.conf

sample.ceph.conf: correct the default value of filestore merge threshold

Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #28749 from hydro-b/patch-1

doc/radosgw/compression.rst: fix typo

Reviewed-by: Casey Bodley <cbodley@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>

mgr/volumes: fix incorrect VolumeException arguments

Fixes: http://tracker.ceph.com/issues/40429
Signed-off-by: Ramana Raja <rraja@redhat.com>

mgr/volumes: allow setting mode

... of fs subvolumes and subvolume groups during their creation.

Fixes: https://tracker.ceph.com/issues/40299
Signed-off-by: Ramana Raja <rraja@redhat.com>

mgr/volumes: allow setting data pool layout

... of fs subvolumes and subvolume groups during their creation.

Fixes: https://tracker.ceph.com/issues/40431
Signed-off-by: Ramana Raja <rraja@redhat.com>

Merge pull request #28593 from smithfarm/wip-40398

cmake: set empty INSTALL_RPATH on crypto shared libs

Reviewed-by: Ricardo Dias <rdias@suse.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>

librbd: prevent concurrent AIO callbacks to external clients

With the various threads and conditional IO paths within librbd, it was
possible for external AIO callbacks to be concurrently executed from
different librbd threads. These callbacks should be serialized to reduce
the unexpected potential for data corruption.

Fixes: http://tracker.ceph.com/issues/40417
Signed-off-by: Jason Dillaman <dillaman@redhat.com>

mgr/dashboard: Separate file for icons for refering and reusing

Fixes: http://tracker.ceph.com/issues/39032
Signed-off-by: Kanika Murarka <kmurarka@redhat.com>

Merge pull request #28623 from cyx1231st/wip-seastar-msgr-socket

test/crimson: add unit-test for ceph::net::Socket

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>

crimson/net: added support for new errors

connection_aborted and invalid_argument.

Signed-off-by: Yingxin Cheng <yingxincheng@gmail.com>

test/crimson: add unit-test for ceph::net::Socket

Added unittest_seastar_socket to make sure that seastar network layer
works as expected.

Added missing error code invalid_argument and address_in_use.

Signed-off-by: Yingxin Cheng <yingxincheng@gmail.com>

doc/radosgw/compression.rst: fix typo

Signed-off-by: hydro-b <stefan@kooman.org>

Merge pull request #28747 from tchaikov/wip-more-than-activate

crimson/osd: update peering_state in PG::on_activate_complete()

Reviewed-by: Samuel Just <sjust@redhat.com>

doc/rados/operations/erasure-code.rst: allow recovery below min_size

https://github.com/ceph/ceph/pull/17619 allows recovery below min_size
for EC pools starting in Octopus. Also mention that this wasn't allowed
earlier.

Fixes: https://tracker.ceph.com/issues/40488
Signed-off-by: Neha Ojha <nojha@redhat.com>

rgw: minor code clean-up

Adding some const correctness and reformatting.

Signed-off-by: J. Eric Ivancich <ivancich@redhat.com>

rgw: allow multipart upload abort to proceed

Cleaning up after aborting unfinished multipart uploads is a
best-effort process. Due to the history of the multipart upload, not
all components may be found and the process needs to be robust to
that.

Presently, if a component is not found after the final call to
list_bucket_multiparts, the error propogates to the caller, but not if
the component is not found in an earlier call. This change does not
propogate that error up ever.

Additional logging is also added to multipart-related functions.

Signed-off-by: J. Eric Ivancich <ivancich@redhat.com>

journal: fix race between player shut down and cache rebalance

Signed-off-by: Mykola Golub <mgolub@suse.com>

crimson/osd: update peering_state in PG::on_activate_complete()

so that the PG can mark itself clean when it is activated and does not
need recovery.

Signed-off-by: Kefu Chai <kchai@redhat.com>

crimson/osd: use get_osdmap_epoch()

would be better to use the interfaces of the PG class, instead of
relying on its implementation.

Signed-off-by: Kefu Chai <kchai@redhat.com>

Merge pull request #28634 from tchaikov/wip-22227

common, auth: use boost::spirit to parse ceph.conf, escape quotes in exported auths

Reviewed-by: Brad Hubbard <bhubbard@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>

common/ConfUtils: implement trim helpers using boost

remove unused trim_whitespace() and its tests. as it is not used anymore

Signed-off-by: Kefu Chai <kchai@redhat.com>

qa/workunits: add auth caps allow command case

this case introduces multiple quotes in caps line
it will trigger the bug like http://tracker.ceph.com/issues/22227

Signed-off-by: Gu Zhongyan <guzhongyan@360.cn>

auth/KeyRing: escape quotes around commands

so the exported auth can be re-imported.

Fixes: http://tracker.ceph.com/issues/22227
Signed-off-by: Kefu Chai <kchai@redhat.com>