]> git.apps.os.sepia.ceph.com Git - ceph.git/log
ceph.git
17 months agonode-proxy: (Redfish_System) reuse the existing client when possible
Guillaume Abrioux [Thu, 15 Jun 2023 14:20:31 +0000 (16:20 +0200)]
node-proxy: (Redfish_System) reuse the existing client when possible

Otherwise, the method start_client() recreates a new client.

Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
(cherry picked from commit ee1d4e49d1431365ceed4043a59d9f91123c4506)

17 months agonode-proxy: remove a redundant message
Guillaume Abrioux [Thu, 15 Jun 2023 14:19:27 +0000 (16:19 +0200)]
node-proxy: remove a redundant message

This message is not needed given that there's the same in
the RedFishClient class.

Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
(cherry picked from commit 415dc693ffaab4e6bbcfd5e2891625c4707bd7e3)

17 months agonode-proxy: add requirements.txt
Guillaume Abrioux [Mon, 12 Jun 2023 12:36:54 +0000 (14:36 +0200)]
node-proxy: add requirements.txt

This adds the requirements.txt file in order to manage the required
libraries.

Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
(cherry picked from commit 31b46ff9b8901d0a54cfedaf219a280c4802676a)

17 months agonode-proxy: add a retry on redfish_client.get_path() calls
Guillaume Abrioux [Fri, 9 Jun 2023 13:03:24 +0000 (15:03 +0200)]
node-proxy: add a retry on redfish_client.get_path() calls

The idea is to retry multiple times before stating the endpoint is
definitely unreachable.

Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
(cherry picked from commit c8f31a1ef01d777e9ef8aae1a895dfcf0a6dea8b)

17 months agonode-proxy: add a decorator 'retry'
Guillaume Abrioux [Fri, 9 Jun 2023 12:58:02 +0000 (14:58 +0200)]
node-proxy: add a decorator 'retry'

This decorator will be useful for calls that should do multiple
attempts before actually failing.

Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
(cherry picked from commit 9b88e5a782b2c10ce782ca09ff2bb56bb0a82200)

17 months agonode-proxy: add type annotation
Guillaume Abrioux [Thu, 8 Jun 2023 16:31:38 +0000 (18:31 +0200)]
node-proxy: add type annotation

This commit adds the type annotation in all files.
This was missing since the initial implementation, let's add
it before the project gets bigger.

Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
(cherry picked from commit ee8e28baafbe6861a21514c2af05b77a42d6f963)

17 months agonode-proxy: address some flake8 linting errors
Guillaume Abrioux [Thu, 8 Jun 2023 16:22:26 +0000 (18:22 +0200)]
node-proxy: address some flake8 linting errors

This addresses some flake8 errors.

Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
(cherry picked from commit 4d63a0a18dbbb5259dad098ea0184edd5c3655bb)

17 months agonode-proxy: implement config & logging management
Guillaume Abrioux [Thu, 8 Jun 2023 13:12:16 +0000 (15:12 +0200)]
node-proxy: implement config & logging management

This adds the classes 'Config' and 'Logger' in order to manage
the logging and the configuration within the node-proxy daemon.

Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
(cherry picked from commit c5acf8183c7d6d02fb8fa301b2acdec096e37059)

17 months agonode-proxy: catch RequestException in reporter
Guillaume Abrioux [Wed, 7 Jun 2023 12:23:57 +0000 (14:23 +0200)]
node-proxy: catch RequestException in reporter

This catches the requests.exceptions.RequestException
exception in the reporter agent so we can better handle the
case where it can't reach the endpoint when trying to send the
collected data.
Before this change, if for some reason the refreshed data couldn't be
sent to the endpoint, it wouldn't have retried because
`self.system.previous_data` was overwritten anyway.

Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
(cherry picked from commit 6d9198519d7b0d51e00d785d7be1f06e2e7509e3)

17 months agonode-proxy: catch more error in redfish_client
Guillaume Abrioux [Wed, 7 Jun 2023 12:20:07 +0000 (14:20 +0200)]
node-proxy: catch more error in redfish_client

This catches more potential exceptions in the redfish_client
class.
So if an error is caught we can log a more accurate and nicer message.

Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
(cherry picked from commit c8653e4cf64af5156d571d5e2ffe7e912ac0a78e)

17 months agonode-proxy: add some logging in the reporter agent
Guillaume Abrioux [Mon, 22 May 2023 12:27:48 +0000 (14:27 +0200)]
node-proxy: add some logging in the reporter agent

This adds some calls to the logging module, mostly for
devel/debug purposes at the moment.

Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
(cherry picked from commit 102a80fc298a4292e14554e7d57db6c541889468)

17 months agonode-proxy: fix a typo in redfish_system.get_status()
Guillaume Abrioux [Mon, 22 May 2023 12:26:54 +0000 (14:26 +0200)]
node-proxy: fix a typo in redfish_system.get_status()

s/Status/status

Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
(cherry picked from commit 7d30c787779078b653d29d31be812580a86602d6)

17 months agonode-proxy: redfish_system.get_system refactor
Guillaume Abrioux [Mon, 22 May 2023 12:25:35 +0000 (14:25 +0200)]
node-proxy: redfish_system.get_system refactor

This method should return the 'unified structure' version of the
collected data instead of the huge json returned by redfish.

Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
(cherry picked from commit 9f72e688c79ebf7883801f108cec3772b16e8d3c)

17 months agonode-proxy: add a lock mechanism
Guillaume Abrioux [Mon, 22 May 2023 12:20:54 +0000 (14:20 +0200)]
node-proxy: add a lock mechanism

The loop in the reporter agent has to wait that the data are all
collected before checking and pushing them to the ceph-mgr (if needed).
The idea is to use the lock mechanism offered by the threading module
from python.

Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
(cherry picked from commit fe03bf3676ee2b351a0155491bc5eb4bb7b3d1a3)

17 months agonode-proxy: migrate to cherrypy
Guillaume Abrioux [Mon, 22 May 2023 12:19:09 +0000 (14:19 +0200)]
node-proxy: migrate to cherrypy

cherrypy is already widely used in Ceph.
Let's not add new dependencies and use cherrypy instead of
python-flask

Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
(cherry picked from commit 213320d33863b2e76bb81e8de33bb78d0970dd28)

17 months agonode-proxy: add method start_client() redfish_system class
Guillaume Abrioux [Mon, 22 May 2023 12:15:05 +0000 (14:15 +0200)]
node-proxy: add method start_client() redfish_system class

This is going to be useful for a new endpoint '/start'

Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
(cherry picked from commit 6f9d3d9e15305e80ea5797ff2f0dd0b929e70822)

17 months agonode-proxy: drop redfish_system._process_redfish_system method
Guillaume Abrioux [Mon, 22 May 2023 12:09:03 +0000 (14:09 +0200)]
node-proxy: drop redfish_system._process_redfish_system method

This method isn't needed, let's drop it.

Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
(cherry picked from commit 9b2a3345b6e52b152ebf680abf319300dad513d2)

17 months agonode-proxy: display error messages when Exception is caught
Guillaume Abrioux [Thu, 11 May 2023 11:29:05 +0000 (13:29 +0200)]
node-proxy: display error messages when Exception is caught

This is mostly for development purposes.

Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
(cherry picked from commit 4b9a4ec55fbcbeed48b1dc01594cf8ed65a23ef5)

17 months agonode-proxy: merge self._system with current values
Guillaume Abrioux [Thu, 11 May 2023 11:25:36 +0000 (13:25 +0200)]
node-proxy: merge self._system with current values

Otherwise `self._system` gets reset in each iteration.

Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
(cherry picked from commit 6ae1687f5f27b6d03dd2c46735de837c7429ae5b)

17 months agonode-proxy: add normalize_dict() function
Guillaume Abrioux [Thu, 11 May 2023 11:23:22 +0000 (13:23 +0200)]
node-proxy: add normalize_dict() function

this is to make sure all keys are converted into
lowercase.

Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
(cherry picked from commit 15b1122f7af6df3faac21ed4f1834ae826f5abb3)

17 months agonode-proxy: split RedfishSystem class
Guillaume Abrioux [Thu, 6 Apr 2023 15:29:28 +0000 (17:29 +0200)]
node-proxy: split RedfishSystem class

This class should be split because the logic will be different depending on the
hardware.

Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
(cherry picked from commit 4454c64f94bb2fd93ed796a832dedb42faecf3f9)

17 months agonode-proxy: implement storage endpoint
Guillaume Abrioux [Thu, 6 Apr 2023 12:56:48 +0000 (14:56 +0200)]
node-proxy: implement storage endpoint

This adds the required logic for the endpoint '/system/storage'
to gather and return data about physical drives.

Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
(cherry picked from commit d919132be3e69e5494e44519e46a864833802b96)

17 months agonode-proxy: implement network endpoint
Guillaume Abrioux [Thu, 6 Apr 2023 12:55:41 +0000 (14:55 +0200)]
node-proxy: implement network endpoint

This adds the required logic for the endpoint '/system/network'
to gather and return data about network interfaces.

Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
(cherry picked from commit 4b9bc24f0dd1ab261c4b87667c6cdb77d3785185)

17 months agonode-proxy: implement processors endpoint
Guillaume Abrioux [Thu, 6 Apr 2023 12:53:41 +0000 (14:53 +0200)]
node-proxy: implement processors endpoint

This adds the required logic for the endpoint '/system/processors'
to gather and return data about CPUs.

Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
(cherry picked from commit 693a05a0cb38f3ca91d8aa3a67c0da23a491aa23)

17 months agonode-proxy: use `use_reloader=False`
Guillaume Abrioux [Wed, 5 Apr 2023 12:18:19 +0000 (14:18 +0200)]
node-proxy: use `use_reloader=False`

In order to prevent the server from restarting in a loop
when an error shows up. Otherwise, it creates a bunch of new
redfish client session and make it quickly unavailable due to the
session limit.
Probably not intended to be kept.

Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
(cherry picked from commit dcbdfd33feda40df82dc898011bfbd690c7aca31)

17 months agonode-proxy: add a /shutdown endpoint
Guillaume Abrioux [Wed, 5 Apr 2023 12:16:29 +0000 (14:16 +0200)]
node-proxy: add a /shutdown endpoint

Add a '/shutdown' endpoint to force the client to logout and delete its current
session.
This is for devel puroposes and probably not intended to be kept.

Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
(cherry picked from commit e06e65b78bdf44d38a3d47ab2040dc88e5cd130f)

17 months agonode-proxy: logout from redfish api on Exception
Guillaume Abrioux [Wed, 5 Apr 2023 12:14:40 +0000 (14:14 +0200)]
node-proxy: logout from redfish api on Exception

Otherwise it ends up recreating new session each time whereas the previous session
is left. After multiple failures, it reaches the limit and left sessions need to be
cleaned up manually.

Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
(cherry picked from commit 7c602947e45ceff719c105b0277a10a6e72831e5)

17 months agonode-proxy: variabilize the system_endpoint
Guillaume Abrioux [Wed, 5 Apr 2023 12:10:41 +0000 (14:10 +0200)]
node-proxy: variabilize the system_endpoint

This makes it possible to define the value of the 'System endpoint'.
This can be different according to the hardware.

This probably means that the class `RedfishSystem` should be split itself.

Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
(cherry picked from commit e80cd0286a34a352fc098d72a9740e25156de9a8)

17 months agonode-proxy: improve logging
Guillaume Abrioux [Wed, 5 Apr 2023 12:08:38 +0000 (14:08 +0200)]
node-proxy: improve logging

this adds a new file `util.py` with a logger function in order
to improve a bit the logging.

Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
(cherry picked from commit 906286426f02e068f5f8379e9330b2dcbaace050)

17 months agonode-proxy: various unified interface changes
Guillaume Abrioux [Tue, 21 Mar 2023 06:07:54 +0000 (07:07 +0100)]
node-proxy: various unified interface changes

this slightly modifies the data structure of the unified interface.

Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
(cherry picked from commit b853761836febe92f6460a13d554cd966ff2e529)
(cherry picked from commit ecc84f5b5aa8f8e45d5068956117ca793f805e18)

17 months agoFirst hardware-monitoring draft version
Redouane Kachach [Wed, 8 Mar 2023 14:27:57 +0000 (15:27 +0100)]
First hardware-monitoring draft version

Signed-off-by: Redouane Kachach <rkachach@redhat.com>
(cherry picked from commit 1c402576529edafdb8aa0aef241965e06fa4c151)

17 months agoMerge pull request #54629 from guits/wip-63599-reef
Guillaume Abrioux [Wed, 24 Jan 2024 15:28:41 +0000 (16:28 +0100)]
Merge pull request #54629 from guits/wip-63599-reef

reef: ceph-volume: fixes fallback to stat in is_device and is_partition

17 months agoMerge pull request #54705 from k0ste/wip-63312-reef
Guillaume Abrioux [Wed, 24 Jan 2024 15:28:31 +0000 (16:28 +0100)]
Merge pull request #54705 from k0ste/wip-63312-reef

reef: ceph-volume: fix a bug in _check_generic_reject_reasons

17 months agoMerge pull request #55282 from zdover23/wip-doc-2024-01-24-backport-55278-to-reef
zdover23 [Wed, 24 Jan 2024 05:29:57 +0000 (15:29 +1000)]
Merge pull request #55282 from zdover23/wip-doc-2024-01-24-backport-55278-to-reef

reef: doc: specify correct fs type for mkfs

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Reviewed-by: Ilya Dryomov <idryomov@redhat.com>
17 months agodoc: specify correct fs type for mkfs 55282/head
Himura Kazuto [Tue, 23 Jan 2024 12:59:10 +0000 (12:59 +0000)]
doc: specify correct fs type for mkfs

The default value is ext2, which is not supported (anymore?).

Signed-off-by: Vladislav Glagolev <vladislav.glagolev@devexpress.com>
(cherry picked from commit 886af37744847246b3e70f54b8577ed4f9815c20)

17 months agoMerge pull request #55271 from zdover23/wip-doc-2024-01-23-backport-55269-to-reef
Anthony D'Atri [Tue, 23 Jan 2024 14:16:10 +0000 (09:16 -0500)]
Merge pull request #55271 from zdover23/wip-doc-2024-01-23-backport-55269-to-reef

reef: doc/radosgw: edit "read/write global rate limit" admin.rst

17 months agodoc/radosgw: edit "read/write global rate limit" admin.rst 55271/head
Zac Dover [Tue, 23 Jan 2024 02:13:10 +0000 (12:13 +1000)]
doc/radosgw: edit "read/write global rate limit" admin.rst

Edit "Reading/Writing Global Rate Limit Configuration" in
doc/radosgw/admin.rst.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit c67a5e5d4bad17e7ae799dd62a66d1e23ec18942)

18 months agoMerge pull request #55263 from zdover23/wip-doc-2024-01-22-backport-54993-to-reef
Anthony D'Atri [Sun, 21 Jan 2024 21:57:11 +0000 (16:57 -0500)]
Merge pull request #55263 from zdover23/wip-doc-2024-01-22-backport-54993-to-reef

reef: doc/rados/operations: document `ceph balancer status detail`

18 months agodoc/rados/operations: document `ceph balancer status detail` 55263/head
Laura Flores [Fri, 22 Dec 2023 22:55:29 +0000 (22:55 +0000)]
doc/rados/operations: document `ceph balancer status detail`

Document change in https://github.com/ceph/ceph/pull/54801

Signed-off-by: Laura Flores <lflores@ibm.com>
(cherry picked from commit 159751b68085fbe0fe10a881ff8bedecda11142f)

18 months agoMerge pull request #55260 from zdover23/wip-doc-2024-01-21-backport-55190-to-reef
Anthony D'Atri [Sun, 21 Jan 2024 15:33:40 +0000 (10:33 -0500)]
Merge pull request #55260 from zdover23/wip-doc-2024-01-21-backport-55190-to-reef

reef: doc/radosgw: edit "Enable/Disable Bucket Rate Limit"

18 months agodoc/radosgw: edit "Enable/Disable Bucket Rate Limit" 55260/head
Zac Dover [Tue, 16 Jan 2024 10:37:17 +0000 (20:37 +1000)]
doc/radosgw: edit "Enable/Disable Bucket Rate Limit"

Edit "Enable/Disable Bucket Rate Limit" in doc/radosgw/admin.rst.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit a1fca50dfdcb30e58ebcc4ef60ef921b977efc81)

18 months agoMerge pull request #55253 from zdover23/wip-doc-2024-01-20-backport-55177-to-reef
Anthony D'Atri [Sat, 20 Jan 2024 14:54:27 +0000 (09:54 -0500)]
Merge pull request #55253 from zdover23/wip-doc-2024-01-20-backport-55177-to-reef

reef: doc/radosgw: edit admin.rst "Get Bucket Rate Limit"

18 months agodoc/radosgw: edit admin.rst "Get Bucket Rate Limit" 55253/head
Zac Dover [Sun, 14 Jan 2024 23:29:23 +0000 (09:29 +1000)]
doc/radosgw: edit admin.rst "Get Bucket Rate Limit"

Edit "Get Bucket Rate Limit" in doc/radosgw/admin.rst.

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 7c4fdd3762831cb86993b1b4a814ea68a9ea2401)

18 months agoMerge pull request #55242 from zdover23/wip-doc-2024-01-19-backport-55170-to-reef
Anthony D'Atri [Fri, 19 Jan 2024 14:44:16 +0000 (09:44 -0500)]
Merge pull request #55242 from zdover23/wip-doc-2024-01-19-backport-55170-to-reef

reef: doc/radosgw: edit admin.rst "set bucket rate limit"

18 months agoMerge pull request #55244 from zdover23/wip-doc-2024-01-19-backport-55168-to-reef
Anthony D'Atri [Fri, 19 Jan 2024 14:29:17 +0000 (09:29 -0500)]
Merge pull request #55244 from zdover23/wip-doc-2024-01-19-backport-55168-to-reef

reef: doc/rados/operations: add EC overhead table to erasure-code.rst

18 months agoMerge pull request #55246 from zdover23/wip-doc-2024-01-19-backport-54915-to-reef
Anthony D'Atri [Fri, 19 Jan 2024 14:26:45 +0000 (09:26 -0500)]
Merge pull request #55246 from zdover23/wip-doc-2024-01-19-backport-54915-to-reef

reef: doc/cephfs/client-auth.rst: correct ``fs authorize cephfs1 /dir1 clie…

18 months agoMerge pull request #54764 from rhcs-dashboard/wip-63652-reef
Nizamudeen A [Fri, 19 Jan 2024 09:29:07 +0000 (14:59 +0530)]
Merge pull request #54764 from rhcs-dashboard/wip-63652-reef

reef: mgr/dashboard: get rgw port from ssl_endpoint

Reviewed-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
18 months agoMerge pull request #55186 from rhcs-dashboard/wip-63725-reef
Nizamudeen A [Fri, 19 Jan 2024 09:25:21 +0000 (14:55 +0530)]
Merge pull request #55186 from rhcs-dashboard/wip-63725-reef

reef: mgr/dashboard: subvolume snapshot management

Reviewed-by: Ankush Behl <cloudbehl@gmail.com>
18 months agodoc/cephfs/client-auth.rst: correct ``fs authorize cephfs1 /dir1 client.x rw`` 55246/head
叶海丰 [Fri, 15 Dec 2023 09:05:38 +0000 (17:05 +0800)]
doc/cephfs/client-auth.rst: correct ``fs authorize cephfs1 /dir1 client.x rw``

(cherry picked from commit 223848a08f58fc20ee4afc008fabbec2d448be68)

18 months agodoc/rados/operations: add EC overhead table to erasure-code.rst 55244/head
Anthony D'Atri [Sat, 13 Jan 2024 17:48:58 +0000 (12:48 -0500)]
doc/rados/operations: add EC overhead table to erasure-code.rst

Signed-off-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
(cherry picked from commit 9e1999c13d5cab65e88200aa2bfc5ce385d98679)

18 months agodoc/radosgw: edit admin.rst "set bucket rate limit" 55242/head
Zac Dover [Sun, 14 Jan 2024 10:23:25 +0000 (20:23 +1000)]
doc/radosgw: edit admin.rst "set bucket rate limit"

Edit "Set Bucket Rate Limit" in doc/radosgw/admin.rst.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit e9b3ef4cb11760392ff7f766d652289636fcf5eb)

18 months agoMerge pull request #55231 from zdover23/wip-doc-2024-01-18-backport-55161-to-reef
Anthony D'Atri [Thu, 18 Jan 2024 14:17:02 +0000 (09:17 -0500)]
Merge pull request #55231 from zdover23/wip-doc-2024-01-18-backport-55161-to-reef

reef: doc/rados/operations: Fix off-by-one errors in control.rst

18 months agodoc/rados/operations: Fix off-by-one errors in control.rst 55231/head
tobydarling [Fri, 12 Jan 2024 14:10:13 +0000 (14:10 +0000)]
doc/rados/operations: Fix off-by-one errors in control.rst

Description of examples was off by one

Signed-off-by: tobydarling <anothercoffee@gmail.com>
(cherry picked from commit c636e3ed2d459a063ae6ab0e2dc876db5c58c7e6)

18 months agoMerge pull request #55212 from afreen23/wip-64036-reef
Nizamudeen A [Thu, 18 Jan 2024 08:28:00 +0000 (13:58 +0530)]
Merge pull request #55212 from afreen23/wip-64036-reef

reef: mgr/dashboard: Fixes multisite topology page breadcrumb

Reviewed-by: Nizamudeen A <nia@redhat.com>
18 months agoMerge pull request #55222 from aaSharma14/wip-64062-reef
Aashish Sharma [Thu, 18 Jan 2024 07:04:45 +0000 (12:34 +0530)]
Merge pull request #55222 from aaSharma14/wip-64062-reef

reef: mgr/dashboard: add frontend unit tests for rgw multisite sync status card

Reviewed-by: Nizamudeen A <nia@redhat.com>
18 months agoMerge pull request #55221 from aaSharma14/wip-62575-reef
Aashish Sharma [Thu, 18 Jan 2024 07:03:25 +0000 (12:33 +0530)]
Merge pull request #55221 from aaSharma14/wip-62575-reef

reef: mgr/dashboard: Create realm sets to default

Reviewed-by: Nizamudeen A <nia@redhat.com>
18 months agomgr/dashboard: add frontend unit tests for rgw multisite sync status 55222/head
Aashish Sharma [Wed, 18 Oct 2023 08:23:51 +0000 (13:53 +0530)]
mgr/dashboard: add frontend unit tests for rgw multisite sync status
card

Fixes: https://tracker.ceph.com/issues/64039
Signed-off-by: Aashish Sharma <aasharma@redhat.com>
(cherry picked from commit d169a206d11283428f7eb74a928525bc93f58915)

18 months agomgr/dashboard: Create realm sets to default 55221/head
Aashish Sharma [Wed, 23 Aug 2023 09:59:44 +0000 (15:29 +0530)]
mgr/dashboard: Create realm sets to default

In Multisite page, When we create a realm the realm sets to default even if some other realm is already default and default checkbox in unchecked as well while creating.

Fixes: https://tracker.ceph.com/issues/62453
Signed-off-by: Aashish Sharma <aasharma@redhat.com>
(cherry picked from commit 00d3ead5ee52cd9865b3f8b2df8416f6446d81f4)

18 months agoMerge pull request #55153 from rzarzynski/wip-64005-reef
Yuri Weinstein [Wed, 17 Jan 2024 20:06:07 +0000 (12:06 -0800)]
Merge pull request #55153 from rzarzynski/wip-64005-reef

reef:  common/weighted_shuffle: don't feed std::discrete_distribution with all-zero weights

Reviewed-by: Neha Ojha <nojha@redhat.com>
18 months agoMerge pull request #55112 from k0ste/wip-63974-reef
Yuri Weinstein [Wed, 17 Jan 2024 19:46:22 +0000 (11:46 -0800)]
Merge pull request #55112 from k0ste/wip-63974-reef

reef: Tools/rados: Improve Error Messaging for Object Name Resolution

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
18 months agoMerge pull request #55078 from amathuria/wip-63947-reef
Yuri Weinstein [Wed, 17 Jan 2024 19:45:39 +0000 (11:45 -0800)]
Merge pull request #55078 from amathuria/wip-63947-reef

reef: mgr/pg_autoscaler: add check for norecover flag

Reviewed-by: Ronen Friedman <rfriedma@redhat.com>
18 months agoMerge pull request #55046 from ljflores/wip-reef-backport-pr-54907
Yuri Weinstein [Wed, 17 Jan 2024 19:45:08 +0000 (11:45 -0800)]
Merge pull request #55046 from ljflores/wip-reef-backport-pr-54907

reef: osd: fix Incremental decode for new/old_pg_upmap_primary

Reviewed-by: Laura Flores <lflores@redhat.com>
18 months agoMerge pull request #55077 from amathuria/wip-63946-reef
Yuri Weinstein [Wed, 17 Jan 2024 19:44:09 +0000 (11:44 -0800)]
Merge pull request #55077 from amathuria/wip-63946-reef

reef: DaemonServer.cc: fix config show command for RGW daemons

Reviewed-by: Casey Bodley <cbodley@redhat.com>
18 months agoMerge pull request #54783 from ifed01/wip-ifed-better-osd-robust-reef
Yuri Weinstein [Wed, 17 Jan 2024 19:42:07 +0000 (11:42 -0800)]
Merge pull request #54783 from ifed01/wip-ifed-better-osd-robust-reef

reef: osd: improve OSD robustness.

Reviewed-by: Neha Ojha <nojha@redhat.com>
18 months agoMerge pull request #54693 from Matan-B/wip-63651-reef
Yuri Weinstein [Wed, 17 Jan 2024 19:40:38 +0000 (11:40 -0800)]
Merge pull request #54693 from Matan-B/wip-63651-reef

reef: tools/ceph_objectstore_tool: action_on_all_objects_in_pg to skip pgmeta

Reviewed-by: Nitzan Mordechai <nmordech@redhat.com>
18 months agoMerge pull request #53888 from sseshasa/wip-63128-reef
Yuri Weinstein [Wed, 17 Jan 2024 19:39:42 +0000 (11:39 -0800)]
Merge pull request #53888 from sseshasa/wip-63128-reef

reef: mon/ConfigMonitor: Show localized name in "config dump --format json" output

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
18 months agomgr/dashboard: Fixes multisite topology page breadcrumb 55212/head
Afreen Misbah [Thu, 11 Jan 2024 07:49:39 +0000 (13:19 +0530)]
mgr/dashboard: Fixes multisite topology page breadcrumb

The multi-site topology page just says object in breadcrumb.
The fix adds the missing "multi-site" breadcrumb.

Fixes https://tracker.ceph.com/issues/63635

Signed-off-by: Afreen Misbah <afreen23.git@gmail.com>
(cherry picked from commit f75a9da2871113a156092ff28f29b9d12f465975)

18 months agoMerge pull request #55104 from rkachach/fix_issue_63957_63958
Redouane Kachach [Wed, 17 Jan 2024 09:05:56 +0000 (10:05 +0100)]
Merge pull request #55104 from rkachach/fix_issue_63957_63958

reef: backport of fixes for 63678 and 63694

18 months agoMerge pull request #55194 from zdover23/wip-doc-2024-01-16-backport-55169-to-reef
zdover23 [Wed, 17 Jan 2024 05:56:26 +0000 (15:56 +1000)]
Merge pull request #55194 from zdover23/wip-doc-2024-01-16-backport-55169-to-reef

reef: docs/radosgw: edit admin.rst "enable/disable user rate limit"

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
18 months agoMerge pull request #55191 from rhcs-dashboard/reef-docs-build-fix
Nizamudeen A [Tue, 16 Jan 2024 16:14:10 +0000 (21:44 +0530)]
Merge pull request #55191 from rhcs-dashboard/reef-docs-build-fix

reef: admin/doc-requirements: bump Sphinx to 5.0.2

Reviewed-by: Matan-B <NOT@FOUND>
18 months agoMerge pull request #55124 from rhcs-dashboard/wip-59470-reef
Nizamudeen A [Tue, 16 Jan 2024 14:38:06 +0000 (20:08 +0530)]
Merge pull request #55124 from rhcs-dashboard/wip-59470-reef

reef: mgr/dashboard: fix e2e failure related to landing page

18 months agodocs/radosgw: edit admin.rst "enable/disable user rate limit" 55194/head
Zac Dover [Sat, 13 Jan 2024 18:06:12 +0000 (04:06 +1000)]
docs/radosgw: edit admin.rst "enable/disable user rate limit"

Edit "Enable/Disable User Rate Limit" in doc/radosgw/admin.rst.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 1cd996b6fe2e3c923001a69772c7b7635d058f2b)

18 months agoadmin/doc-requirements: bump Sphinx to 5.0.2 55191/head
Nizamudeen A [Tue, 16 Jan 2024 05:21:56 +0000 (10:51 +0530)]
admin/doc-requirements: bump Sphinx to 5.0.2

```
Running Sphinx v4.5.0

Sphinx version error:
The sphinxcontrib.applehelp extension used by this project needs at least Sphinx v5.0; it therefore cannot be built with this version.
```

Signed-off-by: Nizamudeen A <nia@redhat.com>
(cherry picked from commit a916feeee757e4e196967944feeb1e9b1f92c398)

18 months agomgr/dashboard: delete cephfs snapshot 55186/head
Nizamudeen A [Wed, 10 Jan 2024 06:42:23 +0000 (12:12 +0530)]
mgr/dashboard: delete cephfs snapshot

Fixes: https://tracker.ceph.com/issues/63990
Signed-off-by: Nizamudeen A <nia@redhat.com>
(cherry picked from commit c3d7f70b7a7d594050e3e231cd7d6544179fdfeb)

18 months agomgr/dashboard: subvolume snapshot creation form
Nizamudeen A [Wed, 27 Dec 2023 09:14:53 +0000 (14:44 +0530)]
mgr/dashboard: subvolume snapshot creation form

Fixes: https://tracker.ceph.com/issues/63934
Signed-off-by: Nizamudeen A <nia@redhat.com>
(cherry picked from commit f5d1b7df2ed090b45dd74634e3c92d4df2c4017c)

18 months agomgr/dashboard: small fixes to directories view
Nizamudeen A [Thu, 7 Dec 2023 17:28:52 +0000 (22:58 +0530)]
mgr/dashboard: small fixes to directories view

Increased the precedence for Directories
Expand the node by default and select them as well

Fixes: https://tracker.ceph.com/issues/63754
Signed-off-by: Nizamudeen A <nia@redhat.com>
(cherry picked from commit 4eb42ff15db14680c0798ceb752fa6578b76fb92)

18 months agomgr/dashboard: fs snapshots e2e
Nizamudeen A [Fri, 27 Oct 2023 08:15:44 +0000 (13:45 +0530)]
mgr/dashboard: fs snapshots e2e

Fixes: https://tracker.ceph.com/issues/63237
Signed-off-by: Nizamudeen A <nia@redhat.com>
(cherry picked from commit 4689c3d65eb758cecf944da0fe2c5686fa2918ee)

18 months agomgr/dashboard: cephfs subvolume list snapshots
Nizamudeen A [Wed, 18 Oct 2023 17:46:09 +0000 (23:16 +0530)]
mgr/dashboard: cephfs subvolume list snapshots

Added a tab for displaying the subvolume snapshots
- this tab will show an info alert when there are no subvolumes present
- if the subvolume is present, then it'll be auto-selected by default

Implemented a filter to search the groups and subvolumes by its name.
Also added a scrollbar when there are too many items in the nav list

Modified the REST APIs to fetch only the names of the resources and
fetch the info when an API call is requesting for it.

Added unit tests

Fixes: https://tracker.ceph.com/issues/63237
Signed-off-by: Nizamudeen A <nia@redhat.com>
(cherry picked from commit b35be54ed9f23b7fc7859f054902e37cb88cefd8)

18 months agoMerge pull request #55163 from zdover23/wip-doc-2024-01-13-backport-54530-to-reef
Anthony D'Atri [Sat, 13 Jan 2024 02:26:50 +0000 (21:26 -0500)]
Merge pull request #55163 from zdover23/wip-doc-2024-01-13-backport-54530-to-reef

reef: ceph-menv:fix typo in README

18 months agoceph-menv:fix typo in README 55163/head
yu.wang [Thu, 16 Nov 2023 17:38:58 +0000 (01:38 +0800)]
ceph-menv:fix typo in README

Signed-off-by: yu.wang <wangyu@wyu.space>
(cherry picked from commit 4efd9317b83eca48c1a92724e7ebe304650fbc04)

18 months agoMerge pull request #55157 from zdover23/wip-doc-2024-01-12-backport-55146-to-reef
Anthony D'Atri [Fri, 12 Jan 2024 11:58:34 +0000 (06:58 -0500)]
Merge pull request #55157 from zdover23/wip-doc-2024-01-12-backport-55146-to-reef

reef: doc/radosgw: edit admin.rst "get user rate limit"

18 months agodoc/radosgw: edit admin.rst "get user rate limit" 55157/head
Zac Dover [Thu, 11 Jan 2024 13:40:25 +0000 (23:40 +1000)]
doc/radosgw: edit admin.rst "get user rate limit"

Edit "Get User Rate Limit" in doc/radosgw/admin.rst.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 1c561e2beac67c85c40f2adf387c42aba8175ecb)

18 months agoMerge pull request #55150 from zdover23/wip-doc-2024-01-12-backport-55142-to-reef
Anthony D'Atri [Thu, 11 Jan 2024 20:25:47 +0000 (15:25 -0500)]
Merge pull request #55150 from zdover23/wip-doc-2024-01-12-backport-55142-to-reef

reef: doc/radosgw - edit admin.rst "set user rate limit"

18 months agotest/test_weighted_shuffle: verify weights containing zeros 55153/head
Radosław Zarzyński [Wed, 30 Aug 2023 13:23:34 +0000 (15:23 +0200)]
test/test_weighted_shuffle: verify weights containing zeros

Signed-off-by: Radosław Zarzyński <rzarzyns@redhat.com>
(cherry picked from commit d02b17ff84c61123ed27d79dc177c2cfbbe6a72f)

18 months agocommon/weighted_shuffle: don't feed std::discrete_distribution with all-zero weights
Radosław Zarzyński [Wed, 30 Aug 2023 13:19:07 +0000 (15:19 +0200)]
common/weighted_shuffle: don't feed std::discrete_distribution with all-zero weights

This flaw results is the assertions like the following one:

```
/usr/include/c++/11/bits/random.tcc:2667: void std::discrete_distribution<_IntType>::param_type::_M_initialize() [with _IntType = int]: Assertion '__sum > 0' failed.
Aborted (core dumped)
```

The reason behind is that `std::discrete_distribution` sums
the weights and uses the result as a divisor.

Fixes: https://tracker.ceph.com/issues/62645
Signed-off-by: Radosław Zarzyński <rzarzyns@redhat.com>
(cherry picked from commit 1b7a7a8df88ffac007dbafdecc131807de66c046)

18 months agodoc/radosgw - edit admin.rst "set user rate limit" 55150/head
Zac Dover [Thu, 11 Jan 2024 08:32:09 +0000 (18:32 +1000)]
doc/radosgw - edit admin.rst "set user rate limit"

Edit "Set User Rate Limit" in doc/radosgw/admin.rst.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 8660b4edc71113d5d2d51438c9fd6f388b35a214)

18 months agoMerge pull request #54296 from yuvalif/wip-59498-reef
Yuri Weinstein [Thu, 11 Jan 2024 15:18:23 +0000 (07:18 -0800)]
Merge pull request #54296 from yuvalif/wip-59498-reef

reef: rgw/lua: fix CopyFrom crash

Reviewed-by: Casey Bodley <cbodley@redhat.com>
18 months agoTools/rados: Improve Error Messaging for Object Name Resolution 55112/head
NitzanMordhai [Thu, 16 Nov 2023 07:09:29 +0000 (07:09 +0000)]
Tools/rados: Improve Error Messaging for Object Name Resolution

The current implementation of 'rados clearomap' exhibits a behavior where
an error message is generated without the associated object name or,
in the case of a non-existent object name, may result in a segmentation fault.

The proposed fix addresses this issue by enhancing the error message.
After applying the fix, error messages will consistently display the correct
object name, providing users with more accurate and actionable information.

Fixes: https://tracker.ceph.com/issues/63541
Signed-off-by: Nitzan Mordechai <nmordech@redhat.com>
(cherry picked from commit 313bfca056ef7f83c0e8c70a3bc4ff9d070b63d9)

18 months agoMerge pull request #54127 from BBoozmen/wip-63255-reef
Yuri Weinstein [Thu, 11 Jan 2024 00:15:25 +0000 (16:15 -0800)]
Merge pull request #54127 from BBoozmen/wip-63255-reef

reef: RGW/STS: when generating keys, take the trailing null character into account

Reviewed-by: Casey Bodley <cbodley@redhat.com>
18 months agoMerge pull request #54862 from idryomov/wip-63654-reef
Yuri Weinstein [Wed, 10 Jan 2024 21:52:45 +0000 (13:52 -0800)]
Merge pull request #54862 from idryomov/wip-63654-reef

reef: librbd: fix regressions in ObjectListSnapsRequest

Reviewed-by: Ramana Raja <rraja@redhat.com>
Reviewed-by: Mykola Golub <mgolub@suse.com>
18 months agoMerge pull request #54852 from mkogan1/wip-63753-reef
Yuri Weinstein [Wed, 10 Jan 2024 21:51:50 +0000 (13:51 -0800)]
Merge pull request #54852 from mkogan1/wip-63753-reef

reef: rgw: d3n: fix valgrind reported leak related to libaio worker threads

Reviewed-by: Casey Bodley <cbodley@redhat.com>
18 months agoMerge pull request #54844 from cbodley/wip-63775-reef
Yuri Weinstein [Wed, 10 Jan 2024 21:51:13 +0000 (13:51 -0800)]
Merge pull request #54844 from cbodley/wip-63775-reef

reef: add checking for rgw frontend init

Reviewed-by: Casey Bodley <cbodley@redhat.com>
18 months agoMerge pull request #54843 from cbodley/wip-63773-reef
Yuri Weinstein [Wed, 10 Jan 2024 21:50:31 +0000 (13:50 -0800)]
Merge pull request #54843 from cbodley/wip-63773-reef

reef: rgw/iam: admin/system users ignore iam policy parsing errors

Reviewed-by: Casey Bodley <cbodley@redhat.com>
18 months agoMerge pull request #54794 from k0ste/wip-62412-reef
Yuri Weinstein [Wed, 10 Jan 2024 21:49:40 +0000 (13:49 -0800)]
Merge pull request #54794 from k0ste/wip-62412-reef

reef: rgw/auth: Fix the return code returned by AuthStrategy,

Reviewed-by: Casey Bodley <cbodley@redhat.com>
18 months agoMerge pull request #54791 from k0ste/wip-63626-reef
Yuri Weinstein [Wed, 10 Jan 2024 21:49:08 +0000 (13:49 -0800)]
Merge pull request #54791 from k0ste/wip-63626-reef

reef: rgw: SignatureDoesNotMatch for certain RGW Admin Ops endpoints w/v4 auth

Reviewed-by: Casey Bodley <cbodley@redhat.com>
18 months agoMerge pull request #54736 from yuvalif/wip-63701-reef
Yuri Weinstein [Wed, 10 Jan 2024 21:48:33 +0000 (13:48 -0800)]
Merge pull request #54736 from yuvalif/wip-63701-reef

reef: rgw/kafka/amqp: fix race conditionn in async completion handlers

Reviewed-by: Casey Bodley <cbodley@redhat.com>
18 months agoMerge pull request #54674 from cbodley/wip-63628-reef
Yuri Weinstein [Wed, 10 Jan 2024 21:47:53 +0000 (13:47 -0800)]
Merge pull request #54674 from cbodley/wip-63628-reef

reef: rgw: object lock avoids 32-bit truncation of RetainUntilDate

Reviewed-by: Casey Bodley <cbodley@redhat.com>
18 months agoMerge pull request #54328 from petrutlucian94/wip-63430-reef
Yuri Weinstein [Wed, 10 Jan 2024 21:47:00 +0000 (13:47 -0800)]
Merge pull request #54328 from petrutlucian94/wip-63430-reef

reef: rgw: fix cloud-sync multi-tenancy scenario

Reviewed-by: Casey Bodley <cbodley@redhat.com>
18 months agoMerge pull request #54129 from ivancich/wip-63247-reef
Yuri Weinstein [Wed, 10 Jan 2024 21:46:05 +0000 (13:46 -0800)]
Merge pull request #54129 from ivancich/wip-63247-reef

reef: rgw: only buckets with reshardable layouts need to be considered for resharding

Reviewed-by: Casey Bodley <cbodley@redhat.com>
18 months agoencoding: use concepts for chrono encoding 54674/head
Casey Bodley [Wed, 15 Nov 2023 20:28:46 +0000 (15:28 -0500)]
encoding: use concepts for chrono encoding

Signed-off-by: Casey Bodley <cbodley@redhat.com>
(cherry picked from commit b33e08657ecb7949505c6eae920c83e1e84096bb)