]> git.apps.os.sepia.ceph.com Git - ceph.git/log
ceph.git
13 months agoMerge pull request #57925 from guits/cv-fix-version-checking
Guillaume Abrioux [Thu, 13 Jun 2024 07:25:56 +0000 (09:25 +0200)]
Merge pull request #57925 from guits/cv-fix-version-checking

ceph-volume: fix set_dmcrypt_no_workqueue()

13 months agoMerge pull request #57486 from ljflores/wip-tracker-66019
Laura Flores [Thu, 13 Jun 2024 05:53:42 +0000 (00:53 -0500)]
Merge pull request #57486 from ljflores/wip-tracker-66019

13 months agoMerge pull request #57856 from athanatos/sjust/wip-66226-ec-crc
Samuel Just [Thu, 13 Jun 2024 00:44:51 +0000 (17:44 -0700)]
Merge pull request #57856 from athanatos/sjust/wip-66226-ec-crc

test/librados: fix LibRadosIoECPP.CrcZeroWrite

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
13 months agoMerge pull request #57934 from ljflores/wip-tracker-66398
Laura Flores [Wed, 12 Jun 2024 19:11:50 +0000 (14:11 -0500)]
Merge pull request #57934 from ljflores/wip-tracker-66398

qa/suites/rados/thrash-old-clients: update supported releases and distro

13 months agoMerge PR #57963 into main
Patrick Donnelly [Wed, 12 Jun 2024 16:47:50 +0000 (12:47 -0400)]
Merge PR #57963 into main

* refs/pull/57963/head:
srcipt/ceph-backports: add redmine ticket's JSON to debug output

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
13 months agoMerge pull request #56906 from dang/wip-dang-65471
Daniel Gryniewicz [Wed, 12 Jun 2024 16:06:34 +0000 (12:06 -0400)]
Merge pull request #56906 from dang/wip-dang-65471

RGW - Remove potential string overflow in POSIXDriver

Reviewed-by: Casey Bodley <cbodley@redhat.com>
13 months agoMerge pull request #57601 from guits/cephadm-hostspec-fixes
Adam King [Wed, 12 Jun 2024 15:25:45 +0000 (11:25 -0400)]
Merge pull request #57601 from guits/cephadm-hostspec-fixes

cephadm: _extract_host_info_from_*() refactor

Reviewed-by: John Mulligan <jmulligan@redhat.com>
13 months agoMerge pull request #57807 from ifed01/wip-ifed-cephvol-zap-after-migrate
Guillaume Abrioux [Wed, 12 Jun 2024 15:21:47 +0000 (17:21 +0200)]
Merge pull request #57807 from ifed01/wip-ifed-cephvol-zap-after-migrate

ceph-volume: do source devices zapping if they're detached.

13 months agoMerge pull request #57889 from idryomov/wip-66359
Ilya Dryomov [Wed, 12 Jun 2024 13:52:17 +0000 (15:52 +0200)]
Merge pull request #57889 from idryomov/wip-66359

pybind/rbd: parse access and modify timestamps in UTC

Reviewed-by: Ramana Raja <rraja@redhat.com>
13 months agoMerge pull request #57759 from guojidan/group-info
Ilya Dryomov [Wed, 12 Jun 2024 13:50:11 +0000 (15:50 +0200)]
Merge pull request #57759 from guojidan/group-info

rbd: add group info command to output group id

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
Reviewed-by: Ramana Raja <rraja@redhat.com>
13 months agoMerge PR #57979 into main
Patrick Donnelly [Wed, 12 Jun 2024 13:46:27 +0000 (09:46 -0400)]
Merge PR #57979 into main

* refs/pull/57979/head:
test/ smb: modify source_type to fix run-tox-mgr failed

Reviewed-by: Ilya Dryomov <idryomov@redhat.com>
Reviewed-by: Adam King <adking@redhat.com>
13 months agoMerge pull request #57536 from kchheda3/wip-fix-persistent-queue-regression
Casey Bodley [Wed, 12 Jun 2024 13:33:08 +0000 (14:33 +0100)]
Merge pull request #57536 from kchheda3/wip-fix-persistent-queue-regression

 rgw/notification: Store the value of `persistent_queue` for existing topics and continue commiting events for all topics subscribed to given bucket

Reviewed-by: Yuval Lifshitz <ylifshit@redhat.com>
13 months agosrcipt/ceph-backports: add redmine ticket's JSON to debug output 57963/head
Rishabh Dave [Tue, 11 Jun 2024 06:13:30 +0000 (11:43 +0530)]
srcipt/ceph-backports: add redmine ticket's JSON to debug output

Add ticket received as JSON to debug output of ceph-backports.sh since
it is pretty helpful while debugging errors related to ticket's field.

This issue was discovered while running -
./src/script/ceph-backport.sh <tracker-num> --existing-pr <pr-num> --debug

Signed-off-by: Rishabh Dave <ridave@redhat.com>
13 months agoMerge pull request #57976 from zdover23/wip-doc-2024-06-12-glossary
Zac Dover [Wed, 12 Jun 2024 09:33:59 +0000 (19:33 +1000)]
Merge pull request #57976 from zdover23/wip-doc-2024-06-12-glossary

doc/glossary: Add "S3"

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
13 months agotest/ smb: modify source_type to fix run-tox-mgr failed 57979/head
Rongqi Sun [Wed, 12 Jun 2024 02:48:59 +0000 (02:48 +0000)]
test/ smb: modify source_type to fix run-tox-mgr failed

source_type should be resource
fixes: https://tracker.ceph.com/issues/66437

Signed-off-by: Rongqi Sun <sunrongqi@huawei.com>
13 months agodoc/glossary: Add "S3" 57976/head
Zac Dover [Tue, 11 Jun 2024 23:11:35 +0000 (09:11 +1000)]
doc/glossary: Add "S3"

Add "S3" entry to the glossary.

Signed-off-by: Zac Dover <zac.dover@proton.me>
13 months agoMerge pull request #57106 from phlogistonjohn/jjm-mgr-quiet-notify-types-err
Adam King [Tue, 11 Jun 2024 16:42:28 +0000 (12:42 -0400)]
Merge pull request #57106 from phlogistonjohn/jjm-mgr-quiet-notify-types-err

mgr: do not require NOTIFY_TYPES in python modules

Reviewed-by: Adam King <adking@redhat.com>
13 months agoMerge pull request #57847 from thegreenbear/keepalived-security-context
Adam King [Tue, 11 Jun 2024 16:38:41 +0000 (12:38 -0400)]
Merge pull request #57847 from thegreenbear/keepalived-security-context

cephadm/services/ingress: configure security user in keepalived template

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: John Mulligan <jmulligan@redhat.com>
13 months agoMerge pull request #57829 from gukaifeng/adjust_bootstrap_config_priorities
Adam King [Tue, 11 Jun 2024 16:33:07 +0000 (12:33 -0400)]
Merge pull request #57829 from gukaifeng/adjust_bootstrap_config_priorities

cephadm: the user config is preferred during the bootstrap

Reviewed-by: Adam King <adking@redhat.com>
13 months agoMerge pull request #57685 from tchaikov/replace-pkg_resources-with-importlib
Adam King [Tue, 11 Jun 2024 16:28:09 +0000 (12:28 -0400)]
Merge pull request #57685 from tchaikov/replace-pkg_resources-with-importlib

cephadm: use importlib.metadata for querying ceph_iscsi's version

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: John Mulligan <jmulligan@redhat.com>
13 months agoMerge pull request #57292 from adk3798/staggered-upgrade-non-ceph-daemons
Adam King [Tue, 11 Jun 2024 16:23:12 +0000 (12:23 -0400)]
Merge pull request #57292 from adk3798/staggered-upgrade-non-ceph-daemons

mgr/cephadm: make SMB and NVMEoF upgrade last in staggered upgrade

Reviewed-by: John Mulligan <jmulligan@redhat.com>
13 months agoMerge pull request #57389 from thmour/patch-1
Adam King [Tue, 11 Jun 2024 16:22:15 +0000 (12:22 -0400)]
Merge pull request #57389 from thmour/patch-1

cephadm: CephExporter doesn't bind to IPv6 in dual stack

Reviewed-by: Adam King <adking@redhat.com>
13 months agoMerge pull request #57180 from phlogistonjohn/jjm-smb-linked-res
Adam King [Tue, 11 Jun 2024 16:20:30 +0000 (12:20 -0400)]
Merge pull request #57180 from phlogistonjohn/jjm-smb-linked-res

mgr/smb: cluster linked  join auth and users/groups resource types

Reviewed-by: Adam King <adking@redhat.com>
13 months agoMerge PR #57881 into main
Patrick Donnelly [Tue, 11 Jun 2024 15:59:45 +0000 (11:59 -0400)]
Merge PR #57881 into main

* refs/pull/57881/head:
qa/tasks/vstart_runner: avoid deprecation warning

Reviewed-by: Leonid Usov <leonid.usov@ibm.com>
13 months agoceph-volume: fix set_dmcrypt_no_workqueue() 57925/head
Guillaume Abrioux [Fri, 7 Jun 2024 08:46:16 +0000 (10:46 +0200)]
ceph-volume: fix set_dmcrypt_no_workqueue()

`set_dmcrypt_no_workqueue()` from `ceph_volume.util.encryption`

The function `set_dmcrypt_no_workqueue` in `encryption.py` now
dynamically retrieves the installed cryptsetup version using `cryptsetup
--version` command. It then parses the version string using a regular
expression to accommodate varying digit counts. If the retrieved version
is greater than or equal to the specified target version,
`conf.dmcrypt_no_workqueue` is set to True, allowing for flexible version
handling.

Fixes: https://tracker.ceph.com/issues/66393
Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
13 months agoMerge pull request #57319 from TRYTOBE8TME/wip-bug-59488
Yuval Lifshitz [Tue, 11 Jun 2024 14:21:05 +0000 (17:21 +0300)]
Merge pull request #57319 from TRYTOBE8TME/wip-bug-59488

src/rgw: Fixing event name

13 months agoMerge pull request #57931 from rhcs-dashboard/bucket-policy-other-daemon
Nizamudeen A [Tue, 11 Jun 2024 14:10:51 +0000 (19:40 +0530)]
Merge pull request #57931 from rhcs-dashboard/bucket-policy-other-daemon

mgr/dashboard: fix edit bucket failing in other selected gateways

Reviewed-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
Reviewed-by: Ankush Behl <cloudbehl@gmail.com>
13 months agoMerge pull request #57957 from zdover23/wip-doc-2024-06-11-rados-troubleshooting-mon
Anthony D'Atri [Mon, 10 Jun 2024 22:46:59 +0000 (18:46 -0400)]
Merge pull request #57957 from zdover23/wip-doc-2024-06-11-rados-troubleshooting-mon

doc/rados: improve leader/peon monitor explanation

13 months agoqa/suites/rados/thrash-old-clients: update supported releases and distro 57934/head
Laura Flores [Fri, 7 Jun 2024 17:30:33 +0000 (12:30 -0500)]
qa/suites/rados/thrash-old-clients: update supported releases and distro

thrash-old-clients tests should only support N-3 releases. To fix this for
main, I have removed all releases < quincy and have added squid.

Also, we are fully switching to centos.9_stream packages/containers after
the centos.8_stream end of life, so I changed the distro from centos.8_stream
to centos.9_stream.

*** Note: If this commit is backported, it should be done in such a way that
only releases >= quincy reference centos.9_stream. For instance, if backporting to squid,
a reef/squid thrash test is okay to make references to centos.9_stream since both reef and
squid support this, but a pacific/squid test will have to take a different approach
since pacific does not support centos.9_stream.

Fixes: https://tracker.ceph.com/issues/66398
Signed-off-by: Laura Flores <lflores@ibm.com>
13 months agodoc/rados: improve leader/peon monitor explanation 57957/head
Zac Dover [Mon, 10 Jun 2024 22:00:00 +0000 (08:00 +1000)]
doc/rados: improve leader/peon monitor explanation

Add an explanation of leader-peon conditions that obtain when the
cluster is in the "HEALTH_OK" state. Previously, the text discussed
these two monitor states only in the context of a health detail entry.

This improvement to the documentation was suggested on the [ceph-users]
email list by Joel Davidow. This email, an absolute model of user
engagement with an upstream project, can be reviewed here: https://lists.ceph.io/hyperkitty/list/ceph-users@ceph.io/message/KF67F5TXFSSTPXV7EKL6JKLA5KZQDLDQ/

I will list Joel Davidow here as the co-author for the sake of more
expediently getting this change into the documentation, but though he is
listed as the co-author, he is the true author.

Co-authored-by: Joel Davidow <jdavidow@nso.edu>
Signed-off-by: Zac Dover <zac.dover@proton.me>
13 months agoMerge pull request #56744 from benhanokh/ncb_async_discard_fix
Yuri Weinstein [Mon, 10 Jun 2024 19:42:47 +0000 (12:42 -0700)]
Merge pull request #56744 from benhanokh/ncb_async_discard_fix

os/BlueStore: NCB fix for leaked space when bdev_async_discard is ena…

Reviewed-by: Igor Fedotov <ifedotov@suse.com>
Reviewed-by: Ronen Friedman <rfriedma@redhat.com>
Reviewed-by: Joshua Baergen <jbaergen@digitalocean.com>
13 months agoMerge pull request #53477 from jianwei1216/fix_msgr_worker_cpu_high
Yuri Weinstein [Mon, 10 Jun 2024 19:39:45 +0000 (12:39 -0700)]
Merge pull request #53477 from jianwei1216/fix_msgr_worker_cpu_high

src/msg: fix high CPU consumption of msgr worker thread

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
Reviewed-by: Mark Nelson <mnelson@redhat.com>
13 months agoMerge pull request #51171 from amathuria/wip-amat-scrub-cost-related-changes
Yuri Weinstein [Mon, 10 Jun 2024 19:38:28 +0000 (12:38 -0700)]
Merge pull request #51171 from amathuria/wip-amat-scrub-cost-related-changes

osd/scrub: Change scrub cost to average object size

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
Reviewed-by: Sridhar Seshasayee <sseshasa@redhat.com>
13 months agoMerge pull request #57593 from Matan-B/wip-matanb-crimson-default-cpu-cores
Matan Breizman [Mon, 10 Jun 2024 11:36:20 +0000 (14:36 +0300)]
Merge pull request #57593 from Matan-B/wip-matanb-crimson-default-cpu-cores

Crimson: Support basic deployments

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
13 months agoMerge pull request #57313 from xxhdx1985126/wip-65832
Matan Breizman [Mon, 10 Jun 2024 08:14:10 +0000 (11:14 +0300)]
Merge pull request #57313 from xxhdx1985126/wip-65832

crimson/osd/ops_executor: calculation of clone_overlap shouldn't consider snap contexts

Reviewed-by: Matan Breizman <mbreizma@redhat.com>
13 months agoMerge pull request #57279 from xxhdx1985126/wip-65806
Matan Breizman [Mon, 10 Jun 2024 08:12:53 +0000 (11:12 +0300)]
Merge pull request #57279 from xxhdx1985126/wip-65806

crimson/osd/pg: trigger wait_for_active_blocker on replica osds when the activate event is committed

Reviewed-by: Samuel Just <sjust@redhat.com>
13 months agoMerge pull request #57947 from zdover23/wip-doc-2024-06-10-start-rm-intro
Zac Dover [Sun, 9 Jun 2024 21:31:36 +0000 (07:31 +1000)]
Merge pull request #57947 from zdover23/wip-doc-2024-06-10-start-rm-intro

doc/start: remove "intro.rst"

<Reviewed-by: Cole Mitchell <cole.mitchell.ceph@gmail.com>

13 months agodoc/start: remove "intro.rst" 57947/head
Zac Dover [Sun, 9 Jun 2024 18:55:13 +0000 (04:55 +1000)]
doc/start: remove "intro.rst"

Remove "start/intro.rst", which has been renamed "start/index.rst" in
order to follow the conventions followed elsewhere in the documentation.

Follows https://github.com/ceph/ceph/pull/57900.

Signed-off-by: Zac Dover <zac.dover@proton.me>
13 months agoMerge pull request #57908 from xxhdx1985126/wip-66374
Matan Breizman [Sun, 9 Jun 2024 14:51:07 +0000 (17:51 +0300)]
Merge pull request #57908 from xxhdx1985126/wip-66374

crimson/osd/osd_operations: correct connection pipelines for osd operations

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
13 months agoMerge pull request #57692 from xxhdx1985126/wip-crimson-unnecessary-move
Matan Breizman [Sun, 9 Jun 2024 13:47:52 +0000 (16:47 +0300)]
Merge pull request #57692 from xxhdx1985126/wip-crimson-unnecessary-move

crimson/osd/pg_shard_manager: remove the unnecessary "std::move" call

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
13 months agoMerge pull request #57561 from guojidan/rollback
Matan Breizman [Sun, 9 Jun 2024 13:46:04 +0000 (16:46 +0300)]
Merge pull request #57561 from guojidan/rollback

crimson/osd/ops_executer: LIST_SNAPS only on CEPH_SNAPDIR

Reviewed-by: Matan Breizman <mbreizma@redhat.com>
13 months agoMerge pull request #57416 from xxhdx1985126/wip-65972
Matan Breizman [Sun, 9 Jun 2024 13:34:12 +0000 (16:34 +0300)]
Merge pull request #57416 from xxhdx1985126/wip-65972

crimson/osd/pg: hold PGs' references to the last minute of snap trim events executions

Reviewed-by: Matan Breizman <mbreizma@redhat.com>
13 months agoMerge pull request #57455 from xxhdx1985126/wip-66002
Matan Breizman [Sun, 9 Jun 2024 13:32:18 +0000 (16:32 +0300)]
Merge pull request #57455 from xxhdx1985126/wip-66002

crimson/osd/replicated_backend: no need to set_rollback_to for repops

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Matan Breizman <mbreizma@redhat.com>
13 months agoMerge pull request #57386 from xxhdx1985126/wip-65894
Matan Breizman [Sun, 9 Jun 2024 13:30:02 +0000 (16:30 +0300)]
Merge pull request #57386 from xxhdx1985126/wip-65894

crimson/osd/recovery_backend: change recovery waiters' promises into optional ones

Reviewed-by: Samuel Just <sjust@redhat.com>
13 months agoMerge pull request #57276 from xxhdx1985126/wip-65804
Matan Breizman [Sun, 9 Jun 2024 12:07:41 +0000 (15:07 +0300)]
Merge pull request #57276 from xxhdx1985126/wip-65804

crimson/osd/pg_backend: DONOT modify OSDOp::indata when handling CEPH_OSD_OP_CHECKSUM

Reviewed-by: Samuel Just <sjust@redhat.com>
13 months agoMerge pull request #57251 from xxhdx1985126/wip-65773
Matan Breizman [Sun, 9 Jun 2024 12:07:02 +0000 (15:07 +0300)]
Merge pull request #57251 from xxhdx1985126/wip-65773

crimson/osd/pg_backend: only create new onode when it doesn't exist

Reviewed-by: Samuel Just <sjust@redhat.com>
13 months agoMerge pull request #57204 from rzarzynski/wip-crimson-osd-read-clamp
Matan Breizman [Sun, 9 Jun 2024 12:06:39 +0000 (15:06 +0300)]
Merge pull request #57204 from rzarzynski/wip-crimson-osd-read-clamp

crimson/osd: clamp reads to object size and bring full read trimming

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Matan Breizman <mbreizma@redhat.com>
13 months agoMerge pull request #57069 from xxhdx1985126/wip-65632
Matan Breizman [Sun, 9 Jun 2024 12:02:56 +0000 (15:02 +0300)]
Merge pull request #57069 from xxhdx1985126/wip-65632

crimson/common/operation: detach blockers from blocking events when they are destroyed

Reviewed-by: Samuel Just <sjust@redhat.com>
13 months agoMerge pull request #57788 from cyx1231st/wip-seastore-report-disk
Matan Breizman [Sun, 9 Jun 2024 07:56:15 +0000 (10:56 +0300)]
Merge pull request #57788 from cyx1231st/wip-seastore-report-disk

crimson/os/seastore: implement disk and writer level stats reporting

Reviewed-by: Xuehan Xu <xuxuehan@qianxin.com>
13 months agoMerge pull request #57939 from zdover23/wip-doc-2024-06-09-glossary-swift
Zac Dover [Sun, 9 Jun 2024 02:27:30 +0000 (12:27 +1000)]
Merge pull request #57939 from zdover23/wip-doc-2024-06-09-glossary-swift

doc/glossary.rst: add "OpenStack Swift" and "Swift"

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
13 months agodoc/glossary.rst: add "OpenStack Swift" and "Swift" 57939/head
Zac Dover [Sat, 8 Jun 2024 20:24:43 +0000 (06:24 +1000)]
doc/glossary.rst: add "OpenStack Swift" and "Swift"

Add "OpenStack Swift" and "Swift" entries to the glossary.

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
13 months agoMerge pull request #57940 from zdover23/wip-doc-2024-06-090-start-documenting-ceph...
Anthony D'Atri [Sat, 8 Jun 2024 23:26:02 +0000 (19:26 -0400)]
Merge pull request #57940 from zdover23/wip-doc-2024-06-090-start-documenting-ceph-squash

doc/start: format squash procedure

13 months agodoc/start: format squash procedure 57940/head
Zac Dover [Sat, 8 Jun 2024 20:32:19 +0000 (06:32 +1000)]
doc/start: format squash procedure

Add letters to substeps in a procedure so that readers won't get too
confused by having numbered steps nested inside numbered steps.

Signed-off-by: Zac Dover <zac.dover@proton.me>
13 months agoMerge PR #48130 into main
Patrick Donnelly [Sat, 8 Jun 2024 19:56:12 +0000 (15:56 -0400)]
Merge PR #48130 into main

* refs/pull/48130/head:
qa: add killpoint testing for dirfrags
qa: stringify arguments to setfattr
qa: move some configs to cluster-conf
qa: restore default for config to split exports
qa/tasks/ceph_test_case: rollback configs using `config reset`
qa/cephfs: set confs using cluster-conf
qa/tasks/ceph: provide configuration for setting configs via mon
mds: optimize MDBalancer code path config access
mds: add killpoints for directory fragmentation

Reviewed-by: Venky Shankar <vshankar@redhat.com>
13 months agoMerge pull request #57912 from ceph/wip-lusov-qdb-exclude-or-cancel
Leonid S. Usov [Sat, 8 Jun 2024 07:43:30 +0000 (10:43 +0300)]
Merge pull request #57912 from ceph/wip-lusov-qdb-exclude-or-cancel

mds: QuiesceDbRequest: update the internal encoding of ops

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
13 months agoMerge pull request #57923 from zdover23/wip-doc-2024-06-07-global-yaml-in-inline...
Zac Dover [Fri, 7 Jun 2024 23:05:41 +0000 (09:05 +1000)]
Merge pull request #57923 from zdover23/wip-doc-2024-06-07-global-yaml-in-inline-literals

doc/src: add inline literals (``) to variables

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
13 months agoMerge pull request #57755 from rhcs-dashboard/fix-66267-main
Nizamudeen A [Fri, 7 Jun 2024 13:59:34 +0000 (19:29 +0530)]
Merge pull request #57755 from rhcs-dashboard/fix-66267-main

mgr/dashboard: provide option to enable pool based mirroring mode while creating a pool

Reviewed-by: Ankush Behl <cloudbehl@gmail.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
13 months agomgr/dashboard: fix edit bucket failing in other selected gateways 57931/head
Nizamudeen A [Fri, 7 Jun 2024 13:49:42 +0000 (19:19 +0530)]
mgr/dashboard: fix edit bucket failing in other selected gateways

even if I select gateway 8002, the bucket policy req seems to go through 8000 and doesn't find the bucket
```
2024-06-07T13:40:33.161+0000 7f563be00700  0 [dashboard DEBUG rest_client] RGW REST API GET req: /hello?policy data: None
2024-06-07T13:40:33.164+0000 7f563be00700  0 [dashboard DEBUG urllib3.connectionpool] http://172.20.0.5:8000 "GET /hello?policy HTTP/1.1" 404 174
2024-06-07T13:40:33.164+0000 7f563be00700  0 [dashboard ERROR rest_client] RGW REST API failed GET req status: 404
2024-06-07T13:40:33.164+0000 7f563be00700  0 [dashboard ERROR exception] Internal Server Error
Traceback (most recent call last):
  File "/ceph/src/pybind/mgr/dashboard/services/exception.py", line 47, in dashboard_exception_handler
    return handler(*args, **kwargs)
  File "/usr/lib/python3.6/site-packages/cherrypy/_cpdispatch.py", line 54, in __call__
    return self.callable(*self.args, **self.kwargs)
  File "/ceph/src/pybind/mgr/dashboard/controllers/_base_controller.py", line 263, in inner
    ret = func(*args, **kwargs)
  File "/ceph/src/pybind/mgr/dashboard/controllers/_rest_controller.py", line 193, in wrapper
    return func(*vpath, **params)
  File "/ceph/src/pybind/mgr/dashboard/controllers/rgw.py", line 463, in get
    result['bucket_policy'] = self._get_policy(bucket_name)
  File "/ceph/src/pybind/mgr/dashboard/controllers/rgw.py", line 381, in _get_policy
    return rgw_client.get_bucket_policy(bucket)
  File "/ceph/src/pybind/mgr/dashboard/rest_client.py", line 543, in func_wrapper
    **kwargs)
  File "/ceph/src/pybind/mgr/dashboard/services/rgw_client.py", line 957, in get_bucket_policy
    raise e
  File "/ceph/src/pybind/mgr/dashboard/services/rgw_client.py", line 949, in get_bucket_policy
    request = request()
  File "/ceph/src/pybind/mgr/dashboard/rest_client.py", line 325, in __call__
    data, raw_content, headers)
  File "/ceph/src/pybind/mgr/dashboard/rest_client.py", line 428, in do_request
    resp.content)
dashboard.rest_client.RequestException: RGW REST API failed request with status code 404
(b'{"Code":"NoSuchBucket","Message":"","BucketName":"hello","RequestId":"tx0000'
 b'0d73bbbad485175ea-0066630dd1-18785-zone1-zg1-realm1","HostId":"18785-zone1-z'
 b'g1-realm1-zg1-realm1"}')
```

But for the same bucket the encryption and other req goes through the correct gateway

```
2024-06-07T13:40:32.704+0000 7f563be00700  0 [dashboard DEBUG urllib3.connectionpool] http://172.20.0.5:8002 "GET /hello?versioning HTTP/1.1" 200 2
2024-06-07T13:40:32.745+0000 7f563be00700  0 [dashboard DEBUG rest_client] RGW REST API GET res status: 200 content: {}
2024-06-07T13:40:32.745+0000 7f563be00700  0 [dashboard INFO rgw_client] Found RGW daemon with configuration: host=172.20.0.5, port=8000, ssl=False
2024-06-07T13:40:32.746+0000 7f563be00700  0 [dashboard INFO rgw_client] Found RGW daemon with configuration: host=172.20.0.5, port=8002, ssl=False
2024-06-07T13:40:32.746+0000 7f563be00700  0 [dashboard DEBUG rest_client] RGW REST API GET req: /hello?encryption data: None
2024-06-07T13:40:32.747+0000 7f563be00700  0 [dashboard DEBUG urllib3.connectionpool] http://172.20.0.5:8002 "GET /hello?encr
```

Fixes: https://tracker.ceph.com/issues/66395
Signed-off-by: Nizamudeen A <nia@redhat.com>
13 months agoMerge PR #57882 into main
Patrick Donnelly [Fri, 7 Jun 2024 12:24:09 +0000 (08:24 -0400)]
Merge PR #57882 into main

* refs/pull/57882/head:
mds: add debug message when conf changes are processed

Reviewed-by: Rishabh Dave <ridave@redhat.com>
13 months agoMerge PR #57919 into main
Patrick Donnelly [Fri, 7 Jun 2024 12:22:54 +0000 (08:22 -0400)]
Merge PR #57919 into main

* refs/pull/57919/head:
script/ceph-backport: lookup "Release" custom_field by id

Reviewed-by: Leonid Usov <leonid.usov@ibm.com>
13 months agoMerge pull request #57894 from AliMasarweh/wip-alimasa-bn-http-teuthology
Ali Masarwa [Fri, 7 Jun 2024 11:20:46 +0000 (14:20 +0300)]
Merge pull request #57894 from AliMasarweh/wip-alimasa-bn-http-teuthology

RGW|BN: make http tests run on a seperate task

Reviewed-by: yuvalif<ylifshit@redhat.com>
13 months agoMerge pull request #57746 from ceph/nodejs-lts-update
Ivo Almeida [Fri, 7 Jun 2024 09:23:29 +0000 (10:23 +0100)]
Merge pull request #57746 from ceph/nodejs-lts-update

mgr/dashboard: update node js version

Reviewed-by: Nizamudeen A <nia@redhat.com>
13 months agomgr/dashboard: provide option to enable pool based mirroring mode while 57755/head
Aashish Sharma [Wed, 29 May 2024 04:34:13 +0000 (10:04 +0530)]
mgr/dashboard: provide option to enable pool based mirroring mode while
creating a pool

Fixes: https://tracker.ceph.com/issues/66267
Signed-off-by: Aashish Sharma <aasharma@redhat.com>
13 months agodoc/src: add inline literals (``) to variables 57923/head
Zac Dover [Fri, 7 Jun 2024 01:24:00 +0000 (11:24 +1000)]
doc/src: add inline literals (``) to variables

Add inline-literal RST markup (``) (double backticks) around variable
names in src/common/options/global.yaml.in.

This follows https://github.com/ceph/ceph/pull/57887.

Signed-off-by: Zac Dover <zac.dover@proton.me>
13 months agoMerge pull request #56874 from smanjara/wip-shilpa-multisite-tests expand-cluster-improvements
Shilpa Jagannath [Thu, 6 Jun 2024 22:28:38 +0000 (15:28 -0700)]
Merge pull request #56874 from smanjara/wip-shilpa-multisite-tests

qa/multisite: stabilize multisite testing

13 months agomultisite/qa: resolve rebase conflicts 56874/head
Shilpa Jagannath [Thu, 6 Jun 2024 19:06:49 +0000 (12:06 -0700)]
multisite/qa: resolve rebase conflicts

Signed-off-by: Shilpa Jagannath <smanjara@redhat.com>
13 months agomultisite/qa: disable sync error injection
Shilpa Jagannath [Tue, 21 May 2024 17:31:31 +0000 (10:31 -0700)]
multisite/qa: disable sync error injection

Signed-off-by: Shilpa Jagannath <smanjara@redhat.com>
13 months agoqa/multisite: disable two-zonegroup and three-zone configs.
Shilpa Jagannath [Mon, 15 Apr 2024 14:54:57 +0000 (10:54 -0400)]
qa/multisite: disable two-zonegroup and three-zone configs.

Signed-off-by: Shilpa Jagannath <smanjara@redhat.com>
13 months agoqa/rgw/multisite: enable notification_v2 feature
Casey Bodley [Mon, 15 Apr 2024 14:06:11 +0000 (10:06 -0400)]
qa/rgw/multisite: enable notification_v2 feature

Signed-off-by: Casey Bodley <cbodley@redhat.com>
(cherry picked from commit 1e7fc66683e4dea7294f0ec95f47b22f48b33b7e)

13 months agoqa/multisite: disable sync policy, endpoint and data_sync_init tests until fixed.
Shilpa Jagannath [Fri, 12 Apr 2024 20:46:11 +0000 (16:46 -0400)]
qa/multisite: disable sync policy, endpoint and data_sync_init tests until fixed.

Signed-off-by: Shilpa Jagannath <smanjara@redhat.com>
13 months agoqa/rgw/multisite: add two-zone configuration
Casey Bodley [Thu, 9 Nov 2023 21:22:36 +0000 (16:22 -0500)]
qa/rgw/multisite: add two-zone configuration

Signed-off-by: Casey Bodley <cbodley@redhat.com>
(cherry picked from commit 14204442ac2eaaaa3f40a76403da49f0f4ed92c1)

13 months agoqa/rgw/multisite: double cluster nodes and osd count
Casey Bodley [Tue, 31 Oct 2023 14:53:25 +0000 (10:53 -0400)]
qa/rgw/multisite: double cluster nodes and osd count

> WARNING: The OSD cluster is overloaded and struggling to complete ops. You need more capacity to serve this level of demand.

give each cluster 2 nodes instead of 1, and 6 osds instead of 3

Signed-off-by: Casey Bodley <cbodley@redhat.com>
(cherry picked from commit 9a80cf4bf473c95c8d0b18fcdce88be20f74f973)

13 months agoqa/rgw/multisite: reduce polling intervals from 20s to 5s
Casey Bodley [Tue, 31 Oct 2023 14:51:28 +0000 (10:51 -0400)]
qa/rgw/multisite: reduce polling intervals from 20s to 5s

Signed-off-by: Casey Bodley <cbodley@redhat.com>
(cherry picked from commit bc084c0ac64477abdbf54d96bc4981edf41e1343)

13 months agorgw/multisite: reconfigure checkpoint delay to 90s
Shilpa Jagannath [Mon, 30 Oct 2023 15:29:06 +0000 (11:29 -0400)]
rgw/multisite: reconfigure checkpoint delay to 90s

Signed-off-by: Shilpa Jagannath <smanjara@redhat.com>
13 months agoMerge pull request #57725 from Matan-B/wip-matanb-crimson-load-exist
Samuel Just [Thu, 6 Jun 2024 18:39:14 +0000 (11:39 -0700)]
Merge pull request #57725 from Matan-B/wip-matanb-crimson-load-exist

crimson/osd/object_context_loader: Fix obc cache existence usage

Reviewed-by: Aishwarya Mathuria <amathuri@redhat.com>
Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Xuehan Xu <xuxuehan@qianxin.com>
Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
13 months agoscript/ceph-backport: lookup "Release" custom_field by id 57919/head
Patrick Donnelly [Thu, 6 Jun 2024 18:17:46 +0000 (14:17 -0400)]
script/ceph-backport: lookup "Release" custom_field by id

Right now the script assumes the Release custom_field will be ordered first in
the array from the REST API.

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
13 months agoqa: add killpoint testing for dirfrags 48130/head
Patrick Donnelly [Thu, 15 Sep 2022 13:59:01 +0000 (09:59 -0400)]
qa: add killpoint testing for dirfrags

Fixes: https://tracker.ceph.com/issues/7320
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
Signed-off-by: Sidharth Anupkrishnan <sanupkri@redhat.com>
13 months agoqa: stringify arguments to setfattr
Patrick Donnelly [Thu, 15 Sep 2022 13:58:01 +0000 (09:58 -0400)]
qa: stringify arguments to setfattr

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
13 months agoqa: move some configs to cluster-conf
Patrick Donnelly [Sat, 16 Sep 2023 00:50:15 +0000 (20:50 -0400)]
qa: move some configs to cluster-conf

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
13 months agoqa: restore default for config to split exports
Patrick Donnelly [Fri, 15 Sep 2023 15:44:29 +0000 (11:44 -0400)]
qa: restore default for config to split exports

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
13 months agoqa/tasks/ceph_test_case: rollback configs using `config reset`
Patrick Donnelly [Tue, 8 Aug 2023 01:14:55 +0000 (21:14 -0400)]
qa/tasks/ceph_test_case: rollback configs using `config reset`

This is faster and catches config changes made outside this interface.

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
13 months agoqa/cephfs: set confs using cluster-conf
Patrick Donnelly [Tue, 8 Aug 2023 01:14:03 +0000 (21:14 -0400)]
qa/cephfs: set confs using cluster-conf

So that these configs can be easily overriden by tests.

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
13 months agoqa/tasks/ceph: provide configuration for setting configs via mon
Patrick Donnelly [Tue, 8 Aug 2023 01:09:21 +0000 (21:09 -0400)]
qa/tasks/ceph: provide configuration for setting configs via mon

These configs may be set using:

ceph:
  cluster-config:
    entity:
      foo: bar

same as the current:

ceph:
  config:
    entity:
      foo: bar

The configs will be set in parallel using the `ceph config set` command.

The main benefit here is to avoid using the ceph.conf to set configs which
cannot be overriden using subsequent `ceph config` command. The only way to
override is to change the ceph.conf in the test (yuck) or the admin socket
(which gets reset when the daemon restarts).

Finally, we can now exploit the `ceph config reset` command will let us
trivially rollback config changes after a test completes. That is exposed
as the `ctx.config_epoch` variable.

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
13 months agomds: optimize MDBalancer code path config access
Sidharth Anupkrishnan [Thu, 1 Oct 2020 15:34:56 +0000 (21:04 +0530)]
mds: optimize MDBalancer code path config access

This change is necessary because the new way of setting config is to use the
ceph config command or the asok interface rather than the old way which
involved editing the ceph.conf and restarting the daemons to reflect the
changes. Have updated the code to support runtime config changes.

Signed-off-by: Sidharth Anupkrishnan <sanupkri@redhat.com>
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
13 months agomds: add killpoints for directory fragmentation
Sidharth Anupkrishnan [Thu, 21 May 2020 15:25:54 +0000 (20:55 +0530)]
mds: add killpoints for directory fragmentation

Defined a set of killpoints for testing directory fragmentation during
cluster recovery after failure.

Signed-off-by: Sidharth Anupkrishnan <sanupkri@redhat.com>
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
13 months agoMerge PR #57879 into main
Patrick Donnelly [Thu, 6 Jun 2024 17:56:46 +0000 (13:56 -0400)]
Merge PR #57879 into main

* refs/pull/57879/head:
qa: add common conf links
qa: disable mon_warn_on_pool_no_app in fs suite

Reviewed-by: Venky Shankar <vshankar@redhat.com>
13 months agoMerge PR #57877 into main
Patrick Donnelly [Thu, 6 Jun 2024 17:56:00 +0000 (13:56 -0400)]
Merge PR #57877 into main

* refs/pull/57877/head:
qa: correct json lookup for new `lock path` output

Reviewed-by: Leonid Usov <leonid.usov@ibm.com>
13 months agoMerge PR #57813 into main
Patrick Donnelly [Thu, 6 Jun 2024 17:55:41 +0000 (13:55 -0400)]
Merge PR #57813 into main

* refs/pull/57813/head:
mds: avoid use of swap to initialize

Reviewed-by: Leonid Usov <leonid.usov@ibm.com>
13 months agoMerge pull request #57887 from zdover23/wip-doc-2024-06-05-rados-config-network-confi...
Zac Dover [Thu, 6 Jun 2024 17:21:43 +0000 (03:21 +1000)]
Merge pull request #57887 from zdover23/wip-doc-2024-06-05-rados-config-network-config-ref

doc/rados: add options to network config ref

Reviewed-by: Cole Mitchell <cole.mitchell.ceph@gmail.com>
13 months agoMerge pull request #57641 from cbodley/wip-rgw-delete-objects-throttle
Casey Bodley [Thu, 6 Jun 2024 16:21:04 +0000 (17:21 +0100)]
Merge pull request #57641 from cbodley/wip-rgw-delete-objects-throttle

rgw: RGWDeleteMultiObj uses spawn_throttle for concurrency

Reviewed-by: Adam Emerson <aemerson@redhat.com>
13 months agoMerge pull request #57702 from Suyashd999/fix-uam2
Casey Bodley [Thu, 6 Jun 2024 14:43:39 +0000 (15:43 +0100)]
Merge pull request #57702 from Suyashd999/fix-uam2

rados/cls_fifo_legacy: 'oid' used after it was moved

Reviewed-by: Yuval Lifshitz <ylifshit@ibm.com>
Reviewed-by: Adam Emerson <aemerson@redhat.com>
13 months agocrimson/osd/object_context_loader: get_or_load to support atomicity 57725/head
Matan Breizman [Thu, 6 Jun 2024 09:48:09 +0000 (09:48 +0000)]
crimson/osd/object_context_loader: get_or_load to support atomicity

make use of try_lock in order to support atomicity when called in
ObjectContext::_with_lock()

Co-authored-by: Yingxin Cheng <yingxin.cheng@intel.com>
Signed-off-by: Matan Breizman <mbreizma@redhat.com>
13 months agocrimson/common/tri_mutex: make lock() atomic if doesn't need wait
Yingxin Cheng [Mon, 3 Jun 2024 06:33:26 +0000 (14:33 +0800)]
crimson/common/tri_mutex: make lock() atomic if doesn't need wait

Otherwise, promotion cannot be atomic with the 1st locker.

Identified by: Matan Breizman <mbreizma@redhat.com>

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
13 months agocrimson/common/tri_mutex: minor cleanup to be consistent
Yingxin Cheng [Mon, 3 Jun 2024 06:31:35 +0000 (14:31 +0800)]
crimson/common/tri_mutex: minor cleanup to be consistent

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
Signed-off-by: Matan Breizman <mbreizma@redhat.com>
13 months agocrimson/common/tri_mutex: add waiter_t::waiter_name
Matan Breizman [Sun, 2 Jun 2024 15:17:36 +0000 (15:17 +0000)]
crimson/common/tri_mutex: add waiter_t::waiter_name

Signed-off-by: Matan Breizman <mbreizma@redhat.com>
13 months agocrimson/common/tri_mutex: add debug logs
Matan Breizman [Sun, 2 Jun 2024 15:00:37 +0000 (15:00 +0000)]
crimson/common/tri_mutex: add debug logs

to be used only for testing

Signed-off-by: Matan Breizman <mbreizma@redhat.com>
13 months agocrimson/osd/object_context_loader: with_head_obc to log `existed`
Matan Breizman [Thu, 30 May 2024 11:48:46 +0000 (11:48 +0000)]
crimson/osd/object_context_loader: with_head_obc to log `existed`

Signed-off-by: Matan Breizman <mbreizma@redhat.com>
13 months agocrimson/osd/object_context_loader: cleanup `loaded`
Matan Breizman [Tue, 28 May 2024 13:52:08 +0000 (13:52 +0000)]
crimson/osd/object_context_loader: cleanup `loaded`

Signed-off-by: Matan Breizman <mbreizma@redhat.com>
13 months agoMerge pull request #57696 from kotreshhr/fix_headcheck_first_damage
Venky Shankar [Thu, 6 Jun 2024 13:45:30 +0000 (19:15 +0530)]
Merge pull request #57696 from kotreshhr/fix_headcheck_first_damage

tools/first-damage: Make CEPH_NOSNAP int64

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
13 months agomds: QuiesceDbRequest: update the internal encoding of ops 57912/head
Leonid Usov [Thu, 6 Jun 2024 11:48:56 +0000 (14:48 +0300)]
mds: QuiesceDbRequest: update the internal encoding of ops

Excluding the last root from a set will automatically mark it as QS_CANCELED.
Hence, it makes more sense if `exclude` and `cancel` share the same op code,
rather than `exclude` and `release`.

Signed-off-by: Leonid Usov <leonid.usov@ibm.com>
Fixes: https://tracker.ceph.com/issues/66383