]> git.apps.os.sepia.ceph.com Git - ceph.git/log
ceph.git
6 years agoMerge pull request #23834 from DikshaGodbole/wip-feature-24571
Lenz Grimmer [Mon, 26 Nov 2018 08:11:15 +0000 (09:11 +0100)]
Merge pull request #23834 from DikshaGodbole/wip-feature-24571

mgr/dashboard: Move Cluster/Audit logs from front page to dedicated Logs page

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Tiago Melo <tmelo@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>
6 years agoMerge pull request #25239 from cbodley/wip-rgw-rados-aio-cleanup
Yehuda Sadeh [Mon, 26 Nov 2018 06:28:10 +0000 (08:28 +0200)]
Merge pull request #25239 from cbodley/wip-rgw-rados-aio-cleanup

rgw: remove unused aio helper functions

Reviewed-by: Yehuda Sadeh <yehuda@redhat.com>
6 years agoMerge PR #17526 into master
Sage Weil [Mon, 26 Nov 2018 03:21:02 +0000 (21:21 -0600)]
Merge PR #17526 into master

* refs/pull/17526/head:
qa/tasks/ceph_manager: avoid test_map_discontinuity stall with too few up osds

Reviewed-by: Gregory Farnum <gfarnum@redhat.com>
6 years agoMerge PR #21444 into master
Sage Weil [Mon, 26 Nov 2018 03:20:44 +0000 (21:20 -0600)]
Merge PR #21444 into master

* refs/pull/21444/head:
qa: Replace 'ceph' with cluster name in restart()

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
6 years agoMerge PR #25185 into master
Sage Weil [Mon, 26 Nov 2018 03:20:18 +0000 (21:20 -0600)]
Merge PR #25185 into master

* refs/pull/25185/head:
auth/AuthSessionHandler: no handler if no session key

Reviewed-by: Gregory Farnum <gfarnum@redhat.com>
Reviewed-by: Greg Farnum <gfarnum@redhat.com>
6 years agoMerge pull request #25206 from dillaman/wip-36622
Mykola Golub [Sun, 25 Nov 2018 08:56:21 +0000 (10:56 +0200)]
Merge pull request #25206 from dillaman/wip-36622

pybind/rbd: add namespace helper API methods

Reviewed-by: Mykola Golub <mgolub@suse.com>
6 years agomgr/dashboard: Added new logs component 23834/head
Diksha Godbole [Wed, 29 Aug 2018 06:56:59 +0000 (12:26 +0530)]
mgr/dashboard: Added new logs component

Added new Logs component and created a cluster->logs menu item. Moved the logs from the dashboard home page to the dedicated logs page.Additional comments resolved.Dropped Logs from health component.

Fixes: https://tracker.ceph.com/issues/24571
Signed-off-by: Diksha Godbole <diksha.godbole@gmail.com>
6 years agoMerge pull request #25221 from tspmelo/wip-37354
Lenz Grimmer [Fri, 23 Nov 2018 12:03:45 +0000 (13:03 +0100)]
Merge pull request #25221 from tspmelo/wip-37354

mgr/dashboard: Fix test_remove_not_expired_trash qa test

Reviewed-by: Laura Paduano <lpaduano@suse.com>
Reviewed-by: Tatjana Dehler <tdehler@suse.com>
6 years agoMerge pull request #24757 from votdev/issue_36480
Lenz Grimmer [Fri, 23 Nov 2018 11:36:26 +0000 (12:36 +0100)]
Merge pull request #24757 from votdev/issue_36480

mgr/dashboard: Can't handle user editing when tenants are specified

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Tatjana Dehler <tdehler@suse.com>
Reviewed-by: Tiago Melo <tmelo@suse.com>
6 years agoMerge pull request #25186 from tchaikov/wip-vive-le-make-install
Kefu Chai [Fri, 23 Nov 2018 01:30:28 +0000 (09:30 +0800)]
Merge pull request #25186 from tchaikov/wip-vive-le-make-install

cmake: do not pass unnecessary param to setup.py

Reviewed-by: Alfredo Deza <adeza@redhat.com>
6 years agoMerge pull request #25197 from iridescent-rsy/fix-typo
Jason Dillaman [Thu, 22 Nov 2018 15:51:45 +0000 (10:51 -0500)]
Merge pull request #25197 from iridescent-rsy/fix-typo

rbd-mirror,common: fix typos in logging messages and comments

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
6 years agoMerge pull request #25202 from trociny/wip-doc-rbd-qos
Jason Dillaman [Thu, 22 Nov 2018 15:50:54 +0000 (10:50 -0500)]
Merge pull request #25202 from trociny/wip-doc-rbd-qos

doc: describe RBD QoS settings

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
Reviewed-by: Patrick Nawracay <pnawracay@suse.com>
6 years agoMerge pull request #25182 from jan--f/mgr-prometheus-doc-mention-instance-label
Jan Fajerski [Thu, 22 Nov 2018 13:29:43 +0000 (14:29 +0100)]
Merge pull request #25182 from jan--f/mgr-prometheus-doc-mention-instance-label

doc/mgr/prometheus: readd section about custom instance labels

6 years agoMerge pull request #25119 from sebastian-philipp/doc-orchestrator-cli-spec
Sebastian Wagner [Thu, 22 Nov 2018 12:59:34 +0000 (13:59 +0100)]
Merge pull request #25119 from sebastian-philipp/doc-orchestrator-cli-spec

doc/orchestrator: Integrate CLI specification into the documentation

Reviewed-by: Alfredo Deza <adeza@redhat.com>
Reviewed-by: Jan Fajerski <jfajerski@suse.com>
Reviewed-by: Jeff Layton <jlayton@redhat.com>
6 years agomgr/dashboard: Fix test_remove_not_expired_trash qa test 25221/head
Tiago Melo [Thu, 22 Nov 2018 11:33:35 +0000 (11:33 +0000)]
mgr/dashboard: Fix test_remove_not_expired_trash qa test

Fixes: http://tracker.ceph.com/issues/37354
Signed-off-by: Tiago Melo <tmelo@suse.com>
6 years agoMerge pull request #25144 from rhcs-dashboard/wip-37295-master
Lenz Grimmer [Thu, 22 Nov 2018 09:54:02 +0000 (10:54 +0100)]
Merge pull request #25144 from rhcs-dashboard/wip-37295-master

mgr/dashboard: Show pool dropdown for block-mgr

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Ricardo Dias <rdias@suse.com>
Reviewed-by: Ricardo Marques <rimarques@suse.com>
6 years agoMerge pull request #25159 from tspmelo/wip-i18n-doc
Lenz Grimmer [Thu, 22 Nov 2018 09:53:22 +0000 (10:53 +0100)]
Merge pull request #25159 from tspmelo/wip-i18n-doc

mgr/dashboard: Update I18N documentation

Reviewed-by: Laura Paduano <lpaduano@suse.com>
Reviewed-by: Tatjana Dehler <tdehler@suse.com>
6 years agoMerge pull request #25181 from smithfarm/wip-37301
Nathan Cutler [Thu, 22 Nov 2018 09:12:09 +0000 (10:12 +0100)]
Merge pull request #25181 from smithfarm/wip-37301

build/ops: rpm: stop install-deps.sh clobbering spec file Python build setting

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
Reviewed-by: Lenz Grimmer <lgrimmer@suse.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Ken Dreyer <kdreyer@redhat.com>
Reviewed-by: Brad Hubbard <bhubbard@redhat.com>
Reviewed-by: Tim Serong <tserong@suse.com>
6 years agoMerge pull request #25205 from smithfarm/wip-37330
Kefu Chai [Thu, 22 Nov 2018 08:53:13 +0000 (16:53 +0800)]
Merge pull request #25205 from smithfarm/wip-37330

build/ops: do_cmake.sh: automate py3 build options for certain distros

Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Brad Hubbard <bhubbard@redhat.com>
Reviewed-by: Jason Dillaman <dillaman@redhat.com>
6 years agoMerge pull request #25211 from badone/wip-selinux-cr-repo-issue
Kefu Chai [Thu, 22 Nov 2018 08:34:37 +0000 (16:34 +0800)]
Merge pull request #25211 from badone/wip-selinux-cr-repo-issue

install-deps.sh: Remove CR repo

Reviewed-by: Kefu Chai <kchai@redhat.com>
6 years agoMerge pull request #24821 from k0ste/prometheus_metadata
Jan Fajerski [Thu, 22 Nov 2018 08:20:52 +0000 (09:20 +0100)]
Merge pull request #24821 from k0ste/prometheus_metadata

mgr: prometheus: added bluestore db and wal/journal devices to ceph_disk_occupation metric.

6 years agoMerge pull request #25200 from tchaikov/wip-silence-Wunused
Kefu Chai [Thu, 22 Nov 2018 05:05:33 +0000 (13:05 +0800)]
Merge pull request #25200 from tchaikov/wip-silence-Wunused

erasure-code,test: silence -Wunused-variable warnings

Reviewed-by: Neha Ojha <nojha@redhat.com>
6 years agoMerge pull request #25199 from tchaikov/wip-mgr-silence-py2-warning
Kefu Chai [Thu, 22 Nov 2018 03:34:05 +0000 (11:34 +0800)]
Merge pull request #25199 from tchaikov/wip-mgr-silence-py2-warning

mgr: silence GCC warning

Reviewed-by: Casey Bodley <cbodley@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
6 years agoMerge pull request #25204 from cbodley/wip-cmake-without-rbd-cephfs
Kefu Chai [Thu, 22 Nov 2018 03:32:15 +0000 (11:32 +0800)]
Merge pull request #25204 from cbodley/wip-cmake-without-rbd-cephfs

cmake: vstart target can build WITH_CEPHFS/RBD/MGR=OFF

Reviewed-by: Kefu Chai <kchai@redhat.com>
6 years agoMerge pull request #25114 from trociny/wip-osd-perf-query-generic
Jason Dillaman [Thu, 22 Nov 2018 02:12:41 +0000 (21:12 -0500)]
Merge pull request #25114 from trociny/wip-osd-perf-query-generic

 mgr: generalize osd perf query and make counters accessible from modules

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
6 years agorgw: remove unused aio helper functions 25239/head
Casey Bodley [Thu, 22 Nov 2018 02:10:54 +0000 (21:10 -0500)]
rgw: remove unused aio helper functions

Signed-off-by: Casey Bodley <cbodley@redhat.com>
6 years agocommon: fix a typo. 25197/head
Shiyang Ruan [Wed, 21 Nov 2018 06:24:39 +0000 (14:24 +0800)]
common: fix a typo.

Signed-off-by: Shiyang Ruan <ruansy.fnst@cn.fujitsu.com>
6 years agoMerge pull request #25209 from runsisi/wip-fix-missing-prefix
Jason Dillaman [Thu, 22 Nov 2018 01:17:07 +0000 (20:17 -0500)]
Merge pull request #25209 from runsisi/wip-fix-missing-prefix

test/librbd: metadata key for config should be prefixed with conf_

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
6 years agoMerge pull request #24936 from mikechristie/igw-selinux
Jason Dillaman [Thu, 22 Nov 2018 00:14:48 +0000 (19:14 -0500)]
Merge pull request #24936 from mikechristie/igw-selinux

selinux: add support for ceph iscsi

Reviewed-by: Boris Ranto <branto@redhat.com>
Reviewed-by: Jason Dillaman <dillaman@redhat.com>
6 years agoMerge pull request #24965 from yangdongsheng/token_fix
Jason Dillaman [Thu, 22 Nov 2018 00:13:52 +0000 (19:13 -0500)]
Merge pull request #24965 from yangdongsheng/token_fix

common: complete all throttle blockers when we set average or max to 0

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
6 years agoMerge pull request #25055 from runsisi/wip-fix-resize
Jason Dillaman [Thu, 22 Nov 2018 00:13:19 +0000 (19:13 -0500)]
Merge pull request #25055 from runsisi/wip-fix-resize

librbd: fix missing unblock_writes if shrink is not allowed

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
6 years agoMerge pull request #25152 from Songweibin/wip-fix-get-key
Jason Dillaman [Thu, 22 Nov 2018 00:13:02 +0000 (19:13 -0500)]
Merge pull request #25152 from Songweibin/wip-fix-get-key

 rbd: fix error parse arg when getting key

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
6 years agoinstall-deps.sh: Remove CR repo 25211/head
Brad Hubbard [Thu, 22 Nov 2018 00:07:22 +0000 (10:07 +1000)]
install-deps.sh: Remove CR repo

Remove the continuous release repos for CentOS and Virtuozzo 7 as they
should no longer be needed since http://tracker.ceph.com/issues/13997 is
no longer relevant and the newer versions of selinux packages pulled in
by the build system are causing problems for systems without CR repos
enabled.

Fixes: https://tracker.ceph.com/issues/37335
Signed-off-by: Alfredo Deza <adeza@redhat.com>
Signed-off-by: Brad Hubbard <bhubbard@redhat.com>
6 years agotest/librbd: metadata key for config should be prefixed with conf_ 25209/head
runsisi [Wed, 21 Nov 2018 23:42:14 +0000 (07:42 +0800)]
test/librbd: metadata key for config should be prefixed with conf_

Signed-off-by: runsisi <luo.runbing@zte.com.cn>
6 years agoMerge pull request #24452 from noahdesu/doc-edit-report
Neha Ojha [Wed, 21 Nov 2018 19:48:07 +0000 (11:48 -0800)]
Merge pull request #24452 from noahdesu/doc-edit-report

doc: edit on github

Reviewed-by: Neha Ojha <nojha@redhat.com>
Reviewed-by: Josh Durgin <jdurgin@redhat.com>
6 years agodoc/orchestrator: Integrate CLI specification into the documentation 25119/head
Sebastian Wagner [Thu, 15 Nov 2018 15:29:03 +0000 (16:29 +0100)]
doc/orchestrator: Integrate CLI specification into the documentation

Also: Make it clear that the orchestrator is WIP

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
6 years agobuild/ops: do_cmake.sh: automate py3 build options for certain distros 25205/head
Nathan Cutler [Wed, 21 Nov 2018 15:14:46 +0000 (16:14 +0100)]
build/ops: do_cmake.sh: automate py3 build options for certain distros

Before this patch, run-make-check.sh was setting the cmake options for
py3 build based only on the absence of a python2 binary in the system.
This was not sufficiently deterministic, and it didn't help folks who
run do_cmake.sh directly.

With this patch, we explicitly force the py3 build in do_cmake.sh, for
those OS types/versions we know need it.

Fixes: https://tracker.ceph.com/issues/37330
Signed-off-by: Nathan Cutler <ncutler@suse.com>
6 years agopybind/rbd: add namespace helper API methods 25206/head
Jason Dillaman [Wed, 21 Nov 2018 14:55:56 +0000 (09:55 -0500)]
pybind/rbd: add namespace helper API methods

Fixes: http://tracker.ceph.com/issues/36622
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
6 years agomgr/dashboard: Update I18N documentation 25159/head
Tiago Melo [Mon, 19 Nov 2018 16:28:24 +0000 (16:28 +0000)]
mgr/dashboard: Update I18N documentation

Add a Suggestions section.

Signed-off-by: Tiago Melo <tmelo@suse.com>
6 years agoMerge pull request #25157 from tspmelo/wip-e2e-stop
Lenz Grimmer [Wed, 21 Nov 2018 14:44:50 +0000 (15:44 +0100)]
Merge pull request #25157 from tspmelo/wip-e2e-stop

mgr/dashboard: Fix run-frontend-e2e-tests.sh

Reviewed-by: Laura Paduano <lpaduano@suse.com>
6 years agocmake: vstart-base only depends on ceph-mgr if WITH_MGR 25204/head
Casey Bodley [Wed, 21 Nov 2018 14:44:16 +0000 (09:44 -0500)]
cmake: vstart-base only depends on ceph-mgr if WITH_MGR

Signed-off-by: Casey Bodley <cbodley@redhat.com>
6 years agocmake: dont depend on cython_rbd if WITH_RBD=OFF
Casey Bodley [Wed, 21 Nov 2018 13:06:24 +0000 (08:06 -0500)]
cmake: dont depend on cython_rbd if WITH_RBD=OFF

Signed-off-by: Casey Bodley <cbodley@redhat.com>
6 years agocmake: dont build ceph-mds if WITH_CEPHFS=OFF
Casey Bodley [Wed, 21 Nov 2018 13:04:31 +0000 (08:04 -0500)]
cmake: dont build ceph-mds if WITH_CEPHFS=OFF

Signed-off-by: Casey Bodley <cbodley@redhat.com>
6 years agoMerge pull request #25155 from rhcs-dashboard/37283-mgr-info-card-improvements
Lenz Grimmer [Wed, 21 Nov 2018 13:55:39 +0000 (14:55 +0100)]
Merge pull request #25155 from rhcs-dashboard/37283-mgr-info-card-improvements

mgr/dashboard: Status info cards' improvements

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
6 years agodoc: describe RBD QoS settings 25202/head
Mykola Golub [Wed, 21 Nov 2018 11:20:48 +0000 (13:20 +0200)]
doc: describe RBD QoS settings

Signed-off-by: Mykola Golub <mgolub@suse.com>
6 years agoerasure-code,test: silence -Wunused-variable warnings 25200/head
Kefu Chai [Wed, 21 Nov 2018 12:43:38 +0000 (20:43 +0800)]
erasure-code,test: silence -Wunused-variable warnings

GCC 7.3 does not support [[maybe_unused]] very well, so it emits
-Wunused-variable warnings even if the variables are marked with
maybe_unused. moreover, the C++17 standard does not forbid these
warnings:

> For an entity marked maybe_unused, implementations are encouraged not
to emit a warning that the entity is unused, or that the entity is used
despite the presence of the attribute.

see also n4659, dcl.attr.unused

so, in this change, the warnings are silenced manually.

Signed-off-by: Kefu Chai <kchai@redhat.com>
6 years agomgr/dashboard: Status info cards' improvements 25155/head
alfonsomthd [Wed, 21 Nov 2018 12:46:56 +0000 (13:46 +0100)]
mgr/dashboard: Status info cards' improvements
- MGR info card:
  Show amount of daemons active instead of active mgr name.
  Daemons active text line: show mgr active name when 'on mouse over'.
- OSD/MDS info cards (for consistency):
  The same text appearance as MGR card.
- Hosts/Object Gateway/iSCSI cards: added 'total' after amount for clarification.
- Some CSS refactor.

Fixes: https://tracker.ceph.com/issues/37283
Signed-off-by: Alfonso Martínez <almartin@redhat.com>
6 years agoMerge pull request #24610 from SUSE/wip-orchestrator-deepsea-redux
Sebastian Wagner [Wed, 21 Nov 2018 12:37:51 +0000 (13:37 +0100)]
Merge pull request #24610 from SUSE/wip-orchestrator-deepsea-redux

mgr/deepsea: DeepSea orchestrator module

Reviewed-by: Jan Fajerski <jfajerski@suse.com>
Reviewed-by: John Spray <john.spray@redhat.com>
Reviewed-by: Sebastian Wagner <sebastian.wagner@suse.com>
6 years agomgr: prometheus: added bluestore db and wal devices to ceph_disk_occupation metric. 24821/head
Konstantin Shalygin [Tue, 30 Oct 2018 06:43:02 +0000 (13:43 +0700)]
mgr: prometheus: added bluestore db and wal devices to ceph_disk_occupation metric.

Signed-off-by: Konstantin Shalygin <k0ste@k0ste.ru>
6 years agomgr/deepsea: DeepSea orchestrator module 24610/head
Tim Serong [Tue, 16 Oct 2018 08:39:41 +0000 (19:39 +1100)]
mgr/deepsea: DeepSea orchestrator module

This module provides integration between Ceph's orchestrator framework
and DeepSea, a Ceph deployment and management system built upon Salt.

Included so far are implementations of get_inventory() and
describe_service().  This allows `ceph orchestrator device ls`, `ceph
orchestrator service ls` and `ceph orchestrator service status` to
operate correctly.

To test, try:

  # ceph mgr module enable orchestrator_cli
  # ceph mgr module enable deepsea
  # ceph orchestrator set backend deepsea
  # ceph deepsea config-set salt_api_url <salt api url>
  # ceph deepsea config-set salt_api_username <salt api username>
  # ceph deepsea config-set salt_api_password <salt api shared secret>
  # ceph orchestrator device ls
  # ceph orchestrator service ls

Signed-off-by: Tim Serong <tserong@suse.com>
6 years agomgr: silence GCC warning 25199/head
Kefu Chai [Wed, 21 Nov 2018 08:56:52 +0000 (16:56 +0800)]
mgr: silence GCC warning

the signature of PyObject_CallMethod() is different in python2 and
python3:

in python2: it is

PyObject* PyObject_CallMethod(PyObject *o, char *method, char *format,
...)

while in python3, it is

PyObject* PyObject_CallMethod(PyObject *obj, const char *name, const
char *format, ...)

so, if we compile mgr with python2, we will have following warning:

warning: ISO C++ forbids converting a string constant to ‘char*’
[-Wwrite-strings]
        (char*)NULL);
                   ^

it'd be simpler if we just const_cast<> the method name string, to
silence the warning just like other places we call
PyObject_CallMethod().

Signed-off-by: Kefu Chai <kchai@redhat.com>
6 years agoMerge PR #25167 into master
Sage Weil [Tue, 20 Nov 2018 23:35:16 +0000 (17:35 -0600)]
Merge PR #25167 into master

* refs/pull/25167/head:
mgr: Diskprediction local activate when config changes

Reviewed-by: Sage Weil <sage@redhat.com>
6 years agoMerge PR #24795 into master
Sage Weil [Tue, 20 Nov 2018 23:34:54 +0000 (17:34 -0600)]
Merge PR #24795 into master

* refs/pull/24795/head:
qa/tasks/ceph: gather crash dumps

6 years agoqa/tasks/ceph_manager: avoid test_map_discontinuity stall with too few up osds 17526/head
Sage Weil [Wed, 6 Sep 2017 17:27:33 +0000 (13:27 -0400)]
qa/tasks/ceph_manager: avoid test_map_discontinuity stall with too few up osds

Some tests have m=2,k=2 and this will break them.  Sometimes even if we
have 5 up osds, we end up with 4 and CRUSH gets picky, so build in a
buffer and only do this if we have 6 up.

We don't have an easy way from here to see what the min up osds for healthy
is...  basically this map discontinuity test just sucks.

Signed-off-by: Sage Weil <sage@redhat.com>
6 years agoMerge pull request #14369 from rzarzynski/wip-rgw-19514
Yuri Weinstein [Tue, 20 Nov 2018 22:01:41 +0000 (14:01 -0800)]
Merge pull request #14369 from rzarzynski/wip-rgw-19514

rgw: fix wrong debug related to user ACLs in rgw_build_bucket_policies()

Reviewed-by: Adam Emerson <aemerson@redhat.com>
Reviewed-by: Casey Bodley <cbodley@redhat.com>
6 years agoMerge pull request #16658 from rzarzynski/wip-rgw-20795
Yuri Weinstein [Tue, 20 Nov 2018 22:00:57 +0000 (14:00 -0800)]
Merge pull request #16658 from rzarzynski/wip-rgw-20795

rgw: Swift's TempURL can handle temp_url_expires written in ISO8601.

Reviewed-by: Matt Benjamin <mbenjami@redhat.com>
6 years agoMerge pull request #19684 from taoCH/wip-librgw-symbolic-link
Yuri Weinstein [Tue, 20 Nov 2018 22:00:41 +0000 (14:00 -0800)]
Merge pull request #19684 from taoCH/wip-librgw-symbolic-link

librgw: support symbolic link

Reviewed-by: Matt Benjamin <mbenjami@redhat.com>
6 years agomgr/osd_perf_query: improvements for testing module 25114/head
Mykola Golub [Thu, 15 Nov 2018 09:09:01 +0000 (11:09 +0200)]
mgr/osd_perf_query: improvements for testing module

Signed-off-by: Mykola Golub <mgolub@suse.com>
6 years agoMerge pull request #22599 from anthonyeleven/patch-2
Robin H. Johnson [Tue, 20 Nov 2018 17:44:04 +0000 (09:44 -0800)]
Merge pull request #22599 from anthonyeleven/patch-2

doc: Tidy up description wording and spelling

6 years agoMerge PR #24737 into master
Sage Weil [Tue, 20 Nov 2018 15:50:04 +0000 (09:50 -0600)]
Merge PR #24737 into master

* refs/pull/24737/head:
doc/ceph-bluestore-tool: add help for migrate and new DB/WAL commands.

Reviewed-by: Sage Weil <sage@redhat.com>
6 years agoMerge pull request #25010 from nathan-weinberg/breadcrumb-tests
Lenz Grimmer [Tue, 20 Nov 2018 15:36:48 +0000 (16:36 +0100)]
Merge pull request #25010 from nathan-weinberg/breadcrumb-tests

mgr/dashboard: Added additional breadcrumb tests to Cluster

Reviewed-by: Laura Paduano <lpaduano@suse.com>
Reviewed-by: Stephan Müller <smueller@suse.com>
Reviewed-by: Tiago Melo <tmelo@suse.com>
6 years agoMerge pull request #25141 from rhcs-dashboard/wip-37293-master
Lenz Grimmer [Tue, 20 Nov 2018 15:34:59 +0000 (16:34 +0100)]
Merge pull request #25141 from rhcs-dashboard/wip-37293-master

mgr/dashboard: Fix Forbidden Error with some roles

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Ricardo Dias <rdias@suse.com>
6 years agocmake: do not pass unnecessary param to setup.py 25186/head
Kefu Chai [Tue, 20 Nov 2018 14:13:35 +0000 (22:13 +0800)]
cmake: do not pass unnecessary param to setup.py

--single-version-externally-managed is used for packaging python eggs
to deb. so the metadata can be stored in the egg, and can be accessed
by user if necessary, see [1]. but this does not apply to users who
just want to "make install" without packaging Ceph.

the problem is, if we pass --single-version-externally-managed to
setup.py, we need to pass --record or --root also. otherwise setuptools
complains:

error: You must specify --record or --root when building system packages

so in this change, we choose not to pass
"--single-version-externally-managed", unless $DESTDIR is set.

both "ceph.spec.in" and "debian/rules" set $DESTDIR when running "make
install". so we can always check $DESTDIR to tell if current "make
install" is launched by the packaging script or not. this might not be
accurate, but good enough. assuming enduser does not use DESTDIR when
running plain "make install".

--
[1] https://wiki.debian.org/Python/FAQ#How_should_we_package_Python_eggs.3F

Signed-off-by: Kefu Chai <kchai@redhat.com>
6 years agoauth/AuthSessionHandler: no handler if no session key 25185/head
Sage Weil [Mon, 19 Nov 2018 15:06:26 +0000 (09:06 -0600)]
auth/AuthSessionHandler: no handler if no session key

If there is no session key, then we should not instantiate a session
handler, or else we'll later crash with something like

     0> 2018-11-19 08:52:27.787 7f6b305e4700 -1 /home/sage/src/ceph.mimic/src/auth/Crypto.h: In function 'std::size_t CryptoKey::encrypt(CephContext*, const in_slice_t&, const out_slice_t&)' thread 7f6b305e4700 time 2018-11-19 08:52:27.784394
/home/sage/src/ceph.mimic/src/auth/Crypto.h: 164: FAILED assert(ckh)

 ceph version 13.2.2-411-g4bfd25addd (4bfd25addd77b8ea785c8b84a073cff0c477e906) mimic (stable)
 1: (ceph::__ceph_assert_fail(char const*, char const*, int, char const*)+0x102) [0x7f6b36ad7e72]
 2: (()+0x2ab007) [0x7f6b36ad8007]
 3: (CephxSessionHandler::_calc_signature(Message*, unsigned long*)+0x297) [0x7f6b36e13007]
 4: (CephxSessionHandler::check_message_signature(Message*)+0x6b) [0x7f6b36e131ab]
 5: (AsyncConnection::process()+0x1dc5) [0x7f6b36bfbc55]
 6: (EventCenter::process_events(unsigned int, std::chrono::duration<unsigned long, std::ratio<1l, 1000000000l> >*)+0x6a5) [0x7f6b36c0abb5]

The specific scenario is:

- new (nautilus) OSD connects to heartbeat port on an older OSD (<= mimic)
and sends an authorizer
- mimic osd ms_verify_authorizer succeeds, but does not set up the
session key because mimic doesn't care.. it blindly sets isvalid = true.
- mimic osd later creates a session handler
- mimic osd later tries to validate a message and crashes

The fix is to not instantiate the session handler if there is no key. Note
that this happens *after* we have authenticated the request (called
ms_verify_authorizer), which is responsible for populating the session
key while verifying the authorizer (if it is authenticating at all), so
this session_key is always set on an authenticated connection.

Fixes: http://tracker.ceph.com/issues/36443
Signed-off-by: Sage Weil <sage@redhat.com>
6 years agobuild/ops: rpm: add link to doc explaining bcond syntax 25181/head
Nathan Cutler [Tue, 20 Nov 2018 12:30:34 +0000 (13:30 +0100)]
build/ops: rpm: add link to doc explaining bcond syntax

The %bcond_with and %bcond_without macros are confusing to folks who
don't do a lot of RPM packaging work. Let's try to help these folks out!

Signed-off-by: Nathan Cutler <ncutler@suse.com>
6 years agobuild/ops: rpm: stop install-deps.sh clobbering spec file Python build setting
Nathan Cutler [Tue, 20 Nov 2018 10:43:13 +0000 (11:43 +0100)]
build/ops: rpm: stop install-deps.sh clobbering spec file Python build setting

Fedora 29 still ships a Python 2 binary, but some of Ceph's build
dependencies are only available in py3 versions there. In other
words, from F29 on, it is no longer possible to do a py2 Ceph build
on Fedora, even if a python2 binary exists on the system.

If that were not enough, the Python 2 that ships with Fedora 29 is
linked against a non-compatible version of OpenSSL.

Before this commit, install-deps.sh was overriding the spec file's
Python build setting based on the presence or absence of a python2
binary. As the bug cited below indicates, this was not a good idea.

It's better for the spec file to be explicit about which OS versions
are py2 and which are py3, and just stick to that.

Fixes: http://tracker.ceph.com/issues/37301
Signed-off-by: Brad Hubbard <bhubbard@redhat.com>
Signed-off-by: Nathan Cutler <ncutler@suse.com>
6 years agoMerge pull request #25176 from cyx1231st/wip-crimson-msgr-extract-states
Kefu Chai [Tue, 20 Nov 2018 13:58:37 +0000 (21:58 +0800)]
Merge pull request #25176 from cyx1231st/wip-crimson-msgr-extract-states

crimson/net: encapsulate protocol implementations with states

Reviewed-by: Kefu Chai <kchai@redhat.com>
6 years agocrimson/net: remove recursive call to handle_connect_reply() 25176/head
Yingxin [Wed, 7 Nov 2018 11:58:24 +0000 (19:58 +0800)]
crimson/net: remove recursive call to handle_connect_reply()

Signed-off-by: Yingxin <yingxin.cheng@intel.com>
6 years agocrimson/net: fix minor issue and add TODO for error-handling
Yingxin [Tue, 20 Nov 2018 14:07:57 +0000 (22:07 +0800)]
crimson/net: fix minor issue and add TODO for error-handling

Signed-off-by: Yingxin <yingxin.cheng@intel.com>
6 years agocrimson/net: extract state transition out of repeat_connect()
Kefu Chai [Mon, 19 Nov 2018 08:09:53 +0000 (16:09 +0800)]
crimson/net: extract state transition out of repeat_connect()

and extract state transition out of repeat_handle_connect()

in this change, the connect/handle-connect loop is restructured, to
avoid ad-hoc state changes in helper functions. this pave the road to
explicit state transtion using named states.

also, exception is thrown instead in handle_connect_reply(), we should
not proceed in case of failures. and we need do error handling in the
named state in future.

currentl, `state` is set to `state_t::open` in `start_connect()` and
`start_accept()`, the next step is to set it in a named state.

Signed-off-by: Kefu Chai <kchai@redhat.com>
6 years agoMerge pull request #25149 from p-na/pna-fix-safe-to-destroy
Lenz Grimmer [Tue, 20 Nov 2018 13:33:42 +0000 (14:33 +0100)]
Merge pull request #25149 from p-na/pna-fix-safe-to-destroy

mgr/dashboard: Fix failing QA test: test_safe_to_destroy

Reviewed-by: Laura Paduano <lpaduano@suse.com>
Reviewed-by: Tatjana Dehler <tdehler@suse.com>
6 years agocrimson/net: define an alias of seastar::stop_iteration
Kefu Chai [Mon, 19 Nov 2018 07:05:51 +0000 (15:05 +0800)]
crimson/net: define an alias of seastar::stop_iteration

Signed-off-by: Kefu Chai <kchai@redhat.com>
6 years agocrimson/net: check short reads in `read_exactly()`
Yingxin [Wed, 24 Oct 2018 14:49:30 +0000 (22:49 +0800)]
crimson/net: check short reads in `read_exactly()`

Signed-off-by: Yingxin <yingxin.cheng@intel.com>
6 years agoMerge PR #24844 into master
Sage Weil [Tue, 20 Nov 2018 12:51:29 +0000 (06:51 -0600)]
Merge PR #24844 into master

* refs/pull/24844/head:
osd: drop PGBackend::Listener::get_epoch().
osd: massively switch to get_osdmap_epoch().
osd: switch the return type of PG::get_osdmap().

Reviewed-by: Sage Weil <sage@redhat.com>
6 years agoMerge PR #24867 into master
Sage Weil [Tue, 20 Nov 2018 12:50:50 +0000 (06:50 -0600)]
Merge PR #24867 into master

* refs/pull/24867/head:
mon: compensate for not having STDLIB_MAP_SPLICING

Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: João Eduardo Luís <joao@suse.de>
6 years agoMerge PR #24929 into master
Sage Weil [Tue, 20 Nov 2018 12:50:33 +0000 (06:50 -0600)]
Merge PR #24929 into master

* refs/pull/24929/head:
osd: set lower bound+docs on osd_max_write_size

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
6 years agoMerge PR #25058 into master
Sage Weil [Tue, 20 Nov 2018 12:50:17 +0000 (06:50 -0600)]
Merge PR #25058 into master

* refs/pull/25058/head:
mgr: Fixed devicehealth plugin resource leak

Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Sage Weil <sage@redhat.com>
6 years agoMerge PR #25125 into master
Sage Weil [Tue, 20 Nov 2018 12:49:54 +0000 (06:49 -0600)]
Merge PR #25125 into master

* refs/pull/25125/head:
mon: require keyring even if cephx is optional

Reviewed-by: Sage Weil <sage@redhat.com>
6 years agoqa/tasks/ceph: gather crash dumps 24795/head
Sage Weil [Sun, 28 Oct 2018 14:26:00 +0000 (09:26 -0500)]
qa/tasks/ceph: gather crash dumps

Gather crash dumps as part of the teuthology run.

Signed-off-by: Sage Weil <sage@redhat.com>
6 years agocrimson/net: connection closed during connecting
Yingxin [Wed, 17 Oct 2018 20:45:53 +0000 (04:45 +0800)]
crimson/net: connection closed during connecting

It is possible during `seastar::connect()`, the connection is marked
closed (when SocketConnection::socket is unavailable), then
`seastar::connect()` successfully returns a connected socket.

Signed-off-by: Yingxin <yingxin.cheng@intel.com>
6 years agodoc/mgr/prometheus: readd section about custom instance labels 25182/head
Jan Fajerski [Tue, 20 Nov 2018 11:43:12 +0000 (12:43 +0100)]
doc/mgr/prometheus: readd section about custom instance labels

This section was removed accidentally by
331a826a9f7433812dc5ed789ac7652e00aaaa71. It offers a helpful configuration
variant to deal with mgr failovers.

Signed-off-by: Jan Fajerski <jfajerski@suse.com>
6 years agoMerge pull request #25121 from zmc/wip-dashboard-test-runner
Lenz Grimmer [Tue, 20 Nov 2018 11:29:35 +0000 (12:29 +0100)]
Merge pull request #25121 from zmc/wip-dashboard-test-runner

mgr/dashboard: Small improvements for running teuthology tests

Reviewed-by: Patrick Nawracay <pnawracay@suse.com>
6 years agomgr: parse OSDPerfMetricQuery spec that comes from python module
Mykola Golub [Thu, 15 Nov 2018 08:59:40 +0000 (10:59 +0200)]
mgr: parse OSDPerfMetricQuery spec that comes from python module

Signed-off-by: Mykola Golub <mgolub@suse.com>
6 years agomgr: make dynamic osd perf counters accessible from modules
Mykola Golub [Wed, 14 Nov 2018 07:33:01 +0000 (09:33 +0200)]
mgr: make dynamic osd perf counters accessible from modules

Signed-off-by: Mykola Golub <mgolub@suse.com>
6 years agoosd: fixup to recently added dynamic perf stats
Mykola Golub [Wed, 14 Nov 2018 07:28:10 +0000 (09:28 +0200)]
osd: fixup to recently added dynamic perf stats

Signed-off-by: Mykola Golub <mgolub@suse.com>
6 years agomgr: fix PyFormatter's dump_unsigned
Mykola Golub [Wed, 14 Nov 2018 07:26:03 +0000 (09:26 +0200)]
mgr: fix PyFormatter's dump_unsigned

Signed-off-by: Mykola Golub <mgolub@suse.com>
6 years agomgr: store osd perf counters received in osd reports
Mykola Golub [Mon, 12 Nov 2018 18:41:42 +0000 (20:41 +0200)]
mgr: store osd perf counters received in osd reports

Make the counters accessible for the query owners.

Signed-off-by: Mykola Golub <mgolub@suse.com>
6 years agomgr: generalize OSDPerfMetricQuery to support different queries
Mykola Golub [Mon, 12 Nov 2018 18:39:33 +0000 (20:39 +0200)]
mgr: generalize OSDPerfMetricQuery to support different queries

Signed-off-by: Mykola Golub <mgolub@suse.com>
6 years agoMerge pull request #24851 from rhcs-dashboard/grafana-roles
Lenz Grimmer [Tue, 20 Nov 2018 09:21:04 +0000 (10:21 +0100)]
Merge pull request #24851 from rhcs-dashboard/grafana-roles

mgr/dashboard: Show/Hide Grafana tabs according to user role

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Tiago Melo <tmelo@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>
6 years agoMerge pull request #24762 from tspmelo/wip-credits
Abhishek L [Tue, 20 Nov 2018 08:40:59 +0000 (09:40 +0100)]
Merge pull request #24762 from tspmelo/wip-credits

credits.sh: Ignore package-lock.json and .xlf files

Reviewed-By: Lenz Grimmer <lgrimmer@suse.com>
Reviewed-By: Nathan Cutler <ncutler@suse.com>
Reviewed-By: Abhishek Lekshmanan <abhishek@suse.com>
6 years agomgr/dashboard: Can't handle user editing when tenants are specified 24757/head
Volker Theile [Tue, 20 Nov 2018 08:07:28 +0000 (09:07 +0100)]
mgr/dashboard: Can't handle user editing when tenants are specified

Fixes: https://tracker.ceph.com/issues/36480
Signed-off-by: Volker Theile <vtheile@suse.com>
6 years agoMerge pull request #25169 from tchaikov/wip-install-libboost-bionic
Kefu Chai [Tue, 20 Nov 2018 07:54:34 +0000 (15:54 +0800)]
Merge pull request #25169 from tchaikov/wip-install-libboost-bionic

install-deps.sh: fix gcc detection and install pre-built libboost on bionic

Tested-by: Changcheng Liu <changcheng.liu@intel.com>
Reviewed-by: Changcheng Liu <changcheng.liu@intel.com>
6 years agoinstall-deps.sh: install prebuilt libboost dependencies for bionic also 25169/head
Kefu Chai [Tue, 20 Nov 2018 04:43:34 +0000 (12:43 +0800)]
install-deps.sh: install prebuilt libboost dependencies for bionic also

* extract boost install function into a helper, so we don't need to
  repeat it when adding support for new distros.
* install ceph-libboost-* for bionic build also. we check for the
  existence in run-make-check.sh, so there is no need to update
  the build script elsewhere.

Signed-off-by: Kefu Chai <kchai@redhat.com>
6 years agoinstall-deps.sh: correct gcc version info as major.minor.patch
Changcheng Liu [Fri, 26 Oct 2018 06:32:09 +0000 (14:32 +0800)]
install-deps.sh: correct gcc version info as major.minor.patch

On ubuntu 18.04, "gcc -dumpversion" output "7", it result in
that below check will return false:
    dpkg --compare-versions 7 ge 7.0
Then, this script will install other gcc.

Actully, the full gcc version "gcc -dumpfullversion" output is
"7.3.0", than below check will turn true:
    dpkg --compare-version 7.3.0 ge 7.0
So, there's no need to install other gcc.

In case of hitting error on ubuntu16.04, use below parameter:
   gcc -dumpfullversion -dumpversion

Signed-off-by: Changcheng Liu <changcheng.liu@intel.com>
6 years agomgr: Diskprediction local activate when config changes 25167/head
hsiang41 [Tue, 20 Nov 2018 03:03:03 +0000 (11:03 +0800)]
mgr: Diskprediction local activate when config changes

Trigger diskprediction local action when receive notify configuration changed.

Signed-off-by: Rick Chen <rick.chen@prophetstor.com>
6 years agoMerge PR #24874 into master
Sage Weil [Mon, 19 Nov 2018 23:31:17 +0000 (17:31 -0600)]
Merge PR #24874 into master

* refs/pull/24874/head:
os/filestore: collect partition/device metadata from journal
os/filestore: include journal in get_devices result

Reviewed-by: Rick Chen <rick.chen@prophetstor.com>
Reviewed-by: Brad Hubbard <bhubbard@redhat.com>
6 years agoMerge PR #25140 into master
Sage Weil [Mon, 19 Nov 2018 23:29:57 +0000 (17:29 -0600)]
Merge PR #25140 into master

* refs/pull/25140/head:
mon: by default, do NOT warn about misplaced objects
mon: add mon_warn_on_misplaced option

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: João Eduardo Luís <joao@suse.de>
6 years agoMerge PR #25147 into master
Sage Weil [Mon, 19 Nov 2018 23:29:41 +0000 (17:29 -0600)]
Merge PR #25147 into master

* refs/pull/25147/head:
mgr/devicehealth: implement config_notify hook
mgr: call config_notify method when mgr's config has changed
mon/MonClient: add callback for (any) config change
common/config: fix debug output for config callbacks changes

Reviewed-by: Tim Serong <tserong@suse.com>
6 years agoMerge PR #25158 into master
Patrick Donnelly [Mon, 19 Nov 2018 22:17:14 +0000 (14:17 -0800)]
Merge PR #25158 into master

* refs/pull/25158/head:
[doc] Fix typo in luminious release notes

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
6 years agomgr/dashboard: Fix run-frontend-e2e-tests.sh 25157/head
Tiago Melo [Mon, 19 Nov 2018 15:07:07 +0000 (15:07 +0000)]
mgr/dashboard: Fix run-frontend-e2e-tests.sh

e2e tests were always returning positive result, even when they failed.

Fixed problem with jq, where it was failing when it was not receiving a string.

Signed-off-by: Tiago Melo <tmelo@suse.com>