]> git.apps.os.sepia.ceph.com Git - ceph.git/log
ceph.git
4 months agoMerge pull request #62316 from anthonyeleven/cme
Zac Dover [Sat, 15 Mar 2025 02:22:03 +0000 (12:22 +1000)]
Merge pull request #62316 from anthonyeleven/cme

doc/rados/operations: improve crush-map-edits.rst

Reviewed-by: Zac Dover <zac.dover@proton.me>
4 months agodoc/rados/operations: improve crush-map-edits.rst 62316/head
Anthony D'Atri [Sat, 15 Mar 2025 01:59:57 +0000 (21:59 -0400)]
doc/rados/operations: improve crush-map-edits.rst

Signed-off-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
4 months agoMerge pull request #61816 from ljflores/wip-tracker-62776
SrinivasaBharathKanta [Fri, 14 Mar 2025 23:11:13 +0000 (04:41 +0530)]
Merge pull request #61816 from ljflores/wip-tracker-62776

qa/suites/rados/basic: ignore POOL_APP_NOT_ENABLED detail in cluster log

4 months agoMerge pull request #57046 from clwluvw/vault-del-bucketkey
Casey Bodley [Fri, 14 Mar 2025 20:12:44 +0000 (16:12 -0400)]
Merge pull request #57046 from clwluvw/vault-del-bucketkey

rgw: false assumption on vault bucket key deletion

Reviewed-by: Casey Bodley <cbodley@redhat.com>
4 months agoMerge PR #62231 into main
Patrick Donnelly [Fri, 14 Mar 2025 15:45:30 +0000 (11:45 -0400)]
Merge PR #62231 into main

* refs/pull/62231/head:
mds: set alternate_name for new fullbit dentries
qa: test alternate_name recovery during mds failover

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Kotresh Hiremath Ravishankar <khiremat@redhat.com>
4 months agoMerge pull request #62194 from rhcs-dashboard/fix-token-polling
Nizamudeen A [Fri, 14 Mar 2025 14:28:19 +0000 (19:58 +0530)]
Merge pull request #62194 from rhcs-dashboard/fix-token-polling

mgr/dashboard: fix token polling req in multi-cluster UI

4 months agoMerge pull request #61772 from rhcs-dashboard/fix-multisite-wizard-forms
Nizamudeen A [Fri, 14 Mar 2025 14:26:50 +0000 (19:56 +0530)]
Merge pull request #61772 from rhcs-dashboard/fix-multisite-wizard-forms

mgr/dashboard: fix multisite wizard form not showing

4 months agoMerge pull request #61781 from rhcs-dashboard/xml-fix
Nizamudeen A [Fri, 14 Mar 2025 14:25:47 +0000 (19:55 +0530)]
Merge pull request #61781 from rhcs-dashboard/xml-fix

mgr/dashboard: fix lifecycle get request

4 months agoMerge PR #61877 into main
Venky Shankar [Fri, 14 Mar 2025 14:07:28 +0000 (19:37 +0530)]
Merge PR #61877 into main

* refs/pull/61877/head:
libcephfs_proxy: implement client side async rw operation
libcephfs_proxy: implement server side async rw operation
libcephfs_proxy: implement the async rw callback
libcephfs_proxy: define async rw opcode and structures
libcephfs_proxy: define some helper macros for callbacks
libcephfs_proxy: move pointer obfuscation functions to proxy_helpers.h
libcephfs_proxy: negotiate and use the async cbk feature
libcephfs_proxy: implement asynchronous callbacks
libcephfs_proxy: gracefully handle connection close
libcephfs_proxy: add negotiation documentation
libcephfs_proxy: replace legacy handshake by negotation in server side
libcephfs_proxy: replace legacy handshake by negotation in client side
libcephfs_proxy: implement server side negotiation
libcephfs_proxy: implement client side negotiation
libcephfs_proxy: implement receiving of negotiate structure
libcephfs_proxy: add negotiation structures
libcephfs_proxy: add support for control messages
libcephfs_proxy: reuse proxy_link_{read|write}

Reviewed-by: Sachin Prabhu <sp@spui.uk>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
4 months agoMerge PR #62228 into main
Patrick Donnelly [Fri, 14 Mar 2025 12:29:12 +0000 (08:29 -0400)]
Merge PR #62228 into main

* refs/pull/62228/head:
libcephfs: getcwd after chdir for API constraint
client: unwrap dentries for getcwd
client: refactor / optimize chdir
test/libcephfs: test getcwd with case insensitive dir
test/libcephfs: refactor ManyNestedDirs
include/filepath: add iterators for components

Reviewed-by: Venky Shankar <vshankar@redhat.com>
4 months agoMerge pull request #62296 from afreen23/wip-sso-fix
Pedro Gonzalez Gomez [Fri, 14 Mar 2025 11:19:34 +0000 (12:19 +0100)]
Merge pull request #62296 from afreen23/wip-sso-fix

mgr/dashboard: fix OAuth2 SSO when roles_path is empty

Reviewed-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
4 months agomgr/dashboard: add basic e2e to verify wizard 61772/head
Nizamudeen A [Wed, 12 Feb 2025 14:14:15 +0000 (19:44 +0530)]
mgr/dashboard: add basic e2e to verify wizard

and topology viewer

Fixes: https://tracker.ceph.com/issues/69925
Signed-off-by: Nizamudeen A <nia@redhat.com>
4 months agomgr/dashboard: fix multisite wizard form not showing
Nizamudeen A [Wed, 12 Feb 2025 14:11:44 +0000 (19:41 +0530)]
mgr/dashboard: fix multisite wizard form not showing

Fixes: https://tracker.ceph.com/issues/69925
Signed-off-by: Nizamudeen A <nia@redhat.com>
4 months agoMerge pull request #62119 from MartinNowak/patch-2
Zac Dover [Fri, 14 Mar 2025 06:54:17 +0000 (16:54 +1000)]
Merge pull request #62119 from MartinNowak/patch-2

doc/radosgw: Improve bucketpolicy.rst #58689 - document SSE-C IAM condition key

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
4 months agomgr/dashboard: fix OAuth2 SSO when roles_path is empty 62296/head
Afreen Misbah [Fri, 14 Mar 2025 05:50:30 +0000 (11:20 +0530)]
mgr/dashboard: fix OAuth2 SSO when roles_path is empty

Fixes https://tracker.ceph.com/issues/70454

Due to PR linter updates, this place remained not updated hence failing

Signed-off-by: Afreen Misbah <afreen@ibm.com>
4 months agoMerge pull request #62258 from dvanders/dvanders_doc_fix
Zac Dover [Fri, 14 Mar 2025 00:38:54 +0000 (10:38 +1000)]
Merge pull request #62258 from dvanders/dvanders_doc_fix

doc/rados/configuration/bluestore-config-ref: Fix lowercase typos

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Reviewed-by: Patrick Donnelly <pdonnell@ibm.com>
4 months agoMerge PR #62232 into main
Patrick Donnelly [Thu, 13 Mar 2025 21:01:31 +0000 (17:01 -0400)]
Merge PR #62232 into main

* refs/pull/62232/head:
include/cephfs: dump optmetadata

Reviewed-by: Dhairya Parmar <dparmar@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
4 months agomgr/dashboard: add xlmtodict import and fix lifecycle get request 61781/head
Pedro Gonzalez Gomez [Wed, 12 Feb 2025 19:24:57 +0000 (20:24 +0100)]
mgr/dashboard: add xlmtodict import and fix lifecycle get request

Fixes: https://tracker.ceph.com/issues/70128
Signed-off-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
4 months agoMerge pull request #62274 from phlogistonjohn/jjm-more-bwc-fixes
Dan Mick [Thu, 13 Mar 2025 20:10:52 +0000 (13:10 -0700)]
Merge pull request #62274 from phlogistonjohn/jjm-more-bwc-fixes

build-with-container: two small fixes

4 months agoMerge pull request #62252 from ronen-fr/wip-rf-fix-62188
Ilya Dryomov [Thu, 13 Mar 2025 19:42:27 +0000 (20:42 +0100)]
Merge pull request #62252 from ronen-fr/wip-rf-fix-62188

librbd/ConfigWatcher: fix a missing 'override'

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
Reviewed-by: Patrick Donnelly <pdonnell@ibm.com>
4 months agoMerge PR #54396 into main
Venky Shankar [Thu, 13 Mar 2025 16:57:57 +0000 (22:27 +0530)]
Merge PR #54396 into main

* refs/pull/54396/head:
PendingReleaseNote: add note for pause_purging and pause_cloninig
doc/cephfs: add note for config option pause_purging and pause_cloning
qa/cephfs: add tests for mgr/vol config pause_cloning
qa/cephfs: extend wait for trash empty
qa/cephfs: add tests for config option pause_purging
qa/cephfs: don't strip any whitespace for get_shell_stdout
mgr/vol: add pause/resume mechanism for async jobs

Reviewed-by: Venky Shankar <vshankar@redhat.com>
4 months agoMerge PR #62240 into main
Patrick Donnelly [Thu, 13 Mar 2025 16:05:18 +0000 (12:05 -0400)]
Merge PR #62240 into main

* refs/pull/62240/head:
qa/cephfs: require-osd-release should now be tentacle

Reviewed-by: Patrick Donnelly <pdonnell@ibm.com>
4 months agoMerge PR #62200 into main
Patrick Donnelly [Thu, 13 Mar 2025 15:51:06 +0000 (11:51 -0400)]
Merge PR #62200 into main

* refs/pull/62200/head:
common/include: Add map type election and fmt::format to interval_map

Reviewed-by: Patrick Donnelly <pdonnell@ibm.com>
4 months agoMerge pull request #59780 from irq0/wip/osd-asok-messenger-dump
Marcel Lauhoff [Thu, 13 Mar 2025 15:40:53 +0000 (16:40 +0100)]
Merge pull request #59780 from irq0/wip/osd-asok-messenger-dump

Add Asok Command: Dump Messenger Status (Connections, TCP stats, ..)

4 months agoMerge PR #62230 into main
Patrick Donnelly [Thu, 13 Mar 2025 15:19:09 +0000 (11:19 -0400)]
Merge PR #62230 into main

* refs/pull/62230/head:
client: avoid multiple calls to path_walk

Reviewed-by: Christopher Hoffman <choffman@redhat.com>
4 months agoMerge pull request #61791 from MaxKellermann/common_includes
Max Kellermann [Thu, 13 Mar 2025 15:11:35 +0000 (16:11 +0100)]
Merge pull request #61791 from MaxKellermann/common_includes

common: add missing includes

Reviewed-By: Adam Emerson <aemerson@ibm.com>
4 months agoinclude/cephfs: dump optmetadata 62232/head
Patrick Donnelly [Tue, 11 Mar 2025 19:03:59 +0000 (15:03 -0400)]
include/cephfs: dump optmetadata

For inspection from `dump tree` MDS command.

Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>
4 months agomds: set alternate_name for new fullbit dentries 62231/head
Patrick Donnelly [Tue, 11 Mar 2025 19:01:46 +0000 (15:01 -0400)]
mds: set alternate_name for new fullbit dentries

Fixes: 9fbf37ade38bc1d057eda2459b0ccfd2ab40626a
Fixes: https://tracker.ceph.com/issues/70409
Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>
4 months agoqa: test alternate_name recovery during mds failover
Patrick Donnelly [Tue, 11 Mar 2025 19:18:03 +0000 (15:18 -0400)]
qa: test alternate_name recovery during mds failover

Fixes: https://tracker.ceph.com/issues/70409
Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>
4 months agolibcephfs: getcwd after chdir for API constraint 62228/head
Patrick Donnelly [Wed, 12 Mar 2025 14:33:02 +0000 (10:33 -0400)]
libcephfs: getcwd after chdir for API constraint

libcephfs semantics require that the old path to the cwd be returned when
getcwd is encounters an unlinked directory in the current working directory.

Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>
4 months agoclient: unwrap dentries for getcwd
Patrick Donnelly [Tue, 11 Mar 2025 14:51:38 +0000 (10:51 -0400)]
client: unwrap dentries for getcwd

This was missed in the path_walk refactor. readdir is not the only way to "get"
dentry names.

Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>
4 months agoclient: refactor / optimize chdir
Patrick Donnelly [Tue, 11 Mar 2025 14:49:50 +0000 (10:49 -0400)]
client: refactor / optimize chdir

In particular: there's no reason to do a getcwd after chdir.

Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>
4 months agotest/libcephfs: test getcwd with case insensitive dir
Patrick Donnelly [Tue, 11 Mar 2025 16:13:33 +0000 (12:13 -0400)]
test/libcephfs: test getcwd with case insensitive dir

Unfortunately, it's not easy to refactor this test into a shared method without
setting up an explicit test class which has been avoided up to this point. So
I'm going to just copy the code. Sorry.

Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>
4 months agotest/libcephfs: refactor ManyNestedDirs
Patrick Donnelly [Tue, 11 Mar 2025 14:53:02 +0000 (10:53 -0400)]
test/libcephfs: refactor ManyNestedDirs

Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>
4 months agoinclude/filepath: add iterators for components
Patrick Donnelly [Tue, 11 Mar 2025 14:50:50 +0000 (10:50 -0400)]
include/filepath: add iterators for components

Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>
4 months agoMerge pull request #62160 from cbodley/wip-qa-vault-list
Casey Bodley [Thu, 13 Mar 2025 13:18:05 +0000 (09:18 -0400)]
Merge pull request #62160 from cbodley/wip-qa-vault-list

qa/vault: create_secrets() cleanup checks for orphaned keys

Reviewed-by: Adam C. Emerson <aemerson@redhat.com>
4 months agoscript: ensure curl is always available in build containers 62274/head
John Mulligan [Thu, 13 Mar 2025 11:59:42 +0000 (07:59 -0400)]
script: ensure curl is always available in build containers

Ensure that curl is installed in all build containers regardless of
ceph's dependencies or other factors. This allows us to use curl in
any subsequent build steps/scripts.

Fixes: https://tracker.ceph.com/issues/70451
Signed-off-by: John Mulligan <jmulligan@redhat.com>
4 months agoscript/build-with-container: fix incorrect build invocation for tests
John Mulligan [Thu, 13 Mar 2025 11:48:28 +0000 (07:48 -0400)]
script/build-with-container: fix incorrect build invocation for tests

The `tests` build target was set to build the "normal" target but it
needs to build the tests.

Signed-off-by: John Mulligan <jmulligan@redhat.com>
4 months agoMerge pull request #61945 from kotreshhr/snapshot-referent-inodes
Venky Shankar [Thu, 13 Mar 2025 10:53:46 +0000 (16:23 +0530)]
Merge pull request #61945 from kotreshhr/snapshot-referent-inodes

mds: snapshot referent inodes feature

Reviewed-by: Venky Shankar <vshankar@redhat.com>
4 months agoMerge pull request #60014 from rhcs-dashboard/cephadm-e2e-endless-fix-1
afreen23 [Thu, 13 Mar 2025 10:21:12 +0000 (15:51 +0530)]
Merge pull request #60014 from rhcs-dashboard/cephadm-e2e-endless-fix-1

mgr/dashboard: fix cephadm dashboard e2e and a combobox issue

Reviewed-by: Afreen Misbah <afreen@ibm.com>
4 months agoMerge pull request #62245 from afreen23/wip-disable-rgw-test
Nizamudeen A [Thu, 13 Mar 2025 05:56:13 +0000 (11:26 +0530)]
Merge pull request #62245 from afreen23/wip-disable-rgw-test

mgr/dashboard: Disable MFA test

4 months agoMerge pull request #62249 from anthonyeleven/improvedmi
Zac Dover [Thu, 13 Mar 2025 04:51:50 +0000 (14:51 +1000)]
Merge pull request #62249 from anthonyeleven/improvedmi

doc/monitoring: Improve index.rst

Reviewed-by: Zac Dover <zac.dover@proton.me>
4 months agomgr/dashboard: skip nfs exports check 60014/head
Nizamudeen A [Sat, 8 Mar 2025 08:47:59 +0000 (14:17 +0530)]
mgr/dashboard: skip nfs exports check

nfs service creation is not working because of some issue with cephadm
for a while now. disabling it until its resolved

Fixes: https://tracker.ceph.com/issues/68871
Signed-off-by: Nizamudeen A <nia@redhat.com>
4 months agomgr/dashboard: save video only on failure
Nizamudeen A [Fri, 7 Mar 2025 15:24:36 +0000 (20:54 +0530)]
mgr/dashboard: save video only on failure

as per
https://docs.cypress.io/app/guides/screenshots-and-videos#Delete-videos-for-specs-without-failing-or-retried-tests.

This would save storage as saving entire video is useless

Fixes: https://tracker.ceph.com/issues/68871
Signed-off-by: Nizamudeen A <nia@redhat.com>
4 months agomgr/dashboard: fix rgw and osd regression in e2e
Nizamudeen A [Mon, 24 Feb 2025 09:23:54 +0000 (14:53 +0530)]
mgr/dashboard: fix rgw and osd regression in e2e

use aria-label as the selector in tests.

data-testid is not supported through this carbon cds-checkbox
input so we can't use it

regression started after started after #61319 and
https://github.com/ceph/ceph/pull/61478/files#diff-7bd2a1f48bd2a7bcebb744eb04d84706087b6b3c2651c4b1ad085b4b6e03fc6d
where multi-select is removed

Fixes: https://tracker.ceph.com/issues/68871
Signed-off-by: Nizamudeen A <nia@redhat.com>
4 months agomgr/dashboard: undefined while creating rbd image
Nizamudeen A [Mon, 10 Feb 2025 04:37:28 +0000 (10:07 +0530)]
mgr/dashboard: undefined while creating rbd image

this only happens on a fresh cluster but consistently reproducible in a
test environment. also cephfs also throws some error occasionally which
is also being handled similarly

Fixes: https://tracker.ceph.com/issues/68871
Signed-off-by: Nizamudeen A <nia@redhat.com>
4 months agomgr/dashboard: cypress failure after angular upgrade
Nizamudeen A [Sun, 9 Feb 2025 16:12:59 +0000 (21:42 +0530)]
mgr/dashboard: cypress failure after angular upgrade

after angular upgrade, the tests started failing with
An uncaught error was detected outside of a test:
     TypeError: The following error originated from your test code, not from Cypress.
Cannot read properties of undefined (reading 'value')

which seems to originate from the page-helper.po. So handling the
undefined value.

Example run: https://jenkins.ceph.com/job/ceph-dashboard-pull-requests/17541/consoleFull#204663575173a8703b-5adb-41c5-84a0-8cf4e065ba3d

Fixes: https://tracker.ceph.com/issues/68871
Signed-off-by: Nizamudeen A <nia@redhat.com>
4 months agomgr/dashboard: fixing cephadm dashboard e2e failures
Nizamudeen A [Fri, 27 Sep 2024 05:28:41 +0000 (10:58 +0530)]
mgr/dashboard: fixing cephadm dashboard e2e failures

the wizard component changes caused issue to the e2e, so fixing it.
It was uncaught before because of the test were unable to run due to
some lab issues.

Fixes: https://tracker.ceph.com/issues/68871
Signed-off-by: Nizamudeen A <nia@redhat.com>
4 months agomgr/dashboard: fix osd list search with id
Nizamudeen A [Thu, 9 Jan 2025 17:39:00 +0000 (23:09 +0530)]
mgr/dashboard: fix osd list search with id

The osd list search with id is broken after the pagination. So if you
search for any id it won't retrieve anything.

PS: One more broken item is the searching with any other cell name but
that's a known issue with server side pagination.

Fixes: https://tracker.ceph.com/issues/68871
Signed-off-by: Nizamudeen A <nia@redhat.com>
4 months agomgr/dashboard: reorder test runs
Nizamudeen A [Thu, 9 Jan 2025 10:40:08 +0000 (16:10 +0530)]
mgr/dashboard: reorder test runs

I saw cypress starting the grafana tests even before the cluster is
setup through the expansion tests. so running grafana separately

Fixes: https://tracker.ceph.com/issues/68871
Signed-off-by: Nizamudeen A <nia@redhat.com>
4 months agomgr/dashboard: add custom items to combo box
Nizamudeen A [Fri, 27 Sep 2024 05:30:17 +0000 (11:00 +0530)]
mgr/dashboard: add custom items to combo box

previously we were able to add custom items to our select-badges like
custom labels for hosts. but it got dropped unintentionally due to the
carbon. fixing it here

Fixes: https://tracker.ceph.com/issues/68871
Signed-off-by: Nizamudeen A <nia@redhat.com>
4 months agoPendingReleaseNote: add note for pause_purging and pause_cloninig 54396/head
Rishabh Dave [Mon, 2 Sep 2024 14:13:45 +0000 (19:43 +0530)]
PendingReleaseNote: add note for pause_purging and pause_cloninig

Added release notes for mgr/vol config option "pause_purging and
"pause_cloning".

Signed-off-by: Rishabh Dave <ridave@redhat.com>
4 months agodoc/cephfs: add note for config option pause_purging and pause_cloning
Rishabh Dave [Mon, 2 Sep 2024 14:11:17 +0000 (19:41 +0530)]
doc/cephfs: add note for config option pause_purging and pause_cloning

Update documentation for add information about mgr/vol config options
"pause_purging" and "pause_cloning".

Signed-off-by: Rishabh Dave <ridave@redhat.com>
4 months agoqa/cephfs: add tests for mgr/vol config pause_cloning
Rishabh Dave [Fri, 11 Oct 2024 19:08:09 +0000 (00:38 +0530)]
qa/cephfs: add tests for mgr/vol config pause_cloning

mgr/vol config option pause_cloning allows pausing of cloner threads.
Add tests for this.

Signed-off-by: Rishabh Dave <ridave@redhat.com>
4 months agoqa/cephfs: extend wait for trash empty
Rishabh Dave [Fri, 11 Oct 2024 19:03:29 +0000 (00:33 +0530)]
qa/cephfs: extend wait for trash empty

Trash directory for a volume is not created by default. If
_wait_for_trash_empty() in test_volumes.py encounters absence of trash
directory, return true.

Signed-off-by: Rishabh Dave <ridave@redhat.com>
4 months agoqa/cephfs: add tests for config option pause_purging
Rishabh Dave [Sat, 6 Jan 2024 14:42:31 +0000 (20:12 +0530)]
qa/cephfs: add tests for config option pause_purging

Setting MGR config option mgr/volumes/pause_purging to true halts
all ongoing purges and allows no new purging to begin until this option
is changed to false. Add tests for this.

Signed-off-by: Rishabh Dave <ridave@redhat.com>
4 months agoqa/cephfs: don't strip any whitespace for get_shell_stdout
Rishabh Dave [Fri, 12 Jan 2024 10:28:41 +0000 (15:58 +0530)]
qa/cephfs: don't strip any whitespace for get_shell_stdout

Whitespace is not removed from the end of the stdout returned by the
method get_ceph_cmd_stdout(). Follow the same policy here since it is
better to not do so (this whitespace can be useful, when copying Ceph
auth keyrings from stdout to a file) and also for sake of uniformity of
interfaces.

Signed-off-by: Rishabh Dave <ridave@redhat.com>
4 months agomgr/vol: add pause/resume mechanism for async jobs
Rishabh Dave [Tue, 3 Sep 2024 10:01:07 +0000 (15:31 +0530)]
mgr/vol: add pause/resume mechanism for async jobs

Add mechansim that allows pausing/resuming of the entire async job
machinery that queues, launches and picks next async job; both async
jobs, clones as well as purges.

And then add mgr/vol config option pause_purging and pause_cloning so
that both of these async jobs can be paused and resumed individually.

Fixes: https://tracker.ceph.com/issues/61903
Fixes: https://tracker.ceph.com/issues/68630
Signed-off-by: Rishabh Dave <ridave@redhat.com>
4 months agoqa/vault: create_secrets() cleanup checks for orphaned keys 62160/head
Casey Bodley [Thu, 6 Mar 2025 18:13:36 +0000 (13:13 -0500)]
qa/vault: create_secrets() cleanup checks for orphaned keys

the vault task creates some keys on startup for use in s3-tests. on
cleanup, check that rgw has removed any temporary bucket keys that
were created during testing. fail with an assertion if the listed keys
differ

Signed-off-by: Casey Bodley <cbodley@redhat.com>
4 months agoMerge pull request #59516 from sajibreadd/wip-67700
Md Mahamudur Rahaman Sajib [Wed, 12 Mar 2025 18:02:37 +0000 (19:02 +0100)]
Merge pull request #59516 from sajibreadd/wip-67700

OSD: Split osd_recovery_sleep into settings applied to degraded or clean PGs

4 months agodoc/rados/configuration/bluestore-config-ref: Fix lowercase typos 62258/head
Dan van der Ster [Wed, 12 Mar 2025 17:25:42 +0000 (10:25 -0700)]
doc/rados/configuration/bluestore-config-ref: Fix lowercase typos

Commit 3879e4ad417d lowercased several commands. This fixes the
remaining typos.

Signed-off-by: Dan van der Ster <dan.vanderster@clyso.com>
4 months agoMerge pull request #62242 from rhcs-dashboard/pin-xmlsec
Nizamudeen A [Wed, 12 Mar 2025 17:04:16 +0000 (22:34 +0530)]
Merge pull request #62242 from rhcs-dashboard/pin-xmlsec

mgr/dashboard: pin lxml to fix run-dashboard-tox-make-check failure

4 months agolibrbd/ConfigWatcher: fix a missing 'override' 62252/head
Ronen Friedman [Wed, 12 Mar 2025 15:49:33 +0000 (10:49 -0500)]
librbd/ConfigWatcher: fix a missing 'override'

dropped in PR#62188

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
4 months agoMerge PR #62188 into main
Patrick Donnelly [Wed, 12 Mar 2025 14:40:10 +0000 (10:40 -0400)]
Merge PR #62188 into main

* refs/pull/62188/head:
librbd/ConfigWatcher: replace obsolete get_tracked_conf_keys()
rbd/throttler: replace obsolete get_tracked_conf_keys()
mds: replace obsolete get_tracked_conf_keys()
nvmeof: replace obsolete get_tracked_conf_keys()

Reviewed-by: Patrick Donnelly <pdonnell@ibm.com>
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
4 months agoMerge PR #62136 into main
Patrick Donnelly [Wed, 12 Mar 2025 14:39:39 +0000 (10:39 -0400)]
Merge PR #62136 into main

* refs/pull/62136/head:
qa: add test case for remove xattr
cephfs-shell: Add the option to remove xattr

Reviewed-by: Patrick Donnelly <pdonnell@ibm.com>
4 months agoMerge PR #62062 into main
Patrick Donnelly [Wed, 12 Mar 2025 14:38:37 +0000 (10:38 -0400)]
Merge PR #62062 into main

* refs/pull/62062/head:
qa/cephfs: avoid unnecessary importing in test_volumes.py

Reviewed-by: Patrick Donnelly <pdonnell@ibm.com>
4 months agodoc/monitoring: Improve index.rst 62249/head
Anthony D'Atri [Wed, 12 Mar 2025 13:31:19 +0000 (09:31 -0400)]
doc/monitoring: Improve index.rst

Signed-off-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
4 months agoMerge pull request #61544 from rkachach/fix_automated_cert_rotation_69581
Adam King [Wed, 12 Mar 2025 13:17:58 +0000 (09:17 -0400)]
Merge pull request #61544 from rkachach/fix_automated_cert_rotation_69581

Introducing certmgr: a unified certificate management system for Cephadm

Reviewed-by: Adam King <adking@redhat.com>
4 months agomgr/dashboard: Disable MFA test 62245/head
Afreen Misbah [Wed, 12 Mar 2025 09:54:11 +0000 (15:24 +0530)]
mgr/dashboard: Disable MFA test

Fixes https://tracker.ceph.com/issues/46735

Disabling the test due to flakiness

Signed-off-by: Afreen Misbah <afreen@ibm.com>
4 months agoMerge pull request #61536 from Matan-B/wip-matanb-backfill-scan
Matan Breizman [Wed, 12 Mar 2025 09:17:17 +0000 (11:17 +0200)]
Merge pull request #61536 from Matan-B/wip-matanb-backfill-scan

crimson/osd/recovery_backend: scan_for_backfill to use obc_manager

Reviewed-by: Xuehan Xu <xuxuehan@qianxin.com>
4 months agoMerge pull request #62226 from ronen-fr/wip-rf-bitset-fmt
Ronen Friedman [Wed, 12 Mar 2025 08:55:47 +0000 (10:55 +0200)]
Merge pull request #62226 from ronen-fr/wip-rf-bitset-fmt

common: fmt support for bitset_set & mini_flat_map

Reviewed-by: Alex Ainscow <aainscow@uk.ibm.com>
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
4 months agomgr/dashboard: pin lxml to fix run-dashboard-tox-make-check failure 62242/head
Nizamudeen A [Wed, 12 Mar 2025 07:06:42 +0000 (12:36 +0530)]
mgr/dashboard: pin lxml to fix run-dashboard-tox-make-check failure

xmlsec had an upgrade yesterday night and python3-saml might need to
adapt its library accordingly I suppose. Testing a fix by pinning lxml

Another approach is being tried out separately
https://github.com/ceph/ceph/pull/62239, but that is failing with some
other errors.

Fixes: https://tracker.ceph.com/issues/70411
Signed-off-by: Nizamudeen A <nia@redhat.com>
4 months agoqa/cephfs: require-osd-release should now be tentacle 62240/head
Venky Shankar [Wed, 12 Mar 2025 06:21:48 +0000 (11:51 +0530)]
qa/cephfs: require-osd-release should now be tentacle

Signed-off-by: Venky Shankar <vshankar@redhat.com>
4 months agoMerge pull request #62217 from aainscow/flat_maps_fix
Alex Ainscow [Wed, 12 Mar 2025 00:18:10 +0000 (00:18 +0000)]
Merge pull request #62217 from aainscow/flat_maps_fix

common:  Remove unnecessary assert checking unsigned number is 0 or greater in bitset_set.h

4 months agocommon/include: Add map type election and fmt::format to interval_map 62200/head
Alex Ainscow [Mon, 10 Mar 2025 11:31:45 +0000 (11:31 +0000)]
common/include: Add map type election and fmt::format to interval_map

Add capability to choose the type of map used in interval_map.

The default will be std::map and so should not change any existing
implementation.

This behaviour is already available in interval_set. The intention
is to enable a more efficient map library which suits a particular
application.

The optimized EC code, which is coming soon, will use a boost::flat_map
here since it deals with large numbers of very small (usually single-entry)
interval_maps.

Also adds fmt::format support and refactors print functions in both
set and map.

Signed-off-by: Alex Ainscow <aainscow@uk.ibm.com>
4 months agoMerge pull request #61828 from clwluvw/datasync-useracl
Casey Bodley [Tue, 11 Mar 2025 22:52:16 +0000 (18:52 -0400)]
Merge pull request #61828 from clwluvw/datasync-useracl

rgw: prevent data sync from replicating to buckets not owned by the user

Signed-off-by: Shilpa Jagannath <smanjara@redhat.com>
4 months agoclient: avoid multiple calls to path_walk 62230/head
Patrick Donnelly [Tue, 11 Mar 2025 14:28:01 +0000 (10:28 -0400)]
client: avoid multiple calls to path_walk

When we wrap a dname after a path walk, we cannot do another path walk.
Originally this method was setup to permit that but with (upcoming) encryption
it cannot work. The dname from the path_walk is in the encrypted namespace so
we cannot do another lookup in a second path_walk.

Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>
4 months agoMerge pull request #60714 from aclamk/wip-aclamk-bluefs-unittest-async-compaction
Adam Kupczyk [Tue, 11 Mar 2025 18:52:46 +0000 (19:52 +0100)]
Merge pull request #60714 from aclamk/wip-aclamk-bluefs-unittest-async-compaction

os/bluestore: New unit test for BlueFS async compaction

4 months agoMerge pull request #61810 from Jayaprakash-ibm/wip-bluestore-onode-test-enhancement
Jaya Prakash [Tue, 11 Mar 2025 17:23:00 +0000 (22:53 +0530)]
Merge pull request #61810 from Jayaprakash-ibm/wip-bluestore-onode-test-enhancement

os/bluestore : Fill onode test instances with sample data

Reviewed-by: Igor Fedotov <igor.fedotov@croit.io>
4 months agoMerge pull request #61900 from aclamk/wip-aclamk-bs-fix-get-unused-mask
Jaya Prakash [Tue, 11 Mar 2025 17:19:10 +0000 (22:49 +0530)]
Merge pull request #61900 from aclamk/wip-aclamk-bs-fix-get-unused-mask

os/bluestore: implemented bluestore_blob_t::get_unused_mask

Reviewed-by: Chunmei Liu <chunmei.liu@ibm.com>
4 months agocommon: Remove unnecessary assert checking unsigned number is 0 or greater. 62217/head
Alex Ainscow [Tue, 11 Mar 2025 09:56:07 +0000 (09:56 +0000)]
common: Remove unnecessary assert checking unsigned number is 0 or greater.

Minor compiler warning caused by unsigned comparison with zero. Clearly
assert is not necessary and so was removed. Wrapping scenarios are
policed using remaining assert code.

Signed-off-by: Alex Ainscow <aainscow@uk.ibm.com>
4 months agoMerge pull request #61829 from rkachach/fix_issue_69971
Adam King [Tue, 11 Mar 2025 15:33:11 +0000 (11:33 -0400)]
Merge pull request #61829 from rkachach/fix_issue_69971

mgr/cephadm: Add virtual_ip as a param for mgmt-gateway apply cmd

Reviewed-by: Adam King <adking@redhat.com>
4 months agoMerge pull request #62085 from afreen23/wip-sso
Nizamudeen A [Tue, 11 Mar 2025 14:09:58 +0000 (19:39 +0530)]
Merge pull request #62085 from afreen23/wip-sso

mgr/dashboard: Improve sso role mapping

4 months agoMerge pull request #60530 from aclamk/wip-aclamk-mute-deferred-test
Adam Kupczyk [Tue, 11 Mar 2025 12:46:34 +0000 (13:46 +0100)]
Merge pull request #60530 from aclamk/wip-aclamk-mute-deferred-test

os/bluestore: Disable invoking unittest_deferred

4 months agoMerge pull request #62214 from Matan-B/wip-matanb-revert-60753
Matan Breizman [Tue, 11 Mar 2025 12:43:41 +0000 (14:43 +0200)]
Merge pull request #62214 from Matan-B/wip-matanb-revert-60753

Revert "os/bluestore: Fix problem with deferred writes replay"

Reviewed-by: Adam Kupczyk <akupczyk@ibm.com>
4 months agoMerge pull request #61476 from piyushagarwal1411/pool
Aashish Sharma [Tue, 11 Mar 2025 12:34:12 +0000 (18:04 +0530)]
Merge pull request #61476 from piyushagarwal1411/pool

mgr/dashboard: Changing SimpleGraphPanel to TimeSeries Panel in pool.libsonnet to fix inconsistency in Line Graphs

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
4 months agoMerge pull request #61474 from piyushagarwal1411/osd
Aashish Sharma [Tue, 11 Mar 2025 12:33:15 +0000 (18:03 +0530)]
Merge pull request #61474 from piyushagarwal1411/osd

mgr/dashboard: Changing SimpleGraphPanel to TimeSeries Panel in osd.libsonnet to fix inconsistency in Line Graphs

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
4 months agoMerge pull request #61463 from piyushagarwal1411/host
Aashish Sharma [Tue, 11 Mar 2025 12:31:48 +0000 (18:01 +0530)]
Merge pull request #61463 from piyushagarwal1411/host

mgr/dashboard: Changing SimpleGraphPanel to TimeSeries Panel in host.libsonnet to fix inconsistency in Line Graphs

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
4 months agoMerge pull request #61210 from piyushagarwal1411/cephfs
Aashish Sharma [Tue, 11 Mar 2025 12:30:26 +0000 (18:00 +0530)]
Merge pull request #61210 from piyushagarwal1411/cephfs

mgr/dashboard: Changing SimpleGraphPanel to TimeSeries Panel in cephfs.libsonnet to fix inconsistency in Line Graphs

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
4 months agotest: test the fmt support for bitset_set & mini_flat_map 62226/head
Ronen Friedman [Mon, 10 Mar 2025 17:55:01 +0000 (12:55 -0500)]
test: test the fmt support for bitset_set & mini_flat_map

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
4 months agocommon: fmt support for bitset_set & mini_flat_map
Ronen Friedman [Mon, 10 Mar 2025 17:12:10 +0000 (12:12 -0500)]
common: fmt support for bitset_set & mini_flat_map

Note: both classes have begin()/end() methods, which
required an explicit opt-out of fmt/range default
handling.

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
4 months agoMerge pull request #62126 from vshankar/wip-70287
Venky Shankar [Tue, 11 Mar 2025 11:07:00 +0000 (16:37 +0530)]
Merge pull request #62126 from vshankar/wip-70287

mds: include deleted file dentry in snapdiff readdir result

4 months agomgr/cepahdm: adding a message when certificates check is OK 61544/head
Redouane Kachach [Thu, 6 Mar 2025 14:04:54 +0000 (15:04 +0100)]
mgr/cepahdm: adding a message when certificates check is OK

Signed-off-by: Redouane Kachach <rkachach@ibm.com>
4 months agomgr/cephadm: addressing reviewer comments
Redouane Kachach [Wed, 5 Mar 2025 12:48:08 +0000 (13:48 +0100)]
mgr/cephadm: addressing reviewer comments

Signed-off-by: Redouane Kachach <rkachach@ibm.com>
4 months agomgr/cepahadm: fixing certificate get_status_description output
Redouane Kachach [Fri, 28 Feb 2025 12:11:58 +0000 (13:11 +0100)]
mgr/cepahadm: fixing certificate get_status_description output

Signed-off-by: Redouane Kachach <rkachach@ibm.com>
4 months agomgr/cephadm: adding new debug flag for testing purposes only
Redouane Kachach [Fri, 28 Feb 2025 11:58:06 +0000 (12:58 +0100)]
mgr/cephadm: adding new debug flag for testing purposes only

Signed-off-by: Redouane Kachach <rkachach@ibm.com>
4 months agomgr/cephadm: fixing docs and defaults for some options
Redouane Kachach [Mon, 24 Feb 2025 11:40:20 +0000 (12:40 +0100)]
mgr/cephadm: fixing docs and defaults for some options

Signed-off-by: Redouane Kachach <rkachach@ibm.com>
4 months agomgr/cephadm: improving individual certificates checks
Redouane Kachach [Wed, 19 Feb 2025 16:36:15 +0000 (17:36 +0100)]
mgr/cephadm: improving individual certificates checks

Some refactoring to improve the individual certificates checking and
use the same code for both cases: certs with and without keys are

Signed-off-by: Redouane Kachach <rkachach@ibm.com>
4 months agomgr/cepahadm: added some logic to avoid loading unknown certs/keys
Redouane Kachach [Wed, 19 Feb 2025 12:25:04 +0000 (13:25 +0100)]
mgr/cepahadm: added some logic to avoid loading unknown certs/keys

Those keys can be already present in the monstore because they were
used/generated by previous versions of cert_store (new certmgr). Since
they are not in use anymore we should not load them.

Signed-off-by: Redouane Kachach <rkachach@ibm.com>
4 months agomgr/cephadm: reverting usage of Org Name 'Ceph' in self-signed certs
Redouane Kachach [Tue, 18 Feb 2025 12:42:17 +0000 (13:42 +0100)]
mgr/cephadm: reverting usage of Org Name 'Ceph' in self-signed certs

This could cause issues on upgrades as it imply chaning the root CA CN

Signed-off-by: Redouane Kachach <rkachach@ibm.com>