]> git.apps.os.sepia.ceph.com Git - ceph.git/log
ceph.git
22 months agoMerge pull request #53296 from phlogistonjohn/jjm-fix-git-ls-files 52810/head
Adam King [Thu, 14 Sep 2023 17:10:16 +0000 (13:10 -0400)]
Merge pull request #53296 from phlogistonjohn/jjm-fix-git-ls-files

cephadm: remove duplicates when listing files in scan

Reviewed-by: Adam King <adking@redhat.com>
22 months agoMerge pull request #52690 from phlogistonjohn/jjm-cephadm-daemon-ident
Adam King [Thu, 14 Sep 2023 15:23:38 +0000 (11:23 -0400)]
Merge pull request #52690 from phlogistonjohn/jjm-cephadm-daemon-ident

cephadm: refactor code to make use of DaemonIdentity type

Reviewed-by: Adam King <adking@redhat.com>
22 months agoMerge pull request #53450 from zdover23/wip-doc-2023-09-14-man-ceph-monstore-tool
zdover23 [Thu, 14 Sep 2023 11:44:15 +0000 (21:44 +1000)]
Merge pull request #53450 from zdover23/wip-doc-2023-09-14-man-ceph-monstore-tool

doc/man: edit ceph-monstore-tool.rst

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
22 months agoMerge pull request #53426 from ronen-fr/wip-rf-fshut
Ronen Friedman [Thu, 14 Sep 2023 10:33:46 +0000 (13:33 +0300)]
Merge pull request #53426 from ronen-fr/wip-rf-fshut

osd: cleaning stop_for_fast_shutdown()

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Reviewed-by: Samuel Just <sjust@redhat.com>
22 months agoMerge PR #53070 into main
Venky Shankar [Thu, 14 Sep 2023 10:09:07 +0000 (15:39 +0530)]
Merge PR #53070 into main

* refs/pull/53070/head:
PendingReleaseNotes: add note about 'm' and 'M' periods
doc/cephfs: add note about monthly scheduling and retention period
qa: update minute period multiplier to m
qa: change minute duration specifier from M to m
mgr/snap_schedule: change minute duration specifier from M to m

Reviewed-by: Dhairya Parmar <dparmar@redhat.com>
Reviewed-by: Neeraj Pratap Singh <neesingh@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
22 months agoMerge pull request #53433 from myoungwon/fix-53232
Yingxin [Thu, 14 Sep 2023 07:15:24 +0000 (15:15 +0800)]
Merge pull request #53433 from myoungwon/fix-53232

crimson/tools/perf_staged_fltree: fix compile error

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
Reviewed-by: Aravind Ramesh <aravind.ramesh@wdc.com>
22 months agoMerge PR #51891 into main
Venky Shankar [Thu, 14 Sep 2023 03:59:07 +0000 (09:29 +0530)]
Merge PR #51891 into main

* refs/pull/51891/head:
qa: fix cephfs-top tests for the new fields
cephfs-top: include the missing fields in --dump output

Reviewed-by: Neeraj Pratap Singh <neesingh@redhat.com>
22 months agoMerge pull request #53444 from zdover23/wip-doc-2023-09-14-architecture-4-of-x
zdover23 [Thu, 14 Sep 2023 03:27:52 +0000 (13:27 +1000)]
Merge pull request #53444 from zdover23/wip-doc-2023-09-14-architecture-4-of-x

doc/architecture: edit "High Avail. Monitors"

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
22 months agodoc/man: edit ceph-monstore-tool.rst 53450/head
Zac Dover [Thu, 14 Sep 2023 03:24:11 +0000 (13:24 +1000)]
doc/man: edit ceph-monstore-tool.rst

Clean up the English in doc/man/8/ceph-monstore-tool.rst. Put all
commands in the imperative mood; make sentences more direct.

Follows https://github.com/ceph/ceph/pull/52860.

Signed-off-by: Zac Dover <zac.dover@proton.me>
22 months agodoc/architecture: edit "High Avail. Monitors" 53444/head
Zac Dover [Wed, 13 Sep 2023 14:09:45 +0000 (00:09 +1000)]
doc/architecture: edit "High Avail. Monitors"

Improve the sentence structure in the "High Availability Monitors"
section of doc/architecture.rst.

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
22 months agoMerge pull request #53178 from aclamk/wip-aclamk-bs-esb-5-enabled
Radoslaw Zarzynski [Wed, 13 Sep 2023 19:45:47 +0000 (21:45 +0200)]
Merge pull request #53178 from aclamk/wip-aclamk-bs-esb-5-enabled

bluestore: Elastic Shared Blobs 5 - enabled, final

Reviewed-by: Igor Fedotov <ifedotov@suse.com>
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com
22 months agocephadm: fix an error running iscsi services 52690/head
John Mulligan [Wed, 13 Sep 2023 19:44:40 +0000 (15:44 -0400)]
cephadm: fix an error running iscsi services

Signed-off-by: John Mulligan <jmulligan@redhat.com>
22 months agoMerge pull request #52793 from linuxbox2/wip-fix-test-librgw-xattr
Matt Benjamin [Wed, 13 Sep 2023 16:57:52 +0000 (12:57 -0400)]
Merge pull request #52793 from linuxbox2/wip-fix-test-librgw-xattr

rgw/file:  fix build of librgw_file_xattr.cc unit test

22 months agoMerge pull request #51368 from dang/wip-dang-zipper-motr
Daniel Gryniewicz [Wed, 13 Sep 2023 13:35:39 +0000 (09:35 -0400)]
Merge pull request #51368 from dang/wip-dang-zipper-motr

Fix MOTR build, and move MOTR and DAOS to proper location

22 months agoMerge pull request #53391 from shreyanshjain7174/bucket_quota
Ali Maredia [Wed, 13 Sep 2023 11:46:19 +0000 (07:46 -0400)]
Merge pull request #53391 from shreyanshjain7174/bucket_quota

RadosGW API: incorrect bucket quota in response to HEAD /{bucket}/?usage

Reviewed-by: Ali Maredia <amaredia@redhat.com>
22 months agocrimson/tools/perf_staged_fltree: fix compile error 53433/head
Myoungwon Oh [Wed, 13 Sep 2023 05:16:16 +0000 (14:16 +0900)]
crimson/tools/perf_staged_fltree: fix compile error

Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com>
22 months agoMerge pull request #53423 from zdover23/wip-doc-2023-09-12-architecture-3-of-x
zdover23 [Wed, 13 Sep 2023 07:07:26 +0000 (17:07 +1000)]
Merge pull request #53423 from zdover23/wip-doc-2023-09-12-architecture-3-of-x

doc/architecture: edit "Cluster Map"

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
22 months agoMerge PR #53153 into main
Venky Shankar [Wed, 13 Sep 2023 05:40:59 +0000 (11:10 +0530)]
Merge PR #53153 into main

* refs/pull/53153/head:
Revert "mds: align quota.max_bytes to 4MB or 4KB"

Reviewed-by: Xiubo Li <xiubli@redhat.com>
22 months agoMerge pull request #53370 from wowly/rgw-cache-nginx-if-match-header
Casey Bodley [Tue, 12 Sep 2023 18:27:00 +0000 (19:27 +0100)]
Merge pull request #53370 from wowly/rgw-cache-nginx-if-match-header

examples: fixed errors with the if-match header in the examples of rgw-cache nginx configs

Reviewed-by: Casey Bodley <cbodley@redhat.com>
22 months agodoc/architecture: edit "Cluster Map" 53423/head
Zac Dover [Tue, 12 Sep 2023 11:17:40 +0000 (21:17 +1000)]
doc/architecture: edit "Cluster Map"

Edit the section "Cluster Map" in doc/architecture.rst.

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
22 months agoMerge pull request #53422 from zdover23/wip-doc-2023-09-12-glossary-primary-affinity
Anthony D'Atri [Tue, 12 Sep 2023 16:00:08 +0000 (12:00 -0400)]
Merge pull request #53422 from zdover23/wip-doc-2023-09-12-glossary-primary-affinity

doc/glossary: add "primary affinity" to glossary

22 months agoosd: cleaning stop_for_fast_shutdown() 53426/head
Ronen Friedman [Tue, 12 Sep 2023 13:15:40 +0000 (08:15 -0500)]
osd: cleaning stop_for_fast_shutdown()

Removed unsued variables to prevent compiler warnings.
Protected the shard lock.

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
22 months agoMerge pull request #52407 from rhcs-dashboard/osd-op-scraper
Adam Kupczyk [Tue, 12 Sep 2023 15:47:52 +0000 (17:47 +0200)]
Merge pull request #52407 from rhcs-dashboard/osd-op-scraper

os/bluestore: osd scrape read/write operations

22 months agoos/bluestore: osd scrape read/write operations 52407/head
Pere Diaz Bou [Wed, 12 Jul 2023 11:05:17 +0000 (13:05 +0200)]
os/bluestore: osd scrape read/write operations

To run:
```bash
../src/test/objectstore/allocsim/ops_scraper.py --ceph_bin_path bin/ceph
```

Example:
```bash
$ ../src/test/objectstore/allocsim/ops_scraper.py --ceph_bin_path bin/ceph                                                                           [13:06:39]
collecting from osd. 0
op_type | offset/extent | name | pgid | initiated_at | who
-------------------------------------------------------
write 0~4194304 4:c4b97d2c:::be151868021c187609fb97e4c22ae1f9:head 4.3 2023-07-12T13:06:34.959082+0200 client.4831.0:351
write 0~4194304 4:d392075e:::b068dce954dca8ca56d72e02e87f39c8:head 4.b 2023-07-12T13:06:35.093439+0200 client.4831.0:358
write 0~4194304 4:bc1ac643:::7b815bd25a40695c891dc06bdf2b65be:head 4.1d 2023-07-12T13:06:35.128097+0200 client.4831.0:360
write 0~4194304 4:d0d21bd5:::cc531199dd2707370bb461cce82bdef6:head 4.b 2023-07-12T13:06:36.023082+0200 client.4831.0:367
write 0~4194304 4:a9abc92c:::0703d6f43d14bc33d69f94ecb96c522c:head 4.15 2023-07-12T13:06:36.367886+0200 client.4831.0:369
write 0~4194304 4:9b4684ea:::d5856dc0ecad96f811012e0937d5e0ac:head 4.19 2023-07-12T13:06:36.654584+0200 client.4831.0:370
write 0~4194304 4:d15b8c87:::c3344e5de8c8936876965d9fb056ad89:head 4.b 2023-07-12T13:06:36.835690+0200 client.4831.0:371
write 0~4194304 4:ad41de2a:::8a1e2743b577a67d6bc8a1d514391b53:head 4.15 2023-07-12T13:06:37.102741+0200 client.4831.0:373
write 0~4194304 4:fc35d54f:::39cd961e7e33680f4bfd1ca0fe43dda4:head 4.1f 2023-07-12T13:06:38.047612+0200 client.4831.0:377

collecting from osd. 1
op_type | offset/extent | name | pgid | initiated_at | who
-------------------------------------------------------
write 0~4194304 4:4c9ed2e8:::86206ccc35d8aceaf78670a751a6b550:head 4.12 2023-07-12T13:06:34.771423+0200 client.4831.0:340
write 0~4194304 4:106d9524:::fe7534cc604b0eb50498cb23aaca9161:head 4.8 2023-07-12T13:06:35.128105+0200 client.4831.0:359
write 0~4194304 4:a6e3fdb1:::2692491bfc4c584ca5b1efcb896936c2:head 4.5 2023-07-12T13:06:35.567070+0200 client.4831.0:363
write 0~4194304 4:2d9a471a:::ba51255646d00c496c2638bad03e0869:head 4.14 2023-07-12T13:06:35.568290+0200 client.4831.0:364
write 0~4194304 4:2b1381b1:::c58fa31e5d3a4f5550ee143bcb07a49f:head 4.14 2023-07-12T13:06:35.764699+0200 client.4831.0:365
write 0~4194304 4:a22e158f:::b2116e08700da18595b96d58120fe81c:head 4.5 2023-07-12T13:06:36.023101+0200 client.4831.0:366
```

Signed-off-by: Pere Diaz Bou <pere-altea@hotmail.com>
22 months agoMerge pull request #53419 from AliMasarweh/wip-alimasa-persistent-q-test
Ali Masarwa [Tue, 12 Sep 2023 13:51:25 +0000 (16:51 +0300)]
Merge pull request #53419 from AliMasarweh/wip-alimasa-persistent-q-test

RGW | bucket notification: adding more sleeping time to prevent test from failing

Reviewed-by: yuvalif <ylifshit@redhat.com>
22 months agoqa: fix cephfs-top tests for the new fields 51891/head
Jos Collin [Fri, 2 Jun 2023 11:09:49 +0000 (16:39 +0530)]
qa: fix cephfs-top tests for the new fields

Fixes: https://tracker.ceph.com/issues/61397
Signed-off-by: Jos Collin <jcollin@redhat.com>
22 months agocephfs-top: include the missing fields in --dump output
Jos Collin [Fri, 2 Jun 2023 11:08:29 +0000 (16:38 +0530)]
cephfs-top: include the missing fields in --dump output

Fixes: https://tracker.ceph.com/issues/61397
Signed-off-by: Jos Collin <jcollin@redhat.com>
22 months agodoc/glossary: add "primary affinity" to glossary 53422/head
Zac Dover [Tue, 12 Sep 2023 10:56:03 +0000 (20:56 +1000)]
doc/glossary: add "primary affinity" to glossary

Add "Primary Affinity" to the glossary and link to the information in
the RADOS documentation that (more or less) explains it.

Signed-off-by: Zac Dover <zac.dover@proton.me>
22 months agoRGW | bucket notification: adding more sleeping time to prevent test from failing 53419/head
Ali Masarwa [Tue, 12 Sep 2023 10:31:31 +0000 (13:31 +0300)]
RGW | bucket notification: adding more sleeping time to prevent test from failing

Signed-off-by: Ali Masarwa <ali.saed.masarwa@gmail.com>
22 months agoPendingReleaseNotes: add note about 'm' and 'M' periods 53070/head
Milind Changire [Tue, 12 Sep 2023 08:39:39 +0000 (14:09 +0530)]
PendingReleaseNotes: add note about 'm' and 'M' periods

Signed-off-by: Milind Changire <mchangir@redhat.com>
22 months agodoc/cephfs: add note about monthly scheduling and retention period
Milind Changire [Thu, 24 Aug 2023 02:19:43 +0000 (07:49 +0530)]
doc/cephfs: add note about monthly scheduling and retention period

Fixes: https://tracker.ceph.com/issues/62494
Signed-off-by: Milind Changire <mchangir@redhat.com>
22 months agoqa: update minute period multiplier to m
Milind Changire [Tue, 12 Sep 2023 08:30:33 +0000 (14:00 +0530)]
qa: update minute period multiplier to m

Signed-off-by: Milind Changire <mchangir@redhat.com>
22 months agoqa: change minute duration specifier from M to m
Milind Changire [Thu, 24 Aug 2023 02:18:17 +0000 (07:48 +0530)]
qa: change minute duration specifier from M to m

Fixes: https://tracker.ceph.com/issues/62494
Signed-off-by: Milind Changire <mchangir@redhat.com>
22 months agomgr/snap_schedule: change minute duration specifier from M to m
Milind Changire [Thu, 24 Aug 2023 02:17:46 +0000 (07:47 +0530)]
mgr/snap_schedule: change minute duration specifier from M to m

Problem:
As per the issue tracker, the period spec specifier 'M' is not
consistent with what is used elsewhere, like the period specifiers
displayed in the 'ceph status' command output.
The 'M' period specifier is used as a 'minute' level period specifier by
the cephfs team.
The issue reporter suggests to use 'M' as a 'month' period specifier.

Solution:
Since the 'minute' level period specifer, 'M', is used internally by
the development team, it is failrly easy to swap the 'minute' ('M')
level and 'month' ('m') level period specifers to finally mean that 'm'
implies 'minute' level period and 'M' implies 'month' level period.
Also, since this is the first time that somebody has ever reported that
neither the 'M' nor the 'm' level specifiers work in production, it is a
good idea to fix them once and for all.

Fixes: https://tracker.ceph.com/issues/62494
Signed-off-by: Milind Changire <mchangir@redhat.com>
22 months agoMerge pull request #53408 from roysahar/nvmeof_fix_omap_state_object_contains_None
Roy Sahar [Tue, 12 Sep 2023 07:43:24 +0000 (10:43 +0300)]
Merge pull request #53408 from roysahar/nvmeof_fix_omap_state_object_contains_None

nvmeof-gw: omap object name contains None as string due to generated template to ceph-nvmeof.conf

22 months agoMerge pull request #53232 from myoungwon/wip-enable-rbm-tests
Liu-Chunmei [Tue, 12 Sep 2023 06:25:24 +0000 (23:25 -0700)]
Merge pull request #53232 from myoungwon/wip-enable-rbm-tests

test/crimson/seastore/rbm: add sub-tests regarding RBM to the existing tests

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
Reviewed-by: Liu-Chunmei <chunmei.liu@intel.com>
22 months agocrimson/os/seastore/object_data_handler: consider a RBM case when checking if write... 53232/head
Myoungwon Oh [Fri, 25 Aug 2023 08:55:36 +0000 (17:55 +0900)]
crimson/os/seastore/object_data_handler: consider a RBM case when checking if write can be merged

RBM's paddr always indicates physical address, which means it doesn't have the dealayed.
So, this commit adds a condition that checks if given paddr is used for ongoing write.

Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com>
22 months agoMerge pull request #53305 from xxhdx1985126/wip-seastore-onode-erase-replay
Yingxin [Tue, 12 Sep 2023 01:21:29 +0000 (09:21 +0800)]
Merge pull request #53305 from xxhdx1985126/wip-seastore-onode-erase-replay

crimson/os/seastore/onode_manager: populate value recorders of onodes to be erased

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
22 months agonvmeof-gw: omap object name contains None due to generated template contains string... 53408/head
Roy Sahar [Mon, 11 Sep 2023 22:52:53 +0000 (01:52 +0300)]
nvmeof-gw: omap object name contains None due to generated template contains string None

Signed-off-by: Roy Sahar <royswi@gmail.com>
22 months agoMerge pull request #53344 from ljflores/wip-tracker-62761
Laura Flores [Mon, 11 Sep 2023 22:22:03 +0000 (18:22 -0400)]
Merge pull request #53344 from ljflores/wip-tracker-62761

common: add CephContext parameter to tracing::Tracer::init() in !HAVE_JAEGER branch

22 months agocephadm: convert _write_iscsi_unit_poststop_commands to to use a DaemonIdentity argument
John Mulligan [Thu, 27 Jul 2023 00:08:23 +0000 (20:08 -0400)]
cephadm: convert _write_iscsi_unit_poststop_commands to to use a DaemonIdentity argument

Signed-off-by: John Mulligan <jmulligan@redhat.com>
22 months agocephadm: convert _write_osd_unit_poststop_commands to to use a DaemonIdentity argument
John Mulligan [Thu, 27 Jul 2023 00:05:03 +0000 (20:05 -0400)]
cephadm: convert _write_osd_unit_poststop_commands to to use a DaemonIdentity argument

Signed-off-by: John Mulligan <jmulligan@redhat.com>
22 months agocephadm: convert _write_iscsi_unit_run_commands to to use a DaemonIdentity argument
John Mulligan [Thu, 27 Jul 2023 00:01:26 +0000 (20:01 -0400)]
cephadm: convert _write_iscsi_unit_run_commands to to use a DaemonIdentity argument

Signed-off-by: John Mulligan <jmulligan@redhat.com>
22 months agocephadm: convert _write_osd_unit_run_commands to to use a DaemonIdentity argument
John Mulligan [Thu, 27 Jul 2023 00:00:01 +0000 (20:00 -0400)]
cephadm: convert _write_osd_unit_run_commands to to use a DaemonIdentity argument

Signed-off-by: John Mulligan <jmulligan@redhat.com>
22 months agocephadm: convert _dispatch_deploy to to use a DaemonIdentity argument
John Mulligan [Wed, 26 Jul 2023 23:53:58 +0000 (19:53 -0400)]
cephadm: convert _dispatch_deploy to to use a DaemonIdentity argument

Signed-off-by: John Mulligan <jmulligan@redhat.com>
22 months agocephadm: convert get_deployment_type to to use a DaemonIdentity argument
John Mulligan [Wed, 26 Jul 2023 23:50:16 +0000 (19:50 -0400)]
cephadm: convert get_deployment_type to to use a DaemonIdentity argument

Signed-off-by: John Mulligan <jmulligan@redhat.com>
22 months agocephadm: convert get_deployment_container to to use a DaemonIdentity argument
John Mulligan [Wed, 26 Jul 2023 23:40:30 +0000 (19:40 -0400)]
cephadm: convert get_deployment_container to to use a DaemonIdentity argument

Signed-off-by: John Mulligan <jmulligan@redhat.com>
22 months agocephadm: convert get_container to to use a DaemonIdentity argument
John Mulligan [Wed, 26 Jul 2023 23:26:47 +0000 (19:26 -0400)]
cephadm: convert get_container to to use a DaemonIdentity argument

Signed-off-by: John Mulligan <jmulligan@redhat.com>
22 months agocephadm: add daemon_name property to DaemonIdentity
John Mulligan [Wed, 26 Jul 2023 23:25:07 +0000 (19:25 -0400)]
cephadm: add daemon_name property to DaemonIdentity

Add a convenience property to DaemonIdentity and DaemonSubIdentity that
produces a name in the ceph daemon naming convention: <type>.<id>.

Signed-off-by: John Mulligan <jmulligan@redhat.com>
22 months agocephadm: convert deploy_daemon to to use a DaemonIdentity argument
John Mulligan [Wed, 26 Jul 2023 22:45:09 +0000 (18:45 -0400)]
cephadm: convert deploy_daemon to to use a DaemonIdentity argument

Signed-off-by: John Mulligan <jmulligan@redhat.com>
22 months agocephadm: convert deploy_daemon_units to to use a DaemonIdentity argument
John Mulligan [Wed, 26 Jul 2023 17:44:58 +0000 (13:44 -0400)]
cephadm: convert deploy_daemon_units to to use a DaemonIdentity argument

Signed-off-by: John Mulligan <jmulligan@redhat.com>
22 months agocephadm: convert get_daemon_args to use DaemonIdentity argument
John Mulligan [Wed, 26 Jul 2023 17:33:24 +0000 (13:33 -0400)]
cephadm: convert get_daemon_args to use DaemonIdentity argument

Signed-off-by: John Mulligan <jmulligan@redhat.com>
22 months agocephadm: assert that DaemonIdentity has valid values
John Mulligan [Wed, 26 Jul 2023 17:26:48 +0000 (13:26 -0400)]
cephadm: assert that DaemonIdentity has valid values

Signed-off-by: John Mulligan <jmulligan@redhat.com>
22 months agocephadm: convert get_container_mounts to use a DaemonIdentity argument
John Mulligan [Wed, 26 Jul 2023 17:24:36 +0000 (13:24 -0400)]
cephadm: convert get_container_mounts to use a DaemonIdentity argument

Convert get_container_mounts to use a DaemonIdentity argument, and in
order to do so: split get_container_mounts_for_type out of
get_container_mounts. get_container_mounts will take a DaemonIdentity
and safely assume that the fsid, daemon_type, daemon_id triple is
available whereas get_container_mounts_for_type has the functionality
of only requiring the fsid and daemon_type.

Signed-off-by: John Mulligan <jmulligan@redhat.com>
22 months agocephadm: convert get_container_binds to use a DaemonIdentity argument
John Mulligan [Wed, 26 Jul 2023 14:46:17 +0000 (10:46 -0400)]
cephadm: convert get_container_binds to use a DaemonIdentity argument

Signed-off-by: John Mulligan <jmulligan@redhat.com>
22 months agocephadm: convert _write_custom_conf_files to use a DaemonIdentity arg
John Mulligan [Wed, 26 Jul 2023 14:35:09 +0000 (10:35 -0400)]
cephadm: convert _write_custom_conf_files to use a DaemonIdentity arg

Signed-off-by: John Mulligan <jmulligan@redhat.com>
22 months agosrc/common: add context to tracing::Tracer::init 53344/head
Laura Flores [Fri, 8 Sep 2023 17:49:01 +0000 (17:49 +0000)]
src/common: add context to tracing::Tracer::init

Followup to https://github.com/ceph/ceph/pull/50948. This wasn't originally
caught since the centos 8 default build passed, but it did fail the
crimson build: https://shaman.ceph.com/builds/ceph/wip-yuri3-testing-2023-08-15-0955/b5259484dbc61e8573f27e692560c6c107b9d4c1/

Fixes: https://tracker.ceph.com/issues/62761
Signed-off-by: Laura Flores <lflores@ibm.com>
22 months agocephadm: convert create_daemon_dirs to use a DaemonIdentity argument
John Mulligan [Wed, 26 Jul 2023 14:29:57 +0000 (10:29 -0400)]
cephadm: convert create_daemon_dirs to use a DaemonIdentity argument

Signed-off-by: John Mulligan <jmulligan@redhat.com>
22 months agocephadm: replace get_data_dir & make_data_dir args with DaemonIdentity
John Mulligan [Tue, 25 Jul 2023 21:24:00 +0000 (17:24 -0400)]
cephadm: replace get_data_dir & make_data_dir args with DaemonIdentity

Signed-off-by: John Mulligan <jmulligan@redhat.com>
22 months agocephadm: split get_unit_name into two functions
John Mulligan [Tue, 25 Jul 2023 20:46:01 +0000 (16:46 -0400)]
cephadm: split get_unit_name into two functions

The previous version of get_unit_name was effectively overloaded,
so that you could pass either an fsid, daemon_type, & daemon_id OR
pass an fsid and a "daemon_type" only that wasn't actually a daemon_type
but rather the instance name of the systemd service. Separate the
two use cases into two functions, making the naming more correct and
the code more audit-able overall.

Signed-off-by: John Mulligan <jmulligan@redhat.com>
22 months agocephadm: add unit_name property to DaemonIdentity
John Mulligan [Tue, 25 Jul 2023 20:36:31 +0000 (16:36 -0400)]
cephadm: add unit_name property to DaemonIdentity

Replace some uses of get_unit_name with the new method.

Signed-off-by: John Mulligan <jmulligan@redhat.com>
22 months agocephadm: use DaemonIdentity in arguments to CephContainer.for_daemon
John Mulligan [Tue, 25 Jul 2023 20:23:34 +0000 (16:23 -0400)]
cephadm: use DaemonIdentity in arguments to CephContainer.for_daemon

Previously, the CephContainer.for_daemon took separate arguments for
fsid, daemon_type, & daemon_id. Now that we have a dedicated type
for encapsulating those values, switch for_daemon to take
a DaemonIdentity instead.

Signed-off-by: John Mulligan <jmulligan@redhat.com>
22 months agocephadm: split DaemonSubIdentity class off from DaemonIdentity
John Mulligan [Tue, 25 Jul 2023 18:08:52 +0000 (14:08 -0400)]
cephadm: split DaemonSubIdentity class off from DaemonIdentity

Split DaemonSubIdentity into it's own subclass of DaemonIdentity
in order to better use the type system for validation and clarity.
DaemonIdentity loses the `subcomponent` field so that there's no
mistaking a DaemonIdentity with a DaemonSubIdentity.
This will make a lot more sense once there are more uses of
DaemonSubIdentity in the codebase.

Signed-off-by: John Mulligan <jmulligan@redhat.com>
22 months agoMerge pull request #53390 from rishabh-d-dave/cephfs-doc-admin
Rishabh Dave [Mon, 11 Sep 2023 16:49:37 +0000 (22:19 +0530)]
Merge pull request #53390 from rishabh-d-dave/cephfs-doc-admin

doc/cephfs: write cephfs commands fully in docs

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Reviewed-by: Zac Dover <zac.dover@proton.me>
Reviewed-by: Dhairya Parmar <dparmar@redhat.com>
22 months agoMerge pull request #53361 from ronen-fr/wip-rf-moveit
Ronen Friedman [Mon, 11 Sep 2023 16:40:43 +0000 (19:40 +0300)]
Merge pull request #53361 from ronen-fr/wip-rf-moveit

rgw/test: qualifying 'move'

Reviewed-by: Mark Kogan <mkogan@redhat.com>
Reviewed-by: Yuval Lifshitz <ylifshit@redhat.com>
22 months agoMerge pull request #53369 from yuvalif/wip-yuval-62784
Yuval Lifshitz [Mon, 11 Sep 2023 16:08:15 +0000 (19:08 +0300)]
Merge pull request #53369 from yuvalif/wip-yuval-62784

rgw/notifications: allow cross tenant notification management

reviewed-by: mattbenjamin

22 months agoMerge pull request #52043 from adk3798/tcmu-entrypoint
Adam King [Mon, 11 Sep 2023 15:32:55 +0000 (11:32 -0400)]
Merge pull request #52043 from adk3798/tcmu-entrypoint

cephadm: run tcmu-runner through script to do restart on failure

Reviewed-by: John Mulligan <jmulligan@redhat.com>
22 months agoMerge pull request #52881 from adk3798/upgrade-test-start-squid
Adam King [Mon, 11 Sep 2023 15:29:38 +0000 (11:29 -0400)]
Merge pull request #52881 from adk3798/upgrade-test-start-squid

qa/cephadm: start upgrade tests from quincy

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
22 months agoRadosGW API: incorrect bucket quota in response to HEAD /{bucket}/?usage 53391/head
shreyanshjain7174 [Mon, 11 Sep 2023 10:40:33 +0000 (06:40 -0400)]
RadosGW API: incorrect bucket quota in response to HEAD /{bucket}/?usage

When we try to get the bucket usage via various methods, through curl or while accessing rgw api endpoint at HEAD /{bucket}/?usage doesn't return the updated information. The endpoint was always returning the user quota and not the actual bucket quota which we see after querying the endpoint.

Fixes: https://tracker.ceph.com/issues/62737
Signed-off-by: shreyanshjain7174 <ssanchet@redhat.com>
22 months agoMerge pull request #52708 from vshankar/wip-62236
Adam King [Mon, 11 Sep 2023 14:56:20 +0000 (10:56 -0400)]
Merge pull request #52708 from vshankar/wip-62236

qa: move nfs (mgr/nfs) related tests to fs suite

Reviewed-by: Adam King <adking@redhat.com>
22 months agoMerge pull request #53343 from markhpc/wip-rocksdb-compression
Mark Nelson [Mon, 11 Sep 2023 14:55:20 +0000 (09:55 -0500)]
Merge pull request #53343 from markhpc/wip-rocksdb-compression

common/options: Set LZ4 compression for bluestore RocksDB.

22 months agoMerge pull request #53072 from adk3798/tcmu-custom-configs
Adam King [Mon, 11 Sep 2023 14:30:06 +0000 (10:30 -0400)]
Merge pull request #53072 from adk3798/tcmu-custom-configs

cephadm: make custom_configs work for tcmu-runner container

Reviewed-by: John Mulligan <jmulligan@redhat.com>
22 months agoMerge pull request #53252 from adk3798/no-tags-upgrade-ls
Adam King [Mon, 11 Sep 2023 14:28:38 +0000 (10:28 -0400)]
Merge pull request #53252 from adk3798/no-tags-upgrade-ls

mgr/cephadm: don't use image tag in orch upgrade ls

Reviewed-by: John Mulligan <jmulligan@redhat.com>
22 months agoMerge pull request #53297 from phlogistonjohn/jjm-logging
Adam King [Mon, 11 Sep 2023 14:27:05 +0000 (10:27 -0400)]
Merge pull request #53297 from phlogistonjohn/jjm-logging

cephadm: move logging configuration into cephadmlib

Reviewed-by: Adam King <adking@redhat.com>
22 months agoMerge pull request #53081 from kchheda3/wip-add-log
Yuval Lifshitz [Mon, 11 Sep 2023 14:22:51 +0000 (17:22 +0300)]
Merge pull request #53081 from kchheda3/wip-add-log

rgw/notification: enrich the expired notification log line for persistent notificatio

reviewed-by: thotz, yuvalif

22 months agoMerge pull request #53009 from kchheda3/wip-bucket-stats-notification
Yuval Lifshitz [Mon, 11 Sep 2023 14:22:17 +0000 (17:22 +0300)]
Merge pull request #53009 from kchheda3/wip-bucket-stats-notification

rgw/notification: Publish notification information in bucket stats

reviewed-by: yuvalif

22 months agoMerge pull request #53073 from kchheda3/wip-filter-noti-uid
Yuval Lifshitz [Mon, 11 Sep 2023 14:21:47 +0000 (17:21 +0300)]
Merge pull request #53073 from kchheda3/wip-filter-noti-uid

rgw/notification: Filter topic list based on uid

reviewed-by: yuvalif

22 months agoMerge pull request #53383 from zdover23/wip-doc-2023-09-11-glossary-ceph-client-link
Anthony D'Atri [Mon, 11 Sep 2023 13:53:53 +0000 (09:53 -0400)]
Merge pull request #53383 from zdover23/wip-doc-2023-09-11-glossary-ceph-client-link

doc/glossary: link to "ceph clients" from entry

22 months agocephadm: remove duplicates when listing files in scan 53296/head
John Mulligan [Tue, 5 Sep 2023 18:18:45 +0000 (14:18 -0400)]
cephadm: remove duplicates when listing files in scan

Fix running tox env flake8 during a rebase/merge where git ls-files
may return duplicate file names.

An earlier version of this change used the `--deuplicate` option to `git
ls-files` in order to remove duplicate files listed when running the
tool during rebase/merge. Mysteriously, this seemed to break the `ceph
API tests` in the CI. A completely unrelated command in a tox file that,
AFAIK, is not executed in that test suite. They ways of git are
subtle and often sucky.

Signed-off-by: John Mulligan <jmulligan@redhat.com>
22 months agoMerge pull request #53246 from rhcs-dashboard/subvolumes-in-subvolumegroups
Nizamudeen A [Mon, 11 Sep 2023 12:53:22 +0000 (18:23 +0530)]
Merge pull request #53246 from rhcs-dashboard/subvolumes-in-subvolumegroups

mgr/dashboard: display the groups in cephfs subvolume tab

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
22 months agoMerge pull request #53323 from rhcs-dashboard/rgw-port-error
Nizamudeen A [Mon, 11 Sep 2023 11:56:02 +0000 (17:26 +0530)]
Merge pull request #53323 from rhcs-dashboard/rgw-port-error

mgr/dashboard: fix rgw port manipulation error in dashboard

Reviewed-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
22 months agoMerge pull request #53389 from alvinowyong/wip-doc-remove-ec-profile-warning
zdover23 [Mon, 11 Sep 2023 10:05:20 +0000 (20:05 +1000)]
Merge pull request #53389 from alvinowyong/wip-doc-remove-ec-profile-warning

doc/rados/operations: Add manual CRUSH rule remove warning to erasure-code-profile.rst

Reviewed-by: Zac Dover <zac.dover@proton.me>
22 months agodoc/cephfs: write cephfs commands fully in docs 53390/head
Rishabh Dave [Mon, 11 Sep 2023 09:55:46 +0000 (15:25 +0530)]
doc/cephfs: write cephfs commands fully in docs

We write CephFS commands incompletely in docs. For example, "ceph tell
mds.a help" is simply written as "tell mds.a help". This might confuse
the reader and it won't harm to write the command in full.

Fixes: https://tracker.ceph.com/issues/62791
Signed-off-by: Rishabh Dave <ridave@redhat.com>
22 months agodoc: Add warning on manual CRUSH rule removal 53389/head
Alvin Owyong [Mon, 11 Sep 2023 09:15:15 +0000 (17:15 +0800)]
doc: Add warning on manual CRUSH rule removal

Add warning for "osd erasure-code-profile rm" section under rados/operations.

Signed-off-by: Alvin Owyong <70066269+alvinowyong@users.noreply.github.com>
22 months agoMerge pull request #53071 from rhcs-dashboard/disable-features-rbd-edit
Nizamudeen A [Mon, 11 Sep 2023 08:27:28 +0000 (13:57 +0530)]
Merge pull request #53071 from rhcs-dashboard/disable-features-rbd-edit

mgr/dashboard: images -> edit -> disable checkboxes for layering and deef-flatten

Reviewed-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
Reviewed-by: Ankush Behl <cloudbehl@gmail.com>
Reviewed-by: Ilya Dryomov <idryomov@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
22 months agomgr/dashboard: CephFS add groups in subvolume tab 53246/head
Pedro Gonzalez Gomez [Thu, 31 Aug 2023 23:54:28 +0000 (01:54 +0200)]
mgr/dashboard: CephFS add groups in subvolume tab

Adds subvolume groups into the subvolume tabs in order to select the subvolumes from the appropiate group.
Also adds the capabilities to manage the subvolume groups of the subvolume in the different actions, create, edit, remove.

Fixes: https://tracker.ceph.com/issues/62675
Signed-off-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
22 months agodoc/glossary: link to "ceph clients" from entry 53383/head
Zac Dover [Mon, 11 Sep 2023 05:18:40 +0000 (15:18 +1000)]
doc/glossary: link to "ceph clients" from entry

Link to the "Ceph Clients" section of doc/architecture.rst from the
"Ceph Clients" entry in the glossary. A glossary entry should be a short
summary of the topic with which it deals, and it should direct the
reader to further and more detailed reading if the reader is interested.
This does that.

Signed-off-by: Zac Dover <zac.dover@proton.me>
22 months agoMerge pull request #53236 from rhcs-dashboard/subvolume-size-validator-fix
Nizamudeen A [Mon, 11 Sep 2023 04:35:52 +0000 (10:05 +0530)]
Merge pull request #53236 from rhcs-dashboard/subvolume-size-validator-fix

mgr/dashboard: add validator for size field in the forms

Reviewed-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
22 months agocrimson/os/seastore/onode_manager: populate value recorders of onodes to 53305/head
Xuehan Xu [Wed, 6 Sep 2023 06:56:51 +0000 (14:56 +0800)]
crimson/os/seastore/onode_manager: populate value recorders of onodes to
be erased

Otherwise, the following modification sequence with the same transaction
might lead to onode extents' crc inconsistency during journal replay:

1. modify the last mapping in an onode extent;
2. erase the last mapping in that onode extent.

During journal replay, if the first modification is not recorded in the
delta, the onode extent's content would be inconsistent with that before
the system reboot

Signed-off-by: Xuehan Xu <xuxuehan@qianxin.com>
22 months agotest/crimson/seastore/rbm: add sub-tests regarding RBM to the existing tests
Myoungwon Oh [Thu, 31 Aug 2023 05:13:07 +0000 (14:13 +0900)]
test/crimson/seastore/rbm: add sub-tests regarding RBM to the existing tests

Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com>
22 months agoMerge pull request #53371 from zdover23/wip-doc-2023-09-11-architecture-2-of-x
Anthony D'Atri [Sun, 10 Sep 2023 17:38:53 +0000 (13:38 -0400)]
Merge pull request #53371 from zdover23/wip-doc-2023-09-11-architecture-2-of-x

doc/architecture.rst - edit a sentence

22 months agodoc/architecture.rst - edit a sentence 53371/head
Zac Dover [Sun, 10 Sep 2023 16:31:30 +0000 (02:31 +1000)]
doc/architecture.rst - edit a sentence

Change the sentence structure of a sentence because the verb
"experience" looked like the abstract noun "experience" when I read it
with fresh eyes. I chose the perhaps TESOL-unfriendly verb "incur", but
I believe it is right.

Signed-off-by: Zac Dover <zac.dover@proton.me>
22 months agorgw/test: adding a qualifier to 'move' 53361/head
Ronen Friedman [Sun, 10 Sep 2023 08:31:35 +0000 (11:31 +0300)]
rgw/test: adding a qualifier to 'move'

rgw: adding a qualifier to 'move'

as Clang now requires fully specifying std::move, as
per https://reviews.llvm.org/D119670?id=408276

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
22 months agoexamples: fixed errors with the if-match header in the examples of rgw-cache nginx... 53370/head
Konstantin Monakhov [Sun, 10 Sep 2023 16:08:50 +0000 (22:08 +0600)]
examples: fixed errors with the if-match header in the examples of rgw-cache nginx configs

Signed-off-by: Konstantin Monakhov <stangerkm@gmail.com>
22 months agorgw/notifications: allow cross tenant notification management 53369/head
Yuval Lifshitz [Sun, 10 Sep 2023 14:40:37 +0000 (14:40 +0000)]
rgw/notifications: allow cross tenant notification management

testing instructions:
https://gist.github.com/yuvalif/60063dc67d981b387b382ff0f7f88d91

Fixes: https://tracker.ceph.com/issues/62784
Signed-off-by: Yuval Lifshitz <ylifshit@redhat.com>
22 months agoMerge pull request #53353 from zdover23/wip-doc-2023-09-10-architecture-1-of-x
zdover23 [Sun, 10 Sep 2023 11:43:44 +0000 (21:43 +1000)]
Merge pull request #53353 from zdover23/wip-doc-2023-09-10-architecture-1-of-x

doc/architecture.rst - edit up to "Cluster Map"

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
22 months agodoc/architecture.rst - edit up to "Cluster Map" 53353/head
Zac Dover [Sun, 10 Sep 2023 03:10:09 +0000 (13:10 +1000)]
doc/architecture.rst - edit up to "Cluster Map"

Edit doc/architecture.rst up to "Cluster Map", but not including
"Cluster Map".

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
22 months agoMerge pull request #53341 from alvinowyong/wip-doc-create-osd-warning
Anthony D'Atri [Sat, 9 Sep 2023 20:08:59 +0000 (16:08 -0400)]
Merge pull request #53341 from alvinowyong/wip-doc-create-osd-warning

doc/cephadm/services: Add package conflict warning to osd.rst

22 months agorgw/file: fix build of librgw_file_xattr.cc unit test 52793/head
Matt Benjamin [Fri, 28 Jul 2023 17:28:32 +0000 (13:28 -0400)]
rgw/file:  fix build of librgw_file_xattr.cc unit test

This resolves a header conflict seen with gcc 12 and clang 17, when
both rgw_file.h and rados/rgw_file.h were included (e.g., in
librgw_file_xattr.cc).

The operative change is the explicit path to rgw_file...h, but
I've renamed it as well to avoid confusion.

Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
22 months agoMerge PR #53331 into main
Patrick Donnelly [Sat, 9 Sep 2023 14:50:22 +0000 (10:50 -0400)]
Merge PR #53331 into main

* refs/pull/53331/head:
Revert "Revert "Merge PR #53077 into main""

Reviewed-by: Ilya Dryomov <idryomov@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>