]> git.apps.os.sepia.ceph.com Git - ceph.git/log
ceph.git
6 years agoMerge pull request #27182 from xiexingguo/wip-38931
Xie Xingguo [Sat, 30 Mar 2019 08:36:47 +0000 (16:36 +0800)]
Merge pull request #27182 from xiexingguo/wip-38931

osd/PG: move down peers out from peer_purged

Reviewed-by: Sage Weil <sage@redhat.com>
6 years agoMerge PR #27249 into master
Sage Weil [Fri, 29 Mar 2019 22:58:53 +0000 (17:58 -0500)]
Merge PR #27249 into master

* refs/pull/27249/head:
qa/suites/rados/thrash-old-clients: fix up v1/v2 options

Reviewed-by: Neha Ojha <nojha@redhat.com>
6 years agoMerge PR #27133 into master
Sage Weil [Fri, 29 Mar 2019 22:58:33 +0000 (17:58 -0500)]
Merge PR #27133 into master

* refs/pull/27133/head:
log,global: do not start flusher thread until after we have our mon config
log: buffer log entries until flusher thread starts
log: open log file from flusher thread
common/ceph_context: fix log_to_file observer

Reviewed-by: Kefu Chai <kchai@redhat.com>
6 years agoMerge PR #26976 into master
Patrick Donnelly [Fri, 29 Mar 2019 21:44:16 +0000 (14:44 -0700)]
Merge PR #26976 into master

* refs/pull/26976/head:
doc: add doc for cephfs lazyio

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
6 years agoMerge PR #27199 into master
Patrick Donnelly [Fri, 29 Mar 2019 21:41:37 +0000 (14:41 -0700)]
Merge PR #27199 into master

* refs/pull/27199/head:
mds: fix dump routine for session_info_t.used_inos
mds: fix some misleading log messages
client: comment fix in _lookup
mds: fix comment over MDRequestImpl
mds: use stdbool.h instead of hand-rolling our own bool type

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Zheng Yan <zyan@redhat.com>
6 years agoMerge pull request #27242 from theanalyst/beast-fe-ports
Casey Bodley [Fri, 29 Mar 2019 17:22:09 +0000 (13:22 -0400)]
Merge pull request #27242 from theanalyst/beast-fe-ports

rgw: beast port parsing

Reviewed-by: Casey Bodley <cbodley@redhat.com>
6 years agorgw: beast: set a default port for endpoints 27242/head
Abhishek Lekshmanan [Thu, 28 Mar 2019 12:41:23 +0000 (13:41 +0100)]
rgw: beast: set a default port for endpoints

if no port is specified we don't set one(or set to 0), and don't exactly error
out, so rgw keeps running without being bound to a port. Set the port to default
in these cases

Fixes: http://tracker.ceph.com/issues/39000
Signed-off-by: Abhishek Lekshmanan <abhishek@suse.com>
6 years agoMerge pull request #27213 from ajarr/fix-38946
Kefu Chai [Fri, 29 Mar 2019 14:35:41 +0000 (22:35 +0800)]
Merge pull request #27213 from ajarr/fix-38946

pybind: fix use of WriteOpCtx and ReadOpCtx

Reviewed-by: Sebastian Wagner <swagner@suse.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
6 years agoMerge pull request #27157 from Devp00l/issue-38933
Lenz Grimmer [Fri, 29 Mar 2019 14:24:13 +0000 (15:24 +0100)]
Merge pull request #27157 from Devp00l/issue-38933

mgr/dashboard: FixtureHelper

Reviewed-by: Tiago Melo <tmelo@suse.com>
6 years agoMerge pull request #27247 from Exotelis/polish-translation
Lenz Grimmer [Fri, 29 Mar 2019 14:19:40 +0000 (15:19 +0100)]
Merge pull request #27247 from Exotelis/polish-translation

mgr/dashboard: Add polish translation

Reviewed-by: Tiago Melo <tmelo@suse.com>
6 years agomgr/dashboard: FixtureHelper 27157/head
Stephan Müller [Wed, 13 Feb 2019 13:22:27 +0000 (14:22 +0100)]
mgr/dashboard: FixtureHelper

Fixes: https://tracker.ceph.com/issues/38933
Signed-off-by: Stephan Müller <smueller@suse.com>
6 years agoMerge pull request #27148 from tchaikov/ceph-volume-terminal-unicode
Kefu Chai [Fri, 29 Mar 2019 02:41:33 +0000 (10:41 +0800)]
Merge pull request #27148 from tchaikov/ceph-volume-terminal-unicode

ceph-volume: terminal: encode unicode when writing to stdout

Reviewed-by: Alfredo Deza <adeza@redhat.com>
6 years agoMerge pull request #27252 from yuriw/wip-yuriw-crontab
Yuri Weinstein [Thu, 28 Mar 2019 22:18:12 +0000 (15:18 -0700)]
Merge pull request #27252 from yuriw/wip-yuriw-crontab

qa/tests: added nautilus-x run

6 years agoMerge pull request #27250 from ivancich/wip-update-resharding-docs
J. Eric Ivancich [Thu, 28 Mar 2019 21:18:58 +0000 (17:18 -0400)]
Merge pull request #27250 from ivancich/wip-update-resharding-docs

rgw: updates to resharding documentation

Reviewed-by: Adam Emerson <aemerson@redhat.com>
6 years agorgw: updates to resharding documentation 27250/head
J. Eric Ivancich [Thu, 28 Mar 2019 17:30:08 +0000 (13:30 -0400)]
rgw: updates to resharding documentation

Some minor updates to the resharding documentation with the aim of
clarifying the language and using terms consistently.

Signed-off-by: J. Eric Ivancich <ivancich@redhat.com>
6 years agoqa/tests: added nautilus-x run 27252/head
Yuri Weinstein [Thu, 28 Mar 2019 20:03:24 +0000 (13:03 -0700)]
qa/tests: added nautilus-x run

Signed-off-by: Yuri Weinstein <yweinste@redhat.com>
6 years agoqa/suites/rados/thrash-old-clients: fix up v1/v2 options 27249/head
Sage Weil [Thu, 28 Mar 2019 16:19:05 +0000 (11:19 -0500)]
qa/suites/rados/thrash-old-clients: fix up v1/v2 options

- don't specify ceph.py options in the ceph.py
- instead, specify them in the per-version facet

Note that we don't currently have a way to do v2 only for the mon IPs, so
in the v2only cases, we are still binding the mons to v1.

Signed-off-by: Sage Weil <sage@redhat.com>
6 years agoMerge pull request #27243 from theanalyst/doc-scheduler
Casey Bodley [Thu, 28 Mar 2019 18:23:11 +0000 (14:23 -0400)]
Merge pull request #27243 from theanalyst/doc-scheduler

config-ref: add a note on current scheduler settings.

Reviewed-by: Casey Bodley <cbodley@redhat.com>
Reviewed-by: J. Eric Ivancich <ivancich@redhat.com>
6 years agoMerge PR #27202 into master
Patrick Donnelly [Thu, 28 Mar 2019 16:39:07 +0000 (09:39 -0700)]
Merge PR #27202 into master

* refs/pull/27202/head:
doc: Miscellaneous spelling fixes

Reviewed-by: Volker Theile <vtheile@suse.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Sebastian Wagner <swagner@suse.com>
6 years agoMerge PR #27154 into master
Sage Weil [Thu, 28 Mar 2019 16:21:23 +0000 (11:21 -0500)]
Merge PR #27154 into master

* refs/pull/27154/head:
mgr/pg_autoscaler: apply bias to pg_num selection
mgr/pg_autoscaler: include pg_autoscale_bias in autoscale-status table
osd/osd_types,mon: add pg_autoscale_bias pool property

Reviewed-by: xie xingguo <xie.xingguo@zte.com.cn>
Reviewed-by: Neha Ojha <nojha@redhat.com>
6 years agoMerge PR #27012 into master
Sage Weil [Thu, 28 Mar 2019 16:21:01 +0000 (11:21 -0500)]
Merge PR #27012 into master

* refs/pull/27012/head:
common/options: allow (but to not prefer or require) secure mode
common/options: make clients prefer to connect to mons via secure mode
common/options: allow connections to mons in secure mode
common/options: prefer secure mode between monitors
auth/AuthRegistry: remove experimental flag for 'secure' mode

Reviewed-by: Neha Ojha <nojha@redhat.com>
Reviewed-by: Greg Farnum <gfarnum@redhat.com>
6 years agodocs: rgw: add a x-ref to rados dmclock docs 27243/head
Abhishek Lekshmanan [Thu, 28 Mar 2019 15:41:15 +0000 (16:41 +0100)]
docs: rgw: add a x-ref to rados dmclock docs

Signed-off-by: Abhishek Lekshmanan <abhishek@suse.com>
6 years agomgr/dashboard: Add polish translation 27247/head
Sebastian Krah [Thu, 28 Mar 2019 14:35:46 +0000 (15:35 +0100)]
mgr/dashboard: Add polish translation

Add polish translation.
Removed 5 unused trans-units.

Fixes: https://tracker.ceph.com/issues/38236
Signed-off-by: Sebastian Krah <skrah@suse.com>
6 years agoconfig-ref: add a note on current scheduler settings.
Abhishek Lekshmanan [Thu, 28 Mar 2019 14:09:12 +0000 (15:09 +0100)]
config-ref: add a note on current scheduler settings.

Adding a note on configuirables for max concurrent requests and the rest of
experimental options for tuning dmclock scheduler

Signed-off-by: Abhishek Lekshmanan <abhishek@suse.com>
6 years agomds: fix dump routine for session_info_t.used_inos 27199/head
Jeff Layton [Tue, 26 Mar 2019 19:21:09 +0000 (15:21 -0400)]
mds: fix dump routine for session_info_t.used_inos

It says it's dumping used_inos, but it's really dumping prealloc_inos.

Signed-off-by: Jeff Layton <jlayton@redhat.com>
6 years agoMerge pull request #26887 from theanalyst/reshard-tenant
Casey Bodley [Thu, 28 Mar 2019 13:42:11 +0000 (09:42 -0400)]
Merge pull request #26887 from theanalyst/reshard-tenant

rgw admin: add tenant argument to reshard cancel

Reviewed-by: Casey Bodley <cbodley@redhat.com>
6 years agoMerge pull request #27222 from ceph/wip-doc-dahsboard
Lenz Grimmer [Thu, 28 Mar 2019 12:07:05 +0000 (13:07 +0100)]
Merge pull request #27222 from ceph/wip-doc-dahsboard

mgr/dashboard: fix hacking.rst

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Volker Theile <vtheile@suse.com>
6 years agoMerge pull request #27233 from tchaikov/script/ceph-backport.sh
Kefu Chai [Thu, 28 Mar 2019 11:35:18 +0000 (19:35 +0800)]
Merge pull request #27233 from tchaikov/script/ceph-backport.sh

script/ceph-backport.sh: allow user to specify remote repo

Reviewed-by: Nathan Cutler <ncutler@suse.com>
6 years agoMerge pull request #27135 from ricardoasmarques/iscsi-filter-images-based-on-features
Lenz Grimmer [Thu, 28 Mar 2019 11:24:18 +0000 (12:24 +0100)]
Merge pull request #27135 from ricardoasmarques/iscsi-filter-images-based-on-features

mgr/dashboard: Validate iSCSI images features

Reviewed-by: Tiago Melo <tmelo@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>
6 years agoscript/ceph-backport.sh: allow user to specify remote repo 27233/head
Kefu Chai [Thu, 28 Mar 2019 04:05:51 +0000 (12:05 +0800)]
script/ceph-backport.sh: allow user to specify remote repo

before this change, the script always push to "origin", in my case,
"origin" points to "ceph/ceph", while we need to create the branch in
private repo. and the name of private repo might vary. so would be great
if we can customize this setting.

Signed-off-by: Kefu Chai <kchai@redhat.com>
6 years agoMerge pull request #26914 from votdev/issue_38331
Lenz Grimmer [Thu, 28 Mar 2019 09:55:27 +0000 (10:55 +0100)]
Merge pull request #26914 from votdev/issue_38331

mgr/dashboard: Add separate option to config SSL port

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Sebastian Wagner <swagner@suse.com>
Reviewed-by: Tatjana Dehler <tdehler@suse.com>
6 years agoMerge pull request #27166 from rhcs-dashboard/add-protractor-screenshoter-plugin
Lenz Grimmer [Thu, 28 Mar 2019 09:52:52 +0000 (10:52 +0100)]
Merge pull request #27166 from rhcs-dashboard/add-protractor-screenshoter-plugin

mgr/dashboard: Add protractor-screenshoter-plugin

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Laura Paduano <lpaduano@suse.com>
Reviewed-by: Tiago Melo <tmelo@suse.com>
6 years agoMerge pull request #24678 from rouming/master
Ricardo Dias [Thu, 28 Mar 2019 09:20:55 +0000 (09:20 +0000)]
Merge pull request #24678 from rouming/master

test/fio: introduce fio ioengine: fio_ceph_messenger

Reviewed-by: Igor Fedotov <ifedotov@suse.com>
Reviewed-by: Ricardo Dias <rdias@suse.com>
6 years agoscript/ceph-backport.sh: fix sanity test of issue number
Kefu Chai [Thu, 28 Mar 2019 03:57:21 +0000 (11:57 +0800)]
script/ceph-backport.sh: fix sanity test of issue number

* no need for checking negative numbers
* use regex for matching the number instead of using bash's pattern
  matching, otherwise i have
./ceph-backport.sh: line 79: syntax error in conditional expression:
unexpected token `('
  the pattern matching works fine if i use it in command line, but
  it fails to work in shell script.

Signed-off-by: Kefu Chai <kchai@redhat.com>
6 years agoMerge pull request #27200 from neha-ojha/wip-21174-2
Xie Xingguo [Thu, 28 Mar 2019 00:12:26 +0000 (08:12 +0800)]
Merge pull request #27200 from neha-ojha/wip-21174-2

osd/PGLog: preserve original_crt to check rollbackability

Reviewed-by: xie xingguo <xie.xingguo@zte.com.cn>
6 years agoMerge pull request #27218 from yuriw/wip-yuriw-crontab
Yuri Weinstein [Wed, 27 Mar 2019 20:14:05 +0000 (13:14 -0700)]
Merge pull request #27218 from yuriw/wip-yuriw-crontab

qa/tests: added nautilus-p2p to cron

6 years agomgr/dashboard: fix hacking.rst 27222/head
Ernesto Puerta [Wed, 27 Mar 2019 18:53:32 +0000 (19:53 +0100)]
mgr/dashboard: fix hacking.rst

Add missing dash to `-prod` and specify full command.

Signed-off-by: Ernesto Puerta <epuertat@redhat.com>
6 years agoqa/tests: added nautilus-p2p to cron 27218/head
Yuri Weinstein [Wed, 27 Mar 2019 16:26:10 +0000 (09:26 -0700)]
qa/tests: added nautilus-p2p to cron

Signed-off-by: Yuri Weinstein <yweinste@redhat.com>
6 years agoMerge pull request #27165 from yuriw/wip-yuriw-crontab-master_2
Yuri Weinstein [Wed, 27 Mar 2019 16:19:56 +0000 (09:19 -0700)]
Merge pull request #27165 from yuriw/wip-yuriw-crontab-master_2

qa/tests: reduced number of jobs for `kcephfs`

6 years agoMerge PR #27169 into master
Sage Weil [Wed, 27 Mar 2019 14:48:33 +0000 (09:48 -0500)]
Merge PR #27169 into master

* refs/pull/27169/head:
common/config: parse --default-$option as a default value

Reviewed-by: Sébastien Han <seb@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
6 years agoMerge PR #27022 into master
Sage Weil [Wed, 27 Mar 2019 14:46:10 +0000 (09:46 -0500)]
Merge PR #27022 into master

* refs/pull/27022/head:
msg/async v2: make v2 work on rdma.

Reviewed-by: Ricardo Dias <rdias@suse.com>
6 years agoMerge PR #27184 into master
Sage Weil [Wed, 27 Mar 2019 14:44:17 +0000 (09:44 -0500)]
Merge PR #27184 into master

* refs/pull/27184/head:
mgr/DaemonServer: handle_conf_change - fix broken locking

Reviewed-by: Mykola Golub <mgolub@suse.com>
6 years agoMerge PR #27187 into master
Sage Weil [Wed, 27 Mar 2019 14:43:21 +0000 (09:43 -0500)]
Merge PR #27187 into master

* refs/pull/27187/head:
mgr/dashboard/qa: Increase timeout for test_disable (tasks.mgr.dashboard.test_mgr_module.MgrModuleTelemetryTest)

Reviewed-by: Lenz Grimmer <lgrimmer@suse.com>
6 years agoceph-volume: terminal: encode unicode when writing to stdout 27148/head
Kefu Chai [Sun, 24 Mar 2019 09:11:31 +0000 (17:11 +0800)]
ceph-volume: terminal: encode unicode when writing to stdout

python determins the encoding of stdout and stderr based on the LC_CTYPE
and PYTHONIOENCODING env variable, by default, python3's sys.stdout uses
'utf-8' as its encoding, so it will be able to write unicode string even
the stdout is not attached to a tty device. but when it comes to
python2, it will default to ascii if neither of these variabls is set.
so, if we are writing unicode using `_Write` in an environment where
LC_CTYPE and/or PYTHONIOENCODING are using non UTF-8 encoding, it chokes
by raising `UnicodeEncodeError` exception.

in this change, we add a wrapper around `_Write._writer` so it is able
to write unicode string in such a non-unicode-friendly environment.

for more info related the encoding of stdout and stderr, see
https://docs.python.org/3/using/cmdline.html#envvar-PYTHONIOENCODING .

Signed-off-by: Alfredo Deza <adeza@redhat.com>
Signed-off-by: Kefu Chai <kchai@redhat.com>
6 years agoMerge PR #27196 into master
Sage Weil [Wed, 27 Mar 2019 14:35:38 +0000 (09:35 -0500)]
Merge PR #27196 into master

* refs/pull/27196/head:
mon/MonClient: do not dereference auth_supported.end()

Reviewed-by: xie xingguo <xie.xingguo@zte.com.cn>
Reviewed-by: Sage Weil <sage@redhat.com>
6 years agomgr/dashboard: Add protractor-screenshoter-plugin 27166/head
alfonsomthd [Wed, 27 Mar 2019 14:21:11 +0000 (15:21 +0100)]
mgr/dashboard: Add protractor-screenshoter-plugin

A plugin to save screenshots on E2E tests failures as well as
console logs, raw HTML, ...
All info visualized in an HTML report (screenshots are clickable to see full image).
Useful for debugging/fixing E2E tests.

Signed-off-by: Alfonso Martínez <almartin@redhat.com>
6 years agoMerge pull request #27211 from tchaikov/wip-crimson-partition-args
Kefu Chai [Wed, 27 Mar 2019 13:53:56 +0000 (21:53 +0800)]
Merge pull request #27211 from tchaikov/wip-crimson-partition-args

crimson/osd: partition args the right way

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
6 years agoMerge pull request #27153 from Devp00l/issue-38932
Lenz Grimmer [Wed, 27 Mar 2019 11:49:39 +0000 (12:49 +0100)]
Merge pull request #27153 from Devp00l/issue-38932

mgr/dashboard: Fixes tooltip behavior

Reviewed-by: Laura Paduano <lpaduano@suse.com>
Reviewed-by: Tiago Melo <tmelo@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>
6 years agotest/pybind: fix use of rados.ReadOpCtx and rados.WriteOpCtx 27213/head
Ramana Raja [Wed, 27 Mar 2019 11:25:09 +0000 (16:55 +0530)]
test/pybind: fix use of rados.ReadOpCtx and rados.WriteOpCtx

classes WriteOpCtx and ReadOpCtx don't take in any arguments
during instantiation

Signed-off-by: Ramana Raja <rraja@redhat.com>
6 years agoceph_volume_client: fix use of rados.WriteOpCtx
Ramana Raja [Wed, 27 Mar 2019 11:03:33 +0000 (16:33 +0530)]
ceph_volume_client: fix use of rados.WriteOpCtx

Class WriteOpCtx doesn't take in any arguments during instantiation.

Fixes: http://tracker.ceph.com/issues/38946
Signed-off-by: Ramana Raja <rraja@redhat.com>
6 years agoMerge pull request #27159 from smithfarm/wip-38934
Nathan Cutler [Wed, 27 Mar 2019 11:17:37 +0000 (12:17 +0100)]
Merge pull request #27159 from smithfarm/wip-38934

doc: move Developer Guide to its own subdirectory

Reviewed-by: Sebastian Wagner <swagner@suse.com>
6 years agoMerge pull request #26561 from Devp00l/issue-38418
Lenz Grimmer [Wed, 27 Mar 2019 10:57:34 +0000 (11:57 +0100)]
Merge pull request #26561 from Devp00l/issue-38418

mgr/dashboard: Make preventDefault work with 400 errors

Reviewed-by: Tatjana Dehler <tdehler@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>
6 years agocrimson/osd: partition args the right way 27211/head
Kefu Chai [Wed, 27 Mar 2019 10:30:43 +0000 (18:30 +0800)]
crimson/osd: partition args the right way

before this change, all "unknown" args are considered `ceph_args`, but
there is chance we have command line like

crimson-osd -i 1 -c ceph.conf --smp 1 --cpuset 00000001

in this case, "1" is listed in `unknown_args`, but it is also in
`parsed.options`. so we will put the second "1" into `ceph_args` even it
should be appended to `app_args`.

so, in this change, `std::partition_copy()` is replaced with a
hand-written loop which advances through the `argv` and `unknown_args`,
try to match as many consecutive options are possible. it assumes that
the order of args in `unknown_args` is the same as their order in
`argv[]`.

Signed-off-by: Kefu Chai <kchai@redhat.com>
6 years agoMerge pull request #27190 from tchaikov/wip-ceph.in-asan-only-for-debug
Kefu Chai [Wed, 27 Mar 2019 06:04:10 +0000 (14:04 +0800)]
Merge pull request #27190 from tchaikov/wip-ceph.in-asan-only-for-debug

 ceph.in: only preload asan library for Debug build

Reviewed-by: Samuel Just <sjust@redhat.com>
6 years agoMerge pull request #26813 from DengkeDu/master
Kefu Chai [Wed, 27 Mar 2019 06:03:21 +0000 (14:03 +0800)]
Merge pull request #26813 from DengkeDu/master

cmake/FindRocksDB: fix IMPORTED_LOCATION for ROCKSDB_LIBRARIES

Reviewed-by: Kefu Chai <kchai@redhat.com>
6 years agoMerge pull request #27204 from xiexingguo/wip-clean-weird-brace
Kefu Chai [Wed, 27 Mar 2019 04:57:16 +0000 (12:57 +0800)]
Merge pull request #27204 from xiexingguo/wip-clean-weird-brace

osd/PG: move '}' to the proper place

Reviewed-by: Neha Ojha <nojha@redhat.com>
Reviewed-by: David Zafman <dzafman@redhat.com>
6 years agodoc: add doc for cephfs lazyio 26976/head
Yan, Zheng [Fri, 15 Mar 2019 10:11:57 +0000 (18:11 +0800)]
doc: add doc for cephfs lazyio

Fixes: http://tracker.ceph.com/issues/38729
Signed-off-by: "Yan, Zheng" <zyan@redhat.com>
6 years agocmake/FindRocksDB: fix IMPORTED_LOCATION for ROCKSDB_LIBRARIES 26813/head
dudengke [Thu, 7 Mar 2019 09:04:11 +0000 (17:04 +0800)]
cmake/FindRocksDB: fix IMPORTED_LOCATION for ROCKSDB_LIBRARIES

Signed-off-by: dudengke <pinganddu90@gmail.com>
6 years agoceph.in: only preload asan library if it is enabled 27190/head
Kefu Chai [Tue, 26 Mar 2019 10:11:58 +0000 (18:11 +0800)]
ceph.in: only preload asan library if it is enabled

my ceph cli hung when i build ceph using `CMAKE_BUILD_TYPE=RelWithDebInfo` and
`WITH_SEASTAR=ON`. because in that case, seastar detects for Sanitize flags
support of the compiler, but it does not pull in the build flags to enable
sanitizers. while `ceph` cli still preloaded the `asan_lib_path` because
`ASAN_LIBRARY` was set. this is not right, as we should enable ASAN at
runtime only if we enable it at compile-time.

so, in this change, we preload the ASAN library when `CMAKE_BUILD_TYPE`
is `Debug` and `WITH_SEASTAR=ON`, or `WITH_ASAN=ON`.

Signed-off-by: Kefu Chai <kchai@redhat.com>
6 years agoceph.in: normalize BOOL values found by get_cmake_variables()
Kefu Chai [Tue, 26 Mar 2019 17:26:59 +0000 (01:26 +0800)]
ceph.in: normalize BOOL values found by get_cmake_variables()

Signed-off-by: Kefu Chai <kchai@redhat.com>
6 years agoosd/PG: move '}' to the proper place 27204/head
xie xingguo [Wed, 27 Mar 2019 01:28:56 +0000 (09:28 +0800)]
osd/PG: move '}' to the proper place

Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
6 years agoosd/PG: move down peers out from peer_purged 27182/head
xie xingguo [Tue, 26 Mar 2019 07:02:02 +0000 (15:02 +0800)]
osd/PG: move down peers out from peer_purged

In purge_strays(), we'll aggressively clear stray_set and
add all related peers into peer_purged.

However, if the corrsponding peer is down and becomes
up again, (unconditionally) adding it to peer_purged
will prevent primary from re-purging it.
(See Active::react(const MNotifyRec& notevt))

On consuming a new osdmap, let's move any down peers out from
peer_purged simutaneously. This way we can lower the risk
of leaving any leftover PGs behind.

Related-to: http://tracker.ceph.com/issues/38931
Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
6 years agoMerge pull request #26942 from dzafman/wip-38616
David Zafman [Tue, 26 Mar 2019 23:48:09 +0000 (16:48 -0700)]
Merge pull request #26942 from dzafman/wip-38616

Feature: Improvements to auto repair

Reviewed-by: Neha Ojha <nojha@redhat.com>
6 years agodoc: Miscellaneous spelling fixes 27202/head
Bryan Stillwell [Tue, 26 Mar 2019 20:52:12 +0000 (14:52 -0600)]
doc: Miscellaneous spelling fixes

While looking over the documentation I found a few words being misspelled.

Signed-off-by: Bryan Stillwell <bstillwell@godaddy.com>
6 years agoMerge PR #27162 into master
Sage Weil [Tue, 26 Mar 2019 20:06:30 +0000 (15:06 -0500)]
Merge PR #27162 into master

* refs/pull/27162/head:
os/bluestore: nice used space report for bluefs-bdev-sizes command.
tools/ceph-kvstore-tool: command to show RocksDB compaction stats.

Reviewed-by: Sage Weil <sage@redhat.com>
6 years agoosd/PGLog: preserve original_crt in merge_log() 27200/head
Neha Ojha [Mon, 25 Mar 2019 21:48:04 +0000 (14:48 -0700)]
osd/PGLog: preserve original_crt in merge_log()

Fixes: https://tracker.ceph.com/issues/21174
Signed-off-by: Neha Ojha <nojha@redhat.com>
6 years agoMerge pull request #26852 from theanalyst/wip-stale-instance-multisite
Casey Bodley [Tue, 26 Mar 2019 17:33:40 +0000 (13:33 -0400)]
Merge pull request #26852 from theanalyst/wip-stale-instance-multisite

rgw admin: disable stale instance delete in a multiste env

Reviewed-by: Casey Bodley <cbodley@redhat.com>
6 years agoos/bluestore: nice used space report for bluefs-bdev-sizes command. 27162/head
Igor Fedotov [Mon, 25 Mar 2019 16:21:53 +0000 (19:21 +0300)]
os/bluestore: nice used space report for bluefs-bdev-sizes command.

Signed-off-by: Igor Fedotov <ifedotov@suse.com>
6 years agotools/ceph-kvstore-tool: command to show RocksDB compaction stats.
Igor Fedotov [Mon, 25 Mar 2019 15:42:00 +0000 (18:42 +0300)]
tools/ceph-kvstore-tool: command to show RocksDB compaction stats.

In fact this command will provide zeros for most of compaction stuff as
completed compactions are required to provide most of numbers.
But one can use it to learn per-level DB statistics: (amount of files,
occupied space, etc).

Signed-off-by: Igor Fedotov <ifedotov@suse.com>
6 years agoMerge PR #26936 into master
Sage Weil [Tue, 26 Mar 2019 16:43:19 +0000 (11:43 -0500)]
Merge PR #26936 into master

* refs/pull/26936/head:
msg: default to debug_ms=0

Reviewed-by: Mark Nelson <mnelson@redhat.com>
6 years agoMerge PR #27069 into master
Sage Weil [Tue, 26 Mar 2019 16:37:48 +0000 (11:37 -0500)]
Merge PR #27069 into master

* refs/pull/27069/head:
mgr: Configure Py root logger for Mgr modules

Reviewed-by: Sebastian Wagner <swagner@suse.com>
6 years agoMerge PR #27084 into master
Sage Weil [Tue, 26 Mar 2019 16:36:16 +0000 (11:36 -0500)]
Merge PR #27084 into master

* refs/pull/27084/head:
osd: process_copy_chunk remove obc ref before pg unlock

Reviewed-by: Myoungwon Oh <omwmw@sk.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
6 years agoMerge PR #27142 into master
Sage Weil [Tue, 26 Mar 2019 16:35:59 +0000 (11:35 -0500)]
Merge PR #27142 into master

* refs/pull/27142/head:
osd/OSDMap: add log for better debugging
osd/OSDMap: calc_pg_upmaps - restrict optimization to origin pools only

Reviewed-by: Sage Weil <sage@redhat.com>
6 years agoMerge PR #27155 into master
Sage Weil [Tue, 26 Mar 2019 16:35:45 +0000 (11:35 -0500)]
Merge PR #27155 into master

* refs/pull/27155/head:
mon/ConfigMonitor: make 'config reset' idempotent

Reviewed-by: Sage Weil <sage@redhat.com>
6 years agomon/MonClient: do not dereference auth_supported.end() 27196/head
Kefu Chai [Tue, 26 Mar 2019 16:02:01 +0000 (00:02 +0800)]
mon/MonClient: do not dereference auth_supported.end()

if we are unable to find a supported method in allowed_methods, we will
dereference `auth_supported.end()` for searching it in desperation.

Reported-by: xie xingguo <xie.xingguo@zte.com.cn>
Signed-off-by: Kefu Chai <kchai@redhat.com>
6 years agoMerge PR #27172 into master
Sage Weil [Tue, 26 Mar 2019 16:07:17 +0000 (11:07 -0500)]
Merge PR #27172 into master

* refs/pull/27172/head:
mgr/devicehealth: Fix python 3 incompatiblity

Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Sebastian Wagner <swagner@suse.com>
6 years agocommon/config: parse --default-$option as a default value 27169/head
Sage Weil [Mon, 25 Mar 2019 18:40:19 +0000 (13:40 -0500)]
common/config: parse --default-$option as a default value

Sometimes it is useful to specify an alternative default value for an
option via the command line such that it has a lower priority than the
mon config database, config file, the rest of the command line, or the
environment.

Signed-off-by: Sage Weil <sage@redhat.com>
6 years agoceph.in: use get_cmake_variables(*args)
Kefu Chai [Tue, 26 Mar 2019 09:57:08 +0000 (17:57 +0800)]
ceph.in: use get_cmake_variables(*args)

and return values in a list for better readability and less repeating

Signed-off-by: Kefu Chai <kchai@redhat.com>
6 years agoMerge pull request #27183 from tchaikov/wip-ceph.spec.in-devtoolset-8
Kefu Chai [Tue, 26 Mar 2019 15:41:58 +0000 (23:41 +0800)]
Merge pull request #27183 from tchaikov/wip-ceph.spec.in-devtoolset-8

rpm: s/devtoolset-7/devtoolset-8/

Reviewed-by: Brad Hubbard <bhubbard@redhat.com>
6 years agoMerge pull request #27177 from tchaikov/wip-crimson-stop-before-exit
Kefu Chai [Tue, 26 Mar 2019 15:39:29 +0000 (23:39 +0800)]
Merge pull request #27177 from tchaikov/wip-crimson-stop-before-exit

crimson/osd: call at_exit() before stopping the engine

Reviewed-by: Samuel Just <sjust@redhat.com>
6 years agomds: fix some misleading log messages
Jeff Layton [Mon, 18 Mar 2019 14:02:37 +0000 (10:02 -0400)]
mds: fix some misleading log messages

There is no process_cap_release function. Change it to print __func__
instead.

Signed-off-by: Jeff Layton <jlayton@redhat.com>
6 years agoclient: comment fix in _lookup
Jeff Layton [Tue, 12 Mar 2019 12:55:16 +0000 (08:55 -0400)]
client: comment fix in _lookup

We're checking for Fs caps on the directory, _not_ a dentry lease.

Signed-off-by: Jeff Layton <jlayton@redhat.com>
6 years agomds: fix comment over MDRequestImpl
Jeff Layton [Tue, 19 Mar 2019 14:25:42 +0000 (10:25 -0400)]
mds: fix comment over MDRequestImpl

Signed-off-by: Jeff Layton <jlayton@redhat.com>
6 years agomds: use stdbool.h instead of hand-rolling our own bool type
Jeff Layton [Wed, 6 Mar 2019 14:59:45 +0000 (09:59 -0500)]
mds: use stdbool.h instead of hand-rolling our own bool type

Signed-off-by: Jeff Layton <jlayton@redhat.com>
6 years agomgr/dashboard/qa: Increase timeout for test_disable (tasks.mgr.dashboard.test_mgr_mod... 27187/head
Volker Theile [Tue, 26 Mar 2019 09:06:42 +0000 (10:06 +0100)]
mgr/dashboard/qa: Increase timeout for test_disable (tasks.mgr.dashboard.test_mgr_module.MgrModuleTelemetryTest)

Fixes: https://tracker.ceph.com/issues/38820
Signed-off-by: Volker Theile <vtheile@suse.com>
6 years agoMerge pull request #27192 from idryomov/wip-krbd-discard-fixups
Ilya Dryomov [Tue, 26 Mar 2019 13:09:41 +0000 (14:09 +0100)]
Merge pull request #27192 from idryomov/wip-krbd-discard-fixups

qa/workunits/rbd: fixups for the new krbd discard behavior

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
6 years agoMerge pull request #26925 from votdev/issue_38265
Lenz Grimmer [Tue, 26 Mar 2019 12:44:19 +0000 (13:44 +0100)]
Merge pull request #26925 from votdev/issue_38265

mgr/dashboard/qa: Improve tasks.mgr.test_dashboard.TestDashboard.test_standby

Reviewed-by: Laura Paduano <lpaduano@suse.com>
Reviewed-by: Tatjana Dehler <tdehler@suse.com>
6 years agoMerge pull request #26396 from familyuu/interval
Lenz Grimmer [Tue, 26 Mar 2019 12:41:35 +0000 (13:41 +0100)]
Merge pull request #26396 from familyuu/interval

mgr/dashboard: Add refresh  interval to the dashboard landing page

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Kanika Murarka <kmurarka@redhat.com>
Reviewed-by: Volker Theile <vtheile@suse.com>
6 years agoMerge pull request #27136 from trociny/wip-38895
Jason Dillaman [Tue, 26 Mar 2019 12:21:37 +0000 (08:21 -0400)]
Merge pull request #27136 from trociny/wip-38895

librbd: trash move return EBUSY instead of EINVAL for migrating image

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
6 years agoMerge pull request #27137 from trociny/wip-qa-rbd-qos
Jason Dillaman [Tue, 26 Mar 2019 12:21:18 +0000 (08:21 -0400)]
Merge pull request #27137 from trociny/wip-qa-rbd-qos

qa: add RBD QOS functional test

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
6 years agoMerge pull request #27151 from trociny/wip-38928
Jason Dillaman [Tue, 26 Mar 2019 12:20:43 +0000 (08:20 -0400)]
Merge pull request #27151 from trociny/wip-38928

librbd: look for pool metadata in default namespace

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
6 years agoMerge pull request #27118 from sebastian-philipp/mypy-gitignore
Sebastian Wagner [Tue, 26 Mar 2019 10:05:36 +0000 (11:05 +0100)]
Merge pull request #27118 from sebastian-philipp/mypy-gitignore

scrips/run_mypy: add .gitignore

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
6 years agoscrips/run_mypy: add .gitignore 27118/head
Sebastian Wagner [Fri, 22 Mar 2019 09:46:52 +0000 (10:46 +0100)]
scrips/run_mypy: add .gitignore

Co-Authored-by: Patrick Nawracay <pnawracay@suse.com>
Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
6 years agoMerge pull request #27181 from tchaikov/wip-test/test_weighted_shuffle
Kefu Chai [Tue, 26 Mar 2019 08:37:58 +0000 (16:37 +0800)]
Merge pull request #27181 from tchaikov/wip-test/test_weighted_shuffle

test/test_weighted_shuffle: enlarge epsilon

Reviewed-by: xie xingguo <xie.xingguo@zte.com.cn>
6 years agomgr/DaemonServer: handle_conf_change - fix broken locking 27184/head
xie xingguo [Tue, 26 Mar 2019 08:08:43 +0000 (16:08 +0800)]
mgr/DaemonServer: handle_conf_change - fix broken locking

The is_locked_by_me() is only meant to be safe if you know
you hold the lock. It's meant to be used in an assertion.

Fixes: http://tracker.ceph.com/issues/38899
Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
6 years agorpm: s/devtoolset-7/devtoolset-8/ 27183/head
Kefu Chai [Tue, 26 Mar 2019 07:19:58 +0000 (15:19 +0800)]
rpm: s/devtoolset-7/devtoolset-8/

should activate devtoolset-8 not devtoolset-7 for enabling GCC-8.

Signed-off-by: Kefu Chai <kchai@redhat.com>
6 years agotest/test_weighted_shuffle: enlarge epsilon 27181/head
Kefu Chai [Tue, 26 Mar 2019 05:30:53 +0000 (13:30 +0800)]
test/test_weighted_shuffle: enlarge epsilon

be more permissive to address the following failure:

test_weighted_shuffle.cc:36: Failure
The difference between float(w) / total_weight and float(f.front()) /
samples is 0.010334432125091553, which exceeds epsilon, where
float(w) / total_weight evaluates to 0.53763443231582642,
float(f.front()) / samples evaluates to 0.52730000019073486, and
epsilon evaluates to 0.0099999997764825821

Signed-off-by: Kefu Chai <kchai@redhat.com>
6 years agocrimson/osd: call at_exit() before stopping the engine 27177/head
Kefu Chai [Tue, 26 Mar 2019 03:59:01 +0000 (11:59 +0800)]
crimson/osd: call at_exit() before stopping the engine

if we mkfs and stop the engine, any calls using the engine should/will
fail after `seastar::engine().exit(0)`. in the case of reactor::at_exit(),
it has:

assert(!_stopping);

in this change, we register the at_exit() calls before scheduling the
`engine().exit(0)` call.

Signed-off-by: Kefu Chai <kchai@redhat.com>
6 years agoMerge pull request #27149 from wjwithagen/wjw-fix-stdFileSystem
Kefu Chai [Tue, 26 Mar 2019 03:05:29 +0000 (11:05 +0800)]
Merge pull request #27149 from wjwithagen/wjw-fix-stdFileSystem

cmake: use StdFilesystem::filesystem instead of stdc++fs

Reviewed-by: Kefu Chai <kchai@redhat.com>
6 years agoMerge pull request #27134 from tchaikov/wip-devtools-8
Kefu Chai [Tue, 26 Mar 2019 01:45:55 +0000 (09:45 +0800)]
Merge pull request #27134 from tchaikov/wip-devtools-8

install-dep,rpm: use devtools-8 on amd64

Reviewed-by: Sage Weil <sage@redhat.com>
Reviewed-by: Brad Hubbard <bhubbard@redhat.com>