]>
git.apps.os.sepia.ceph.com Git - ceph.git/log
Adam Kupczyk [Fri, 13 Oct 2023 14:07:57 +0000 (16:07 +0200)]
Merge pull request #53732 from pereman2/bluefs-expand-bug
os/bluestore: fix bluefs _extend_log seq update
zdover23 [Fri, 13 Oct 2023 13:40:38 +0000 (23:40 +1000)]
Merge pull request #53986 from zdover23/wip-doc-2023-10-12-rados-troubleshooting-troubleshooting-osd-2-of-x
doc/rados: Edit troubleshooting-osd (2 of x)
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Zac Dover [Thu, 12 Oct 2023 08:33:58 +0000 (18:33 +1000)]
doc/rados: Edit troubleshooting-osd (2 of x)
Edit doc/rados/troubleshooting/troubleshooting.rst (2 of x).
Follows https://github.com/ceph/ceph/pull/53936.
Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
Yingxin [Fri, 13 Oct 2023 08:28:34 +0000 (16:28 +0800)]
Merge pull request #53234 from xxhdx1985126/wip-seastore-onode-manager-replay
crimson/os/seastore/onode_manager: populate delta recorders for each onode modification
Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
Ilya Dryomov [Thu, 12 Oct 2023 19:29:05 +0000 (21:29 +0200)]
Merge pull request #53914 from idryomov/wip-63149
qa/suites/rbd: drop cache tiering workload tests
Reviewed-by: Ramana Raja <rraja@redhat.com>
Reviewed-by: Mykola Golub <mgolub@suse.com>
Adam King [Thu, 12 Oct 2023 19:24:26 +0000 (15:24 -0400)]
Merge pull request #51416 from adk3798/jaeger-agent-dep
mgr/cephadm: make jaeger-collector a dep for jaeger-agent
Reviewed-by: John Mulligan <jmulligan@redhat.com>
Yuri Weinstein [Thu, 12 Oct 2023 14:56:01 +0000 (07:56 -0700)]
Merge pull request #53980 from ceph/wip-yuri-crontab-main
qa/tests: fixed typo and added `--force-priority` in missing places
Reviewed-by: Laura Flores <lflores@redhat.com>
Yingxin [Thu, 12 Oct 2023 06:44:11 +0000 (14:44 +0800)]
Merge pull request #53062 from xxhdx1985126/wip-seastore-list-objects
crimson/os/seastore: return ghobject_t::max as the end when list_objects reaches the end of the listing
Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
Reviewed-by: Chunmei Liu <chunmei.liu@intel.com>
zdover23 [Thu, 12 Oct 2023 05:15:58 +0000 (15:15 +1000)]
Merge pull request #53936 from zdover23/wip-doc-2023-10-11-rados-troubleshooting-troubleshooting-osd-1-of-x
doc/rados: edit troubleshooting-osd (1 of x)
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Zac Dover [Wed, 11 Oct 2023 10:38:55 +0000 (20:38 +1000)]
doc/rados: edit troubleshooting-osd (1 of x)
Edit doc/rados/troubleshooting/troubleshooting-osd.
Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
zdover23 [Thu, 12 Oct 2023 03:44:24 +0000 (13:44 +1000)]
Merge pull request #53971 from zdover23/wip-doc-2023-10-12-start-get-involved-slack
doc/start: add Slack to get-involved
Reviewed-by: Laura Flores <lflores@redhat.com>
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Yuri Weinstein [Wed, 11 Oct 2023 22:07:02 +0000 (15:07 -0700)]
qa/tests: fixed typo and added `--force-priority` in missing places
Signed-off-by: Yuri Weinstein <yweinste@redhat.com>
Zack Cerza [Wed, 11 Oct 2023 21:10:14 +0000 (15:10 -0600)]
Merge pull request #53926 from zmc/workunit-assert-client-role
qa/tasks/workunit: improve assert on client names
Zac Dover [Wed, 11 Oct 2023 16:29:12 +0000 (02:29 +1000)]
doc/start: add Slack to get-involved
Add a link to the Ceph Slack to doc/start/get-involved.rst.
Signed-off-by: Zac Dover <zac.dover@proton.me>
Casey Bodley [Wed, 11 Oct 2023 15:59:20 +0000 (16:59 +0100)]
Merge pull request #53846 from cbodley/wip-62989-again
rgw: fix http error checks in keystone/barbican/vault clients
Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
Radoslaw Zarzynski [Wed, 11 Oct 2023 15:01:44 +0000 (17:01 +0200)]
Merge pull request #53579 from Matan-B/wip-matanb-reset_purged_snaps_last
osd/OSD: introduce reset_purged_snaps_last
Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
zdover23 [Wed, 11 Oct 2023 00:39:53 +0000 (10:39 +1000)]
Merge pull request #53908 from zdover23/wip-doc-2023-10-10-troubleshooting-troubleshooting-memory-profiling
doc/rados: edit memory-profiling.rst
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Yuri Weinstein [Tue, 10 Oct 2023 23:01:19 +0000 (16:01 -0700)]
Merge pull request #53930 from ceph/wip-yuri-crontab-main
qa/tests: Added upgrade/reef-x to the mix
Reviewed-by: Laura Flores <lflores@redhat.com>
Yuri Weinstein [Tue, 10 Oct 2023 19:00:12 +0000 (12:00 -0700)]
qa/tests: Added upgrade/reef-x to the mix
Signed-off-by: Yuri Weinstein <yweinste@redhat.com>
Yuri Weinstein [Tue, 10 Oct 2023 18:55:24 +0000 (11:55 -0700)]
Merge pull request #53085 from ceph/wip-yuriw-reef-x-main
qa/tests: initial reef-x check in
Reviewed-by: Laura Flores <lflores@redhat.com>
Zack Cerza [Tue, 10 Oct 2023 17:23:20 +0000 (11:23 -0600)]
workunit: Improve assert on client names
Instead of a bare AssertionError, we can mention the problematic value.
Signed-off-by: Zack Cerza <zack@redhat.com>
Adam King [Tue, 10 Oct 2023 16:08:43 +0000 (12:08 -0400)]
Merge pull request #53862 from adk3798/nvmeof-upgrade
mgr/cephadm: fix upgrades with nvmeof
Reviewed-by: Redouane Kachach <rkachach@redhat.com>
Laura Flores [Tue, 10 Oct 2023 15:52:01 +0000 (11:52 -0400)]
Merge pull request #53900 from ljflores/wip-fix-stress-split-tests
qa/suites/upgrade: fix env indentation in stress-split upgrade tests
Zac Dover [Tue, 10 Oct 2023 08:26:53 +0000 (18:26 +1000)]
doc/rados: edit memory-profiling.rst
Edit doc/rados/troubleshooting/memory-profiling.rst.
Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
Matan Breizman [Thu, 31 Aug 2023 09:55:33 +0000 (09:55 +0000)]
qa/tasks/ceph_manager: thrash - add reset_purged_snaps_last
Signed-off-by: Matan Breizman <mbreizma@redhat.com>
Juan Miguel Olmo [Tue, 10 Oct 2023 11:37:01 +0000 (13:37 +0200)]
Merge pull request #50132 from aruniiird/add-rbd-mirror-mon-alerts
ceph-mixin: Add RBD Mirror monitoring alerts
Ilya Dryomov [Tue, 10 Oct 2023 10:31:28 +0000 (12:31 +0200)]
qa/suites/rbd: drop redundant ignorelist entries
CACHE_POOL_NO_HIT_SET is retained in *api_tests*.yaml and
rbd_mirror.yaml snippets for TestLibRBD.ListChildrenTiered and
TestClusterWatcher.CachePools tests.
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
Xuehan Xu [Mon, 21 Aug 2023 08:33:16 +0000 (16:33 +0800)]
crimson/os/seastore: return ghobject_t::max as the end when list_objects
reaches the end of the listing
Signed-off-by: Xuehan Xu <xuxuehan@qianxin.com>
Ilya Dryomov [Sat, 30 Sep 2023 09:39:32 +0000 (11:39 +0200)]
qa/suites/rbd: deduplicate (data) pool facets
With cache tiering facets gone, "pool" facets are strictly about
--data-pool option now. Rename to "data-pool" and create symlinks
to a common directory.
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
Ilya Dryomov [Sat, 30 Sep 2023 11:34:44 +0000 (13:34 +0200)]
qa/suites/rbd: drop cache tiering workload tests
Cache tiering facets have been a constant source of job timeouts
accompanied by "slow request" warnings on the OSDs for at least two
years. Same workloads pass without pool/small-cache-pool.yaml or
thrashers/cache.yaml.
See cache tiering deprecation note added in commit
535b8db33ea0 ("doc:
deprecate the cache tiering").
Fixes: https://tracker.ceph.com/issues/63149
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
Rishabh Dave [Tue, 10 Oct 2023 05:56:35 +0000 (11:26 +0530)]
Merge pull request #53719 from rishabh-d-dave/mon-fscmds
mon/FSCommands: clean up FSCommands
Reviewed-by: Leonid Usov <leonid.usov@ibm.com>
Reviewed-by: Xiubo Li <xiubli@redhat.com>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
Reviewed-by: Laura Flores <lflores@redhat.com>
Xuehan Xu [Tue, 10 Oct 2023 03:47:38 +0000 (11:47 +0800)]
crimson/os/seastore/onode_manager: drop unnecessary status
Signed-off-by: Xuehan Xu <xuxuehan@qianxin.com>
Xuehan Xu [Sat, 7 Oct 2023 06:01:32 +0000 (14:01 +0800)]
crimson/os/seastore/onode_manager: avoid unnecessary delta related
overhead
Signed-off-by: Xuehan Xu <xuxuehan@qianxin.com>
Venky Shankar [Tue, 10 Oct 2023 04:05:37 +0000 (09:35 +0530)]
Merge PR #53885 into main
* refs/pull/53885/head:
Revert "mds: disable delegating inode ranges to clients"
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Yuri Weinstein [Mon, 9 Oct 2023 21:04:54 +0000 (14:04 -0700)]
Merge pull request #53517 from cbodley/wip-qa-distros-s
qa/distros: remove centos/rhel8 and ubuntu20.04 from supported distros
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Ilya Dryomov <idryomov@redhat.com>
Reviewed-by: Ali Maredia <amaredia@redhat.com>
Laura Flores [Mon, 9 Oct 2023 20:24:14 +0000 (20:24 +0000)]
qa/suites/upgrade: fix env indentation in stress-split upgrade tests
This is an issue with the stress-split yaml files, as introduced in https://github.com/ceph/ceph/pull/51889.
The stress-split tests have an incorrectly-intented "env" section, which teuthology detects as an entry for "clients".
Fixes: https://tracker.ceph.com/issues/63158
Signed-off-by: Laura Flores <lflores@ibm.com>
Ilya Dryomov [Mon, 9 Oct 2023 19:38:21 +0000 (21:38 +0200)]
Merge pull request #53829 from ajarr/wip-63009
librbd: kick ExclusiveLock state machine stalled waiting for lock from reacquire_lock()
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
Rishabh Dave [Mon, 9 Oct 2023 17:23:42 +0000 (22:53 +0530)]
Merge pull request #53722 from rishabh-d-dave/mon-authmon
mon/AuthMonitor: clean up AuthMonitor
Reviewed-by: Leonid Usov <leonid.usov@ibm.com>
Reviewed-by: Xiubo Li <xiubli@redhat.com>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
Reviewed-by: Laura Flores <lflores@redhat.com>
Rishabh Dave [Mon, 9 Oct 2023 17:22:44 +0000 (22:52 +0530)]
Merge pull request #53721 from rishabh-d-dave/mon-mdsmon
mon/MDSMonitor: clean up MDSMonitor
Reviewed-by: Leonid Usov <leonid.usov@ibm.com>
Reviewed-by: Xiubo Li <xiubli@redhat.com>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
Reviewed-by: Laura Flores <lflores@redhat.com>
Rishabh Dave [Mon, 9 Oct 2023 17:19:28 +0000 (22:49 +0530)]
Merge pull request #53405 from rishabh-d-dave/ceph-auth-caps-val-caps
mon/AuthMonitor: make "ceph auth caps" print error messsages
Reviewed-by: Xiubo Li <xiubli@redhat.com>
Reviewed-by: Laura Flores <lflores@redhat.com>
Patrick Donnelly [Mon, 9 Oct 2023 17:03:37 +0000 (13:03 -0400)]
Merge PR #53099 into main
* refs/pull/53099/head:
script: update ceph-debug-docker for centos 9.stream
Reviewed-by: Laura Flores <lflores@redhat.com>
Venky Shankar [Mon, 9 Oct 2023 05:06:49 +0000 (10:36 +0530)]
Revert "mds: disable delegating inode ranges to clients"
This isn't necessary -- the MDS handles delegating inode ranges
to clients from its preallocated inode set properly - the suspected
bug involving not persisting the sessionmap and causing asserts
during replay isn't an issue. The preallocated set is persisted
with the log event and the MDS correctly rebuild the set from
this information during replay.
Signed-off-by: Venky Shankar <vshankar@redhat.com>
Patrick Donnelly [Mon, 9 Oct 2023 15:53:31 +0000 (11:53 -0400)]
Merge PR #53206 into main
* refs/pull/53206/head:
mds: use LogSegment dump for debugging
Reviewed-by: Leonid Usov <leonid.usov@ibm.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Yuval Lifshitz [Mon, 9 Oct 2023 14:58:42 +0000 (17:58 +0300)]
Merge pull request #52254 from vedanshbhartia/coverity_uninit
rgw: Add coverity uninitialized variable and initialize RGWBucketEntryMetadataObject
reviewed-by: yuvalif
Yuval Lifshitz [Mon, 9 Oct 2023 14:57:47 +0000 (17:57 +0300)]
Merge pull request #52328 from vedanshbhartia/coverity_1512267
rgw: fix potential null dereference in rgw_iam_policy.c: ParseState::do_string
reviewed-by: yuvalif
Yuval Lifshitz [Mon, 9 Oct 2023 14:56:40 +0000 (17:56 +0300)]
Merge pull request #52472 from vedanshbhartia/coverity_1510724
rgw: Remove unnecessary null check from valid_s3_bucket_name
reviwed-by: soumyakoduri , yuvalif
Yuval Lifshitz [Mon, 9 Oct 2023 14:54:34 +0000 (17:54 +0300)]
Merge pull request #52734 from vedanshbhartia/coverity_ostream
rgw: Restore ostream format state after changing it
reviwed-by: yuvalif
Yuval Lifshitz [Mon, 9 Oct 2023 14:53:15 +0000 (17:53 +0300)]
Merge pull request #52326 from yuvalif/wip-yuval-lua-reload
rgw/lua: support reloading lua packages on all RGWs
reviwed-by: dang, cbodle, anthonyeleven
zdover23 [Mon, 9 Oct 2023 13:53:05 +0000 (23:53 +1000)]
Merge pull request #53890 from zdover23/wip-doc-2023-10-09-troubleshooting-troubleshooting-mon-4-of-x
doc/rados: edit troubleshooting-mon.rst (4 of x)
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Rishabh Dave [Mon, 9 Oct 2023 13:47:07 +0000 (19:17 +0530)]
Merge pull request #53892 from rishabh-d-dave/fix-test_cephfs.py
src/test/pybind: don't use decorator "with_setup"
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Zac Dover [Mon, 9 Oct 2023 08:55:07 +0000 (18:55 +1000)]
doc/rados: edit troubleshooting-mon.rst (4 of x)
Edit doc/rados/troubleshooting/troubleshooting-mon.rst.
Follows https://github.com/ceph/ceph/pull/53875
Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
Daniel Gryniewicz [Mon, 9 Oct 2023 12:57:13 +0000 (08:57 -0400)]
Merge pull request #53884 from leonid-s-usov/rgw-posix-test
test/rgw: don't compile POSIX test unless enabled
Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
Venky Shankar [Mon, 9 Oct 2023 12:19:30 +0000 (17:49 +0530)]
Merge PR #53873 into main
* refs/pull/53873/head:
qa: typo fix when checking for perf counter - s/md_thresh_evicted/mdthresh_evicted
qa: lower mds_session_metadata_threshold for tests
Reviewed-by: Milind Changire <mchangir@redhat.com>
Reviewed-by: Rishabh Dave <ridave@redhat.com>
Reviewed-by: Leonid Usov <leonid.usov@ibm.com>
Rishabh Dave [Mon, 9 Oct 2023 11:28:16 +0000 (16:58 +0530)]
src/test/pybind: don't use decorator "with_setup"
Signed-off-by: Rishabh Dave <ridave@redhat.com>
Venky Shankar [Mon, 9 Oct 2023 04:29:45 +0000 (09:59 +0530)]
qa: typo fix when checking for perf counter - s/md_thresh_evicted/mdthresh_evicted
Signed-off-by: Venky Shankar <vshankar@redhat.com>
Venky Shankar [Sat, 7 Oct 2023 15:12:29 +0000 (20:42 +0530)]
qa: lower mds_session_metadata_threshold for tests
... and increase the number of files that are created so as to
hit the threshold with a high probability.
Fixes: http://tracker.ceph.com/issues/62873
Signed-off-by: Venky Shankar <vshankar@redhat.com>
Nizamudeen A [Mon, 9 Oct 2023 05:11:21 +0000 (10:41 +0530)]
Merge pull request #53817 from cloudbehl/active-alert-filter
mgr/dashboard: Filter active alerts
Reviewed-by: Nizamudeen A <nia@redhat.com>
Leonid Usov [Sun, 8 Oct 2023 14:14:23 +0000 (17:14 +0300)]
test/rgw: don't compile POSIX test unless enabled
Signed-off-by: Leonid Usov <leonid.usov@ibm.com>
Ramana Raja [Mon, 2 Oct 2023 16:39:26 +0000 (12:39 -0400)]
librbd/ManagedLock: kickstart ExclusiveLock state machine
... that is stalled waiting for lock. Do this when trying to reacquire
lock in the ImageWatcher's rewatch mechanism. This would enable the
ExclusiveLock state machine to propagate the blocklist error to the
caller trying to perform an image operation requiring an exclusive
lock.
Previous attempt,
e66db763 , to fix the hang due to exclusive lock
acquisiton (stuck waiting for lock) racing with client blocklisting
did not always work.
e66db763 kickstarted the ExclusiveLock state
machine when the ImageWatcher tried to schedule a exclusive lock
request and the blocklisting was detected. However, there is a short
window between a watch getting deregistered and client blocklisting
getting detected as part of rewatching. If hit when trying to schedule
a lock request, the ExclusiveLock state machine wasn't kickstarted,
blocklist error wasn't propagated, and the hang resurfaced.
A more robust approach is taken to resume the ExclusiveLock state
machine stuck waiting for lock during client blocklisting. Whenever
a client's ImageWatcher loses connection to the cluster, as it happens
during blocklising, the ImageWatcher initiates a mechanism to rewatch
the image and tries to reacquire the lock. Piggyback on this rewatch
mechanism that gets triggered during client blocklisting. And when
trying to reacquire the lock, kickstart the ExclusiveLock state
machine stalled waiting for lock (STATE_WAITING_FOR_LOCK).
Fixes: https://tracker.ceph.com/issues/63009
Signed-off-by: Ramana Raja <rraja@redhat.com>
Xuehan Xu [Wed, 27 Sep 2023 09:15:29 +0000 (17:15 +0800)]
crimson/os/seastore/onode_manager: drop write_dirty
Signed-off-by: Xuehan Xu <xuxuehan@qianxin.com>
Xuehan Xu [Wed, 27 Sep 2023 09:13:44 +0000 (17:13 +0800)]
crimson/os/seastore/onode_manager: populate delta recorders for each
onode modification
Signed-off-by: Xuehan Xu <xuxuehan@qianxin.com>
zdover23 [Sun, 8 Oct 2023 05:10:20 +0000 (16:10 +1100)]
Merge pull request #53874 from zdover23/wip-doc-2023-10-07-rados-troubleshooting-community
doc/rados: edit troubleshooting/community.rst
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
zdover23 [Sun, 8 Oct 2023 04:50:45 +0000 (15:50 +1100)]
Merge pull request #53875 from zdover23/wip-doc-2023-10-07-troubleshooting-troubleshooting-mon-3-of-x
doc/rados: edit troubleshooting-mon.rst (3 of x)
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Zac Dover [Sat, 7 Oct 2023 20:39:23 +0000 (06:39 +1000)]
doc/rados: edit troubleshooting/community.rst
Edit doc/rados/troubleshooting/community.rst.
Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
Zac Dover [Sat, 7 Oct 2023 21:33:17 +0000 (07:33 +1000)]
doc/rados: edit troubleshooting-mon.rst (3 of x)
Edit doc/rados/troubleshooting/troubleshooting-mon.rst.
Follows https://github.com/ceph/ceph/pull/52827
Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
Anthony D'Atri [Sun, 8 Oct 2023 00:45:38 +0000 (20:45 -0400)]
Merge pull request #53876 from zdover23/wip-doc-2023-10-08-architecture-rbd-sentence-repair
doc/architecture: repair RBD sentence
Zac Dover [Sat, 7 Oct 2023 21:43:43 +0000 (07:43 +1000)]
doc/architecture: repair RBD sentence
Improve an ambiguous sentence in doc/architecture.rst.
The problem presented by the original sentence is that the phrasal verb
"to provide with" is implicated in one of its possible readings.
Interpreted in that way, the sentence seems to express the incorrect
idea that RBD furnishes block devices with snapshotting and cloning, as
though snapshotting and cloning are being delivered to the block
devices. In fact, snapshotting and cloning are just features of RBD, and
are features that are described on this page:
https://docs.ceph.com/en/quincy/rbd/rbd-snapshot/.
Signed-off-by: Zac Dover <zac.dover@proton.me>
zdover23 [Sat, 7 Oct 2023 04:51:27 +0000 (15:51 +1100)]
Merge pull request #53790 from zdover23/wip-doc-2023-10-03-architecture-17-of-x
doc/architecture: edit "Peering and Sets"
Zac Dover [Tue, 3 Oct 2023 12:11:50 +0000 (22:11 +1000)]
doc/architecture: edit "Peering and Sets"
Edit the English in the section "Peering and Sets" in the file
doc/architecture.rst.
Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
Patrick Donnelly [Sat, 7 Oct 2023 00:15:23 +0000 (20:15 -0400)]
Merge PR #53855 into main
* refs/pull/53855/head:
script: add option for debug build
Reviewed-by: Ilya Dryomov <idryomov@redhat.com>
Patrick Donnelly [Fri, 6 Oct 2023 00:11:29 +0000 (20:11 -0400)]
script: add option for debug build
See: https://github.com/ceph/ceph-build/pull/2167
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
Adam King [Fri, 6 Oct 2023 15:20:57 +0000 (11:20 -0400)]
mgr/cephadm: fix upgrades with nvmeof
Currently, nvmeof was being treated as if it used
a ceph image during upgrades. This would cause logging
of messages like (I've removed the nvmeof daemon id)
log [WRN] : Upgrade daemon: nvmeof.<id>: Cannot redeploy
nvmeof.<id> with a new image: Supported types are: mgr, mon,
crash, osd, mds, rgw, rbd-mirror, cephfs-mirror, ceph-exporter,
iscsi, nfs
and if you had set a custom image for the
mgr/cephadm/container_image_nvmeof setting, this would
be undone as part of the upgrade process.
Fixes: https://tracker.ceph.com/issues/63127
Signed-off-by: Adam King <adking@redhat.com>
Yuri Weinstein [Fri, 6 Oct 2023 13:58:11 +0000 (06:58 -0700)]
Merge pull request #53417 from jrchyang/fix_mclock_scheduling_slow_main
osd: fix: slow scheduling when item_cost is large
Reviewed-by: Sridhar Seshasayee <sseshasa@redhat.com>
Yuval Lifshitz [Fri, 6 Oct 2023 10:07:31 +0000 (13:07 +0300)]
Merge pull request #52430 from vedanshbhartia/coverity_datarace
rgw: Add coverity annotations for missing mutex locks
reviewed-by: yuvalif, mkogan1
Yuval Lifshitz [Wed, 5 Jul 2023 18:33:55 +0000 (18:33 +0000)]
rgw/lua/doc: support reloading lua packages on all RGWs
without requiring a restart of the RGWs
test instructions:
https://gist.github.com/yuvalif/
95b8ed9ea73ab4591c59644a050e01e2
also use capitalized "Lua" in logs/doc
Signed-off-by: Yuval Lifshitz <ylifshit@ibm.com>
Rishabh Dave [Thu, 28 Sep 2023 17:34:51 +0000 (23:04 +0530)]
mon/AuthMonitor: check if entity is absent before creating it
Although this code path is not used for creating entities yet, it is
better to fix the bug sooner than later. Method
AuthMonitor::_update_or_create_entity() must exit (with appropriate
error code) when entity to be created on the Ceph cluster is already
present.
Signed-off-by: Rishabh Dave <ridave@redhat.com>
Rishabh Dave [Thu, 28 Sep 2023 14:29:24 +0000 (19:59 +0530)]
mds/MDSAuthCaps: re-word an error message for better clarity
Signed-off-by: Rishabh Dave <ridave@redhat.com>
zdover23 [Thu, 5 Oct 2023 23:21:14 +0000 (10:21 +1100)]
Merge pull request #53834 from dparmar18/remove-egg-fragment-from-doc
doc: remove egg fragment from dev/developer_guide/running-tests-locally
Reviewed-by: John Mulligan <jmulligan@redhat.com>
Reviewed-by: Rishabh Dave <ridave@redhat.com>
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Reviewed-by: Zac Dover <zac.dover@proton.me>
Casey Bodley [Thu, 5 Oct 2023 15:59:52 +0000 (11:59 -0400)]
rgw: fix http error checks in keystone/barbican/vault clients
when RGWHTTPManager encounters an http error, it uses
rgw_http_error_to_errno() to map that to a negative posix error code.
RGWHTTPClient::process() returns that mapped error code, and exposes the
original http error via get_http_status()
the http client code for keystone, barbican, and vault were returning
early on the errors from process(), so weren't getting to the http error
checks
these clients now check for specific http errors before testing the
result of process()
Fixes: https://tracker.ceph.com/issues/62989
Signed-off-by: Casey Bodley <cbodley@redhat.com>
Adam King [Thu, 5 Oct 2023 15:43:53 +0000 (11:43 -0400)]
Merge pull request #52296 from asm0deuz/bz2153448_ipv6
mgr/cephadm: ceph orch add fails when ipv6 address is surrounded by square brackets.
Reviewed-by: Adam King <adking@redhat.com>
Adam King [Thu, 5 Oct 2023 15:41:47 +0000 (11:41 -0400)]
Merge pull request #53621 from phlogistonjohn/jjm-cephadm-dtypes-common
cephadm: introduce Daemon Forms
Reviewed-by: Adam King <adking@redhat.com>
Venky Shankar [Thu, 5 Oct 2023 15:28:33 +0000 (20:58 +0530)]
Merge PR #53836 into main
* refs/pull/53836/head:
PendingReleaseNotes: add a note about disallowing delegating inodes
qa: start testing mds_client_delegate_inos_pct config
mds: disable delegating inode ranges to clients
Reviewed-by: Milind Changire <mchangir@redhat.com>
Reviewed-by: Dhairya Parmar <dparmar@redhat.com>
Dhairya Parmar [Thu, 5 Oct 2023 08:12:31 +0000 (13:42 +0530)]
doc: remove egg fragment from dev/developer_guide/running-tests-locally
DEPRECATION: git+https://github.com/ceph/teuthology#egg=teuthology
[test] contains an egg fragment with a non-PEP 508 name pip 25.0 will enforce
this behaviour change. A possible replacement is to use the req @ url syntax,
and remove the egg fragment. Discussion can be found at
https://github.com/pypa/pip/issues/11617
Signed-off-by: Dhairya Parmar <dparmar@redhat.com>
Rishabh Dave [Wed, 4 Oct 2023 18:52:51 +0000 (00:22 +0530)]
src/MDSMonitor: make use of imported namespace symbols
Symbols imported into current namespace should be used directly; there
is no need to mention their parent namespace while using them. IOW, to use
"std::string" after it has been imported, just write "string" instead of
"std::string".
Signed-off-by: Rishabh Dave <ridave@redhat.com>
Rishabh Dave [Thu, 28 Sep 2023 18:05:22 +0000 (23:35 +0530)]
mon/MDSMonitor: remove unused namespace imports
Remove symbols imported into the current namespace since they are not being
used.
Signed-off-by: Rishabh Dave <ridave@redhat.com>
Rishabh Dave [Wed, 4 Oct 2023 18:08:47 +0000 (23:38 +0530)]
mon/FSCommands: import std::ostream into current namespace
Signed-off-by: Rishabh Dave <ridave@redhat.com>
Yuval Lifshitz [Tue, 4 Jul 2023 16:27:38 +0000 (16:27 +0000)]
rgw/lua: install lua packages in temp directory
and switch to it only once installation is done.
this is needed for cases where installation can happen
while RGW is running
Signed-off-by: Yuval Lifshitz <ylifshit@ibm.com>
Yuval Lifshitz [Tue, 4 Jul 2023 15:38:04 +0000 (15:38 +0000)]
rgw/lua/doc: fix luajson example
Signed-off-by: Yuval Lifshitz <ylifshit@ibm.com>
Rishabh Dave [Wed, 4 Oct 2023 18:16:32 +0000 (23:46 +0530)]
mon/FSCommands: make use of imported namespace symbols
There's no need to mention the "home" namespace of a symbol while using
it after it has been imported into the current namespace. IOW, no need to
write, for example, "std::string" after it has been imported from its
namespace; instead simply writing "string" will suffice.
Signed-off-by: Rishabh Dave <ridave@redhat.com>
Rishabh Dave [Thu, 28 Sep 2023 17:10:19 +0000 (22:40 +0530)]
mon/FSCommands: remove unused namespace imports
When symbols imported into the current namespace won't be used, don't
import them.
Signed-off-by: Rishabh Dave <ridave@redhat.com>
Rishabh Dave [Wed, 4 Oct 2023 18:22:27 +0000 (23:52 +0530)]
mon/AuthMonitor: make use of imported namespace symbols
Once a symbol has been imported into the current namespace, no need to
mention the original namespace while using it. IOW, no need to write
"std::string" after it has been imported from the namespace "std" into the
current namespace.
Signed-off-by: Rishabh Dave <ridave@redhat.com>
Rishabh Dave [Thu, 28 Sep 2023 18:14:09 +0000 (23:44 +0530)]
mon/AuthMonitor: remove unused namespace imports
Don't import items into current namespace when they'll be never used.
Signed-off-by: Rishabh Dave <ridave@redhat.com>
Nizamudeen A [Thu, 5 Oct 2023 14:10:32 +0000 (19:40 +0530)]
Merge pull request #53700 from cloudbehl/cephfs-snapshot
mgr/dashboard: Fixed cephfs snapshot listing in directories
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Adam King [Thu, 5 Oct 2023 12:37:56 +0000 (08:37 -0400)]
Merge pull request #53782 from sachinpunadikar/vstart-fix
vstart: exclude default route during cluster setup
Reviewed-by: Adam King <adking@redhat.com>
cloudbehl [Wed, 4 Oct 2023 11:05:26 +0000 (16:35 +0530)]
mgr/dashboard: Filter active alerts
- List alerts which are not suppressed
fixes: https://tracker.ceph.com/issues/62990
Signed-off-by: cloudbehl <cloudbehl@gmail.com>
zdover23 [Thu, 5 Oct 2023 11:43:02 +0000 (22:43 +1100)]
Merge pull request #53819 from zdover23/wip-doc-2023-10-04-rados-troubleshooting-index
doc/rados: edit troubleshooting.rst
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Venky Shankar [Thu, 5 Oct 2023 11:24:04 +0000 (16:54 +0530)]
PendingReleaseNotes: add a note about disallowing delegating inodes
Signed-off-by: Venky Shankar <vshankar@redhat.com>
Venky Shankar [Wed, 4 Oct 2023 14:20:12 +0000 (19:50 +0530)]
qa: start testing mds_client_delegate_inos_pct config
Signed-off-by: Venky Shankar <vshankar@redhat.com>
Venky Shankar [Thu, 5 Oct 2023 09:26:32 +0000 (14:56 +0530)]
mds: disable delegating inode ranges to clients
Fixes: http://tracker.ceph.com/issues/63103
Signed-off-by: Venky Shankar <vshankar@redhat.com>
Yuval Lifshitz [Thu, 5 Oct 2023 07:50:21 +0000 (10:50 +0300)]
Merge pull request #52735 from vedanshbhartia/coverity_minlong
rgw: Add coverity annotation for warning about tautological comparison
reviewed-by: thotz, yuvalif