]> git.apps.os.sepia.ceph.com Git - ceph.git/log
ceph.git
3 years agorun-make-check: fix do_cmake not consuming run-make-check opts 42842/head
Deepika Upadhyay [Thu, 19 Aug 2021 09:00:33 +0000 (14:30 +0530)]
run-make-check: fix do_cmake not consuming run-make-check opts

run-make-check.sh uses run-make.sh to `prepare`(install dependencies)
and `configure` cmake options, without quotes these options containing
special characters(hypens mostly) are skipped, hence we see not all
options supplied at cmake configure step.

Resolves(focused to solve issues in jenkins build env):
 - missing cmake options:
    cmake_opts+=" -DCMAKE_CXX_COMPILER=$cxx_compiler -DCMAKE_C_COMPILER=$c_compiler"
    cmake_opts+=" -DCMAKE_CXX_FLAGS_DEBUG=\-Werror"
 - Ninja not being used as cmake generator

Signed-off-by: Deepika Upadhyay <dupadhya@redhat.com>
3 years agoMerge pull request #42340 from mkogan1/wip-d3n-docs
Casey Bodley [Mon, 16 Aug 2021 20:11:33 +0000 (16:11 -0400)]
Merge pull request #42340 from mkogan1/wip-d3n-docs

doc/radosgw/d3n: add user docs

Reviewed-by: Casey Bodley <cbodley@redhat.com>
Reviewed-by: Matt Benjamin <mbenjamin@redhat.com>
3 years agodoc/radosgw/d3n: add user docs 42340/head
Mark Kogan [Wed, 14 Jul 2021 16:37:16 +0000 (19:37 +0300)]
doc/radosgw/d3n: add user docs

(high-level feature description, setup instructions, config options)
Fixes: https://tracker.ceph.com/issues/51409
Signed-off-by: Mark Kogan <mkogan@redhat.com>
3 years agoMerge pull request #42790 from ronen-fr/wip-ronenf-std-fix
Kefu Chai [Mon, 16 Aug 2021 15:05:41 +0000 (23:05 +0800)]
Merge pull request #42790 from ronen-fr/wip-ronenf-std-fix

key_value_store: fix missing std

Reviewed-by: Kefu Chai <kchai@redhat.com>
3 years agoMerge pull request #42795 from tchaikov/wip-cmake-quiet
Kefu Chai [Mon, 16 Aug 2021 14:38:58 +0000 (22:38 +0800)]
Merge pull request #42795 from tchaikov/wip-cmake-quiet

cmake: silence build output when building external deps

Reviewed-by: Deepika Upadhyay <dupadhya@redhat.com>
3 years agocmake: do not quote string 42795/head
Kefu Chai [Mon, 16 Aug 2021 13:02:06 +0000 (21:02 +0800)]
cmake: do not quote string

otherwise we have

CMake Error at /home/jenkins-build/build/workspace/ceph-pull-requests/build/spdk-ext-prefix/src/spdk-ext-stamp/spdk-ext-build-.cmake:37 (message):
  Command failed: 2

   'env' '-i' 'PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin' 'CC=/usr/bin/clang-10' '/usr/bin/make' 'EXTRA_CFLAGS=' '-fPIC' '-Wno-address-of-packed-member""'

Signed-off-by: Kefu Chai <kchai@redhat.com>
3 years agocmake: silence build output when building external deps
Kefu Chai [Mon, 16 Aug 2021 10:42:18 +0000 (18:42 +0800)]
cmake: silence build output when building external deps

when download/building grafonnet-lib, dpdk, spdk, liburing and fio,
they dump lots of output during configuration and building phrases,
all of which is irrelevant to us. so let's just silence it.

Signed-off-by: Kefu Chai <kchai@redhat.com>
3 years agoMerge pull request #42784 from tchaikov/wip-rgw_dencoder
Kefu Chai [Mon, 16 Aug 2021 13:12:05 +0000 (21:12 +0800)]
Merge pull request #42784 from tchaikov/wip-rgw_dencoder

rgw/rgw_dencoder: set identity_type when creating samples

Reviewed-by: Casey Bodley <cbodley@redhat.com>
3 years agokey_value_store: fix missing std 42790/head
Ronen Friedman [Mon, 16 Aug 2021 11:28:28 +0000 (11:28 +0000)]
key_value_store: fix missing std

following PR #42742

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
3 years agoMerge pull request #42785 from tchaikov/wip-no-warnings
Kefu Chai [Mon, 16 Aug 2021 13:08:33 +0000 (21:08 +0800)]
Merge pull request #42785 from tchaikov/wip-no-warnings

run-make-check: pass -Werror when compiling C++ code and a couple cleanups

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Reviewed-by: Casey Bodley <cbodley@redhat.com>
3 years agoMerge pull request #42714 from ronen-fr/wip-ronenf-last-update
Kefu Chai [Mon, 16 Aug 2021 12:20:12 +0000 (20:20 +0800)]
Merge pull request #42714 from ronen-fr/wip-ronenf-last-update

osd/scrub: only telling the scrubber of 'updates' events if these eve…

Reviewed-by: Samuel Just <sjust@redhat.com>
3 years agoMerge pull request #42754 from aclamk/wip-aclamk-bluefs-improve-allocation-check
Kefu Chai [Mon, 16 Aug 2021 12:18:02 +0000 (20:18 +0800)]
Merge pull request #42754 from aclamk/wip-aclamk-bluefs-improve-allocation-check

os/bluestore/bluefs: Cleanup allocation consistency check code

Reviewed-by: Igor Fedotov <ifedotov@suse.com>
3 years agorun-make-check: pass -Werror when compiling C++ code 42785/head
Kefu Chai [Mon, 16 Aug 2021 09:36:30 +0000 (17:36 +0800)]
run-make-check: pass -Werror when compiling C++ code

to raise the bar so we can identify potential issues earlier.

Signed-off-by: Kefu Chai <kchai@redhat.com>
3 years agocmake: use -Wno-unused-but-set-variable when compiling SPDK if supported
Kefu Chai [Mon, 16 Aug 2021 09:32:33 +0000 (17:32 +0800)]
cmake: use -Wno-unused-but-set-variable when compiling SPDK if supported

to silence warnings like:

In file included from nvme_tcp.c:52:
/home/jenkins-build/build/workspace/ceph-pull-requests/src/spdk/include/spdk_internal/nvme_tcp.h:369:17: warning: variable 'plen' set but not used [-Wunused-but-set-variable]
        uint32_t hlen, plen;
                       ^

Signed-off-by: Kefu Chai <kchai@redhat.com>
3 years agoMerge pull request #42580 from hualongfeng/solve_competition_between_read_and_retire
Ilya Dryomov [Mon, 16 Aug 2021 09:30:01 +0000 (11:30 +0200)]
Merge pull request #42580 from hualongfeng/solve_competition_between_read_and_retire

librbd/cache/pwl/ssd: solve competition between read and retire

Reviewed-by: Mahati Chamarthy <mahati.chamarthy@intel.com>
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
3 years agocmake: use string(APPEND ..) to append to string
Kefu Chai [Mon, 16 Aug 2021 09:29:35 +0000 (17:29 +0800)]
cmake: use string(APPEND ..) to append to string

more readable and less repeating this way.

Signed-off-by: Kefu Chai <kchai@redhat.com>
3 years agorgw/rgw_rest: do not set unused variable
Kefu Chai [Mon, 16 Aug 2021 09:26:09 +0000 (17:26 +0800)]
rgw/rgw_rest: do not set unused variable

`len` is used to track the total length of received data, but we already
collect the data in `bl`, so we can always check `bl` for the total
length. this change also silences following warning from Clang:

../src/rgw/rgw_rest.cc:1477:21: warning: variable 'len' set but not used [-Wunused-but-set-variable]
  int read_len = 0, len = 0;
                    ^
1 warning generated.

Signed-off-by: Kefu Chai <kchai@redhat.com>
3 years agoos/bluestore/BlueStore: make maybe unused variable [[maybe_unused]]
Kefu Chai [Mon, 16 Aug 2021 09:17:48 +0000 (17:17 +0800)]
os/bluestore/BlueStore: make maybe unused variable [[maybe_unused]]

cct is defined so it can be used by dout(), but when the source code is
compiled for crimson, dout() does not use cct at all, so in that case,
compiler complains like:

../src/os/bluestore/BlueStore.cc:17413:8: warning: unused variable 'cct' [-Wunused-variable]
  auto cct  = onode->c->store->cct;
       ^
1 warning generated.

in this change, cct is marked with [[maybe_unused]] to silence this
warning.

Signed-off-by: Kefu Chai <kchai@redhat.com>
3 years agoMerge pull request #42777 from tchaikov/wip-clang-build
Kefu Chai [Mon, 16 Aug 2021 08:59:09 +0000 (16:59 +0800)]
Merge pull request #42777 from tchaikov/wip-clang-build

run-make-check,cmake: use clang in run-make-check.sh

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
3 years agorgw/rgw_json_enc: dump rgw_log_entry::identity_type 42784/head
Kefu Chai [Mon, 16 Aug 2021 08:23:26 +0000 (16:23 +0800)]
rgw/rgw_json_enc: dump rgw_log_entry::identity_type

should dump it for better debugging experience

Signed-off-by: Kefu Chai <kchai@redhat.com>
3 years agorgw/rgw_json_enc: dump obj using dump_stream()
Kefu Chai [Mon, 16 Aug 2021 08:21:42 +0000 (16:21 +0800)]
rgw/rgw_json_enc: dump obj using dump_stream()

use dump_stream() instead of dump_string() for dumping stringify object.

more readably this way.

Signed-off-by: Kefu Chai <kchai@redhat.com>
3 years agorgw/rgw_dencoder: set identity_type when creating samples
Kefu Chai [Mon, 16 Aug 2021 08:01:42 +0000 (16:01 +0800)]
rgw/rgw_dencoder: set identity_type when creating samples

otherwise identity_type is a random number on stack. and there is good
chance that it does not match with the one decoded from the encoded
blob.

this change should address the failures like:

**** rgw_log_entry test 2 binary reencode check failed ****
   ceph-dencoder type rgw_log_entry select_test 2 encode export /tmp/typ-O8hVYK2Gb
   ceph-dencoder type rgw_log_entry select_test 2 encode decode encode export /tmp/typ-G09itHHIC
   cmp /tmp/typ-O8hVYK2Gb /tmp/typ-G09itHHIC

The following tests FAILED:
132 - check-generated.sh (Failed)
..

Fixes: https://tracker.ceph.com/issues/52278
Signed-off-by: Kefu Chai <kchai@redhat.com>
3 years agotest/crimson: disable logging for unittest-*fltree* 42777/head
Kefu Chai [Sat, 14 Aug 2021 12:28:07 +0000 (20:28 +0800)]
test/crimson: disable logging for unittest-*fltree*

these two tests are very chatty, just silence it. we can always re-enable the
logging, if something goes wrong with any of them.

Signed-off-by: Kefu Chai <kchai@redhat.com>
3 years agocmake: pass -Wunused-but-set-variable when building dpdk
Kefu Chai [Sun, 15 Aug 2021 08:31:02 +0000 (16:31 +0800)]
cmake: pass -Wunused-but-set-variable when building dpdk

otherwise we have:

src/spdk/dpdk/lib/librte_eal/linux/eal.c:591:11: error: variable 'total_mem' set but not used [-Werror,-Wunused-but-set-variable]
        uint64_t total_mem = 0;
                 ^
1 error generated.

when building dpdk with Clang. dpdk passes -Werror to compiler, so
we have to disable this option.

Signed-off-by: Kefu Chai <kchai@redhat.com>
3 years agocmake/modules/BuildFIO: use ceph fork
Kefu Chai [Sat, 14 Aug 2021 01:47:36 +0000 (09:47 +0800)]
cmake/modules/BuildFIO: use ceph fork

to pick up the clang build fix. we should use the upstream repo, once the
clang build fix gets merged.

bumping up the fio helps to address following error, as this part was rewritten:

src/test/fio/CMakeFiles/fio_ceph_objectstore.dir/fio_ceph_objectstore.cc.o.d -o src/test/fio/CMakeFiles/fio_ceph_objectstore.dir/fio_ceph_objectstore.cc.o -c ../src/test/fio/fio_ceph_objectstore.cc
In file included from ../src/test/fio/fio_ceph_objectstore.cc:26:
In file included from src/fio/fio.h:18:
In file included from src/fio/thread_options.h:6:
In file included from src/fio/options.h:8:
src/fio/parse.h:128:13: error: arithmetic on a pointer to void
        return ret + offset;
               ~~~ ^
1 error generated.

Signed-off-by: Kefu Chai <kchai@redhat.com>
3 years agobuild: switch the make check bot to Clang.
Radoslaw Zarzynski [Mon, 2 Aug 2021 19:26:00 +0000 (19:26 +0000)]
build: switch the make check bot to Clang.

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
3 years agoMerge pull request #42781 from cyx1231st/wip-seastore-disable-test-intr-future
Kefu Chai [Mon, 16 Aug 2021 06:21:58 +0000 (14:21 +0800)]
Merge pull request #42781 from cyx1231st/wip-seastore-disable-test-intr-future

crimson/onode-staged-tree: force test to work with invalidated transactions

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
3 years agocrimson/onode-staged-tree: force test work with invalidated transactions 42781/head
Yingxin Cheng [Mon, 16 Aug 2021 02:33:32 +0000 (10:33 +0800)]
crimson/onode-staged-tree: force test work with invalidated transactions

is_then() is failed to interrupt the continuation chain and cause
unit test failure. So add a workaround to make the test pass again.

Fixes: https://tracker.ceph.com/issues/52259
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
3 years agoMerge pull request #42778 from tchaikov/wip-crimson-cleanup
Kefu Chai [Mon, 16 Aug 2021 03:10:00 +0000 (11:10 +0800)]
Merge pull request #42778 from tchaikov/wip-crimson-cleanup

crimson/os/seastore: do not capture unused variable

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
3 years agoMerge pull request #42776 from tchaikov/wip-freebsd
Kefu Chai [Sat, 14 Aug 2021 10:28:37 +0000 (18:28 +0800)]
Merge pull request #42776 from tchaikov/wip-freebsd

msg/async: build without "using namespace std"

Reviewed-by: Willem Jan Withagen <wjw@digiware.nl>
3 years agotest: s/INSTANTIATE_TEST_CASE_P/INSTANTIATE_TEST_SUITE_P/ 42778/head
Kefu Chai [Sat, 14 Aug 2021 02:25:25 +0000 (10:25 +0800)]
test: s/INSTANTIATE_TEST_CASE_P/INSTANTIATE_TEST_SUITE_P/

to silence warnings like:

../src/test/osd/TestOSDMap.cc:2076:1: warning: 'InstantiateTestCase_P_IsDeprecated' is deprecated: INSTANTIATE_TEST_CASE_P is deprecated, please use INSTANTIATE_TEST_SUITE_P
[-Wdeprecated-declarations]
INSTANTIATE_TEST_CASE_P(
^
../src/googletest/googletest/include/gtest/gtest-param-test.h:505:38: note: expanded from macro 'INSTANTIATE_TEST_CASE_P'
  static_assert(::testing::internal::InstantiateTestCase_P_IsDeprecated(), \
                                     ^
../src/googletest/googletest/include/gtest/internal/gtest-internal.h:1298:1: note: 'InstantiateTestCase_P_IsDeprecated' has been explicitly marked deprecated here
GTEST_INTERNAL_DEPRECATED(
^
../src/googletest/googletest/include/gtest/internal/gtest-port.h:2249:59: note: expanded from macro 'GTEST_INTERNAL_DEPRECATED'
 #define GTEST_INTERNAL_DEPRECATED(message) __attribute__((deprecated(message)))
                                                          ^
1 warning generated.

Signed-off-by: Kefu Chai <kchai@redhat.com>
3 years agocrimson/os/seastore: do not capture unused variable
Kefu Chai [Sat, 14 Aug 2021 01:58:29 +0000 (09:58 +0800)]
crimson/os/seastore: do not capture unused variable

Signed-off-by: Kefu Chai <kchai@redhat.com>
3 years agoMerge pull request #42744 from wjwithagen/wjw-fix-varlength-init
Kefu Chai [Sat, 14 Aug 2021 02:28:52 +0000 (10:28 +0800)]
Merge pull request #42744 from wjwithagen/wjw-fix-varlength-init

rgw/store: Do not init var-length arrays

Reviewed-by: Soumya Koduri <skoduri@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
3 years agomsg/async: build without "using namespace std" 42776/head
Kefu Chai [Sat, 14 Aug 2021 01:40:35 +0000 (09:40 +0800)]
msg/async: build without "using namespace std"

* add "std::" prefix in headers

Signed-off-by: Kefu Chai <kchai@redhat.com>
3 years agoMerge pull request #42730 from tchaikov/wip-cmake-build-type
Kefu Chai [Fri, 13 Aug 2021 16:14:12 +0000 (00:14 +0800)]
Merge pull request #42730 from tchaikov/wip-cmake-build-type

cmake: set CMAKE_BUILD_TYPE only if it is not specified

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
Reviewed-by: Mark Nelson <mnelson@redhat.com>
3 years agoMerge pull request #42742 from tchaikov/wip-no-using-namespace-std
Kefu Chai [Fri, 13 Aug 2021 16:12:06 +0000 (00:12 +0800)]
Merge pull request #42742 from tchaikov/wip-no-using-namespace-std

src: build without "using namespace std"

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Reviewed-by: Casey Bodley <cbodley@redhat.com>
Reviewed-by: Adam C. Emerson <aemerson@redhat.com>
3 years agoinclude/object.h: do not "using namespace std" 42742/head
Kefu Chai [Mon, 9 Aug 2021 07:54:22 +0000 (15:54 +0800)]
include/object.h: do not "using namespace std"

so the identifiers in "std" namespace do not conflict the ones in C code
or the idenfitiers in other namespaces.

Signed-off-by: Kefu Chai <kchai@redhat.com>
3 years agodokan: : build without "using namespace std"
Kefu Chai [Fri, 13 Aug 2021 05:24:58 +0000 (13:24 +0800)]
dokan: : build without "using namespace std"

* add "using" declarations in .cc files.

so we don't rely on "using namespace std" in one or more included
headers.

Signed-off-by: Kefu Chai <kchai@redhat.com>
3 years agojava: build without "using namespace std"
Kefu Chai [Thu, 12 Aug 2021 14:42:47 +0000 (22:42 +0800)]
java: build without "using namespace std"

* add "using" declarations in .cc files.

so we don't rely on "using namespace std" in one or more included
headers.

Signed-off-by: Kefu Chai <kchai@redhat.com>
3 years agotools/cephfs: build without "using namespace std"
Kefu Chai [Wed, 11 Aug 2021 10:44:08 +0000 (18:44 +0800)]
tools/cephfs: build without "using namespace std"

* add "std::" prefix in headers
* add "using" declarations in .cc files.

so we don't rely on "using namespace std" in one or more included
headers.

Signed-off-by: Kefu Chai <kchai@redhat.com>
3 years agotools/rbd_nbd: build without "using namespace std"
Kefu Chai [Wed, 11 Aug 2021 10:42:52 +0000 (18:42 +0800)]
tools/rbd_nbd: build without "using namespace std"

* add "std::" prefix in headers
* add "using" declarations in .cc files.

so we don't rely on "using namespace std" in one or more included
headers.

Signed-off-by: Kefu Chai <kchai@redhat.com>
3 years agomount.ceph: build without "using namespace std"
Kefu Chai [Wed, 11 Aug 2021 10:41:28 +0000 (18:41 +0800)]
mount.ceph: build without "using namespace std"

* add "std::" prefix in headers
* add "using" declarations in .cc files.

so we don't rely on "using namespace std" in one or more included
headers.

Signed-off-by: Kefu Chai <kchai@redhat.com>
3 years agocrimson/tools: build without "using namespace std"
Kefu Chai [Wed, 11 Aug 2021 10:24:34 +0000 (18:24 +0800)]
crimson/tools: build without "using namespace std"

* add "std::" prefix in headers
* add "using" declarations in .cc files.

so we don't rely on "using namespace std" in one or more included
headers.

Signed-off-by: Kefu Chai <kchai@redhat.com>
3 years agotools/erasure-code: build without "using namespace std"
Kefu Chai [Wed, 11 Aug 2021 10:22:40 +0000 (18:22 +0800)]
tools/erasure-code: build without "using namespace std"

* add "std::" prefix in headers
* add "using" declarations in .cc files.

so we don't rely on "using namespace std" in one or more included
headers.

Signed-off-by: Kefu Chai <kchai@redhat.com>
3 years agocephfs-mirror: build without "using namespace std"
Kefu Chai [Wed, 11 Aug 2021 09:57:00 +0000 (17:57 +0800)]
cephfs-mirror: build without "using namespace std"

* add "std::" prefix in headers
* add "using" declarations in .cc files.

so we don't rely on "using namespace std" in one or more included
headers.

Signed-off-by: Kefu Chai <kchai@redhat.com>
3 years agoclient: build without "using namespace std"
Kefu Chai [Wed, 11 Aug 2021 08:00:32 +0000 (16:00 +0800)]
client: build without "using namespace std"

* add "std::" prefix in headers
* add "using" declarations in .cc files.

so we don't rely on "using namespace std" in one or more included
headers.

Signed-off-by: Kefu Chai <kchai@redhat.com>
3 years agoceph_fuse: build without "using namespace std"
Kefu Chai [Wed, 11 Aug 2021 07:55:39 +0000 (15:55 +0800)]
ceph_fuse: build without "using namespace std"

* add "std::" prefix in headers
* add "using" declarations in .cc files.

so we don't rely on "using namespace std" in one or more included
headers.

Signed-off-by: Kefu Chai <kchai@redhat.com>
3 years agokrbd: build without "using namespace std"
Kefu Chai [Wed, 11 Aug 2021 04:03:26 +0000 (12:03 +0800)]
krbd: build without "using namespace std"

* add "std::" prefix in headers
* add "using" declarations in .cc files.

so we don't rely on "using namespace std" in one or more included
headers.

Signed-off-by: Kefu Chai <kchai@redhat.com>
3 years agocrush: build without "using namespace std"
Kefu Chai [Wed, 11 Aug 2021 04:02:57 +0000 (12:02 +0800)]
crush: build without "using namespace std"

* add "std::" prefix in headers
* add "using" declarations in .cc files.

so we don't rely on "using namespace std" in one or more included
headers.

Signed-off-by: Kefu Chai <kchai@redhat.com>
3 years agocompressor: build without "using namespace std"
Kefu Chai [Wed, 11 Aug 2021 04:02:35 +0000 (12:02 +0800)]
compressor: build without "using namespace std"

* add "std::" prefix in headers
* add "using" declarations in .cc files.

so we don't rely on "using namespace std" in one or more included
headers.

Signed-off-by: Kefu Chai <kchai@redhat.com>
3 years agoauth: build without "using namespace std"
Kefu Chai [Wed, 11 Aug 2021 04:02:08 +0000 (12:02 +0800)]
auth: build without "using namespace std"

* add "std::" prefix in headers
* add "using" declarations in .cc files.

so we don't rely on "using namespace std" in one or more included
headers.

Signed-off-by: Kefu Chai <kchai@redhat.com>
3 years agokv: build without "using namespace std"
Kefu Chai [Wed, 11 Aug 2021 04:01:50 +0000 (12:01 +0800)]
kv: build without "using namespace std"

* add "std::" prefix in headers
* add "using" declarations in .cc files.

so we don't rely on "using namespace std" in one or more included
headers.

Signed-off-by: Kefu Chai <kchai@redhat.com>
3 years agomsg: build without "using namespace std"
Kefu Chai [Wed, 11 Aug 2021 04:01:08 +0000 (12:01 +0800)]
msg: build without "using namespace std"

* add "std::" prefix in headers
* add "using" declarations in .cc files.

so we don't rely on "using namespace std" in one or more included
headers.

Signed-off-by: Kefu Chai <kchai@redhat.com>
3 years agoneorados: build without "using namespace std"
Kefu Chai [Wed, 11 Aug 2021 04:00:47 +0000 (12:00 +0800)]
neorados: build without "using namespace std"

* add "std::" prefix in headers
* add "using" declarations in .cc files.

so we don't rely on "using namespace std" in one or more included
headers.

Signed-off-by: Kefu Chai <kchai@redhat.com>
3 years agolibradosstriper: build without "using namespace std"
Kefu Chai [Wed, 11 Aug 2021 04:00:21 +0000 (12:00 +0800)]
libradosstriper: build without "using namespace std"

* add "std::" prefix in headers
* add "using" declarations in .cc files.

so we don't rely on "using namespace std" in one or more included
headers.

Signed-off-by: Kefu Chai <kchai@redhat.com>
3 years agolibcephfs: build without "using namespace std"
Kefu Chai [Wed, 11 Aug 2021 04:00:00 +0000 (12:00 +0800)]
libcephfs: build without "using namespace std"

* add "std::" prefix in headers
* add "using" declarations in .cc files.

so we don't rely on "using namespace std" in one or more included
headers.

Signed-off-by: Kefu Chai <kchai@redhat.com>
3 years agoblk: build without "using namespace std"
Kefu Chai [Wed, 11 Aug 2021 03:58:38 +0000 (11:58 +0800)]
blk: build without "using namespace std"

* add "std::" prefix in headers
* add "using" declarations in .cc files.

so we don't rely on "using namespace std" in one or more included
headers.

Signed-off-by: Kefu Chai <kchai@redhat.com>
3 years agolibcephsqlite: build without "using namespace std"
Kefu Chai [Wed, 11 Aug 2021 03:57:31 +0000 (11:57 +0800)]
libcephsqlite: build without "using namespace std"

* add "std::" prefix in headers
* add "using" declarations in .cc files.

so we don't rely on "using namespace std" in one or more included
headers.

Signed-off-by: Kefu Chai <kchai@redhat.com>
3 years agocommon: build without "using namespace std"
Kefu Chai [Wed, 11 Aug 2021 03:56:21 +0000 (11:56 +0800)]
common: build without "using namespace std"

* add "std::" prefix in headers
* add "using" declarations in .cc files.

so we don't rely on "using namespace std" in one or more included
headers.

Signed-off-by: Kefu Chai <kchai@redhat.com>
3 years agoosdc: build without "using namespace std"
Kefu Chai [Wed, 11 Aug 2021 03:55:49 +0000 (11:55 +0800)]
osdc: build without "using namespace std"

* add "std::" prefix in headers
* add "using" declarations in .cc files.

so we don't rely on "using namespace std" in one or more included
headers.

Signed-off-by: Kefu Chai <kchai@redhat.com>
3 years agorbd_replay: build without "using namespace std"
Kefu Chai [Wed, 11 Aug 2021 03:55:32 +0000 (11:55 +0800)]
rbd_replay: build without "using namespace std"

* add "std::" prefix in headers
* add "using" declarations in .cc files.

so we don't rely on "using namespace std" in one or more included
headers.

Signed-off-by: Kefu Chai <kchai@redhat.com>
3 years agocls: build without "using namespace std"
Kefu Chai [Wed, 11 Aug 2021 03:54:56 +0000 (11:54 +0800)]
cls: build without "using namespace std"

* add "std::" prefix in headers
* add "using" declarations in .cc files.

so we don't rely on "using namespace std" in one or more included
headers.

Signed-off-by: Kefu Chai <kchai@redhat.com>
3 years agolibrados: build without "using namespace std"
Kefu Chai [Wed, 11 Aug 2021 03:54:10 +0000 (11:54 +0800)]
librados: build without "using namespace std"

* add "std::" prefix in headers
* add "using" declarations in .cc files.

so we don't rely on "using namespace std" in one or more included
headers.

Signed-off-by: Kefu Chai <kchai@redhat.com>
3 years agoos: build without "using namespace std"
Kefu Chai [Wed, 11 Aug 2021 03:53:50 +0000 (11:53 +0800)]
os: build without "using namespace std"

* add "std::" prefix in headers
* add "using" declarations in .cc files.

so we don't rely on "using namespace std" in one or more included
headers.

Signed-off-by: Kefu Chai <kchai@redhat.com>
3 years agoosd: build without "using namespace std"
Kefu Chai [Wed, 11 Aug 2021 03:53:25 +0000 (11:53 +0800)]
osd: build without "using namespace std"

* add "std::" prefix in headers
* add "using" declarations in .cc files.

so we don't rely on "using namespace std" in one or more included
headers.

Signed-off-by: Kefu Chai <kchai@redhat.com>
3 years agotest: : build without "using namespace std"
Kefu Chai [Wed, 11 Aug 2021 03:53:01 +0000 (11:53 +0800)]
test: : build without "using namespace std"

* add "std::" prefix in headers
* add "using" declarations in .cc files.

so we don't rely on "using namespace std" in one or more included
headers.

Signed-off-by: Kefu Chai <kchai@redhat.com>
3 years agotest/erasure-code: build without "using namespace std"
Kefu Chai [Wed, 11 Aug 2021 03:52:02 +0000 (11:52 +0800)]
test/erasure-code: build without "using namespace std"

* add "std::" prefix in headers
* add "using" declarations in .cc files.

so we don't rely on "using namespace std" in one or more included
headers.

Signed-off-by: Kefu Chai <kchai@redhat.com>
3 years agotest/common: build without "using namespace std"
Kefu Chai [Wed, 11 Aug 2021 03:51:25 +0000 (11:51 +0800)]
test/common: build without "using namespace std"

* add "std::" prefix in headers
* add "using" declarations in .cc files.

so we don't rely on "using namespace std" in one or more included
headers.

Signed-off-by: Kefu Chai <kchai@redhat.com>
3 years agotest/objectstore: build without "using namespace std"
Kefu Chai [Wed, 11 Aug 2021 03:50:47 +0000 (11:50 +0800)]
test/objectstore: build without "using namespace std"

* add "std::" prefix in headers
* add "using" declarations in .cc files.

so we don't rely on "using namespace std" in one or more included
headers.

Signed-off-by: Kefu Chai <kchai@redhat.com>
3 years agomon: build without "using namespace std"
Kefu Chai [Wed, 11 Aug 2021 03:49:52 +0000 (11:49 +0800)]
mon: build without "using namespace std"

* add "std::" prefix in headers
* add "using" declarations in .cc files.

so we don't rely on "using namespace std" in one or more included
headers.

Signed-off-by: Kefu Chai <kchai@redhat.com>
3 years agomgr: build without "using namespace std"
Kefu Chai [Wed, 11 Aug 2021 03:48:33 +0000 (11:48 +0800)]
mgr: build without "using namespace std"

* add "std::" prefix in headers
* add "using" declarations in .cc files.

so we don't rely on "using namespace std" in one or more included
headers.

Signed-off-by: Kefu Chai <kchai@redhat.com>
3 years agolibrbd: build without "using namespace std"
Kefu Chai [Wed, 11 Aug 2021 03:48:00 +0000 (11:48 +0800)]
librbd: build without "using namespace std"

* add "std::" prefix in headers
* add "using" declarations in .cc files.

so we don't rely on "using namespace std" in one or more included
headers.

Signed-off-by: Kefu Chai <kchai@redhat.com>
3 years agoclient: build without "using namespace std"
Kefu Chai [Wed, 11 Aug 2021 03:47:21 +0000 (11:47 +0800)]
client: build without "using namespace std"

* add "std::" prefix in headers
* add "using" declarations in .cc files.

so we don't rely on "using namespace std" in one or more included
headers.

Signed-off-by: Kefu Chai <kchai@redhat.com>
3 years agomessages: build without "using namespace std"
Kefu Chai [Wed, 11 Aug 2021 03:46:41 +0000 (11:46 +0800)]
messages: build without "using namespace std"

* add "std::" prefix in headers
* add "using" declarations in .cc files.

so we don't rely on "using namespace std" in one or more included
headers.

Signed-off-by: Kefu Chai <kchai@redhat.com>
3 years agomds: build without "using namespace std"
Kefu Chai [Wed, 11 Aug 2021 03:46:14 +0000 (11:46 +0800)]
mds: build without "using namespace std"

* add "std::" prefix in headers
* add "using" declarations in .cc files.

so we don't rely on "using namespace std" in one or more included
headers.

Signed-off-by: Kefu Chai <kchai@redhat.com>
3 years agotest/librbd: build without "using namespace std"
Kefu Chai [Wed, 11 Aug 2021 03:45:41 +0000 (11:45 +0800)]
test/librbd: build without "using namespace std"

* add "std::" prefix in headers
* add "using" declarations in .cc files.

so we don't rely on "using namespace std" in one or more included
headers.

Signed-off-by: Kefu Chai <kchai@redhat.com>
3 years agotest/rbd_mirror: build without "using namespace std"
Kefu Chai [Wed, 11 Aug 2021 03:44:59 +0000 (11:44 +0800)]
test/rbd_mirror: build without "using namespace std"

* add "std::" prefix in headers
* add "using" declarations in .cc files.

so we don't rely on "using namespace std" in one or more included
headers.

Signed-off-by: Kefu Chai <kchai@redhat.com>
3 years agotest/rgw: build without "using namespace std"
Kefu Chai [Wed, 11 Aug 2021 03:44:27 +0000 (11:44 +0800)]
test/rgw: build without "using namespace std"

* add "std::" prefix in headers
* add "using" declarations in .cc files.

so we don't rely on "using namespace std" in one or more included
headers.

Signed-off-by: Kefu Chai <kchai@redhat.com>
3 years agorgw: build without "using namespace std"
Kefu Chai [Wed, 11 Aug 2021 03:43:42 +0000 (11:43 +0800)]
rgw: build without "using namespace std"

* add "std::" prefix in headers
* add "using" declarations in .cc files.

so we don't rely on "using namespace std" in one or more included
headers.

Signed-off-by: Kefu Chai <kchai@redhat.com>
3 years agotools: build without "using namespace std"
Kefu Chai [Wed, 11 Aug 2021 03:42:44 +0000 (11:42 +0800)]
tools: build without "using namespace std"

* add "std::" prefix in headers
* add "using" declarations in .cc files.

so we don't rely on "using namespace std" in one or more included
headers.

Signed-off-by: Kefu Chai <kchai@redhat.com>
3 years agotools/rbd_mirror: build without "using namespace std"
Kefu Chai [Wed, 11 Aug 2021 03:41:42 +0000 (11:41 +0800)]
tools/rbd_mirror: build without "using namespace std"

* add "std::" prefix in headers
* add "using" declarations in .cc files.

so we don't rely on "using namespace std" in one or more included
headers.

Signed-off-by: Kefu Chai <kchai@redhat.com>
3 years agotools/rbd: build without "using namespace std"
Kefu Chai [Wed, 11 Aug 2021 03:40:46 +0000 (11:40 +0800)]
tools/rbd: build without "using namespace std"

* add "std::" prefix in headers
* add "using" declarations in .cc files.

so we don't rely on "using namespace std" in one or more included
headers.

Signed-off-by: Kefu Chai <kchai@redhat.com>
3 years agotest/crimson: build without "using namespace std"
Kefu Chai [Wed, 11 Aug 2021 03:38:07 +0000 (11:38 +0800)]
test/crimson: build without "using namespace std"

* add "std::" prefix in headers
* add "using" declarations in .cc files.

so we don't rely on "using namespace std" in one or more included
headers.

Signed-off-by: Kefu Chai <kchai@redhat.com>
3 years agoMerge pull request #42167 from emenguy/nomad_ceph_integration_documentation
zdover23 [Thu, 12 Aug 2021 22:48:40 +0000 (08:48 +1000)]
Merge pull request #42167 from emenguy/nomad_ceph_integration_documentation

[docs]: RBD and Nomad integration

Reviewed-by: Zac Dover <zac.dover@gmail.com>
3 years agoMerge PR #42771 into master
Sage Weil [Thu, 12 Aug 2021 20:04:21 +0000 (16:04 -0400)]
Merge PR #42771 into master

* refs/pull/42771/head:
.githubmap: fix format

Reviewed-by: Sage Weil <sage@redhat.com>
3 years agoMerge pull request #41570 from jhrcz-ls/wip-cephfs-overview-use-rate
Ernesto Puerta [Thu, 12 Aug 2021 18:53:07 +0000 (20:53 +0200)]
Merge pull request #41570 from jhrcz-ls/wip-cephfs-overview-use-rate

mgr/dashboard: cephfs MDS Workload to use rate for counter type metric

3 years agoMerge pull request #42745 from rhcs-dashboard/52130-tox-cleanup
Ernesto Puerta [Thu, 12 Aug 2021 18:52:03 +0000 (20:52 +0200)]
Merge pull request #42745 from rhcs-dashboard/52130-tox-cleanup

mgr/dashboard: tox.ini: delete useless env. 'apidocs'

3 years agoMerge pull request #42724 from rhcs-dashboard/52082-cephadm-e2e-improv
Ernesto Puerta [Thu, 12 Aug 2021 18:50:51 +0000 (20:50 +0200)]
Merge pull request #42724 from rhcs-dashboard/52082-cephadm-e2e-improv

mgr/dashboard: run-cephadm-e2e-tests.sh improvements

3 years ago.githubmap: fix format 42771/head
Ernesto Puerta [Thu, 12 Aug 2021 18:22:39 +0000 (20:22 +0200)]
.githubmap: fix format

Issue introduced by merge commit
4b9a3b217127d003d4ae6addb1f0e1d8ce21b816

Signed-off-by: Ernesto Puerta <epuertat@redhat.com>
3 years agoMerge pull request #42630 from mark15213/licephsqlitefix
Yuri Weinstein [Thu, 12 Aug 2021 18:24:39 +0000 (11:24 -0700)]
Merge pull request #42630 from mark15213/licephsqlitefix

libcephsqlite: fix unconditional success bug in CheckReservedLock

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
3 years agoMerge pull request #42345 from aclamk/wip-resharding-column-options
Yuri Weinstein [Thu, 12 Aug 2021 18:21:36 +0000 (11:21 -0700)]
Merge pull request #42345 from aclamk/wip-resharding-column-options

Add handling of block_cache option for resharding

Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
3 years agoMerge pull request #42767 from soumyakoduri/wip-skoduri-sqlite-freebsd
Daniel Gryniewicz [Thu, 12 Aug 2021 17:57:30 +0000 (13:57 -0400)]
Merge pull request #42767 from soumyakoduri/wip-skoduri-sqlite-freebsd

rgw/dbstore: Resolve library link issues on FreeBSD

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
Reviewed-by: Willem Jan Withagen
3 years agoMerge pull request #42766 from rhcs-dashboard/fix-grafonnet-42194
Ernesto Puerta [Thu, 12 Aug 2021 16:39:25 +0000 (18:39 +0200)]
Merge pull request #42766 from rhcs-dashboard/fix-grafonnet-42194

mgr/dashboard: fix grafonnet build error

3 years agoMerge pull request #42725 from ifed01/wip-ifed-fix-deferred
Neha Ojha [Thu, 12 Aug 2021 16:14:59 +0000 (09:14 -0700)]
Merge pull request #42725 from ifed01/wip-ifed-fix-deferred

os/bluestore: make deferred writes less aggressive for large writes

Reviewed-by: Adam Kupczyk <akupczyk@redhat.com>
3 years agoMerge pull request #42685 from BenoitKnecht/rgw-opa-100-continue
Casey Bodley [Thu, 12 Aug 2021 14:06:51 +0000 (10:06 -0400)]
Merge pull request #42685 from BenoitKnecht/rgw-opa-100-continue

rgw: Use 100-continue in OPA requests to reduce latency

Reviewed-by: Casey Bodley <cbodley@redhat.com>
3 years agorgw/dbstore: Resolve library link issues on FreeBSD 42767/head
Soumya Koduri [Thu, 12 Aug 2021 13:52:08 +0000 (19:22 +0530)]
rgw/dbstore: Resolve library link issues on FreeBSD

Add "rgw_common" to the target_link_libraries list to
resolve issues with sqlite_db target build on FreeBSD

Reported-by: Willem Jan Withagen wjw@digiware.nl
Signed-off-by: Soumya Koduri <skoduri@redhat.com>
3 years agoMerge pull request #42657 from tchaikov/wip-optional-wheel
Kefu Chai [Thu, 12 Aug 2021 13:13:54 +0000 (21:13 +0800)]
Merge pull request #42657 from tchaikov/wip-optional-wheel

tools/setup-virtualenv: do not use wheel if wheelhouse does not exist

Reviewed-by: Deepika Upadhyay <dupadhya@redhat.com>
3 years agomgr/dashboard: fix grafonnet build error 42766/head
Aashish Sharma [Thu, 12 Aug 2021 08:58:23 +0000 (14:28 +0530)]
mgr/dashboard: fix grafonnet build error

This PR tends to fix the issue caused by #42194

Fixes:https://tracker.ceph.com/issues/52238
Signed-off-by: Aashish Sharma <aasharma@redhat.com>
3 years agoMerge pull request #42293 from zdover23/wip-doc-cephadm-client-setup-2021-07-12
Sebastian Wagner [Thu, 12 Aug 2021 11:06:11 +0000 (13:06 +0200)]
Merge pull request #42293 from zdover23/wip-doc-cephadm-client-setup-2021-07-12

doc/cephadm: rewrite client-setup.rst

Reviewed-by: Sebastian Wagner <sewagner@redhat.com>
3 years agoos/bluestore/bluefs: Cleanup allocation consistency check code 42754/head
Adam Kupczyk [Wed, 11 Aug 2021 13:41:34 +0000 (15:41 +0200)]
os/bluestore/bluefs: Cleanup allocation consistency check code

When bluefs_log_replay_check_allocations is set _replay performs checks if
allocations/deallocations of extents are valid and properly aligned.
The changes include:
- now deallocations are also checked for valid alignment (more sanity checks)
- bluefs log read from super is checked once - before reading any transaction

Signed-off-by: Adam Kupczyk <akupczyk@redhat.com>