rgw: remove some compilation warnings

rgw: don't override ret value in do_read_permisions

rgw: return correct bucket missing error when needed

rgw: fix 500 error on bucket creation

rgw: fix clitest

MonClient: fix possible null dereference

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>

mds/Server.c: fix memory leak in err path

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>

rgw: don't check for zero content when creating a bucket

rgw: rgw_admin bucket stats dumps owner

rgw: add radosgw_admin bucket stats

librados: fix memory leak in error path

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>

test/confutils.cc: fix resource leak

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>

rgw: fix prepare_get_obj when ENOENT

rbd: fix shared_ptr usage

shared_ptr calls the disposal function even when the pointer is null
that is being disposed of.

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>

do_kernel_showmapped: fix resource leak

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>

Merge remote branch 'origin/next'

client: fix readdir + cap recovation/reissue race

The current race:
 - we start readdir
 - mds revokes dir cap
 - some file gets removed
 - mds reissues dir cap
 - we finish readdir and set I_COMPLETE

We should only set it if there have been no FILE_SHARED reissues during
the readdir.

Note that we still set I_COMPLETE even if we don't have the cap; that's
useless but harmless, since it is undefined without FILE_SHARED being
set.

Signed-off-by: Sage Weil <sage@newdream.net>

rados_sync: fix resource leak on err

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>

CephBroker.cc: fix allocation/deallocation mismatch

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>

test_rados_tool.sh: test export with --workers

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>

rados_sync: make number of worker threads configurable

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>

rgw: clear warning

Merge branch 'wip-decouple-bucket'

journaler: fix waiting_for_zero clearing, again

We can only clear this when we have >= a period between flush_pos and
write_pos.

Clear the flag in _do_flush() so the check is not fragile, should this
ever be changed in the future.

Signed-off-by: Sage Weil <sage.weil@dreamhost.com>

Revert "pipe.c: #define GNU_SOURCE"

This reverts commit ae9ba2249e372e7435e56f54fc2d8e22f3e42ff8.

This is handled in master by the Makefile.

Merge branch 'next'

client: only link directories into hierarchy once

Directories can only link into the hierarchy once.  We assert as much
in readdir_r_cb().  Fix link() so that it unlinked the directory from the
old location when relinking somewhere new.  Be careful to do this after
we take inode refs to avoid any unpleasantness.

Fixes: #1429
Reported-by: Sam Lang <samlang@gmail.com>
Signed-off-by: Sage Weil <sage@newdream.net>

mon: fix store_state

We need to bound the range we write to disk by m->last_committed; this got
lost in translation in commit dfab2c91f53289b1d527fb87126a639f5d5275f1.

Fixes paxos crashes in handle_begin

mon/Paxos.cc: In function 'void Paxos::handle_begin(MMonPaxos*)', in thread '0x7fc74d11f700'
mon/Paxos.cc: 393: FAILED assert(begin->last_committed == last_committed)

Signed-off-by: Sage Weil <sage.weil@dreamhost.com>

journaler: fix waiting_for_zero clearing

Clear this flag only if we know no subsequent flushes could be waiting on
a prezero operation.

Fixes MDS journaling hang under heavy journal load.

Signed-off-by: Sage Weil <sage.weil@dreamhost.com>

Merge branch 'master' into wip-decouple-bucket

add missing include, required for certain environments

Merge remote-tracking branch 'origin/master' into wip-decouple-bucket

Conflicts:
src/rgw/rgw_rados.cc

rgw: fix multipart upload

don't try to reset meta object with category

parallelize rados export and import

* use workqueues to parallelize rados export and import

* Put export and import into separate files

* Fix RADOS_SYNC_TMP_SUFFIX_LEN bug

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>

WorkQueue: don't be chatty about finishing workers

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>

test_rados_tool.sh: fix xattr test

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>

librados: fix IoCtx copy constructor

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>

rados_sync:don't need to declare CHANGED_XATTRS 2x

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>

Some fixes to double-dash support, fix warning

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>

rgw: if pool is empty recreate

ceph_argparse: handle double dashes consistently

Handle double dashes in the ceph_argparse functions, so that any piece
of code doing argument parsing will correctly interpret them.

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>

injectargs: binary flags only consume 1 token

Never consume more than one token when parsing a binary flag.

Basically, your choices are --foo=false, --foo=true, and just --foo.
However, only 1 token will ever be examined.

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>

config: print warning on injectargs parse fail

injectargs should print a warning message when its parser fails.

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>

injectargs test: test foo=true

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>

mon: allow wildcards for mon cap command matching

We need wildcards, actually.  * is any token, ... is 1 or more tokens.

Signed-off-by: Sage Weil <sage@newdream.net>

common/config: fix get_val for booleans

md_config_t::get_val should return true/false for booleans, not 0/1.
This is for consistency with the setter.

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>

pipe.c: #define GNU_SOURCE

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>

qa: add unit tests for mon cap 'allow command ...' stanzas

Signed-off-by: Sage Weil <sage@newdream.net>

mon: whitelist individual commands in mon cap string

This lets you whitelist a command prefix.  For example,

 'allow command osd foo'

will let you do any command that begins with 'osd foo', including
'osd foo' and 'osd foo bar baz bam'.

No deny, and no pattern matching.

Signed-off-by: Sage Weil <sage@newdream.net>

mon: adjust max_devices when adding to crush map

Signed-off-by: Sage Weil <sage@newdream.net>

crush: refuse to add item >= max_devices

Signed-off-by: Sage Weil <sage@newdream.net>

mon: 'osd gstcrushmap' or 'osd crush set' both work

Signed-off-by: Sage Weil <sage@newdream.net>

mon: fix arg count checks

Signed-off-by: Sage Weil <sage@newdream.net>

mon: 'osd crush reweight <name> <weight>'

Reweight a node in the crush map.

Signed-off-by: Sage Weil <sage@newdream.net>

mon: 'osd crush rm <name>'

This is similar to crushtool --remove-item.

Signed-off-by: Sage Weil <sage@newdream.net>

mon: 'osd crush add <id> <name> <weight> [<loc1=foo> [<loc2=bar> ...]]'

This is identical to the crushtool --add-item functionality, but does not
require a racy and tedious

 - get crush map
 - update crush map
 - set new crush map

Signed-off-by: Sage Weil <sage@newdream.net>

mon: return error message string when no other output string specified

Signed-off-by: Sage Weil <sage@newdream.net>

common/config: honor --

Argument parsing should stop after --

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>

mon: remove dead 'setmap' code

Signed-off-by: Sage Weil <sage@newdream.net>

mon: make auto-marking of booting osds 'in' optional

By default we mark a booting OSD 'in' so that it immediately gets data.
Make this optional.

Eventually we may want to make this default to off...

Signed-off-by: Sage Weil <sage@newdream.net>

client: kill dentry_of() macro

Signed-off-by: Sage Weil <sage@newdream.net>

Merge branch 'next'

osd_types: fix category encoding in object_info_t

This was mis-merged in f6ff0f14e9a5b70d5ce0277975d321f10e3b39c7.

Signed-off-by: Sage Weil <sage@newdream.net>

qa: define _GNU_SOURCE for qa helpers; add btrfs dir makefile

Signed-off-by: Sage Weil <sage.weil@dreamhost.com>

librados: whitespace

Don't do

some::class::
method(int foo)
{

}

...because then I can't '^S::method'. :)

Signed-off-by: Sage Weil <sage.weil@dreamhost.com>

librbd: reimplement copy using read_iterate

Ah, so much simpler!

Signed-off-by: Sage Weil <sage@newdream.net>

rbd: fix check_io for snap

Need to look at image size for snapshot, not the head version.

Signed-off-by: Sage Weil <sage@newdream.net>

librbd: fix copy

This was croaking on sparse images.

Use an image ctx for the dest.

We should probably use read_iterate instead.

Signed-off-by: Sage Weil <sage@newdream.net>

qa: add rbd copy workunit

Test copying an image and snapshot.

Signed-off-by: Sage Weil <sage@newdream.net>

mdcache: documentation for path_traverse

Signed-off-by: Greg Farnum <gregory.farnum@dreamhost.com>

mdcache: Reduce the gratuitous references to onfail

We've been setting flags at the beginning of path_traverse
for a while; use those instead of ongoing comparisons.

Signed-off-by: Greg Farnum <gregory.farnum@dreamhost.com>

mds: remove the unused MDS_TRAVERSE_FAIL flag.

This isn't used, and judging by the comments was a horrible lie.

Signed-off-by: Greg Farnum <gregory.farnum@dreamhost.com>

mdcache: handle unreadable null dentries

Previously, we were asserting (farther down) if the dentry was
null but blocked by a lock. Instead, we should here be waiting
until it's readable instead of just continuing on.

Signed-off-by: Greg Farnum <gregory.farnum@dreamhost.com>

librbd: specify copy src image as image handle

By specifying via an image handle we can set the snapshot on the src
image.  This also makes the API cleaner.

Fixes: #1416
Signed-off-by: Sage Weil <sage@newdream.net>

Define _GNU_SOURCE in src/Makefile.am

We end up needing _GNU_SOURCE in a bunch of places-- to get direct i/o,
pipe2, and some other Linux-specific interfaces.

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>

pipe.c: #define GNU_SOURCE

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>

Merge branch 'next'

mds: open+pin stray dirfrags on startup

This ensures that the stray dirfrags are always open, which in turn ensures
that whenever we add straydn items the rstats/fragstats will get updated
properly.  This is a better solution than d3d767a.

Now we can assert the stray dirfrag is open in
get_or_create_stray_dentry() instead of calling get_or_open_dirfrag().

Signed-off-by: Sage Weil <sage@newdream.net>

Revert "mds: do not complain/assert about stray inode rstat/fragstat consistency"

This reverts commit d3d767a2a36caefdeb8a94abba1673cf8304c793.

A better solution is to keep the stray frags loaded+pinned.

common/pipe: add function to do pipe2(O_CLOEXEC)

Support old systems that don't have O_CLOEXEC.

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>

PG: Move reset_last_warm_restart to Initial::exit

Previously, reset_last_warm_restart was only invoked when handle_create
was used.  This misses cases where the pg is initialized via a Notify,
Log, or Info message.  reset_last_warm_restart will now be called from
the Initial state exit handler in order to handle the other cases.

Signed-off-by: Samuel Just <samuel.just@dreamhost.com>

common/pipe: add function to do pipe2(O_CLOEXEC)

Support old systems that don't have O_CLOEXEC.

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>

PG: Move reset_last_warm_restart to Initial::exit

Previously, reset_last_warm_restart was only invoked when handle_create
was used.  This misses cases where the pg is initialized via a Notify,
Log, or Info message.  reset_last_warm_restart will now be called from
the Initial state exit handler in order to handle the other cases.

Signed-off-by: Samuel Just <samuel.just@dreamhost.com>

osd: flush writes prior to PGLS

Make sure previous writes (which will include both object creation and
PG creation) are flushed before listing objects.

Fixes: #1427
Signed-off-by: Sage Weil <sage@newdream.net>

osd: remove dead code, whitespace

Signed-off-by: Sage Weil <sage@newdream.net>

librados: prefix api test pools

Signed-off-by: Sage Weil <sage.weil@dreamhost.com>

librados: statically link gtest into librados unit tests

This way they can run via teuthology.

We should do this for anything that we expect to run outside of the
immediate build environment.

Signed-off-by: Sage Weil <sage.weil@dreamhost.com>

Makefile: allow gtest to be linked in statically

Use UNITTEST_STATIC_LDADD instead of UNITTEST_LDADD.

Signed-off-by: Sage Weil <sage.weil@dreamhost.com>

.gitignore: scratchtool

Signed-off-by: Sage Weil <sage.weil@dreamhost.com>

Makefile: rule to upload + submit coverity job

You need to

 make project.tgz
 make submit-coverity

and have .coverity.build.pass with the right password in CWD
(ceph.git/src).

The submit-coverity rule doesn't do the project.tgz for you because it
always cleans+rebuilds every time.

Signed-off-by: Sage Weil <sage.weil@dreamhost.com>

addr_parsing: fix warning

warning: include/addr_parsing.c:45: ‘saveptr’ may be used uninitialized in this function

Signed-off-by: Sage Weil <sage.weil@dreamhost.com>

escape: fix snprintf args

Include space for null termination.

Signed-off-by: Sage Weil <sage.weil@dreamhost.com>

.gitignore: scratchtool

Signed-off-by: Sage Weil <sage.weil@dreamhost.com>

librados: fix shadow

Coverity cid 23

Signed-off-by: Sage Weil <sage.weil@dreamhost.com>

mds: fix shadow

Coverity cid 24

Signed-off-by: Sage Weil <sage.weil@dreamhost.com>

mds: fix shadow

Coverity cid 25

Signed-off-by: Sage Weil <sage.weil@dreamhost.com>

mds: fix shadow

Coverity cid 26

Signed-off-by: Sage Weil <sage.weil@dreamhost.com>

mds: fix shadow

Coverity cid 27

Signed-off-by: Sage Weil <sage.weil@dreamhost.com>

mds: fix shadow

Coverity cid 28

Signed-off-by: Sage Weil <sage.weil@dreamhost.com>

moncaps: fix shadow

Coverity cid 30

Signed-off-by: Sage Weil <sage.weil@dreamhost.com>