Merge pull request #30404 from shun-s/cleanup-failure-pending

osd: make osd recover more smoothly by avoiding failure peer info to resent

Reviewed-by: xie xingguo <xie.xingguo@zte.com.cn>
Reviewed-by: Sage Weil <sage@redhat.com>

Merge pull request #30517 from tchaikov/wip-test/dashboard/scheme-allow-unknown

qa/tasks/mgr/dashboard/test_health: add "allow_unknown" in mgr_map

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>

Merge PR #30297 into master

* refs/pull/30297/head:
test_cephfs_shell: add note on how to run this testsuite
cephfs-shell: rewrite help text for put and get commands

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

Merge pull request #30533 from cxytt/fix-complete-to-not-reset

osd/PGLog: reset log.complete_to when recover obect failed

Reviewed-by: xie xingguo <xie.xingguo@zte.com.cn>

Merge pull request #30538 from tchaikov/wip/test/ceph_argparse/yet-another-test

mon.test: improve validation and add a test for "osd pool create"

Reviewed-by: xie xingguo <xie.xingguo@zte.com.cn>

Merge pull request #30504 from Songweibin/wip-app-meta-get

pybind/rados: add application_metadata_get

Reviewed-by: xie xingguo <xie.xingguo@zte.com.cn>

Merge pull request #30421 from sebastian-philipp/prometheus-always-on-modules

mgr/prometheus: Fix KeyError in get_mgr_status

Reviewed-by: Jan Fajerski <jfajerski@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>

Merge pull request #30200 from NancySu05/dev

mon/OSDMonitor: trim not-longer-exist failure reporters

Reviewed-by: Greg Farnum <gfarnum@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge PR #29906 into master

* refs/pull/29906/head:
vstart_runner: name booleans for options differently
qa/vstart_runner.py: add an option to remove old log
qa/vstart_runner.py: make log initialization code reusable
qa/vstart_runner.py: make printing of stdout of ps optional
qa/vstart_runner.py: add timeout for vstart.sh and stop.sh
qa/vstart_runner.py: add an option to teardown cluster

Reviewed-by: Jeff Layton <jlayton@redhat.com>

Merge pull request #30612 from tchaikov/wip-install-deps.sh/do-not-fail-if-already-installed

install-deps: do not install if rpm already installed

Reviewed-by: Brad Hubbard <bhubbard@redhat.com>

install-deps: do not install if rpm already installed

there is chance that the system already have epel-release-latest-7.noarch.rpm
installed, in that case, install-deps.sh should not fail.

Signed-off-by: Kefu Chai <kchai@redhat.com>

Merge pull request #30466 from xiexingguo/wip-41924

osd/PGLog: persist num_objects_missing for replicas when peering is done

Reviewed-by: Neha Ojha <nojha@redhat.com>

Merge pull request #30576 from xiexingguo/wip-42052

osd/OSDMap: do not trust partially simplified pg_upmap_item

Reviewed-by: Sage Weil <sage@redhat.com>

Merge pull request #30560 from xiexingguo/wip-balancer-upmap-cli

mgr/balancer: enable pg_upmap cli for future use

Reviewed-by: Sage Weil <sage@redhat.com>

Merge PR #30223 into master

* refs/pull/30223/head:
msg/async: do not register lossy client connections
msg/async: allow anonymous client-side connections

Reviewed-by: Greg Farnum <gfarnum@redhat.com>

mgr/dashboard: REST API: OpenAPI docs require internet connect… (#30477)

mgr/dashboard: REST API: OpenAPI docs require internet connection

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Tiago Melo <tmelo@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>

Merge pull request #30557 from smithfarm/wip-42023

install-deps.sh: add EPEL repo for non-x86_64 archs as well

Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Brad Hubbard <bhubbard@redhat.com>

Merge pull request #30590 from jtlayton/wip-42032

ceph.spec.in: fix Cython package dependency for Fedora

Merge pull request #29460 from rhcs-dashboard/bucket-versioning

mgr/dashboard: enable/disable versioning on RGW bucket

Reviewed-by: Volker Theile <vtheile@suse.com>

Merge pull request #30208 from ricardoasmarques/support-iscsi-controls-types

mgr/dashboard: Controls UI inputs based on "type"

Reviewed-by: Tiago Melo <tmelo@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>

Merge PR #28834 into master

* refs/pull/28834/head:
libcephfs: Add test for lazyio via libcephfs
libcephfs: Add lazyio_propogate and lazyio_synchronize methods to libcephfs

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Jeff Layton <jlayton@redhat.com>

Merge PR #29818 into master

* refs/pull/29818/head:
client/MetaRequest: Add age to MetaRequest dump
osdc/Objecter: Add age to the ops
common/ceph_time: Use fixed floating-point notation for mono_clock

Reviewed-by: Sage Weil <sage@redhat.com>
Reviewed-by: Adam C. Emerson <aemerson@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

Merge PR #29902 into master

* refs/pull/29902/head:
mds: Revert "properly setup client_need_snapflush for snap inode"
mds: cleanup dirty snap caps tracking

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

Merge PR #29921 into master

* refs/pull/29921/head:
mds: split the dir if the op makes it oversized

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Zheng Yan <zyan@redhat.com>

Merge PR #30202 into master

* refs/pull/30202/head:
mds: Explicitly call slave_updates with 0 size
mds: Move log_segment_seq_t into class LogSegment
mds: Reorganize class members in LogSegment header

Reviewed-by: Jos Collin <jcollin@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

Merge PR #30403 into master

* refs/pull/30403/head:
mds: mds returns -5 error when the deleted file does not exist

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Jeff Layton <jlayton@redhat.com>

Merge PR #30462 into master

* refs/pull/30462/head:
qa: have kclient tests use new mount.ceph functionality

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Rishabh Dave <ridave@redhat.com>
Reviewed-by: Ilya Dryomov <idryomov@redhat.com>

mgr/dashboard: Support iSCSI target-level CHAP auth (#30011)

mgr/dashboard: Support iSCSI target-level CHAP auth

Reviewed-by: Tiago Melo <tmelo@suse.com>

Merge pull request #30588 from ricardoasmarques/fix-iscsi-test-put

mgr/dashboard: Wait for iSCSI target put and delete

Reviewed-by: Laura Paduano <lpaduano@suse.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>

ceph.spec.in: fix Cython package dependency for Fedora

Fedora distros do not have python3?-Cython packages, but they do have
python3-Cython ones. Fix the BuildRequires so that we only use the
python3_version_nodots based version string for RHEL.

Fixes: https://tracker.ceph.com/issues/42032
Signed-off-by: Jeff Layton <jlayton@redhat.com>

mgr/dashboard: Wait for iSCSI target put and delete

Signed-off-by: Ricardo Marques <rimarques@suse.com>

Merge pull request #30571 from smithfarm/wip-bci-force

src/script/backport-create-issue: implement --force option

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

mgr/dashboard: Controls UI inputs based on "type"

iSCSI controls UI inputs should be rendered based
on the control "type" returned by `ceph-iscsi`.

Fixes: https://tracker.ceph.com/issues/41682
Signed-off-by: Ricardo Marques <rimarques@suse.com>

mgr/dashboard: test_mgr_module QA test has not been adapted to… (#30513)

mgr/dashboard: Adapt test_mgr_module QA test to latest controller changes

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Laura Paduano <lpaduano@suse.com>

mgr/dashboard: wait for iscsi/target create/put (#30582)

mgr/dashboard: wait for iscsi/target create/put

Reviewed-by: Laura Paduano <lpaduano@suse.com>

mgr/dashboard: enable/disable versioning on RGW bucket

Fixes: https://tracker.ceph.com/issues/40920
Signed-off-by: Alfonso Martínez <almartin@redhat.com>

Merge pull request #30578 from tchaikov/wip-seastar-unix-domain-socket

seastar: pickup unix domain socket support

Reviewed-by: Ronen Friedman <rfriedma@redhat.com>

mgr/dashboard: wait for iscsi/target create/put

IscsiTarget.create() returns a Task, so we need to wait for its
completion before moving on.

the same applies to IscsiTarget.put()

Signed-off-by: Kefu Chai <kchai@redhat.com>

msg/async: do not register lossy client connections

If our policy is server + lossy, we do not need to track our incoming
client connections by address.  First, because it doesn't do us any good.
Second, it is nicer if we don't, because we can allow multiple incoming
connections from the same peer addr.

Update a couple of tests: one doesn't apply any more, and the other needs
a different way of getting the just-accepted con ref.

Signed-off-by: Sage Weil <sage@redhat.com>

msg/async: allow anonymous client-side connections

If the connection mode is lossy, allow us to open a new connection to
a target, regardless of whether other such connections are already open.
This allows for single-use connections.  If you call this multiple times,
you'll get separate, distinct connections.

We are lucky that the cleanup infrastructure for AsyncMessenger just works
without modification.  :)

Signed-off-by: Sage Weil <sage@redhat.com>

seastar: pickup unix domain socket support

Signed-off-by: Kefu Chai <kchai@redhat.com>

Merge PR #30523 into master

* refs/pull/30523/head:
mon/MonClient: skip CEPHX_V2 challenge if client doesn't support it

Reviewed-by: Greg Farnum <gfarnum@redhat.com>
Reviewed-by: Ricardo Dias <rdias@suse.com>

osd/OSDMap: do not trust partially simplified pg_upmap_item

If we simplified a partially no-op pg_upmap_item, we shall still
continue to verify that the remaining part is valid.
The bug is introduced by 02e5499b350bcd7d9eac98b2072052a9a4a1f535,
before which we always validate the correctness of a pg_upmap_item
before trying to cancel or simplify it.

Fixes: https://tracker.ceph.com/issues/42052
Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>

mgr/dashboard: Support iSCSI target-level CHAP auth

Requires `ceph-iscsi` config v11

Fixes: https://tracker.ceph.com/issues/41576
Signed-off-by: Ricardo Marques <rimarques@suse.com>

mgr/dashboard: Display the "destroyed" state in OSD list (#30514)

mgr/dashboard: Display the "destroyed" state in OSD list

Reviewed-by: Ricardo Dias <rdias@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>

install-deps.sh: add EPEL repo for non-x86_64 archs as well

Fixes: https://tracker.ceph.com/issues/42023
Signed-off-by: Kefu Chai <kchai@redhat.com>
Signed-off-by: Nathan Cutler <ncutler@suse.com>

src/script/backport-create-issue: implement --force option

If --force option is given along with an explicit list of issue numbers,
backport issues will be created regardless of issue status.

In all other usage scenarios, script behavior remains the same (backport
issues are created only if issue status is "Pending Backport").

Signed-off-by: Nathan Cutler <ncutler@suse.com>

Merge pull request #30420 from runsisi/wip-remove-requests

rpm,deb: python-requests is not needed for ceph-common

Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #30422 from rishabh-d-dave/cv-fix-pytest-warning

ceph-volume: fix warnings raised by pytest

vstart_runner: name booleans for options differently

This achieves 2 things: makes it more understandable for the reader that
the boolean variable is an option and reads less like a method name.

Signed-off-by: Rishabh Dave <ridave@redhat.com>

qa/vstart_runner.py: add an option to remove old log

Add an option "--clear-old-log" to get rid of log entries before making
entries for current batch of tests.

Signed-off-by: Rishabh Dave <ridave@redhat.com>

qa/vstart_runner.py: make log initialization code reusable

Move it to a method so that the code be can be reused.

Signed-off-by: Rishabh Dave <ridave@redhat.com>

qa/vstart_runner.py: make printing of stdout of ps optional

stdout of ps command is generally pretty huge which makes it harder to
interpret logs. Don't print it by default and add "--log-ps-output" to
enable printing it.

Signed-off-by: Rishabh Dave <ridave@redhat.com>

qa/vstart_runner.py: add timeout for vstart.sh and stop.sh

Override default timeout for execution of vstart.sh and stop.sh since
neither scripts take more than 100 seconds normally.

Signed-off-by: Rishabh Dave <ridave@redhat.com>

qa/vstart_runner.py: add an option to teardown cluster

Add "--teardown" option so that vstart_runner.py tears down Ceph
cluster automatically after the batch of tests has completed running.
Also delete build/dev and build/out directories, after running stop.sh.

Update the doc for vstart_runner.py as well.

Signed-off-by: Rishabh Dave <ridave@redhat.com>

mgr/balancer: enable pg_upmap cli for future use

Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>

Merge pull request #30036 from tchaikov/wip-python3-pkgversion

ceph.spec.in: s/pkgversion/version_nodots/

Reviewed-by: Sage Weil <sage@redhat.com>
Reviewed-by: Boris Ranto <branto@redhat.com>

ceph.spec.in: s/pkgversion/version_nodots/

`python3_pkgversion` is now defined as 3, while we don't have packages
like python3-Cython yet in EPEL7. but we do have `python36-Cython`. so
let's use `python3_version_nodots` instead.

Signed-off-by: Kefu Chai <kchai@redhat.com>

mgr/dashboard: Gracefully handle client/target info not found (#30349)

mgr/dashboard: Gracefully handle client/target info not found

Reviewed-by: Tiago Melo <tmelo@suse.com>

mgr/dashboard: Using wrong identifiers in RGW user/bucket data… (#30492)

mgr/dashboard: Using wrong identifiers in RGW user/bucket datatables

Reviewed-by: Tiago Melo <tmelo@suse.com>

Merge PR #30537 into master

* refs/pull/30537/head:
test/pybind: fix local variables for emacs
crush: add editor property variables

Reviewed-by: Sage Weil <sage@redhat.com>

mgr/dashboard: Gracefully handle client/target info not found

Fixes: https://tracker.ceph.com/issues/41779
Signed-off-by: Ricardo Marques <rimarques@suse.com>

Merge PR #29824 into master

* refs/pull/29824/head:
qa: whitelist new FS_INLINE_DATA_DEPRECATED health warning
mds: add a HEALTH_WARN message when inline_data is enabled
mds: log a warning message when mds is started on an fs with inline_data
mon: deprecate CephFS inline_data support

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Sage Weil <sage@redhat.com>
Reviewed-by: Douglas Fuller <dfuller@redhat.com>

Merge PR #29526 into master

* refs/pull/29526/head:
client: _readdir_cache_cb() may use the readdir_cache already clear

Reviewed-by: Zheng Yan <zyan@redhat.com>

Merge pull request #30426 from votdev/harden_mgr_modules_list

mgr/dashboard: Prevent KeyError when requesting always_on_modules

Reviewed-by: Sebastian Wagner <swagner@suse.com>
Reviewed-by: Stephan Müller <smueller@suse.com>

Merge PR #30164 into master

* refs/pull/30164/head:
mds: Remove unnecessary headers in Locker
mds: Reorganize class members in Locker header

Reviewed-by: Jos Collin <jcollin@redhat.com>

Merge PR #30312 into master

* refs/pull/30312/head:
client:EINVAL may be returned when offset is 0 ,Loff_t pos = f->pos should be the best.

Reviewed-by: Jeff Layton <jlayton@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

Merge pull request #30493 from p-se/wip-pse-osd-improvements

mgr/dashboard: OSD improvements

Reviewed-by: Tiago Melo <tmelo@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>

mgr/dashboard: enable run-frontend-unittest.sh to run from any… (#30496)

mgr/dashboard: enable run-frontend-unittest.sh to run from any directory

Reviewed-by: Kiefer Chang <kiefer.chang@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>

mgr/dashboard: Fix error editing iSCSI disk controls (#30100)

mgr/dashboard: Fix error editing iSCSI disk controls

Reviewed-by: Ricardo Dias <rdias@suse.com>

pybind/rados: add application_metadata_get

Signed-off-by: songweibin <song.weibin@zte.com.cn>

test/pybind/test_ceph_argparse.py: add a test for "osd pool create"

Signed-off-by: Kefu Chai <kchai@redhat.com>

mon/MonCommands: improve "osd pool create" command validation

both `expected_num_objects` and `size` are required to be greater or
equal to 0, and monitor will return -EINVAL at seeing a negative value
of either of them. so let's fail earlier.

Signed-off-by: Kefu Chai <kchai@redhat.com>

Merge pull request #30535 from xiexingguo/wip-test_ceph_argparse

test/pybind/test_ceph_argparse.py: pg_num of pool creation now optional

Reviewed-by: Kefu Chai <kchai@redhat.com>

test/pybind: fix local variables for emacs

* pass CEPH_BIN env variable if necessary
* do not 'make' unless necessary
* use `cmake --build` as developer might be using some different cmake
  generator for building ceph.

Signed-off-by: Kefu Chai <kchai@redhat.com>

crush: add editor property variables

so the local settings won't interfere when working on ceph.

Signed-off-by: Kefu Chai <kchai@redhat.com>

test/pybind/test_ceph_argparse.py: pg_num of pool creation now optional

introduced by f88d95bef6948410603bd877aa4714a2afefd5a5

note that we remove the bad pg_num = -1 test too, which will now
be treated as the the crush rule name (invalid but allowed) since
pg_num is optional

Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>

osd/PGLog: reset log.complete_to when recover obect failed

1. Injection read fault, recover failed object is added to the missing set, log.complete_to == log.end()
2. Before the first object recovery, the new object writes, update info.last_update, because num_missing() != 0, so last_complete will not be updated
3. After the first object recovery, PeeringState::recover_got generates the error: ceph_assert(info.last_complete == info.last_update);

Fixed: https://tracker.ceph.com/issues/42019

Signed-off-by: Tao Ning <ningtao@sangfor.com.cn>

Merge PR #30348 into master

* refs/pull/30348/head:
doc: Add a new document on Dynamic Metadata Management in CephFS

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

Merge pull request #30512 from xiexingguo/wip-vstart-inc-osd

vstart: add --inc-osd option

Reviewed-by: Sage Weil <sage@redhat.com>

Merge pull request #30490 from ceph/guits-41392

ceph-volume: do not fail when trying to remove crypt mapper

Reviewed-by: Jan Fajerski <jfajerski@suse.com>
Reviewed-by: Alfredo Deza <adeza@redhat.com>

mon/MonClient: skip CEPHX_V2 challenge if client doesn't support it

If the client doesn't support the CEPHX_V2 challenge, and we don't require
it, skip it.  This allows the client to authenticate without getting an
error like

  cephx: verify_reply couldn't decrypt with error: error decoding block for decryption

Note that we don't have this problem in the monitor exchange in
Monitor::handle_auth_request() because that verify_authorizer() caller is
only used for msgrv2, and all such clients support CEPHX_V2.  Instead,
those client authenticate via the MAuth messages, a path that does not use
authorizers at all.

Fixes: https://tracker.ceph.com/issues/40716
Signed-off-by: Sage Weil <sage@redhat.com>

mgr/dashboard: Display the "destroyed" state in OSD list

Signed-off-by: Tiago Melo <tmelo@suse.com>

qa/tasks/mgr/dashboard/test_health: add "allow_unknown" in mgr_map

tests/functionalities are not broken if we add more fields to mgr_map.

see also #30507

Signed-off-by: Kefu Chai <kchai@redhat.com>

Merge pull request #30507 from tchaikov/wip-mgr-features-in-mgrmap

qa/tasks/mgr/dashboard/test_health: update schema

Reviewed-by: Sage Weil <sage@redhat.com>
Reviewed-by: Alfonso Martínez <almartin@redhat.com>

doc: Add a new document on Dynamic Metadata Management in CephFS

Signed-off-by: Sidharth Anupkrishnan <sanupkri@redhat.com>

Merge PR #30475 into master

* refs/pull/30475/head:
qa/standalone/ceph-helpers: default pg autoscale mode off for standalone
os/bluestore: fix objectstore_blackhole read-after-write
test,misc: do not specify pg_num per pool
mgr/volumes: do not specify pg_num
pybind/ceph_volume_client: do not specify pg_num for new pools
doc: remove all pg_num arguments to 'osd pool create'
mon: do not require pg_num to 'osd pool create'
common: default pg_autoscale_mode=on for new pools

Reviewed-by: xie xingguo <xie.xingguo@zte.com.cn>

Merge PR #30503 into master

* refs/pull/30503/head:
osd/PeeringState: recover_got - add special handler for empty log

Reviewed-by: Sage Weil <sage@redhat.com>

Merge PR #30506 into master

* refs/pull/30506/head:
qa/standalone/osd/divergent-priors: add reproducer for bug 41816

Reviewed-by: xie xingguo <xie.xingguo@zte.com.cn>

mgr/dashboard: Fix spacing between cards (#30461)

mgr/dashboard: Fix spacing between cards

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Kiefer Chang <kiefer.chang@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>

mgr/dashboard: test_mgr_module QA test has not been adapted to latest controller changes

Fixes: https://tracker.ceph.com/issues/41993
Signed-off-by: Volker Theile <vtheile@suse.com>

mgr/dashboard: Improve and simplify OsdListComponent

Signed-off-by: Patrick Seidensal <pseidensal@suse.com>

mgr/dashboard: fix error when linking a bucket to a tenanted u… (#30123)

mgr/dashboard: fix error when linking a bucket to a tenanted user

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Volker Theile <vtheile@suse.com>

mgr/dashboard: OSD list component improvements (#30488)

mgr/dashboard: OSD list component improvements

Reviewed-by: Patrick Seidensal <pnawracay@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>

mgr/dashboard: NFS list should display the "Pseudo Path" (#30395)

mgr/dashboard: NFS list should display the "Pseudo Path"

Reviewed-by: Ricardo Dias <rdias@suse.com>
Reviewed-by: Tiago Melo <tmelo@suse.com>

ceph-volume: do not fail when trying to remove crypt mapper

In a containerized context, at some point, need to run `simple scan` on a device
from a separate container (not the existing and running corresponding container
to that device), but this can't work because when it tries to remove the
mapper which is still in use by the corresponding running osd container,
it fails.
This can be a bit more permissive and simply throw a warning.

Closes: https://tracker.ceph.com/issues/41392
Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>

Merge pull request #30411 from dillaman/wip-41653

rbd-mirror: simplify peer bootstrapping

Reviewed-by: Mykola Golub <mgolub@suse.com>

Merge PR #30428 into master

* refs/pull/30428/head:
doc/dev/developer_guide: fix heading level

Reviewed-by: Sage Weil <sage@redhat.com>
Reviewed-by: J. Eric Ivancich <ivancich@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

Merge PR #30435 into master

* refs/pull/30435/head:
doc: improve developer guide doc

Reviewed-by: Jeff Layton <jlayton@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

Merge PR #30497 into master

* refs/pull/30497/head:
ceph-volume: systemd fix typo in log message

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>