mgr/dashboard: Add NFS frontend services

Signed-off-by: Tiago Melo <tmelo@suse.com>

Merge pull request #26410 from tspmelo/wip-bootstrap-3.4.1

mgr/dashboard: Update bootstrap to v3.4.1

Reviewed-by: Stephan Müller <smueller@suse.com>

Merge pull request #26409 from rhcs-dashboard/fix-tox-ini

mgr/dashboard: fix: tox not detecting deps changes

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Sebastian Wagner <swagner@suse.com>
Reviewed-by: Stephan Müller <smueller@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>

Merge pull request #26210 from falcon78921/wip-mgr-restful-python3

mgr/restful: updated string formatting to str.format()

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

Merge pull request #26315 from tchaikov/wip-fix-Waddress-of-packed-member

msg/msg_types.h: do not cast `ceph_entity_name` to `entity_name_t` for printing

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>

Merge pull request #26380 from tchaikov/wip-split-dashboard-package

deb,rpm,qa: split dashboard package

Reviewed-by: Tim Serong <tserong@suse.com>
Reviewed-by: Sage Weil <sage@redhat.com>

Merge pull request #26419 from cyx1231st/wip-fix-echo

test/crimson: fixes of unittest_seastar_echo

Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #25989 from votdev/feature_36488

mgr/dashboard: Add UI to configure the telemetry mgr plugin

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Laura Paduano <lpaduano@suse.com>
Reviewed-by: Patrick Nawracay <pnawracay@suse.com>
Reviewed-by: Tatjana Dehler <tdehler@suse.com>

Merge pull request #26398 from SUSE/wip-fix-spec-badness

ceph.spec.in: Don't use noarch for mgr module subpackages, fix /usr/lib64/ceph/mgr dir ownership

Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #26393 from zmc/wip-rhel7-deps

install-deps.sh: Fixes for RHEL 7

Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #26411 from liewegas/wip-remove-smart

mgr/smart: remove obsolete smart module

Merge PR #26389 into master

* refs/pull/26389/head:
message/MMonMgrReport: conditionally reencode PGMapDigest
qa/suites/upgrade/luminous-x/parallel: enable all classes
qa/suites/upgrade/luminous-x/parallel/5-final-workload/rados_mon_thrash: use x branch
qa/suites/upgade/luminous-x: pglog_hardlimit succeeds now on luminous due to backport
mgr/DaemonServer: use a luminous-compatible 'mgr metadata' command
mgr/Mgr: print bad (non-object) json
qa/suites/upgrade/luminous-x/stress-split: mons on separate hosts, enable msgr2
qa/suites/upgrade/luminous-x/parallel: mon per host, msgr2
qa/suites/upgrade/luminous-x: whitelist 'slow request'
mon/HealthMonitor: add mon_warn_on_msgr2_not_enabled

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>

message/MMonMgrReport: conditionally reencode PGMapDigest

The encoding changed between luminous and mimic.  Reencode the
structure if the target doesn't have all the features.

Fixes: http://tracker.ceph.com/issues/38295
Signed-off-by: Sage Weil <sage@redhat.com>

qa/suites/upgrade/luminous-x/parallel: enable all classes

Otherwise it's annoying because the class list changes between luminous and nautilus,
and we don't want to futz around with changing this setting during the upgrade.

The problematic classes are 'cas' (added) and 'sdk' (not enabled by default but
included by the cls/ workunit.

Signed-off-by: Sage Weil <sage@redhat.com>

qa/suites/upgrade/luminous-x/parallel/5-final-workload/rados_mon_thrash: use x branch

The luminous version is (1) not what we want and (2) will fail because
ceph_test_rados_api_tier no longer exists in master.

Signed-off-by: Sage Weil <sage@redhat.com>

Merge pull request #26397 from guits/guits-fix_ceph-volume

ceph-volume: update testing playbook 'deploy.yml'

Reviewed-by: Andrew Schoen <aschoen@redhat.com>

mgr/smart: remove

This is obsolete and replaced by the devicehealth module.

Signed-off-by: Sage Weil <sage@redhat.com>

mgr/restful: updated string formatting to str.format()

Made changes per @tchaikov's request

Signed-off-by: James McClune <jmcclune@mcclunetechnologies.net>

qa/suites/upgade/luminous-x: pglog_hardlimit succeeds now on luminous due to backport

Signed-off-by: Sage Weil <sage@redhat.com>

mgr/DaemonServer: use a luminous-compatible 'mgr metadata' command

In luminous it was 'id', in mimic it changed to 'who'.

Signed-off-by: Sage Weil <sage@redhat.com>

mgr/Mgr: print bad (non-object) json

Signed-off-by: Sage Weil <sage@redhat.com>

qa/suites/upgrade/luminous-x/stress-split: mons on separate hosts, enable msgr2

Signed-off-by: Sage Weil <sage@redhat.com>

qa/suites/upgrade/luminous-x/parallel: mon per host, msgr2

- mon per host
- enable msgr2 at the end
- include the nautilus.yaml

Signed-off-by: Sage Weil <sage@redhat.com>

msg/msg_types.h: do not cast `ceph_entity_name` to `entity_name_t` for printing

in GCC-9, `-Waddress-of-packed-member` is enabled, so we have warnings like:

src/msg/msg_types.h:142:41: warning: converting a packed 'const
ceph_entity_name' pointer (alignment 1) to a 'const entity_name_t'
pointer (alignment 8) may result in an unaligned pointer value
[-Waddress-of-packed-member]
  142 |   return out << *(const entity_name_t*)&addr;
      |                                         ^~~~

since the alignment of these two structures are different, we cannot
cast a structure with the alignment of 1 to a structure with the
alignment of 8. as the code generated by compiler accessing the members
of alignment 8 won't work with the members of alignment 1, we need to
create a temporary structure for printing it.

Signed-off-by: Kefu Chai <kchai@redhat.com>

Merge pull request #26406 from drunkard/master

doc: typo fixes, s/Requered/Required/

Reviewed-by: Kefu Chai <kchai@redhat.com>

mgr/dashboard: Update bootstrap to v3.4.1

This update fixes an XSS vulnerability (CVE-2019-8331)

Signed-off-by: Tiago Melo <tmelo@suse.com>

mgr/dashboard: fix: tox not detecting deps changes

* tox.ini: replaced 'deps' setting by appropriate commands
  due to this bug:
  https://github.com/tox-dev/tox/issues/149
  tox is not detecting changes in requirements.txt when using
  'deps' setting in 'tox.ini'.

Signed-off-by: Alfonso Martínez <almartin@redhat.com>

Merge pull request #26325 from jtlayton/wip-jlayton-dashboard-orch

mgr/dashboard: use the orchestrator_cli backend setting

Reviewed-by: Ricardo Dias <rdias@suse.com>
Reviewed-by: Sebastian Wagner <swagner@suse.com>
Reviewed-by: Sage Weil <sage@redhat.com>
Reviewed-by: Volker Theile <vtheile@suse.com>

doc: typo fixes, s/Requered/Required/

Signed-off-by: Drunkard Zhang <gongfan193@gmail.com>

qa: exclude new packages when installing old versions

ceph-mgr-dashboard is introduced in nautilus, so exclude it when
installing old versions.

Signed-off-by: Kefu Chai <kchai@redhat.com>

rpm: split ceph-mgr-dashboard plugin into its own package

to make ceph-mgr-dashboard a separated package

- helps to reduce the repo size of downstream. because
  ceph-mgr-dashboard is an architecture independent package. by
  making it separated package avoids needless duplication of
  the same data in mutiple .debs.
- gives user a fine grained control of selection.

Signed-off-by: Kefu Chai <kchai@redhat.com>

Merge pull request #26390 from smithfarm/wip-doc-mgr-dashboard

doc: add Ceph Manager Dashboard to top-level TOC

Reviewed-by: Lenz Grimmer <lgrimmer@suse.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>

qa/suites/upgrade/luminous-x: whitelist 'slow request'

The luminous warnings say slow request.

Signed-off-by: Sage Weil <sage@redhat.com>

mon/HealthMonitor: add mon_warn_on_msgr2_not_enabled

Default true, but allow users (or tests) to turn this warning off.

Signed-off-by: Sage Weil <sage@redhat.com>

Merge PR #26265 into master

* refs/pull/26265/head:
qa/suites/rados/upgrade: whitelist 'slow request'

Reviewed-by: Yuri Weinstein <yweins@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>

Merge PR #26366 into master

* refs/pull/26366/head:
os/filestore: ceph_abort() on fsync(2) or fdatasync(2) failure

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: Jeff Layton <jlayton@redhat.com>
Reviewed-by: Greg Farnum <gfarnum@redhat.com>

Merge PR #26369 into master

* refs/pull/26369/head:
ceph-mon: slightly more helpful output during mkfs

Reviewed-by: Neha Ojha <nojha@redhat.com>

Merge PR #26391 into master

* refs/pull/26391/head:
buffer: disable hypercombining in bufferlist.

Reviewed-by: Sage Weil <sage@redhat.com>

Merge PR #26392 into master

* refs/pull/26392/head:
messages/MMonMgrReport: fix compat decoding

Reviewed-by: Neha Ojha <nojha@redhat.com>
Reviewed-by: Josh Durgin <jdurgin@redhat.com>

ceph-volume: update deploy.yml

update deploy.yml accordingly with recent changes in ceph-ansible.

Fixes: ceph/ceph-ansible#3602
Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>

ceph.spec.in: Make ceph-mgr own /usr/lib64/ceph/mgr directory

Without this, no package actually owns the /usr/lib64/ceph/mgr directory
so the build fails with "directories not owned by a package" errors for
ceph-mgr, ceph-mgr-diskprediction-local, ceph-mgr-diskprediction-cloud
and ceph-mgr-rook.

Signed-off-by: Tim Serong <tserong@suse.com>

ceph.spec.in: Don't use noarch for ceph-mgr module subpackages

Even though ceph-mgr modules are notionally non-architecture-specific,
the files themselves are installed to an architecture-specific path
(/usr/lib64/ceph/mgr/....), which causes the build to fail on SUSE
distros with a huge long list of errors like:

ceph-mgr-diskprediction-cloud.noarch: E: suse-filelist-forbidden-noarch
(Badness: 10000) /usr/lib64/ceph/mgr/diskprediction_cloud is not
allowed in a noarch package
[...]
(none): E: badness 1120287 exceeds threshold 1000, aborting.

Signed-off-by: Tim Serong <tserong@suse.com>

Merge pull request #26367 from tspmelo/wip-iscsi-edit-ui

mgr/dashboard: Add iSCSI Target Edit UI

Reviewed-by: Ricardo Marques <rimarques@suse.com>

Merge pull request #26346 from noahdesu/mgr-orch-cache-refresh

mgr/orch: refresh option for inventory query

Reviewed-by: Sebastian Wagner <sebastian.wagner@suse.com>

Merge pull request #26357 from rjfd/wip-orch-fix-dev-pretty-print

mgr/orchestrator: fix device pretty print with None attributes

Reviewed-by: Sebastian Wagner <sebastian.wagner@suse.com>

Merge pull request #26384 from tspmelo/wip-e2e-login

mgr/dashboard: Add implicit wait in e2e tests

Reviewed-by: Laura Paduano <lpaduano@suse.com>

debian: split ceph-mgr-dashboard plugin into its own package

to make ceph-mgr-dashboard a separated package

- helps to reduce the repo size of downstream. because
  ceph-mgr-dashboard is an architecture independent package. by
  making it separated package avoids needless duplication of
  the same data in mutiple .debs.
- gives user a fine grained control of selection.

Signed-off-by: Kefu Chai <kchai@redhat.com>

Merge pull request #26379 from tchaikov/wip-remove-jinja2

rpm,deb: remove python-jinja2 dependency

Reviewed-by: Lenz Grimmer <lgrimmer@suse.com>
Reviewed-by: Ken Dreyer <kdreyer@redhat.com>

crimson/net: msgr default to v1 in test_alien_echo

Signed-off-by: Yingxin Cheng <yingxincheng@gmail.com>

crimson/net: fix nonce setting in test_alien_echo

Signed-off-by: Yingxin Cheng <yingxincheng@gmail.com>

crimson/net: fix var capture in test_alien_echo

Signed-off-by: Yingxin Cheng <yingxincheng@gmail.com>

install-deps.sh: Fixes for RHEL 7

Signed-off-by: Zack Cerza <zack@redhat.com>

mgr/dashboard: Add implicit wait in e2e tests

Fixes: https://tracker.ceph.com/issues/38269
Signed-off-by: Tiago Melo <tmelo@suse.com>

Merge PR #26385 into master

* refs/pull/26385/head:
mon: mons also connect to mgrs

Reviewed-by: Sage Weil <sage@redhat.com>
Reviewed-by: João Eduardo Luís <joao@suse.de>

messages/MMonMgrReport: fix compat decoding

Broken by 08d1a6fc3c57ccbeb6dff8fce1aae429edca97f3

Signed-off-by: Sage Weil <sage@redhat.com>

Merge pull request #26377 from tchaikov/wip-mgr-plugin-arch-all

debian/control: change Architecture python plugins to "all"

Merge pull request #26246 from leseb/cb-typo

ceph-volume: add space between words

Reviewed-by: Andrew Schoen <aschoen@redhat.com>

Merge pull request #26337 from dillaman/wip-37998

librbd: get_parent API method should properly handle migrating image

Reviewed-by: Mykola Golub <mgolub@suse.com>

Merge pull request #26368 from alfredodeza/wip-rm38261

build: further removal of `subman` configuration

Reviewed-by: Ken Dreyer <kdreyer@redhat.com>
Reviewed-by: Kefu Chai <tchaikov@gmail.com>

doc: add Ceph Manager Dashboard to top-level TOC

Signed-off-by: Nathan Cutler <ncutler@suse.com>

buffer: disable hypercombining in bufferlist.

We're seeing various failures like:

      * http://tracker.ceph.com/issues/38024,
      * http://tracker.ceph.com/issues/38230,
      * http://tracker.ceph.com/issues/37910

without a clear cause. Disabling hypercombining makes at least one
reproducer happy.

Fixes: http://tracker.ceph.com/issues/38024
Fixes: http://tracker.ceph.com/issues/38230
Fixes: http://tracker.ceph.com/issues/37910
Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>

test/crimson: should not capture temporary variables

otherwise, we are passing dangling pointers down to
`app_template::run()`.

Signed-off-by: Kefu Chai <kchai@redhat.com>

test/crimson: always use "async" for alien msgr

avoid reading from conf as it is not populated yet without calling
`ceph::common::sharded_conf().start()` first.

Signed-off-by: Kefu Chai <kchai@redhat.com>

rbd: added missing feature bitmask to name mapping

Signed-off-by: Jason Dillaman <dillaman@redhat.com>

rbd: removed migration source annotation from parent info

Signed-off-by: Jason Dillaman <dillaman@redhat.com>

mgr/dashboard: Add UI to configure the telemetry mgr plugin

Fixes: tracker.ceph.com/issues/36488
Signed-off-by: Volker Theile <vtheile@suse.com>

Merge PR #26340 into master

* refs/pull/26340/head:
osd/OSD: respect osdmap message limits
mon/OSDMonitor: limit MOSDMap message size by bytes
common/options: add osd_map_message_max_bytes

Reviewed-by: Josh Durgin <jdurgin@redhat.com>

Merge PR #26365 into master

* refs/pull/26365/head:
msg/async/ProtocolV2: refuse incoming reconnect attempt intended for someone else
msg/async/ProtocolV2: refuse incoming connection intended for someone else

Reviewed-by: Ricardo Dias <rdias@suse.com>

Merge PR #26363 into master

* refs/pull/26363/head:
ceph.spec.in: python-kubernetes broken on rhel

Reviewed-by: Brad Hubbard <bhubbard@redhat.com>
Reviewed-by: Jeff Layton <jlayton@redhat.com>

Merge pull request #26323 from LenzGr/pools-typo

mgr/dashboard: Fix typo in pools management

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Volker Theile <vtheile@suse.com>
Reviewed-by: Tatjana Dehler <tdehler@suse.com>
Reviewed-by: Patrick Nawracay <pnawracay@suse.com>
Reviewed-by: Stephan Müller <smueller@suse.com>

mon: mons also connect to mgrs

Signed-off-by: Ricardo Dias <rdias@suse.com>

mgr/dashboard: Add iSCSI target edit UI

Fixes: http://tracker.ceph.com/issues/38014
Signed-off-by: Tiago Melo <tmelo@suse.com>

Merge pull request #26320 from tspmelo/wip-iscsi-discovery-ui

mgr/dashboard: Add iSCSI discovery authentication UI

Reviewed-by: Ricardo Marques <rimarques@suse.com>
Reviewed-by: Tatjana Dehler <tdehler@suse.com>

Merge pull request #26383 from tchaikov/wip-auth-common-cleanup

auth, common: cleanups

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>

mgr/dashboard: use orchestrator_cli to figure out the backend

Currently the dashboard has its own setting for the orchestrator
backend, which means that one has to set it in both the dashboard and
the orchestrator_cli module if you intend to use both.

Change the dashboard code to use the setting in the orchestrator_cli
module, and eliminate the dashboard-specific setting.

Signed-off-by: Jeff Layton <jlayton@redhat.com>

mgr: make orchestrator_cli be always-on

The volumes module has at least a loose dependency on the orchestrator,
and thus also relies on the orchestrator_cli module for the backend
setting. Since the volumes module is always-on, do the same with the
orchestrator_cli module.

Signed-off-by: Jeff Layton <jlayton@redhat.com>

mgr/volumes: properly handle NoOrchestrator exception

Signed-off-by: Jeff Layton <jlayton@redhat.com>

mgr/orchestrator: don't have _select_orchestrator raise exceptions

This is problematic as this usually gets invoked via the Mgr remote
method, which will clobber any exception with a RuntimeError.

Instead, just have it return None if one isn't configured, and have the
callers raise the exception if necessary.

Signed-off-by: Jeff Layton <jlayton@redhat.com>

mgr/orchestrator: move NoOrchestrator definition to base orchestrator.py

Signed-off-by: Jeff Layton <jlayton@redhat.com>

Merge pull request #26221 from cyx1231st/wip-seastar-msgr-perf

crimson/net: misc fixes and features for crimson-messenger tests

Reviewed-by: Kefu Chai <kchai@redhat.com>

mon/MonClient: forward declare AuthRegistry instead of #include it

to speed up the compilation.

Signed-off-by: Kefu Chai <kchai@redhat.com>

common/ceph_context: hardwire module_type to CEPH_ENTITY_TYPE_OSD

currently, crimson project is only targeting crimson-osd.

Signed-off-by: Kefu Chai <kchai@redhat.com>

auth/AuthServer: fix typo in comments

Signed-off-by: Kefu Chai <kchai@redhat.com>

crimson/net: crimson messenger performance test tool

Support the following settings:
* mode: both, client mode, server mode;
* set server address;
* rounds of messages;
* keepalive-ratio;
* block size;
* io-depth;

Signed-off-by: Yingxin Cheng <yingxincheng@gmail.com>

crimson/net: improve UT performance and added timing

Signed-off-by: Yingxin Cheng <yingxincheng@gmail.com>

Merge pull request #26243 from nathan-weinberg/block-tabs

mgr/dashboard: Added tab tests to Block menu items

Reviewed-by: Laura Paduano <lpaduano@suse.com>
Reviewed-by: Tiago Melo <tmelo@suse.com>

Merge pull request #26364 from tchaikov/wip-test-silence-warnings

test/rgw: silence -Wsign-compare warnings

Reviewed-by: Abhishek Lekshmanan <abhishek@suse.com>

mgr/dashboard: Add iSCSI discovery authentication UI

Fixes: https://tracker.ceph.com/issues/38021
Signed-off-by: Tiago Melo <tmelo@suse.com>

mgr/dashboard: Fix order of table buttons

"float:none" is changing  the order of the table buttons.
By reverting this change and setting .oadatatableactions to "float:left",
we get the same result as intended before.

Signed-off-by: Tiago Melo <tmelo@suse.com>

Merge pull request #26319 from tspmelo/wip-iscsi-service-spec

mgr/dashboard: Fix iSCSI service unit tests

Reviewed-by: Ricardo Marques <rimarques@suse.com>

rpm,deb: remove python-jinja2 dependency

python-jinja2 dependency was added for the dashboard v1 in 87399bea. but
dashboard v2, which is now known as "dashboard" has taken the place of
the old dashboard. and dashboard now does not use jinja2, so we should
drop this dependency.

Signed-off-by: Kefu Chai <kchai@redhat.com>

crimson/net: fix memory leak

Do not enqueue sent before lossless policy implemented, it is causing
memory leak.

Signed-off-by: Yingxin Cheng <yingxincheng@gmail.com>

crimson/net: port sharded-msgr to existing code

Port sharded-msgr to crimson osd, monc, heartbeat and tests with
compatible mode.

Signed-off-by: Yingxin Cheng <yingxincheng@gmail.com>

crimson/net: promote policy related method to Messenger

Signed-off-by: Yingxin Cheng <yingxincheng@gmail.com>

crimson/net: compatible mode of crimson-msgr

Added a compatible mode with master_sid to support single-core
dispatcher.

Signed-off-by: Yingxin Cheng <yingxincheng@gmail.com>

crimson/net: suppress info logs for frequent keepalive

The new unittest_seastar_messenger will print out the count of keepalive
attempts at the end of the execution.

Signed-off-by: Yingxin Cheng <yingxincheng@gmail.com>

crimson/net: enable connections on all cores

Implement the sharded crimson-messenger:

* Sharded Messenger: provides shared-nothing Messenger for each shard,
  it's interfaces are symmetric to be called, any modifications will be
  applied to all shards.

* Sharded/non-sharded Dispatcher interface: allow connections to be
  dispatched, and related resources (such as Session) to be managed in
  its own shard or not.

* Sharded Connection: A connection only lives at one dedicated core
  during its lifecycle. It's sharded by its peer_IP in this PoC, because
  peer port and nonce are not available when a socket is accepted. While
  its interfaces are safe to be called from all shards.

* Replace `boost::intrusive_ptr` by seastar native smart ptrs for
  `Connection` and `SocketConnection`, because they need to be
  destructed from its original core.

* Unit test: establish multiple connections on both client and server
  sides, they runs concurrently and creates sessions that are also
  following shared-nothing design.

Signed-off-by: Yingxin Cheng <yingxincheng@gmail.com>

debian/control: change Architecture python plugins to "all"

change following plugins' Architecture to "all", as they are pure python
plugins, and are architecture-independent packages.

- ceph-mgr-diskprediction-cloud
- ceph-mgr-diskprediction-local
- ceph-mgr-rook

this also matches their couterparts in ceph.spec.in, where we have
```
BuildArch:  noarch
```

Signed-off-by: Kefu Chai <kchai@redhat.com>

mgr/orchestrator: fix device pretty-print, added unit test

Signed-off-by: Ricardo Dias <rdias@suse.com>

Merge pull request #26255 from tchaikov/wip-crimson-hb

crimson/osd: add more heartbeat peers

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>