]> git.apps.os.sepia.ceph.com Git - ceph.git/log
ceph.git
3 years agorbd-mirror: make mirror properly detect pool replayer needs restart 45086/head
Mykola Golub [Fri, 18 Feb 2022 10:42:23 +0000 (10:42 +0000)]
rbd-mirror: make mirror properly detect pool replayer needs restart

When a PoolReplayer detects remote pool metadata change it
sets "stopping" flag expecting the Mirror will restart it.

Although setting "stopping" flag makes the PoolReplayer::run
thread to terminate, the thread's is_started function will still
return true until join is called (and reset the thread id).

This made impossible for the Mirror to detect (by calling
PoolReplayer::is_running) that the PoolReplayer needed restart.

Fixes: https://tracker.ceph.com/issues/54258
Signed-off-by: Mykola Golub <mgolub@suse.com>
3 years agoMerge pull request #44933 from liu-chunmei/seastore-support-sparse-read
Samuel Just [Thu, 17 Feb 2022 22:40:27 +0000 (14:40 -0800)]
Merge pull request #44933 from liu-chunmei/seastore-support-sparse-read

crimson/seastore: support sparse_read

Reviewed-by: Samuel Just <sjust@redhat.com>
3 years agoMerge pull request #44955 from aclamk/wip-vselector-check-fix
Neha Ojha [Thu, 17 Feb 2022 18:26:10 +0000 (10:26 -0800)]
Merge pull request #44955 from aclamk/wip-vselector-check-fix

os/bluestore/bluefs: Fix improper vselector tracking in _flush_special()

Reviewed-by: Igor Fedotov <igor.fedotov@croit.io>
3 years agocrimson/seastore: put ObjectDataHandler instance into do_with 44933/head
chunmei-liu [Wed, 16 Feb 2022 03:13:15 +0000 (19:13 -0800)]
crimson/seastore: put ObjectDataHandler instance into do_with

make ObjectDataHandler instance alive before sub functions are resolved.

Signed-off-by: chunmei-liu <chunmei.liu@intel.com>
3 years agocrimson/seastore:: add fiemap and sparse read unit test
chunmei-liu [Sat, 12 Feb 2022 21:36:33 +0000 (13:36 -0800)]
crimson/seastore:: add fiemap and sparse read unit test

Signed-off-by: chunmei-liu <chunmei.liu@intel.com>
3 years agocrimson/seastore: support sparse_read
chunmei-liu [Mon, 7 Feb 2022 22:34:33 +0000 (14:34 -0800)]
crimson/seastore: support sparse_read

add fiemap and readv functions.

Signed-off-by: chunmei-liu <chunmei.liu@intel.com>
3 years agoMerge pull request #45057 from zdover23/wip-doc-2022-02-17-os-recs-nautilus-and-lumin...
zdover23 [Thu, 17 Feb 2022 10:19:35 +0000 (20:19 +1000)]
Merge pull request #45057 from zdover23/wip-doc-2022-02-17-os-recs-nautilus-and-luminous-table-removal

doc/start: remove L and N release-related tables

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
3 years agoMerge pull request #45049 from liu-chunmei/crimson-clang-warning-cleanup
Samuel Just [Wed, 16 Feb 2022 20:07:56 +0000 (12:07 -0800)]
Merge pull request #45049 from liu-chunmei/crimson-clang-warning-cleanup

crimson: eliminate clang build warning in crimson

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Reviewed-by: Ronen Friedman <rfriedma@redhat.com>
3 years agocrimson: eliminate clang build warning in crimson 45049/head
chunmei-liu [Wed, 16 Feb 2022 05:06:24 +0000 (21:06 -0800)]
crimson: eliminate clang build warning in crimson

Signed-off-by: chunmei-liu <chunmei.liu@intel.com>
3 years agodoc/start: remove L and N release-related tables 45057/head
Zac Dover [Wed, 16 Feb 2022 15:21:44 +0000 (01:21 +1000)]
doc/start: remove L and N release-related tables

This PR removes the tables for Luminous and Nautilus,
in order to keep the documentation as current as possible.
This is one a series of PRs intended to update the OS
Recommendations page. The scope of this PR is confined to
the removal of these two tables. Other PRs will update the
information elsewhere on the OS Recommendations page.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
3 years agoMerge pull request #45045 from idryomov/wip-qemu-task-rbd-package
Ilya Dryomov [Wed, 16 Feb 2022 13:15:24 +0000 (14:15 +0100)]
Merge pull request #45045 from idryomov/wip-qemu-task-rbd-package

qa/tasks/qemu: make sure block-rbd.so is installed

Reviewed-by: Deepika Upadhyay <dupadhya@redhat.com>
3 years agoqa/suites/rbd: make sure block-rbd.so is installed 45045/head
Ilya Dryomov [Wed, 16 Feb 2022 09:32:26 +0000 (10:32 +0100)]
qa/suites/rbd: make sure block-rbd.so is installed

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
3 years agoMerge pull request #45021 from idryomov/wip-groupsnapns-operator-less
Ilya Dryomov [Wed, 16 Feb 2022 10:32:10 +0000 (11:32 +0100)]
Merge pull request #45021 from idryomov/wip-groupsnapns-operator-less

cls/rbd: GroupSnapshotNamespace comparator violates ordering rules

Reviewed-by: Mykola Golub <mgolub@suse.com>
Reviewed-by: Sunny Kumar <sunkumar@redhat.com>
3 years agoMerge pull request #45020 from rhcs-dashboard/snmp-priv-protocol-fix
Avan [Wed, 16 Feb 2022 09:52:26 +0000 (15:22 +0530)]
Merge pull request #45020 from rhcs-dashboard/snmp-priv-protocol-fix

mgr/dashboard: change privacy protocol field from required to optional

3 years agoMerge pull request #44659 from ifed01/wip-ifed-alloc-replay-boind-size
Igor Fedotov [Wed, 16 Feb 2022 09:50:08 +0000 (12:50 +0300)]
Merge pull request #44659 from ifed01/wip-ifed-alloc-replay-boind-size

test/alloc_replay_test: be able to cap allocator space with capacity …

Reviewed-by: Adam Kupczyk <akupczyk@redhat.com>
3 years agoos/bluestore/bluefs: Fix vselector 44955/head
Adam Kupczyk [Tue, 15 Feb 2022 22:13:59 +0000 (23:13 +0100)]
os/bluestore/bluefs: Fix vselector

Fix bluefs volume selector in device_migrate_to_existing.
Fix bluefs volume selector in _rewrite_log_and_layout_sync_LNF_LD.

Fixes: https://tracker.ceph.com/issues/54248
Signed-off-by: Adam Kupczyk <akupczyk@redhat.com>
3 years agoMerge pull request #44997 from pcfe/pcfe-add-cos9-instructions 38123/head
Adam King [Tue, 15 Feb 2022 19:09:31 +0000 (14:09 -0500)]
Merge pull request #44997 from pcfe/pcfe-add-cos9-instructions

doc/cephadm: Add CentOS Stream install instructions

Reviewed-by: Adam King <adking@redhat.com>
3 years agodoc/cephadm: Add CentOS Stream install instructions 44997/head
Patrick C. F. Ernzer [Sun, 13 Feb 2022 01:05:44 +0000 (02:05 +0100)]
doc/cephadm: Add CentOS Stream install instructions

Signed-off-by: Patrick C. F. Ernzer <pcfe@pcfe.net>.
3 years agoMerge pull request #44988 from caisan/FixRGWLogStringError
Casey Bodley [Tue, 15 Feb 2022 14:29:12 +0000 (09:29 -0500)]
Merge pull request #44988 from caisan/FixRGWLogStringError

Fix rgw data sync log info error

Reviewed-by: Yehuda Sadeh <ysadehwe@redhat.com>
3 years agomgr/dashboard: add validation for snmp v3 engine id 45020/head
Avan Thakkar [Tue, 15 Feb 2022 13:13:36 +0000 (18:43 +0530)]
mgr/dashboard: add validation for snmp v3 engine id

Fixes: https://tracker.ceph.com/issues/54270
Signed-off-by: Avan Thakkar <athakkar@redhat.com>
3 years agoqa/tasks/qemu: make sure block-rbd.so is installed
Ilya Dryomov [Tue, 15 Feb 2022 13:57:51 +0000 (14:57 +0100)]
qa/tasks/qemu: make sure block-rbd.so is installed

Fixes: https://tracker.ceph.com/issues/54286
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
3 years agoMerge pull request #45032 from ceph/revert-45018
David Galloway [Tue, 15 Feb 2022 13:55:31 +0000 (08:55 -0500)]
Merge pull request #45032 from ceph/revert-45018

Revert "admin/doc-requirements: pin breathe to 4.32.0"

3 years agoMerge pull request #44951 from votdev/issue_54215_expand_cluster
Ernesto Puerta [Tue, 15 Feb 2022 10:58:49 +0000 (11:58 +0100)]
Merge pull request #44951 from votdev/issue_54215_expand_cluster

mgr/dashboard: "Please expand your cluster first" shouldn't be shown if cluster is already meaningfully running

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Tatjana Dehler <tdehler@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>
3 years agoMerge pull request #43588 from lxbsz/fsize_support
Venky Shankar [Tue, 15 Feb 2022 09:18:34 +0000 (14:48 +0530)]
Merge pull request #43588 from lxbsz/fsize_support

mds: add truncate size handling support for fscrypt

Reviewed-by: Venky Shankar <vshankar@redhat.com>
3 years agoMerge pull request #45011 from tchaikov/librados/cleanup
Ilya Dryomov [Mon, 14 Feb 2022 23:16:14 +0000 (00:16 +0100)]
Merge pull request #45011 from tchaikov/librados/cleanup

include/rados/librados.h: drop duplicated function declaration

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
3 years agoadmin/doc-requirements.txt: Not breathe=4.33 45032/head
David Galloway [Mon, 14 Feb 2022 20:11:58 +0000 (15:11 -0500)]
admin/doc-requirements.txt: Not breathe=4.33

See https://github.com/michaeljones/breathe/issues/803

Signed-off-by: David Galloway <dgallowa@redhat.com>
3 years agoRevert "admin/doc-requirements: pin breathe to 4.32.0"
David Galloway [Mon, 14 Feb 2022 19:38:16 +0000 (14:38 -0500)]
Revert "admin/doc-requirements: pin breathe to 4.32.0"

This reverts commit d020d07be97c56db88fadd9921e7b3eff11c0802.

Fixed upstream https://github.com/michaeljones/breathe/issues/803#issuecomment-1039341857

Signed-off-by: David Galloway <dgalloway@redhat.com>
3 years agoMerge pull request #44779 from rkachach/fix_issue_53010
Adam King [Mon, 14 Feb 2022 17:35:15 +0000 (12:35 -0500)]
Merge pull request #44779 from rkachach/fix_issue_53010

mgr/cephadm: Adding logic to cleanup several ceph dirs (rm-cluster)

Reviewed-by: Adam King <adking@redhat.com>
3 years agoMerge pull request #45014 from guits/fix-cephadm-ingress
Adam King [Mon, 14 Feb 2022 17:29:36 +0000 (12:29 -0500)]
Merge pull request #45014 from guits/fix-cephadm-ingress

cephadm/ingress: make frontend stats bind on localhost

Reviewed-by: Adam King <adking@redhat.com>
3 years agoMerge pull request #44794 from rzarzynski/wip-common-fix-numa-warning
Yuri Weinstein [Mon, 14 Feb 2022 17:06:28 +0000 (09:06 -0800)]
Merge pull request #44794 from rzarzynski/wip-common-fix-numa-warning

common: fix compilation warnings in numa.cc

Reviewed-by: Ronen Friedman <rfriedma@redhat.com>
3 years agoMerge pull request #44781 from ljflores/wip-basic-channel-additions
Yuri Weinstein [Mon, 14 Feb 2022 17:06:00 +0000 (09:06 -0800)]
Merge pull request #44781 from ljflores/wip-basic-channel-additions

mgr/telemetry: add `basic_pool_usage` and `basic_usage_by_class` collections to the telemetry module

Reviewed-by: Yaarit Hatuka <yaarit@redhat.com>
3 years agoMerge pull request #44746 from ljflores/wip-telemetry-down-osd-fix
Yuri Weinstein [Mon, 14 Feb 2022 17:04:33 +0000 (09:04 -0800)]
Merge pull request #44746 from ljflores/wip-telemetry-down-osd-fix

mgr/telemetry: collect what we can from histograms, mempools, and heap stats

Reviewed-by: Yaarit Hatuka <yaarit@redhat.com>
3 years agoMerge pull request #44670 from rzarzynski/wip-common-dout-gcc12-ftbfs
Yuri Weinstein [Mon, 14 Feb 2022 17:03:51 +0000 (09:03 -0800)]
Merge pull request #44670 from rzarzynski/wip-common-dout-gcc12-ftbfs

common: fix FTBFS due to dout & need_dynamic on GCC-12

Reviewed-by: Kefu Chai <kchai@redhat.com>
3 years agoMerge pull request #44983 from cbodley/wip-52673
Yuri Weinstein [Mon, 14 Feb 2022 17:02:51 +0000 (09:02 -0800)]
Merge pull request #44983 from cbodley/wip-52673

rgw: remove rgw_rados_pool_pg_num_min and its use on pool creation

Reviewed-by: Neha Ojha <nojha@redhat.com>
3 years agoos/bluestore/bluefs: Fix improper vselector tracking in _flush_special()
Adam Kupczyk [Wed, 9 Feb 2022 15:19:56 +0000 (16:19 +0100)]
os/bluestore/bluefs: Fix improper vselector tracking in _flush_special()

Moves vselector size tracking outside _flush_special().
Function _compact_log_async...() updated sizes twice.
Problem could not be solved by making second modification of size just update,
as it will possibly disrupt vselector consistency check (_vselector_check()).
Feature to track vselector consistency relies on the fact that either log.lock or nodes.lock
are taken when the check is performed. Which is not true for _compact_log_async...().

Now _flush_special does not update vselector sizes by itself but leaves the update to
the caller.

Fixes: https://tracker.ceph.com/issues/54248
Signed-off-by: Adam Kupczyk <akupczyk@redhat.com>
3 years agoMerge pull request #44917 from guits/fix_rook_smoke_nvme_loop
Adam King [Mon, 14 Feb 2022 15:55:36 +0000 (10:55 -0500)]
Merge pull request #44917 from guits/fix_rook_smoke_nvme_loop

qa/orch: use hwe kernel in rook/smoke tests (ubuntu 20.04)

Reviewed-by: Neha Ojha nojha@redhat.com
Reviewed-by: Yuri Weinstein yweinste@redhat.com
3 years agoMerge pull request #45018 from tchaikov/wip-doc-breathe
David Galloway [Mon, 14 Feb 2022 15:44:34 +0000 (10:44 -0500)]
Merge pull request #45018 from tchaikov/wip-doc-breathe

admin/doc-requirements: pin breathe to 4.32.0

3 years agomgr/dashboard: change privacy protocol field from required to optional
Avan Thakkar [Mon, 14 Feb 2022 12:18:39 +0000 (17:48 +0530)]
mgr/dashboard: change privacy protocol field from required to optional

Fixes: https://tracker.ceph.com/issues/54270
Signed-off-by: Avan Thakkar <athakkar@redhat.com>
Privacy protocol field shouldn't be a required field.

3 years agocephadm/ingress: make frontend stat bind on localhost 45014/head
Guillaume Abrioux [Fri, 11 Feb 2022 16:39:18 +0000 (17:39 +0100)]
cephadm/ingress: make frontend stat bind on localhost

The current configuration of keepalived makes it do
a curl on localhost:9999 in order to check the endpoint is alive.
Given the endpoint only binds on the vip addr, that doesn't work.

Fixes: https://tracker.ceph.com/issues/53807
Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
3 years agoMerge pull request #44965 from adk3798/test_cli_timeout
Adam King [Mon, 14 Feb 2022 13:24:32 +0000 (08:24 -0500)]
Merge pull request #44965 from adk3798/test_cli_timeout

qa/tasks/cephadm_cases: increase timeouts in test_cli.py

Reviewed-by: Michael Fritch mfritch@suse.com
3 years agocls/rbd: GroupSnapshotNamespace comparator violates ordering rules 45021/head
Ilya Dryomov [Mon, 14 Feb 2022 12:04:00 +0000 (13:04 +0100)]
cls/rbd: GroupSnapshotNamespace comparator violates ordering rules

For

  GroupSnapshotNamespace a(1, "group-1", "snap-2");
  GroupSnapshotNamespace b(1, "group-2", "snap-1");

both a < b and b < a evaluate to true.  This violates STL strict weak
ordering requirements which is a problem because GroupSnapshotNamespace
is used as a key in std::map (ictx->snap_ids at least), etc.

Fixes: https://tracker.ceph.com/issues/49792
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
3 years agoadmin/doc-requirements: pin breathe to 4.32.0 45018/head
Kefu Chai [Mon, 14 Feb 2022 10:25:26 +0000 (18:25 +0800)]
admin/doc-requirements: pin breathe to 4.32.0

in breathe v4.33, it includes following commit

https://github.com/michaeljones/breathe/commit/2498a437234343503e0087cad793c6f333f1f781

which specfies the app config value of "graphviz_dot". this annoys
sphinx:

WARNING: while setting up extension breathe: node class 'graphviz' is already registered, its visitors will be overridden

Traceback (most recent call last):
  File "/home/docs/checkouts/readthedocs.org/user_builds/ceph/envs/44951/lib/python3.8/site-packages/sphinx/cmd/build.py", line 276, in build_main
    app = Sphinx(args.sourcedir, args.confdir, args.outputdir,
  File "/home/docs/checkouts/readthedocs.org/user_builds/ceph/envs/44951/lib/python3.8/site-packages/sphinx/application.py", line 245, in __init__
    self.setup_extension(extension)
  File "/home/docs/checkouts/readthedocs.org/user_builds/ceph/envs/44951/lib/python3.8/site-packages/sphinx/application.py", line 402, in setup_extension
    self.registry.load_extension(self, extname)
  File "/home/docs/checkouts/readthedocs.org/user_builds/ceph/envs/44951/lib/python3.8/site-packages/sphinx/registry.py", line 430, in load_extension
    metadata = setup(app)
  File "/home/docs/checkouts/readthedocs.org/user_builds/ceph/envs/44951/lib/python3.8/site-packages/breathe/__init__.py", line 14, in setup
    renderer_setup(app)
  File "/home/docs/checkouts/readthedocs.org/user_builds/ceph/envs/44951/lib/python3.8/site-packages/breathe/renderer/sphinxrenderer.py", line 2613, in setup
    app.add_config_value("graphviz_dot", "dot", "html")
  File "/home/docs/checkouts/readthedocs.org/user_builds/ceph/envs/44951/lib/python3.8/site-packages/sphinx/application.py", line 535, in add_config_value
    self.config.add(name, default, rebuild, types)
  File "/home/docs/checkouts/readthedocs.org/user_builds/ceph/envs/44951/lib/python3.8/site-packages/sphinx/config.py", line 282, in add
    raise ExtensionError(__('Config value %r already present') % name)
sphinx.errors.ExtensionError: Config value 'graphviz_dot' already present

Extension error:
Config value 'graphviz_dot' already present

this issue has been reported to upstream, see
https://github.com/michaeljones/breathe/issues/803

before it is fixed upstream, let's stick with 4.32.0
which is known to work.

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
3 years agomgr/dashboard: "Please expand your cluster first" shouldn't be shown if cluster is... 44951/head
Volker Theile [Wed, 9 Feb 2022 08:37:48 +0000 (09:37 +0100)]
mgr/dashboard: "Please expand your cluster first" shouldn't be shown if cluster is already meaningfully running

This PR will assume that a cluster is already up and fully running. If this should not be the expected behaviour, deployment tools have to set 'INSTALLED' explicitly. Without this assumption it might happen that upgraded and fully running clusters, e.g. Octopus -> Pacific, will show the 'Expand Cluster' on first log in.

cephadm will take care that the bootstrap phase will write the necessary key to show the 'Expand cluster' page.

Fixes: https://tracker.ceph.com/issues/54215
Signed-off-by: Volker Theile <vtheile@suse.com>
3 years agoMerge pull request #44971 from joscollin/wip-doc-fix-name-id
Venky Shankar [Mon, 14 Feb 2022 06:49:43 +0000 (12:19 +0530)]
Merge pull request #44971 from joscollin/wip-doc-fix-name-id

doc: mention MDS name and ID format in ceph-mds.rst

Reviewed-by: Venky Shankar <vshankar@redhat.com>
3 years agoMerge pull request #39315 from shenhang/fetchkey
Venky Shankar [Mon, 14 Feb 2022 04:23:10 +0000 (09:53 +0530)]
Merge pull request #39315 from shenhang/fetchkey

mds: fetch single dentry instead of complete dirfrag for lookup

Reviewed-by: Venky Shankar <vshankar@redhat.com>
3 years agoinclude/rados/librados.h: drop duplicated function declaration 45011/head
Kefu Chai [Mon, 14 Feb 2022 04:19:35 +0000 (12:19 +0800)]
include/rados/librados.h: drop duplicated function declaration

rados_mgr_command() has been declared in the very same header file
with exactly the same function signature, so there is no need to
repeat it.

in this change, the duplicated declaration of rados_mgr_command()
is dropped. the one with doxygen document is reserved.

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
3 years agoMerge pull request #44308 from vshankar/wip-document-mds-locker
Kotresh HR [Sun, 13 Feb 2022 03:11:10 +0000 (08:41 +0530)]
Merge pull request #44308 from vshankar/wip-document-mds-locker

doc: document mds locking operation

3 years agoMerge pull request #44898 from taggelos/patch-1
Anthony D'Atri [Sat, 12 Feb 2022 10:52:16 +0000 (02:52 -0800)]
Merge pull request #44898 from taggelos/patch-1

doc/man/8: Fix spelling in user rename example

3 years agoMerge pull request #44780 from sosodev/dump-blocked-ops-count
Yuri Weinstein [Fri, 11 Feb 2022 22:51:00 +0000 (14:51 -0800)]
Merge pull request #44780 from sosodev/dump-blocked-ops-count

mds, osd: add dump_blocked_ops_count command

Reviewed-by: Neha Ojha <nojha@redhat.com>
3 years agoMerge pull request #44752 from NitzanMordhai/wip-nitzan-osd-status
Yuri Weinstein [Fri, 11 Feb 2022 22:50:31 +0000 (14:50 -0800)]
Merge pull request #44752 from NitzanMordhai/wip-nitzan-osd-status

pybind/mgr: ceph osd status crash with ZeroDivisionError

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
Reviewed-by: Ronen Friedman <rfriedma@redhat.com>
3 years agoMerge pull request #44588 from kamoltat/wip-ksirivad-disable-progress-by-default
Yuri Weinstein [Fri, 11 Feb 2022 22:49:17 +0000 (14:49 -0800)]
Merge pull request #44588 from kamoltat/wip-ksirivad-disable-progress-by-default

pybind/mgr/progress: disable pg recovery event by default

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
3 years agoMerge pull request #44289 from Vicente-Cheng/fix-outgoing-bl-overflow
Yuri Weinstein [Fri, 11 Feb 2022 22:48:18 +0000 (14:48 -0800)]
Merge pull request #44289 from Vicente-Cheng/fix-outgoing-bl-overflow

msg/async: fix outgoing_bl overflow and reset state_offset

Reviewed-by: Kefu Chai <kchai@redhat.com>
3 years agoMerge pull request #44809 from cyx1231st/wip-crimson-cleanup-epm
Samuel Just [Fri, 11 Feb 2022 21:36:57 +0000 (13:36 -0800)]
Merge pull request #44809 from cyx1231st/wip-crimson-cleanup-epm

crimson/os/seastore: allow EPM to make decisions on the general allocation path

Reviewed-by: Xuehan Xu <xxhdx1985126@gmail.com>
Reviewed-by: Samuel Just <sjust@redhat.com>
3 years agodoc: document mds locking operation 44308/head
Venky Shankar [Tue, 14 Dec 2021 12:47:02 +0000 (18:17 +0530)]
doc: document mds locking operation

Signed-off-by: Venky Shankar <vshankar@redhat.com>
3 years agoMerge pull request #44849 from rhcs-dashboard/bugfix-cephfs-invalid-dir-permission
Sarthak0702 [Fri, 11 Feb 2022 09:59:20 +0000 (15:29 +0530)]
Merge pull request #44849 from rhcs-dashboard/bugfix-cephfs-invalid-dir-permission

mgr/dashboard: Directories Menu Can't Use on Ceph File System Dashboard

3 years agoFix rgw data sync log info error 44988/head
caishan [Fri, 11 Feb 2022 09:47:35 +0000 (17:47 +0800)]
Fix rgw data sync log info error

Signed-off-by: caishan <caishan1993@foxmail.com>
3 years agoMerge pull request #44970 from kotreshhr/fix-clone-uid-gid
Venky Shankar [Fri, 11 Feb 2022 07:41:24 +0000 (13:11 +0530)]
Merge pull request #44970 from kotreshhr/fix-clone-uid-gid

mgr/volumes: Fix clone uid/gid mismatch

Reviewed-by: Venky Shankar <vshankar@redhat.com>
3 years agodoc: mention MDS name and ID format in ceph-mds.rst 44971/head
Jos Collin [Thu, 10 Feb 2022 11:13:10 +0000 (16:43 +0530)]
doc: mention MDS name and ID format in ceph-mds.rst

Signed-off-by: Jos Collin <jcollin@redhat.com>
3 years agocrimson/os/seastore: misc log improvements 44809/head
Yingxin Cheng [Sat, 29 Jan 2022 11:13:12 +0000 (19:13 +0800)]
crimson/os/seastore: misc log improvements

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
3 years agocrimson/os/seastore: initialize segment_info_t correctly when open/empty
Yingxin Cheng [Fri, 28 Jan 2022 12:12:10 +0000 (20:12 +0800)]
crimson/os/seastore: initialize segment_info_t correctly when open/empty

Previously, segment_info_t was not initialized for out-of-line segments
when open, including journal_segment_seq and the legacy out_of_line.

And the journal_segment_seq was not reset when empty.

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
3 years agocrimson/os/seastore: replace out_of_line by segment_type_t
Yingxin Cheng [Fri, 28 Jan 2022 12:08:04 +0000 (20:08 +0800)]
crimson/os/seastore: replace out_of_line by segment_type_t

Leverage segment_seq_t to identify the type of the segment.

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
3 years agocrimson/os/seastore: cleanup dependency between epm and journal
Yingxin Cheng [Fri, 28 Jan 2022 07:12:57 +0000 (15:12 +0800)]
crimson/os/seastore: cleanup dependency between epm and journal

OOL segments won't contain deltas and don't need to replay. There is no
need to assign segment sequence from journal.

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
3 years agocrimson/os/seastore: cleanup dependency between epm and lba_manager
Yingxin Cheng [Thu, 27 Jan 2022 15:35:45 +0000 (23:35 +0800)]
crimson/os/seastore: cleanup dependency between epm and lba_manager

Move lba_manamger->update_mapping() from epm to transaction manager.

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
3 years agocrimson/os/seastore: update_mapping related cleanups
Yingxin Cheng [Thu, 27 Jan 2022 15:30:54 +0000 (23:30 +0800)]
crimson/os/seastore: update_mapping related cleanups

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
3 years agocrimson/os/seastore: allow EPM to make decisions on the general extent allocation...
Yingxin Cheng [Thu, 27 Jan 2022 07:00:44 +0000 (15:00 +0800)]
crimson/os/seastore: allow EPM to make decisions on the general extent allocation path

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
3 years agocrimson/os/seastore: drop the unnecessary backend_type in every cached extent
Yingxin Cheng [Thu, 27 Jan 2022 06:33:46 +0000 (14:33 +0800)]
crimson/os/seastore: drop the unnecessary backend_type in every cached extent

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
3 years agocrimson/os/seastore/epm: cleanup unnecessary cache dependency when mark extent ool
Yingxin Cheng [Thu, 27 Jan 2022 06:03:43 +0000 (14:03 +0800)]
crimson/os/seastore/epm: cleanup unnecessary cache dependency when mark extent ool

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
3 years agocrimson/os/seastore: cleanup delayed paddr
Yingxin Cheng [Thu, 27 Jan 2022 05:53:08 +0000 (13:53 +0800)]
crimson/os/seastore: cleanup delayed paddr

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
3 years agoMerge pull request #44968 from cyx1231st/wip-crimson-cleanup-cleaner-1
Samuel Just [Thu, 10 Feb 2022 22:45:59 +0000 (14:45 -0800)]
Merge pull request #44968 from cyx1231st/wip-crimson-cleanup-cleaner-1

crimson/os/seastore/segment_cleaner: minor cleanups

Reviewed-by: Xuehan Xu <xxhdx1985126@gmail.com>
Reviewed-by: Samuel Just <sjust@redhat.com>
3 years agoMerge pull request #44964 from yaarith/pending-release-notes-perf
Neha Ojha [Thu, 10 Feb 2022 22:40:38 +0000 (14:40 -0800)]
Merge pull request #44964 from yaarith/pending-release-notes-perf

PendingReleaseNotes: add a note about perf channel

Reviewed-by: Laura Flores <lflores@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
3 years agoMerge pull request #44963 from ljflores/wip-peering-state-docs
Neha Ojha [Thu, 10 Feb 2022 22:07:31 +0000 (14:07 -0800)]
Merge pull request #44963 from ljflores/wip-peering-state-docs

doc/dev: add section on using the gen_state_diagram.py script

Reviewed-by: Neha Ojha <nojha@redhat.com>
3 years agorgw: remove rgw_rados_pool_pg_num_min and its use on pool creation 44983/head
Casey Bodley [Thu, 10 Feb 2022 18:39:24 +0000 (13:39 -0500)]
rgw: remove rgw_rados_pool_pg_num_min and its use on pool creation

use the cluster defaults for pg_num_min

Fixes: https://tracker.ceph.com/issues/52673
Signed-off-by: Casey Bodley <cbodley@redhat.com>
3 years agodoc/dev: add section on using the gen_state_diagram.py script 44963/head
Laura Flores [Wed, 9 Feb 2022 20:53:33 +0000 (20:53 +0000)]
doc/dev: add section on using the gen_state_diagram.py script

Commands sourced from Jianshen Liu's blog post on the Ceph peering state machine: https://jianshenliu.com/blog/development/ceph-peering-state-machine/

Also fixed the formatting of "PG info".

Signed-off-by: Laura Flores <lflores@redhat.com>
3 years agoMerge pull request #44765 from guits/guits-fix-cve-cv
Guillaume Abrioux [Thu, 10 Feb 2022 12:38:13 +0000 (13:38 +0100)]
Merge pull request #44765 from guits/guits-fix-cve-cv

ceph-volume: honour osd_dmcrypt_key_size option

3 years agoMerge pull request #44808 from rhcs-dashboard/support-snmp-service-creation
Ernesto Puerta [Thu, 10 Feb 2022 11:54:00 +0000 (12:54 +0100)]
Merge pull request #44808 from rhcs-dashboard/support-snmp-service-creation

mgr/dashboard: support snmp-gateway service creation from UI

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: sunilangadi2 <NOT@FOUND>
3 years agomgr/volumes: Fix clone uid/gid mismatch 44970/head
Kotresh HR [Thu, 10 Feb 2022 05:34:41 +0000 (11:04 +0530)]
mgr/volumes: Fix clone uid/gid mismatch

This is the regression caused by commit 18b85c53a.
The 'set_attrs' function sets the uid/gid of the
group to the subvolume if uid/gid is not passed.
The attrs of the clone should match the source
snapshot. Hence, don't use the 'set_attrs'
function to set only the quota attrs for the
clone.

Fixes: https://tracker.ceph.com/issues/54066
Signed-off-by: Kotresh HR <khiremat@redhat.com>
3 years agoMerge pull request #44953 from aejv/spellingerror
Venky Shankar [Thu, 10 Feb 2022 06:51:47 +0000 (12:21 +0530)]
Merge pull request #44953 from aejv/spellingerror

purge_queue.py: fixed typo

Reviewed-by: Venky Shankar <vshankar@redhat.com>
3 years agocrimson/os/seastore/segment_cleaner: mark get_next_gc_target() private 44968/head
Yingxin Cheng [Thu, 10 Feb 2022 05:03:21 +0000 (13:03 +0800)]
crimson/os/seastore/segment_cleaner: mark get_next_gc_target() private

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
3 years agocrimson/os/seastore/segment_cleaner: make init_mark_segment_closed() private
Yingxin Cheng [Thu, 10 Feb 2022 04:59:02 +0000 (12:59 +0800)]
crimson/os/seastore/segment_cleaner: make init_mark_segment_closed() private

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
3 years agocrimson/os/seastore/segment_cleaner: drop unused code
Yingxin Cheng [Thu, 10 Feb 2022 04:57:36 +0000 (12:57 +0800)]
crimson/os/seastore/segment_cleaner: drop unused code

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
3 years agocrimson/net/socket: add a missing header
Yingxin Cheng [Thu, 10 Feb 2022 04:52:12 +0000 (12:52 +0800)]
crimson/net/socket: add a missing header

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
3 years agoceph-volume/activate: load the config from lv tag 44765/head
Guillaume Abrioux [Thu, 10 Feb 2022 01:23:51 +0000 (02:23 +0100)]
ceph-volume/activate: load the config from lv tag

When `ceph-volume lvm trigger` is called with an OSD where the tag
`ceph.cluster_name` is not 'ceph', it fails.

Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
3 years agoqa/tasks/cephadm_cases: increase timeouts in test_cli.py 44965/head
Adam King [Thu, 10 Feb 2022 01:42:42 +0000 (20:42 -0500)]
qa/tasks/cephadm_cases: increase timeouts in test_cli.py

These seem to be failing sometimes but in my testing
sometimes these events are happening a few seconds after
we hit the timeout. Trying to see if this makes the tests
more consistent. No need to mark the test as failed
if we report something up in 34 seconds vs 25 especially
when cephadm works on a cyclic daemon refresh.

Signed-off-by: Adam King <adking@redhat.com>
3 years agoceph-volume/tests: use centos/stream8 images
Guillaume Abrioux [Wed, 9 Feb 2022 17:33:27 +0000 (18:33 +0100)]
ceph-volume/tests: use centos/stream8 images

Since recent move from CentOS 8 to CentOS Stream 8, let's do the same here.

Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
3 years agoceph-volume/tests: add tests in util/encryption.py
Guillaume Abrioux [Wed, 9 Feb 2022 16:04:19 +0000 (17:04 +0100)]
ceph-volume/tests: add tests in util/encryption.py

this adds some unit tests in order to cover `luks_format()` and `luks_open()`
in `util/encryption.py`.

Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
3 years agoceph-volume: honour osd_dmcrypt_key_size option
Guillaume Abrioux [Tue, 25 Jan 2022 09:25:53 +0000 (10:25 +0100)]
ceph-volume: honour osd_dmcrypt_key_size option

ceph-volume doesn't honour osd_dmcrypt_key_size.
It means the default size is always applied.

It also changes the default value in `get_key_size_from_conf()`

From cryptsetup manpage:

> For XTS mode you can optionally set a key size of 512 bits with the -s option.

Using more than 512bits will end up with the following error message:

```
Key size in XTS mode must be 256 or 512 bits.
```

Fixes: https://tracker.ceph.com/issues/54006
Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
3 years agoPendingReleaseNotes: add a note about perf channel 44964/head
Yaarit Hatuka [Wed, 9 Feb 2022 21:48:51 +0000 (21:48 +0000)]
PendingReleaseNotes: add a note about perf channel

Signed-off-by: Yaarit Hatuka <yaarit@redhat.com>
3 years agoMerge pull request #44956 from rhcs-dashboard/appli-fix
Ernesto Puerta [Wed, 9 Feb 2022 19:44:55 +0000 (20:44 +0100)]
Merge pull request #44956 from rhcs-dashboard/appli-fix

mgr/dashboard: change the readFile to readFileSync

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
3 years agoMerge pull request #44939 from soumyakoduri/wip-skoduri-dbstore-tests
Casey Bodley [Wed, 9 Feb 2022 18:01:22 +0000 (13:01 -0500)]
Merge pull request #44939 from soumyakoduri/wip-skoduri-dbstore-tests

rgw/dbstore: Add dbstore-tests to `make check`

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
Reviewed-by: Casey Bodley <cbodley@redhat.com>
3 years agomgr/dashboard: change the readFile to readFileSync 44956/head
Nizamudeen A [Wed, 9 Feb 2022 15:36:16 +0000 (21:06 +0530)]
mgr/dashboard: change the readFile to readFileSync

Apparently the readFile i added in #44934 is async and that's not what
we want. so changing it to the synchronous call that is readFileSync

Fixes: https://tracker.ceph.com/issues/54190
Signed-off-by: Nizamudeen A <nia@redhat.com>
3 years agoMerge PR #42000 into master
Patrick Donnelly [Wed, 9 Feb 2022 14:34:49 +0000 (09:34 -0500)]
Merge PR #42000 into master

* refs/pull/42000/head:
qa: update rhel kclient to setup container tools
qa: stop overriding distro for k-testing
qa: only use RHEL for workload testing
qa: convert fs:workload to use cephadm
qa: split fs begin task
qa/tasks/cephadm: setup CephManager when OSDs are provisioned
qa/tasks/cephadm: setup file system if MDS are provisioned

Reviewed-by: Sage Weil <sage@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
3 years agopurge_queue.py: fixed typo 44953/head
Judah van der Ster [Wed, 9 Feb 2022 14:25:58 +0000 (15:25 +0100)]
purge_queue.py: fixed typo

Signed-off-by: Judah van der Ster <jevanderster@gmail.com>
3 years agoMerge pull request #44937 from idryomov/wip-rbd-help-positional-optional
Ilya Dryomov [Wed, 9 Feb 2022 14:08:58 +0000 (15:08 +0100)]
Merge pull request #44937 from idryomov/wip-rbd-help-positional-optional

rbd: mark optional positional arguments as such in help output

Reviewed-by: Sunny Kumar <sunkumar@redhat.com>
Reviewed-by: Mykola Golub <mgolub@suse.com>
3 years agoMerge pull request #44492 from xijiacun/master
Casey Bodley [Wed, 9 Feb 2022 13:37:35 +0000 (08:37 -0500)]
Merge pull request #44492 from xijiacun/master

rgw: Erase old storage class attr when the object is rewrited using r…

Reviewed-by: Casey Bodley <cbodley@redhat.com>
3 years agomgr/dashboard:Directories Menu Can't Use on Ceph File System Dashboard 44849/head
Sarthak0702 [Thu, 3 Feb 2022 17:59:17 +0000 (23:29 +0530)]
mgr/dashboard:Directories Menu Can't Use on Ceph File System Dashboard

Added exception handling to opendir() in cephfs.py for directories with no execute permission.

Fixes: https://tracker.ceph.com/issues/51611
Signed-off-by: Sarthak0702 <sarthak.0702@gmail.com>
3 years agomgr/dashboard: add snmp-gateway service e2e tests 44808/head
Avan Thakkar [Tue, 1 Feb 2022 13:02:42 +0000 (18:32 +0530)]
mgr/dashboard: add snmp-gateway service e2e tests

Fixes: https://tracker.ceph.com/issues/54034
Signed-off-by: Avan Thakkar <athakkar@redhat.com>
3 years agoMerge pull request #44934 from rhcs-dashboard/applitools-baseline-branch
Ernesto Puerta [Wed, 9 Feb 2022 11:05:21 +0000 (12:05 +0100)]
Merge pull request #44934 from rhcs-dashboard/applitools-baseline-branch

mgr/dashboard: set appropriate baseline branch for applitools

Reviewed-by: aaryanporwal <NOT@FOUND>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
3 years agorgw/dbstore: Add dbstore-tests to `make check` 44939/head
Soumya Koduri [Tue, 8 Feb 2022 10:02:16 +0000 (15:32 +0530)]
rgw/dbstore: Add dbstore-tests to `make check`

Include and run dbstore-tests as part of `make check` target

Signed-off-by: Soumya Koduri <skoduri@redhat.com>
3 years agomds: add an option to decide whether prefetching entire dir or not. 39315/head
shenhang [Fri, 10 Sep 2021 10:59:49 +0000 (18:59 +0800)]
mds: add an option to decide whether prefetching entire dir or not.
Accessing one single dentry could be fastened by set this option to
false, when dir is not in the memory.
Signed-off-by: "Shen, Hang" <shenhang@kuaishou.com>
3 years agomds: avoid adding null dentry to bloom filter
Shen, Hang [Thu, 26 Aug 2021 06:09:45 +0000 (14:09 +0800)]
mds: avoid adding null dentry to bloom filter

Signed-off-by: "Shen, Hang" <shenhang@kuaishou.com>