]> git.apps.os.sepia.ceph.com Git - ceph.git/log
ceph.git
5 years agoMerge pull request #31857 from smithfarm/wip-40947-luminous
Yuri Weinstein [Thu, 12 Dec 2019 16:41:43 +0000 (08:41 -0800)]
Merge pull request #31857 from smithfarm/wip-40947-luminous

luminous:  osd: add hdd, ssd and hybrid variants for osd_snap_trim_sleep

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
5 years agoMerge pull request #31858 from smithfarm/wip-38205-luminous
Yuri Weinstein [Thu, 12 Dec 2019 16:41:19 +0000 (08:41 -0800)]
Merge pull request #31858 from smithfarm/wip-38205-luminous

luminous: osd: refuse to start if we're > N+2 from recorded require_osd_release

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
5 years agoMerge pull request #31992 from dzafman/wip-balancer3-luminous
Yuri Weinstein [Thu, 12 Dec 2019 16:40:45 +0000 (08:40 -0800)]
Merge pull request #31992 from dzafman/wip-balancer3-luminous

luminous: mgr: Release GIL and Balancer fixes

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
5 years agoMerge pull request #31846 from smithfarm/wip-42988-luminous
Yuri Weinstein [Wed, 11 Dec 2019 19:53:06 +0000 (11:53 -0800)]
Merge pull request #31846 from smithfarm/wip-42988-luminous

luminous: tests: kernel.sh: update for read-only changes

Reviewed-by: Ilya Dryomov <idryomov@redhat.com>
5 years agorelease note: Add pending release notes for already merged code 31992/head
David Zafman [Thu, 5 Dec 2019 17:52:04 +0000 (09:52 -0800)]
release note: Add pending release notes for already merged code

Follow on to https://github.com/ceph/ceph/pull/31774

Signed-off-by: David Zafman <dzafman@redhat.com>
(cherry picked from commit 65d03bae8b4f50cc3cbaa50640eaeab4cabd711f)

5 years agocommon/options.cc, doc: osd_snap_trim_sleep overrides other variants 31857/head
Neha Ojha [Fri, 28 Jun 2019 16:53:01 +0000 (09:53 -0700)]
common/options.cc, doc: osd_snap_trim_sleep overrides other variants

A value > 0 for osd_snap_trim_sleep, will override the backend specific
variants of osd_snap_trim_sleep.

Signed-off-by: Neha Ojha <nojha@redhat.com>
(cherry picked from commit 733df09fe5111e7beca75f8be0afb8669ef9a625)

5 years agodoc/rados/configuration/osd-config-ref.rst: document snap trim sleep
Neha Ojha [Thu, 27 Jun 2019 19:33:46 +0000 (12:33 -0700)]
doc/rados/configuration/osd-config-ref.rst: document snap trim sleep

Signed-off-by: Neha Ojha <nojha@redhat.com>
(cherry picked from commit accf95e9dea257c3aaa64b7a36d077468d7c86ec)

5 years agoosd: add hdd, ssd and hybrid variants for osd_snap_trim_sleep
Neha Ojha [Wed, 26 Jun 2019 01:43:05 +0000 (18:43 -0700)]
osd: add hdd, ssd and hybrid variants for osd_snap_trim_sleep

This is better than the earlier default, which was set to 0.

Fixes: https://tracker.ceph.com/issues/40528
Signed-off-by: Neha Ojha <nojha@redhat.com>
(cherry picked from commit 560fca12e695a817e1b7e46d365838ed871b64bd)

Conflicts:
src/osd/OSD.cc
src/osd/OSD.h
src/osd/PrimaryLogPG.h
- no OSD::get_osd_delete_sleep() in luminous, no OSD::get_recovery_max_active()
  in luminous
- use cct->_conf->get_val instead of cct->_conf.get_val

5 years agoosd: refuse to start if release > recorded min_osd_release + 2 31858/head
Sage Weil [Mon, 28 Jan 2019 20:58:26 +0000 (14:58 -0600)]
osd: refuse to start if release > recorded min_osd_release + 2

If we try to start up the objectstore, we may make writeable changes to
(say) rocksdb that are not backwards compatible.  This happens, for
example, if you start a mimic osd.  Even if the compatset checks fail,
rocksdb may have written something that is not backwards compatible.

Fixes: http://tracker.ceph.com/issues/38076
Signed-off-by: Sage Weil <sage@redhat.com>
(cherry picked from commit 9f7713a905d67441b28371e4494e9447319d2129)

Conflicts:
src/ceph_osd.cc
- include common/version.h for ceph_release()
- use exit instead of forker.exit

5 years agoosd: record require_osd_release in objectstore meta
Sage Weil [Mon, 28 Jan 2019 21:05:53 +0000 (15:05 -0600)]
osd: record require_osd_release in objectstore meta

Record the require_osd_release value from the OSDMap in the 'meta' portion
of the osd's metadata that can be accessed without actually mounting the
OSD.  This will be useful as a safety gate to prevent you from mounting
an osd thet is too new that may make incompatible changes to the store.

Signed-off-by: Sage Weil <sage@redhat.com>
(cherry picked from commit 482cdca55351ca85290f1b2adb3c0cdf78af411d)

Conflicts:
src/osd/OSD.cc
src/osd/OSD.h
- ignore differences in surrounding context, as they do not seem relevant to
  the fix

5 years agoMerge pull request #32019 from dzafman/wip-revert-verify-upmap-luminous
David Zafman [Fri, 6 Dec 2019 18:23:01 +0000 (10:23 -0800)]
Merge pull request #32019 from dzafman/wip-revert-verify-upmap-luminous

luminous: Revert "crush: remove invalid upmap items"

Reviewed-by: Neha Ojha <nojha@redhat.com>
Reviewed-by: Josh Durgin <jdurgin@redhat.com>
5 years agoMerge pull request #31966 from smithfarm/wip-43100-luminous
Nathan Cutler [Thu, 5 Dec 2019 15:16:08 +0000 (16:16 +0100)]
Merge pull request #31966 from smithfarm/wip-43100-luminous

luminous: ceph-detect-init: run tox tests on Python 2 only

Reviewed-by: Thomas Bechtold <tbechtold@suse.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Jan Fajerski <jfajerski@suse.com>
5 years agoceph-detect-init: run tox tests on Python 2 only 31966/head
Nathan Cutler [Tue, 3 Dec 2019 09:34:45 +0000 (10:34 +0100)]
ceph-detect-init: run tox tests on Python 2 only

Luminous is EOL upstream and 12.2.13 will be the last point release, so it's
pretty much a given that luminous will not be migrated to py3.

Luminous runs on OS versions where py3 is not a "first-class citizen": compiling
the mgr with a py3 subinterpreter on such systems would be "interesting"...

Python 3 testing was dropped for ceph-disk by
28c545eff5f73e392b70ef4c0cf74f8a896b693b (over 3 years ago) and
ceph-detect-init is a component of ceph-disk.

This commit cannot be cherry-picked from master because ceph-detect-init was
removed in nautilus.

Fixes: https://tracker.ceph.com/issues/43100
Signed-off-by: Nathan Cutler <ncutler@suse.com>
5 years agoRevert "crush: remove invalid upmap items" 32019/head
David Zafman [Thu, 5 Dec 2019 00:30:00 +0000 (16:30 -0800)]
Revert "crush: remove invalid upmap items"

This reverts commit 09528ac4663cda9f206eb8d4dcc15926b8e4586f.

Signed-off-by: David Zafman <dzafman@redhat.com>
5 years agotest: Fix test to use -gt instead of creating an empty file "0"
David Zafman [Sat, 18 Aug 2018 00:25:38 +0000 (17:25 -0700)]
test: Fix test to use -gt instead of creating an empty file "0"

Signed-off-by: David Zafman <dzafman@redhat.com>
(cherry picked from commit d0b260c272cf2732437c838c80ab380b4bb8d433)

5 years agotest balancer: Backport specific fixes
David Zafman [Tue, 3 Dec 2019 18:13:46 +0000 (10:13 -0800)]
test balancer: Backport specific fixes

Add "ceph balancer sleep" command to set balancer sleep_interval for testing
Remove unavailable "ceph balancer pool" part of testing
Remove setting of nonexistant osd_pool_default_pg_autoscale_mode
Improve balancer module log message
Fix log message test (no pg merging)
Pool balancing isn't grouped by rule, so results different here

Signed-off-by: David Zafman <dzafman@redhat.com>
(cherry picked from commit 61dedc249bb93a208e685c68a65a5c07d60870d1)
From mimic backport

5 years agoqa/standalone/ceph-helpers.sh: fix mgr module path
Noah Watkins [Fri, 17 Aug 2018 22:21:57 +0000 (15:21 -0700)]
qa/standalone/ceph-helpers.sh: fix mgr module path

callers of get_python_path were not passing in a $1 parameter, so
ceph_lib was an empty string resulting in an invalid path to the built
cython modules. assume this is called from the `lib` parent directory.

pass path to the manager modules when starting ceph-mgr.

Signed-off-by: Noah Watkins <nwatkins@redhat.com>
(cherry picked from commit 7d3fa9bda3b0160c872e388c9f75cd1cabf9d4b5)

Conflicts:
qa/run-standalone.sh (No get_python_path() to modify)

5 years agotest: Luminous specific change required due to output difference
David Zafman [Wed, 4 Dec 2019 01:13:08 +0000 (17:13 -0800)]
test: Luminous specific change required due to output difference

Signed-off-by: David Zafman <dzafman@redhat.com>
5 years agotools/osdmaptool.cc: do not use deprecated std::random_shuffle()
Kefu Chai [Wed, 4 Dec 2019 00:06:40 +0000 (16:06 -0800)]
tools/osdmaptool.cc: do not use deprecated std::random_shuffle()
the use of `std::random_shuffle()` was introduced by
b946308 .

in this change, it is replaced using `std::shuffle()`.

Fixes: https://tracker.ceph.com/issues/43084
Signed-off-by: Kefu Chai <kchai@redhat.com>
(cherry picked from commit 30dfef208d859a67c1f1b13c314735861c536e85)

Conflicts:
src/tools/osdmaptool.cc (randomizing pools here instead of rules)

5 years agoMerge pull request #31934 from smithfarm/wip-tox-luminous
Nathan Cutler [Tue, 3 Dec 2019 10:48:43 +0000 (11:48 +0100)]
Merge pull request #31934 from smithfarm/wip-tox-luminous

luminous: rpm: explicitly declare python-tox build dependency

Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Sebastian Wagner <swagner@suse.com>
5 years agotest: Add test case based on Xie script in commit comment
David Zafman [Wed, 27 Nov 2019 18:50:01 +0000 (10:50 -0800)]
test: Add test case based on Xie script in commit comment

Other test fixes to reflect changes

Signed-off-by: David Zafman <dzafman@redhat.com>
(cherry picked from commit 9d2e0267e1f025a634ee4925c919008cacdd3d38)

Conflict:
src/test/cli/osdmaptool/upmap-out.t (older output format)
src/test/cli/osdmaptool/upmap.t (older output format)

5 years agoosd: ceph_pg_upmaps() use any overfull when there are still underfull
David Zafman [Wed, 27 Nov 2019 18:48:30 +0000 (10:48 -0800)]
osd: ceph_pg_upmaps() use any overfull when there are still underfull

Signed-off-by: David Zafman <dzafman@redhat.com>
(cherry picked from commit f38d38398f33f64bd49f017b1c8e737452157c53)

5 years agoosd: Create more_underfull with below target that aren't in underfull
David Zafman [Tue, 26 Nov 2019 23:19:01 +0000 (15:19 -0800)]
osd: Create more_underfull with below target that aren't in underfull

Use more_underfull for finding remaps for overfull OSDs

Signed-off-by: David Zafman <dzafman@redhat.com>
(cherry picked from commit fe03383e6691f6bd95189d3ba4d91fbb2ea9e9c8)

5 years agoosd: calc_pg_upmaps() pick most overfull remap from try_pg_upmap()
David Zafman [Tue, 26 Nov 2019 05:38:16 +0000 (21:38 -0800)]
osd: calc_pg_upmaps() pick most overfull remap from try_pg_upmap()

Signed-off-by: David Zafman <dzafman@redhat.com>
(cherry picked from commit 3f132061fd33c82dc131e18ae80cbec067b53cae)

5 years agoosd: ceph_pg_upmaps() use max_deviation to determine perfect distribution
David Zafman [Fri, 15 Nov 2019 05:10:28 +0000 (21:10 -0800)]
osd: ceph_pg_upmaps() use max_deviation to determine perfect distribution

Signed-off-by: David Zafman <dzafman@redhat.com>
(cherry picked from commit 7f4ae9312314c329b63c850e09b403a95ad18bed)

Conflicts:
src/pybind/mgr/balancer/module.py (upmap_max_deviation config option
   handled differently)

5 years agotools: osdmaptool: Perform upmap calculation as ceph-mgr does
David Zafman [Thu, 7 Nov 2019 04:32:48 +0000 (20:32 -0800)]
tools: osdmaptool: Perform upmap calculation as ceph-mgr does

This is the backportable commit that works with older balancer module.py

Signed-off-by: David Zafman <dzafman@redhat.com>
(cherry picked from commit b946308f03f1798915fafe7878f34b4a234c2ae4)

5 years agoosd: For balancer crush needs the rule passed to get_parent_of_type()
David Zafman [Wed, 20 Nov 2019 06:21:00 +0000 (22:21 -0800)]
osd: For balancer crush needs the rule passed to get_parent_of_type()

Fixes: https://tracker.ceph.com/issues/42718
Signed-off-by: David Zafman <dzafman@redhat.com>
(cherry picked from commit 3eb69fd0cb15974e33e675babdd5d232d69c3c6d)

5 years agoosdmaptool: Match default max value of 10
David Zafman [Thu, 7 Nov 2019 04:31:21 +0000 (20:31 -0800)]
osdmaptool: Match default max value of 10

Signed-off-by: David Zafman <dzafman@redhat.com>
(cherry picked from commit 91bab14ea0e2ec7c94eb758cd76f9a620688725f)

5 years agotools: odsmaptool truncate target upmap file
David Zafman [Wed, 20 Nov 2019 19:55:15 +0000 (11:55 -0800)]
tools: odsmaptool truncate target upmap file

Signed-off-by: David Zafman <dzafman@redhat.com>
(cherry picked from commit a49324ceb9c322f792ea00720f438ea9ea09555f)

5 years agomgr: Improve balancer module status
David Zafman [Thu, 24 Oct 2019 00:00:14 +0000 (17:00 -0700)]
mgr: Improve balancer module status

Add balancer status fields so that slow optimizations can be detected

Signed-off-by: David Zafman <dzafman@redhat.com>
(cherry picked from commit f04c505b9dc128bdfbcca49d82f8aac4abf8b56f)

5 years agotest: Test balancer module commands
David Zafman [Wed, 23 Oct 2019 23:38:48 +0000 (16:38 -0700)]
test: Test balancer module commands

Signed-off-by: David Zafman <dzafman@redhat.com>
(cherry picked from commit 3a0e2c8ff1cce44bf44b139572f4d1bd9bbfb766)

5 years agomgr: Release GIL before calling OSDMap::calc_pg_upmaps()
David Zafman [Tue, 22 Oct 2019 22:24:05 +0000 (15:24 -0700)]
mgr: Release GIL before calling OSDMap::calc_pg_upmaps()

Prevent optimize and execute commands from running with active balancer

Fixes: https://tracker.ceph.com/issues/42432
Signed-off-by: David Zafman <dzafman@redhat.com>
(cherry picked from commit e2a35e8c8e9f381a635ad0ca01326a2c512590a9)

Conflicts:
src/pybind/mgr/balancer/module.py (trivial)
src/test/cli-integration/balancer/misplaced.t (doesn't exist)

5 years agorpm: explicitly declare python-tox build dependency 31934/head
Nathan Cutler [Mon, 2 Dec 2019 11:39:57 +0000 (12:39 +0100)]
rpm: explicitly declare python-tox build dependency

"make check" needs python-tox to run, but until 71ac2163831ffd764bf3da6a3efa76ef02e5e884
("ceph.spec: added dashboard_v2 development and runtime dependencies")
this was not explicitly declared in the spec file. It does not make sense to
backport that commit to luminous, though, because the dashboard itself was never
backported to luminous.

Fixes: https://tracker.ceph.com/issues/43082
Signed-off-by: Nathan Cutler <ncutler@suse.com>
5 years agoMerge pull request #31664 from hillpd/wip-38714-luminous
Yuri Weinstein [Mon, 25 Nov 2019 16:51:29 +0000 (08:51 -0800)]
Merge pull request #31664 from hillpd/wip-38714-luminous

luminous: rgw: resolve bugs and clean up garbage collection code

Reviewed-by: Casey Bodley <cbodley@redhat.com>
5 years agoMerge pull request #31655 from smithfarm/wip-40496-luminous
Yuri Weinstein [Mon, 25 Nov 2019 16:50:54 +0000 (08:50 -0800)]
Merge pull request #31655 from smithfarm/wip-40496-luminous

luminous: doc: fixed --read-only argument value in multisite doc

Reviewed-by: Casey Bodley <cbodley@redhat.com>
5 years agoMerge pull request #31647 from smithfarm/wip-39603-luminous
Yuri Weinstein [Mon, 25 Nov 2019 16:50:08 +0000 (08:50 -0800)]
Merge pull request #31647 from smithfarm/wip-39603-luminous

luminous: doc/rgw: document CreateBucketConfiguration for s3 PUT Bucket api

Reviewed-by: Casey Bodley <cbodley@redhat.com>
5 years agoqa: kernel.sh: update for read-only changes 31846/head
Ilya Dryomov [Mon, 18 Nov 2019 17:15:10 +0000 (18:15 +0100)]
qa: kernel.sh: update for read-only changes

Snapshot existence validation code was removed from krbd.  It was racy
and relied on having watch established for snapshots.

Fixes: https://tracker.ceph.com/issues/42916
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit 6fb544045e743c5dc73dac2f62aeeb964dcd62bc)

5 years agoMerge pull request #31696 from k0ste/wip-42849-luminous
Yuri Weinstein [Thu, 21 Nov 2019 22:55:41 +0000 (14:55 -0800)]
Merge pull request #31696 from k0ste/wip-42849-luminous

luminous: pybind/mgr: Cancel output color control

Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Sebastian Wagner <sebastian.wagner@suse.com>
5 years agoMerge pull request #31587 from k0ste/wip-42784-luminous
Yuri Weinstein [Wed, 20 Nov 2019 20:14:14 +0000 (12:14 -0800)]
Merge pull request #31587 from k0ste/wip-42784-luminous

luminous: mgr/prometheus: assign a value to osd_dev_node when obj_store is not filestore or bluestore

Reviewed-by: David Zafman <dzafman@redhat.com>
5 years agoMerge pull request #31360 from idryomov/wip-krbd-udev-fixes-luminous
Yuri Weinstein [Wed, 20 Nov 2019 15:50:05 +0000 (07:50 -0800)]
Merge pull request #31360 from idryomov/wip-krbd-udev-fixes-luminous

luminous: krbd: avoid udev netlink socket overrun and retry on transient errors from udev_enumerate_scan_devices()

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
Reviewed-by: Dongsheng Yang <dongsheng.yang@easystack.cn>
5 years agoMerge pull request #31654 from smithfarm/wip-40350-luminous
Yuri Weinstein [Tue, 19 Nov 2019 21:53:04 +0000 (13:53 -0800)]
Merge pull request #31654 from smithfarm/wip-40350-luminous

luminous: rgw/OutputDataSocket: actually discard data on full buffer

Reviewed-by: Casey Bodley <cbodley@redhat.com>
5 years agoMerge pull request #31653 from smithfarm/wip-40359-luminous
Yuri Weinstein [Tue, 19 Nov 2019 21:52:40 +0000 (13:52 -0800)]
Merge pull request #31653 from smithfarm/wip-40359-luminous

luminous: rgw: set null version object acl issues

Reviewed-by: Casey Bodley <cbodley@redhat.com>
5 years agoMerge pull request #31652 from smithfarm/wip-40132-luminous
Yuri Weinstein [Tue, 19 Nov 2019 21:52:17 +0000 (13:52 -0800)]
Merge pull request #31652 from smithfarm/wip-40132-luminous

luminous: rgw: TempURL should not allow PUTs with the X-Object-Manifest.

Reviewed-by: Casey Bodley <cbodley@redhat.com>
5 years agoMerge pull request #31651 from smithfarm/wip-40127-luminous
Yuri Weinstein [Tue, 19 Nov 2019 21:49:30 +0000 (13:49 -0800)]
Merge pull request #31651 from smithfarm/wip-40127-luminous

luminous: rgw: parse_copy_location defers url-decode

Reviewed-by: Casey Bodley <cbodley@redhat.com>
5 years agoMerge pull request #31649 from smithfarm/wip-39747-luminous
Yuri Weinstein [Tue, 19 Nov 2019 21:49:02 +0000 (13:49 -0800)]
Merge pull request #31649 from smithfarm/wip-39747-luminous

luminous: rgw: delete_obj_index() takes mtime for bilog

Reviewed-by: Casey Bodley <cbodley@redhat.com>
5 years agoMerge pull request #31648 from smithfarm/wip-39733-luminous
Yuri Weinstein [Tue, 19 Nov 2019 21:48:37 +0000 (13:48 -0800)]
Merge pull request #31648 from smithfarm/wip-39733-luminous

luminous: rgw: cls/user: cls_user_set_buckets_info overwrites creation_time

Reviewed-by: Casey Bodley <cbodley@redhat.com>
5 years agoMerge pull request #31220 from less-is-morr/wip-39732-luminous
Yuri Weinstein [Tue, 19 Nov 2019 21:48:10 +0000 (13:48 -0800)]
Merge pull request #31220 from less-is-morr/wip-39732-luminous

luminous: rgw: allow radosgw-admin to list bucket w --allow-unordered

Reviewed-by: Casey Bodley <cbodley@redhat.com>
5 years agoMerge pull request #31218 from smithfarm/wip-39696-luminous
Yuri Weinstein [Tue, 19 Nov 2019 21:47:44 +0000 (13:47 -0800)]
Merge pull request #31218 from smithfarm/wip-39696-luminous

luminous: rgw: return ERR_NO_SUCH_BUCKET early while evaluating bucket policy

Reviewed-by: Casey Bodley <cbodley@redhat.com>
5 years agoMerge pull request #30946 from smithfarm/wip-40852-luminous
Yuri Weinstein [Tue, 19 Nov 2019 21:47:17 +0000 (13:47 -0800)]
Merge pull request #30946 from smithfarm/wip-40852-luminous

luminous: rgw/multisite: Don't allow certain radosgw-admin commands to run on non-master zone

Reviewed-by: Casey Bodley <cbodley@redhat.com>
5 years agoMerge pull request #30984 from k0ste/luminous_backports
Yuri Weinstein [Tue, 19 Nov 2019 21:46:26 +0000 (13:46 -0800)]
Merge pull request #30984 from k0ste/luminous_backports

luminous: rgw: add list user admin OP API

Reviewed-by: Casey Bodley <cbodley@redhat.com>
5 years agoMerge pull request #31598 from smithfarm/wip-42796-luminous
Yuri Weinstein [Tue, 19 Nov 2019 21:45:02 +0000 (13:45 -0800)]
Merge pull request #31598 from smithfarm/wip-42796-luminous

luminous: osd/OSDMap.cc: don't output over/underfull messages to lderr

Reviewed-by: David Zafman <dzafman@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
5 years agoMerge pull request #29122 from taodd/barckport-26564
Yuri Weinstein [Tue, 19 Nov 2019 21:40:15 +0000 (13:40 -0800)]
Merge pull request #29122 from taodd/barckport-26564

luminous: rgw: LC: handle resharded buckets

Reviewed-by: Abhishek Lekshmanan <abhishek.lekshmanan@gmail.com>
5 years agoMerge pull request #31674 from smithfarm/wip-42834-luminous
Yuri Weinstein [Tue, 19 Nov 2019 17:02:36 +0000 (09:02 -0800)]
Merge pull request #31674 from smithfarm/wip-42834-luminous

luminous: os/bluestore: fix improper setting of STATE_KV_SUBMITTED.

Reviewed-by: Igor Fedotov <ifedotov@suse.com>
Reviewed-by: xie xingguo <xie.xingguo@zte.com.cn>
5 years agoMerge pull request #31449 from batrick/i41031-luminous
Yuri Weinstein [Tue, 19 Nov 2019 16:33:16 +0000 (08:33 -0800)]
Merge pull request #31449 from batrick/i41031-luminous

luminous: qa: malformed job

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Sidharth Anupkrishnan <sanupkri@redhat.com>
5 years agoMerge pull request #31450 from batrick/i42672
Yuri Weinstein [Tue, 19 Nov 2019 16:32:11 +0000 (08:32 -0800)]
Merge pull request #31450 from batrick/i42672

luminous: qa: cfuse_workunit_kernel_untar_build fails on Ubuntu 18.04

Reviewed-by: Sidharth Anupkrishnan <sanupkri@redhat.com>
5 years agoMerge pull request #31573 from ukernel/luminous-42774
Yuri Weinstein [Tue, 19 Nov 2019 16:31:35 +0000 (08:31 -0800)]
Merge pull request #31573 from ukernel/luminous-42774

luminous: mds: add command that config individual client session

Reviewed-by: Sidharth Anupkrishnan <sanupkri@redhat.com>
5 years agorgw: resolve bugs and clean up garbage collection code 31664/head
J. Eric Ivancich [Fri, 15 Feb 2019 01:30:46 +0000 (20:30 -0500)]
rgw: resolve bugs and clean up garbage collection code

Does a number of things to clean up rgw gc code:

  * adds additional logging to make future debugging easier.
  * resolves bug where the truncated flag was not always set correctly
    in gc_iterate_entries
  * resolves bug where marker in RGWGC::process was not advanced
  * resolves bug in which gc entries with a zero-length chain
    were not trimmed
  * resolves bug where same gc entry tag was added to list for
    deletion multiple times

Fixes: http://tracker.ceph.com/issues/38454
Signed-off-by: J. Eric Ivancich <ivancich@redhat.com>
(cherry picked from commit 73d7d36)

Conflicts:
src/rgw/rgw_gc.cc dout() vs ldpp_dout()

Note: This was a clean cherry-pick from Mimic, which already resolved
      dout() vs ldpp_dout() conficts.

Signed-off-by: Dan Hill <daniel.hill@canonical.com>
(cherry picked from commit a598ccce2e)

5 years agopybind/mgr: Cancel output color control 31696/head
zhengyin [Wed, 6 Nov 2019 03:57:40 +0000 (11:57 +0800)]
pybind/mgr: Cancel output color control

When I do "ceph osd status" command, the units are not visible
when using a black background, So cancel outpul color control

Fixes: https://tracker.ceph.com/issues/42517
Signed-off-by: Zheng Yin <zhengyin@cmss.chinamobile.com>
(cherry picked from commit ca2675e215acc8fbfb2d730b9c1f9f3aafc3e67d)

Conflicts:
- path: rc/pybind/mgr/mgr_util.py
  comment: mgr_util.py in luminous is status/module.py

5 years agoos/bluestore: fix improper setting of STATE_KV_SUBMITTED. 31674/head
Igor Fedotov [Mon, 7 Oct 2019 13:39:20 +0000 (16:39 +0300)]
os/bluestore: fix improper setting of STATE_KV_SUBMITTED.

Fixes: https://tracker.ceph.com/issues/42209
The issue is Nautilus and earlier releases specific as master already has
some changes making the case even worse and then fixing the whole bunch.
See https://tracker.ceph.com/issues/42189

Signed-off-by: Igor Fedotov <ifedotov@suse.com>
(cherry picked from commit f8ed28a812bd068d07d4fe5013a731100038bf17)

Conflicts:
src/os/bluestore/BlueStore.cc
- luminous assert became ceph_assert later

5 years agodoc: fixed --read-only argument value in multisite doc 31655/head
Chenjiong Deng [Wed, 19 Jun 2019 10:17:43 +0000 (18:17 +0800)]
doc: fixed --read-only argument value in multisite doc

Fixes: https://tracker.ceph.com/issues/40458
Signed-off-by: Chenjiong Deng <dengchenjiong@umcloud.com>
(cherry picked from commit c65832c1ff03e802f98cb7f4bda620e1e515264f)

5 years agorgw/OutputDataSocket: actually discard data on full buffer 31654/head
Matt Benjamin [Wed, 5 Jun 2019 17:25:32 +0000 (13:25 -0400)]
rgw/OutputDataSocket: actually discard data on full buffer

A dout message in OutputDataSocket::append_output() states that
data will be dropped when appending would cause data_max_backlog
to be exceeded--but the method appends it anyway.

Log output discards at level 0, as messages will be lost.  Suppress
repeated warnings mod 100.  Switch to vector.

Fixes: http://tracker.ceph.com/issues/40178
Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
(cherry picked from commit c806b825dae649829de8847d36cb21ffd2bbee8e)

Conflicts:
src/common/OutputDataSocket.cc
src/common/OutputDataSocket.h

5 years agorgw: set null version object acl issues 31653/head
Tianshan Qu [Sun, 11 Nov 2018 11:56:51 +0000 (19:56 +0800)]
rgw: set null version object acl issues

1.set null version object acl will create empty index
RGWRados::set_attrs did not clear instance, so index prepare, complete got instance=null,
which lead to empty index 1000_<obj>_i_null.
there is no harm to create empty index, but listomapkeys to find that key.

2.if object is exist with versioned key, we can set none exists null version object
order:
1) enable bucket version
2) put obj
3) disable bucket version
4) set versoned_id=null acl will succeed which should not

Fixes: http://tracker.ceph.com/issues/36763
Signed-off-by: Tianshan Qu <tianshan@xsky.com>
(cherry picked from commit ca6e5c89e8d6da498da15f0eea4bcd4d271b44e9)

5 years agorgw: TempURL should not allow PUTs with the X-Object-Manifest. 31652/head
Radoslaw Zarzynski [Fri, 28 Jul 2017 14:37:07 +0000 (10:37 -0400)]
rgw: TempURL should not allow PUTs with the X-Object-Manifest.

Fixes: http://tracker.ceph.com/issues/20797
Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
(cherry picked from commit 40e602bc3866598952eb0dd68ecec947dd7b70d6)

5 years agorgw: parse_copy_location defers url-decode 31651/head
Casey Bodley [Tue, 11 Dec 2018 21:13:58 +0000 (16:13 -0500)]
rgw: parse_copy_location defers url-decode

don't url-decode until after we search for the ?, or we'll truncate
object names that contain a url-encoded ?

Fixes: http://tracker.ceph.com/issues/27217
Signed-off-by: Casey Bodley <cbodley@redhat.com>
(cherry picked from commit 804bb853f1c7b5ce546c100d61c6fc526838c134)

5 years agorgw: delete_obj_index() takes mtime for bilog 31649/head
Casey Bodley [Mon, 6 May 2019 19:01:07 +0000 (15:01 -0400)]
rgw: delete_obj_index() takes mtime for bilog

writing an empty timestamp to the bilog prevents other zones from
applying the delete. this means that the --bypass-gc flag for
'radosgw-admin bucket rm' doesn't work in multisite

Fixes: http://tracker.ceph.com/issues/24991
Signed-off-by: Casey Bodley <cbodley@redhat.com>
(cherry picked from commit 0316a81875ae93a06841d532bf3548c81370296e)

5 years agotest/rgw: add multisite test_bucket_creation_time() 31648/head
Casey Bodley [Thu, 9 May 2019 14:07:52 +0000 (10:07 -0400)]
test/rgw: add multisite test_bucket_creation_time()

does not create any buckets itself, but checks that all creation times
match on buckets created by other tests

Signed-off-by: Casey Bodley <cbodley@redhat.com>
(cherry picked from commit 8df991c5cc48a6709185edf506d8bdec4d28e371)

5 years agocls/user: cls_user_set_buckets_info overwrites creation_time
Casey Bodley [Wed, 8 May 2019 18:35:25 +0000 (14:35 -0400)]
cls/user: cls_user_set_buckets_info overwrites creation_time

metadata sync of a new bucket entrypoint may call rgw_link_bucket()
(which in turn calls into cls user) without deleting/unlinking the
previous bucket entrypoint. this prevented the new bucket entrypoint
from overwriting the creation_time of the old one

Fixes: http://tracker.ceph.com/issues/39635
Signed-off-by: Casey Bodley <cbodley@redhat.com>
(cherry picked from commit c469e5150a3e95b547a7d05d1ae08fa88fad7159)

5 years agodoc/rgw: document CreateBucketConfiguration for s3 PUT Bucket api 31647/head
Casey Bodley [Mon, 6 May 2019 13:33:05 +0000 (09:33 -0400)]
doc/rgw: document CreateBucketConfiguration for s3 PUT Bucket api

Fixes: http://tracker.ceph.com/issues/39597
Signed-off-by: Casey Bodley <cbodley@redhat.com>
(cherry picked from commit e97668bb7a1333850a5791ae16b97496851ac854)

5 years agoAdded single check to avoid duplication. Included few more commands. 30946/head
Shilpa Jagannath [Fri, 5 Jul 2019 10:47:31 +0000 (16:17 +0530)]
Added single check to avoid duplication. Included few more commands.

Signed-off-by: Shilpa Jagannath <smanjara@redhat.com>
(cherry picked from commit 14c3b4b3ebb6ef2fc44d24f8020beb2977c8e46e)

Conflicts:
        src/rgw/rgw_admin.cc
- cherry-pick was clean, but there was a build failure "error: 'class RGWRados'
has no member named 'svc'", which was fixed by making the following change:

-  bool non_master_cmd = (!store->svc.zone->is_meta_master() && !yes_i_really_mean_it);
+  bool non_master_cmd = (!store->is_meta_master() && !yes_i_really_mean_it);

- drop OPT_MFA_CREATE, OPT_MFA_REMOVE, and OPT_MFA_RESYNC which were added
  post-luminous (by 3ab463f9f538a08fd11db2b654004449994dd0fe)

5 years agorgw: Fail radosgw-admin commands on non-master zone that modify metadata
Shilpa Jagannath [Wed, 3 Jul 2019 11:06:52 +0000 (16:36 +0530)]
rgw: Fail radosgw-admin commands on non-master zone that modify metadata
but with an option to override, allowing changes only on the local zone.

Fixes: http://tracker.ceph.com/issues/39548
Signed-off-by: Shilpa Jagannath <smanjara@redhat.com>
(cherry picked from commit 79d884eb018cd2fea9ee9e763d0339b3e8626e6d)

5 years agorgw_admin.cc: do not compare int with boolean
Danny Al-Gaaf [Fri, 13 Oct 2017 19:42:23 +0000 (21:42 +0200)]
rgw_admin.cc: do not compare int with boolean

Fix for:

[src/rgw/rgw_admin.cc:5862]: (warning) Comparison of a boolean
 expression with an integer.

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
(cherry picked from commit d5419143ac5ab0ad8d9e31bd251978b4d9355e46)

5 years agoosd/OSDMap.cc: don't output over/underfull messages to lderr 31598/head
Neha Ojha [Mon, 11 Nov 2019 21:32:15 +0000 (13:32 -0800)]
osd/OSDMap.cc: don't output over/underfull messages to lderr

There can be cases where overfull and underfull(see example in
https://tracker.ceph.com/issues/42756) will be empty, which is not
necessarily an error. These error messages can end up spamming
the ceph-mgr log.

Fixes: https://tracker.ceph.com/issues/42756
Signed-off-by: Neha Ojha <nojha@redhat.com>
(cherry picked from commit 3cf28f09a2ebdd922fc5c1d29c65469f8331e741)

5 years agomgr/prometheus: initializing osd_dev_node = None 31587/head
jiahuizeng [Fri, 25 Oct 2019 09:45:09 +0000 (17:45 +0800)]
mgr/prometheus: initializing osd_dev_node = None

Signed-off-by: jiahuizeng <jhzeng93@foxmail.com>
(cherry picked from commit d7e84a0be1d6113d527a3b525647041775f643e2)

5 years agomgr/prometheus: assign a value to osd_dev_node when obj_store is not filestore or...
jiahuizeng [Tue, 24 Sep 2019 03:01:20 +0000 (11:01 +0800)]
mgr/prometheus: assign a value to osd_dev_node when obj_store is not filestore or bluestore

Fixes: https://tracker.ceph.com/issues/42017
Signed-off-by: jiahuizeng <jhzeng93@foxmail.com>
(cherry picked from commit f5b51a35930bda5499531c75f0c80816afe4ab24)

5 years agoqa/cephfs: test case for timeout config of individual session 31573/head
Yan, Zheng [Tue, 23 Jul 2019 12:21:07 +0000 (20:21 +0800)]
qa/cephfs: test case for timeout config of individual session

Signed-off-by: "Yan, Zheng" <zyan@redhat.com>
(cherry picked from commit 4b28a4a7569ab516d75752c97226f598e6229ca2)

 Conflicts:
qa/tasks/cephfs/test_client_recovery.py

5 years agomds: add command that config individual client session
Yan, Zheng [Thu, 18 Jul 2019 07:31:15 +0000 (15:31 +0800)]
mds: add command that config individual client session

For now, the command only can change session's timeout config

Fixes: http://tracker.ceph.com/issues/40811
Signed-off-by: "Yan, Zheng" <zyan@redhat.com>
(cherry picked from commit a9c21bdaef3473d99ac362122d441b9d869230dd)

 Conflicts:
src/mds/MDSDaemon.cc
src/mds/MDSRank.h
src/mds/mdstypes.h

5 years agomds: allow client to specify its session timeout
Yan, Zheng [Fri, 4 May 2018 03:11:35 +0000 (11:11 +0800)]
mds: allow client to specify its session timeout

This is for ganesha client (it is expected to be reclaimed if it dies)
The default session timeout may be too short to reliably get ganesha
back up.

Signed-off-by: "Yan, Zheng" <zyan@redhat.com>
(cherry picked from commit eb4c36bf23f32cf9117d62660a4919dcfe80baa5)

 Conflicts:
src/client/Client.cc
src/client/Client.h
src/include/cephfs/libcephfs.h
src/libcephfs.cc
src/mds/Server.cc

5 years agoMerge pull request #31433 from smithfarm/wip-42663-luminous
Yuri Weinstein [Fri, 8 Nov 2019 17:21:16 +0000 (09:21 -0800)]
Merge pull request #31433 from smithfarm/wip-42663-luminous

luminous: tests: qa/tasks/ceph.py: pass cluster_name to get_mons

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
Reviewed-by: Yuri Weinstein <yweinste@redhat.com>
5 years agoqa/tasks/ceph: keep mon addrs in ctx namespace 31433/head
Sage Weil [Wed, 19 Dec 2018 03:18:31 +0000 (21:18 -0600)]
qa/tasks/ceph: keep mon addrs in ctx namespace

Signed-off-by: Sage Weil <sage@redhat.com>
(cherry picked from commit 545df766bef04b1a70380ac04909b2a88521e4da)

5 years agoqa/tasks/mon_seesaw: make get_mon_status use mon addr
Nathan Cutler [Thu, 7 Nov 2019 12:37:09 +0000 (13:37 +0100)]
qa/tasks/mon_seesaw: make get_mon_status use mon addr

We don't have the 'mon addr' config property any more.

This commit cannot be cherry-picked from master because qa/tasks/mon_seesaw.py
was dropped in nautilus.

Signed-off-by: Nathan Cutler <ncutler@suse.com>
5 years agoqa/tasks/ceph_manager: make get_mon_status use mon addr
Sage Weil [Wed, 19 Dec 2018 03:18:57 +0000 (21:18 -0600)]
qa/tasks/ceph_manager: make get_mon_status use mon addr

We don't have the 'mon addr' config property any more.

Signed-off-by: Sage Weil <sage@redhat.com>
(cherry picked from commit ac2430a43ddec469575a25be4aff75ce1628eee2)

5 years agoqa/tasks/ceph.py/create_simple_monmap: use split_role
Nathan Cutler [Wed, 6 Nov 2019 07:00:45 +0000 (08:00 +0100)]
qa/tasks/ceph.py/create_simple_monmap: use split_role

This cannot be cherry-picked from master because it fixes an issue that was
introduced into luminous by a bad backport.

Fixes: c543810cd426819538b07d2f60ebd8cdd76b9b93
Fixes: https://tracker.ceph.com/issues/42658
Signed-off-by: Nathan Cutler <ncutler@suse.com>
5 years agoqa/tasks/ceph.py: pass cluster_name to get_mons
Nathan Cutler [Tue, 5 Nov 2019 18:10:15 +0000 (19:10 +0100)]
qa/tasks/ceph.py: pass cluster_name to get_mons

This cannot be cherry-picked from master because it fixes an issue that was
introduced into luminous by a bad backport.

Fixes: c543810cd426819538b07d2f60ebd8cdd76b9b93
Fixes: https://tracker.ceph.com/issues/42658
Signed-off-by: Nathan Cutler <ncutler@suse.com>
5 years agoMerge PR #31286 into luminous
Patrick Donnelly [Thu, 7 Nov 2019 04:39:13 +0000 (20:39 -0800)]
Merge PR #31286 into luminous

* refs/pull/31286/head:
mds: cleanup truncating inodes when standby replay mds trim log segments

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
5 years agoqa: use recent kernel to kernel build testing 31450/head
Patrick Donnelly [Tue, 7 Aug 2018 01:33:40 +0000 (18:33 -0700)]
qa: use recent kernel to kernel build testing

Fixes: http://tracker.ceph.com/issues/24679
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
(cherry picked from commit f0fe0936e64dde2be7139340489960b9635316c2)

Conflicts:
qa/cephfs/begin.yaml : Resolved for extra_system_packages
(cherry picked from commit 1cf09acdca619407c8d3438049138a42fb845d70)

5 years agoqa: use cephfs standard configs for kclient
Patrick Donnelly [Mon, 20 Aug 2018 20:51:35 +0000 (13:51 -0700)]
qa: use cephfs standard configs for kclient

Specifically, qa/cephfs/begin.yaml.

Fixes: http://tracker.ceph.com/issues/26967
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
(cherry picked from commit 862b84c1e8f496be71666c35c11c665c5c259a43)
(cherry picked from commit 8e483d9bb27a193c85b233b6da4231b30b63e0f4)

5 years agoqa: fix malformed suite config 31449/head
Patrick Donnelly [Wed, 31 Jul 2019 17:11:45 +0000 (10:11 -0700)]
qa: fix malformed suite config

Fixes: https://tracker.ceph.com/issues/41031
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
(cherry picked from commit 31492bb09502082868c95762f6eff46df12913a7)

5 years agoMerge pull request #31234 from smithfarm/wip-42548-luminous
Yuri Weinstein [Tue, 5 Nov 2019 20:44:12 +0000 (12:44 -0800)]
Merge pull request #31234 from smithfarm/wip-42548-luminous

luminous: crush: remove invalid upmap items

Reviewed-by: xie xingguo <xie.xingguo@zte.com.cn>
5 years agoMerge pull request #30329 from smithfarm/wip-41626-luminous
Yuri Weinstein [Tue, 5 Nov 2019 15:25:59 +0000 (07:25 -0800)]
Merge pull request #30329 from smithfarm/wip-41626-luminous

luminous: rgw: RGWCoroutine::call(nullptr) sets retcode=0

Reviewed-by: Casey Bodley <cbodley@redhat.com>
5 years agoMerge pull request #30674 from smithfarm/wip-41382-luminous
Yuri Weinstein [Tue, 5 Nov 2019 15:23:52 +0000 (07:23 -0800)]
Merge pull request #30674 from smithfarm/wip-41382-luminous

luminous: rgw: housekeeping of reset stats operation in radosgw-admin and cls back-end

Reviewed-by: J. Eric Ivancich <ivancich@redhat.com>
5 years agoMerge pull request #30254 from smithfarm/wip-41706-luminous
Yuri Weinstein [Tue, 5 Nov 2019 15:23:04 +0000 (07:23 -0800)]
Merge pull request #30254 from smithfarm/wip-41706-luminous

luminous: rgw: fix cls_bucket_list_unordered() partial results

Reviewed-by: Casey Bodley <cbodley@redhat.com>
Reviewed-by: Matt Benjamin <mbenjami@redhat.com>
Reviewed-by: J. Eric Ivancich <ivancich@redhat.com>
5 years agoMerge pull request #30198 from taodd/backport-41111
Yuri Weinstein [Tue, 5 Nov 2019 15:22:11 +0000 (07:22 -0800)]
Merge pull request #30198 from taodd/backport-41111

luminous: rgw: fix drain handles error when deleting bucket with bypass-gc option

Reviewed-by: Casey Bodley <cbodley@redhat.com>
5 years agoMerge pull request #31277 from dzafman/wip-network-fix-luminous
Yuri Weinstein [Mon, 4 Nov 2019 21:28:10 +0000 (13:28 -0800)]
Merge pull request #31277 from dzafman/wip-network-fix-luminous

luminous: core: osd: Fix for compatibility of encode/decode of osd_stat_t

Reviewed-by: Sage Weil <sage@redhat.com>
5 years agoMerge pull request #30842 from smithfarm/wip-42264-luminous
Yuri Weinstein [Mon, 4 Nov 2019 20:44:58 +0000 (12:44 -0800)]
Merge pull request #30842 from smithfarm/wip-42264-luminous

luminous: tests: do not take ceph.conf.template from ceph/teuthology.git

Reviewed-by: Yuri Weinstein <yweinste@redhat.com>
5 years agoMerge pull request #30945 from smithfarm/wip-40318-luminous
Yuri Weinstein [Mon, 4 Nov 2019 20:44:17 +0000 (12:44 -0800)]
Merge pull request #30945 from smithfarm/wip-40318-luminous

luminous: tests: qa/workunits/rados/test_librados_build.sh: install build deps

Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Yuri Weinstein <yweinste@redhat.com>
5 years agoMerge pull request #31272 from badone/wip-luminous-restful-node-items
Yuri Weinstein [Mon, 4 Nov 2019 20:42:20 +0000 (12:42 -0800)]
Merge pull request #31272 from badone/wip-luminous-restful-node-items

luminous: restful: Query nodes_by_id for items

Reviewed-by: Boris Ranto <branto@redhat.com>
5 years agoMerge pull request #31278 from tchaikov/wip-luminous/42580
Yuri Weinstein [Mon, 4 Nov 2019 20:40:11 +0000 (12:40 -0800)]
Merge pull request #31278 from tchaikov/wip-luminous/42580

luminous: tests: install python3-cephfs for fs suite

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: Nathan Cutler <ncutler@suse.com>
Reviewed-by: Yuri Weinstein <yweinste@redhat.com>
5 years agoMerge pull request #31293 from smithfarm/wip-42586-luminous
Yuri Weinstein [Mon, 4 Nov 2019 20:38:54 +0000 (12:38 -0800)]
Merge pull request #31293 from smithfarm/wip-42586-luminous

luminous: core: osd: fix out of order caused by letting old msg from down osd be processed

Reviewed-by: Yuri Weinstein <yweinste@redhat.com>
Reviewed-by: Greg Farnum <gfarnum@redhat.com>
5 years agoMerge pull request #30446 from tchaikov/wip-luminous-37866
Yuri Weinstein [Mon, 4 Nov 2019 20:29:42 +0000 (12:29 -0800)]
Merge pull request #30446 from tchaikov/wip-luminous-37866

luminous: mgr/localpool: pg_num is an int arg to 'osd pool create'

Reviewed-by: Neha Ojha <nojha@redhat.com>
5 years agoMerge pull request #30519 from smithfarm/wip-41864-luminous
Yuri Weinstein [Mon, 4 Nov 2019 20:29:16 +0000 (12:29 -0800)]
Merge pull request #30519 from smithfarm/wip-41864-luminous

luminous: mon: ensure prepare_failure() marks no_reply on op

Reviewed-by: Neha Ojha <nojha@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>