rgw/multisite: drain children before collect() returns error in RGWInitDataSyncStatusCoroutine()

Signed-off-by: Shilpa Jagannath <smanjara@redhat.com>

Merge pull request #66431 from cbodley/wip-doc-release-os-recommendations

doc: add Tentacle to os recommendations

Reviewed-by: Ville Ojamo <14869000+bluikko@users.noreply.github.com>
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>

doc: remove redundant note about tested container hosts

Signed-off-by: Casey Bodley <cbodley@redhat.com>

doc: remove old distros from os recommendations

Signed-off-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #63794 from clwluvw/enc-copy

rgw: implement CopyObject for encrypted objects

Reviewed-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #66410 from aclamk/aclamk-encode-fix-debug-macro

encode: Fix bad use of DENC_DUMP_PRE

Merge pull request #66407 from rhcs-dashboard/redirect-other-propery-name

mgr/dashboard: support custom prop for table item redirection

Reviewed-by: Afreen Misbah <afreen@ibm.com>

Merge pull request #66437 from rhcs-dashboard/fix-74008-main

mgr/dashboard: fix multi-cluster route reload logic

Reviewed-by: Afreen Misbah <afreen@ibm.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>

Merge pull request #66346 from rhcs-dashboard/fix-service-form

mgr/dashboard: service creation fails if service name is same as sevice type

Reviewed-by: Afreen Misbah <afreen@ibm.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>

Merge pull request #66436 from rhcs-dashboard/add-sagar--to-mailmap-githubmap-organizationmap

add Sagar Gopale to githubmap mailmap organizationmap

Reviewed-by: Afreen Misbah <afreen@ibm.com>
Reviewed-by: Abhishek Desai <abhishek.desai1@ibm.com>

Merge pull request #65433 from mohit84/repeer_on_acting

test: repeer_on_down_acting_member_coming_back is continuously failing

mgr/dashboard: support custom prop for table item redirection

use an extra customTemplateConfig called `customRowProperty` where
you can provide the key of the property you wish to route, instead of
relying on the cell's prop itself

Fixes: https://tracker.ceph.com/issues/73989
Signed-off-by: Nizamudeen A <nia@redhat.com>

mgr/dashboard: fix multi-cluster route reload logic

Issue: Route was being force-reloaded using a two-step navigation hack causing unnecessary redirects and side effects.
Fix: Replaced the hack with Angular’s native same-URL reload using onSameUrlNavigation: 'reload' for a clean, stable route refresh.

Fixes: https://tracker.ceph.com/issues/74008
Signed-off-by: Aashish Sharma <aasharma@redhat.com>

doc: remove os recommendations for eol releases

Signed-off-by: Casey Bodley <cbodley@redhat.com>

doc/dev: add os-recommendations.rst to release checklist

Signed-off-by: Casey Bodley <cbodley@redhat.com>

doc: add Tentacle to os recommendations

Signed-off-by: Casey Bodley <cbodley@redhat.com>

doc: remove Octopus and Centos7 from os recommendations

cleanup to prepare for tentacle

Signed-off-by: Casey Bodley <cbodley@redhat.com>

add Sagar Gopale to githubmap mailmap organizationmap
Signed-off-by: Sagar Gopale <sagar.gopale@ibm.com>

encode: Fix bad use of DENC_DUMP_PRE

Signed-off-by: Adam Kupczyk <akupczyk@ibm.com>

rgw: fix offset calculation in copy_obj_data

Set ofs to total bytes read by adding 1 to end offset.
Since 'end' represents the last byte offset (zero-indexed),
we need to add 1 to get the actual number of bytes copied.

Signed-off-by: Seena Fallah <seenafallah@gmail.com>

Merge pull request #66333 from shraddhaag/wip-shraddhaag-increase-reactors

qa/clusters/crimson: increase reactors count

Merge pull request #66336 from Matan-B/wip-matanb-crimson-snapmapper-osddriver

osd/SnapMapper: fix Crimson logs

Reviewed-by: Aishwarya Mathuria <amathuri@redhat.com>

Merge pull request #66332 from rhcs-dashboard/73854-CephFS-Authorize-modal-Update-issues

mgr/dashboard : fix - CephFS Authorize Modal Update issue

Reviewed-by: Dnyaneshwari Talwekar dtalweka@redhat.com

Merge pull request #66382 from bluikko/doc-mgmt-gateway-improvements-cephadm

doc/cephadm: Fix command plus improvements in services/mgmt-gateway.rst

Merge pull request #66006 from afreen23/carbonize-chnage-password

mgr/dashboard: Carbonize the Change Password Form

Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Dnyaneshwari Talwekar dtalweka@redhat.com

Merge pull request #66326 from afreen23/fixes-mixins

monitoring: Fixes for development

Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Anthony D Atri <anthony.datri@gmail.com>

mgr/dashboard : fix - CephFS Authorize Modal Update issue
fixes : https://tracker.ceph.com/issues/73854
Signed-off-by: Devika Babrekar <devika.babrekar@ibm.com>

doc/cephadm: Fix command plus improvements in service/mgmt-gateway.rst

Remove double backticks from a CLI command.

Use bash prompt consistently for CLI command blocks.

Don't capitalize word in middle of sentence.

Talk about "admin" instead of "user", similarly to the last text
paragraph in the doc.

Signed-off-by: Ville Ojamo <14869000+bluikko@users.noreply.github.com>

qa/clusters/crimson: increase reactors count

This commit increases the number of reactors in fixed-1 and
fixed-2 crimson clusters.

Signed-off-by: Shraddha Agrawal <shraddhaag@ibm.com>

mgr/dashboard: Carbonize the Change Password Form

Fixes https://tracker.ceph.com/issues/73193

-  using carbon based stylings, typography and components
-  used grid layout for form arrangement
-  breadcrumb is slightly off, which needs to be fixed by applying grid layout to the app shell

Signed-off-by: Afreen Misbah <afreen@ibm.com>

Merge pull request #66372 from tchaikov/wip-qa-encoder-exclude

qa/suites/rados/encoder: exclude ceph-osd-classic when installing LTS…

Reviewed-by: Matan Breizman <mbreizma@ibm.com>

qa/suites/rados/encoder: exclude ceph-osd-* when installing LTS releases

In a37b5b5, the ceph-osd-classic and ceph-osd-crimson packages were
added to qa/packages/packages.yaml. The "install" task uses this file as
the default package list for all branches, including LTS releases like
Reef.

However, a37b5b5 only exists in the main branch and won't be backported
to LTS branches. This causes installation failures in the rados/encoder
test suite, which verifies forward compatibility by installing LTS
releases and testing whether they can decode the latest corpus.

Exclude ceph-osd-classic and ceph-osd-crimson from LTS installations to
ensure the test suite can successfully install ceph-dencoder, which is
required for the interoperability tests.

Fixes: https://tracker.ceph.com/issues/73957
Signed-off-by: Kefu Chai <k.chai@proxmox.com>

Merge pull request #66293 from anthonyeleven/instore.dbnoonecanhearyouscream

doc: Improve start/hardware-recommendations.rst

Merge pull request #65995 from pcuzner/rocksdb_compaction_metric

rados/osd: enable compact_running perfcounter at PRIO=5

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Reviewed-by: Neha Ojha <nojha@ibm.com>

doc: Improve start/hardware-recommendations.rst

Signed-off-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>

mgr/dashboard: service creation fails if service name is same as service type

Fixes: https://tracker.ceph.com/issues/73948
Signed-off-by: Naman Munet <naman.munet@ibm.com>

rgw: sanitize copy source attrs

Co-authored-by: Marcus Watts <mwatts@redhat.com>
Signed-off-by: Seena Fallah <seenafallah@gmail.com>

osd/SnapMapper: fix Crimson logs

Switch to crimson's debugging macro and fix the faulty
subsystem defined of ceph_subsys_

Might help with https://tracker.ceph.com/issues/73790

Signed-off-by: Matan Breizman <mbreizma@redhat.com>

rgw: verify sse-c headers on multipart completion

Co-authored-by: Marcus Watts <mwatts@redhat.com>
Signed-off-by: Seena Fallah <seenafallah@gmail.com>

Merge pull request #55638 from clwluvw/cmake-boost

cmake: skip boost dependency on ALIAS executable targets

Merge pull request #66228 from imran-imtiaz/dashboard

mgr/dashboard: add API endpoint to add images to consistency groups

Reviewed-by: Nizamudeen A <nia@redhat.com>

Merge pull request #65915 from edwinzrodriguez/ceph-zstd-update

zstd: Update zstd to 1.5.6 for cmake 4 compatability

cmake: skip boost dependency on ALIAS executable targets

The current add_executable override in Boost does not support alias
targets. Although Ceph currently has no alias targets that are
affected by this limitation, addressing this issue now will benefit
future developments and personal projects.
This change enhances the robustness of the override logic, ensuring
compatibility with alias targets moving forward.

Signed-off-by: Seena Fallah <seenafallah@gmail.com>

monitoring: Fixes for development

- fixes tox.ini using and undefined env - `grafonnet-check`( instead of `jsonnet-check`)
- adds steps for local development of mixins and building jsonnet
- added help command in Makefile
- added comments and descriptions for Makefile and tox.ini

Signed-off-by: Afreen Misbah <afreen@ibm.com>

rgw: always return crypt headers on put obj

Co-authored-by: Marcus Watts <mwatts@redhat.com>
Signed-off-by: Seena Fallah <seenafallah@gmail.com>

rgw: expose copy_source from rgw_s3_prepare_decrypt

Co-authored-by: Marcus Watts <mwatts@redhat.com>
Signed-off-by: Seena Fallah <seenafallah@gmail.com>

rgw: fix lifecycle transition of encrypted multipart objects

Lifecycle transtion can copy objects to a different storage tier.
When this happens, since the object is repacked, the original
manifest is invalidated.  It is necessary to store a special
"parts_len" attribute to fix this.  There was code in PutObj
to handle this, but that was only used for multisite replication,
it is not used by the lifecycle transisiton code.  This fix
adds similar logic to the lifecycle transition code path to make the
same thing happen.

Fixes: https://tracker.ceph.com/issues/23264
Signed-off-by: Marcus Watts <mwatts@redhat.com>

rgw: set compression attrs in copy_obj_data()

Co-authored-by: Marcus Watts <mwatts@redhat.com>
Signed-off-by: Seena Fallah <seenafallah@gmail.com>

rgw: implement CopyObject for encrypted object

Pass RGWCopyObjDPF to copy_object() for RGWCopyObj so it can decrypt
and/or encrypt the object on copy if needed.

Co-authored-by: Marcus Watts <mwatts@redhat.com>
Signed-off-by: Seena Fallah <seenafallah@gmail.com>

rgw: introduce RGWCopyObjDPF for RGWCopyObj

This will construct a DataProcessorFactory where it will apply
filters such as decrypt and decompress when a data is being read
and encrypt and compression when the data wants to be written.

Co-authored-by: Marcus Watts <mwatts@redhat.com>
Signed-off-by: Seena Fallah <seenafallah@gmail.com>

rgw: introduce DataProcessorFilter

DataProcessor to RGWGetObj_Filter pipe where allows a RGWGetObj_Filter
instance to process DataProcessor.

Co-authored-by: Marcus Watts <mwatts@redhat.com>
Signed-off-by: Seena Fallah <seenafallah@gmail.com>

rgw: pass DataProcessorFactory to copy_object

Co-authored-by: Marcus Watts <mwatts@redhat.com>
Signed-off-by: Seena Fallah <seenafallah@gmail.com>

rgw/sal: introduce DataProcessorFactory

This is a factory for DataProcessor to enable reading the data by
RGWGetObj_Filter and pass it to be processed by the writer that is
defined by set_writer().
With that, we can have filters applied to the data before writing.
That can be either filter on read or filter on write.

Co-authored-by: Marcus Watts <mwatts@redhat.com>
Signed-off-by: Seena Fallah <seenafallah@gmail.com>

rgw: gather all get_decrypt_filter together

Define one get_decrypt_filter() in rgw_op so others can call the
same rather redefining it.

Co-authored-by: Marcus Watts <mwatts@redhat.com>
Signed-off-by: Seena Fallah <seenafallah@gmail.com>

rgw: teach rgw_s3_prepare_decrypt about source decrypt headers

Co-authored-by: Marcus Watts <mwatts@redhat.com>
Signed-off-by: Seena Fallah <seenafallah@gmail.com>

rgw: involve next on RGWGetObj_BlockDecrypt::flush

Co-authored-by: Marcus Watts <mwatts@redhat.com>
Signed-off-by: Seena Fallah <seenafallah@gmail.com>

rgw: involve next on RGWGetObj_BlockDecrypt::fixup_range

Co-authored-by: Marcus Watts <mwatts@redhat.com>
Signed-off-by: Seena Fallah <seenafallah@gmail.com>

Merge pull request #66268 from Matan-B/wip-matanb-old-clients-installs

qa/suites/thrash-old-clients/1-install: exclude ceph-osd-classic

Reviewed-by: Radosław Zarzyński <rzarzyns@redhat.com>
Reviewed-by: Laura Flores <lflores@redhat.com>

mgr/dashboard: add API endpoint to add images to consistency groups

Signed-off-by: Imran Imtiaz <imran.imtiaz@uk.ibm.com>
Fixes: https://tracker.ceph.com/issues/73840
Create a consistency group dashboard API endpoint that enables adding
RBD images to the group.

Merge pull request #62765 from bobham-bloomberg/unittest-ceph-assert

test/ceph_assert.cc: Disable core files

Merge pull request #66307 from shraddhaag/wip-shraddhaag-fix-slow-ops

qa/clusters/crimson: increase reactors in fixed-1 cluster

Reviewed-by: Matan Breizman <mbreizma@ibm.com>

Merge pull request #65971 from ceph/wip-20.2.0-documentation

doc: add Tentacle v20.2.0 release notes

Merge pull request #65374 from dang/wip-dang-standalone

RGW - Standalone - Enable building without librados

doc/releases: add cephadm notes

Signed-off-by: Laura Flores <lflores@ibm.com>

doc/releases: change final release date

Signed-off-by: Laura Flores <lflores@ibm.com>

doc/releases/tentacle: add missing rgw deprecation notice

Signed-off-by: Casey Bodley <cbodley@redhat.com>

doc/releases/tentacle: fix Crimson highlight

Signed-off-by: Matan Breizman <mbreizma@redhat.com>

doc/releases/tentacle: add Crimson highlight

Signed-off-by: Matan Breizman <mbreizma@redhat.com>

doc/releases: arrange sections in alphabetical order

Signed-off-by: Laura Flores <lflores@ibm.com>

doc/releases/tentacle.rst: more RBD items

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>

doc/releases/tentacle.rst: fix seastore typo

Signed-off-by: Matan Breizman <mbreizma@redhat.com>

doc/releases: remove extra word

Signed-off-by: Laura Flores <lflores@ibm.com>

doc/releases/tentacle.rst: Update Crimson section

Refer to Tentacle Crimson updates blog post

Signed-off-by: Matan Breizman <mbreizma@redhat.com>

doc/releases: remove note that is not specific to tentacle

Signed-off-by: Laura Flores <lflores@ibm.com>

doc/releases: move smb support update into highlights

Signed-off-by: Laura Flores <lflores@ibm.com>

doc/releases: give smb update a better category title

Signed-off-by: Laura Flores <lflores@ibm.com>

doc/releases: add Crimson section and clean up references

Signed-off-by: Laura Flores <lflores@ibm.com>

doc/releases: edit formatting and other small changes

Formatting with double backticks, indentation etc.

Fix some typos and add missing hyphenation.

Add review comment suggestions by anthonyeleven after OOB discussion.

Signed-off-by: Ville Ojamo <14869000+bluikko@users.noreply.github.com>

doc/releases: add one more item to RADOS

Signed-off-by: Laura Flores <lflores@ibm.com>

doc/releases: add to CephFS section

And a bit of RGW

Signed-off-by: Laura Flores <lflores@ibm.com>

doc/releases: add more to RBD section

Signed-off-by: Laura Flores <lflores@ibm.com>

doc/releases: clean up RGW formatting

Signed-off-by: Laura Flores <lflores@ibm.com>

doc/releases: take quincy out of timeline since it is EOL

Signed-off-by: Laura Flores <lflores@ibm.com>

doc/releases: add more to mgr section and fix rados formatting

Signed-off-by: Laura Flores <lflores@ibm.com>

doc: improve rados section for tentacle release notes

Signed-off-by: Laura Flores <lflores@ibm.com>

doc/tentacle: add more RGW release notes

Signed-off-by: Casey Bodley <cbodley@redhat.com>

doc: add Tentacle v20.2.0 release notes

Signed-off-by: Laura Flores <lflores@ibm.com>

qa/clusters/crimson: increase reactors in fixed-1 cluster

Issue: Various different tests were failing randomly due to slow
ops. There was no common ground between them, it was happening
across differnet object stores (seastore and bluestore) and
across different tests.

Cause: Since this is happening quite randomly, this is likely
happening due to low reactor count.

Solution: We are opting the solution to increase reactors used
for testing. I've increased them to 3 from the initial 2 value.

Fixes: https://tracker.ceph.com/issues/72778
Signed-off-by: Shraddha Agrawal <shraddha.agrawal000@gmail.com>

Merge pull request #66207 from steliaio/fix-rados-fsid-return-doc

include/rados/librados.h: fix documented rados_cluster_fsid return value

Reviewed-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #66259 from rhcs-dashboard/add-panel-footer

mgr/dashboard: add footer to side-panel

Reviewed-by: Nizamudeen A <nia@redhat.com>

Merge pull request #66253 from rhcs-dashboard/add-to-mailmap-githubmap-organizationmap

Add Devika Babrekar into githubmap, organizationmap, mailmap

Reviewed-by: Afreen Misbah <afreen@ibm.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>

Merge pull request #66291 from afreen23/illegible-text

mgr/dashboard: Remove illegible texts from the dashboard

Reviewed-by: Nizamudeen A <nia@redhat.com>

Merge pull request #66246 from nbalacha/wip-nbalacha-73812

rgw/notify: fix reading the entries in a loop

Merge pull request #66299 from solmagd/wip-doc-release-dates-jd

doc: Added release dates to 18.2.5 to 18.2.7 and 19.2.0 to 19.2.3.

Reviewed-by: Laura Flores <lflores@ibm.com>

test/ceph_assert.cc: Disable core files

Without this, core files are produced which subsequently cause
failures in other tests, specifically smoke.sh and safe-to-destroy.sh.

Fixes: bfa83df6d33ee2238f1389ca4518592b5c4fb267
Signed-off-by: Bob Ham <bham12@bloomberg.net>
test/ceph_assert.cc: Update line numbers

Signed-off-by: Bob Ham <bham12@bloomberg.net>

doc: Added release dates to reef 18.2.5 to 18.2.7 and squid 19.2.0 to 19.2.3 inclusive.

Signed-off-by: Joel Davidow <jdavidow@nso.edu>

Merge pull request #66105 from rhcs-dashboard/carbonize-sync-policy-form

mgr/dashboard: Carbonize multisite sync policy forms

Reviewed-by: Pedro Gonzalez Gomez <pegonzal@ibm.com>

qa/suites: exclude ceph-osd-classic

a37b5b5bde8c2e8d6890f16b31046119ed55f25d added ceph-osd-classic
package.
old-clients and upgrade tests should not try to install the new package
as it is not available in older releases.

Fixes: https://tracker.ceph.com/issues/73848
Signed-off-by: Matan Breizman <mbreizma@redhat.com>

mgr/dashboard: Remove illegible texts from the dashboard

Signed-off-by: Afreen Misbah <afreen@ibm.com>

mgr/dashboard: add footer to side-panel

Fixes: https://tracker.ceph.com/issues/73788Wq
Signed-off-by: Naman Munet <naman.munet@ibm.com>