]> git.apps.os.sepia.ceph.com Git - ceph.git/log
ceph.git
4 years agoMerge pull request #36594 from matthewoliver/ipv6_prometheus_module
Jan Fajerski [Wed, 2 Sep 2020 13:52:45 +0000 (15:52 +0200)]
Merge pull request #36594 from matthewoliver/ipv6_prometheus_module

prometheus: Properly split the port off IPv6 addresses

4 years agoMerge pull request #34293 from yuvalif/notifications_persistent_delivery2
Casey Bodley [Wed, 2 Sep 2020 13:35:57 +0000 (09:35 -0400)]
Merge pull request #34293 from yuvalif/notifications_persistent_delivery2

rgw/notifications: add persistent delivery to notifications

Reviewed-by: Matt Benjamin <mbenjamin@redhat.com>
Reviewed-by: Casey Bodley <cbodley@redhat.com>
4 years agoMerge pull request #36847 from X0Ken/fix-journal-size
Jan Fajerski [Wed, 2 Sep 2020 13:33:30 +0000 (15:33 +0200)]
Merge pull request #36847 from X0Ken/fix-journal-size

ceph-volume: fix journal size argument not work

4 years agoMerge pull request #36545 from AmnonHanuhov/wip-seastar_metrics
Radoslaw Zarzynski [Wed, 2 Sep 2020 12:49:11 +0000 (14:49 +0200)]
Merge pull request #36545 from AmnonHanuhov/wip-seastar_metrics

crimson/admin: Add a hook for Seastar metrics

Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
4 years agoMerge pull request #36743 from cbodley/wip-rgw-sal-bucket-ctime
Daniel Gryniewicz [Wed, 2 Sep 2020 12:36:19 +0000 (08:36 -0400)]
Merge pull request #36743 from cbodley/wip-rgw-sal-bucket-ctime

rgw: RGWBucket uses creation_time from RGWBucketInfo

4 years agoceph-volume: fix journal size argument not work 36847/head
wanghongxu [Thu, 27 Aug 2020 07:11:28 +0000 (15:11 +0800)]
ceph-volume: fix journal size argument not work

Journal size argument not work in batch prepare
filestore with SSD journal device.

Fixes: https://tracker.ceph.com/issues/41374
Signed-off-by: wanghongxu <wanghongxu@t2cloud.net>
4 years agoMerge pull request #35802 from rhcs-dashboard/wip-46160-fix_cephfs_api_inconsistency
Lenz Grimmer [Wed, 2 Sep 2020 10:29:59 +0000 (12:29 +0200)]
Merge pull request #35802 from rhcs-dashboard/wip-46160-fix_cephfs_api_inconsistency

mgr/dashboard: Address API inconsistencies in Cephfs endpoint

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Laura Paduano <lpaduano@suse.com>
Reviewed-by: Tatjana Dehler <tdehler@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>
4 years agoMerge pull request #36873 from sebastian-philipp/cephadm-osd-activate-rm-storage
Sebastian Wagner [Wed, 2 Sep 2020 07:26:42 +0000 (09:26 +0200)]
Merge pull request #36873 from sebastian-philipp/cephadm-osd-activate-rm-storage

cephadm: properly remove `osd-activate` container

Reviewed-by: Michael Fritch <mfritch@suse.com>
4 years agocrimson/osd: Register Seastar metrics hook 36545/head
Amnon Hanuhov [Mon, 10 Aug 2020 12:38:49 +0000 (15:38 +0300)]
crimson/osd: Register Seastar metrics hook

Signed-off-by: Amnon Hanuhov <ahanukov@redhat.com>
4 years agocrimson/admin: Add Seastar metrics hook
Amnon Hanuhov [Mon, 10 Aug 2020 12:31:08 +0000 (15:31 +0300)]
crimson/admin: Add Seastar metrics hook

Signed-off-by: Amnon Hanuhov <ahanukov@redhat.com>
4 years agoMerge pull request #36923 from rhcs-dashboard/fix-47232-master
Lenz Grimmer [Wed, 2 Sep 2020 07:03:15 +0000 (09:03 +0200)]
Merge pull request #36923 from rhcs-dashboard/fix-47232-master

mgr/dashboard/api: print logs when vstart fails

Reviewed-by: Laura Paduano <lpaduano@suse.com>
4 years agoMerge pull request #36222 from ishanrai05/docs
Lenz Grimmer [Wed, 2 Sep 2020 06:51:15 +0000 (08:51 +0200)]
Merge pull request #36222 from ishanrai05/docs

doc: Create new chapter about the Dashboard's landing page

Reviewed-by: Laura Paduano <lpaduano@suse.com>
Reviewed-by: Stephan Müller <smueller@suse.com>
4 years agoMerge pull request #34644 from rhcs-dashboard/26954-histogram
Lenz Grimmer [Wed, 2 Sep 2020 06:28:49 +0000 (08:28 +0200)]
Merge pull request #34644 from rhcs-dashboard/26954-histogram

mgr/dashboard: Remove Histogram Component

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Laura Paduano <lpaduano@suse.com>
Reviewed-by: Tiago Melo <tmelo@suse.com>
4 years agoMerge pull request #36869 from tchaikov/wip-mon-no-MMonMetadata
Kefu Chai [Wed, 2 Sep 2020 02:18:57 +0000 (10:18 +0800)]
Merge pull request #36869 from tchaikov/wip-mon-no-MMonMetadata

mon/Monitor: do not handle MMonMetadata

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
4 years agoMerge PR #35697 into master
Patrick Donnelly [Tue, 1 Sep 2020 20:24:59 +0000 (13:24 -0700)]
Merge PR #35697 into master

* refs/pull/35697/head:
doc: document cephfs mirroring developement status
cephfs-mirror: cephfs-mirror daemon
cephfs-mirror: FSMirror class to synchronize directory snaps
common: introduce configuration options for cephfs-mirror daemon
cephfs-mirror: InstanceWatcher class to register mirror instance
cephfs-mirror: MirrorWatcher class to watch cephfs-mirror object
cephfs-mirror: Watcher class to receive/ack watch notifications
cephfs-mirror: ClusterWatcher class for watching peer changes
librados: add API for fetching client addrs
common: add cephfs_mirror subsystem
cephfs-mirror: filesystem specification class

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
4 years agoMerge pull request #35899 from myoungwon/wip-fix-manifest-tier
Samuel Just [Tue, 1 Sep 2020 19:49:57 +0000 (12:49 -0700)]
Merge pull request #35899 from myoungwon/wip-fix-manifest-tier

osd, test: refactoring manfiest-tier

Reviewed-by: Samuel Just <sjust@redhat.com>
4 years agoMerge pull request #36915 from yuriw/wip-yuriw-46529-master
Yuri Weinstein [Tue, 1 Sep 2020 15:52:47 +0000 (08:52 -0700)]
Merge pull request #36915 from yuriw/wip-yuriw-46529-master

qa/tests: use bionic only for old clients in rados/thrash-old-clients

Reviewed-by: Sebastian Wagner <sebastian.wagner@suse.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
4 years agoMerge pull request #36700 from leseb/retry-on-lock
Jan Fajerski [Tue, 1 Sep 2020 13:12:08 +0000 (15:12 +0200)]
Merge pull request #36700 from leseb/retry-on-lock

ceph-volume: retry when acquiring lock fails

4 years agoMerge pull request #36889 from idryomov/wip-relax-preauth-asserts
Ilya Dryomov [Tue, 1 Sep 2020 11:39:13 +0000 (13:39 +0200)]
Merge pull request #36889 from idryomov/wip-relax-preauth-asserts

msg/async/ProtocolV2: allow rxbuf/txbuf get bigger in testing

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
4 years agomgr/dashboard/api: print logs when vstart fails 36923/head
Ernesto Puerta [Tue, 1 Sep 2020 11:32:11 +0000 (13:32 +0200)]
mgr/dashboard/api: print logs when vstart fails

Fixes: https://tracker.ceph.com/issues/47232
Signed-off-by: Ernesto Puerta <epuertat@redhat.com>
4 years agoMerge pull request #36241 from jan--f/c-v-mpath-support
Jan Fajerski [Tue, 1 Sep 2020 11:29:32 +0000 (13:29 +0200)]
Merge pull request #36241 from jan--f/c-v-mpath-support

ceph-volume: support for mpath devices

4 years agodoc: document cephfs mirroring developement status 35697/head
Venky Shankar [Mon, 31 Aug 2020 12:34:47 +0000 (08:34 -0400)]
doc: document cephfs mirroring developement status

Signed-off-by: Venky Shankar <vshankar@redhat.com>
4 years agocephfs-mirror: cephfs-mirror daemon
Venky Shankar [Thu, 18 Jun 2020 05:50:25 +0000 (01:50 -0400)]
cephfs-mirror: cephfs-mirror daemon

Signed-off-by: Venky Shankar <vshankar@redhat.com>
4 years agocephfs-mirror: FSMirror class to synchronize directory snaps
Venky Shankar [Thu, 18 Jun 2020 05:41:26 +0000 (01:41 -0400)]
cephfs-mirror: FSMirror class to synchronize directory snaps

Signed-off-by: Venky Shankar <vshankar@redhat.com>
4 years agocommon: introduce configuration options for cephfs-mirror daemon
Venky Shankar [Wed, 12 Aug 2020 10:25:07 +0000 (06:25 -0400)]
common: introduce configuration options for cephfs-mirror daemon

Signed-off-by: Venky Shankar <vshankar@redhat.com>
4 years agocephfs-mirror: InstanceWatcher class to register mirror instance
Venky Shankar [Thu, 18 Jun 2020 05:30:55 +0000 (01:30 -0400)]
cephfs-mirror: InstanceWatcher class to register mirror instance

... and watch for notifications via instance object.

Signed-off-by: Venky Shankar <vshankar@redhat.com>
4 years agocephfs-mirror: MirrorWatcher class to watch cephfs-mirror object
Venky Shankar [Thu, 9 Jul 2020 10:41:45 +0000 (06:41 -0400)]
cephfs-mirror: MirrorWatcher class to watch cephfs-mirror object

... and ack details such as instance-id and address.

Signed-off-by: Venky Shankar <vshankar@redhat.com>
4 years agocephfs-mirror: Watcher class to receive/ack watch notifications
Venky Shankar [Thu, 18 Jun 2020 04:55:57 +0000 (00:55 -0400)]
cephfs-mirror: Watcher class to receive/ack watch notifications

Signed-off-by: Venky Shankar <vshankar@redhat.com>
4 years agocephfs-mirror: ClusterWatcher class for watching peer changes
Venky Shankar [Thu, 18 Jun 2020 04:41:50 +0000 (00:41 -0400)]
cephfs-mirror: ClusterWatcher class for watching peer changes

Signed-off-by: Venky Shankar <vshankar@redhat.com>
4 years agolibrados: add API for fetching client addrs
Venky Shankar [Wed, 29 Jul 2020 07:56:39 +0000 (03:56 -0400)]
librados: add API for fetching client addrs

Signed-off-by: Venky Shankar <vshankar@redhat.com>
4 years agocommon: add cephfs_mirror subsystem
Venky Shankar [Thu, 18 Jun 2020 04:31:41 +0000 (00:31 -0400)]
common: add cephfs_mirror subsystem

Signed-off-by: Venky Shankar <vshankar@redhat.com>
4 years agocephfs-mirror: filesystem specification class
Venky Shankar [Thu, 18 Jun 2020 04:22:41 +0000 (00:22 -0400)]
cephfs-mirror: filesystem specification class

Signed-off-by: Venky Shankar <vshankar@redhat.com>
4 years agoMerge pull request #36917 from zdover23/wip-doc-rados-init-mems-to-mon-host
zdover23 [Tue, 1 Sep 2020 09:23:10 +0000 (19:23 +1000)]
Merge pull request #36917 from zdover23/wip-doc-rados-init-mems-to-mon-host

doc/rados: s/initial members/mon host

Reviewed-by: Brad Hubbard <bhubbard@redhat.com>
4 years agoMerge pull request #36800 from adk3798/cephadm-46654
Sebastian Wagner [Tue, 1 Sep 2020 08:26:35 +0000 (10:26 +0200)]
Merge pull request #36800 from adk3798/cephadm-46654

cephadm: Change service type to forking via systemd

Reviewed-by: Sebastian Wagner <sebastian.wagner@suse.com>
4 years agodoc/rados: s/initial members/mon host 36917/head
Zac Dover [Tue, 1 Sep 2020 04:28:12 +0000 (14:28 +1000)]
doc/rados: s/initial members/mon host

This changes an old string, "initial members"
to a current string, "mon host".

Fixes: https://tracker.ceph.com/issues/47116
Signed-off-by: Zac Dover <zac.dover@gmail.com>
4 years agoMerge pull request #36879 from tchaikov/wip-doc-stable-release
Kefu Chai [Tue, 1 Sep 2020 03:04:23 +0000 (11:04 +0800)]
Merge pull request #36879 from tchaikov/wip-doc-stable-release

doc: bump up sphinx to 3.2.1 and define "stable-release" global substitution

Reviewed-by: Willem Jan Withagen <wjw@digiware.nl>
Reviewed-by: Neha Ojha <nojha@redhat.com>
4 years agoMerge pull request #36897 from tchaikov/wip-cmake-asan
Kefu Chai [Tue, 1 Sep 2020 02:36:02 +0000 (10:36 +0800)]
Merge pull request #36897 from tchaikov/wip-cmake-asan

cmake: expose Sanitizers_COMPILE_OPTIONS as a list

Reviewed-by: Brad Hubbard <bhubbard@redhat.com>
4 years agodoc: fix broken hyper link 36879/head
Kefu Chai [Mon, 31 Aug 2020 01:30:25 +0000 (09:30 +0800)]
doc: fix broken hyper link

and always reference multisite.rst using tha label not the file.

Signed-off-by: Kefu Chai <kchai@redhat.com>
4 years agodoc: fix broken hyper link
Kefu Chai [Sun, 30 Aug 2020 10:10:28 +0000 (18:10 +0800)]
doc: fix broken hyper link

Signed-off-by: Kefu Chai <kchai@redhat.com>
4 years agodoc: define label before section title
Kefu Chai [Sat, 29 Aug 2020 18:08:03 +0000 (02:08 +0800)]
doc: define label before section title

so we can see the title of section when following the link

Signed-off-by: Kefu Chai <kchai@redhat.com>
4 years agodoc: add sphinx.ext.mathjax for math-to-MathML rendering
Kefu Chai [Sat, 29 Aug 2020 16:51:12 +0000 (00:51 +0800)]
doc: add sphinx.ext.mathjax for math-to-MathML rendering

Signed-off-by: Kefu Chai <kchai@redhat.com>
4 years agodoc: fix broken hyper link
Kefu Chai [Sat, 29 Aug 2020 15:24:22 +0000 (23:24 +0800)]
doc: fix broken hyper link

this link was broken in 1427905c473e352e7cac1a9ac209cddb82544b57

Signed-off-by: Kefu Chai <kchai@redhat.com>
4 years agodoc: always refernce terms in case sensitive mode
Kefu Chai [Fri, 28 Aug 2020 11:28:18 +0000 (19:28 +0800)]
doc: always refernce terms in case sensitive mode

to silence warning from sphinx like:

ceph/doc/install/ceph-deploy/quick-start-preflight.rst:5: WARNING: term node not found in case sensitive match.made a reference to Node instead.

Signed-off-by: Kefu Chai <kchai@redhat.com>
4 years agoinclude/rados/librados.h: avoid redefinition of rados_object_list_item
Kefu Chai [Fri, 28 Aug 2020 11:25:51 +0000 (19:25 +0800)]
include/rados/librados.h: avoid redefinition of rados_object_list_item

doxygen complains at seeing rados_object_list_item gets defined twice.
so let's fix it.

Signed-off-by: Kefu Chai <kchai@redhat.com>
4 years agodoc: replace luminous with |stable-release|
Kefu Chai [Fri, 28 Aug 2020 10:26:26 +0000 (18:26 +0800)]
doc: replace luminous with |stable-release|

"luminous" is a magic number in these contexts, and we should use a
constant for representing it.

the "sphinx_substitution_extensions" sphinx extension is introduced for
performing the global subsitution.

Signed-off-by: Kefu Chai <kchai@redhat.com>
4 years agoMerge pull request #36907 from yuvalif/fix-issue-47209
Kefu Chai [Tue, 1 Sep 2020 01:48:33 +0000 (09:48 +0800)]
Merge pull request #36907 from yuvalif/fix-issue-47209

cmake: make crimson libraries static to prevent cmake error

Reviewed-by: Kefu Chai <kchai@redhat.com>
4 years agoosd: fix reference leak 35899/head
myoungwon oh [Sun, 30 Aug 2020 08:23:52 +0000 (17:23 +0900)]
osd: fix reference leak

Signed-off-by: Myoungwon Oh <myoungwon.oh@samsumg.com>
4 years agoqa/tests: use bionic only for old clients in rados/thrash-old-clients 36915/head
Yuri Weinstein [Mon, 31 Aug 2020 23:31:13 +0000 (16:31 -0700)]
qa/tests: use bionic only for old clients in rados/thrash-old-clients

Fixes: https://tracker.ceph.com/issues/46529
Signed-off-by: Yuri Weinstein <yweinste@redhat.com>
4 years agoMerge PR #36089 into master
Patrick Donnelly [Mon, 31 Aug 2020 22:18:03 +0000 (15:18 -0700)]
Merge PR #36089 into master

* refs/pull/36089/head:
mds/OpenFileTable: add option that disables dirfrags prefetch
mds: use parent/d_name in cap_reconnect_t to speedup MDCache::open_ino()
client: encode inode's parent/d_name in cap_reconnect_t
mds: explicitly track files with client writeable ranges
mds: properly set CLIENTWRITEABLE flag for imported caps
mds: in-place update projected inode's client ranges
mds: only add inodes that clients want Frw or excl caps to open file table
mds/OpenFileTable: reduce anchor map lookup during prefetch
mds/OpenFileTable: merge dirfrag set into anchor map

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
4 years agoMerge PR #36887 into master
Patrick Donnelly [Mon, 31 Aug 2020 20:23:57 +0000 (13:23 -0700)]
Merge PR #36887 into master

* refs/pull/36887/head:
qa: ignore expected mds failover message

Reviewed-by: Jeff Layton <jlayton@redhat.com>
4 years agoMerge PR #36846 into master
Patrick Donnelly [Mon, 31 Aug 2020 20:21:51 +0000 (13:21 -0700)]
Merge PR #36846 into master

* refs/pull/36846/head:
client: support getting ceph.dir.rsnaps vxattr
messages: fix decode version for snap_btime

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
4 years agoMerge PR #36777 into master
Patrick Donnelly [Mon, 31 Aug 2020 20:21:14 +0000 (13:21 -0700)]
Merge PR #36777 into master

* refs/pull/36777/head:
osdc/Journaler: do not call onsafe->complete() if onsafe is 0

Reviewed-by: Zheng Yan <zyan@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
4 years agoMerge PR #36672 into master
Patrick Donnelly [Mon, 31 Aug 2020 20:19:22 +0000 (13:19 -0700)]
Merge PR #36672 into master

* refs/pull/36672/head:
client: handle readdir reply without Fs cap

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
4 years agoMerge PR #36631 into master
Patrick Donnelly [Mon, 31 Aug 2020 20:18:43 +0000 (13:18 -0700)]
Merge PR #36631 into master

* refs/pull/36631/head:
client: dump frag's repmap if dir_replicated is true

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
4 years agoMerge PR #36885 into master
Patrick Donnelly [Mon, 31 Aug 2020 20:05:41 +0000 (13:05 -0700)]
Merge PR #36885 into master

* refs/pull/36885/head:
mon: ignore statfs requests on invalid poolid
qa: test for statfs on deleted file system
qa: move run_shell args to kwargs

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
4 years agoMerge pull request #36881 from mhackett/wip-mhackett-47189
Vikhyat Umrao [Mon, 31 Aug 2020 19:06:21 +0000 (12:06 -0700)]
Merge pull request #36881 from mhackett/wip-mhackett-47189

doc: document tuning of object gateway garbage collection

4 years agomgr/dashboard: Address API inconsistencies 35802/head
Fabrizio D'Angelo [Fri, 26 Jun 2020 13:50:15 +0000 (09:50 -0400)]
mgr/dashboard: Address API inconsistencies

Cephfs endpoints are inconsistencies with other endpoints.

* Change rm endpoints from GET to DELETE requests
* Change set_quotas from POST to PUT
* Renames endpoints accordingly
* Changes related angular files
* update a few lines related to mypy
* remove future import as the python2 compatibility is not needed

Fixes: https://tracker.ceph.com/issues/46160
Signed-off-by: Fabrizio D'Angelo <fdangelo@redhat.com>
(cherry picked from commit 222286b08bde3600d50a6deb25e7425c17e9e482)

4 years agoceph-volume: retry when acquiring lock fails 36700/head
Sébastien Han [Tue, 18 Aug 2020 13:41:31 +0000 (15:41 +0200)]
ceph-volume: retry when acquiring lock fails

When preaparing the osd device with --mkfs, the ceph-osd binary tries to
acquire an exclusive lock on the device (soon to become an OSD).
Unfortunately, when running in containers, we have seen cases where
there is a race between ceph-osd and systemd-udevd to acquire a lock on
the device. Sometimes systemd-udevd gets the lock and releases it soon
so that the ceph-osd gets sometimes the lock is still held and because
ceph-osd uses LOCK_NB the command fails.

This commit retries if the lock cannot be acquired, up to 5 times for 5
seconds, this should be more than enough to acquire the lock and
proceed with the OSD mkfs.

Unfortunately, this is so transient that we cannot lock earlier from c-v,
this won't do anything.

Fixes: https://tracker.ceph.com/issues/47010
Signed-off-by: Sébastien Han <seb@redhat.com>
4 years agocrimson/cmake: fix copy&paste error 36907/head
ylifshit@redhat.com [Mon, 31 Aug 2020 16:32:54 +0000 (19:32 +0300)]
crimson/cmake: fix copy&paste error

Signed-off-by: Yuval Lifshitz <ylifshit@redhat.com>
4 years agocrimson/cmake: make libraries static to prevent cmake error
Yuval Lifshitz [Mon, 31 Aug 2020 09:58:18 +0000 (12:58 +0300)]
crimson/cmake: make libraries static to prevent cmake error

Fixes: https://tracker.ceph.com/issues/47209
Signed-off-by: Yuval Lifshitz <ylifshit@redhat.com>
4 years agodoc: create new chapter about the Dashboard's landing page 36222/head
Ishan Rai [Wed, 26 Aug 2020 07:37:06 +0000 (07:37 +0000)]
doc: create new chapter about the Dashboard's landing page

Fixes: https://tracker.ceph.com/issues/46415
Signed-off-by: Ishan Rai <ishanrai05@gmail.com>
4 years agoMerge pull request #36826 from agayev/fix-hmsmr-compilation
Kefu Chai [Mon, 31 Aug 2020 14:14:29 +0000 (22:14 +0800)]
Merge pull request #36826 from agayev/fix-hmsmr-compilation

os/bluestore: Restore HM-SMR functionality on BlueStore

Reviewed-by: Igor Fedotov <ifedotov@suse.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
4 years agoMerge pull request #34653 from clwluvw/bucket-stats
Daniel Gryniewicz [Mon, 31 Aug 2020 14:02:20 +0000 (10:02 -0400)]
Merge pull request #34653 from clwluvw/bucket-stats

rgw: Add bucket name to bucket stats error logging

4 years agoMerge pull request #36857 from tchaikov/wip-crimson-conf
Kefu Chai [Mon, 31 Aug 2020 14:01:39 +0000 (22:01 +0800)]
Merge pull request #36857 from tchaikov/wip-crimson-conf

crimson/osd: support "dump_pgstate_history" command and update legacy conf vars

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
4 years agocrimson/osd: improve the const correctness 36857/head
Kefu Chai [Thu, 27 Aug 2020 14:22:04 +0000 (22:22 +0800)]
crimson/osd: improve the const correctness

it should suffice to pass a `const OSD&` to the ctor of `OsdStatusHook`

Signed-off-by: Kefu Chai <kchai@redhat.com>
4 years agocrimson/osd: support "dump_pgstate_history" command
Kefu Chai [Thu, 27 Aug 2020 14:16:25 +0000 (22:16 +0800)]
crimson/osd: support "dump_pgstate_history" command

it is required by the "ceph_test_admin_socket_output" test.

Signed-off-by: Kefu Chai <kchai@redhat.com>
4 years agocrimson/admin: make injected_args optional
Kefu Chai [Thu, 27 Aug 2020 13:15:42 +0000 (21:15 +0800)]
crimson/admin: make injected_args optional

this option for `injectargs` command is optional, so we should not
crash if it does not exist.

Signed-off-by: Kefu Chai <kchai@redhat.com>
4 years agocrimson/common: do not check for experimental/filesystem anymore
Kefu Chai [Thu, 27 Aug 2020 13:01:37 +0000 (21:01 +0800)]
crimson/common: do not check for experimental/filesystem anymore

seastar is only compatible with C++17 and C++20, so no need to check for
<experimental/filesystem> anymore. the C++ standard library should be
C++17 compatible.

Signed-off-by: Kefu Chai <kchai@redhat.com>
4 years agocrimson/common: call config::update_legacy_vals()
Kefu Chai [Thu, 27 Aug 2020 13:00:14 +0000 (21:00 +0800)]
crimson/common: call config::update_legacy_vals()

so the legacy vals are populated with the changes received from conffile.

Signed-off-by: Kefu Chai <kchai@redhat.com>
4 years agocommon/config: make update_legacy_vals() public
Kefu Chai [Thu, 27 Aug 2020 12:58:11 +0000 (20:58 +0800)]
common/config: make update_legacy_vals() public

so crimson can call it in `ConfigProxy::parse_config_files()` after calling
`get_config().parse_buffer()`. so the legacy vals are populated with the
changes received from conffile.

Signed-off-by: Kefu Chai <kchai@redhat.com>
4 years agoMerge pull request #36891 from tchaikov/wip-less-warnings
Kefu Chai [Mon, 31 Aug 2020 13:00:43 +0000 (21:00 +0800)]
Merge pull request #36891 from tchaikov/wip-less-warnings

crimson/mon,common: replace #warning with // TODO

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
4 years agoMerge pull request #36892 from tchaikov/wip-crimson-cleanups
Kefu Chai [Mon, 31 Aug 2020 12:55:18 +0000 (20:55 +0800)]
Merge pull request #36892 from tchaikov/wip-crimson-cleanups

crimson/osd: return EAGAIN if !can_serve_replica_read() and cleanups

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
4 years agoMerge pull request #36905 from sebastian-philipp/cephadm-pep8-test-migration
Sebastian Wagner [Mon, 31 Aug 2020 12:12:30 +0000 (14:12 +0200)]
Merge pull request #36905 from sebastian-philipp/cephadm-pep8-test-migration

mgr/cephadm: PEP8tify test_migration.py

Reviewed-by: Adam King <adking@redhat.com>
4 years agoMerge pull request #36676 from matthewoliver/cephadm_orch_ipv6
Sebastian Wagner [Mon, 31 Aug 2020 11:34:02 +0000 (13:34 +0200)]
Merge pull request #36676 from matthewoliver/cephadm_orch_ipv6

cephadm: auto wrap and unwrap ipv6 addresses

Reviewed-by: Laura Paduano <lpaduano@suse.com>
Reviewed-by: Sebastian Wagner <sebastian.wagner@suse.com>
4 years agoMerge pull request #36896 from xxhdx1985126/wip-47133
Kefu Chai [Mon, 31 Aug 2020 11:12:07 +0000 (19:12 +0800)]
Merge pull request #36896 from xxhdx1985126/wip-47133

crimson/pg: check acting set change before appending pglog

Reviewed-by: Kefu Chai <kchai@redhat.com>
4 years agomgr/cephadm: PEP8tify test_migration.py 36905/head
Sebastian Wagner [Mon, 31 Aug 2020 09:48:14 +0000 (11:48 +0200)]
mgr/cephadm: PEP8tify test_migration.py

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
4 years agoMerge pull request #36877 from sebastian-philipp/mgr-module-fix-kwargs-cli-command
Sebastian Wagner [Mon, 31 Aug 2020 09:14:59 +0000 (11:14 +0200)]
Merge pull request #36877 from sebastian-philipp/mgr-module-fix-kwargs-cli-command

mgr/mgr_module.py: CLICommand: Fix parsing of kwargs arguments

Reviewed-by: Jan Fajerski <jfajerski@suse.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
4 years agoMerge pull request #36859 from tspmelo/wip-fix-onselect
Laura Paduano [Mon, 31 Aug 2020 08:46:59 +0000 (10:46 +0200)]
Merge pull request #36859 from tspmelo/wip-fix-onselect

mgr/dashboard: Fix stale table actions

Reviewed-by: Volker Theile <vtheile@suse.com>
Reviewed-by: Stephan Müller <smueller@suse.com>
Reviewed-by: Laura Paduano <lpaduano@suse.com>
4 years agocmake: expose Sanitizers_COMPILE_OPTIONS as a list 36897/head
Kefu Chai [Mon, 31 Aug 2020 08:09:21 +0000 (16:09 +0800)]
cmake: expose Sanitizers_COMPILE_OPTIONS as a list

* cmake/modules/FindSanitizers.cmake: do not pollute CMAKE_REQUIRED_FLAGS
* cmake/modules/FindSanitizers.cmake: expose Sanitizers_COMPILE_OPTIONS
  as a list
* CMakeLists.txt: append Sanitizers_COMPILE_OPTIONS to
  *_LINKER_FLAGS after replacing ";" with " " in it.

Signed-off-by: Kefu Chai <kchai@redhat.com>
4 years agoMerge pull request #36839 from dillaman/wip-46875
Mykola Golub [Mon, 31 Aug 2020 05:59:06 +0000 (08:59 +0300)]
Merge pull request #36839 from dillaman/wip-46875

librbd: flush all incomplete in-flight IOs upon image close

Reviewed-by: Mykola Golub <mgolub@suse.com>
4 years agoMerge pull request #36819 from vumrao/wip-vumrao-46663
Kefu Chai [Mon, 31 Aug 2020 05:31:34 +0000 (13:31 +0800)]
Merge pull request #36819 from vumrao/wip-vumrao-46663

mon/PGMap: add pg count for pools in the ceph df command

Reviewed-by: Neha Ojha <nojha@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
4 years agocrimson/pg: check acting set change before appending pglog 36896/head
Xuehan Xu [Mon, 31 Aug 2020 05:17:48 +0000 (13:17 +0800)]
crimson/pg: check acting set change before appending pglog

Fixes: https://tracker.ceph.com/issues/47133
Signed-off-by: Xuehan Xu <xxhdx1985126@gmail.com>
4 years agoMerge pull request #33852 from rosinL/wip-fix-enqueue-dead-qp-deadlock
Kefu Chai [Mon, 31 Aug 2020 02:39:02 +0000 (10:39 +0800)]
Merge pull request #33852 from rosinL/wip-fix-enqueue-dead-qp-deadlock

msg/async/rdma: avoid enqueue_dead_qp deadlock

Reviewed-by: Peng Liu <liupeng37@baidu.com>
4 years agoMerge pull request #36767 from tchaikov/wip-47061
Kefu Chai [Sun, 30 Aug 2020 15:21:32 +0000 (23:21 +0800)]
Merge pull request #36767 from tchaikov/wip-47061

test/osd/RadosModel: check retval of read op

Reviewed-by: Samuel Just <sjust@redhat.com>
4 years agocrimson/osd: return EAGAIN if !can_serve_replica_read() 36892/head
Kefu Chai [Sun, 30 Aug 2020 15:11:40 +0000 (23:11 +0800)]
crimson/osd: return EAGAIN if !can_serve_replica_read()

it's necessary for serving balanced read.

Signed-off-by: Kefu Chai <kchai@redhat.com>
4 years agocrimson/osd: check for primary out side of is_misdirected()
Kefu Chai [Sun, 30 Aug 2020 15:09:14 +0000 (23:09 +0800)]
crimson/osd: check for primary out side of is_misdirected()

so we can check can_serve_replica_read() without checking primary again.

Signed-off-by: Kefu Chai <kchai@redhat.com>
4 years agocrimson/osd: encode OI with CEPH_FEATURES_ALL
Kefu Chai [Sun, 30 Aug 2020 12:59:35 +0000 (20:59 +0800)]
crimson/osd: encode OI with CEPH_FEATURES_ALL

Signed-off-by: Kefu Chai <kchai@redhat.com>
4 years agocrimson/osd: use logger() instead of crimson::get_logger(...)
Kefu Chai [Sun, 30 Aug 2020 08:47:10 +0000 (16:47 +0800)]
crimson/osd: use logger() instead of crimson::get_logger(...)

for better readability

Signed-off-by: Kefu Chai <kchai@redhat.com>
4 years agocrimson/osd: call PeeringState::get_peer_missing(peer)
Kefu Chai [Sun, 30 Aug 2020 08:24:41 +0000 (16:24 +0800)]
crimson/osd: call PeeringState::get_peer_missing(peer)

as PeeringState::get_peer_missing(const pg_shard_t &peer) already checks
for the non-existent shard, and because `get_replica_recovery_order()`
never returns primary osd, it's safe to use
`PeeringState::get_peer_missing(peer)` instead of
`pg->get_peering_state().get_peer_missing().find(peer)`.

Signed-off-by: Kefu Chai <kchai@redhat.com>
4 years agocrimson/osd: eliminate a local variable
Kefu Chai [Sun, 30 Aug 2020 08:11:46 +0000 (16:11 +0800)]
crimson/osd: eliminate a local variable

for better readability

Signed-off-by: Kefu Chai <kchai@redhat.com>
4 years agotest/osd/RadosModel: assure that tid seq is contiguous 36767/head
Kefu Chai [Mon, 24 Aug 2020 13:49:28 +0000 (21:49 +0800)]
test/osd/RadosModel: assure that tid seq is contiguous

before this change:

4:  finishing write tid 1 to gen81094472-1
4:  finishing write tid 2 to gen81094472-1
4:  finishing write tid 3 to gen81094472-1
4:  finishing write tid 5 to gen81094472-1
4:  finishing write tid 6 to gen81094472-1

after this change:

1:  finishing write tid 1 to gen81117124-1
1:  finishing write tid 2 to gen81117124-1
1:  finishing write tid 3 to gen81117124-1
1:  finishing write tid 4 to gen81117124-1
1:  finishing write tid 5 to gen81117124-1

more pleasant when reading the logging messages.

Signed-off-by: Kefu Chai <kchai@redhat.com>
4 years agotest/osd/RadosModel: check retval of read op
Kefu Chai [Mon, 24 Aug 2020 11:06:11 +0000 (19:06 +0800)]
test/osd/RadosModel: check retval of read op

* check racing read's return value
* check if racing read completes

Fixes: https://tracker.ceph.com/issues/47061
Signed-off-by: Kefu Chai <kchai@redhat.com>
4 years agotest/osd/RadosModel: do not set done
Kefu Chai [Mon, 24 Aug 2020 10:35:22 +0000 (18:35 +0800)]
test/osd/RadosModel: do not set done

we don't reuse TestOp, and `done` should have been reset in the
constructor.

Signed-off-by: Kefu Chai <kchai@redhat.com>
4 years agotest/osd/RadosModel: use range-based for loop
Kefu Chai [Mon, 24 Aug 2020 10:34:42 +0000 (18:34 +0800)]
test/osd/RadosModel: use range-based for loop

Signed-off-by: Kefu Chai <kchai@redhat.com>
4 years agotest/osd/RadosModel: use in-class initiailization
Kefu Chai [Mon, 24 Aug 2020 10:34:06 +0000 (18:34 +0800)]
test/osd/RadosModel: use in-class initiailization

Signed-off-by: Kefu Chai <kchai@redhat.com>
4 years agotest/osd: use stack for ObjectDesc::iterator::stack
Kefu Chai [Mon, 24 Aug 2020 09:11:40 +0000 (17:11 +0800)]
test/osd: use stack for ObjectDesc::iterator::stack

better readability this way

Signed-off-by: Kefu Chai <kchai@redhat.com>
4 years agocrimson/mon: replace #warning with TODO 36891/head
Kefu Chai [Sun, 30 Aug 2020 09:57:38 +0000 (17:57 +0800)]
crimson/mon: replace #warning with TODO

less distracting when fixing compiling error / warnings this way

Signed-off-by: Kefu Chai <kchai@redhat.com>
4 years agocommon/admin_socket: replace #warning with TODO
Kefu Chai [Sun, 30 Aug 2020 09:56:48 +0000 (17:56 +0800)]
common/admin_socket: replace #warning with TODO

less distracting when fixing compiling error / warnings this way

Signed-off-by: Kefu Chai <kchai@redhat.com>
4 years agoMerge pull request #36815 from sebastian-philipp/cephadm-pep8-module
Sebastian Wagner [Sat, 29 Aug 2020 21:49:13 +0000 (23:49 +0200)]
Merge pull request #36815 from sebastian-philipp/cephadm-pep8-module

mgr/cephadm: PEP8tify module.py

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Michael Fritch <mfritch@suse.com>
4 years agomgr/cephadm: PEP8tify module.py 36815/head
Sebastian Wagner [Sat, 29 Aug 2020 18:41:20 +0000 (20:41 +0200)]
mgr/cephadm: PEP8tify module.py

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>