tools/rados: update the help message

Fixes: #12451
Signed-off-by: Kefu Chai <kchai@redhat.com>

Merge pull request #5139 from jmunhoz/wip-7817-ms

rgw: add minimum support for copy multipart part

Reviewed-by: Yehuda Sadeh <yehuda@redhat.com>

Merge pull request #5313 from guce/rgw_access_invalid_argument

rgw: check subuser illegal access parameter.

Reviewed-by: Yehuda Sadeh <yehuda@redhat.com>

Merge pull request #5364 from xdonghai/master

doc:modified librados-intro.rst an error of document representation

Reviewed-by: Abhishek Lekshmanan <abhishek.lekshmanan@ril.com>
Reviewed-by: Josh Durgin <jdurgin@redhat.com>

Merge pull request #5191 from theanalyst/v9.0.2/mailmap

doc: mailmap for v9.0.2 release

Reviewed-by: Loic Dachary <ldachary@redhat.com>

Merge pull request #5130 from tchaikov/wip-12167

ceph-detect-init: do not require "argparse" on py2.6

Reviewed-by: Loic Dachary <ldachary@redhat.com>

Merge pull request #5338 from hjwsm1989/wip-12459

common/WorkQueue: fix the FTBFS with GCC 4.4.7

* add nested-name-specifier ThreadPool before WorkQueueVal

Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #5355 from ceph/wip-anotate-s-files

Anotate all the .s files

Reviewed-by: Sage Weil <sage@redhat.com>

Merge pull request #5116 from yuyuyu101/wip-compressor

Wip compressor

Reviewed-by: Sage Weil <sage@redhat.com>

modified librados-intro.rst

Signed-off-by: x11507 <xu.donghai@h3c.com>

Merge pull request #5254 from vuhuong/wip-xio

@vuhuong sorry for the latency, could you please rebase & repush , to poke the built bot again?

once the build completes, will get it merged.

thanks,

Merge pull request #5349 from yuyuyu101/wip-async-fix-21

AsyncConnection: Exit process loop if entering fault

Merge remote-tracking branch 'origin/next'

Merge pull request #5352 from ceph/wip-rbd-help-specs

rbd: cli help and arg parsing fixes

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
Reviewed-by: Josh Durgin <jdurgin@redhat.com>

Merge pull request #5336 from ceph/wip-migrate-event-seq

mds: fix val used in inode->last_journaled

Reviewed-by: Greg Farnum <gfarnum@redhat.com>

Anotate all the .s files

Recent update to erasure code library in 59aa6700 caused a regression
where .s files are no longer properly anotated and yasm sets the exec
stack for them. This patch brings back the anotations as was done before
by Dan Mick, see Bug #10114.

Signed-off-by: Boris Ranto <branto@redhat.com>

rbd: rename --object-extents option to --whole-object

--object-extents is a bit confusing - extent is generally something of
a varying length and here the meaning is "diff whole objects".  Rename
it to --whole-object (the name of diff_iterate() parameter).

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>

rbd: du command should take spec as an argument

Change du to take <image-spec> | <snap-spec> as an argument instead of
going through --image option.  The new synopsis is

    (du | disk-usage) [<image-spec> | <snap-spec>]

This is to make it look more like the rest of the commands: the only
other command that takes pool as an argument is ls and it can't really
serve as a prototype for du, because the latter has to work on images
and snapshots as well.

Examples:

    # stats for pool rbd
    $ rbd du
    $ rbd -p rbd du

    # stats for pool foo
    $ rbd -p foo du

    # stats for snapshot mysnap of image baz in pool rbd
    $ rbd du baz@mysnap

    # stats for image bar in pool foo
    $ rbd du foo/bar

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>

rbd: assorted cli arg parsing fixes

- import-diff needs image-spec, yet OPT_IMPORT_DIFF was in the list of
  commands that don't need imgname

- check for lock id after imgname, so that if imgname isn't specified
  we fail with imgname rather than lock id error message

- error out if locker isn't specified

- move feature-name validity check after imgname checks so that if
  imgname is malformed we fail with imgname rather than feature error
  message

- error out if image-meta key or value isn't specified

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>

rbd: error out if dest_snapname is specified

No command uses it as of now, but only clone command fails; cp, mv and
import simply ignore it.  Check if it's set and exit with a generic
error message.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>

rbd: import doesn't require image-spec arg, ditto for export and path

Mark those as such in help and clarify what image-spec defaults to.

Related, all command args in our man page are enclosed into brackets.
I suppose the reason is that they are optional in the sense that you
can have commands like

    $ rbd clone --pool a --image b --snap -c --dest-pool d --dest e

with no args.  Given that we are trying to push people towards

    $ rbd clone a/b@c d/e

undo that so that real optional arguments can be marked optional.
While at it, add synopsis for each command and use backticks for
denoting commands more consistently.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>

doc: use spec syntax in rbd docs

Use spec syntax instead of --pool, --image and --snap to hopefully push
people towards the former.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>

rbd: use image-spec and snap-spec in rbd help

This patch changes image-name instances to image-spec and snap-name
instances to snap-spec to try to clarify usage for some commands and
disambiguate the term {image,snap}-name, which has been used to denote
both simple names and compound names (specs).

<image-spec> is [<pool-name>]/<image-name>
<snap-spec> is [<pool-name>]/<image-name>@<snap-name>

This patch also removes duplicate checks for image-name and snap-name.

Signed-off-by: Vikhyat Umrao <vumrao@redhat.com>
[idryomov@gmail.com: some commands take either image-spec or snap-spec,
other fixes, formatting, changelog]
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>

Compressor: Remove thread affinity options

Signed-off-by: Haomai Wang <haomaiwang@gmail.com>

AsyncConnection: Exit process loop if entering fault

"fault" will transmit state to exception state or STATE_CONNECTING, all
transmitted states don't need to check right now.

Signed-off-by: Haomai Wang <haomaiwang@gmail.com>

Merge pull request #5342 from tchaikov/wip-fix-perf-local-on-arm

test/perf_local: disable tests on unsupported archs

Reviewed-by: Haomai Wang <haomaiwang@gmail.com>

test/perf_local: disable tests on unsupported archs

* maybe we can have div32 tests on aarch64, but i don't
  think "udiv|sdiv" supports 64bits numerator. probably
  we can use float divde for the benchmark...
* disable cpuid test on non-intel archs.

Fixes: #12453
Reported-by: Tom Deneau <tom.deneau@amd.com>
Signed-off-by: Kefu Chai <kchai@redhat.com>

Merge pull request #5316 from shylesh/bugfix

mon: ceph osd map shows NONE when an osd is missing

Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Loic Dachary <ldachary@redhat.com>

  common: add nested-name-specifier ThreadPool before WorkQueueVal
Fixes: #12459
Signed-off-by: huangjun <hjwsm1989@gmail.com>

Merge pull request #5322 from majianpeng/mds-log

mmds/MDLog: No make sense set offset for LogEvent in _start_entry.

Reviewed-by: John Spray <john.spray@redhat.com>

mds: fix val used in inode->last_journaled

This was getting assigned with LogEvent::get_start_offset
on an uncommitted LogEvent, which is junk.  During replay
last_journaled is compared with the metablob's event_seq,
so that's what should be used here.

This change just from code inspection -- haven't seen this
manifest as an actual misbehaviour.

Signed-off-by: John Spray <john.spray@redhat.com>

Merge pull request #5330 from liewegas/wip-cephtool-test

qa/workunits/cephtool/test.sh: escape osd.* and mon.*

Reviewed-by: Loic Dachary <ldachary@redhat.com>

qa/workunits/cephtool/test.sh: escape osd.* and mon.*

Otherwise we get filenames if the glob happens to match something in the
source dir.

Signed-off-by: Sage Weil <sage@redhat.com>

Merge branch 'next'

Merge pull request #5327 from athanatos/wip-12223

WBThrottle::clear_object: signal if we cleared an object

Reviewed-by: David Zafman <dzafman@redhat.com>

Merge pull request #5328 from athanatos/wip-12263

ReplicatedPG::finish_promote: do not prefill new_clones

Reviewed-by: David Zafman <dzafman@redhat.com>

WBThrottle::clear_object: signal if we cleared an object

Fixes: #12223
Signed-off-by: Samuel Just <sjust@redhat.com>

Merge pull request #5189 from athanatos/wip-recovery-defaults

config_opts: turn down default recovery tunables

Reviewed-by: David Zafman <dzafman@redhat.com>

Merge pull request #5329 from athanatos/wip-8193

test/librados/tier.cc: we can exceed the hitset limit while backfilling

Reviewed-by: David Zafman <dzafman@redhat.com>

Merge pull request #5323 from ceph/wip-12426

mon: fix checks on mds add_data_pool

Reviewed-by: Greg Farnum <gfarnum@redhat.com>

Merge pull request #4982 from branch-predictor/bp-lighter-rwlocks

common/RWLock: allow disabling read/write lock counts

Reviewed-by: Samuel Just <sjust@redhat.com>

Merge pull request #5152 from branch-predictor/bp-rados-aio-overrun

tools: fix race condition in seq/rand bench

Reviewed-by: Samuel Just <sjust@redhat.com>

Merge pull request #5093 from guangyy/wip-12162

osd - pg_interval_t::check_new_interval should not rely on pool.min_size to determine if the PG was active

Reviewed-by: Samuel Just <sjust@redhat.com>

ceph-helpers.sh: don't test the osd_max_backfills value

This isn't a very meaningful assert since the default could
easily change.

Signed-off-by: Samuel Just <sjust@redhat.com>

Merge pull request #5325 from vumrao/wip-vumrao-10927

rgw: fix radosgw start-up script.

Reviewed-by: Ken Dreyer <kdreyer@redhat.com>

Merge pull request #5308 from oritwas/fix-compilation-warnings

Fix "was hidden" compilation warnings

Reviewed-by: Yehuda Sadeh <yehuda@redhat.com>

Fix "was hidden" compilation warnings

Signed-off-by: Orit Wasserman <owasserm@redhat.com>

rgw: fix radosgw start-up script.

radosgw init script is unable to start radosgw daemon.
as it is relies on requiretty being disabled.
once init script start this daemon with sudo it fails
to start the daemon.

changing 'sudo' to 'su', it will fix this issue and
will also help running radosgw daemon with our new
"ceph" UID project.

Fixes: #10927
Signed-off-by: Vikhyat Umrao <vumrao@redhat.com>

Merge pull request #5326 from tweenk/docs-improvements

Documentation for a few objects

Reviewed-by: Sage Weil <sage@redhat.com>

Merge pull request #5261 from SUSE/wip-drop-py-requires

ceph.spec.in: drop SUSE-specific %py_requires macro

Reviewed-by: Ken Dreyer <kdreyer@redhat.com>

Merge pull request #5263 from SUSE/wip-apache-not-required

ceph.spec.in: remove SUSE-specific apache2-mod_fcgid dependency

Reviewed-by: Ken Dreyer <kdreyer@redhat.com>

docs: Document md_config_obs_t.

Signed-off-by: Krzysztof Kosiński <krzysztof.kosinski@intel.com>

docs: Document the ThreadPool and WorkQueue classes.

Signed-off-by: Krzysztof Kosiński <krzysztof.kosinski@intel.com>

docs: Document the Finisher class.

Signed-off-by: Krzysztof Kosiński <krzysztof.kosinski@intel.com>

mon: fix checks on mds add_data_pool

Use same _check_pool helper as during fs creation.

Fixes: #12426
Signed-off-by: John Spray <john.spray@redhat.com>

Merge pull request #5324 from ceph/wip-12355

mds: fix crash while stopping rank

Reviewed-by: Greg Farnum <gfarnum@redhat.com>

Merge pull request #5317 from ceph/wip-quota-doc

doc/cephfs/quota: simple doc

Reviewed-by: John Spray <john.spray@redhat.com>
Reviewed-by: Travis Rhoden <trhoden@redhat.com>

doc/cephfs/quota: simple doc

Signed-off-by: Sage Weil <sage@redhat.com>

mds: fix crash while stopping rank

trim() was broken in:
8a91daae mds: fix mds crash when mds_max_log_events smaller

When doing a final trim in shutdown we need to trim everything,
not just all but the last segment.  The previous change's intent
was to prevent badness when mds_log_max_events was too small: accomplish
the same thing here by clamping the value to something sane.

Fixes: #12355
Signed-off-by: John Spray <john.spray@redhat.com>

mmds/MDLog: No make sense set offset for LogEvent in _start_entry.

For offset of LogEvent only determine in submit_thread. So in
_start_entry it's no make sense set.

Signed-off-by: Jianpeng Ma <jianpeng.ma@intel.com>

rgw: check subuser illegal access parameter.

Both empty arguments and illegal parameters, can modify the existing configuration to none permissions.

It should be modified to:
1.empty parameter modify the existing configuration to none permissions.
2.illegal parameter return an error.

test fix:
    before: subuser create or modify, illegal access parameter can modify the existing configuration.
    after changes, do the same procedure, can check for illegal access parameters.

Signed-off-by: guce <guce@h3c.com>

Merge pull request #5305 from ceph/wip-12417

auth: check return value of keyring->get_secret

Reviewed-by: Sage Weil <sage@redhat.com>

Merge pull request #5300 from yuyuyu101/wip-async-fix-20

AsyncConnection: Fix local message dispatch lack of source name

mon: ceph osd map shows NONE when an osd is missing

Signed-off-by: Shylesh Kumar <shmohan@redhat.com>

Merge pull request #5314 from dachary/wip-12419-rule-create-erasure

tests: robust test for the pool create crush map test

Reviewed-by: Kefu Chai <kchai@redhat.com>

tests: robust test for the pool create crushmap test

The test that goes with f1e86be589803596e86acc964ac5c5c03b4038d8 to
verify that a bugous crush ruleset will prevent the creation of a pool
trying to use it was fragile. I depends on the implementation of the
erasure code lrc plugin and turns out to not work on i386.

The test is modified to use a fake crushtool that always returns false
and validate that it prevents the creation of a pool, which demonstrate
it is used for crushmap validation prior to the pool creation.

http://tracker.ceph.com/issues/12419 Fixes: #12419

Signed-off-by: Loic Dachary <ldachary@redhat.com>

Merge pull request #5304 from ceph/wip-add-scrub-config-doc

doc/rados/configuration: add more scrub related config

Reviewed-by: Loic Dachary <ldachary@redhat.com>

doc/rados/configuration: add more scrub related config

Signed-off-by: Kefu Chai <kchai@redhat.com>

Merge pull request #5306 from dachary/wip-release-notes

src/script/ceph-release-notes: add --text for plain text output

Reviewed-by: Abhishek Lekshmanan <abhishek.lekshmanan@ril.com>

xio: reduce quantum numbers to grow pool

Growing pool's allocators with the proper quantum to
reduce memory pressure and waste

Signed-off-by: Vu Pham <vu@mellanox.com>

xio: reduce the default depth of accelio msg queue

Signed-off-by: Vu Pham <vu@melanox.com>

xio: configurable max send inline

Allow configuring the maximum threshold to send inline

Signed-off-by: Vu Pham <vu@mellanox.com>

xio: safely clean up transport messages with valid connection

Transport messages can be safely and completely cleaned up as
long as low level connection is valid

Signed-off-by: Vu Pham <vu@mellanox.com>

doc: v0.80.10 changelog

Signed-off-by: Sage Weil <sage@redhat.com>

src/script/ceph-release-notes: add --text for plain text output

This is a format that's easier to consume when sending a mail.

Signed-off-by: Loic Dachary <ldachary@redhat.com>

Merge pull request #5303 from oritwas/fix-cmake-4

cmake: add missing blkid to ceph-osd

Reviewed-by: Kefu Chai <kchai@redhat.com>

auth: check return value of keyring->get_secret

get_secret can fail to populate the passed CryptoKey, for
example if the entity name is not found in the keyring.  In
this case, attempts to use the CryptoKey will lead to
segfaults.

Fixes: #12417
Signed-off-by: John Spray <john.spray@redhat.com>

Merge pull request #5127 from tchaikov/wip-12193

tools: add osdmap commands to ceph-objectstore-tool

Reviewed-by: David Zafman <dzafman@redhat.com>

doc/releases: v0.80.10

Signed-off-by: Sage Weil <sage@redhat.com>

doc/release-notes: v0.80.10

Signed-off-by: Sage Weil <sage@redhat.com>

Merge branch 'wip-firefly-release-notes' of git://github.com/dachary/ceph

Merge pull request #4958 from xinxinsh/wip-clone-test

ceph_test_objectstore: improve the StoreTest.SimpleCloneTest

Reviewed-by: Haomai Wang <haomaiwang@gmail.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #5301 from ceph/wip-12251

mon: OSDMonitor: fix hex output on 'osd reweight'

Reviewed-by: Kefu Chai <kchai@redhat.com>

cmake: add missing blkid libraries

Signed-off-by: Orit Wasserman <owasserm@redhat.com>

Merge pull request #5302 from ssssztes/master

mon: fix the message in OSDMonitor::get_pools_health

Reviewed-by: Xinze Chi <xmdxcxz@gmail.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>

Update OSDMonitor.cc

OSDMonitor::get_pools_health(), s/objects/bytes/

Fixes: #12402
Signed-off-by: ren.huanwen@zte.com.cn

mon: OSDMonitor: fix hex output on 'osd reweight'

Fixes: #12251
Signed-off-by: Joao Eduardo Luis <joao@suse.de>

Merge pull request #5294 from ceph/wip-12354

client: fix directory fsync

Reviewed-by: Greg Farnum <gfarnum@redhat.com>

AsyncConnection: Fix local message dispatch lack of source

Signed-off-by: Haomai Wang <haomaiwang@gmail.com>

TestMsgr: Add message source check for local message dispatch

Signed-off-by: Haomai Wang <haomaiwang@gmail.com>

Merge pull request #5288 from hjwsm1989/pgmonitor-overflow

mon/PGMonitor: avoid overflow when checking num_objects against the threshold

Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #5297 from ceph/wip-7647

rgw: avoid using slashes for generated secret keys

rgw: avoid using slashes for generated secret keys

Just use plain alphanumeric characterset.

Fixes: #7647
Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>

client: fix directory fsync

When opening a regular file, fuse assigns a 'struct Fh' pointer to
fuse_file_info::fh. but when openning a directory, fuse assigns a
'struct dir_result_t' to fuse_file_info::fh. So we need a seperate
function for fsyncdir (cast fuse_file_info::fh to a struct
dir_result_t pointer)

Fixes: #12354
Signed-off-by: Yan, Zheng <zyan@redhat.com>

test/librados/tier.cc: we can exceed the hitset limit while backfilling

We leave the time limit as the actual test, but we are allowed to
temperarily exceed the number of hitsets during backfilling.

Fixes: 8193
Related: d0f1806d57646ec24e844af368c46285ab9a59f8
Signed-off-by: Samuel Just <sjust@redhat.com>

Merge pull request #5291 from zhouyuan/rgw_s3_obj_version

rgw: doc: Mark S3 object version API as supported

Reviewed-by: Yehuda Sadeh <yehuda@redhat.com>

rgw: doc: Mark S3 object version API as supported

S3 object version is already in since Hammer.
Ref: http://marc.info/?l=ceph-devel&m=143715290627682

Signed-off-by: Yuan Zhou <yuan.zhou@intel.com>

  mon/PGMonitor: avoid uint64_t overflow when checking pool 'target/max' status.
Fixes: #12401
Signed-off-by: huangjun <hjwsm1989@gmail.com>

Merge pull request #5282 from ceph/wip-fix-test-mon_deprecated_commands

qa/workunits: cephtool: take EOPNOTSUPP as an alias of ENOTSUP

Reviewed-by: Loic Dachary <ldachary@redhat.com>

qa/workunits: cephtool: take EOPNOTSUPP as an alias of ENOTSUP

the proble breaks `test_mon_deprecated_commands` on ubuntu precise,
on the python shipped with ubuntu precise, errno.errorcode[95]
evalutes to `EOPNOTSUPP` but not `ENOTSUP`. but these two errnos
are equal in glibc.

Signed-off-by: Kefu Chai <kchai@redhat.com>