Fix "was hidden" compilation warnings

Signed-off-by: Orit Wasserman <owasserm@redhat.com>

Merge pull request #5326 from tweenk/docs-improvements

Documentation for a few objects

Reviewed-by: Sage Weil <sage@redhat.com>

Merge pull request #5261 from SUSE/wip-drop-py-requires

ceph.spec.in: drop SUSE-specific %py_requires macro

Reviewed-by: Ken Dreyer <kdreyer@redhat.com>

Merge pull request #5263 from SUSE/wip-apache-not-required

ceph.spec.in: remove SUSE-specific apache2-mod_fcgid dependency

Reviewed-by: Ken Dreyer <kdreyer@redhat.com>

docs: Document md_config_obs_t.

Signed-off-by: Krzysztof Kosiński <krzysztof.kosinski@intel.com>

docs: Document the ThreadPool and WorkQueue classes.

Signed-off-by: Krzysztof Kosiński <krzysztof.kosinski@intel.com>

docs: Document the Finisher class.

Signed-off-by: Krzysztof Kosiński <krzysztof.kosinski@intel.com>

Merge pull request #5317 from ceph/wip-quota-doc

doc/cephfs/quota: simple doc

Reviewed-by: John Spray <john.spray@redhat.com>
Reviewed-by: Travis Rhoden <trhoden@redhat.com>

doc/cephfs/quota: simple doc

Signed-off-by: Sage Weil <sage@redhat.com>

Merge pull request #5305 from ceph/wip-12417

auth: check return value of keyring->get_secret

Reviewed-by: Sage Weil <sage@redhat.com>

Merge pull request #5300 from yuyuyu101/wip-async-fix-20

AsyncConnection: Fix local message dispatch lack of source name

Merge pull request #5314 from dachary/wip-12419-rule-create-erasure

tests: robust test for the pool create crush map test

Reviewed-by: Kefu Chai <kchai@redhat.com>

tests: robust test for the pool create crushmap test

The test that goes with f1e86be589803596e86acc964ac5c5c03b4038d8 to
verify that a bugous crush ruleset will prevent the creation of a pool
trying to use it was fragile. I depends on the implementation of the
erasure code lrc plugin and turns out to not work on i386.

The test is modified to use a fake crushtool that always returns false
and validate that it prevents the creation of a pool, which demonstrate
it is used for crushmap validation prior to the pool creation.

http://tracker.ceph.com/issues/12419 Fixes: #12419

Signed-off-by: Loic Dachary <ldachary@redhat.com>

Merge pull request #5304 from ceph/wip-add-scrub-config-doc

doc/rados/configuration: add more scrub related config

Reviewed-by: Loic Dachary <ldachary@redhat.com>

doc/rados/configuration: add more scrub related config

Signed-off-by: Kefu Chai <kchai@redhat.com>

Merge pull request #5306 from dachary/wip-release-notes

src/script/ceph-release-notes: add --text for plain text output

Reviewed-by: Abhishek Lekshmanan <abhishek.lekshmanan@ril.com>

doc: v0.80.10 changelog

Signed-off-by: Sage Weil <sage@redhat.com>

src/script/ceph-release-notes: add --text for plain text output

This is a format that's easier to consume when sending a mail.

Signed-off-by: Loic Dachary <ldachary@redhat.com>

Merge pull request #5303 from oritwas/fix-cmake-4

cmake: add missing blkid to ceph-osd

Reviewed-by: Kefu Chai <kchai@redhat.com>

auth: check return value of keyring->get_secret

get_secret can fail to populate the passed CryptoKey, for
example if the entity name is not found in the keyring.  In
this case, attempts to use the CryptoKey will lead to
segfaults.

Fixes: #12417
Signed-off-by: John Spray <john.spray@redhat.com>

Merge pull request #5127 from tchaikov/wip-12193

tools: add osdmap commands to ceph-objectstore-tool

Reviewed-by: David Zafman <dzafman@redhat.com>

doc/releases: v0.80.10

Signed-off-by: Sage Weil <sage@redhat.com>

doc/release-notes: v0.80.10

Signed-off-by: Sage Weil <sage@redhat.com>

Merge branch 'wip-firefly-release-notes' of git://github.com/dachary/ceph

Merge pull request #4958 from xinxinsh/wip-clone-test

ceph_test_objectstore: improve the StoreTest.SimpleCloneTest

Reviewed-by: Haomai Wang <haomaiwang@gmail.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #5301 from ceph/wip-12251

mon: OSDMonitor: fix hex output on 'osd reweight'

Reviewed-by: Kefu Chai <kchai@redhat.com>

cmake: add missing blkid libraries

Signed-off-by: Orit Wasserman <owasserm@redhat.com>

Merge pull request #5302 from ssssztes/master

mon: fix the message in OSDMonitor::get_pools_health

Reviewed-by: Xinze Chi <xmdxcxz@gmail.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>

Update OSDMonitor.cc

OSDMonitor::get_pools_health(), s/objects/bytes/

Fixes: #12402
Signed-off-by: ren.huanwen@zte.com.cn

mon: OSDMonitor: fix hex output on 'osd reweight'

Fixes: #12251
Signed-off-by: Joao Eduardo Luis <joao@suse.de>

Merge pull request #5294 from ceph/wip-12354

client: fix directory fsync

Reviewed-by: Greg Farnum <gfarnum@redhat.com>

AsyncConnection: Fix local message dispatch lack of source

Signed-off-by: Haomai Wang <haomaiwang@gmail.com>

TestMsgr: Add message source check for local message dispatch

Signed-off-by: Haomai Wang <haomaiwang@gmail.com>

Merge pull request #5288 from hjwsm1989/pgmonitor-overflow

mon/PGMonitor: avoid overflow when checking num_objects against the threshold

Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #5297 from ceph/wip-7647

rgw: avoid using slashes for generated secret keys

rgw: avoid using slashes for generated secret keys

Just use plain alphanumeric characterset.

Fixes: #7647
Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>

client: fix directory fsync

When opening a regular file, fuse assigns a 'struct Fh' pointer to
fuse_file_info::fh. but when openning a directory, fuse assigns a
'struct dir_result_t' to fuse_file_info::fh. So we need a seperate
function for fsyncdir (cast fuse_file_info::fh to a struct
dir_result_t pointer)

Fixes: #12354
Signed-off-by: Yan, Zheng <zyan@redhat.com>

Merge pull request #5291 from zhouyuan/rgw_s3_obj_version

rgw: doc: Mark S3 object version API as supported

Reviewed-by: Yehuda Sadeh <yehuda@redhat.com>

rgw: doc: Mark S3 object version API as supported

S3 object version is already in since Hammer.
Ref: http://marc.info/?l=ceph-devel&m=143715290627682

Signed-off-by: Yuan Zhou <yuan.zhou@intel.com>

  mon/PGMonitor: avoid uint64_t overflow when checking pool 'target/max' status.
Fixes: #12401
Signed-off-by: huangjun <hjwsm1989@gmail.com>

Merge pull request #5282 from ceph/wip-fix-test-mon_deprecated_commands

qa/workunits: cephtool: take EOPNOTSUPP as an alias of ENOTSUP

Reviewed-by: Loic Dachary <ldachary@redhat.com>

qa/workunits: cephtool: take EOPNOTSUPP as an alias of ENOTSUP

the proble breaks `test_mon_deprecated_commands` on ubuntu precise,
on the python shipped with ubuntu precise, errno.errorcode[95]
evalutes to `EOPNOTSUPP` but not `ENOTSUP`. but these two errnos
are equal in glibc.

Signed-off-by: Kefu Chai <kchai@redhat.com>

Merge pull request #5253 from ceph/wip-12262

Bug  fix for rados export
Add rados purge command
Fix and add rados tool testing to make check

Reviewed-by: Loic Dachary <ldachary@redhat.com>
Reviewed-by: John Spray <john.spray@redhat.com>

Merge pull request #5274 from zhouyuan/rgw_api_link

rgw: doc: adding S3/Swift API link

Reviewed-by: Abhishek Lekshmanan <abhishek.lekshmanan@ril.com>

Merge pull request #5281 from joehandzik/copyright_mailmap_update

doc: Adding Hewlett-Packard copyright messages

Merge pull request #5270 from dachary/wip-releases

doc: add v9.0.2 to the release timeline

doc: Adding Hewlett-Packard copyright messages to files containing more than minor enhancements and build scripting

Signed-off-by: Joe Handzik <joseph.t.handzik@hp.com>

test: Make test_rados_tool.sh part of make check

Signed-off-by: David Zafman <dzafman@redhat.com>

common, tools, test: Add "rados purge" feature to remove all objects from a pool

This required creating an Object type which is a pair of strings an
object id and object namespace.  Functionally, nothing has changed
with regards to the bench and cleanup command semantics.  Those
commands still allow operation in the default or a specified namespace.

Fixes: #12262
Signed-off-by: David Zafman <dzafman@redhat.com>

Merge pull request #5052 from ceph/wip-11815-restore-crushmap

tools: add a tool to restore crush map after a faulty one is injected

Reviewed-by: Joao Eduardo Luis <joao@suse.de>

Merge pull request #5246 from t-miyamae/wip-mshec-fixlogic3

erasure code: shec performance optimization by SIMD instructions

Reviewed-by: Loic Dachary <ldachary@redhat.com>

test: add test for {get,set}-inc-osdmap commands.

Signed-off-by: Kefu Chai <kchai@redhat.com>

Merge pull request #5273 from wonzhq/rados-df

rados.cc: fix an issue in the output of the 'rados df' command

Reviewed-by: Kefu Chai <kchai@redhat.com>

tools: ceph-monstore-update-crush: fail early if mon's running

Signed-off-by: Joao Eduardo Luis <joao@suse.de>

tools: ceph_monstore_tool: describe behavior of rewrite command

Signed-off-by: Joao Eduardo Luis <joao@suse.de>

osd/OSDMap: fix a typo in the comment

Signed-off-by: Kefu Chai <kchai@redhat.com>

osd/OSDMap: remove unused dump_json()

Signed-off-by: Kefu Chai <kchai@redhat.com>

package ceph-monstore-update-crush.sh

Fixes: #11815
Signed-off-by: Kefu Chai <kchai@redhat.com>

test: add a test to exercise ceph-monstore-update-crush.sh

Fixes: #11815
Signed-off-by: Kefu Chai <kchai@redhat.com>

tools: add ceph-monstore-update-crush.sh

Fixes: #11815
Signed-off-by: Kefu Chai <kchai@redhat.com>

PendingReleaseNotes: add the notes about osdmaptool

* its '--dump-json' option is replaced by '--dump json'

Signed-off-by: Kefu Chai <kchai@redhat.com>

tool/osdmaptool: replace --dump-json with --dump

* --dump will accept a formatter argument.

Signed-off-by: Kefu Chai <kchai@redhat.com>

tools/ceph-monstore-tools: add rewrite command

"rewrite" command will
 - add a new osdmap version to update current osdmap held by OSDMonitor
 - add a new paxos version, as a proposal it will
   * rewrite all osdmap epochs from specified epoch to  the last_committed
     one with the specified crush map.
   * add the new osdmap which is added just now
so the leader monitor can trigger a recovery process to apply the transaction
to all monitors in quorum, and hence bring them back to normal after being
injected with a faulty crushmap.

Fixes: #11815
Signed-off-by: Kefu Chai <kchai@redhat.com>

Merge pull request #4807 from dachary/wip-11814-erasure-code-ruleset

mon: validate implicit erasure code crush ruleset

Reviewed-by: Takeshi Miyamae <miyamae.takeshi@jp.fujitsu.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>

rados.cc: fix an issue in the output of the 'rados df' command

The output doesn't indent correctly without this fix. Right align the df
stats with their headers. Before this change some of them are 1
character off, and with a strange 'category' column.

Signed-off-by: Zhiqiang Wang <zhiqiang.wang@intel.com>

rgw: doc: adding S3/Swift API link

Signed-off-by: Yuan Zhou <yuan.zhou@intel.com>

erasure code: shec add ceph-erasure-code-corpus

Signed-off-by: Takeshi Miyamae <miyamae.takeshi@jp.fujitsu.com>

tools/ceph-objectstore-tool: add get-inc-osdmap command

Signed-off-by: Kefu Chai <kchai@redhat.com>

tools/ceph-objectstore-tool: add set-inc-osdmap command

Signed-off-by: Kefu Chai <kchai@redhat.com>

test: add test for {get,set}-osdmap commands

Signed-off-by: Kefu Chai <kchai@redhat.com>

Merge pull request #5260 from ceph/wip-12297-readdir

DNM Client: check dir is still complete after dropping locks in _readdir_cache_cb

doc: add v9.0.2 to the release timeline

Signed-off-by: Loic Dachary <ldachary@redhat.com>

doc/release-notes: v9.0.2

Signed-off-by: Sage Weil <sage@redhat.com>

Merge pull request #5268 from dachary/wip-ceph-port

tests: test/cephtool-test-mon.sh uses 7202 7203 and 7204

Reviewed-by: David Zafman <dzafman@redhat.com>

test: test_rados_tool.sh update due to new import/export semantics

Remove redundant check for rados binary
No longer use the attr command so remove check

Signed-off-by: David Zafman <dzafman@redhat.com>

Merge pull request #5266 from ceph/wip-ftbfs-cls-cephfs

cls: fix the build on i386

Reviewed-by: Loic Dachary <ldachary@redhat.com>

tests: test/cephtool-test-mon.sh uses 7202 7203 and 7204

When running 3 mons, vstart uses ports starting from CEPH_PORT=7202 and
increments to 7203 for the second mon and 7204 for the third. Add a
comment showing the port number. The method for a test to figure out
which port is free is to grep for the port and if nothing matches, use
it. The grep will match 7204 and 7203 and 7202 from the comment and
reduce the chances of someone using 7203 because it was nowhere to be
found in the sources.

Signed-off-by: Loic Dachary <ldachary@redhat.com>

Merge branch 'wip-10507'

Reviewed-by: Sage Weil <sage@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Greg Farnum <gfarnum@redhat.com>

tools/ceph-objectstore-tool: add "get-osdmap" command

Signed-off-by: Kefu Chai <kchai@redhat.com>

tools/ceph-objectstore-tool: add "set-osdmap" command

Fixes: #12193
Signed-off-by: Kefu Chai <kchai@redhat.com>

messages: MForward: get() message reference

Don't simply put() a reference if it has gone unclaimed without
get()'ing it first. This can cause nefarious consequences for those
users of MForward that do not expect this to happen.

Signed-off-by: Joao Eduardo Luis <joao@suse.de>

mon: MonOpRequest: dump function as private

Signed-off-by: Joao Eduardo Luis <joao@suse.de>

mon: services: assert on unexpected op request type

Ensures some type safety by asserting on the request type.

Signed-off-by: Joao Eduardo Luis <joao@suse.de>

mon: Monitor: set op request type during dispatch

Signed-off-by: Joao Eduardo Luis <joao@suse.de>

mon: MonOpRequest: allow setting the op type

When we introduced the MonOpRequest in the monitor and moved pretty much
every single function receiving messages in their arguments to take op
requests, we basically lost the type safety that was guaranteed from
Monitor::dispatch().

This patch adds an op_type field to the op request, as an easy fix for
this now lacking safety.

Signed-off-by: Joao Eduardo Luis <joao@suse.de>

mon: Monitor: drop PaxoServiceMessage reply functions

The services are now fully using MonOpRequest and should stay that way.
Drop PaxosService-specific reply functions as we want nothing to do with
them :)

Signed-off-by: Joao Eduardo Luis <joao@suse.de>

mon: MDSMonitor: use op-related no_reply()

Signed-off-by: Joao Eduardo Luis <joao@suse.de>

mon: OSDMonitor: use op requests when sending out full/incrementals

Signed-off-by: Joao Eduardo Luis <joao@suse.de>

mon: OSDMonitor: move failure code to support op requests

Signed-off-by: Joao Eduardo Luis <joao@suse.de>

mon: Monitor: have op-related no_reply()

Signed-off-by: Joao Eduardo Luis <joao@suse.de>

mon: MonOpRequest: send_reply() belongs in the Monitor class

Op Requests should have no business replying to messages. Besides,
given the Monitor is currently the place to do this, because it is the
one with access to all things that may be required to validate state
(e.g., quorum features), permanently moving this code to the Monitor
class also avoid having duplicate/very similar code in two distinct
places.

Signed-off-by: Joao Eduardo Luis <joao@suse.de>

mon: Monitor: routed requests handling op requests

Signed-off-by: Joao Eduardo Luis <joao@suse.de>

mon: Monitor: forward_request_leader() taking ops instead

Signed-off-by: Joao Eduardo Luis <joao@suse.de>

mon: Monitor: drop reply_command(MMonCommand *m,...)

Monitor commands are now op requests; always use ops when replying to
commands.

Signed-off-by: Joao Eduardo Luis <joao@suse.de>

mon: use op's get_session() instead of getting from connection

Signed-off-by: Joao Eduardo Luis <joao@suse.de>

mon: services: use op-based reply_command()

Signed-off-by: Joao Eduardo Luis <joao@suse.de>

cls: fix the build on i386

this is a leftover of 0dae022

Signed-off-by: Kefu Chai <kchai@redhat.com>

mon: Monitor: reply_command() wrapper for ops

Signed-off-by: Joao Eduardo Luis <joao@suse.de>

mon: Paxos: mark events

Signed-off-by: Joao Eduardo Luis <joao@suse.de>

mon: Monitor: mark events

Signed-off-by: Joao Eduardo Luis <joao@suse.de>