common: Rename Logger to ProfilingLogger

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>

common: combine set_fg_logging into common_init

Combine set_fg_logging into common_init. This eliminates the problem
where we briefly try to apply the logging settings from the config file
even in a program that needs to set foreground logging.

TestTimers, TestSignalHandlers, TestDoutStreambuf: don't initialize ceph
authentication. These applications don't need it.

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>

gitignore: ignore massif.out.*

Signed-off-by: Sage Weil <sage.weil@dreamhost.com>

config: kill more unused options

Signed-off-by: Sage Weil <sage.weil@dreamhost.com>

cfuse: remove high level fuse interface

Untested, unused, and inferior to the lowlevel implementation.

Signed-off-by: Sage Weil <sage.weil@dreamhost.com>

common: call closelog before openlog

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>

vstart.sh: -k doesn't take an argument

-k doesn't take an argument, so don't call shift a second time. (It's
already called once at the end of the loop.)

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>

config: call openlog to set ident

Set the 'ident' field in our syslog output.

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>

dout: force reopen after conf read, fg logging set

After the configuration is read, or a program sets foreground logging,
force those changes to be applied to the dout() configuration.

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>

mkcephfs: fix bug in multi-node setups

mkcephfs needs to create $TDIR on the other nodes in a multi-node setup
before trying to scp files into that directory.

Also, do mkdir -p on the directory where the configuration is going to
go.

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>

safe_io: move to C

Fixes unistd vs XOPEN_SOURCE define weirdness.

Signed-off-by: Sage Weil <sage.weil@dreamhost.com>

ceph: use new safe_read wrapper

Signed-off-by: Sage Weil <sage.weil@dreamhost.com>

add safe_{read/write} wrappers

Signed-off-by: Sage Weil <sage.weil@dreamhost.com>

build_debian_image: include bind9-host

Signed-off-by: Sage Weil <sage.weil@dreamhost.com>

build_debian_image: fixes

- /dev/pts
- copy console helper scripts
- run from any directory

Signed-off-by: Sage Weil <sage.weil@dreamhost.com>

filejournal: fix return code check

pwrite() returns number of bytes, or -1.

Signed-off-by: Sage Weil <sage.weil@dreamhost.com>

qa: test for proper i_complete handling

This reproduces some buggery with rename vs I_COMPLETE on the kernel
client.

Signed-off-by: Sage Weil <sage.weil@dreamhost.com>

build_debian_image: include libcrypto++ (need for runtime)

Signed-off-by: Sage Weil <sage.weil@dreamhost.com>

kernel console debug output setup scripts

Signed-off-by: Sage Weil <sage.weil@dreamhost.com>

script: add script to build uml images

Set up a tap interface in your bridge, and then

./linux ubda=image mem=512M eth0=tuntap,tap0 ip=<ip> netmask=<netmask> gw=<gw>

Signed-off-by: Sage Weil <sage.weil@dreamhost.com>

remove old script

remove ancient web content

Signed-off-by: Sage Weil <sage.weil@dreamhost.com>

msgr: make remove_pid_file fail silently if nothing to remove

Signed-off-by: Sage Weil <sage.weil@dreamhost.com>

remove ancient mds_local_osd option

This used to add a few osds to the end of the osdmap, not included in the
crush map, with the assumption that they would be colocated with the MDSs
and used as the primary MDS journal copy.  Not a useful hack anymore; you
can do this all explicitly by setting up your own crush map.

Signed-off-by: Sage Weil <sage.weil@dreamhost.com>

fakemessenger: remove fakemessenger and related dead code

FakeMessenger has hopelessly drifted from the current abstract interface;
all of this code is years old.

Signed-off-by: Sage Weil <sage.weil@dreamhost.com>

clock: remove tare function

This was used way back when to set a clock's relative "zero" time to
simplify stat collection when running performance benchmarks.  It has no
use in a real system.  If we need relative time for something, we can
subtract off the zero time in the output.

Signed-off-by: Sage Weil <sage.weil@dreamhost.com>

config: remove (most) unused options

Left in a few that may be used later:

client_unmount_timeout
osd_shed_reads*
osd_min_raid_width
osd_recovery_forget_lost_objects

Signed-off-by: Sage Weil <sage.weil@dreamhost.com>

client: set lru midpoint

Signed-off-by: Sage Weil <sage.weil@dreamhost.com>

logger: don't calculate variance by default

Less memory, less CPU.

Signed-off-by: Sage Weil <sage.weil@dreamhost.com>

msgr: check return values

Signed-off-by: Sage Weil <sage.weil@dreamhost.com>

msgr: check return values for write_pid_file

Signed-off-by: Sage Weil <sage.weil@dreamhost.com>

msgr: SimpleMessenger::start: fix unchecked return

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>

msgr: remove deadcode, warnings

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>

msgr: remove_pid_file: fix unchecked returns

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>

os: FileJournal::do_write: fix error handling

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>

Merge branch 'wannoying2'

Conflicts:
src/os/FileJournal.cc

filestore: handle read_op_seq errors

Fixes: #775
Signed-off-by: Sage Weil <sage.weil@dreamhost.com>

osd: Return error code when a write is too large.

This should prevent us from crashing the OSD by trying
to pass in a write that is larger than its journal can handle.

Signed-off-by: Greg Farnum <gregory.farnum@dreamhost.com>

config: add new osd_max_write_size option.

Signed-off-by: Greg Farnum <gregory.farnum@dreamhost.com>

assert.h: Add ceph_abort

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>

os: _check_disk_write_cache: fix error handling

Fix error handling; use popen instead of a temporary file.

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>

cmds: check return code of chdir

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>

unittest_encoding: build without -fstrict-aliasing

unittest_encoding gets "this breaks strict-aliasing" warnings when
compiled under Ubuntu. So don't crank up optimization on the unit test.

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>

FileStore::mount: fix error handling

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>

os: fix zeroing first chunk of FileJournal

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>

os: FileStore::mkjournal: fix error handling

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>

os: FileJournal::create: fix error handling

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>

cmon: check return code of chdir

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>

tools/common: EINTR/unchecked return fix

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>

rados: fix pedantic gcc warning on writing stdout

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>

filejournal: fix unchecked returns, modularize

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>

cosd: check chdir return code

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>

osd: Ager: remove Ebofs leftovers

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>

Add do_autogen.sh

It's handy when making builds with various different warning levels.
Also saves you from having to remember --prefix, etc. all the time.

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>

mkcephfs: clean up temp files, honor $TEMPDIR

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>

filer: fix probe

ENOENT is allowed and expected at the end of a journal.  It is treated the
same as a zero size object.

Fixes 800507e891170b99cae10a9bf7c5166fd3512927.

Signed-off-by: Sage Weil <sage.weil@dreamhost.com>

client/fuse_ll.c: const cleanup

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>

Revert "client/fuse_ll: fully initialize callback struct"

Older build environments may not have all the fuse function ptrs that
are present in newer ones. It's best to just let them all silently be
set to 0.

This reverts commit 516ac99bb8c16614757f3b61f4bf266e4531861e.

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>

Revert "client/fuse.cc: explicity zero fuse function ptrs"

Older build environments may not have all the fuse function ptrs that
are present in newer ones. It's best to just let them all silently be
set to 0.

This reverts commit 38b50013e27e79dd43c5f514c8c24bd8b1e69e5f.

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>

Merge branch 'master' of ssh://ceph.newdream.net/git/ceph

filestore: fix wipe_subvol the rest of the way

Signed-off-by: Sage Weil <sage.weil@dreamhost.com>

filestore: fix (part of) wipe_subvol

Signed-off-by: Sage Weil <sage.weil@dreamhost.com>

msgr: add nonce parsing to entity_addr_t::parse()

Reported-by: John Leach <john@brightbox.co.uk>
Signed-off-by: Sage Weil <sage.weil@dreamhost.com>

os: FileStore::wipe_subvol: fix removing old dir

Older versions of btrfs which don't have BTRFS_IOC_SNAP_DESTROY need to
manually remove snapshots.

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>

cosd.cc: better error message if osd->init fails

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>

auth/ExportControl: fix allow_def leak

allow_def would be leaked if the first branch is not taken.

Signed-off-by: Samuel Just <samuel.just@dreamhost.com>

Merge branch 'stable'

Conflicts:
src/common/signal.cc
src/os/FileStore.cc

signal: fix redefine warnings

Signed-off-by: Sage Weil <sage.weil@dreamhost.com>

ReplicatedPG: snap_trimmer fix leaked lock

Previous patch 7a02070b741d3482ff6b28827c1eb274a2134486 leaks the pg
lock.

Signed-off-by: Samuel Just <samuel.just@dreamhost.com>

mds: make SETDIRLAYOUT start with ancestor policy

When we set a new policy on a directory, make the starting point the
current policy, as specified by an ancestor.  Remove any reference to
g_default_file_layout.

This aligns the code with the inode creation paths (the other time we
look at the layout policy).

Signed-off-by: Sage Weil <sage.weil@dreamhost.com>

ReplicatedPG:snap_trimmer should return if !clean or !active or !primary

The PG may become !clean or !active while in the osd snap_trim_wq.

Signed-off-by: Samuel Just <samuel.just@dreamhost.com>

Merge branch 'wannoying'

MonMap: add,remove,contains can take const references

Signed-off-by: Samuel Just <samuel.just@dreamhost.com>

SimpleMessenger: learned_addr can take a const ref

peer_addr_for_me can be passed as a const ref.

Signed-off-by: Samuel Just <samuel.just@dreamhost.com>

mds: handle_client_setdirlayout: init fl_pg_pool

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>

librados: print out errs in do_import, check EINTR

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>

include/utime.h: avoid comparing float with 0

Avoid doing an exact comparison of a float with 0.

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>

crush: eliminate signed/unsigned comparisons

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>

client/fuse.cc: explicity zero fuse function ptrs

Set unused function pointers to 0 explicitly to please gcc. (They were
already implicitly zeroed because the containing struct was a global.)

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>

mount.ceph: put static at the beginning of decl

To squash a gcc warning.

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>

tools/gui.cc: remove empty else statement

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>

mon/OSDMonitor: don't check if unsigned < 0

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>

osd/OSD: remove always-true assert

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>

const-ify some unchanging static structs

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>

rgw/rgw_rest.cc: fix uninitialized static struct

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>

osdc/Filer: assert(0) on stat error

Remove broken error handling code and replace with an assert(0) and a
TODO.

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>

client/fuse_ll: fully initialize callback struct

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>

mds/locks: fully initialize lock states

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>

osdc/ObjectCacher.h: don't assert unsigned >= 0

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>

Client::readdir_r_cb: fix "always returns true"cmp

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>

direct_io_test: fix signed/unsigned, printf flags

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>

src/config.cc: fully initialize g_default_file_layout

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>

crush/builder.c: fix signed/unsigned confusion

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>

include/buffer.h:unsigned variables are always >=0

Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>

Merge branch 'master' of ssh://ceph.newdream.net/git/ceph

RGW: RGW::GetObj - signed/unsigned bug

get_obj returns an int, len is unsigned

Signed-off-by: Samuel Just <samuel.just@dreamhost.com>

RGW: fix ret in RGWCopyObj::init_common

int ret shadows RGWCopyObj::ret.

Signed-off-by: Samuel Just <samuel.just@dreamhost.com>

RGW: fix shadowed variable error

int ret and bool ret shadow this->ret, setting ret before the goto
therefore had no effect in these cases.

Signed-off-by: Samuel Just <samuel.just@dreamhost.com>

RGW: get_service_secret returns a bool, not an int

Signed-off-by: Samuel Just <samuel.just@dreamhost.com>

RBD.cc: pread returns a signed value

The check for len < 0 here always returned true since len is uint64_t.

Signed-off-by: Samuel Just <samuel.just@dreamhost.com>