Merge pull request #53412 from trociny/wip-62352-reef

reef: qa: fix keystone in rgw/crypt/barbican.yaml

Merge pull request #53811 from zdover23/wip-doc-2023-10-04-backport-53791-to-reef

reef: doc/rados: edit ops/control.rst (1 of x)

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

Merge pull request #53831 from rhcs-dashboard/wip-62999-reef

reef: mgr/dashboard: fix cephfs forms validations

Reviewed-by: Aashish Sharma <aasharma@redhat.com>

mgr/dashboard: fix cephfs forms validations

1. CephFS Edit Form didnt had any validation for name eventhough the
   create had. So reused the Create form to display the Edit as well

2. Add Name Validations to Subvoume and Subvolume group forms

3. Removed the datePipe from the cephfs list template since we are using
   the relativeDate.

Fixes: https://tracker.ceph.com/issues/62939
Signed-off-by: Nizamudeen A <nia@redhat.com>
(cherry picked from commit cd617a3bd28b0aedd03505314509f0c00391bc39)

Merge pull request #53818 from aaSharma14/wip-63098-reef

reef: mgr/dashboard: Fix user/bucket count in rgw overview dashboard

Reviewed-by: Ankush Behl <cloudbehl@gmail.com>

Merge pull request #53780 from rhcs-dashboard/wip-63069-reef

reef: mgr/dashboard: allow tls 1.2 with a config option

Reviewed-by: Avan Thakkar <athakkar@redhat.com>

Merge pull request #53646 from vshankar/wip-61805-reef

reef: cephfs-journal-tool: disambiguate usage of all keyword (in tool help).

Reviewed-by: Venky Shankar <vshankar@redhat.com>

Merge pull request #53638 from vshankar/wip-62950-reef

reef: cephfs-mirror: do not run concurrent C_RestartMirroring context

Reviewed-by: Venky Shankar <vshankar@redhat.com>

Merge pull request #53627 from lxbsz/wip-62947

reef: qa: descrease pgbench scale factor to 32 for postgresql database test

Reviewed-by: Venky Shankar <vshankar@redhat.com>

Merge pull request #52843 from lxbsz/wip-62271

reef: xfstests_dev: install extra packages from powertools repo for xfsprogs

Reviewed-by: Venky Shankar <vshankar@redhat.com>

Merge branch 'reef' into wip-doc-2023-10-04-backport-53791-to-reef

Signed-off-by: zdover23 <zac.dover@proton.me>

Merge pull request #53810 from rhcs-dashboard/wip-63091-reef

reef: mgr/dashboard: rbd image hide usage bar when disk usage is not provided

Reviewed-by: Nizamudeen A <nia@redhat.com>

Merge pull request #53815 from zdover23/wip-doc-2023-10-04-backport-53792-to-reef

reef: doc/rados: edit ops/control.rst (2 of x)

mgr/dashboard: Fix user/bucket count in rgw overview dashboard

Donot consider buckets/users count from daemons that have similar realm
name

Fixes: https://tracker.ceph.com/issues/62964
Signed-off-by: Aashish Sharma <aasharma@redhat.com>
(cherry picked from commit bfdcabe9d967ab28040173107bfd3f94235e3921)

doc/rados: edit ops/control.rst (2 of x)

Edit doc/rados/operations/control.rst (2 of x).

Co-authored-by: Cole Mitchell <cole.mitchell.ceph@gmail.com>
Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 03ed13930661628c10f185af1a3949548bdc8288)

Merge pull request #53806 from aaSharma14/wip-63087-reef

reef: mgr/dashboard: Rgw Multi-site naming improvements

Reviewed-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>

doc/rados: edit ops/control.rst (1 of x)

Edit doc/rados/operations/control.rst (1 of x).

Co-authored-by: Cole Mitchell <cole.mitchell.ceph@gmail.com>
Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 89c9584f8a1633b5ad1936af09529657d81b7134)

mgr/dashboard: rbd image hide usage bar when disk usage is not provided

Fixes: https://tracker.ceph.com/issues/63037
Signed-off-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
(cherry picked from commit 17d87af98a60471fc72cab4e6d5a53caf1847842)

Merge pull request #52662 from rhcs-dashboard/wip-62184-reef

reef: mgr/dashboard: upgrade angular v14 and v15

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Ankush Behl <cloudbehl@gmail.com>

Merge pull request #53805 from aaSharma14/wip-63079-reef

reef: mgr/dashboard: show a message to restart the rgw daemons after moving from single-site to multi-site

Reviewed-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>

Merge pull request #53795 from rhcs-dashboard/wip-63077-reef

reef: mgr/dashboard: enable protect option if layering enabled

Reviewed-by: Nizamudeen A <nia@redhat.com>

mgr/dashboard: Rgw Multi-site naming improvements

Fixes: https://tracker.ceph.com/issues/62721
Signed-off-by: Aashish Sharma <aasharma@redhat.com>
(cherry picked from commit e3d8ac03c343f98b43f8a009cb2a26fc913ad12d)

Merge pull request #53778 from rhcs-dashboard/wip-63067-reef

reef: mgr/dashboard: fix cephfs form validator

Reviewed-by: Avan Thakkar <athakkar@redhat.com>

mgr/dashboard: show a message to restart the rgw daemons after moving from single-site to multi-site

Fixes: https://tracker.ceph.com/issues/62984
Signed-off-by: Aashish Sharma <aasharma@redhat.com>
(cherry picked from commit ab06466aa2bb7ddc97ccc33acb3aa6ce35582f05)

Merge pull request #53515 from yuvalif/wip-61642-reef

reef: rgw/kafka: make sure that destroy is called after connection is removed

Reviewed-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #53599 from idryomov/wip-62711-reef

reef: qa/suites/{rbd,krbd}: disable POOL_APP_NOT_ENABLED health check

Reviewed-by: Ramana Raja <rraja@redhat.com>

Merge pull request #53590 from cbodley/wip-62935-reef

reef: rgw/crypt: don't deref null manifest_bl

Reviewed-by: Shilpa Jagannath <smanjara@redhat.com>

Merge pull request #53584 from cbodley/wip-62924-reef

reef: rgw/sal: get_placement_target_names() returns void

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>

Merge pull request #53514 from yuvalif/wip-61535-reef

reef: RGW:notifications: persistent topics are not deleted via radosgw-admin

Reviewed-by: Shilpa Jagannath <smanjara@redhat.com>

Merge pull request #53513 from yuvalif/wip-59496-reef

reef: rgw/kafka: failed to reconnect to broker after idle timeout

Reviewed-by: Shilpa Jagannath <smanjara@redhat.com>

Merge pull request #53510 from yuvalif/wip-62803-reef

reef: rgw/notifications: allow cross tenant notification management

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>

Merge pull request #53509 from yuvalif/wip-62831-reef

reef: RGW: add admin interfaces to get and delete notifications by bucket

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>

Merge pull request #53507 from yuvalif/wip-61484-reef

reef: RGW: bucket notification - hide auto generated topics when listing topics

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>

Merge pull request #53466 from k0ste/wip-61439-reef

reef: rgw/multisite[archive zone]: fix storing of bucket instance info in the new bucket entrypoint

Reviewed-by: Shilpa Jagannath <smanjara@redhat.com>

Merge pull request #53440 from trociny/wip-61871-reef

reef: rgw: pick http_date in case of http_x_amz_date absence

Reviewed-by: Shilpa Jagannath <smanjara@redhat.com>

Merge pull request #53437 from k0ste/wip-62825-reef

reef: RadosGW API: incorrect bucket quota in response to HEAD /{bucket}/?usage

Reviewed-by: Shilpa Jagannath <smanjara@redhat.com>

Merge pull request #53398 from trociny/wip-62752-reef

reef: rgw: fix 2 null versionID after convert_plain_entry_to_versioned

Reviewed-by: J. Eric Ivancich <ivancich@redhat.com>

Merge pull request #53395 from trociny/wip-62306-reef

reef: rgw/sync-policy: Correct "sync status" & "sync group" commands

Reviewed-by: J. Eric Ivancich <ivancich@redhat.com>

Merge pull request #53377 from jzhu116-bloomberg/wip-59646-reef

reef: rgw/notification: pass in bytes_transferred to populate object_size in sync notification

Reviewed-by: Yuval Lifshitz <ylifshit@redhat.com>

Merge pull request #53375 from jzhu116-bloomberg/wip-59693-reef

reef: rgw/notification: remove non x-amz-meta-* attributes from bucket notifications

Reviewed-by: Yuval Lifshitz <ylifshit@redhat.com>

Merge pull request #53034 from galsalomon66/wip-62466-reef

reef: rgw/s3select: s3select fixes related to Trino/TPCDS benchmark and QE tests

Reviewed-by: Shilpa Jagannath <smanjara@redhat.com>

Merge pull request #53293 from ajarr/wip-62687-reef

reef: librbd: kick ExclusiveLock state machine on client being blocklisted when waiting for lock

Reviewed-by: Ilya Dryomov <idryomov@redhat.com>

Merge pull request #53276 from idryomov/wip-61707-reef

reef: librbd: make CreatePrimaryRequest remove any unlinked mirror snapshots

Reviewed-by: Ramana Raja <rraja@redhat.com>

mgr/dashboard: enable protect option if layering enabled

Fixes: https://tracker.ceph.com/issues/63076
Signed-off-by: avanthakkar <avanjohn@gmail.com>
(cherry picked from commit 91be9ecdf519df18e564c79681f6275376f786e6)

mgr/dashboard: allow tls 1.2 with a config option

Provide the option to allow tls1.2

`ceph dashboard set-enable-unsafe-tls-v1-2 True` followed with a mgr
restart will enable tls 1.2.

With tls1.2 enabled
```
╰─$ nmap -sV --script ssl-enum-ciphers -p 11000 127.0.0.1
Starting Nmap 7.93 ( https://nmap.org ) at 2023-09-27 16:56 IST
Nmap scan report for localhost (127.0.0.1)
Host is up (0.00018s latency).

PORT      STATE SERVICE  VERSION
11000/tcp open  ssl/http CherryPy wsgiserver
|_http-server-header: Ceph-Dashboard
| ssl-enum-ciphers:
|   TLSv1.2:
|     ciphers:
|       TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (ecdh_x25519) - A
|       TLS_ECDHE_RSA_WITH_CHACHA20_POLY1305_SHA256 (ecdh_x25519) - A
|       TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (ecdh_x25519) - A
|       TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256 (ecdh_x25519) - A
|       TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA (ecdh_x25519) - A
|       TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA (ecdh_x25519) - A
|       TLS_RSA_WITH_AES_256_GCM_SHA384 (rsa 2048) - A
|       TLS_RSA_WITH_AES_256_CCM (rsa 2048) - A
|       TLS_RSA_WITH_AES_128_GCM_SHA256 (rsa 2048) - A
|       TLS_RSA_WITH_AES_128_CCM (rsa 2048) - A
|       TLS_RSA_WITH_AES_256_CBC_SHA256 (rsa 2048) - A
|       TLS_RSA_WITH_AES_128_CBC_SHA256 (rsa 2048) - A
|       TLS_RSA_WITH_AES_256_CBC_SHA (rsa 2048) - A
|       TLS_RSA_WITH_AES_128_CBC_SHA (rsa 2048) - A
|     compressors:
|       NULL
|     cipher preference: server
|   TLSv1.3:
|     ciphers:
|       TLS_AKE_WITH_AES_256_GCM_SHA384 (ecdh_x25519) - A
|       TLS_AKE_WITH_CHACHA20_POLY1305_SHA256 (ecdh_x25519) - A
|       TLS_AKE_WITH_AES_128_GCM_SHA256 (ecdh_x25519) - A
|       TLS_AKE_WITH_AES_128_CCM_SHA256 (ecdh_x25519) - A
|     cipher preference: server
|_  least strength: A

Service detection performed. Please report any incorrect results at https://nmap.org/submit/ .
Nmap done: 1 IP address (1 host up) scanned in 16.55 seconds
```

Without tls1.2 enabled (which defaults to tls 1.3)
```
╰─$ nmap -sV --script ssl-enum-ciphers -p 11000 127.0.0.1
Starting Nmap 7.93 ( https://nmap.org ) at 2023-09-27 16:54 IST
Nmap scan report for localhost (127.0.0.1)
Host is up (0.000075s latency).

PORT      STATE SERVICE  VERSION
11000/tcp open  ssl/http CherryPy wsgiserver
| ssl-enum-ciphers:
|   TLSv1.3:
|     ciphers:
|       TLS_AKE_WITH_AES_256_GCM_SHA384 (ecdh_x25519) - A
|       TLS_AKE_WITH_CHACHA20_POLY1305_SHA256 (ecdh_x25519) - A
|       TLS_AKE_WITH_AES_128_GCM_SHA256 (ecdh_x25519) - A
|       TLS_AKE_WITH_AES_128_CCM_SHA256 (ecdh_x25519) - A
|     cipher preference: server
|_  least strength: A
|_http-server-header: Ceph-Dashboard
```

Fixes: https://tracker.ceph.com/issues/62940
Signed-off-by: Nizamudeen A <nia@redhat.com>
(cherry picked from commit 219c62bea60083c0e59a86454b0cecf8afaf9780)

mgr/dashboard: fix cephfs form validator

Number is not allowed as the starting character of the mds service

Fixes: https://tracker.ceph.com/issues/63005
Signed-off-by: Nizamudeen A <nia@redhat.com>
(cherry picked from commit fe8fa180d323500303f449be537ec2b7eae1a64a)

mgr/dashboard: upgrade to cypress 12

Looks like chrome 117 will need cypress >=12.15.0
https://github.com/cypress-io/cypress-documentation/issues/5479

Signed-off-by: Nizamudeen A <nia@redhat.com>
(cherry picked from commit 630ba3ab379439c1faab176532e489d5a67ac1c4)

mgr/dashboard: adapt and refactor jest test files

Use the `configureTestBed` as the placeholder for adding the
declarations, imports... that is required for the unit tests to run

Fixes: https://tracker.ceph.com/issues/62844
Signed-off-by: Nizamudeen A <nia@redhat.com>
(cherry picked from commit e2626fb63ca568b053cd97d30b398ed38446b5a4)

mgr/dashboard: update nodejs to 18.17.0

the latest npm doesn't support setting python as a config like `npm
config set python3` instead it needs to be either set in the node-gyp
explicitly using the node-gyp command or through an environment
variable.
Since we are calling the node-gyp through npm, we need to set the
environment variable which is documented here: https://github.com/nodejs/node-gyp?tab=readme-ov-file#configuring-python-dependency

Accordingly the CMakeLists.txt for dashboard is adapted

Fixes: https://tracker.ceph.com/issues/62844
Signed-off-by: Nizamudeen A <nia@redhat.com>
(cherry picked from commit 47f49e5b1ae2e5bf7aad5df23d877ae5df00210c)

mgr/dashboard: update to angular v15

- The scss import was broken because of the ~ symbol. Looks like its not
needed.

- Login username/password label was somehow broken because of the
placeholder class and color. instead of applying the color through a
class I applied the color directly to the attribute and it worked

- Typescript 4.9 uses ES2022 and it complaints about using some items
  before its initialization. There were other typescript fixes need to
be delivered because of this change.

- Reverting back the badge to rectangular shape (because I feel like the
  round leaves out some empty spaces)

Fixes: https://tracker.ceph.com/issues/62844
Signed-off-by: Nizamudeen A <nia@redhat.com>
(cherry picked from commit 7f8f232da45721f669b313bb883af948c7a9cce1)

mgr/dashboard: adapt jest unit tests to angular 14

Important change would be the introduction of `TypedFormControl` which
is now more stricter in typing the FormControl and FormGroups as well.
Right now the dashboard has many number of untypedforms which by default
is migrated to an `UntypedFormControl` class when I ran the angular
upgrade script

Fixes: https://tracker.ceph.com/issues/61641
Signed-off-by: Nizamudeen A <nia@redhat.com>
(cherry picked from commit 08a32ec4ef79c32b3182d327a79fdfbb3376164d)

mgr/dashboard: update angular to 14

Fixes: https://tracker.ceph.com/issues/61641
Signed-off-by: Nizamudeen A <nia@redhat.com>
(cherry picked from commit 8915205a9e190601d88f543ea898f0c1e28ca652)

Merge pull request #53118 from adk3798/wip-61964-reef

reef: mgr/cephadm: add is_host_<status> functions to HostCache

Reviewed-by: John Mulligan <jmulligan@redhat.com>

Merge pull request #53748 from zdover23/wip-doc-2023-10-02-backport-53744-to-reef

reef: doc/architecture: edit "Calculating PG IDs"

doc/architecture: edit "Calculating PG IDs"

Edit the section "Calcluating PG IDs" in doc/architecture.rst.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 69a585fbf4fbf50eed784a248442f622f01120c9)

Merge pull request #53742 from zdover23/wip-doc-2023-10-01-backport-53740-to-reef

reef: doc/architecture: edit several sections

doc/architecture: edit several sections

Edit the following sections in doc/architecture.rst:

 1. Dynamic Cluster Management
 2. About Pools
 3. Mapping PGs to OSDs

The tone of "Dynamic Cluster Management" remains a bit too close to the
tone of marketing material, in my opinion, but I will return to firm it
up when I have finished a once-over of architecture.rst.

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 9657c45fc12cd8522df72c9bb8820320758305e4)

Merge pull request #53738 from zdover23/wip-doc-2023-09-30-backport-53726-to-reef

reef: doc/architecture: edit "Replication"

doc/architecture: edit "Replication"

Edit "Replication" in the "Smart Daemons Enable Hyperscale" section of
doc/architecture.rst.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 4cf22e195ab367eb65f95c2578d06919ebcd108f)

Merge pull request #53730 from zdover23/wip-doc-2023-09-29-backport-53723-to-reef

reef: doc/architecture: edit "Data Scrubbing"

Reviewed-by: Cole Mitchell <cole.mitchell.ceph@gmail.com>

Merge pull request #52846 from lxbsz/wip-62201

reef: mds: skip forwarding request if the session were removed

Reviewed-by: Venky Shankar <vshankar@redhat.com>

Merge pull request #52748 from mchangir/wip-61990-reef

reef: mgr/snap_schedule: allow retention spec 'n' to be user defined

Reviewed-by: Venky Shankar <vshankar@redhat.com>

Merge pull request #52742 from batrick/wip-62269-reef

reef: qa: wait for file to have correct size

Reviewed-by: Venky Shankar <vshankar@redhat.com>

Merge pull request #52724 from kotreshhr/wip-62240-reef

reef: mds: Fix the linkmerge assert check

Reviewed-by: Venky Shankar <vshankar@redhat.com>

Merge pull request #52681 from batrick/wip-62189-reef

reef: mds: update mdlog perf counters during replay

Reviewed-by: Venky Shankar <vshankar@redhat.com>

Merge pull request #52656 from joscollin/wip-62178-reef

reef: qa: fix cephfs-mirror unwinding and 'fs volume create/rm' order

Reviewed-by: Venky Shankar <vshankar@redhat.com>

Merge pull request #52246 from batrick/wip-61800-reef

reef: mon/MDSMonitor: plug paxos when maybe manipulating osdmap

Reviewed-by: Venky Shankar <vshankar@redhat.com>

doc/architecture: edit "Data Scrubbing"

Edit the "Data Scrubbing" listitem in the list of benefits conferred by
the use by OSDs of the aggregate power of the cluster, in the section
"Smart Daemons Enable Hyperscale" in doc/architecture.rst.

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit d7b991646fcd36a1df7456e8e82c9d54a01e50f9)

Merge pull request #53727 from zdover23/wip-doc-2023-09-29-backport-53707-to-reef

reef: doc/architecture: edit "OSD Membership and Status"

doc/architecture: edit "OSD Membership and Status"

Edit "OSD Membership and Status" in the "Smart Daemons Enable
Hyperscale" section of doc/architecture.rst.

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit dbd85336b1aa3ef42cfc12495b3dc5142d4b8a28)

Merge pull request #53506 from yuvalif/wip-62284-reef

reef: rgw/amqp: skip idleness tests since it needs to sleep longer than 30s

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>

Merge pull request #53686 from zdover23/wip-doc-2023-09-27-backport-53685-to-reef

reef: doc/architecture: edit "OSDs service clients directly"

Merge pull request #53695 from rhcs-dashboard/wip-63002-reef

reef: exporter: add ceph_daemon labels to labeled counters as well

Reviewed-by: Ilya Dryomov <idryomov@redhat.com>

exporter: add ceph_daemon labels to labeled counters as well

Exporter missed adding the `ceph_daemon` or `instance_id`
labels(in case if rgw metrics) to the new labeled performance counters.

Fixes: https://tracker.ceph.com/issues/62874
Signed-off-by: avanthakkar <avanjohn@gmail.com>
(cherry picked from commit f061955f0beabcaa3dca0dbfb6a8c8e56c764a0b)

deps: increase the node version to 16

With node 14, the angular 13 is going into some issues with node-gyp.
```
prebuild-install || node-gyp rebuild

prebuild-install WARN install No prebuilt binaries found (target=14.20.0 runtime=node arch=x64 libc= platform=linux)
make: Entering directory '/home/jenkins-build/build/workspace/ceph-dashboard-cephadm-e2e/src/pybind/mgr/dashboard/frontend/node_modules/tree-sitter/build'
  CC(target) Release/obj.target/tree_sitter/vendor/tree-sitter/lib/src/lib.o
  AR(target) Release/obj.target/tree_sitter.a
  COPY Release/tree_sitter.a
  CXX(target) Release/obj.target/tree_sitter_runtime_binding/src/binding.o
```
and in some other environments its like `cb() never called` and stops
the whole `npm ci` process.

After some research, looks like updating node is the way to stop this.

Also, ` npm 7 will block installations if an upstream dependency
conflict is present that cannot be automatically resolved.` https://github.blog/2021-02-02-npm-7-is-now-generally-available/#peer-dependencies

Fixes: https://tracker.ceph.com/issues/62107
Signed-off-by: Nizamudeen A <nia@redhat.com>
(cherry picked from commit 692a45362db367ab5a9410c35a8fae91f419b6ec)

 Conflicts:
src/pybind/mgr/dashboard/frontend/package-lock.json
  - generate a new lock file

Merge pull request #53669 from rhcs-dashboard/wip-62963-reef

reef: mgr/dashboard: fix prometheus queries subscriptions

Reviewed-by: Nizamudeen A <nia@redhat.com>

doc/architecture: edit "OSDs service clients directly"

Edit "OSDs service clients directly" in the list in
"Smart Daemons Enable Hyperscale" in doc/architecure.rst.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 6f9dfd75b50f7793d2ff9bc3003c35efa6d6da04)

Merge pull request #53659 from zdover23/wip-doc-2023-09-26-backport-53657-to-reef

reef: doc/architecture: edit "SDEH"

rgw/amqp: skip idleness tests since it needs to sleep longer than 30s

current idle timeout is 30s, so, making the test sleep for 30s may not
be enough. setting sleep time to be longer, and skippign the test so it
won't take too long.

Fixes: https://tracker.ceph.com/issues/62264
Signed-off-by: Yuval Lifshitz <ylifshit@redhat.com>
(cherry picked from commit 11439ecd8957cdf90b80fd52cc500372ffd24685)

mgr/dashboard: fix prometheus queries subscriptions

Fixes: https://tracker.ceph.com/issues/62868
Signed-off-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
(cherry picked from commit b7f25e63178080800f96f1cdcdd620fea200ea58)

doc/architecture: edit "SDEH"

Edit the front matter of the "Smart Daemons Enable Hyperscale" section
of doc/architecture.rst.

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 5054f6c7538e1e3b0ffd3c0badf0fcd3a95c8d92)

Merge pull request #53652 from rhcs-dashboard/wip-62967-reef

reef: mgr/dashboard: remove empty popover when there are no health warns

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Ankush Behl <cloudbehl@gmail.com>

mgr/dashboard: remove empty popover when there are no health warns

Fixes: https://tracker.ceph.com/issues/62846
Signed-off-by: Nizamudeen A <nia@redhat.com>
(cherry picked from commit d7d142435863239751fb5e228d80fe4c44490aee)

cephfs-journal-tool: disambiguate usage of all keyword (in tool help).

        The fs:all for rank option description was confusing. It seemd
like the fs was optional, but it is mandatory. This change modifies the
help message to reflect the correct way to use all in the --rank option.

Fixes: https://tracker.ceph.com/issues/61753
Signed-off-by: Manish M Yathnalli <myathnal@redhat.com>
(cherry picked from commit 52c033f85e274c86bd75f0eb902a32d86356094e)

cephfs-mirror: restart failed/blocklisted replayer instances

This was buggy right from the start. Start maintaining per replayer
blocklisted or failed timestamp and use that to check if a replayer
restart is required.

Signed-off-by: Venky Shankar <vshankar@redhat.com>
(cherry picked from commit f2fb84ddd25ac66ca1e79339801913b35b597e83)

cephfs-mirror: do not run concurrent C_RestartMirroring context

Fixes: http://tracker.ceph.com/issues/62072
Signed-off-by: Venky Shankar <vshankar@redhat.com>
(cherry picked from commit b4d8f99c2aaef3b3dd74a4840c21dcb3ca9eb81a)

Merge pull request #53632 from zdover23/wip-doc-2023-09-25-backport-53631-to-reef

reef: doc/architecture: edit "HA Authentication"

doc/architecture: edit "HA Authentication"

Edit "High Availability Authentication" in doc/architecture.rst.

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit cb680a7865c4766d54d535889ec1517a0e84b5b5)

qa: descrease pgbench scale factor to 32 for postgresql database test

The scale factor will depend on the node's performance and disk sizes
being used to run the test, and 500 seems too large here as a common
test case without knowing the nodes' configuration.

We should just follow the white-book:
https://github.com/ApsaraDB/PolarDB-for-PostgreSQL/blob/distributed/doc/polardb/benchmark.md

Fixes: https://tracker.ceph.com/issues/62700
Signed-off-by: Xiubo Li <xiubli@redhat.com>
(cherry picked from commit 497f951c0ddcb4be3921ef887f866eb534258537)

Merge pull request #53619 from zdover23/wip-doc-2023-09-24-backport-53613-to-reef

reef: doc/architecture: "Edit HA Auth"

doc/architecture: "Edit HA Auth"

Rewrite the explanation of how a client authenticates against a monitor.
This is a rewrite of a single paragraph, and has been set apart in its
own PR so that it can receive the maximum amount of scrutiny that the
upstream Ceph community can muster.

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit c71cd84ec9e579ba0913c4952570bba6082e03b5)

qa/suites/krbd: disable POOL_APP_NOT_ENABLED health check

... same as for rbd suite.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit 0b68a8b4c07d1528190c71cda566b9d1fdb32640)

qa/suites/rbd: drop POOL_APP_NOT_ENABLED from ignorelists

With "mon warn on pool no app = false" in the config, it's obviously
redundant.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit 9e884ddeecde4a3028803d207b1fab91706ebbf1)

qa/suites/rbd: disable POOL_APP_NOT_ENABLED health check

Commit 990806e635a1 ("mon, qa: issue pool application warning even
if pool is empty") made it impossible to create a pool without raising
a (bogus) health alert.  See [1] for details.

[1] https://lists.ceph.io/hyperkitty/list/dev@ceph.io/thread/ZTDYC5HN677RR26EB4P6PORN6L2IFH4R/

Fixes: https://tracker.ceph.com/issues/62711
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit e64830eb8e94eafa42b0a5f6cacd5359db317a0b)

Merge pull request #53543 from rhcs-dashboard/wip-62880-reef

reef: mgr/dashboard: align charts of landing page

Reviewed-by: Nizamudeen A <nia@redhat.com>

rgw/crypt: don't deref null manifest_bl

with dbstore, the manifest_bl pointer was null; check for null before
dereferencing for read_manifest_parts()

Fixes: https://tracker.ceph.com/issues/62378
Signed-off-by: Casey Bodley <cbodley@redhat.com>
(cherry picked from commit 04d9ea6dafb9ab0d71888b5ac9b1317c111e41ec)

Merge pull request #53585 from zdover23/wip-doc-2023-09-22-backport-53493-to-reef

reef: doc/architecture: "Edit HA Auth" (one of several)

doc/architecture: "Edit HA Auth" (one of several)

Edit "High Availability Authentication" in doc/architecture.rst.

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 78804e1aadb4d1ad8273ff7dc50b0ea7bc72b686)

rgw/sal: get_placement_target_names() returns void

the function returned an integer error code, but two callers were
incorrectly testing the return value as a boolean

the function just returns placement ids that are in-memory, so none of
the drivers have a failure case; change the return value to void

Fixes: https://tracker.ceph.com/issues/62771
Signed-off-by: Casey Bodley <cbodley@redhat.com>
(cherry picked from commit 3ad17ed3b222701bb6f4e3150989584645789d7c)

Merge pull request #53569 from zdover23/wip-doc-2023-09-21-backport-53176-to-reef

reef: doc: add note for removing (automatic) partitioning policy

Reviewed-by: Venky Shankar <vshankar@redhat.com>