]> git.apps.os.sepia.ceph.com Git - ceph.git/log
ceph.git
3 years agoMerge pull request #44429 from cyx1231st/wip-crimson-improve-log-2
Samuel Just [Wed, 5 Jan 2022 20:52:18 +0000 (12:52 -0800)]
Merge pull request #44429 from cyx1231st/wip-crimson-improve-log-2

crimson/os/seastore: differentiate loggers in seastore

Reviewed-by: Samuel Just <sjust@redhat.com>
3 years agoMerge pull request #44420 from aisakaki/lru-cache
Samuel Just [Wed, 5 Jan 2022 20:34:24 +0000 (12:34 -0800)]
Merge pull request #44420 from aisakaki/lru-cache

crimson/os/seastore/cache: add lru

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
3 years agoMerge pull request #44474 from ljflores/wip-doc-integration-tests
Neha Ojha [Wed, 5 Jan 2022 18:33:55 +0000 (10:33 -0800)]
Merge pull request #44474 from ljflores/wip-doc-integration-tests

doc/.../testing_integration_tests: fix formatting of teuthology-suite option

Reviewed-by: Neha Ojha <nojha@redhat.com>
3 years agodoc/.../testing_integration_tests: fix formatting of teuthology-suite option 44474/head
Laura Flores [Wed, 5 Jan 2022 16:48:53 +0000 (16:48 +0000)]
doc/.../testing_integration_tests: fix formatting of teuthology-suite option

The `--subset` teuthology-suite option should be formatted.

Signed-off-by: Laura Flores <lflores@redhat.com>
3 years agoMerge pull request #39192 from linuxbox2/wip-lc-notify
Matt Benjamin [Wed, 5 Jan 2022 14:38:47 +0000 (09:38 -0500)]
Merge pull request #39192 from linuxbox2/wip-lc-notify

rgwlc:  optionally support notifications on object expiration

3 years agoMerge pull request #44341 from sebastian-philipp/cleanup-snmp
Sebastian Wagner [Wed, 5 Jan 2022 13:34:48 +0000 (14:34 +0100)]
Merge pull request #44341 from sebastian-philipp/cleanup-snmp

mgr/cephadm: Cleanup snmp

Reviewed-by: Adam King <adking@redhat.com>
3 years agoMerge pull request #44000 from nmshelke/exception-handling-48473
Venky Shankar [Wed, 5 Jan 2022 12:25:39 +0000 (17:55 +0530)]
Merge pull request #44000 from nmshelke/exception-handling-48473

mgr/stats: exception handling for ceph fs perf stats command

Reviewed-by: Venky Shankar <vshankar@redhat.com>
3 years agoMerge pull request #44291 from vshankar/wip-ignore-invalid-client-op
Venky Shankar [Wed, 5 Jan 2022 12:25:06 +0000 (17:55 +0530)]
Merge pull request #44291 from vshankar/wip-ignore-invalid-client-op

mds: ignore unknown client op when tracking op latency

Reviewed-by: Venky Shankar <vshankar@redhat.com>
3 years agoMerge pull request #44279 from jtlayton/wip-50235
Venky Shankar [Wed, 5 Jan 2022 12:16:01 +0000 (17:46 +0530)]
Merge pull request #44279 from jtlayton/wip-50235

cephfs-shell: add the ability to mount a named filesystem

Reviewed-by: Venky Shankar <vshankar@redhat.com>
3 years agoMerge pull request #44158 from adk3798/agent-failed
Sebastian Wagner [Wed, 5 Jan 2022 11:28:34 +0000 (12:28 +0100)]
Merge pull request #44158 from adk3798/agent-failed

mgr/cephadm: don't include agents in CEPHADM_FAILED_DAEMON

Reviewed-by: Sebastian Wagner <sewagner@redhat.com>
3 years agoMerge pull request #44388 from rhcs-dashboard/02-host-inventory-fix
Alfonso Martínez [Wed, 5 Jan 2022 10:32:22 +0000 (11:32 +0100)]
Merge pull request #44388 from rhcs-dashboard/02-host-inventory-fix

mgr/dashboard: fix orchestrator/02-hosts-inventory.e2e failure

Reviewed-by: Waad Alkhoury <walkhour@redhat.com>
Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
3 years agoMerge pull request #44193 from adk3798/agent-upgrade
Sebastian Wagner [Wed, 5 Jan 2022 09:27:21 +0000 (10:27 +0100)]
Merge pull request #44193 from adk3798/agent-upgrade

mgr/cephadm: speed up upgrade when using agent

Reviewed-by: John Mulligan <jmulligan@redhat.com>
Reviewed-by: Sebastian Wagner <sewagner@redhat.com>
3 years agoMerge pull request #44266 from adk3798/http-reconfig
Sebastian Wagner [Wed, 5 Jan 2022 09:26:01 +0000 (10:26 +0100)]
Merge pull request #44266 from adk3798/http-reconfig

mgr/cephadm: reconfig agents over http

Reviewed-by: Sebastian Wagner <sewagner@redhat.com>
3 years agopython-common: move test_valid_snmp_gateway_spec from mgr/cephadm 44341/head
Sebastian Wagner [Mon, 20 Dec 2021 10:48:43 +0000 (11:48 +0100)]
python-common: move test_valid_snmp_gateway_spec from mgr/cephadm

We have to validate to_json() now as well, as we have spcial enums.
Otherwiese we might end up with !!python... representations.

Signed-off-by: Sebastian Wagner <sewagner@redhat.com>
3 years agopython-common: move test_invalid_snmp_gateway_spec from mgr/cephadm
Sebastian Wagner [Mon, 20 Dec 2021 10:37:40 +0000 (11:37 +0100)]
python-common: move test_invalid_snmp_gateway_spec from mgr/cephadm

Let's keep the tests in the same package where the class is defined.

Signed-off-by: Sebastian Wagner <sewagner@redhat.com>
3 years agomgr/cephadm: SNMP: don't write urls manually
Sebastian Wagner [Thu, 16 Dec 2021 16:57:50 +0000 (17:57 +0100)]
mgr/cephadm: SNMP: don't write urls manually

this just broken for non-trivial urls. Don't be a bad example

Signed-off-by: Sebastian Wagner <sewagner@redhat.com>
3 years agomgr/cephadm: SNMP: Don't write default values into the store
Sebastian Wagner [Thu, 16 Dec 2021 16:51:07 +0000 (17:51 +0100)]
mgr/cephadm: SNMP: Don't write default values into the store

Enable us to chage defaults in the future

Signed-off-by: Sebastian Wagner <sewagner@redhat.com>
3 years agomgr/cephadm: SNMP: use of python3 enums
Sebastian Wagner [Thu, 16 Dec 2021 16:43:47 +0000 (17:43 +0100)]
mgr/cephadm: SNMP: use of python3 enums

Little reason to duplicate things ourselves

Signed-off-by: Sebastian Wagner <sewagner@redhat.com>
3 years agoMerge pull request #44367 from sebastian-philipp/osd-count-fix-again
Sebastian Wagner [Wed, 5 Jan 2022 09:21:03 +0000 (10:21 +0100)]
Merge pull request #44367 from sebastian-philipp/osd-count-fix-again

mgr/cephadm: Fix count for OSDs with OSD specs

Reviewed-by: Adam King <adking@redhat.com>
3 years agoMerge pull request #44374 from fmount/ingress_vip
Sebastian Wagner [Wed, 5 Jan 2022 09:19:43 +0000 (10:19 +0100)]
Merge pull request #44374 from fmount/ingress_vip

mgr/cephadm: spec.virtual_ip  param should be used by the ingress daemon

Reviewed-by: Sebastian Wagner <sewagner@redhat.com>
3 years agoMerge pull request #44442 from ceph/dependabot-npm_and_yarn-src-pybind-mgr-dashboard...
Alfonso Martínez [Wed, 5 Jan 2022 09:04:58 +0000 (10:04 +0100)]
Merge pull request #44442 from ceph/dependabot-npm_and_yarn-src-pybind-mgr-dashboard-frontend-simplebar-angular-2.3.6

mgr/dashboard: bump simplebar-angular from 2.3.0 to 2.3.6 in /src/pybind/mgr/dashboard/frontend

Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
3 years agoMerge pull request #44361 from xxhdx1985126/wip-53612
Samuel Just [Wed, 5 Jan 2022 05:53:24 +0000 (21:53 -0800)]
Merge pull request #44361 from xxhdx1985126/wip-53612

crimson/os/seastore/cache: add lba nodes' logical begin addresses to extent_info_t

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
3 years agoqa: test cases for ceph fs perf stats command 44000/head
Nikhilkumar Shelke [Thu, 2 Dec 2021 11:27:10 +0000 (16:57 +0530)]
qa: test cases for ceph fs perf stats command

Fixes: https://tracker.ceph.com/issues/48473
Signed-off-by: Nikhilkumar Shelke <nshelke@redhat.com>
3 years agomgr/stats: exception handling for ceph fs perf stats command
Nikhilkumar Shelke [Thu, 2 Dec 2021 11:23:50 +0000 (16:53 +0530)]
mgr/stats: exception handling for ceph fs perf stats command

Fixes: https://tracker.ceph.com/issues/48473
Signed-off-by: Nikhilkumar Shelke <nshelke@redhat.com>
3 years agoMerge pull request #44458 from cyx1231st/wip-seastore-cleanup-with-empty-transactions
Samuel Just [Wed, 5 Jan 2022 04:53:50 +0000 (20:53 -0800)]
Merge pull request #44458 from cyx1231st/wip-seastore-cleanup-with-empty-transactions

crimson/os/seastore: cleanup with empty transactions

Reviewed-by: Samuel Just <sjust@redhat.com>
3 years agoMerge pull request #44268 from lxbsz/mds-fix1
Venky Shankar [Wed, 5 Jan 2022 04:23:25 +0000 (09:53 +0530)]
Merge pull request #44268 from lxbsz/mds-fix1

mds: set hb to NULL after the memory released

Reviewed-by: Venky Shankar <vshankar@redhat.com>
3 years agocrimson/os/seastore: cleanup with empty transactions 44458/head
Yingxin Cheng [Fri, 17 Dec 2021 05:43:50 +0000 (13:43 +0800)]
crimson/os/seastore: cleanup with empty transactions

* Add logs to identify OSD operation that submits transaction;
* Mark empty transactions as debug log;
* Misc cleanup;

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
3 years agoMerge pull request #44329 from ljflores/wip-telemetry-last-additions
Yuri Weinstein [Tue, 4 Jan 2022 22:43:05 +0000 (14:43 -0800)]
Merge pull request #44329 from ljflores/wip-telemetry-last-additions

mgr/telemetry: add heap stats and pool application to the perf channel

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
3 years agoMerge pull request #43716 from kamoltat/wip-ksirivad-autoscale-global-flag
Yuri Weinstein [Tue, 4 Jan 2022 22:42:41 +0000 (14:42 -0800)]
Merge pull request #43716 from kamoltat/wip-ksirivad-autoscale-global-flag

mgr/autoscaler: Introduce noautoscale flag

Reviewed-by: Vikhyat Umrao <vikhyat@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
3 years agorgwlc: format event.eventName with to_event_string(...) 39192/head
Matt Benjamin [Wed, 29 Dec 2021 17:47:42 +0000 (12:47 -0500)]
rgwlc: format event.eventName with to_event_string(...)

Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
3 years agorgwlc: add integration tests for lc triggered bucket notifications
yuval Lifshitz [Thu, 30 Dec 2021 16:14:03 +0000 (18:14 +0200)]
rgwlc: add integration tests for lc triggered bucket notifications

Signed-off-by: yuval Lifshitz <ylifshit@redhat.com>
3 years agorgwlc: temporary logic to compensate for rgw::sal::Bucket::get_owner() always nullptr
Matt Benjamin [Thu, 23 Dec 2021 21:51:52 +0000 (16:51 -0500)]
rgwlc: temporary logic to compensate for rgw::sal::Bucket::get_owner() always nullptr

(Acked by Daniel.)  Now with less use-after-free.

Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
3 years agoMerge pull request #44433 from sebastian-schmid/master
Laura Flores [Tue, 4 Jan 2022 17:21:59 +0000 (11:21 -0600)]
Merge pull request #44433 from sebastian-schmid/master

docs/start: fixes typo in hardware recommendation docs

3 years agoMerge pull request #43580 from rhcs-dashboard/cephadm_box-docs
Alfonso Martínez [Tue, 4 Jan 2022 16:24:44 +0000 (17:24 +0100)]
Merge pull request #43580 from rhcs-dashboard/cephadm_box-docs

cephadm/box: DiD box documentation

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: sebastian-philipp <sewagner@redhat.com>
3 years agoMerge pull request #43763 from rhcs-dashboard/cephadm_box
Alfonso Martínez [Tue, 4 Jan 2022 16:22:56 +0000 (17:22 +0100)]
Merge pull request #43763 from rhcs-dashboard/cephadm_box

cephadm/box: Cephadm Docker in Docker dev box

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
3 years agoMerge pull request #44449 from rhcs-dashboard/api-docs-e2e-test
Alfonso Martínez [Tue, 4 Jan 2022 16:19:48 +0000 (17:19 +0100)]
Merge pull request #44449 from rhcs-dashboard/api-docs-e2e-test

mgr/dashboard: add test coverage for API docs (SwaggerUI)

Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
3 years agodocs/start: fixes typo and empty headline in hardware recommendation docs 44433/head
Sebastian Schmid [Sat, 1 Jan 2022 16:33:10 +0000 (17:33 +0100)]
docs/start: fixes typo and empty headline in hardware recommendation docs

Signed-off-by: Sebastian Schmid <mail@sebastian-schmid.de>
3 years agoMerge pull request #44428 from rhcs-dashboard/e2e-improvement
Alfonso Martínez [Tue, 4 Jan 2022 16:15:26 +0000 (17:15 +0100)]
Merge pull request #44428 from rhcs-dashboard/e2e-improvement

mgr/dashboard: stabilizing the cephadm dashboard e2e

Reviewed-by: Waad Alkhoury <walkhour@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
3 years agoMerge pull request #44453 from sebastian-philipp/mypy-cheroot-import-ssl-fix
Sebastian Wagner [Tue, 4 Jan 2022 15:11:54 +0000 (16:11 +0100)]
Merge pull request #44453 from sebastian-philipp/mypy-cheroot-import-ssl-fix

mgr/dashboard: cheroot now ships type hints

Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
3 years agonotify: fix a use-after-move crash, unconstify res_id
Yuval Lifshitz [Wed, 29 Dec 2021 17:27:43 +0000 (12:27 -0500)]
notify: fix a use-after-move crash, unconstify res_id

Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
3 years agorgwlc: harmonize lifecycle notifications with the others
Matt Benjamin [Wed, 22 Dec 2021 18:33:52 +0000 (13:33 -0500)]
rgwlc:  harmonize lifecycle notifications with the others

After working with notification configurations, it seemed to make
more sense to organize the different lifecycle notification sub-types
along the same lines as the official AWS ones.  So, there are now
ObjectExpirationCurrent and ObjectExpirationNoncurrent types, and
an ObjectExpiration wildcard.  Similarly, ObjectTransition
contains Current and Noncurrent sub-types.

Note that I have defined an ObjectExpirationAbortMPU notification
sub-type, but do not currently generate it--this is to avoid changing
the rgw::sal interface, but most likely we would support this in
future.

Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
3 years agorgwlc: optionally support notifications on object expiration
Matt Benjamin [Tue, 26 Jan 2021 17:52:47 +0000 (12:52 -0500)]
rgwlc:  optionally support notifications on object expiration

Most of the work is to remove direct knowledge of req_state from
methods in rgw_notify.

I've chosen to create new notification types matching the different
expire actions (but not transition).  The new event types are not
nested under Delete.  Notifications are sent iff rgw_lc_notify is true
(default false).

Adjusted per comments in initial review, in particular, notification from
lifecycle is no longer conditional on a config setting, and constness
is restored.

Fixes: https://tracker.ceph.com/issues/49068
Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
3 years agomgr/dashboard: stabilizing the cephadm dashboard e2e 44428/head
Nizamudeen A [Thu, 30 Dec 2021 08:28:58 +0000 (13:58 +0530)]
mgr/dashboard: stabilizing the cephadm dashboard e2e

Reordering the tests and adding some more tests to verify the cluster is
healthy before proceeding to do some complex tasks like maintenance and
drain host

Fixes: https://tracker.ceph.com/issues/53742
Signed-off-by: Nizamudeen A <nia@redhat.com>
3 years agomgr/dashboard: cheroot now ships type hints 44453/head
Sebastian Wagner [Tue, 4 Jan 2022 13:56:12 +0000 (14:56 +0100)]
mgr/dashboard: cheroot now ships type hints

Now we need to prevent mypy frm complainign about a duplicated import.

Signed-off-by: Sebastian Wagner <sewagner@redhat.com>
3 years agoMerge pull request #44067 from MrFreezeex/dirfrags-test
Venky Shankar [Tue, 4 Jan 2022 09:45:41 +0000 (15:15 +0530)]
Merge pull request #44067 from MrFreezeex/dirfrags-test

qa/suites/fs: add prefetch_dirfrags false to thrasher suite

Reviewed-by: Venky Shankar <vshankar@redhat.com>
3 years agoMerge pull request #44255 from lxbsz/syncfs-44916
Venky Shankar [Tue, 4 Jan 2022 09:44:59 +0000 (15:14 +0530)]
Merge pull request #44255 from lxbsz/syncfs-44916

client: fix sync fs to force flush mdlog for all sessions

Reviewed-by: Venky Shankar <vshankar@redhat.com>
3 years agocephadm/box: remove unnecessary bash files 43763/head
Pere Diaz Bou [Tue, 4 Jan 2022 09:10:15 +0000 (10:10 +0100)]
cephadm/box: remove unnecessary bash files

Signed-off-by: Pere Diaz Bou <pdiazbou@redhat.com>
3 years agoMerge pull request #43618 from kotreshhr/recover-symlink
Venky Shankar [Tue, 4 Jan 2022 09:09:22 +0000 (14:39 +0530)]
Merge pull request #43618 from kotreshhr/recover-symlink

mds: Store symlink target in first data object

Reviewed-by: Venky Shankar <vshankar@redhat.com>
3 years agoMerge pull request #44246 from yongseokoh/fix-prefetch-dirfrags
Venky Shankar [Tue, 4 Jan 2022 09:07:59 +0000 (14:37 +0530)]
Merge pull request #44246 from yongseokoh/fix-prefetch-dirfrags

mds: split _prefetch_dirfrags to avoid heartbeat timeout during up:rejoin

Reviewed-by: Venky Shankar <vshankar@redhat.com>
3 years agoMerge pull request #43236 from mchangir/mgr/snap_schedule-fix-db-connection-concurren...
Venky Shankar [Tue, 4 Jan 2022 09:06:07 +0000 (14:36 +0530)]
Merge pull request #43236 from mchangir/mgr/snap_schedule-fix-db-connection-concurrent-usage

mgr/snap_schedule: fix db connection concurrent usage

Reviewed-by: Venky Shankar <vshankar@redhat.com>
3 years agomgr/dashboard: bump simplebar-angular 44442/head
dependabot[bot] [Mon, 3 Jan 2022 16:50:17 +0000 (16:50 +0000)]
mgr/dashboard: bump simplebar-angular

Bumps simplebar-angular from 2.3.0 to 2.3.6.

---
updated-dependencies:
- dependency-name: simplebar-angular
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
3 years agoMerge pull request #44407 from ceph/dependabot/npm_and_yarn/src/pybind/mgr/dashboard...
Alfonso Martínez [Mon, 3 Jan 2022 16:47:13 +0000 (17:47 +0100)]
Merge pull request #44407 from ceph/dependabot/npm_and_yarn/src/pybind/mgr/dashboard/frontend/swagger-ui-4.1.3

build(deps): bump swagger-ui from 4.1.2 to 4.1.3 in /src/pybind/mgr/dashboard/frontend

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
3 years agomgr/dashboard: add test coverage for API docs (SwaggerUI) 44449/head
Alfonso Martínez [Mon, 3 Jan 2022 16:43:07 +0000 (17:43 +0100)]
mgr/dashboard: add test coverage for API docs (SwaggerUI)

Fixes: https://tracker.ceph.com/issues/53756
Signed-off-by: Alfonso Martínez <almartin@redhat.com>
3 years agoMerge pull request #44354 from tchaikov/cmake-cleanup
Kefu Chai [Mon, 3 Jan 2022 15:31:24 +0000 (23:31 +0800)]
Merge pull request #44354 from tchaikov/cmake-cleanup

cmake: use new CMP0127 policy

Reviewed-by: Casey Bodley <cbodley@redhat.com>
3 years agoMerge pull request #43337 from ljflores/wip-bluestore-zero-detection
Laura Flores [Mon, 3 Jan 2022 15:16:32 +0000 (09:16 -0600)]
Merge pull request #43337 from ljflores/wip-bluestore-zero-detection

os/bluestore: detect unnecessary zeroes in bufferlist when data is written

3 years agoMerge pull request #44187 from rhcs-dashboard/wip-configure_dependabot-master
Alfonso Martínez [Mon, 3 Jan 2022 13:17:27 +0000 (14:17 +0100)]
Merge pull request #44187 from rhcs-dashboard/wip-configure_dependabot-master

mgr/dashboard: configure dependabot

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
3 years agoMerge pull request #44130 from LittleFox94/wip-doc-rbd-default-object-size
Ilya Dryomov [Mon, 3 Jan 2022 09:06:06 +0000 (10:06 +0100)]
Merge pull request #44130 from LittleFox94/wip-doc-rbd-default-object-size

doc: how to change default rbd object size

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
3 years agomds: ignore unknown client op when tracking op latency 44291/head
Venky Shankar [Mon, 13 Dec 2021 06:15:19 +0000 (01:15 -0500)]
mds: ignore unknown client op when tracking op latency

Server::handle_client_request() ignores unknown client operation
by returning -ENOTSUPP, however, Server::perf_gather_op_latency()
aborts on unknown client op, thereby causing -ENOTSUPP to never
reach the client. ceph_abort() seems unnecessary here.

Note, we could have invoked Server::perf_gather_op_latency()
when the return value to client is not -ENOTSUPP, however,
a valid client operation *might* just return -ENOTSUPP in
some cases.

@mchangir ran into this with his getvxattr op changes (PR #42001).

Signed-off-by: Venky Shankar <vshankar@redhat.com>
3 years agomgr/dashboard: fix orchestrator/02-hosts-inventory.e2e failed. 44388/head
Nizamudeen A [Thu, 23 Dec 2021 10:53:31 +0000 (16:23 +0530)]
mgr/dashboard: fix orchestrator/02-hosts-inventory.e2e failed.

I removed the `02-hosts-inventory.e2e` file because it is a duplicate
test of one of the test in the `01-hosts.e2e` file and fixed the error
from that file.

Also, in the inventory Identify test, we test for an element to be not
visible. According to the latest cypress docs, this should be not.exist
instead of not.visible since the cd-modal will not even be present in
the DOM

Fixes: https://tracker.ceph.com/issues/53499
Signed-off-by: Nizamudeen A <nia@redhat.com>
3 years agocrimson/os/seastore: differentiate loggers in seastore 44429/head
Yingxin Cheng [Fri, 31 Dec 2021 03:48:07 +0000 (11:48 +0800)]
crimson/os/seastore: differentiate loggers in seastore

To enable fine-grain logger control for easier bug triage.

See common/subsys.h for the new classifications.

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
3 years agocrimson/os/seastore: clean up logging
Yingxin Cheng [Fri, 31 Dec 2021 03:45:51 +0000 (11:45 +0800)]
crimson/os/seastore: clean up logging

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
3 years agocrimson/os/seastore/cache: clean up LRU 44420/head
Xinyu Huang [Thu, 30 Dec 2021 08:43:08 +0000 (16:43 +0800)]
crimson/os/seastore/cache: clean up LRU

Signed-off-by: Xinyu Huang <xinyu.huang@intel.com>
3 years agoMerge pull request #44398 from rhcs-dashboard/e2e-script-improvement
Nizamudeen A [Thu, 30 Dec 2021 05:55:58 +0000 (11:25 +0530)]
Merge pull request #44398 from rhcs-dashboard/e2e-script-improvement

mgr/dashboard: dashboard cephadm e2e improvement

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
3 years agomgr/dashboard: dashboard cephadm e2e improvement 44398/head
Nizamudeen A [Fri, 24 Dec 2021 05:39:37 +0000 (11:09 +0530)]
mgr/dashboard: dashboard cephadm e2e improvement

Fixes: https://tracker.ceph.com/issues/53742
Signed-off-by: Nizamudeen A <nia@redhat.com>
3 years agoMerge pull request #44403 from cyx1231st/wip-fix-crimson-args
Yingxin [Wed, 29 Dec 2021 05:01:50 +0000 (13:01 +0800)]
Merge pull request #44403 from cyx1231st/wip-fix-crimson-args

crimson/osd: fix and improve args processing

Reviewed-by: Kefu Chai <tchaikov@gmail.com>
3 years agocrimson/os/seastore/cache: trim after adding to lru
Xinyu Huang [Mon, 27 Dec 2021 02:53:59 +0000 (10:53 +0800)]
crimson/os/seastore/cache: trim after adding to lru

Signed-off-by: Xinyu Huang <xinyu.huang@intel.com>
3 years agocrimson/os/seastore/cache: add lru
Samuel Just [Mon, 1 Nov 2021 20:48:28 +0000 (13:48 -0700)]
crimson/os/seastore/cache: add lru

Signed-off-by: Samuel Just <sjust@redhat.com>
3 years agoMerge pull request #44396 from cyx1231st/wip-seastore-fix-seastar-runner
Kefu Chai [Tue, 28 Dec 2021 16:31:03 +0000 (00:31 +0800)]
Merge pull request #44396 from cyx1231st/wip-seastore-fix-seastar-runner

crimson/test: fix SeastarRunner when app is not started

Reviewed-by: Xuehan Xu <xuxuehan@360.cn>
Reviewed-by: Kefu Chai <tchaikov@gmail.com>
3 years agoMerge pull request #44274 from fengchunsong/dpdk-dfx
Kefu Chai [Tue, 28 Dec 2021 11:55:41 +0000 (19:55 +0800)]
Merge pull request #44274 from fengchunsong/dpdk-dfx

msg/async/dpdk: add commands to obtain the NIC status and statistics

Reviewed-by: Kefu Chai <tchaikov@gmail.com>
3 years agomsg/async/dpdk:add commands to obtain the NIC status and statistics 44274/head
Chunsong Feng [Fri, 10 Dec 2021 08:59:41 +0000 (08:59 +0000)]
msg/async/dpdk:add commands to obtain the NIC status and statistics

Commands are added to obtain the network adapter status and statistics
for debugging network adapter packet loss and mbuf insufficiency issues.

Signed-off-by: Chunsong Feng <fengchunsong@huawei.com>
Reviewed-by: luo rixin <luorixin@huawei.com>
Reviewed-by: Han Fengzhe <hanfengzhe@hisilicon.com>
3 years agoMerge pull request #44276 from fengchunsong/dpdk-affinity
fengchunsong [Mon, 27 Dec 2021 23:53:19 +0000 (07:53 +0800)]
Merge pull request #44276 from fengchunsong/dpdk-affinity

common/numa: Skip the DPDK thread when setting NUMA affinity

3 years agodoc: add docs for rbd_default_order 44130/head
Mara Sophie Grosch [Mon, 29 Nov 2021 14:00:23 +0000 (15:00 +0100)]
doc: add docs for rbd_default_order

Adds documentation how to change default rbd object size. With the
previous option `--order` it was easy to guess the config name for the
default value, with the current option name `--object-size` thats hard
to guess.

Also extends the documentation for rbd_default_order to include
* how object-size is derived from the configured value
* allowed range of the value

In the first version of this commit I also added min and max for this
parameter (12/25, matching the object size range in `man 8
rbd`/Striping/object-size), but this made some tests fail, since some
seem to set values outside this range (and probably are fine since
included for some time already). To have this a doc-change only, I
removed the range.

Signed-off-by: Mara Sophie Grosch <littlefox@lf-net.org>
3 years agoMerge PR #44342 into master
Patrick Donnelly [Mon, 27 Dec 2021 17:55:30 +0000 (12:55 -0500)]
Merge PR #44342 into master

* refs/pull/44342/head:
mds: trigger stray reintegration when loading dentry
qa: test that scrub causes reintegration

Reviewed-by: Xiubo Li <xiubli@redhat.com>
3 years agocommon/numa: Skip the DPDK thread when setting NUMA affinity 44276/head
Chunsong Feng [Mon, 27 Dec 2021 13:03:21 +0000 (13:03 +0000)]
common/numa: Skip the DPDK thread when setting NUMA affinity

The CPU affinity of the DPDK thread has been set during DPDK initialization.
Do not modify the DPDK affinity when setting NUMA affinity.

Signed-off-by: Chunsong Feng <fengchunsong@huawei.com>
Reviewed-by: luo rixin <luorixin@huawei.com>
Reviewed-by: Han Fengzhe <hanfengzhe@hisilicon.com>
3 years agomsg/async: refactory rename_thread for DPDKStack
Chunsong Feng [Fri, 10 Dec 2021 10:18:36 +0000 (10:18 +0000)]
msg/async: refactory rename_thread for DPDKStack

The thread_name of the DPDK thread has been set during DPDK initialization.

Signed-off-by: Chunsong Feng <fengchunsong@huawei.com>
Reviewed-by: luo rixin <luorixin@huawei.com>
Reviewed-by: Han Fengzhe <hanfengzhe@hisilicon.com>
3 years agoMerge pull request #44243 from ideepika/wip-deepika-iscsi
Ilya Dryomov [Mon, 27 Dec 2021 11:29:07 +0000 (12:29 +0100)]
Merge pull request #44243 from ideepika/wip-deepika-iscsi

qa/rbd: update the cephadm required distro

Reviewed-by: Melissa Li <melissali@redhat.com>
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
3 years agocrimson/osd: print message when customize parameters 44403/head
Yingxin Cheng [Fri, 24 Dec 2021 08:16:04 +0000 (16:16 +0800)]
crimson/osd: print message when customize parameters

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
3 years agocrimson/osd: allow seastar application to print its helps
Yingxin Cheng [Fri, 24 Dec 2021 08:14:29 +0000 (16:14 +0800)]
crimson/osd: allow seastar application to print its helps

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
3 years agocrimson/osd: --help-seastar does no longer belong to unknown_args
Yingxin Cheng [Fri, 24 Dec 2021 08:12:13 +0000 (16:12 +0800)]
crimson/osd: --help-seastar does no longer belong to unknown_args

Now that app_template handles --help-seastar, and prints out all
app-level usages if --help is included in command line options. There is
no need to add a dedicated --help-seastar by ourselves and translate it
to --help.

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
3 years agoMerge pull request #44411 from tchaikov/wip-crimson-doc
Kefu Chai [Mon, 27 Dec 2021 09:14:58 +0000 (17:14 +0800)]
Merge pull request #44411 from tchaikov/wip-crimson-doc

doc: remove references to SEASTAR_DEFAULT_ALLOCATOR

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
3 years agoMerge pull request #44333 from rzarzynski/wip-crimson-fix-recovery-discarding
Kefu Chai [Sun, 26 Dec 2021 13:46:41 +0000 (21:46 +0800)]
Merge pull request #44333 from rzarzynski/wip-crimson-fix-recovery-discarding

crimson/osd: implement op discarding for pglog-based recovery.

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Chunmei Liu <chunmei.liu@intel.com>
3 years agoMerge pull request #44275 from fengchunsong/dpdk-nic
Kefu Chai [Sun, 26 Dec 2021 12:41:33 +0000 (20:41 +0800)]
Merge pull request #44275 from fengchunsong/dpdk-nic

msg/async/dpdk: add NIC whitelist configuration

Reviewed-by: Kefu Chai <tchaikov@gmail.com>
3 years agoMerge pull request #44285 from fengchunsong/dpdk-rte-init
Kefu Chai [Sun, 26 Dec 2021 12:04:40 +0000 (20:04 +0800)]
Merge pull request #44285 from fengchunsong/dpdk-rte-init

msg/async/dpdk: handle DPDK initialization failure properly

Reviewed-by: Kefu Chai <tchaikov@gmail.com>
3 years agomsg/async/dpdk:add the handling of DPDK initialization failure 44285/head
Chunsong Feng [Sat, 11 Dec 2021 01:11:18 +0000 (01:11 +0000)]
msg/async/dpdk:add the handling of DPDK initialization failure

If rte_eal_init returns with failure,the waiting msgr-worker thread is
woken up for exception handling.

Signed-off-by: Chunsong Feng <fengchunsong@huawei.com>
Reviewed-by: luo rixin <luorixin@huawei.com>
Reviewed-by: Han Fengzhe <hanfengzhe@hisilicon.com>
3 years agodoc: remove references to SEASTAR_DEFAULT_ALLOCATOR 44411/head
Kefu Chai [Sun, 26 Dec 2021 05:11:06 +0000 (13:11 +0800)]
doc: remove references to SEASTAR_DEFAULT_ALLOCATOR

now that https://github.com/scylladb/seastar/commit/067681b70172ab4a6676431b623e8bd0caab6dc8
has been merged upstream, and our src/seastar submodule includes
this commit. there is no need to worry that the seastar's lockless
allocator does not work with seastar::alien anymore.

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
3 years agocrimson/test: fix SeastarRunner when app is not started 44396/head
Yingxin Cheng [Fri, 24 Dec 2021 03:05:30 +0000 (11:05 +0800)]
crimson/test: fix SeastarRunner when app is not started

Support the case when the SeastarRunner isn't able to start the app,
for example, when start with --help.

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
3 years agomsg/async/dpdk: add NIC whitelist configuration 44275/head
Chunsong Feng [Fri, 10 Dec 2021 02:27:58 +0000 (02:27 +0000)]
msg/async/dpdk: add NIC whitelist configuration

Each DPDK process uses some exclusive network adapters.The network adapters to
be used are specified in the whitelist to prevent data sharing between multiple
DPDK process.The following is an example:
1)Configure a single NIC.
-a 0000:7d:010 or --allow=0000:7d:010
2)Configure the Bond Network Adapter
ms_dpdk_port_options=--allow=0000:7d:01.0 --allow=0000:7d:02.6
--vdev=net_bonding0,mode=2,slave=0000:7d:01.0,slave=0000:7d:02.6

Signed-off-by: Chunsong Feng <fengchunsong@huawei.com>
Reviewed-by: luo rixin <luorixin@huawei.com>
Reviewed-by: Han Fengzhe <hanfengzhe@hisilicon.com>
3 years agoMerge pull request #44404 from inspur-wyq/wip-doc-mgr-zabbix
Kefu Chai [Sat, 25 Dec 2021 08:44:07 +0000 (16:44 +0800)]
Merge pull request #44404 from inspur-wyq/wip-doc-mgr-zabbix

doc/mgr/zabbix.rst: fix typos

Reviewed-by: Kefu Chai <tchaikov@gmail.com>
3 years agobuild(deps): bump swagger-ui in /src/pybind/mgr/dashboard/frontend 44407/head
dependabot[bot] [Fri, 24 Dec 2021 15:39:49 +0000 (15:39 +0000)]
build(deps): bump swagger-ui in /src/pybind/mgr/dashboard/frontend

Bumps [swagger-ui](https://github.com/swagger-api/swagger-ui) from 4.1.2 to 4.1.3.
- [Release notes](https://github.com/swagger-api/swagger-ui/releases)
- [Commits](https://github.com/swagger-api/swagger-ui/compare/v4.1.2...v4.1.3)

---
updated-dependencies:
- dependency-name: swagger-ui
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
3 years agodoc/mgr/zabbix.rst: fix typos 44404/head
wangyunqing [Fri, 24 Dec 2021 09:10:11 +0000 (17:10 +0800)]
doc/mgr/zabbix.rst: fix typos

Signed-off-by: wangyunqing <wangyunqing@inspur.com>
3 years agoMerge pull request #44378 from cyx1231st/wip-seastore-onode-cleanup
Yingxin [Fri, 24 Dec 2021 03:41:02 +0000 (11:41 +0800)]
Merge pull request #44378 from cyx1231st/wip-seastore-onode-cleanup

crimson/os/seastore: fix potential leak for onodes to live across transactions

Reviewed-by: Xuehan Xu <xxhdx1985126@gmail.com>
Reviewed-by: Chunmei Liu <chunmei.liu@intel.com>
3 years agotest/objectstore: write unit tests for zero block detection 43337/head
Laura Flores [Fri, 24 Dec 2021 01:19:43 +0000 (01:19 +0000)]
test/objectstore: write unit tests for zero block detection

Unit tests include ZeroBlockDetectionSmall{Append/Overwrite} and ZeroBlockDetectionBig{Append/Overwrite}.

Signed-off-by: Laura Flores <lflores@redhat.com>
3 years agoos/bluestore: detect unnecessary zeros in _do_write_big()
Laura Flores [Fri, 24 Dec 2021 01:18:13 +0000 (01:18 +0000)]
os/bluestore: detect unnecessary zeros in _do_write_big()

Bluestore's `_do_write()` method handles writing data from bufferlists. Currently, it writes data from bufferlists without checking for unnecessary zeros. The lack zero detection may negatively impact performance.

In _do_write_big, we also check if a bufferlist is made up of zeros and avoid writing it if so.
Two new counters, `l_bluestore_write_big_skipped_blobs` and `l_bluestore_write_big_skipped_bytes`, have been introduced to help us count how many zero blocks and bytes from _do_write_big() have been skipped.

Signed-off-by: Laura Flores <lflores@redhat.com>
3 years agoos/bluestore: detect unnecessary zeros in _do_write_small()
Laura Flores [Fri, 24 Dec 2021 01:15:33 +0000 (01:15 +0000)]
os/bluestore: detect unnecessary zeros in _do_write_small()

Bluestore's `_do_write()` method handles writing data from bufferlists. Currently, it writes data from bufferlists without checking for unnecessary zeros. The lack zero detection may negatively impact performance.

In _do_write_small(), we check if a bufferlist is made up of zeros and avoid writing it if so.
Two new counters, `l_bluestore_write_small_skipped` and l_bluestore_write_small_skipped_bytes`, have been introduced to help us count how many zero blocks and bytes from _do_write_small() have been skipped.

Signed-off-by: Laura Flores <lflores@redhat.com>
3 years agoMerge pull request #44311 from ifed01/wip-ifed-cleanup-onode-pin
Yuri Weinstein [Fri, 24 Dec 2021 00:44:43 +0000 (16:44 -0800)]
Merge pull request #44311 from ifed01/wip-ifed-cleanup-onode-pin

os/bluestore: get rid of fake onode nref increment for pinned entry

Reviewed-by: Adam Kupczyk <akupczyk@redhat.com>
3 years agoMerge pull request #44303 from 5cs/fix-new-state-weight
Yuri Weinstein [Fri, 24 Dec 2021 00:44:06 +0000 (16:44 -0800)]
Merge pull request #44303 from 5cs/fix-new-state-weight

mon/OSDMonitor: fix incorrect op between osd state and weight

Reviewed-by: xie xingguo <xie.xingguo@zte.com.cn>
3 years agoMerge pull request #44391 from anthonyeleven/anthonyeleven/correct-quay-url
Neha Ojha [Thu, 23 Dec 2021 23:34:22 +0000 (15:34 -0800)]
Merge pull request #44391 from anthonyeleven/anthonyeleven/correct-quay-url

doc/install: Update quay.io URL for ceph-ci builds

Reviewed-by: Neha Ojha <nojha@redhat.com>
3 years agodoc/install: Update quay.io URL for ceph-ci builds 44391/head
Anthony D'Atri [Thu, 23 Dec 2021 20:11:25 +0000 (12:11 -0800)]
doc/install: Update quay.io URL for ceph-ci builds

Signed-off-by: Anthony D'Atri <anthony.datri@gmail.com>
3 years agoMerge pull request #44352 from SMIL-Infra/journald
Yuri Weinstein [Thu, 23 Dec 2021 22:02:39 +0000 (14:02 -0800)]
Merge pull request #44352 from SMIL-Infra/journald

common: fix fmt::format_to deprecated warning

Reviewed-by: Kefu Chai <kchai@redhat.com>
3 years agoMerge pull request #42896 from ifed01/wip-ifed-bluefs-improve-log
Yuri Weinstein [Thu, 23 Dec 2021 22:02:16 +0000 (14:02 -0800)]
Merge pull request #42896 from ifed01/wip-ifed-bluefs-improve-log

os/bluestore: dump alloc unit size on bluefs allocation failure.

Reviewed-by: Adam Kupczyk <akupczyk@redhat.com>