]>
git.apps.os.sepia.ceph.com Git - ceph.git/log
Adam King [Mon, 12 Feb 2024 23:34:48 +0000 (18:34 -0500)]
Merge pull request #53527 from rhcs-dashboard/add-rgw-perf-counter-cache
cephadm/rgw: make rgw perf counters cache and it's size configurable
Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Ali Maredia <amaredia@redhat.com>
Adam King [Mon, 12 Feb 2024 23:21:25 +0000 (18:21 -0500)]
Merge pull request #55355 from adk3798/cephadm-nvmeof-version-bug
cephadm: fix get_version for nvmeof
Reviewed-by: John Mulligan <jmulligan@redhat.com>
Radoslaw Zarzynski [Mon, 12 Feb 2024 19:22:47 +0000 (20:22 +0100)]
Merge pull request #50422 from rzarzynski/wip-bug-58915
osd: don't send stale hb msgr's addresses in MOSDBoot
Reviewed-by: Laura Flores <lflores@redhat.com>
Ali Maredia [Mon, 12 Feb 2024 18:35:09 +0000 (13:35 -0500)]
Merge pull request #55156 from alimaredia/wip-rgw-add-cap-user-without-keys
rgw: add new cap user-info-without-keys
Reviewed-by: Casey Bodley <cbodley@redhat.com>
Casey Bodley [Mon, 12 Feb 2024 17:05:33 +0000 (17:05 +0000)]
Merge pull request #55487 from cbodley/wip-qa-rgw-hadoop-distro
qa/rgw: hadoop-s3a uses supported-random-distro$
Reviewed-by: Ali Maredia <amaredia@redhat.com>
Casey Bodley [Mon, 12 Feb 2024 17:05:02 +0000 (17:05 +0000)]
Merge pull request #55360 from shreyanshjain7174/fix_2252048
RGW: Getting an RGW service Segfault when assigning an attribute to an IAM role.
Reviewed-by: Casey Bodley <cbodley@redhat.com>
Casey Bodley [Mon, 12 Feb 2024 17:04:33 +0000 (17:04 +0000)]
Merge pull request #55486 from jzhu116-bloomberg/wip-64340
rgw: do not copy olh attributes in versioning suspended bucket
Reviewed-by: Casey Bodley <cbodley@redhat.com>
Casey Bodley [Mon, 12 Feb 2024 17:03:49 +0000 (17:03 +0000)]
Merge pull request #55458 from tobias-urdin/cors-signature
rgw/auth: ignoring signatures for HTTP OPTIONS calls
Reviewed-by: Casey Bodley <cbodley@redhat.com>
Yuri Weinstein [Mon, 12 Feb 2024 16:05:33 +0000 (08:05 -0800)]
Merge pull request #55347 from lightmelodies/mon
mon: fix health store size growing infinitely
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Reviewed-by: Matan Breizman <Matan.Brz@gmail.com>
Yuri Weinstein [Mon, 12 Feb 2024 16:04:54 +0000 (08:04 -0800)]
Merge pull request #55251 from rzarzynski/wip-bug-64104
tools/cot: respect generic, Ceph-wide argvs
Reviewed-by: Nitzan Mordechai <nmordech@redhat.com>
Aashish Sharma [Mon, 12 Feb 2024 07:16:48 +0000 (12:46 +0530)]
Merge pull request #55467 from rhcs-dashboard/rgw-s3-analytics-grafana-dashboard
mgr/dashboard: Add RGW per user/bucket panels in grafana
Reviewed-by: Nizamudeen A <nia@redhat.com>
Nizamudeen A [Mon, 12 Feb 2024 06:28:03 +0000 (11:58 +0530)]
Merge pull request #55494 from ivoalmeida/snapshot-schedule-delete-activate
mgr/dashboard: added delete and activation actions
Reviewed-by: afreen23 <NOT@FOUND>
Reviewed-by: Ankush Behl <cloudbehl@gmail.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Kefu Chai [Mon, 12 Feb 2024 01:23:21 +0000 (09:23 +0800)]
Merge pull request #55529 from tchaikov/cmake-cap
cmake: find_package(cap) before linking against it
Reviewed-by: Casey Bodley <cbodley@redhat.com>
Ivo Almeida [Wed, 7 Feb 2024 14:03:45 +0000 (14:03 +0000)]
mgr/dashboard: added delete and activation actions
Fixes: https://tracker.ceph.com/issues/64355
Signed-off-by: Ivo Almeida <ialmeida@redhat.com>
Kefu Chai [Sun, 11 Feb 2024 16:39:04 +0000 (00:39 +0800)]
Merge pull request #55528 from tchaikov/cmake-boost-debug
cmake: build boost debug variant when CMAKE_BUILD_TYPE is Debug
Reviewed-by: Casey Bodley <cbodley@redhat.com>
Casey Bodley [Sun, 11 Feb 2024 16:15:17 +0000 (16:15 +0000)]
Merge pull request #55199 from igomon-bloomberg/wip-publish-commit-async
rgw/s3-notifications: async commit to persistent notification queue
Reviewed-by: Yuval Lifshitz <ylifshit@redhat.com>
Casey Bodley [Sun, 11 Feb 2024 16:14:42 +0000 (16:14 +0000)]
Merge pull request #55371 from pritha-srivastava/wip-rgw-correct-err-msg
rgw/auth: correcting the error message to indicate
Reviewed-by: Casey Bodley <cbodley@redhat.com>
Casey Bodley [Sun, 11 Feb 2024 16:12:48 +0000 (16:12 +0000)]
Merge pull request #55250 from cbodley/wip-64084
rgw/auth/s3: validate x-amz-content-sha256 for empty payloads
Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
Ronen Friedman [Sun, 11 Feb 2024 11:25:47 +0000 (13:25 +0200)]
Merge pull request #55478 from ronen-fr/wip-rf-update-times
osd: restoring timely collection of PG stats
Reviewed-by: Matan Breizman <mbreizma@redhat.com>
Kefu Chai [Sun, 11 Feb 2024 08:53:26 +0000 (16:53 +0800)]
cmake: find_package(cap) before linking against it
before this change, we link against libcap without finding it. this
works fine as long as libcap-devel or libcap-dev is installed in the
system. but if it is not, the source would fail to build due to missing
`sys/capability.h`. this is not a great developer experience.
in this change, a `Findcap.cmake` is added to find the capability
library. which would fail the build at the configure phase.
Signed-off-by: Kefu Chai <tchaikov@gmail.com>
Kefu Chai [Sun, 11 Feb 2024 07:42:14 +0000 (15:42 +0800)]
cmake: build boost debug variant when CMAKE_BUILD_TYPE is Debug
boost has some different predefined build variants. they are quite
like CMake's CMAKE_BUILD_TYPE. in which, "debug" enables some
features related features. so it would be nice if we can have it
enabled for the Debug build, if the boost is built from source.
see also
https://www.boost.org/build/doc/html/bbv2/overview/builtins/features.html
before this change, we always build the "release" variant. in this
change, "debug" variant is built if Ceph's is built with
CMAKE_BUILD_TYPE=Debug. please note, this change does not change
the way how boost is built when packaging Ceph, as our debian/rpm
receipts do not define CMAKE_BUILD_TYPE and respect the distros'
settings, in that case, the "release" variant is still built.
Signed-off-by: Kefu Chai <tchaikov@gmail.com>
zdover23 [Sat, 10 Feb 2024 14:47:59 +0000 (00:47 +1000)]
Merge pull request #55525 from zdover23/wip-doc-2024-02-11-radosgw-55524-rollback
doc/radosgw: undo 55524
Reviewed-by: Casey Bodley <cbodley@redhat.com>
Zac Dover [Sat, 10 Feb 2024 14:36:29 +0000 (00:36 +1000)]
doc/radosgw: undo 55524
Roll back the docs changes made in
https://github.com/ceph/ceph/pull/55524, in accordance with Casey
Bodley's instructions to me here:
https://github.com/ceph/ceph/pull/55524#issuecomment-
1937020543 .
Signed-off-by: Zac Dover <zac.dover@proton.me>
Anthony D'Atri [Sat, 10 Feb 2024 11:30:41 +0000 (06:30 -0500)]
Merge pull request #55524 from zdover23/wip-doc-2024-02-10-radosgw-lua-scripting-options
doc/radosgw: remove invalid LUA context options
Laura Flores [Sat, 10 Feb 2024 05:36:21 +0000 (23:36 -0600)]
Merge pull request #55507 from ljflores/wip-tracker-64343
Zac Dover [Sat, 10 Feb 2024 03:14:59 +0000 (13:14 +1000)]
doc/radosgw: remove invalid LUA context options
Remove "background", "getdata", and "putdata" from the list of LUA
context options. Passing these options throws the following error:
"ERROR: invalid script context: background. must be one of: preRequest,
postRequest".
Fixes: https://tracker.ceph.com/issues/64327
Signed-off-by: Zac Dover <zac.dover@proton.me>
Laura Flores [Thu, 8 Feb 2024 22:14:03 +0000 (16:14 -0600)]
qa/suites/orch: whitelist warnings that are expected in test environments
Fixes: https://tracker.ceph.com/issues/64343
Signed-off-by: Laura Flores <lflores@ibm.com>
Aashish Sharma [Tue, 6 Feb 2024 13:08:31 +0000 (18:38 +0530)]
mgr/dashboard: Add RGW per user/bucket panels in grafana
Fixes: https://tracker.ceph.com/issues/64359
Signed-off-by: Aashish Sharma <aasharma@redhat.com>
Kefu Chai [Fri, 9 Feb 2024 15:11:18 +0000 (23:11 +0800)]
Merge pull request #53521 from xxhdx1985126/wip-62857
crimson/osd/replicated_backend: don't put pg's metadata updates in repops
Reviewed-by: Samuel Just <sjust@redhat.com>
Adam Kupczyk [Fri, 9 Feb 2024 15:07:17 +0000 (16:07 +0100)]
Merge pull request #54650 from pereman2/buffer_map-noptr
os/bluestore: use buffer values instead of pointers in buffer_map
Ronen Friedman [Wed, 7 Feb 2024 13:40:32 +0000 (07:40 -0600)]
osd: no 'legacy' form for two configuration options
also - fixing review comments not addressed in the original PR.
Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
Ronen Friedman [Wed, 7 Feb 2024 13:25:18 +0000 (07:25 -0600)]
osd: restoring timely collection of PG stats
500 seconds is way too long, e.g. when compared to the 5s
default configuration option for the manager collection of the OSD data.
Fixes tracker issue 53342 note 5 (a specific scenario leading
to 'not all pgs scrubbed')
Fixes: https://tracker.ceph.com/issues/53342 - partial fix
Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
Nizamudeen A [Fri, 9 Feb 2024 07:05:47 +0000 (12:35 +0530)]
Merge pull request #55462 from afreen23/fix-64270
mgr/dashboard: fix error while accessing roles tab when policy attached
Reviewed-by: Nizamudeen A <nia@redhat.com>
Rishabh Dave [Fri, 9 Feb 2024 06:54:00 +0000 (12:24 +0530)]
Merge pull request #55365 from kotreshhr/ceph-mds-replica-debug-logs
mds: Add debug messages in replica handling
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Dhairya Parmar <dparmar@redhat.com>
Reviewed-by: Rishabh Dave <ridave@redhat.com>
Reviewed-by: Jos Collin <jcollin@redhat.com>
Rishabh Dave [Fri, 9 Feb 2024 06:50:13 +0000 (12:20 +0530)]
Merge pull request #55411 from rishabh-d-dave/qa-cephfs-caps_helper
qa/cephfs: declare f-string to get values to substitute variable names
Reviewed-by: Jos Collin <jcollin@redhat.com>
Venky Shankar [Fri, 9 Feb 2024 04:33:08 +0000 (10:03 +0530)]
Merge PR #55493 into main
* refs/pull/55493/head:
client: remove unused/undefined fake_write_size()
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Jos Collin <jcollin@redhat.com>
Casey Bodley [Thu, 8 Feb 2024 22:14:54 +0000 (22:14 +0000)]
Merge pull request #55499 from cbodley/wip-squid-deprecate-blkin
doc: deprecate blkin tracing
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Radoslaw Zarzynski [Thu, 8 Feb 2024 21:56:55 +0000 (22:56 +0100)]
Merge pull request #55332 from athanatos/sjust/wip-crush-multi-choose
crush: add multistep retry rules
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Reviewed-by: Greg Farnum <gfarnum@redhat.com>
Casey Bodley [Thu, 8 Feb 2024 21:13:52 +0000 (21:13 +0000)]
Merge pull request #54624 from cbodley/wip-cmake-qat
cmake: add ExternalProjects to enable QAT by default
Reviewed-by: Kefu Chai <tchaikov@gmail.com>
zdover23 [Thu, 8 Feb 2024 19:38:48 +0000 (05:38 +1000)]
Merge pull request #55490 from eroldan/patch-2
doc/start: fix typo in hw-recs
Reviewed-by: Zac Dover <zac.dover@proton.me>
Eduardo Roldan [Thu, 8 Feb 2024 06:40:21 +0000 (03:40 -0300)]
doc:start.rst fix typo in hw-recs
s/power less/power loss/
Signed-off-by: Eduardo Roldan <trazor@gmail.com>
Casey Bodley [Thu, 8 Feb 2024 15:56:03 +0000 (10:56 -0500)]
doc: deprecate blkin tracing
Signed-off-by: Casey Bodley <cbodley@redhat.com>
Kefu Chai [Thu, 8 Feb 2024 15:14:09 +0000 (23:14 +0800)]
Merge pull request #55267 from athos-ribeiro/cmake-empty-submodules
cmake: quote variable to allow empty values
Reviewed-by: Kefu Chai <tchaikov@gmail.com>
Guillaume Abrioux [Thu, 8 Feb 2024 14:26:38 +0000 (15:26 +0100)]
Merge pull request #55398 from ifed01/wip-ifed-fix-ceph-vol-migrate-wal
ceph-volume: Fix migration from WAL to data with no DB
Dhairya Parmar [Thu, 8 Feb 2024 12:28:42 +0000 (17:58 +0530)]
client: remove unused/undefined fake_write_size()
there are no usages of this function in entire codebase
Signed-off-by: Dhairya Parmar <dparmar@redhat.com>
Afreen [Tue, 6 Feb 2024 09:43:58 +0000 (15:13 +0530)]
mgr/dashboard: fix error while accessing roles tab when policy attached
Fixes https://tracker.ceph.com/issues/64270
Issue:
======
Accessing Object->Users-Roles tab causing 500 internal servor error.
This is due to the "PermissionPolicies" which are attached to role and
backend was not handling this field for rgw roles.
Fix:
====
Added "PermissionPolicies" as the valid field in backend and updated
frontend to render the attached policy in formatted JSON
Signed-off-by: Afreen <afreen23.git@gmail.com>
Ivo Almeida [Thu, 8 Feb 2024 08:51:46 +0000 (05:51 -0300)]
Merge pull request #55416 from ivoalmeida/snapshot-schedule-edit
mgr/dashboard: added edit functionality
Reviewed-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
Reviewed-by: afreen23 <NOT@FOUND>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Venky Shankar [Thu, 8 Feb 2024 05:31:04 +0000 (11:01 +0530)]
Merge pull request #55465 from neesingh-rh/wip-63991
doc: add description of metric fields for cephfs-top
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Jos Collin <jcollin@redhat.com>
Casey Bodley [Wed, 7 Feb 2024 21:08:49 +0000 (16:08 -0500)]
qa/rgw: hadoop-s3a uses supported-random-distro$
without this, teuthology-suite tries to schedule against centos8 which
is not supported for squid
Signed-off-by: Casey Bodley <cbodley@redhat.com>
Casey Bodley [Wed, 7 Feb 2024 20:47:23 +0000 (20:47 +0000)]
Merge pull request #55479 from ronen-fr/wip-rf-fifolegacy
rgw: mark maybe_unused variables
Reviewed-by: Casey Bodley <cbodley@redhat.com>
Jane Zhu [Wed, 7 Feb 2024 19:12:23 +0000 (14:12 -0500)]
rgw: do not copy olh attributes in versioning suspended bucket
Signed-off-by: Juan Zhu <jzhu4@dev-10-34-20-139.pw1.bcc.bloomberg.com>
zdover23 [Wed, 7 Feb 2024 19:04:35 +0000 (05:04 +1000)]
Merge pull request #55475 from zdover23/wip-doc-2024-02-07-radosgw-admin-confval
doc/radosgw: add confval directives
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Adam King [Wed, 7 Feb 2024 18:54:19 +0000 (13:54 -0500)]
Merge pull request #55149 from rkachach/fix_issue_63992
mgr/prometheus: fix orch check to prevent Prometheus from crashing
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Juan Miguel Olmo MartÃnez <jolmomar@redhat.com>
Casey Bodley [Mon, 27 Nov 2023 15:42:06 +0000 (10:42 -0500)]
cmake: WITH_QATLIB/ZIP disabled on aarch64
Signed-off-by: Casey Bodley <cbodley@redhat.com>
Casey Bodley [Thu, 23 Nov 2023 04:32:40 +0000 (23:32 -0500)]
compressor: move QatAccel out of common
move the QatAccel instance out of the Compressor base class and into
the zlib and lz4 compressors that can use it
this avoids having to link QAT into the ceph-common library, and only
the plugins where it's necessary
had to add LZ4Compressor.cc to store the new static variable
Signed-off-by: Casey Bodley <cbodley@redhat.com>
Casey Bodley [Mon, 27 Nov 2023 13:32:38 +0000 (08:32 -0500)]
build/win32: disable qat options
Signed-off-by: Casey Bodley <cbodley@redhat.com>
Casey Bodley [Thu, 23 Nov 2023 01:08:19 +0000 (20:08 -0500)]
rpm: add system_qat option, default on for centos9
Signed-off-by: Casey Bodley <cbodley@redhat.com>
Casey Bodley [Fri, 24 Nov 2023 18:42:59 +0000 (13:42 -0500)]
cmake: enable WITH_QATLIB and WITH_QATZIP by default
Signed-off-by: Casey Bodley <cbodley@redhat.com>
Casey Bodley [Fri, 24 Nov 2023 18:42:45 +0000 (13:42 -0500)]
cmake: WITH_QATZIP requires WITH_QATLIB or WITH_QATDRV
Signed-off-by: Casey Bodley <cbodley@redhat.com>
Casey Bodley [Fri, 24 Nov 2023 19:15:12 +0000 (14:15 -0500)]
cmake: build from qatzip submodule
Signed-off-by: Casey Bodley <cbodley@redhat.com>
Casey Bodley [Thu, 23 Nov 2023 00:27:01 +0000 (19:27 -0500)]
cmake: build qatzip from source when WITH_SYSTEM_QATZIP=OFF
Signed-off-by: Casey Bodley <cbodley@redhat.com>
Casey Bodley [Fri, 24 Nov 2023 19:10:55 +0000 (14:10 -0500)]
cmake: build from qatlib submodule
Signed-off-by: Casey Bodley <cbodley@redhat.com>
Casey Bodley [Thu, 23 Nov 2023 00:10:59 +0000 (19:10 -0500)]
cmake: build qat from source when WITH_SYSTEM_QATLIB=OFF
Signed-off-by: Casey Bodley <cbodley@redhat.com>
Ali Maredia [Wed, 7 Feb 2024 15:58:08 +0000 (10:58 -0500)]
Merge pull request #54623 from alimaredia/wip-rgw-op-metrics-section-rename
rgw: change section name of rgw_op counters
Reviewed-by: Casey Bodley <cbodley@redhat.com>
Redouane Kachach [Thu, 11 Jan 2024 16:12:07 +0000 (17:12 +0100)]
mgr/prometheus: fix orch check to prevent Prometheus from crashing
Fixes: https://tracker.ceph.com/issues/63992
Signed-off-by: Redouane Kachach <rkachach@redhat.com>
Casey Bodley [Fri, 24 Nov 2023 17:41:44 +0000 (12:41 -0500)]
cmake: rename qatzip->QATzip and support pkg-config
Signed-off-by: Casey Bodley <cbodley@redhat.com>
Casey Bodley [Fri, 24 Nov 2023 17:23:57 +0000 (12:23 -0500)]
cmake: add WITH_QATLIB to build against qatlib
FindQAT.cmake adds library targets QAT::qat and QAT::usdm for qatlib,
and FindQatDrv.cmake adds alias targets to the same
src/compressor and src/crypto/qat link against these common QAT targets
src/crypto/qat/qcccrypto.h uses new HAVE_QATDRV define to determine
which headers to include
Signed-off-by: Casey Bodley <cbodley@redhat.com>
Casey Bodley [Fri, 24 Nov 2023 17:06:28 +0000 (12:06 -0500)]
cmake: rename WITH_QAT to WITH_QATDRV
Signed-off-by: Casey Bodley <cbodley@redhat.com>
Casey Bodley [Fri, 24 Nov 2023 19:58:37 +0000 (14:58 -0500)]
crypto/qat: remove unused variable qcc_alloc_mutex
Signed-off-by: Casey Bodley <cbodley@redhat.com>
Casey Bodley [Fri, 24 Nov 2023 18:53:58 +0000 (13:53 -0500)]
crypto/qat: remove unused captures of 'this'
Signed-off-by: Casey Bodley <cbodley@redhat.com>
Casey Bodley [Fri, 24 Nov 2023 17:48:15 +0000 (12:48 -0500)]
crypto/qat: add missing include use_future.hpp
Signed-off-by: Casey Bodley <cbodley@redhat.com>
Casey Bodley [Tue, 6 Feb 2024 14:43:50 +0000 (09:43 -0500)]
crypto/qat: qualify spawn::yield_context
Signed-off-by: Casey Bodley <cbodley@redhat.com>
zdover23 [Wed, 7 Feb 2024 15:11:35 +0000 (01:11 +1000)]
Merge pull request #55476 from zdover23/wip-doc-2024-02-07-cephadm-tshooting
doc/cephadm - edit t11ing.
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Zac Dover [Wed, 7 Feb 2024 13:18:35 +0000 (23:18 +1000)]
doc/radosgw: add confval directives
Add confval directives to the documentation of "quota cache" options.
This addresses a request made by Antony D'Atri in https://github.com/ceph/ceph/pull/55075/files#r1444006246.
Signed-off-by: Zac Dover <zac.dover@proton.me>
Ronen Friedman [Wed, 7 Feb 2024 15:00:29 +0000 (09:00 -0600)]
rgw: mark maybe_unused variables
Specifically, variables that are only used in debug builds.
Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
Casey Bodley [Wed, 7 Feb 2024 14:50:58 +0000 (14:50 +0000)]
Merge pull request #54596 from cbodley/wip-cmake-dencoder-modules
cmake: ceph-dencoder depends on ceph-dencoder-modules
Reviewed-by: Kefu Chai <tchaikov@gmail.com>
Guillaume Abrioux [Wed, 7 Feb 2024 14:10:23 +0000 (15:10 +0100)]
Merge pull request #55376 from guits/guits-cv-64248
ceph-volume: fix zap_partitions() in devices.lvm.zap
Ivo Almeida [Thu, 1 Feb 2024 18:15:19 +0000 (18:15 +0000)]
mgr/dashboard: snapshot schedule edit form
Fixes: https://tracker.ceph.com/issues/64331
Signed-off-by: Ivo Almeida <ialmeida@redhat.com>
Zac Dover [Wed, 7 Feb 2024 13:32:53 +0000 (23:32 +1000)]
doc/cephadm - edit t11ing.
Edit "Running Repeated Debugging Sessions" in
doc/cephadm/troubleshooting.rst. Improve grammar. Fix a misspelling.
Signed-off-by: Zac Dover <zac.dover@proton.me>
neeraj pratap singh [Tue, 6 Feb 2024 12:12:50 +0000 (17:42 +0530)]
doc: add description of metric fields for cephfs-top
Fixes: https://tracker.ceph.com/issues/63991
Signed-off-by: Neeraj Pratap Singh <neesingh@redhat.com>
Matan Breizman [Wed, 7 Feb 2024 09:38:45 +0000 (11:38 +0200)]
Merge pull request #55444 from Matan-B/wip-crimson-seastar-upgrade
Crimson: bump up seastar version
Reviewed-by: Samuel Just <sjust@redhat.com>
Shreyansh Sancheti [Mon, 29 Jan 2024 18:03:07 +0000 (13:03 -0500)]
RGW: Getting an RGW service Segfault when assigning an attribute to an IAM role
The current implementation of RGWTagRole, which inherits RGWRestRole::verify_permission() from its base class, encounters a critical issue when loading RGWRole from storage and initializing the RGWRestRole::_role member variable.To address this issue and ensure that errors in initialization are appropriately handled, it is proposed to separate the initialization logic from the permission-checking logic.
Fixes: https://tracker.ceph.com/issues/64232
Signed-off-by: Shreyansh Sancheti <ssanchet@redhat.com>
Yingxin [Wed, 7 Feb 2024 05:42:47 +0000 (13:42 +0800)]
Merge pull request #54280 from xxhdx1985126/wip-rbm-scattered-allocation
crimson/os/seastore/random_block_manager: allow allocating multiple extents for a single disk space allocation request
Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
Reviewed-by: Myoungwon Oh <myoungwon.oh@samsung.com>
Matan Breizman [Mon, 5 Feb 2024 09:35:24 +0000 (09:35 +0000)]
ceph.spec.in: crimson add protobuf
Following https://github.com/scylladb/seastar/commit/
eea4102091bb4d689e0b5a769512966b716ee8a2
Signed-off-by: Matan Breizman <mbreizma@redhat.com>
Matan Breizman [Sun, 4 Feb 2024 10:36:22 +0000 (10:36 +0000)]
crimson/crush/CrushLocation: fix compilation errors
Signed-off-by: Matan Breizman <mbreizma@redhat.com>
Matan Breizman [Sun, 4 Feb 2024 10:34:56 +0000 (10:34 +0000)]
CMakeLists.txt: fix Seastar expected dirs
```
# create the directory so cmake won't complain when looking at the imported
# target: Seastar exports this directory created at build-time
```
Signed-off-by: Matan Breizman <mbreizma@redhat.com>
Matan Breizman [Sun, 4 Feb 2024 09:17:11 +0000 (09:17 +0000)]
seastar: bump up seastar submodule version
Signed-off-by: Matan Breizman <mbreizma@redhat.com>
Adam Kupczyk [Tue, 6 Feb 2024 14:32:48 +0000 (15:32 +0100)]
Merge pull request #55054 from pereman2/zns-remove
os/bluestore: remove zoned namespace support
It has never been finished and now its in the way of future improvements.
Yuval Lifshitz [Tue, 6 Feb 2024 12:09:37 +0000 (14:09 +0200)]
Merge pull request #55275 from qiuxinyidian/rgw-noti-dev
rgw: add topic owner user check when creating
reviewed-by: cbodley, kchheda3
zdover23 [Tue, 6 Feb 2024 09:36:55 +0000 (19:36 +1000)]
Merge pull request #55447 from zdover23/wip-doc-2024-02-05-rados-operations-pools
doc/rados: update PG guidance
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Tobias Urdin [Tue, 6 Feb 2024 07:50:55 +0000 (07:50 +0000)]
rgw/auth: ignoring signatures for HTTP OPTIONS calls
Before [1] we always sent all HTTP OPTIONS requests to
the S3AnonymousEngine and ignored any provided AWSv4
credentials sent in the request.
That PR changed so that if we got credentials in the
request we instead sent it through the authentication
code in order to solve HTTP OPTIONS requests on tenanted
users to start working (because we need to resolve the
tenant, also called bucket tenant in the code, and we can't
only rely on the bucket name since it will not be found).
We solved this by modifying the canonical HTTP method used
when calculating the AWSv4 signature by instead using the
access-control-request-method header which worked good.
This change did not take into account that when you generated
a presigned URL for a put_object request you can also pass in
extra parameters like a canned ACL [2] to the Params variable
in for example boto3's generated_presigned_url().
Doing that will cause the client to add the x-amz-acl header
to x-amz-signedheaders and also use that in their signature
calculation.
When doing a HTTP OPTIONS calls for CORS on that presigned URL
the browser will never send a x-amz-acl header with the correct
data since that is something that the actual PUT request should
include later, so that HTTP OPTIONS call should pass even though
the signature can never be calculated correctly server-side like
verified against AWS S3 in tracker [3].
This patch as a result skips the signature calculation when doing
EC2 auth using the LocalEngine but we still need to pass the request
there in order to lookup the user to support buckets in a tenant.
For the Keystone EC2 auth we're pretty out of luck in the sense that
Keystone's API itself requires us to send the AWSv4 signature in the
request with the access_key in order to obtain a token, and we cannot
leave the signature out, we also cannot spoof the signature from
rgw -> keystone since we don't have access to the secret_key if it's
not in our cache.
For that approach we simply pass on to get_access_token() that if it's
an HTTP OPTIONS and we find the access_key in the cache we pull that
and ignore verifying signature and pass it on for validation. This means
that the cache must be warm if using Keystone auth and adding extra
params to a presigned URL.
This partly makes some of the commits in [1] redundant for EC2
LocalEngine auth but we still need it for tenanted bucket support.
[1] https://github.com/ceph/ceph/pull/52673
[2] https://docs.aws.amazon.com/AmazonS3/latest/userguide/acl-overview.html#canned-acl
[3] https://tracker.ceph.com/issues/64308
Fixes: https://tracker.ceph.com/issues/64308
Signed-off-by: Tobias Urdin <tobias.urdin@binero.se>
Zhipeng Li [Tue, 23 Jan 2024 06:50:52 +0000 (14:50 +0800)]
rgw: modify topic owner check when creating
add tests to cover topic policies
as well as behavior when no policies are defined
Fixes: https://tracker.ceph.com/issues/64124
Signed-off-by: Zhipeng Li <qiuxinyidian@gmail.com>
Casey Bodley [Mon, 5 Feb 2024 21:21:11 +0000 (21:21 +0000)]
Merge pull request #54311 from gabriel-samfira/do-not-escape-slash
RGW: fix cloud-sync not being able to sync folders
Reviewed-by: Casey Bodley <cbodley@redhat.com>
Casey Bodley [Mon, 5 Feb 2024 21:17:31 +0000 (21:17 +0000)]
Merge pull request #55252 from jzhu116-bloomberg/wip-21800
rgw/multisite: avoid writing multipart parts to the bucket index log
Reviewed-by: Casey Bodley <cbodley@redhat.com>
Casey Bodley [Mon, 5 Feb 2024 21:16:56 +0000 (21:16 +0000)]
Merge pull request #55293 from jzhu116-bloomberg/wip-63178
rgw/lc: pass in flag as an argument when calling function complete(..)
Reviewed-by: Casey Bodley <cbodley@redhat.com>
Casey Bodley [Mon, 5 Feb 2024 21:16:27 +0000 (21:16 +0000)]
Merge pull request #54661 from lightmelodies/rgw-gc
rgw: optimize gc chain size calculation
Reviewed-by: Casey Bodley <cbodley@redhat.com>
Ilya Dryomov [Mon, 5 Feb 2024 19:12:51 +0000 (20:12 +0100)]
Merge pull request #55452 from nbalacha/wip-typo-fix
rbd-mirror: fix a typo in NotifyAckPayload::dump()
Reviewed-by: Ramana Raja <rraja@redhat.com>
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
Ali Maredia [Fri, 5 Jan 2024 19:21:17 +0000 (19:21 +0000)]
rgw: add new cap user-info-without-keys
This new cap allows users to run the admin api op
`get user info` without the S3 keys and Swift keys
in the response.
Signed-off-by: Ali Maredia <amaredia@redhat.com>
Casey Bodley [Mon, 5 Feb 2024 17:59:46 +0000 (17:59 +0000)]
Merge pull request #55406 from cbodley/wip-64255
rgw: SiteConfig::load() falls back to local zonegroup
Reviewed-by: Shilpa Jagannath <smanjara@redhat.com>
Reviewed-by: Adam Emerson <aemerson@redhat.com>
Adam King [Mon, 5 Feb 2024 13:28:42 +0000 (08:28 -0500)]
Merge pull request #55448 from guits/subclass-thread
node-proxy: refactor entrypoint
Reviewed-by: Adam King <adking@redhat.com>