Afreen Misbah [Tue, 26 Aug 2025 16:33:54 +0000 (22:03 +0530)]
mgr/dashboard: Drop support for older version of dashboard
Fixes https://tracker.ceph.com/issues/72739
- remove the code for previous version of dashboard
- popover css was globally added in infocard component which needs to be removed now. So include css in respective components- dashboard and upgrade.
Afreen Misbah [Wed, 13 Aug 2025 06:49:02 +0000 (12:19 +0530)]
mgr/dashboard: Add /health/snapshot api
Fixes https://tracker.ceph.com/issues/72609
- The current minimal API relies on fetching data from osdmap and pgmap.
- These commands produce large, detailed payloads that become a performance bottleneck and impact scalability, especially in large clusters.
- To address this, we propose switching to the ceph snapshot API using ceph status command, which retrieves essential information directly from the cluster map.
- ceph status is significantly more lightweight compared to osdmap/pgmap, reducing payload sizes and processing overhead.
- This change ensures faster response times, improves system efficiency in large deployments, and minimizes unnecessary data transfer.
- update tests
Dan Mick [Sat, 23 Aug 2025 00:43:24 +0000 (17:43 -0700)]
make-debs.sh: invoke tar with --no-same-owner
When running as a normal user, tar does not attempt to preserve
owners set on the tar content files. When running as root, it does.
Containerized builds are running as root. Stop make-debs.sh from
trying to set other owners for files, and leaving files in the
host system with mapped UIDs other than the user running the container
(which causes jenkins to be unable to clear the workspace).
Zac Dover [Fri, 22 Aug 2025 08:39:29 +0000 (18:39 +1000)]
doc/cephfs: edit troubleshooting.rst (Slow MDS)
Move the "Slow requests (MDS)" section immediately after the first
section in this document ("Slow/Stuck Operations"), because the first
procedure on the page directs the reader to undertake the operation in
"Slow requests (MDS)" before trying anything else.
Dan Mick [Thu, 21 Aug 2025 20:00:43 +0000 (13:00 -0700)]
make-debs.sh: make "skip debug packages" conditional
Now that we're using make-debs.sh as a builder inside containers,
the default should be to build all the packages, including debug.
(Also, fix a typo.)
Ilya Dryomov [Thu, 21 Aug 2025 19:39:29 +0000 (21:39 +0200)]
mon/MonClient: post version request completions outside of monc_lock
dispatch() is allowed to invoke the completion object in the current
thread, before control returns from dispatch(). This isn't desirable
when it comes to discarding version requests in MonClient::shutdown()
and MonClient::_reopen_session() because completion objects could then
be invoked under monc_lock. In case of MonClient::_reopen_session() in
particular, this leads to an attempt to acquire monc_lock once again in
MonClient::get_version() on a retry due to monc_errc::session_reset
that is converted to errc::resource_unavailable_try_again:
MonClient::ms_handle_reset
< takes monc_lock >
MonClient::_reopen_session
< invokes the completion object via dispatch() with ec == monc_errc::session_reset >
Objecter::CB_Objecter_GetVersion::operator() [ ec == errc::resource_unavailable_try_again ]
Objecter::_wait_for_latest_osdmap
MonClient::get_version
< attempts to take monc_lock in the body of the lambda >
The end result is either a lockup or some form of undefined behavior.
The best possible outcome here is an exception (std::system_error with
"Resource deadlock avoided" error) and a successive call to
std::terminate().
This is a regression introduced in commit e81d4eae4e76 ("common/async:
Update `use_blocked` for newer asio"). Revert to posting version
request completions for the error cases in a way that is uniform with
the success case in MonClient::handle_get_version_reply().
Samuel Just [Tue, 12 Aug 2025 00:36:16 +0000 (17:36 -0700)]
crimson/.../store-bench: refactor arguments and workloads
- Adds a workload abstraction grouping arguments with associated
workload.
- Reworks argument parsing to occur prior to seastar app, allows
passing unparsed arguments to ceph.
- Refactors time usages as necessary to use std::chrono types.
- Removes LOG_PREFIX usages that don't currently have log lines.
- Other minor cleanups not worth separating out.
make_snapmapper_oid was missing for the new PGs created post-splitting.
This was causing a scrub error due to the missing snap mapper object in the children PGs.
crimson/osd/scrub: check if stats have been marked invalid
In case of splits/merges the PeeringState::split_into function will mark
the child and parent pgs stats invalid.
We need to check for this when scrub finishes, update the stats and mark them valid.
Kefu Chai [Mon, 9 Jun 2025 12:35:44 +0000 (20:35 +0800)]
src: Fix memory leaks in generate_test_instance() by returning values instead of pointers
Problem:
The current `generate_test_instance()` function returns `std::list<T*>`,
which creates memory management issues:
- Inconsistent lifecycle management of test instances
- Callers don't always properly clean up allocated memory
- Results in ASan memory leak reports in unit tests and ceph-dencoder
Solution:
Change `generate_test_instance()` to return `std::list<T>` instead of `std::list<T*>`:
Core Changes:
- Modified all classes with `generate_test_instance()` to return `std::list<T>`
- Use `emplace_back()` without parameters** to avoid copy/move
constructors for classes that don't define them
- Updated ceph-dencoder to handle the new return type
ceph-dencoder Adaptations:
Since `m_list` now holds `T` objects instead of `T*`, and we can't
assume `T` is copyable/moveable:
- Keep `m_object` as a pointer for flexibility
- Handle two scenarios:
1. `m_object` points to an element in `m_list`
2. `m_object` points to a decoded instance (requires manual cleanup)
- Introduce `make_ptr()` as a factory function to create a smart pointer
to conditionally free the managed pointer.
Additional Cleanup:
- Simplify DencoderBase constructor from template to plain
function (extra parameters were never used in derived classes)
With this change, object lifecycles are now managed by value semantics
instead of raw pointers, eliminating memory leaks.
Niklas Hambüchen [Sat, 21 Jun 2025 17:46:13 +0000 (19:46 +0200)]
doc/rados/configuration: Mention show-with-defaults and ceph-conf
A small improvement based on
"Why is it still so difficult to just dump all config and where it comes from?"
https://lists.ceph.io/hyperkitty/list/ceph-users@ceph.io/thread/EZSLRYBYEWDA6YIARQVMUKQUWHAE3PGR/
`show-with-defaults` is very useful, and `ceph-conf` is mentioned
so that it's clear that it's legacy, and the user doesn't have to
wonder if it's actually useful but was forgotten in the list.
Improve source rpm detection by adding a new detection method that
executes and rpm command in a container to get exactly the version of
the source rpm that the ceph.spec file would have generated. For
backwards compatibility and that I don't entirely trust myself to have
tested this the old methods are still available.
The old `--rpm-no-match-sha` is now an alias for `--srpm-match=any` to
cause it to build any (unique) ceph srpm it finds.
`--srpm-match=versionglob` retains the previous default behavior of
using a glob matching on the git id or ceph version value. The new
default of `--srpm-match=auto` implements the rpm command based behavior
described above.
All of this is wrapped in a new step `find-rpm` but that's mostly an
implementation detail and for testing.
Signed-off-by: John Mulligan <jmulligan@redhat.com>
projects / ceph.git / log