]> git.apps.os.sepia.ceph.com Git - ceph.git/log
ceph.git
20 months agoMerge pull request #54314 from batrick/wip-63419-pacific
Yuri Weinstein [Mon, 4 Dec 2023 19:35:48 +0000 (11:35 -0800)]
Merge pull request #54314 from batrick/wip-63419-pacific

pacific: mds: ensure next replay is queued on req drop

Reviewed-by: Rishabh Dave <ridave@redhat.com>
20 months agoMerge pull request #54593 from idryomov/wip-53593-pacific
Yuri Weinstein [Mon, 4 Dec 2023 15:54:31 +0000 (07:54 -0800)]
Merge pull request #54593 from idryomov/wip-53593-pacific

pacific: osd: don't require RWEXCL lock for stat+write ops.

Reviewed-by: Laura Flores <lflores@redhat.com>
20 months agoMerge pull request #52993 from k0ste/wip-57474-pacific
Yuri Weinstein [Mon, 4 Dec 2023 15:53:28 +0000 (07:53 -0800)]
Merge pull request #52993 from k0ste/wip-57474-pacific

pacific: mgr: fix a race condition in DaemonServer::handle_report()

Reviewed-by: Laura Flores <lflores@redhat.com>
20 months agoMerge pull request #51259 from k0ste/wip-52557-pacific
Yuri Weinstein [Mon, 4 Dec 2023 15:52:40 +0000 (07:52 -0800)]
Merge pull request #51259 from k0ste/wip-52557-pacific

pacific: pybind/rados: don't close watch in dealloc if already closed

Reviewed-by: Laura Flores <lflores@redhat.com>
21 months agoMerge pull request #54039 from vshankar/wip-61829-pacific
Yuri Weinstein [Fri, 1 Dec 2023 17:22:36 +0000 (09:22 -0800)]
Merge pull request #54039 from vshankar/wip-61829-pacific

pacific: qa: assign file system affinity for replaced MDS

Reviewed-by: Laura Flores <lflores@redhat.com>
21 months agoMerge pull request #54361 from ifed01/wip-ifed-fix-rados-pybind-pac
Yuri Weinstein [Fri, 1 Dec 2023 16:41:28 +0000 (08:41 -0800)]
Merge pull request #54361 from ifed01/wip-ifed-fix-rados-pybind-pac

pacific: pybind/rados: fix missed changes for PEP484 style type annotations

Reviewed-by: Kefu Chai <tchaikov@gmail.com>
21 months agoMerge pull request #51260 from k0ste/wip-52307-pacific
Yuri Weinstein [Fri, 1 Dec 2023 16:39:20 +0000 (08:39 -0800)]
Merge pull request #51260 from k0ste/wip-52307-pacific

pacific: doc: clarify use of `rados rm` command

Reviewed-by: Neha Ojha <nojha@redhat.com>
21 months agoMerge pull request #54652 from k0ste/wip-58829-pacific
Nizamudeen A [Wed, 29 Nov 2023 11:32:47 +0000 (17:02 +0530)]
Merge pull request #54652 from k0ste/wip-58829-pacific

pacific: mgr/dashboard: fix constraints.txt

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
21 months agoMerge pull request #54474 from k0ste/wip-63441-pacific
Yuri Weinstein [Tue, 28 Nov 2023 20:03:08 +0000 (12:03 -0800)]
Merge pull request #54474 from k0ste/wip-63441-pacific

pacific: Fixing example of BlueStore resharding.

Reviewed-by: Laura Flores <lflores@redhat.com>
Reviewed-by: Joshua Baergen <jbaergen@digitalocean.com>
21 months agoMerge pull request #53567 from pdvian/wip-59178-pacific
Yuri Weinstein [Tue, 28 Nov 2023 20:00:59 +0000 (12:00 -0800)]
Merge pull request #53567 from pdvian/wip-59178-pacific

pacific: blk/kernel: Add O_EXCL for block devices

Reviewed-by: Laura Flores <lflores@redhat.com>
21 months agoMerge pull request #52055 from trociny/wip-61433-pacific
Yuri Weinstein [Tue, 28 Nov 2023 19:59:02 +0000 (11:59 -0800)]
Merge pull request #52055 from trociny/wip-61433-pacific

pacific: rgw: multisite data log flag not used

Reviewed-by: Shilpa Jagannath <smanjara@redhat.com>
21 months agoMerge pull request #52051 from trociny/wip-59610-pacific
Yuri Weinstein [Tue, 28 Nov 2023 19:58:29 +0000 (11:58 -0800)]
Merge pull request #52051 from trociny/wip-59610-pacific

pacific: rgw/sts: AssumeRole no longer writes to user metadata

Reviewed-by: Shilpa Jagannath <smanjara@redhat.com>
21 months agoMerge pull request #51602 from alimaredia/wip-58584-pacific
Yuri Weinstein [Tue, 28 Nov 2023 19:57:54 +0000 (11:57 -0800)]
Merge pull request #51602 from alimaredia/wip-58584-pacific

pacific: rgw: set keys from from master zone on admin api user create

Reviewed-by: Jiffin Tony Thottan <jthottan@redhat.com>
21 months agoMerge pull request #51600 from alimaredia/wip-61175-pacific
Yuri Weinstein [Tue, 28 Nov 2023 19:55:27 +0000 (11:55 -0800)]
Merge pull request #51600 from alimaredia/wip-61175-pacific

pacific: rgw/swift: check position of first slash in slo manifest files

Reviewed-by: Shilpa Jagannath <smanjara@redhat.com>
21 months agoMerge pull request #51445 from k0ste/wip-59729-pacific
Yuri Weinstein [Tue, 28 Nov 2023 19:54:59 +0000 (11:54 -0800)]
Merge pull request #51445 from k0ste/wip-59729-pacific

pacific: RGW: Solving the issue of not populating etag in Multipart upload result

Reviewed-by: Shilpa Jagannath <smanjara@redhat.com>
21 months agoMerge pull request #51256 from k0ste/wip-55063-pacific
Yuri Weinstein [Tue, 28 Nov 2023 19:54:25 +0000 (11:54 -0800)]
Merge pull request #51256 from k0ste/wip-55063-pacific

pacific: radosgw-admin: fix segfault on pipe modify without source/dest zone specified

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
21 months agoMerge pull request #50540 from k0ste/wip-55149-pacific
Yuri Weinstein [Tue, 28 Nov 2023 19:53:31 +0000 (11:53 -0800)]
Merge pull request #50540 from k0ste/wip-55149-pacific

pacific: rgw: Update "CEPH_RGW_DIR_SUGGEST_LOG_OP" for remove entries

Reviewed-by: Shilpa Jagannath <smanjara@redhat.com>
21 months agoMerge pull request #49526 from dang/wip-58234-pacific
Yuri Weinstein [Tue, 28 Nov 2023 19:52:45 +0000 (11:52 -0800)]
Merge pull request #49526 from dang/wip-58234-pacific

pacific: rgw: Fix truncated ListBuckets response.

Reviewed-by: Shilpa Jagannath <smanjara@redhat.com>
21 months agoMerge pull request #46106 from BenoitKnecht/wip-55500-pacific
Yuri Weinstein [Tue, 28 Nov 2023 19:52:15 +0000 (11:52 -0800)]
Merge pull request #46106 from BenoitKnecht/wip-55500-pacific

pacific: rgw: Avoid segfault when OPA authz is enabled

Reviewed-by: Shilpa Jagannath <smanjara@redhat.com>
21 months agoMerge pull request #44471 from pritha-srivastava/wip-53648-pacific
Yuri Weinstein [Tue, 28 Nov 2023 19:51:13 +0000 (11:51 -0800)]
Merge pull request #44471 from pritha-srivastava/wip-53648-pacific

pacific: rgw/sts: fix read_obj_policy permission evaluation

Reviewed-by: Shilpa Jagannath <smanjara@redhat.com>
21 months agoMerge pull request #44464 from pritha-srivastava/wip-52778-pacific
Yuri Weinstein [Tue, 28 Nov 2023 19:50:34 +0000 (11:50 -0800)]
Merge pull request #44464 from pritha-srivastava/wip-52778-pacific

pacific: rgw/sts: code to fetch certs using .well-known/openid-configuration URL

Reviewed-by: Shilpa Jagannath <smanjara@redhat.com>
21 months agoMerge pull request #44463 from pritha-srivastava/wip-52785-pacific
Yuri Weinstein [Tue, 28 Nov 2023 19:49:20 +0000 (11:49 -0800)]
Merge pull request #44463 from pritha-srivastava/wip-52785-pacific

pacific: rgw/sts: fixes getsessiontoken authenticated with LDAP,

Reviewed-by: Shilpa Jagannath <smanjara@redhat.com>
21 months agoMerge pull request #53693 from pdvian/wip-62996-pacific
Aishwarya Mathuria [Tue, 28 Nov 2023 16:31:24 +0000 (22:01 +0530)]
Merge pull request #53693 from pdvian/wip-62996-pacific

pacific: osd/OpRequest: Add detail description for delayed op in osd log file

21 months agoMerge pull request #54434 from ifed01/wip-ifed-no-alloc-lba-align-pac
Yuri Weinstein [Tue, 28 Nov 2023 16:02:26 +0000 (08:02 -0800)]
Merge pull request #54434 from ifed01/wip-ifed-no-alloc-lba-align-pac

pacific: os/bluestore: get rid off resulting lba alignment in allocators

Reviewed-by: Adam Kupczyk <akupczyk@redhat.com>
21 months agoMerge pull request #53464 from k0ste/wip-56649-pacific
Yuri Weinstein [Tue, 28 Nov 2023 16:01:18 +0000 (08:01 -0800)]
Merge pull request #53464 from k0ste/wip-56649-pacific

pacific: pybind/mgr/autoscaler: Donot show NEW PG_NUM value if autoscaler is not on

Reviewed-by: Neha Ojha <nojha@redhat.com>
21 months agoMerge pull request #52203 from trociny/wip-61822-pacific
Yuri Weinstein [Tue, 28 Nov 2023 16:00:49 +0000 (08:00 -0800)]
Merge pull request #52203 from trociny/wip-61822-pacific

pacific: tools/osdmaptool: fix possible segfaults when there are down osds

Reviewed-by: Neha Ojha <nojha@redhat.com>
21 months agoMerge pull request #51262 from k0ste/wip-52841-pacific
Yuri Weinstein [Tue, 28 Nov 2023 16:00:22 +0000 (08:00 -0800)]
Merge pull request #51262 from k0ste/wip-52841-pacific

pacific: osd: fix shard-threads cannot wakeup bug

Reviewed-by: Neha Ojha <nojha@redhat.com>
21 months agoMerge pull request #50552 from rzarzynski/wip-59085-pacific
Yuri Weinstein [Tue, 28 Nov 2023 15:59:51 +0000 (07:59 -0800)]
Merge pull request #50552 from rzarzynski/wip-59085-pacific

pacific: mon: add proxy to cache tier options

Reviewed-by: Neha Ojha <nojha@redhat.com>
21 months agoMerge pull request #50194 from trociny/wip-58805-pacific
Yuri Weinstein [Tue, 28 Nov 2023 15:58:46 +0000 (07:58 -0800)]
Merge pull request #50194 from trociny/wip-58805-pacific

pacific: mgr: don't dump global config holding gil

Reviewed-by: Tim Serong <tserong@suse.com>
Reviewed-by: John Mulligan <jmulligan@redhat.com>
21 months agomgr/dashboard: fix constraints.txt 54652/head
Ernesto Puerta [Wed, 22 Feb 2023 10:31:47 +0000 (11:31 +0100)]
mgr/dashboard: fix constraints.txt

Replaces strict version matching with compatible version syntax.

Reference: https://peps.python.org/pep-0440/#version-specifiers

Fixes: https://tracker.ceph.com/issues/58827
Signed-off-by: Ernesto Puerta <epuertat@redhat.com>
(cherry picked from commit d5f8927a5cd4bfd9870f02fea1c66b32191d1fba)

21 months agoMerge pull request #54192 from cfsnyder/wip-62621-pacific
Nizamudeen A [Fri, 24 Nov 2023 05:02:09 +0000 (10:32 +0530)]
Merge pull request #54192 from cfsnyder/wip-62621-pacific

pacific: mgr/dashboard: add 'omit_usage' query param to dashboard api 'get rbd' endpoint

Reviewed-by: Nizamudeen A <nia@redhat.com>
21 months agomds: ensure next replay is queued on req drop 54314/head
Patrick Donnelly [Fri, 15 Jul 2022 20:39:00 +0000 (16:39 -0400)]
mds: ensure next replay is queued on req drop

Not all client replay requests are queued at once since [1]. We require
the next request by queued when completed (unsafely) or during cleanup.
Not all code paths seem to handle this [2] so move it to a generic
location, MDCache::request_cleanup. Even so, this doesn't handle all
errors (so we must still be careful) as sometimes we must queue the next
replay request before an MDRequest is constructed [3] during some error
conditions.

Additionally, preserve the behavior of Server::journal_and_reply
queueing the next replay op. Otherwise, must wait for the request to be
durable before moving onto the next one, unnecessarily.

For reproducing, two specific cases are highlighted (thanks to @Mer1997 on
Github for locating these):

- The request is killed by a session close / eviction while a replayed request
  is queued and waiting for a journal flush (e.g. dirty inest locks).

- The request construction fails because the request is already in the
  active_requests. This could happen theoretically if a client resends the same
  request (same reqid) twice.

The first case is most probable but very difficult to reproduce for testing
purposes. The replayed op would need to wait on a journal flush (to be
restarted by C_MDS_RetryRequest).  Then, the request would need killed by a
session close.

[1] ed6a18d90fdd1dc869369fb92c2aad43bc5c9a34
[2] https://github.com/ceph/ceph/blob/a6f1a1c6c09d74f5918c715b05789f34f2ea0e90/src/mds/Server.cc#L2253-L2262
[3] https://github.com/ceph/ceph/blob/a6f1a1c6c09d74f5918c715b05789f34f2ea0e90/src/mds/Server.cc#L2380

Fixes: https://tracker.ceph.com/issues/56577
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
(cherry picked from commit 078ecaa42b98f9858d2e3a045aedb51153b39e34)

Conflicts:
src/mds/Mutation.h: lock dump changes not backported
src/mds/Server.cc: minor code change

21 months agoMerge pull request #54410 from mihalicyn/wip-63478-pacific
Yuri Weinstein [Wed, 22 Nov 2023 20:01:19 +0000 (12:01 -0800)]
Merge pull request #54410 from mihalicyn/wip-63478-pacific

pacific: MClientRequest: properly handle ceph_mds_request_head_legacy for ext_num_retry, ext_num_fwd, owner_uid, owner_gid

Reviewed-by: Rishabh Dave <ridave@redhat.com>
21 months agoMerge pull request #54318 from batrick/wip-63414-pacific
Yuri Weinstein [Wed, 22 Nov 2023 20:00:39 +0000 (12:00 -0800)]
Merge pull request #54318 from batrick/wip-63414-pacific

pacific: mon: fix mds metadata lost in one case.

Reviewed-by: Rishabh Dave <ridave@redhat.com>
21 months agoMerge pull request #54245 from vshankar/wip-63283-pacific
Yuri Weinstein [Wed, 22 Nov 2023 19:58:26 +0000 (11:58 -0800)]
Merge pull request #54245 from vshankar/wip-63283-pacific

pacific: client: always refresh mds feature bits on session open

Reviewed-by: Rishabh Dave <ridave@redhat.com>
21 months agoMerge pull request #53716 from leonid-s-usov/bp/msg-wait/pacific
Yuri Weinstein [Wed, 22 Nov 2023 19:57:10 +0000 (11:57 -0800)]
Merge pull request #53716 from leonid-s-usov/bp/msg-wait/pacific

pacific: msg/AsyncMessenger: re-evaluate the stop condition when woken up in 'wait()'

Reviewed-by: Rishabh Dave <ridave@redhat.com>
Reviewed-by: Ilya Dryomov <idryomov@redhat.com>
21 months agoMerge pull request #53634 from vshankar/wip-62584-pacific
Yuri Weinstein [Wed, 22 Nov 2023 19:56:06 +0000 (11:56 -0800)]
Merge pull request #53634 from vshankar/wip-62584-pacific

pacific: mds: blocklist clients with "bloated" session metadata

Reviewed-by: Rishabh Dave <ridave@redhat.com>
21 months agoMerge pull request #53552 from batrick/wip-62906-pacific
Yuri Weinstein [Wed, 22 Nov 2023 19:55:20 +0000 (11:55 -0800)]
Merge pull request #53552 from batrick/wip-62906-pacific

pacific: mds,qa: some balancer debug messages (<=5) not printed when debug_mds is >=5

Reviewed-by: Rishabh Dave <ridave@redhat.com>
21 months agoMerge pull request #54604 from lxbsz/wip-63586-p
Ilya Dryomov [Wed, 22 Nov 2023 11:22:52 +0000 (12:22 +0100)]
Merge pull request #54604 from lxbsz/wip-63586-p

pacific: osd: log the number of extents for sparse read

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
21 months agoosd: add more debug logs for sparse read 54604/head
Xiubo Li [Mon, 20 Nov 2023 14:04:12 +0000 (22:04 +0800)]
osd: add more debug logs for sparse read

This will be very important to get to know what exactly has happened
when client get a very large number of extents.

URL: https://tracker.ceph.com/issues/63586
Signed-off-by: Xiubo Li <xiubli@redhat.com>
(cherry picked from commit 1cf5ecb93fb73a5ed4a82935f635f98efccf7de6)

21 months agoosd: don't require RWEXCL lock for stat+write ops. 54593/head
Alice Zhao [Mon, 11 Apr 2022 12:35:57 +0000 (08:35 -0400)]
osd: don't require RWEXCL lock for stat+write ops.
In librbd, a stat op is inserted before write op for cloned image. OSD used to use RWEXCL and such requests are processed one by one.
With this fix, OSD will use RWWRITE rather than RWEXCL for such [stat,write] request to allow multiple [stat,write] on the same object and improve performance.

Signed-off-by: Alice Zhao <brucen1030@163.com>
(cherry picked from commit 9be266b0a0304aaaaa0ca12f28fcd3e9cce1f9d7)

Conflicts:
src/osd/PrimaryLogPG.cc [ commit dfca9f8c0d8b ("osd: move
  PrimaryLogPG::get_rw_locks() from header to .cc.") not in
  pacific ]

21 months agoMerge pull request #54542 from aaSharma14/wip-63570-pacific
Aashish Sharma [Tue, 21 Nov 2023 11:17:36 +0000 (16:47 +0530)]
Merge pull request #54542 from aaSharma14/wip-63570-pacific

pacific: mgr/dashboard: Consider null values as zero in grafana panels

Reviewed-by: Nizamudeen A <nia@redhat.com>
21 months agomgr/dashboard: Consider null values as zero in grafana panels 54542/head
Aashish Sharma [Wed, 4 Oct 2023 06:54:13 +0000 (12:24 +0530)]
mgr/dashboard: Consider null values as zero in grafana panels

After upgrading from RHCS4 to RHCS5..some of the grafana charts broke.
This is because in RHCS5 we do not generate the metrics if its value is
zero as a result the null value from that metric breaks the grafana
charts or graphs. This PR is to fix the above mentioned issue.

Fixes: https://tracker.ceph.com/issues/63088
Signed-off-by: Aashish Sharma <aasharma@redhat.com>
(cherry picked from commit 6f3f58cb8e4ce100cc7186858465b4d11d5c2c49)

21 months agoMerge pull request #54010 from k0ste/wip-53152-pacific
Yuri Weinstein [Wed, 15 Nov 2023 22:24:38 +0000 (14:24 -0800)]
Merge pull request #54010 from k0ste/wip-53152-pacific

pacific: radosgw-admin: allow 'bi purge' to delete index if entrypoint doesn't exist

Reviewed-by: Casey Bodley <cbodley@redhat.com>
21 months agoMerge pull request #54160 from cbodley/wip-61351-pacific
Yuri Weinstein [Wed, 15 Nov 2023 21:47:05 +0000 (13:47 -0800)]
Merge pull request #54160 from cbodley/wip-61351-pacific

pacific: rgw/s3: ListObjectsV2 returns correct object owners

Reviewed-by: Casey Bodley <cbodley@redhat.com>
21 months agoMerge pull request #53764 from cbodley/wip-63043-pacific
Yuri Weinstein [Wed, 15 Nov 2023 21:46:11 +0000 (13:46 -0800)]
Merge pull request #53764 from cbodley/wip-63043-pacific

pacific: rgw/keystone: EC2Engine uses reject() for ERR_SIGNATURE_NO_MATCH

Reviewed-by: Casey Bodley <cbodley@redhat.com>
21 months agoMerge pull request #53443 from trociny/wip-61872-pacific
Yuri Weinstein [Wed, 15 Nov 2023 21:45:17 +0000 (13:45 -0800)]
Merge pull request #53443 from trociny/wip-61872-pacific

pacific: rgw: pick http_date in case of http_x_amz_date absence

Reviewed-by: Casey Bodley <cbodley@redhat.com>
21 months agoMerge pull request #52996 from k0ste/wip-59026-pacific
Yuri Weinstein [Wed, 15 Nov 2023 21:44:30 +0000 (13:44 -0800)]
Merge pull request #52996 from k0ste/wip-59026-pacific

pacific: rgw: use unique_ptr for flat_map emplace in BucketTrimWatche

Reviewed-by: Casey Bodley <cbodley@redhat.com>
21 months agoMerge pull request #52605 from cbodley/wip-62138-pacific
Yuri Weinstein [Wed, 15 Nov 2023 21:20:33 +0000 (13:20 -0800)]
Merge pull request #52605 from cbodley/wip-62138-pacific

pacific: rgw: s3 object lock avoids overflow in retention date

Reviewed-by: Casey Bodley <cbodley@redhat.com>
21 months agoMerge pull request #54016 from k0ste/wip-57199-pacific
Yuri Weinstein [Wed, 15 Nov 2023 21:06:05 +0000 (13:06 -0800)]
Merge pull request #54016 from k0ste/wip-57199-pacific

pacific: rgw: 'bucket check' deletes index of multipart meta when its pending_map is nonempty

Reviewed-by: Casey Bodley <cbodley@redhat.com>
21 months agoMerge pull request #54014 from k0ste/wip-59361-pacific
Yuri Weinstein [Wed, 15 Nov 2023 21:05:32 +0000 (13:05 -0800)]
Merge pull request #54014 from k0ste/wip-59361-pacific

pacific: rgw: fix rgw cache invalidation after unregister_watch() error

Reviewed-by: Casey Bodley <cbodley@redhat.com>
21 months agoMerge pull request #53775 from cbodley/wip-63055-pacific
Yuri Weinstein [Wed, 15 Nov 2023 21:04:55 +0000 (13:04 -0800)]
Merge pull request #53775 from cbodley/wip-63055-pacific

pacific: rgw: improve buffer list utilization in the chunkupload scenario

Reviewed-by: Casey Bodley <cbodley@redhat.com>
21 months agoMerge pull request #53772 from cbodley/wip-63052-pacific
Yuri Weinstein [Wed, 15 Nov 2023 21:04:10 +0000 (13:04 -0800)]
Merge pull request #53772 from cbodley/wip-63052-pacific

pacific: rgw: fix SignatureDoesNotMatch when extra headers start with 'x-amz'

Reviewed-by: Casey Bodley <cbodley@redhat.com>
21 months agoMerge pull request #53769 from cbodley/wip-63049-pacific
Yuri Weinstein [Wed, 15 Nov 2023 21:03:19 +0000 (13:03 -0800)]
Merge pull request #53769 from cbodley/wip-63049-pacific

pacific: rgw: s3website doesn't prefetch for web_dir() check

Reviewed-by: Casey Bodley <cbodley@redhat.com>
21 months agoMerge pull request #53759 from cbodley/wip-63058-pacific
Yuri Weinstein [Wed, 15 Nov 2023 21:02:30 +0000 (13:02 -0800)]
Merge pull request #53759 from cbodley/wip-63058-pacific

pacific: rgw: fix unwatch crash at radosgw startup

Reviewed-by: Casey Bodley <cbodley@redhat.com>
21 months agoMerge pull request #53593 from trociny/wip-58478-pacific
Yuri Weinstein [Wed, 15 Nov 2023 21:01:45 +0000 (13:01 -0800)]
Merge pull request #53593 from trociny/wip-58478-pacific

pacific: rgw: fix FP error when calculating enteries per bi shard

Reviewed-by: Casey Bodley <cbodley@redhat.com>
21 months agoMerge pull request #53474 from k0ste/wip-55701-pacific
Yuri Weinstein [Wed, 15 Nov 2023 21:01:16 +0000 (13:01 -0800)]
Merge pull request #53474 from k0ste/wip-55701-pacific

pacific: radosgw-admin: don't crash on --placement-id without --storage-class

Reviewed-by: Casey Bodley <cbodley@redhat.com>
21 months agoMerge pull request #53472 from k0ste/wip-57635-pacific
Yuri Weinstein [Wed, 15 Nov 2023 21:00:49 +0000 (13:00 -0800)]
Merge pull request #53472 from k0ste/wip-57635-pacific

pacific: rgw: Drain async_processor request queue during shutdown

Reviewed-by: Casey Bodley <cbodley@redhat.com>
21 months agoMerge pull request #53439 from k0ste/wip-62823-pacific
Yuri Weinstein [Wed, 15 Nov 2023 21:00:19 +0000 (13:00 -0800)]
Merge pull request #53439 from k0ste/wip-62823-pacific

pacific: RadosGW API: incorrect bucket quota in response to HEAD /{bucket}/?usage

Reviewed-by: Casey Bodley <cbodley@redhat.com>
21 months agoMerge pull request #53410 from trociny/wip-62308-pacific
Yuri Weinstein [Wed, 15 Nov 2023 20:59:46 +0000 (12:59 -0800)]
Merge pull request #53410 from trociny/wip-62308-pacific

pacific: rgw/sync-policy: Correct "sync status" & "sync group" commands

Reviewed-by: Casey Bodley <cbodley@redhat.com>
21 months agoMerge pull request #53400 from trociny/wip-62751-pacific
Yuri Weinstein [Wed, 15 Nov 2023 20:59:14 +0000 (12:59 -0800)]
Merge pull request #53400 from trociny/wip-62751-pacific

pacific: rgw: fix 2 null versionID after convert_plain_entry_to_versioned

Reviewed-by: Casey Bodley <cbodley@redhat.com>
21 months agoMerge pull request #53376 from jzhu116-bloomberg/wip-59692-pacific
Yuri Weinstein [Wed, 15 Nov 2023 20:51:27 +0000 (12:51 -0800)]
Merge pull request #53376 from jzhu116-bloomberg/wip-59692-pacific

pacific: rgw/notification: remove non x-amz-meta-* attributes from bucket notifications

Reviewed-by: Yuval Lifshitz <ylifshit@redhat.com>
21 months agoMerge pull request #53356 from k0ste/wip-53658-pacific
Yuri Weinstein [Wed, 15 Nov 2023 20:50:05 +0000 (12:50 -0800)]
Merge pull request #53356 from k0ste/wip-53658-pacific

pacific: rgw: fix UploadPartCopy error code when src object not exist and src bucket not exist

Reviewed-by: Casey Bodley <cbodley@redhat.com>
21 months agoMerge pull request #52936 from k0ste/wip-58902-pacific
Yuri Weinstein [Wed, 15 Nov 2023 20:49:17 +0000 (12:49 -0800)]
Merge pull request #52936 from k0ste/wip-58902-pacific

pacific: rgw: Fix Browser POST content-length-range min value

Reviewed-by: Casey Bodley <cbodley@redhat.com>
21 months agoMerge pull request #52797 from cbodley/wip-62300-pacific
Yuri Weinstein [Wed, 15 Nov 2023 20:48:47 +0000 (12:48 -0800)]
Merge pull request #52797 from cbodley/wip-62300-pacific

pacific: rgw: retry metadata cache notifications with INVALIDATE_OBJ

Reviewed-by: Casey Bodley <cbodley@redhat.com>
21 months agoMerge pull request #52729 from theanalyst/wip-58817
Yuri Weinstein [Wed, 15 Nov 2023 20:47:48 +0000 (12:47 -0800)]
Merge pull request #52729 from theanalyst/wip-58817

pacific: rgw: swift : check for valid key in POST forms

Reviewed-by: Casey Bodley <cbodley@redhat.com>
21 months agoMerge pull request #52113 from cbodley/wip-61728-pacific
Yuri Weinstein [Wed, 15 Nov 2023 20:45:37 +0000 (12:45 -0800)]
Merge pull request #52113 from cbodley/wip-61728-pacific

pacific: rgw/beast: add max_header_size option with 16k default, up from 4k

Reviewed-by: Casey Bodley <cbodley@redhat.com>
21 months agoMerge pull request #54167 from cbodley/wip-58238-pacific
Yuri Weinstein [Wed, 15 Nov 2023 16:28:52 +0000 (08:28 -0800)]
Merge pull request #54167 from cbodley/wip-58238-pacific

pacific: rgw: beast frontend checks for local_endpoint() errors

Reviewed-by: Casey Bodley <cbodley@redhat.com>
21 months agoMerge pull request #54120 from dparmar18/wip-63269-pacific
Yuri Weinstein [Wed, 15 Nov 2023 15:55:34 +0000 (07:55 -0800)]
Merge pull request #54120 from dparmar18/wip-63269-pacific

pacific: mds: report clients laggy due laggy OSDs only after checking any OSD is laggy

Reviewed-by: Rishabh Dave <ridave@redhat.com>
21 months agoMerge pull request #53916 from kotreshhr/wip-63164-pacific
Yuri Weinstein [Wed, 15 Nov 2023 15:55:00 +0000 (07:55 -0800)]
Merge pull request #53916 from kotreshhr/wip-63164-pacific

pacific: pybind/mgr/volumes: log mutex locks to help debug deadlocks

Reviewed-by: Rishabh Dave <ridave@redhat.com>
21 months agoMerge pull request #53576 from mchangir/wip-57157-pacific
Yuri Weinstein [Wed, 15 Nov 2023 15:54:26 +0000 (07:54 -0800)]
Merge pull request #53576 from mchangir/wip-57157-pacific

pacific: doc/cephfs: note regarding start time time zone

Reviewed-by: Rishabh Dave <ridave@redhat.com>
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
21 months agoMerge pull request #53556 from batrick/wip-62731-pacific
Yuri Weinstein [Wed, 15 Nov 2023 15:53:11 +0000 (07:53 -0800)]
Merge pull request #53556 from batrick/wip-62731-pacific

pacific: mds: add event for batching getattr/lookup

Reviewed-by: Rishabh Dave <ridave@redhat.com>
21 months agoMerge pull request #53555 from batrick/wip-62897-pacific
Yuri Weinstein [Wed, 15 Nov 2023 15:52:40 +0000 (07:52 -0800)]
Merge pull request #53555 from batrick/wip-62897-pacific

pacific: qa: lengthen shutdown timeout for thrashed MDS

Reviewed-by: Rishabh Dave <ridave@redhat.com>
21 months agoMerge pull request #53550 from batrick/wip-62902-pacific
Yuri Weinstein [Wed, 15 Nov 2023 15:51:56 +0000 (07:51 -0800)]
Merge pull request #53550 from batrick/wip-62902-pacific

pacific: mds: log message when exiting due to asok command

Reviewed-by: Rishabh Dave <ridave@redhat.com>
Reviewed-by: Christopher Hoffman <choffman@redhat.com>
21 months agoMerge pull request #53495 from lxbsz/wip-62859
Yuri Weinstein [Wed, 15 Nov 2023 15:51:08 +0000 (07:51 -0800)]
Merge pull request #53495 from lxbsz/wip-62859

pacific: mds: fix deadlock between unlinking and linkmerge

Reviewed-by: Rishabh Dave <ridave@redhat.com>
21 months agoMerge pull request #53486 from batrick/wip-62854-pacific
Yuri Weinstein [Wed, 15 Nov 2023 15:50:36 +0000 (07:50 -0800)]
Merge pull request #53486 from batrick/wip-62854-pacific

pacific: qa: ignore expected cluster warning from damage tests

Reviewed-by: Rishabh Dave <ridave@redhat.com>
21 months agoMerge pull request #53453 from joscollin/wip-62834-pacific
Yuri Weinstein [Wed, 15 Nov 2023 15:49:44 +0000 (07:49 -0800)]
Merge pull request #53453 from joscollin/wip-62834-pacific

pacific: cephfs-top: include the missing fields in --dump output

Reviewed-by: Rishabh Dave <ridave@redhat.com>
21 months agoos/bluestore: proper init sequent in BlueFS::mount() 54434/head
Igor Fedotov [Tue, 14 Nov 2023 13:49:28 +0000 (16:49 +0300)]
os/bluestore: proper init sequent in BlueFS::mount()

Requires in pacific backport only due to the lack of
https://github.com/ceph/ceph/pull/41557

Signed-off-by: Igor Fedotov <igor.fedotov@croit.io>
21 months agoMerge PR #52852 into pacific
Patrick Donnelly [Mon, 13 Nov 2023 14:46:16 +0000 (09:46 -0500)]
Merge PR #52852 into pacific

* refs/pull/52852/head:
mds: remove calculating caps after adding revokes back
test/libcephfs: add test case for revoking caps
client: issue a cap release immediately if no cap exists
mds: add the revoking caps back to _revokes list
mds: move confirm_receipt() to Capability.cc

Reviewed-by: Rishabh Dave <ridave@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
21 months agodoc/rados/configuration/bluestore-config-ref: Fix lowcase typo 54474/head
Adam Kupczyk [Fri, 3 Nov 2023 15:50:19 +0000 (16:50 +0100)]
doc/rados/configuration/bluestore-config-ref: Fix lowcase typo

Letters "L P" got lowcased to "l p".
Reverted that.

Signed-off-by: Adam Kupczyk <akupczyk@ibm.com>
(cherry picked from commit 59a7f01b5c3cc48aa1e15ee44204d3552ffd593a)

21 months agoqa: typo fix when checking for perf counter - s/md_thresh_evicted/mdthresh_evicted 53634/head
Venky Shankar [Mon, 9 Oct 2023 04:29:45 +0000 (09:59 +0530)]
qa: typo fix when checking for perf counter - s/md_thresh_evicted/mdthresh_evicted

Signed-off-by: Venky Shankar <vshankar@redhat.com>
(cherry picked from commit 5856a1e6b72dc77d3b4d9109385481b924e4fe36)

21 months agoqa: lower mds_session_metadata_threshold for tests
Venky Shankar [Sat, 7 Oct 2023 15:12:29 +0000 (20:42 +0530)]
qa: lower mds_session_metadata_threshold for tests

... and increase the number of files that are created so as to
hit the threshold with a high probability.

Fixes: http://tracker.ceph.com/issues/62873
Signed-off-by: Venky Shankar <vshankar@redhat.com>
(cherry picked from commit 92200d9d10d30ed35f640fd1120be65577a3ce64)

21 months agoPendingReleaseNotes: add a note for `mds_session_metadata_threshold` mds config
Venky Shankar [Thu, 17 Aug 2023 04:40:37 +0000 (10:10 +0530)]
PendingReleaseNotes: add a note for `mds_session_metadata_threshold` mds config

Signed-off-by: Venky Shankar <vshankar@redhat.com>
(cherry picked from commit ac3ab1a203ad65c7db07bc2c02acb5620800fb25)

21 months agotest: add test to verify that a buggy client is blocklisted
Venky Shankar [Fri, 11 Aug 2023 08:40:36 +0000 (04:40 -0400)]
test: add test to verify that a buggy client is blocklisted

... when its session metadata is bloated due to buildup of
`completed_requests`.

Signed-off-by: Venky Shankar <vshankar@redhat.com>
(cherry picked from commit 84df4b3d0c9e767a74cf5af80e8138239992df2c)

21 months agomds: add perf counter to track number of sessions evicted due to metadata threshold...
Venky Shankar [Mon, 21 Aug 2023 07:50:22 +0000 (03:50 -0400)]
mds: add perf counter to track number of sessions evicted due to metadata threshold being exceeded

Signed-off-by: Venky Shankar <vshankar@redhat.com>
(cherry picked from commit 59dd587ddb3bc95a95d0fb8715511d194181ec6f)

21 months agomds: blocklist clients with "bloated" session metadata
Venky Shankar [Fri, 11 Aug 2023 08:36:52 +0000 (04:36 -0400)]
mds: blocklist clients with "bloated" session metadata

Buggy clients (or maybe a MDS bug) causes a huge buildup of
`completed_requests` metadata in its session information.
This could cause the MDS to go read-only when its flushing
session metadata to the journal since the bloated metadata
causes the ODSOp payload to exceed the maximum write size.

Blocklist such clients so as to allow the MDS to continue
servicing requests.

Fixes: http://tracker.ceph.com/issues/61947
Signed-off-by: Venky Shankar <vshankar@redhat.com>
(cherry picked from commit bc6814d72a9fbec9c41ed75aee2314666cfca34b)

 Conflicts:
src/common/options/mds.yaml.in
src/mds/MDSRank.cc

Pacific uses old-style config file (src/common/options.cc), so
adjust to that.

21 months agoMerge pull request #54268 from ronen-fr/wip-63372-pacific
Yuri Weinstein [Thu, 9 Nov 2023 17:01:41 +0000 (09:01 -0800)]
Merge pull request #54268 from ronen-fr/wip-63372-pacific

pacific: osd: fix use-after-move in build_incremental_map_msg()

Reviewed-by: Laura Flores <lflores@redhat.com>
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
21 months agoMerge pull request #53662 from lxbsz/wip-62523
Yuri Weinstein [Thu, 9 Nov 2023 16:59:13 +0000 (08:59 -0800)]
Merge pull request #53662 from lxbsz/wip-62523

pacific: ceph: allow xlock state to be LOCK_PREXLOCK when putting it

Reviewed-by: Rishabh Dave <ridave@redhat.com>
21 months agoMerge pull request #53645 from vshankar/wip-61803-pacific
Yuri Weinstein [Thu, 9 Nov 2023 16:58:43 +0000 (08:58 -0800)]
Merge pull request #53645 from vshankar/wip-61803-pacific

pacific: cephfs-journal-tool: disambiguate usage of all keyword (in tool help).

Reviewed-by: Rishabh Dave <ridave@redhat.com>
21 months agoMerge pull request #53640 from vshankar/wip-62949-pacific
Yuri Weinstein [Thu, 9 Nov 2023 16:58:06 +0000 (08:58 -0800)]
Merge pull request #53640 from vshankar/wip-62949-pacific

pacific: cephfs-mirror: do not run concurrent C_RestartMirroring context

Reviewed-by: Rishabh Dave <ridave@redhat.com>
21 months agoMerge pull request #53362 from k0ste/wip-57110-pacific
Yuri Weinstein [Thu, 9 Nov 2023 16:57:30 +0000 (08:57 -0800)]
Merge pull request #53362 from k0ste/wip-57110-pacific

pacific: mds: replacing bootstrap session only if handle client session message

Reviewed-by: Rishabh Dave <ridave@redhat.com>
21 months agoMerge pull request #53270 from mchangir/wip-59001-pacific
Yuri Weinstein [Thu, 9 Nov 2023 16:57:03 +0000 (08:57 -0800)]
Merge pull request #53270 from mchangir/wip-59001-pacific

pacific: cephfs_mirror: correctly set top level dir permissions

Reviewed-by: Rishabh Dave <ridave@redhat.com>
21 months agoMerge pull request #53169 from leonid-s-usov/bp/cap-throttle-event/pacific
Yuri Weinstein [Thu, 9 Nov 2023 16:56:20 +0000 (08:56 -0800)]
Merge pull request #53169 from leonid-s-usov/bp/cap-throttle-event/pacific

pacific: mds/Server: mark a cap acquisition throttle event in the request

Reviewed-by: Rishabh Dave <ridave@redhat.com>
21 months agoos/bluestore: get rid off resulting lba alignment in allocators
Igor Fedotov [Fri, 15 Sep 2023 17:35:13 +0000 (20:35 +0300)]
os/bluestore: get rid off resulting lba alignment in allocators

Fixes: https://tracker.ceph.com/issues/62815
Signed-off-by: Igor Fedotov <igor.fedotov@croit.io>
(cherry picked from commit 5a98cdfdf932300b6e467e33f692c20a2f67f728)

 Conflicts:
src/os/bluestore/BtreeAllocator.cc
 * missong BtreeAllocator.cc

21 months agoos/bluestore: adjust and validate bluefs_shared_alloc_size
Igor Fedotov [Wed, 13 Sep 2023 13:51:16 +0000 (16:51 +0300)]
os/bluestore: adjust and validate bluefs_shared_alloc_size

Make sure it's in-sync (meaning it's higher or equal and properly aligned)
with bluestore_min_alloc_size into account

Signed-off-by: Igor Fedotov <igor.fedotov@croit.io>
(cherry picked from commit 33a87bda7f65a9c6d2f881cc0a69e1d98f21d14a)

21 months agoos/bluestore: dump bluefs alloc unit sizes with perf counters dump
Igor Fedotov [Wed, 24 Nov 2021 17:33:23 +0000 (20:33 +0300)]
os/bluestore: dump bluefs alloc unit sizes with perf counters dump

Signed-off-by: Igor Fedotov <igor.fedotov@croit.io>
(cherry picked from commit d17986306d23cfbf410434aaf789546707dd7dc9)

 Conflicts:
src/os/bluestore/BlueFS.cc
 * missed backports

21 months agoclient: always refresh mds feature bits on session open 54245/head
Venky Shankar [Mon, 16 Oct 2023 04:11:19 +0000 (00:11 -0400)]
client: always refresh mds feature bits on session open

Fixes: http://tracker.ceph.com/issues/63188
Signed-off-by: Venky Shankar <vshankar@redhat.com>
(cherry picked from commit 167fdd22e38d9febef8d7e0969403261314e3c98)

 Conflicts:
src/client/Client.cc

In pacific, the client would close the mds session if it has missing
features - adjust the code due to that. Also adjust for `session`
variable in Client::handle_client_session() as in pacific its of
type MetaSession* rather than MetaSesssionRef.

21 months agoMerge pull request #54294 from ajarr/wip-63385-pacific
Yuri Weinstein [Wed, 8 Nov 2023 21:37:59 +0000 (13:37 -0800)]
Merge pull request #54294 from ajarr/wip-63385-pacific

pacific: qa/suites/rbd: add test to check rbd_support module recovery

Reviewed-by: Mykola Golub <mgolub@suse.com>
Reviewed-by: Ilya Dryomov <idryomov@redhat.com>
21 months agoMerge pull request #54293 from ajarr/wip-63382-pacific
Yuri Weinstein [Wed, 8 Nov 2023 21:37:19 +0000 (13:37 -0800)]
Merge pull request #54293 from ajarr/wip-63382-pacific

pacific: mgr/rbd_support: fix recursive locking on CreateSnapshotRequests lock

Reviewed-by: Ilya Dryomov <idryomov@redhat.com>
Reviewed-by: Mykola Golub <mgolub@suse.com>
21 months agoMerge pull request #54256 from pkalever/wip-63351-pacific
Yuri Weinstein [Wed, 8 Nov 2023 21:36:35 +0000 (13:36 -0800)]
Merge pull request #54256 from pkalever/wip-63351-pacific

pacific: rbd-nbd: fix stuck with disable request

Reviewed-by: Mykola Golub <mgolub@suse.com>
Reviewed-by: Ilya Dryomov <idryomov@redhat.com>