]> git.apps.os.sepia.ceph.com Git - ceph.git/log
ceph.git
4 years agoMerge pull request #33996 from mdw-at-linuxbox/wip-master-kmip
Matt Benjamin [Fri, 5 Mar 2021 21:20:18 +0000 (16:20 -0500)]
Merge pull request #33996 from mdw-at-linuxbox/wip-master-kmip

rgw / kmip kms

4 years agoMerge PR #39817 into master
Sage Weil [Fri, 5 Mar 2021 20:33:50 +0000 (15:33 -0500)]
Merge PR #39817 into master

* refs/pull/39817/head:
qa/suites/rados/cephadm: drop centos/rhel cephadm tests for the moment
qa/sites/rados/cephadm/thrash: rename 3-tasks.yaml/ -> 3-tasks/
qa/suites/rados/cephadm: adjust distros
qa/suites/upgrade: use kubic; test all distros
qa/suites/rados/cephadm/upgrade: use kubic on centos
qa: new kubic distro files; use kubic podman for centos/rhel

Reviewed-by: Sebastian Wagner <swagner@suse.com>
4 years agoMerge PR #39855 into master
Sage Weil [Fri, 5 Mar 2021 20:33:38 +0000 (15:33 -0500)]
Merge PR #39855 into master

* refs/pull/39855/head:
qa/suites/rgw/singleton: add trivial cephadm case
Revert "rgw: register daemon in service map with more details"

Reviewed-by: Sebastian Wagner <swagner@suse.com>
4 years agoMerge pull request #39861 from tchaikov/wip-doc-theme
Josh Durgin [Fri, 5 Mar 2021 19:42:30 +0000 (11:42 -0800)]
Merge pull request #39861 from tchaikov/wip-doc-theme

doc/_theme: remove the spacing at top of "dl dt"

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
4 years agoMerge PR #39841 into master
Patrick Donnelly [Fri, 5 Mar 2021 19:34:14 +0000 (11:34 -0800)]
Merge PR #39841 into master

* refs/pull/39841/head:
qa: ignorelist slow ops during scrub

Reviewed-by: Rishabh Dave <ridave@redhat.com>
4 years agoMerge PR #38859 into master
Patrick Donnelly [Fri, 5 Mar 2021 19:33:08 +0000 (11:33 -0800)]
Merge PR #38859 into master

* refs/pull/38859/head:
mds: don't start purging inodes in the middle of recovery
mds: purge orphan objects created by lost async file creation
mds: track free prealloc_inos and delegated_inos separately
mds: cleanup code that purges orphan objects created by lost unsafe file creation
mds: subtract inos_to_purge from prealloc_inos when session close is logged
mds: use vector to define old_pools in PurgeItem and inode_backtrace_t

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
4 years agoMerge pull request #39838 from sebastian-philipp/doc-rm-cephadm-install
zdover23 [Fri, 5 Mar 2021 17:38:37 +0000 (03:38 +1000)]
Merge pull request #39838 from sebastian-philipp/doc-rm-cephadm-install

doc/install/index_manual: remove cephadm from toctree

Reviewed-by: Zac Dover <zac.dover@gmail.com>
4 years agodoc/_theme: remove the spacing at top of "dl dt" 39861/head
Kefu Chai [Fri, 5 Mar 2021 16:13:05 +0000 (00:13 +0800)]
doc/_theme: remove the spacing at top of "dl dt"

otherwise there is a margin-top on top of dt.

Signed-off-by: Kefu Chai <kchai@redhat.com>
4 years agoqa/suites/rgw/singleton: add trivial cephadm case 39855/head
Sage Weil [Fri, 5 Mar 2021 14:47:19 +0000 (09:47 -0500)]
qa/suites/rgw/singleton: add trivial cephadm case

Make sure we can deploy an rgw and not generate any warnings.

Signed-off-by: Sage Weil <sage@newdream.net>
4 years agoRevert "rgw: register daemon in service map with more details"
Sage Weil [Fri, 5 Mar 2021 14:40:59 +0000 (09:40 -0500)]
Revert "rgw: register daemon in service map with more details"

This reverts commit 46ec2f0ddd81b4b5b4a61633eada998dcd606c9b.

This broke cephadm (by triggering CEPHADM_STRAY_DAEMON) because cephadm
assumes that a daemon named rgw.r.z.foo will register as rgw.r.z.foo.

It is not clear to me that there is a way to work around this naming
mismatch that makes much sense.  I think it makes more sense to focus on
the use-case that needs daemons to register under unique names and perhaps
control that naming behavior via an option or invest in providing daemons
with unique ids up front.

Signed-off-by: Sage Weil <sage@newdream.net>
4 years agoMerge pull request #39813 from smithfarm/wip-49583
Nathan Cutler [Fri, 5 Mar 2021 13:28:08 +0000 (14:28 +0100)]
Merge pull request #39813 from smithfarm/wip-49583

rpm: disable parallel compression on SUSE

Reviewed-by: Kefu Chai <kchai@redhat.com>
4 years agoMerge pull request #39809 from sebastian-philipp/cephadm-compatibilty
Sebastian Wagner [Fri, 5 Mar 2021 11:20:33 +0000 (12:20 +0100)]
Merge pull request #39809 from sebastian-philipp/cephadm-compatibilty

doc/cephadm: remove warning about cephadm in production

Reviewed-by: Sage Weil <sage@redhat.com>
4 years agoMerge pull request #39639 from sebastian-philipp/cephadm-deploy-daemon-units-for...
Sebastian Wagner [Fri, 5 Mar 2021 09:43:39 +0000 (10:43 +0100)]
Merge pull request #39639 from sebastian-philipp/cephadm-deploy-daemon-units-for-existing-osds

mgr/cephadm: Activate existing OSDs

Reviewed-by: Michael Fritch <mfritch@suse.com>
4 years agoMerge pull request #39824 from batrick/nightly-partitions
Josh Durgin [Fri, 5 Mar 2021 02:15:56 +0000 (18:15 -0800)]
Merge pull request #39824 from batrick/nightly-partitions

qa: allow specifying partition size for nightlies

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: Yuri Weinstein <yweins@redhat.com>
4 years agoMerge pull request #39457 from tchaikov/wip-sphinx-rtd-theme
Kefu Chai [Fri, 5 Mar 2021 02:08:12 +0000 (10:08 +0800)]
Merge pull request #39457 from tchaikov/wip-sphinx-rtd-theme

doc: switch to sphinx_rtd_theme theme

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
4 years agoMerge pull request #39842 from liewegas/smoke-timeout
Neha Ojha [Fri, 5 Mar 2021 02:05:35 +0000 (18:05 -0800)]
Merge pull request #39842 from liewegas/smoke-timeout

src/test/smoke.sh: increase timeout

Reviewed-by: Neha Ojha <nojha@redhat.com>
4 years agoMerge pull request #39840 from rzarzynski/wip-crimson-notify_reply_t
Kefu Chai [Fri, 5 Mar 2021 02:05:13 +0000 (10:05 +0800)]
Merge pull request #39840 from rzarzynski/wip-crimson-notify_reply_t

crimson/osd: fix the serialization of notify_reply_t.

Reviewed-by: Kefu Chai <kchai@redhat.com>
4 years agodoc/_theme: customize sphinx_rtd_theme 39457/head
Kefu Chai [Sat, 13 Feb 2021 04:57:19 +0000 (12:57 +0800)]
doc/_theme: customize sphinx_rtd_theme

* move the breadcrumbs to the top
* add border around admonition elements
* use different colors and fonts for section headers
* add decoration lines at the bottom of breadcrumbs
* remove left and right borders in tables
* override the injected versions, the name of theme
  is different from "sphinx_rtd_theme", but the
  versions element is still displayed at the
  bottom-left corner as "versions.html" defines.
  without overriding .rst-badge CSS styling,
  readthedocs puts the injected versions at
  the default bottom-right corner, see
  https://github.com/readthedocs/readthedocs.org/blob/2a519f1146142d18f6a63b61c2f08984067280e0/readthedocs/api/v2/templates/restapi/footer.html

Signed-off-by: Kefu Chai <kchai@redhat.com>
4 years agoqa/suites/rados/cephadm: drop centos/rhel cephadm tests for the moment 39817/head
Sage Weil [Thu, 4 Mar 2021 18:33:12 +0000 (12:33 -0600)]
qa/suites/rados/cephadm: drop centos/rhel cephadm tests for the moment

...until we sort out the podman problems!  :( :(

Signed-off-by: Sage Weil <sage@newdream.net>
4 years agoqa/sites/rados/cephadm/thrash: rename 3-tasks.yaml/ -> 3-tasks/
Sage Weil [Thu, 4 Mar 2021 18:32:27 +0000 (12:32 -0600)]
qa/sites/rados/cephadm/thrash: rename 3-tasks.yaml/ -> 3-tasks/

Signed-off-by: Sage Weil <sage@newdream.net>
4 years agoqa/suites/rados/cephadm: adjust distros
Sage Weil [Thu, 4 Mar 2021 18:32:00 +0000 (12:32 -0600)]
qa/suites/rados/cephadm: adjust distros

Signed-off-by: Sage Weil <sage@newdream.net>
4 years agoqa/suites/upgrade: use kubic; test all distros
Sage Weil [Wed, 3 Mar 2021 14:23:56 +0000 (08:23 -0600)]
qa/suites/upgrade: use kubic; test all distros

Signed-off-by: Sage Weil <sage@newdream.net>
4 years agoqa/suites/rados/cephadm/upgrade: use kubic on centos
Sage Weil [Wed, 3 Mar 2021 14:18:19 +0000 (08:18 -0600)]
qa/suites/rados/cephadm/upgrade: use kubic on centos

Signed-off-by: Sage Weil <sage@newdream.net>
4 years agoqa: new kubic distro files; use kubic podman for centos/rhel
Sage Weil [Wed, 3 Mar 2021 14:14:29 +0000 (08:14 -0600)]
qa: new kubic distro files; use kubic podman for centos/rhel

The current centos/rhel version of podman (2.2.1) is broken.

- create new qa/distros/podman/* files that install kubic podman
- include centos/rhel variants
- adjust cephadm jobs to use new yaml files
- remove old qa/distros/all/*_podman.yaml files

Signed-off-by: Sage Weil <sage@newdream.net>
4 years agosrc/test/smoke.sh: increase timeout 39842/head
Sage Weil [Thu, 4 Mar 2021 23:34:00 +0000 (17:34 -0600)]
src/test/smoke.sh: increase timeout

Fixes: https://tracker.ceph.com/issues/47419
Signed-off-by: Sage Weil <sage@newdream.net>
4 years agoqa: schedule random subset 39824/head
Patrick Donnelly [Thu, 4 Mar 2021 21:01:01 +0000 (13:01 -0800)]
qa: schedule random subset

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
4 years agoqa: allow specifying partition size for nightlies
Patrick Donnelly [Wed, 3 Mar 2021 21:23:35 +0000 (13:23 -0800)]
qa: allow specifying partition size for nightlies

I did some visual cleanup too but mostly this changeset is to support
specifying subsets for each suite type. For now, only "fs" suite is
using partitions different from rados.

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
4 years agoMerge PR #39787 into master
Patrick Donnelly [Thu, 4 Mar 2021 21:33:14 +0000 (13:33 -0800)]
Merge PR #39787 into master

* refs/pull/39787/head:
qa: Update featureful_client suite to use octopus instead of nautilus

Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
4 years agoMerge PR #39724 into master
Patrick Donnelly [Thu, 4 Mar 2021 21:32:10 +0000 (13:32 -0800)]
Merge PR #39724 into master

* refs/pull/39724/head:
qa: skip exit-on-first-failure option for valgrind on ubuntu
mds,qa: exit instead of respawn under valgrind
qa: skip chdir for fuse_mount
qa: ignore all slow request warnings
qa: add new mds beacon grace mon config
qa: wait for MDS to join fsmap
qa: move get_valgrind_args to qa

Reviewed-by: Rishabh Dave <ridave@redhat.com>
4 years agoMerge PR #39354 into master
Patrick Donnelly [Thu, 4 Mar 2021 21:28:59 +0000 (13:28 -0800)]
Merge PR #39354 into master

* refs/pull/39354/head:
mds/client: create cephfs errno aliases

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
4 years agoMerge PR #38684 into master
Patrick Donnelly [Thu, 4 Mar 2021 21:27:45 +0000 (13:27 -0800)]
Merge PR #38684 into master

* refs/pull/38684/head:
qa: add _check_scrub_status helper to simplify the code
qa: add run_scrub helper in filesystem class
qa: add get_scrub_status helper in filesystem class
qa: wait the scrub task to complete
qa: remove passed_validation check for test_damage
qa: move wait_until_scrub_complete helper to filesystem class
mds: simplify the C_MDS_EnqueueScrub finish code

Reviewed-by: Rishabh Dave <ridave@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
4 years agoMerge pull request #39835 from yuriw/wip-yuriw-crontab-master
Yuri Weinstein [Thu, 4 Mar 2021 21:23:20 +0000 (13:23 -0800)]
Merge pull request #39835 from yuriw/wip-yuriw-crontab-master

qa/tests: moved nautilus and octopus tests to run on gibba and -p 70 …

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
4 years agoqa: ignorelist slow ops during scrub 39841/head
Patrick Donnelly [Thu, 4 Mar 2021 21:22:08 +0000 (13:22 -0800)]
qa: ignorelist slow ops during scrub

Fixes: https://tracker.ceph.com/issues/49607
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
4 years agoMerge PR #39832 into master
Sage Weil [Thu, 4 Mar 2021 21:08:14 +0000 (16:08 -0500)]
Merge PR #39832 into master

* refs/pull/39832/head:
mgr/DaemonServer: osd ok-to-stop: return json when there are unknown PGs

Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Sebastian Wagner <swagner@suse.com>
4 years agoMerge PR #39726 into master
Sage Weil [Thu, 4 Mar 2021 19:31:57 +0000 (14:31 -0500)]
Merge PR #39726 into master

* refs/pull/39726/head:
mgr/cephadm: document ok_to_stop output argument for clarity
mgr/DaemonServer: make warning language a bit friendlier
mgr/cephadm/upgrade: improve language a bit
mgr/cephadm/upgrade: restart multiple osds at once
mgr/cephadm: gather other osds that are safe to stop
mgr/cephadm: optional pass 'known' through to ok_to_stop
mgr/cephadm/upgrade: log start/stop/pause/resume

Reviewed-by: Sebastian Wagner <swagner@suse.com>
4 years agoMerge pull request #38741 from BryceCao/wip-standardize-request
Harish Munjulur [Thu, 4 Mar 2021 19:07:17 +0000 (11:07 -0800)]
Merge pull request #38741 from BryceCao/wip-standardize-request

rgw : add the check for bucket handler if http args exist object_exclusive sub_resource

4 years agoMerge pull request #39790 from yuvalif/wip-yuval-fix-49557
Harish Munjulur [Thu, 4 Mar 2021 19:05:30 +0000 (11:05 -0800)]
Merge pull request #39790 from yuvalif/wip-yuval-fix-49557

rgw/notification: fix persistent notification hang when ack-levl=none

4 years agoMerge pull request #39782 from yuvalif/wip-yuval-fix-49552
Harish Munjulur [Thu, 4 Mar 2021 19:05:14 +0000 (11:05 -0800)]
Merge pull request #39782 from yuvalif/wip-yuval-fix-49552

rgw/notification: fixing the "persistent=false" flag

4 years agoMerge pull request #39515 from CloudFerro/gc_max_objs
Harish Munjulur [Thu, 4 Mar 2021 19:03:56 +0000 (11:03 -0800)]
Merge pull request #39515 from CloudFerro/gc_max_objs

rgw: limit rgw_gc_max_objs to RGW_SHARDS_PRIME_1

4 years agoMerge pull request #39380 from leseb/rgw-svc-map-name
Harish Munjulur [Thu, 4 Mar 2021 19:03:19 +0000 (11:03 -0800)]
Merge pull request #39380 from leseb/rgw-svc-map-name

rgw: register daemon in service map with more details

4 years agoqa/tests: moved nautilus and octopus tests to run on gibba and -p 70 for smoke tests 39835/head
Yuri Weinstein [Thu, 4 Mar 2021 16:40:40 +0000 (08:40 -0800)]
qa/tests: moved nautilus and octopus tests to run on gibba and -p 70 for smoke tests

Signed-off-by: Yuri Weinstein <yweinste@redhat.com>
4 years agocrimson/osd: fix the serialization of notify_reply_t. 39840/head
Radoslaw Zarzynski [Thu, 4 Mar 2021 18:13:52 +0000 (18:13 +0000)]
crimson/osd: fix the serialization of notify_reply_t.

The `LibRadosWatchNotify.WatchNotify2` was expecting
data in the very raw form:

```cpp
  std::map<std::pair<uint64_t,uint64_t>, bufferlist> reply_map;
  std::set<std::pair<uint64_t,uint64_t> > missed_map;
  auto reply_p = reply.cbegin();
  decode(reply_map, reply_p);
  decode(missed_map, reply_p);
```

while the serialization of `notify_reply_t` was appending
extra preamable with versioning data.

This was the root cause of the following problem:
```
2021-03-04T15:40:03.001 INFO:tasks.workunit.client.0.smithi058.stdout:         api_watch_notify: Running main() from gmock_main.cc
2021-03-04T15:40:03.001 INFO:tasks.workunit.client.0.smithi058.stdout:         api_watch_notify: [==========] Running 11 tests from 2 test suites.
2021-03-04T15:40:03.002 INFO:tasks.workunit.client.0.smithi058.stdout:         api_watch_notify: [----------] Global test environment set-up.
2021-03-04T15:40:03.002 INFO:tasks.workunit.client.0.smithi058.stdout:         api_watch_notify: [----------] 10 tests from LibRadosWatchNotify
2021-03-04T15:40:03.002 INFO:tasks.workunit.client.0.smithi058.stdout:         api_watch_notify: [ RUN      ] LibRadosWatchNotify.WatchNotify
2021-03-04T15:40:03.002 INFO:tasks.workunit.client.0.smithi058.stdout:         api_watch_notify: watch_notify_test_cb
2021-03-04T15:40:03.003 INFO:tasks.workunit.client.0.smithi058.stdout:         api_watch_notify: [       OK ] LibRadosWatchNotify.WatchNotify (744 ms)
2021-03-04T15:40:03.003 INFO:tasks.workunit.client.0.smithi058.stdout:         api_watch_notify: [ RUN      ] LibRadosWatchNotify.Watch2Delete
2021-03-04T15:40:03.003 INFO:tasks.workunit.client.0.smithi058.stdout:         api_watch_notify: waiting up to 300 for disconnect notification ...
2021-03-04T15:40:03.003 INFO:tasks.workunit.client.0.smithi058.stdout:         api_watch_notify: watch_notify2_test_errcb cookie 94023196839536 err -107
2021-03-04T15:40:03.004 INFO:tasks.workunit.client.0.smithi058.stdout:         api_watch_notify: [       OK ] LibRadosWatchNotify.Watch2Delete (3123 ms)
2021-03-04T15:40:03.004 INFO:tasks.workunit.client.0.smithi058.stdout:         api_watch_notify: [ RUN      ] LibRadosWatchNotify.AioWatchDelete
2021-03-04T15:40:03.004 INFO:tasks.workunit.client.0.smithi058.stdout:         api_watch_notify: waiting up to 300 for disconnect notification ...
2021-03-04T15:40:03.004 INFO:tasks.workunit.client.0.smithi058.stdout:         api_watch_notify: watch_notify2_test_errcb cookie 94023196851488 err -107
2021-03-04T15:40:03.005 INFO:tasks.workunit.client.0.smithi058.stdout:         api_watch_notify: [       OK ] LibRadosWatchNotify.AioWatchDelete (5086 ms)
2021-03-04T15:40:03.005 INFO:tasks.workunit.client.0.smithi058.stdout:         api_watch_notify: [ RUN      ] LibRadosWatchNotify.WatchNotify2
2021-03-04T15:40:03.005 INFO:tasks.workunit.client.0.smithi058.stdout:         api_watch_notify: watch_notify2_test_cb from 4394 notify_id 120259084288 cookie 94023196869248
2021-03-04T15:40:03.005 INFO:tasks.workunit.client.0.smithi058.stdout:         api_watch_notify: unknown file: Failure
2021-03-04T15:40:03.006 INFO:tasks.workunit.client.0.smithi058.stdout:         api_watch_notify: C++ exception with description "End of buffer" thrown in the test body.```

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
4 years agocrimson/osd: improve debugs around sending notify_reply_t.
Radoslaw Zarzynski [Thu, 4 Mar 2021 18:10:43 +0000 (18:10 +0000)]
crimson/osd: improve debugs around sending notify_reply_t.

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
4 years agodoc/install/index_manual: remove cephadm from toctree 39838/head
Sebastian Wagner [Thu, 4 Mar 2021 17:18:33 +0000 (18:18 +0100)]
doc/install/index_manual: remove cephadm from toctree

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
4 years agomgr/cephadm: document ok_to_stop output argument for clarity 39726/head
Sage Weil [Thu, 4 Mar 2021 17:01:28 +0000 (12:01 -0500)]
mgr/cephadm: document ok_to_stop output argument for clarity

Signed-off-by: Sage Weil <sage@newdream.net>
4 years agoMerge PR #39823 into master
Sage Weil [Thu, 4 Mar 2021 16:41:28 +0000 (11:41 -0500)]
Merge PR #39823 into master

* refs/pull/39823/head:
qa/tasks/cephadm: remove mirror code

Reviewed-by: Sebastian Wagner <swagner@suse.com>
4 years agoMerge pull request #39822 from mgfritch/cephadm-custom-container-sample
Sebastian Wagner [Thu, 4 Mar 2021 15:23:26 +0000 (16:23 +0100)]
Merge pull request #39822 from mgfritch/cephadm-custom-container-sample

cephadm: split custom container args into argv

Reviewed-by: Sebastian Wagner <sebastian.wagner@suse.com>
4 years agoMerge pull request #39699 from mgfritch/cephadm-bin-flake8-quotes
Sebastian Wagner [Thu, 4 Mar 2021 14:59:07 +0000 (15:59 +0100)]
Merge pull request #39699 from mgfritch/cephadm-bin-flake8-quotes

cephadm: introduce flake8 and flake8-quotes

Reviewed-by: Juan Miguel Olmo Martínez <jolmomar@redhat.com>
4 years agomgr/DaemonServer: osd ok-to-stop: return json when there are unknown PGs 39832/head
Sage Weil [Thu, 4 Mar 2021 13:35:24 +0000 (08:35 -0500)]
mgr/DaemonServer: osd ok-to-stop: return json when there are unknown PGs

In 791952cc01201010f298033003ba52374cc0159f we switched to return JSON
both on success and fail to describe which PGs are affected or are blocking
the ability to stop/restart OSDs.  Do the same for the case where
some PG states are unknown (i.e., just after a mgr restart) so that
the cephadm upgrade process can unconditionally expect a JSON result.

Signed-off-by: Sage Weil <sage@newdream.net>
4 years agoqa/tasks/cephadm: remove mirror code 39823/head
Sage Weil [Wed, 3 Mar 2021 18:35:07 +0000 (12:35 -0600)]
qa/tasks/cephadm: remove mirror code

This is being done from ansible now.  Also, it breaks when
the conf file has unqualified-search-registries but not 'registry'
entries.

Signed-off-by: Sage Weil <sage@newdream.net>
4 years agoMerge pull request #39831 from xxhdx1985126/wip-crimson-io-sequencer-bug
Kefu Chai [Thu, 4 Mar 2021 13:10:36 +0000 (21:10 +0800)]
Merge pull request #39831 from xxhdx1985126/wip-crimson-io-sequencer-bug

crimson/osd: do not pass lvalue of the lambda to seastar::futurize_invoke

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
4 years agoMerge pull request #39656 from pritha-srivastava/wip-rgw-sts-user-fix
Matt Benjamin [Thu, 4 Mar 2021 12:57:58 +0000 (07:57 -0500)]
Merge pull request #39656 from pritha-srivastava/wip-rgw-sts-user-fix

rgw/sts: fix for encoding/decoding user namespace

4 years agoMerge pull request #39452 from rhcs-dashboard/wip-49283-master
Ernesto Puerta [Thu, 4 Mar 2021 12:53:06 +0000 (13:53 +0100)]
Merge pull request #39452 from rhcs-dashboard/wip-49283-master

mgr/dashboard: report mgr fsid

Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
4 years agocrimson/osd: do not pass lvalue of the lambda to seastar::futurize_invoke 39831/head
Xuehan Xu [Thu, 4 Mar 2021 12:29:57 +0000 (20:29 +0800)]
crimson/osd: do not pass lvalue of the lambda to seastar::futurize_invoke

Signed-off-by: Xuehan Xu <xxhdx1985126@gmail.com>
4 years agoMerge pull request #39815 from sebastian-philipp/github-cephadm-minor
Kefu Chai [Thu, 4 Mar 2021 11:06:08 +0000 (19:06 +0800)]
Merge pull request #39815 from sebastian-philipp/github-cephadm-minor

.github: Minor cephadm changes

Reviewed-by: Kefu Chai <kchai@redhat.com>
4 years agodoc: import layout.html from sphinx_rtd_theme
Kefu Chai [Sat, 13 Feb 2021 03:45:13 +0000 (11:45 +0800)]
doc: import layout.html from sphinx_rtd_theme

so we can customize it later

Signed-off-by: Kefu Chai <kchai@redhat.com>
4 years agodoc: switch to sphinx_rtd_theme
Kefu Chai [Sat, 13 Feb 2021 03:23:23 +0000 (11:23 +0800)]
doc: switch to sphinx_rtd_theme

Signed-off-by: Kefu Chai <kchai@redhat.com>
4 years agoMerge pull request #39827 from xxhdx1985126/wip-crimson-minor-bugs
Kefu Chai [Thu, 4 Mar 2021 10:33:25 +0000 (18:33 +0800)]
Merge pull request #39827 from xxhdx1985126/wip-crimson-minor-bugs

crimson/osd: capture error_code by value in PG::handle_failed_op

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Reviewed-by: Xuehan Xu <xxhdx1985126@gmail.com>
4 years agoMerge pull request #39812 from rzarzynski/wip-crimson-admin-config-help
Kefu Chai [Thu, 4 Mar 2021 09:45:16 +0000 (17:45 +0800)]
Merge pull request #39812 from rzarzynski/wip-crimson-admin-config-help

crimson/admin: add support for 'config help'

Reviewed-by: Kefu Chai <kchai@redhat.com>
4 years agocrimson/osd: capture error_code by value in PG::handle_failed_op 39827/head
Xuehan Xu [Thu, 4 Mar 2021 09:20:28 +0000 (17:20 +0800)]
crimson/osd: capture error_code by value in PG::handle_failed_op

Signed-off-by: Xuehan Xu <xxhdx1985126@gmail.com>
4 years agoMerge pull request #39801 from rhcs-dashboard/49574-fix-pyjwt
Ernesto Puerta [Thu, 4 Mar 2021 08:53:42 +0000 (09:53 +0100)]
Merge pull request #39801 from rhcs-dashboard/49574-fix-pyjwt

mgr/dashboard: fix issues related with PyJWT versions >=2.0.0

Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
4 years agoMerge pull request #39755 from smithfarm/wip-49550
Nathan Cutler [Thu, 4 Mar 2021 08:29:47 +0000 (09:29 +0100)]
Merge pull request #39755 from smithfarm/wip-49550

rpm: use PMDK system libraries on SUSE

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
Reviewed-by: Mykola Golub <mgolub@suse.com>
4 years agoMerge PR #39799 into master
Patrick Donnelly [Thu, 4 Mar 2021 04:05:22 +0000 (20:05 -0800)]
Merge PR #39799 into master

* refs/pull/39799/head:
doc: update affiliation for myoungwon

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
4 years agodoc: update affiliation for myoungwon 39799/head
myoungwon oh [Wed, 3 Mar 2021 06:05:05 +0000 (15:05 +0900)]
doc: update affiliation for myoungwon

Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com>
4 years agorgw/kms/kmip - document configuration for a new feature: kmip kms 33996/head
Marcus Watts [Wed, 3 Feb 2021 19:26:46 +0000 (14:26 -0500)]
rgw/kms/kmip - document configuration for a new feature: kmip kms

I've written up a brief description of using kmip
with ceph.  Major features:
* ceph configuration.
* making keys with a "paste-in" python script.
* pointers to PyKMIP and IBM SKLM.

Signed-off-by: Marcus Watts <mwatts@redhat.com>
4 years agorgw/kms/kmip - rgw / kmip test integration.
Marcus Watts [Wed, 18 Nov 2020 19:37:31 +0000 (14:37 -0500)]
rgw/kms/kmip - rgw / kmip test integration.

Actually add kmip to the kms crypt suite.

This also makes some ssl certs which is required for use of kmip.

Signed-off-by: Marcus Watts <mwatts@redhat.com>
4 years agorgw/kms/kmip - rgw / kmip test integration.
Marcus Watts [Thu, 12 Nov 2020 03:38:18 +0000 (22:38 -0500)]
rgw/kms/kmip - rgw / kmip test integration.

s3tests needs to know key names in order to run kms tests.
It seems desirable to have s3tests default to discovering
the names that were created by the pykmip task, and that
if there is more than one rgw connected to more than one
pykmip, that names belonging to the appropriate pykmip
instance should be used.

This logic does the following:
rgw task: save pykmip role name.
s3tests task: set kms_key (and kms_keyid2) to
these in order of priority
1 s3tests client task property ['kms_key'] (or ['kms_key2'])
2 first (second) secret created in the matching pykmip instance.
3 testkey-1 (testkey-2)

For case 2, names from the secrets have an initial "token-" stripped from them.
The assumption here is that rgw is being run with a setting such as
rgw crypt kmip kms key template: pykmip-$keyid
therefore "pykmip-" will be prefixed back onto the key before use.

Signed-off-by: Marcus Watts <mwatts@redhat.com>
4 years agorgw/kms/kmip - rgw / kmip test integration.
Marcus Watts [Tue, 3 Nov 2020 23:17:28 +0000 (18:17 -0500)]
rgw/kms/kmip - rgw / kmip test integration.

Pass endpoint configuration from pykmip to radosgw at runtime.

Signed-off-by: Marcus Watts <mwatts@redhat.com>
4 years agorgw/kms/kmip - correct documentation.
Marcus Watts [Thu, 29 Oct 2020 16:04:36 +0000 (12:04 -0400)]
rgw/kms/kmip - correct documentation.

The pykmip task should be after ceph, and before rgw.

kmip needs ssl certs in order to function correctly.
Because the openssl_keys task has an indeterminate
order of execution, it is best to create the ca as
a separate task.  The ca can be shared with rgw, but
real life deployments of kmip are likely to have their
own CA.

In order to create kmip secrets, a client certificate
is necessary, so must be supplied to the pykmip task.

Signed-off-by: Marcus Watts <mwatts@redhat.com>
4 years agorgw/kms/kmip - pykmip.py needs to make keys too.
Marcus Watts [Thu, 29 Oct 2020 03:40:58 +0000 (23:40 -0400)]
rgw/kms/kmip - pykmip.py needs to make keys too.

The logic to deploy pykmip in teuthology was not complete.
The necessary logic to add kmip keys was missing.

Existing logic for other key services providers could use rest based
protocols directly from the teuthology host.  For kmip, it is necessary
to use a special protocol, and it is more convenient to run this directly
on the pykmip server.

Signed-off-by: Marcus Watts <mwatts@redhat.com>
4 years agorgw/kms/kmip - pykmip.py should actually run pykmip.
Marcus Watts [Tue, 27 Oct 2020 21:16:14 +0000 (17:16 -0400)]
rgw/kms/kmip - pykmip.py should actually run pykmip.

The logic to deploy pykmip in teuthology was not complete.
While it deployed all the code and certs to run pykmip,
it didn't actually run it.  This commit fixes that.

Signed-off-by: Marcus Watts <mwatts@redhat.com>
4 years agorgw/kms/kmip - python3 changes for testing.
Marcus Watts [Fri, 23 Oct 2020 23:07:09 +0000 (19:07 -0400)]
rgw/kms/kmip - python3 changes for testing.

python3 requires different imports and there's a different
way to get at the first element in a view.
This is to match changes introduced in the rest of ceph in these
commits: 24e7acc261a4 d7258ea7fdcd

Signed-off-by: Marcus Watts <mwatts@redhat.com>
4 years agorgw/kms/kmip - string handling cleanup.
Marcus Watts [Thu, 22 Oct 2020 05:31:05 +0000 (01:31 -0400)]
rgw/kms/kmip - string handling cleanup.

Use string::data and string_view to clean up some string handling,
as suggested by reviewers.

Signed-off-by: Marcus Watts <mwatts@redhat.com>
4 years agoteuthology/rgw: pykmip task
Marcus Watts [Sun, 1 Mar 2020 06:44:14 +0000 (01:44 -0500)]
teuthology/rgw: pykmip task

Configure and run a simple pykmip daemon,
similar in concept to barbican | vault.

Signed-off-by: Marcus Watts <mwatts@redhat.com>
4 years agokmip: first pass at implementation logic.
Marcus Watts [Sun, 16 Feb 2020 02:08:29 +0000 (21:08 -0500)]
kmip: first pass at implementation logic.

This implements SSE-KMS for the radosgw using kmip.
This uses symmetric raw keys with a name attribute in kmip,
so providing the same functionality as the "kv" key store
in hashicorp vault.

Signed-off-by: Marcus Watts <mwatts@redhat.com>
4 years agokmip: configuration options.
Marcus Watts [Wed, 12 Feb 2020 10:58:31 +0000 (05:58 -0500)]
kmip: configuration options.

First pass at configuration configuration for kmip.

Signed-off-by: Marcus Watts <mwatts@redhat.com>
4 years agoIncluding cmake build logic inside of libkmip.
Marcus Watts [Wed, 12 Feb 2020 10:57:46 +0000 (05:57 -0500)]
Including cmake build logic inside of libkmip.

Signed-off-by: Marcus Watts <mwatts@redhat.com>
4 years agocmake glue to build libkmip.
Marcus Watts [Wed, 12 Feb 2020 10:55:40 +0000 (05:55 -0500)]
cmake glue to build libkmip.

Signed-off-by: Marcus Watts <mwatts@redhat.com>
4 years agoAdded libkmip as a submodule.
Marcus Watts [Wed, 12 Feb 2020 10:54:36 +0000 (05:54 -0500)]
Added libkmip as a submodule.

Signed-off-by: Marcus Watts <mwatts@redhat.com>
4 years agocephadm: split custom container args into argv 39822/head
Michael Fritch [Wed, 3 Mar 2021 20:00:32 +0000 (13:00 -0700)]
cephadm: split custom container args into argv

introduced by usage of `shlex` in 3ea514c5

Fixes: https://tracker.ceph.com/issues/49590
Signed-off-by: Michael Fritch <mfritch@suse.com>
4 years agorpm: use PMDK system libraries on SUSE 39755/head
Nathan Cutler [Mon, 1 Mar 2021 11:07:29 +0000 (12:07 +0100)]
rpm: use PMDK system libraries on SUSE

As of a49d1dbb32e2436ff2836a85b2fa84418f0a5fff, when the rbd_rwl_cache and
rbd_ssd_cache bconds are enabled and WITH_SYSTEM_PMDK is disabled (as it is by
default), the RPM build attempts to

    git clone https://github.com/ceph/pmdk.git

but of course that won't work in the OBS, where the build workers have no
Internet connectivity.

Fortunately, the openSUSE/SLE versions targeted by Ceph master and pacific ship
the necessary PMDK libraries as RPM packages.

Fixes: a49d1dbb32e2436ff2836a85b2fa84418f0a5fff
Fixes: https://tracker.ceph.com/issues/49550
Signed-off-by: Nathan Cutler <ncutler@suse.com>
4 years agoMerge pull request #39765 from smithfarm/wip-ncpus-for-obs
Nathan Cutler [Wed, 3 Mar 2021 19:44:20 +0000 (20:44 +0100)]
Merge pull request #39765 from smithfarm/wip-ncpus-for-obs

rpm: set build parallelism from memory on SUSE

Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: David Galloway <dgallowa@redhat.com>
4 years agoMerge PR #39682 into master
Patrick Donnelly [Wed, 3 Mar 2021 18:05:35 +0000 (10:05 -0800)]
Merge PR #39682 into master

* refs/pull/39682/head:
vstart_runner: remove duplicate methods from LocalCephManager

Reviewed-by: Xiubo Li <xiubli@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
4 years agoMerge PR #39780 into master
Patrick Donnelly [Wed, 3 Mar 2021 18:04:23 +0000 (10:04 -0800)]
Merge PR #39780 into master

* refs/pull/39780/head:
qa/vstart_runner: dont log "not Ceph bin" msg too often

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Xiubo Li <xiubli@redhat.com>
4 years agoMerge PR #39681 into master
Patrick Donnelly [Wed, 3 Mar 2021 18:02:41 +0000 (10:02 -0800)]
Merge PR #39681 into master

* refs/pull/39681/head:
vstart_runner: define path to ceph binary and use it

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Xiubo Li <xiubli@redhat.com>
4 years agoqa: skip exit-on-first-failure option for valgrind on ubuntu 39724/head
Patrick Donnelly [Wed, 3 Mar 2021 03:43:15 +0000 (19:43 -0800)]
qa: skip exit-on-first-failure option for valgrind on ubuntu

The valgrind version is too old.

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
4 years agomds,qa: exit instead of respawn under valgrind
Patrick Donnelly [Wed, 3 Mar 2021 03:39:09 +0000 (19:39 -0800)]
mds,qa: exit instead of respawn under valgrind

valgrind can't handle execve of /proc/self/exe:

    2021-02-27T05:52:37.813 INFO:tasks.ceph.mds.d.smithi073.stderr:==00:01:03:20.556 41218== execve(0x18546740(/proc/self/exe), 0x18546670, 0x133ef310) failed, errno 2
    2021-02-27T05:52:37.813 INFO:tasks.ceph.mds.d.smithi073.stderr:==00:01:03:20.556 41218== EXEC FAILED: I can't recover from execve() failing, so I'm dying.
    2021-02-27T05:52:37.813 INFO:tasks.ceph.mds.d.smithi073.stderr:==00:01:03:20.556 41218== Add more stringent tests in PRE(sys_execve), or work out how to recover.

So configure the MDS to just exit so it can be restarted by QA infra (the
daemon watchdog).

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
4 years agoqa: skip chdir for fuse_mount
Patrick Donnelly [Wed, 3 Mar 2021 02:45:01 +0000 (18:45 -0800)]
qa: skip chdir for fuse_mount

The use of chdir will muck up the use of nsenter with valgrind:

    2021-03-03T02:13:49.897 DEBUG:teuthology.orchestra.run.smithi144:> sudo nsenter --net=/var/run/netns/ceph-ns--home-ubuntu-cephtest-mnt.0 cd /home/ubuntu/cephtest && sudo adjust-ulimits ceph-coverage /home/ubuntu/cephtest/archive/coverage daemon-helper term env 'OPENSSL_ia32cap=~0x1000000000000000' valgrind --trace-children=no --child-silent-after-fork=yes '--soname-synonyms=somalloc=*tcmalloc*' --num-callers=50 --suppressions=/home/ubuntu/cephtest/valgrind.supp --xml=yes --xml-file=/var/log/ceph/valgrind/client.0.log --time-stamp=yes --vgdb=yes --exit-on-first-error=yes --error-exitcode=42 --tool=memcheck --leak-check=full --show-reachable=yes ceph-fuse -f --admin-socket '/var/run/ceph/$cluster-$name.$pid.asok' --id 0 /home/ubuntu/cephtest/mnt.0
    2021-03-03T02:13:49.899 DEBUG:teuthology.orchestra.run.smithi144:> sudo modprobe fuse
    2021-03-03T02:13:49.914 INFO:teuthology.orchestra.run:Running command with timeout 30
    2021-03-03T02:13:49.914 DEBUG:teuthology.orchestra.run.smithi144:> sudo mount -t fusectl /sys/fs/fuse/connections /sys/fs/fuse/connections
    2021-03-03T02:13:49.919 INFO:tasks.cephfs.fuse_mount.ceph-fuse.0.smithi144.stderr:nsenter: failed to execute cd: No such file or directory

It's not necessary to chdir at all to do the mount, so don't.

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
4 years agoqa: ignore all slow request warnings
Patrick Donnelly [Mon, 1 Mar 2021 20:11:56 +0000 (12:11 -0800)]
qa: ignore all slow request warnings

Generalize the ignorelist for:

    2021-02-27T05:54:27.644 INFO:teuthology.orchestra.run.smithi002.stdout:2021-02-27T05:20:24.513041+0000 mds.d (mds.0) 1 : cluster [WRN] 1 slow requests, 1 included below; oldest blocked for > 183.680676 secs

From: /ceph/teuthology-archive/pdonnell-2021-02-26_23:40:39-fs-wip-pdonnell-testing-20210226.181017-distro-basic-smithi/5917580/teuthology.log

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
4 years agoqa: add new mds beacon grace mon config
Patrick Donnelly [Fri, 26 Feb 2021 16:52:48 +0000 (08:52 -0800)]
qa: add new mds beacon grace mon config

Otherwise the mons don't observe it.

Fixes: https://tracker.ceph.com/issues/49507
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
4 years agoqa: wait for MDS to join fsmap
Patrick Donnelly [Tue, 2 Mar 2021 23:07:39 +0000 (15:07 -0800)]
qa: wait for MDS to join fsmap

When running under valgrind, MDS may be slow to be added to the FSMap
(especially if mons are in valgrind too). The file system creation that
follows will throw unnecessary warnings about insufficient standbys if
no MDS is available.

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
4 years agoqa: move get_valgrind_args to qa
Patrick Donnelly [Wed, 3 Mar 2021 02:38:36 +0000 (18:38 -0800)]
qa: move get_valgrind_args to qa

This method is unused in the teuthology repo. The helper method better
belongs here where it is more easily modified.

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
4 years agoMerge pull request #39382 from gauravsitlani/master
Casey Bodley [Wed, 3 Mar 2021 17:13:16 +0000 (12:13 -0500)]
Merge pull request #39382 from gauravsitlani/master

rgw: added missing documentation on "pubsub" in rgw_enable_apis

Reviewed-by: Yuval Lifshitz <ylifshit@redhat.com>
Reviewed-by: Casey Bodley <cbodley@redhat.com>
4 years agoMerge pull request #39762 from smithfarm/wip-support-leap-15.3
Nathan Cutler [Wed, 3 Mar 2021 17:05:07 +0000 (18:05 +0100)]
Merge pull request #39762 from smithfarm/wip-support-leap-15.3

rpm/luarocks: simplify conditional and support Leap 15.3

Reviewed-by: Yuval Lifshitz <ylifshit@redhat.com>
Reviewed-by: Kyr Shatskyy <kyrylo.shatskyy@suse.de>
4 years agocephadm: fixup `alrady` -> `already` 39699/head
Michael Fritch [Thu, 25 Feb 2021 15:12:46 +0000 (08:12 -0700)]
cephadm: fixup `alrady` -> `already`

Signed-off-by: Michael Fritch <mfritch@suse.com>
4 years agocephadm: Change outer quotes to avoid escaping inner quotes (Q003)
Michael Fritch [Thu, 25 Feb 2021 15:12:37 +0000 (08:12 -0700)]
cephadm: Change outer quotes to avoid escaping inner quotes (Q003)

Signed-off-by: Michael Fritch <mfritch@suse.com>
4 years agocephadm: Remove bad quotes from multiline string (Q001)
Michael Fritch [Thu, 25 Feb 2021 15:12:24 +0000 (08:12 -0700)]
cephadm: Remove bad quotes from multiline string (Q001)

Signed-off-by: Michael Fritch <mfritch@suse.com>
4 years agocephadm: Remove bad quotes (Q000)
Michael Fritch [Wed, 24 Feb 2021 20:50:33 +0000 (13:50 -0700)]
cephadm: Remove bad quotes (Q000)

Signed-off-by: Michael Fritch <mfritch@suse.com>
4 years agocephadm: introduce flake8-quotes
Michael Fritch [Wed, 24 Feb 2021 20:48:37 +0000 (13:48 -0700)]
cephadm: introduce flake8-quotes

Signed-off-by: Michael Fritch <mfritch@suse.com>
4 years agocephadm: line break after binary operator (W504)
Michael Fritch [Fri, 19 Feb 2021 15:09:49 +0000 (08:09 -0700)]
cephadm: line break after binary operator (W504)

Signed-off-by: Michael Fritch <mfritch@suse.com>