]>
git.apps.os.sepia.ceph.com Git - ceph.git/log
Jan Fajerski [Mon, 9 Nov 2020 13:10:36 +0000 (14:10 +0100)]
Merge PR #32777 into master
* refs/pull/32777/head:
common,log,msg: Fix win32 compiler warnings
win32,common: provide a default ceph.conf location
common: add newline before parsing config on Windows
common: verify unix sockets support on Windows
common: fix md_config_t::get_cluster_name
global, common: Print config parse errors
common: accept config files containing whitespaces
librbd: avoid broken mingw rng
common: define DEV_NULL
tools,common,msg: Use O_BINARY for win32 compatibility
log: fix timestamps on Windows
common,librbd: add portable ceph_memzero_s
common,msg: Fix socket handling
common: Extend win32 compatbility layer
Reviewed-by: Jason Dillaman <dillaman@redhat.com>
Kefu Chai [Mon, 9 Nov 2020 13:08:13 +0000 (21:08 +0800)]
Merge pull request #37984 from tchaikov/wip-fio
cmake: drop WITH_SYSTEM_FIO option
Reviewed-by: Igor Fedotov <ifedotov@suse.com>
Lenz Grimmer [Mon, 9 Nov 2020 12:37:55 +0000 (13:37 +0100)]
Merge pull request #37965 from rhcs-dashboard/about-modal-cleanup
mgr/dashboard: Moving copyright variable into the app.constants
Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Kiefer Chang <kiefer.chang@suse.com>
Reviewed-by: Tatjana Dehler <tdehler@suse.com>
Jason Dillaman [Mon, 9 Nov 2020 12:14:43 +0000 (07:14 -0500)]
Merge pull request #37958 from ronen-fr/wip-ronenf-librbd-move1
librbd: removing a "pessimizing move"
Reviewed-by: Jason Dillaman <dillaman@redhat.com>
Kefu Chai [Mon, 9 Nov 2020 12:10:05 +0000 (20:10 +0800)]
Merge pull request #37990 from tchaikov/wip-liburing-fPIC
cmake: build liburing with -fPIC
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Gregory Farnum [Mon, 9 Nov 2020 11:52:07 +0000 (03:52 -0800)]
Merge pull request #37915 from gregsfortytwo/wip-stretch-fixes
Fix several stretch mode issues
Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
Jan Fajerski [Mon, 9 Nov 2020 10:33:18 +0000 (11:33 +0100)]
Merge PR #37741 into master
* refs/pull/37741/head:
ceph-volume: remove mention of dmcache from docs and help text
Reviewed-by: Jan Fajerski <jfajerski@suse.com>
Reviewed-by: Rishabh Dave <ridave@redhat.com>
Jan Fajerski [Mon, 9 Nov 2020 10:30:35 +0000 (11:30 +0100)]
Merge PR #37896 into master
* refs/pull/37896/head:
ceph-volume: implement the --log-level flag
Reviewed-by: Rishabh Dave <ridave@redhat.com>
Reviewed-by: Jan Fajerski <jfajerski@suse.com>
Lenz Grimmer [Mon, 9 Nov 2020 09:45:35 +0000 (10:45 +0100)]
Merge pull request #37506 from rhcs-dashboard/fix-47478-master
mgr/dashboard: Improvements in cluster > OSDs
Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Volker Theile <vtheile@suse.com>
Lenz Grimmer [Mon, 9 Nov 2020 09:43:50 +0000 (10:43 +0100)]
Merge pull request #37649 from rhcs-dashboard/add-header-tooltip
mgr/dashboard: add description for CRUSH Ruleset
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Laura Paduano <lpaduano@suse.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Kefu Chai [Mon, 9 Nov 2020 09:08:35 +0000 (17:08 +0800)]
cmake: build liburing with -fPIC
in liburing,
https://github.com/axboe/liburing/commit/
75cad68b953fe0fabbc4b1ced1ab4ba0ed5da18e
partially reverts
https://github.com/axboe/liburing/commit/
4e360f71131918c36774f51688e5c65dea8d43f2 ,
which builds liburing.a with -fPIC.
so we need to pass -fPIC by ourselves. otherwise we'd have
/usr/bin/ld: ../../liburing/src/liburing.a(setup.ol): relocation R_X86_64_PC32 against symbol `io_uring_queue_mmap' can not be used when making a shared object; recompile with -fPIC
/usr/bin/ld: final link failed: Bad value
collect2: error: ld returned 1 exit status
src/test/fio/CMakeFiles/fio_ceph_objectstore.dir/build.make:154: recipe for target 'lib/libfio_ceph_objectstore.so' failed
Signed-off-by: Kefu Chai <kchai@redhat.com>
Kefu Chai [Mon, 9 Nov 2020 07:47:41 +0000 (15:47 +0800)]
cmake: expose FIO_INCLUDE_DIR via libfio
always use the fio built from source for better consistency.
Signed-off-by: Kefu Chai <kchai@redhat.com>
Kefu Chai [Mon, 9 Nov 2020 07:36:47 +0000 (15:36 +0800)]
cmake: drop WITH_SYSTEM_FIO option
there is no well-known distro packaging fio.h, so drop this option.
Signed-off-by: Kefu Chai <kchai@redhat.com>
Kefu Chai [Mon, 9 Nov 2020 07:58:16 +0000 (15:58 +0800)]
Merge pull request #37981 from tchaikov/wip-make-dist
make-dist: add liburing to dist tarball
Reviewed-by: Brad Hubbard <bhubbard@redhat.com>
Kefu Chai [Mon, 9 Nov 2020 07:34:55 +0000 (15:34 +0800)]
cmake: use make explicitly to build fio
we cannot assume that user uses "make" as the generator of cmake, if,
for instance, ninja is used, `$(MAKE)` is not a valid variable in the
generated `build.ninja`. so we should use "make" explicitly.
Signed-off-by: Kefu Chai <kchai@redhat.com>
Kefu Chai [Mon, 9 Nov 2020 05:11:06 +0000 (13:11 +0800)]
cmake: use src/liburing for building liburing if it exists
so we can build with liburing enabled if the dist tarball contains
liburing.
Signed-off-by: Kefu Chai <kchai@redhat.com>
Kefu Chai [Mon, 9 Nov 2020 04:31:34 +0000 (12:31 +0800)]
make-dist: use a loop to collect the ingredients of the dist tarball
for better readability
Signed-off-by: Kefu Chai <kchai@redhat.com>
Kefu Chai [Mon, 9 Nov 2020 04:25:24 +0000 (12:25 +0800)]
make-dist: add liburing to dist tarball
since liburing is enabled by default, let's included it in the dist
tarball.
Signed-off-by: Kefu Chai <kchai@redhat.com>
Kefu Chai [Mon, 9 Nov 2020 03:58:10 +0000 (11:58 +0800)]
make-dist: extract download_from() out
so we can reuse it
Signed-off-by: Kefu Chai <kchai@redhat.com>
Patrick Donnelly [Sat, 7 Nov 2020 04:51:54 +0000 (20:51 -0800)]
Merge PR #36998 into master
* refs/pull/36998/head:
doc/mgr/volumes: Document authorize/deauthorize cli commands
qa/tasks/cephfs: test `fs subvolume authorize/deauthorize`
mgr/volumes: Allow/deny auth IDs access to FS subvolumes
mon/MonCap: allow 'profile mgr' to create/update/del auth IDs
Reviewed-by: Ramana Raja <rraja@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Patrick Donnelly [Sat, 7 Nov 2020 04:51:06 +0000 (20:51 -0800)]
Merge PR #37618 into master
* refs/pull/37618/head:
mds: throttle cap acquisition via readdir
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Patrick Donnelly [Sat, 7 Nov 2020 04:50:28 +0000 (20:50 -0800)]
Merge PR #37662 into master
* refs/pull/37662/head:
mon/MDSMonitor: deal with subscription after being expired
Reviewed-by: Jos Collin <jcollin@redhat.com>
Reviewed-by: João Eduardo Luís <joao@suse.de>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Michael Fritch [Sat, 7 Nov 2020 01:10:26 +0000 (18:10 -0700)]
Merge pull request #37600 from mgfritch/cephadm-nfs-rgw
mgr/cephadm: add RGW support for NFS ganesha
Reviewed-by: Daniel-Pivonka <dpivonka@redhat.com>
Reviewed-by: Juan Miguel Olmo <jolmomar@redhat.com>
Reviewed-by: Kiefer Chang <kiefer.chang@suse.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Michael Fritch [Sat, 7 Nov 2020 01:02:00 +0000 (18:02 -0700)]
Merge pull request #37792 from p-se/monitoring-prom-many-to-many
mgr/cephadm: many-to-many Prometheus error
Reviewed-by: Laura Paduano <lpaduano@suse.com>
Reviewed-by: Lenz Grimmer <lgrimmer@suse.com>
Reviewed-by: Michael Fritch <mfritch@suse.com>
Matt Benjamin [Fri, 6 Nov 2020 17:41:48 +0000 (12:41 -0500)]
Merge pull request #37967 from linuxbox2/wip-rgwfile-zwrite
rgw_file: fix some zipper flow for RGWLibContinuedReq
Kefu Chai [Fri, 6 Nov 2020 15:37:27 +0000 (23:37 +0800)]
Merge pull request #37968 from changchengx/paxos
mon/PaxosService: remove unnecessary code
Reviewed-by: Kefu Chai <kchai@redhat.com>
Kefu Chai [Fri, 6 Nov 2020 11:34:03 +0000 (19:34 +0800)]
Merge pull request #37970 from toabctl/fix-orch-cli-doc-link
mgr/orchestratori: Fix doc link in README.rst
Reviewed-by: Kefu Chai <kchai@redhat.com>
Thomas Bechtold [Fri, 6 Nov 2020 08:42:47 +0000 (09:42 +0100)]
mgr/orchestrator_cli: Fix doc link in README.rst
Signed-off-by: Thomas Bechtold <tbechtold@suse.com>
Greg Farnum [Fri, 6 Nov 2020 06:24:49 +0000 (06:24 +0000)]
doc: update stretch mode doc to not be a lie
Signed-off-by: Greg Farnum <gfarnum@redhat.com>
Greg Farnum [Thu, 5 Nov 2020 00:07:01 +0000 (00:07 +0000)]
mon: include stretch mode status in more outputs
It was missing from the monmap dump, and included in OSDMap::dump()
but not the OSDMap::print() which is used for text-based CLI queries.
Signed-off-by: Greg Farnum <gfarnum@redhat.com>
Greg Farnum [Mon, 2 Nov 2020 08:14:48 +0000 (08:14 +0000)]
mon: retain disallowed leader list on restart
We were only setting this when new monmaps were read from paxos -- whoops!
Pull apart that mechanism a little bit and make sure to set them before
doing elections, as part of bootstrap.
Signed-off-by: Greg Farnum <gfarnum@redhat.com>
Greg Farnum [Thu, 29 Oct 2020 06:10:23 +0000 (06:10 +0000)]
mon: Output the real leader in ::_quorum_status() and get_leader_name()
These functions previously assumed the first mon in the quorum
was the leader. That isn't accurate if the first monitor is
disallowed or it lost a connectivity-mode election, though.
Signed-off-by: Greg Farnum <gfarnum@redhat.com>
Greg Farnum [Thu, 29 Oct 2020 06:06:24 +0000 (06:06 +0000)]
mon: monmap: print out disallowed_leaders in text form, when non-empty
This is already dumped in the programmatic output, but it got left out of
the direct-user-facing calls (as in "ceph mon dump").
Signed-off-by: Greg Farnum <gfarnum@redhat.com>
Greg Farnum [Thu, 29 Oct 2020 05:58:56 +0000 (05:58 +0000)]
mon: Do not increase compatv when using monitor location or stretch mode
For mon_info_t, I first wrote things so that when monitors get a location
added in MonMap::mon_info_t, I bumped the struct_v to 5 and also bumped
the min_compat to 5. This made sure that nobody could decode the
struct and lose the location info, which if it were a monitor
would be very bad.
And for the MonMap, when stretch mode is enabled I bumped up the
comptav (in addition to the always-increased struct_v), for the same reason.
But clients also have to decode these structures, and we can't
disallow older clients from connecting to a stretched cluster.
Happily, usage of any stretch modes already requires a feature
bit and sets it as required in the monmap, so these are already
gated. Therefore, just don't set new compat values in these cases.
While at it, also gate setting the location on the monmap indicating
all monitors are updated.
Reported-by: Travis Nielsen <tnielsen@redhat.com>
Signed-off-by: Greg Farnum <gfarnum@redhat.com>
Greg Farnum [Fri, 23 Oct 2020 16:32:33 +0000 (16:32 +0000)]
mon: fix erroneous commit of monmap stretch mode when failing to enable
MonmapMonitor::try_enable_stretch_mode() was accidentally writing into the
pending_map even when commit was false. Whoops!
Signed-off-by: Greg Farnum <gfarnum@redhat.com>
Kefu Chai [Fri, 6 Nov 2020 03:36:24 +0000 (11:36 +0800)]
Merge pull request #37966 from tchaikov/wip-cmake-uring
cmake: set GIT_SHALLOW and UPDATE_DISCONNECTED
Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
Kefu Chai [Thu, 5 Nov 2020 16:16:45 +0000 (00:16 +0800)]
cmake: set GIT_SHALLOW and UPDATE_DISCONNECTED
* GIT_SHALLOW=TRUE, so we don't pull the full git history,
as we don't care about it.
* UPDATE_DISCONNECTED=TRUE, to skip the UPDATE step, this change
somehow works around
https://gitlab.kitware.com/cmake/cmake/-/issues/19703. otherwise
cmake keeps building liburing.
Signed-off-by: Kefu Chai <kchai@redhat.com>
Kefu Chai [Thu, 5 Nov 2020 16:37:32 +0000 (00:37 +0800)]
blk/kernel/io_uring: bump liburing to v0.7
* use functions exposed by liburing instead of using syscalls
* v0.7 is the latest release at the time of writing, as liburing is under
active development. it'd be better to use a newer release.
* also use https://git.kernel.dk/liburing instead of
http://git.kernel.dk/liburing.
Signed-off-by: Kefu Chai <kchai@redhat.com>
Matt Benjamin [Wed, 4 Nov 2020 17:02:27 +0000 (12:02 -0500)]
rgw_file: fix some zipper flow for RGWLibContinuedReq
Some bits of the standard Zipper conversions were missed for
the RGWLibContinuedReq case, where the setup is encapsulated in
the request, but execution is broken up in to steps. This
currently affects only RGWWriteRequest.
Fixes: https://tracker.ceph.com/issues/48136
Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
Ronen Friedman [Thu, 5 Nov 2020 08:38:37 +0000 (10:38 +0200)]
librbd: removing a "pessimizing move"
Silencing a compiler warning ("warning: moving a temporary object
prevents copy elision")
Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
Nizamudeen A [Thu, 5 Nov 2020 16:27:00 +0000 (21:57 +0530)]
mgr/dashboard: Moving copyright into the app.constants
Move the variable copyright from about.component.ts to the app.constants.ts
https://tracker.ceph.com/issues/48135
Signed-off-by: Nizamudeen A <nia@redhat.com>
Kefu Chai [Thu, 5 Nov 2020 15:32:32 +0000 (23:32 +0800)]
Merge pull request #37919 from tchaikov/wip-cmake-liburing
cmake: enable LIBURING bluestore backend by default
Reviewed-by: Mark Nelson <mnelson@redhat.com>
Casey Bodley [Thu, 5 Nov 2020 15:04:30 +0000 (10:04 -0500)]
Merge pull request #37929 from BryceCao/wip-modify-error-code-of-bucket-info-API
rgw : modify error message to NoSuchBucket when bucket doesn't exist in bucket info API
Reviewed-by: Casey Bodley <cbodley@redhat.com>
Lenz Grimmer [Thu, 5 Nov 2020 13:54:16 +0000 (14:54 +0100)]
Merge pull request #37913 from rhcs-dashboard/button-disable
Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Volker Theile <vtheile@suse.com>
Kefu Chai [Thu, 5 Nov 2020 13:05:17 +0000 (21:05 +0800)]
Merge pull request #37832 from tchaikov/wip-doc-slow-ops
doc: reformat health-messages.rst and revise SLOW_OPS section
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: Zac Dover <zac.dover@gmail.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
Kefu Chai [Thu, 5 Nov 2020 13:01:46 +0000 (21:01 +0800)]
Merge pull request #37951 from agayev/misc-zbd-changes
doc, os/bluestore: Zoned storage related cleanup.
Reviewed-by: Kefu Chai <kchai@redhat.com>
Lenz Grimmer [Thu, 5 Nov 2020 12:38:59 +0000 (13:38 +0100)]
Merge pull request #37637 from p-se/dashboard-smart-logging
Reviewed-by: Kiefer Chang <kiefer.chang@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>
Kotresh HR [Fri, 11 Sep 2020 04:26:22 +0000 (09:56 +0530)]
doc/mgr/volumes: Document authorize/deauthorize cli commands
Fixes: https://tracker.ceph.com/issues/40401
Signed-off-by: Kotresh HR <khiremat@redhat.com>
Ramana Raja [Thu, 11 Jul 2019 11:14:35 +0000 (16:44 +0530)]
qa/tasks/cephfs: test `fs subvolume authorize/deauthorize`
Fixes: https://tracker.ceph.com/issues/40401
Signed-off-by: Ramana Raja <rraja@redhat.com>
Signed-off-by: Kotresh HR <khiremat@redhat.com>
Ramana Raja [Fri, 5 Jul 2019 06:41:52 +0000 (12:11 +0530)]
mgr/volumes: Allow/deny auth IDs access to FS subvolumes
... via the `ceph fs subvolume authorize/deauthorize` command.
Fixes: https://tracker.ceph.com/issues/40401
Signed-off-by: Ramana Raja <rraja@redhat.com>
Signed-off-by: Kotresh HR <khiremat@redhat.com>
Lenz Grimmer [Thu, 5 Nov 2020 09:57:51 +0000 (10:57 +0100)]
Merge pull request #37454 from votdev/custom_container_docs
doc/mgr/orchestrator: Add hints related to custom containers to the docs
Reviewed-by: Kiefer Chang <kiefer.chang@suse.com>
Lenz Grimmer [Thu, 5 Nov 2020 09:51:54 +0000 (10:51 +0100)]
Merge pull request #37946 from bk201/wip-47373
mgr/dashboard: disable cluster selection in NFS export editing form
Reviewed-by: Laura Paduano <lpaduano@suse.com>
Reviewed-by: Tatjana Dehler <tdehler@suse.com>
Ramana Raja [Wed, 10 Jul 2019 19:03:20 +0000 (00:33 +0530)]
mon/MonCap: allow 'profile mgr' to create/update/del auth IDs
Signed-off-by: Ramana Raja <rraja@redhat.com>
Kefu Chai [Thu, 5 Nov 2020 08:55:30 +0000 (16:55 +0800)]
Merge pull request #37955 from tchaikov/wip-cmake-crimson-cleanup
cmake: rename crimson tests named like foo_bar to foo-bar
Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
Kefu Chai [Thu, 5 Nov 2020 08:53:03 +0000 (16:53 +0800)]
Merge pull request #37953 from tchaikov/wip-crimson-recovery-cleanup
test/crimson: do not support variadic future
Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
Kefu Chai [Thu, 5 Nov 2020 06:45:36 +0000 (14:45 +0800)]
cmake: do not name demo-like tests with unittest-*
these tests cannot be exercised without human intervention.
Signed-off-by: Kefu Chai <kchai@redhat.com>
Kefu Chai [Thu, 5 Nov 2020 06:42:54 +0000 (14:42 +0800)]
cmake/test: remove duplicated target_link_libraries()
it is a copy-n-paste error.
Signed-off-by: Kefu Chai <kchai@redhat.com>
Kefu Chai [Thu, 5 Nov 2020 06:27:35 +0000 (14:27 +0800)]
cmake: rename crimson tests named like foo_bar to foo-bar
for two reasons:
* less typing: no need to press "shift" for inputting "_"
* more consistent with executable names like "ceph-conf"
* simpler to grep when compiling the tests. there is chance
we need to kill the dead jobs on a jenkins worker node
where it happens to be compiling the tests.
Signed-off-by: Kefu Chai <kchai@redhat.com>
Kefu Chai [Thu, 5 Nov 2020 05:07:25 +0000 (13:07 +0800)]
Merge pull request #37940 from yuvalif/remove_lua_submodule
rpm,deb,cmake: remove the lua submodule
Reviewed-by: Kefu Chai <kchai@redhat.com>
Patrick Donnelly [Thu, 5 Nov 2020 05:03:02 +0000 (21:03 -0800)]
Merge PR #37869 into master
* refs/pull/37869/head:
qa: for the latest kclient it will also return EIO
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Patrick Donnelly [Thu, 5 Nov 2020 05:02:29 +0000 (21:02 -0800)]
Merge PR #37713 into master
* refs/pull/37713/head:
mds: fix wrong log text and allignment
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Patrick Donnelly [Thu, 5 Nov 2020 05:01:35 +0000 (21:01 -0800)]
Merge PR #37664 into master
* refs/pull/37664/head:
cephfs: release client dentry_lease before send caps release to mds
Reviewed-by: Zheng Yan <zyan@redhat.com>
Patrick Donnelly [Thu, 5 Nov 2020 05:00:50 +0000 (21:00 -0800)]
Merge PR #37654 into master
* refs/pull/37654/head:
mds: print the METRIC_TYPE for debug info
mds: add XXPayload:print support
mds: only update the requesting metrics
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Patrick Donnelly [Thu, 5 Nov 2020 04:59:44 +0000 (20:59 -0800)]
Merge PR #32479 into master
* refs/pull/32479/head:
mds: add dentry lease metric payload support
client: add _dentry_valid() helper support
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Kefu Chai [Thu, 5 Nov 2020 04:46:52 +0000 (12:46 +0800)]
crimson/common: refactor crimson::do_until()
* define `errorator_t` instead of `futurator` to simplify the code a
little bit.
* use seastar helper function / types when appropriate
Signed-off-by: Kefu Chai <kchai@redhat.com>
Kefu Chai [Thu, 5 Nov 2020 04:44:21 +0000 (12:44 +0800)]
test/crimson: do not support variadic future
also add "unittest-seastar-errorator" to unit test.
this should address the build failure introduced by
688b95798bfd88b409abce9b70bb6d2933819bef
Signed-off-by: Kefu Chai <kchai@redhat.com>
Kefu Chai [Thu, 5 Nov 2020 04:31:53 +0000 (12:31 +0800)]
Merge pull request #37950 from tchaikov/wip-crimson-recovery-cleanup
crimson: cleanups
Reviewed-by: Samuel Just <sjust@redhat.com>
Changcheng Liu [Thu, 5 Nov 2020 02:29:43 +0000 (10:29 +0800)]
mon/PaxosService: remove unnecessary code
The class declaration has been included in the header file.
Signed-off-by: Changcheng Liu <changcheng.liu@aliyun.com>
Changcheng Liu [Wed, 4 Nov 2020 23:53:42 +0000 (07:53 +0800)]
mon/MDSMonitor: deal with subscription after being expired
check expiration condition before taking further action
Signed-off-by: Changcheng Liu <changcheng.liu@aliyun.com>
Patrick Donnelly [Wed, 4 Nov 2020 19:04:17 +0000 (11:04 -0800)]
Merge PR #37899 into master
* refs/pull/37899/head:
qa: avoid using ceph.dir.entries for empty check
qa: do not test dir size equals rbytes
qa: disable check for value kclient fails to get
qa: leave one standby available to avoid warning
qa: do not check access timestamps
qa: ignore skip errors for kclient
qa: add more clients for test_volume_client
qa: accept client returning pool id for layout
qa: ignore expected warning about client missing features
qa: do not fail on skip
qa: fix mount directory
qa: rename distro link to distros
qa: accept eio for mount failure
qa: unmount volumes before removal
qa: some sessionmap tests require fuse
qa: remove obsolete test
qa: do not fail on test skip
qa: use more OSDs for workload tests
qa: use 4 clients for volumes testing
qa: relocate tasks
qa: rename workload suite
qa: relocate new tasks from fs:basic_functional
qa: remove kcephfs suite
qa: move kcephfs:mixed-clients to fs
qa: remove dead kcephfs:cephfs suite
qa: merge snap tests for kcephfs/fs
qa: add new fs:shell sub-suite
qa: remove task-less kcephfs:recovery suite
qa: add new fs:volumes sub-suite
qa: merge fs:basic_functional and kcephfs:recovery
qa: move kcephfs:thrash to fs:thrash
qa: reorganize thrash tasks
qa: move multifs/failover tests
qa: run norstats workunit for klient
qa: merge workload tests from kcephfs with fs
qa: use consistent syntax
qa: remove inline testing
qa: move log-rotate config to common yaml
qa: remove fuse default permissions config
qa: fix whitespace
Reviewed-by: Kotresh Hiremath Ravishankar <khiremat@redhat.com>
Reviewed-by: Ramana Raja <rraja@redhat.com>
Abutalib Aghayev [Wed, 4 Nov 2020 18:57:05 +0000 (13:57 -0500)]
os/bluestore: Cleanup. Move ZBD related functions into one place and add zoned
prefix to all of them.
Signed-off-by: Abutalib Aghayev <agayev@psu.edu>
Abutalib Aghayev [Wed, 4 Nov 2020 18:56:22 +0000 (13:56 -0500)]
doc: Update contact email address and documentation for zoned-storage.rst.
Signed-off-by: Abutalib Aghayev <agayev@psu.edu>
Avan Thakkar [Tue, 13 Oct 2020 09:52:48 +0000 (15:22 +0530)]
mgr/dashboard: add description for CRUSH Ruleset
Fixes: https://tracker.ceph.com/issues/48067
Signed-off-by: Avan Thakkar <athakkar@redhat.com>
Adds a description for CRUSH Ruleset column in pools table in the pool creation dialogue
J. Eric Ivancich [Wed, 4 Nov 2020 15:03:51 +0000 (10:03 -0500)]
Merge pull request #32394 from zhangsw/fix-appendobj-invalidposition
rgw: using strict_strtoll for append position. If not, any invalid value will be decoded as zero which is not correct.
Reviewed-by: Yuval Lifshitz <ylifshit@redhat.com>
J. Eric Ivancich [Wed, 4 Nov 2020 15:03:20 +0000 (10:03 -0500)]
Merge pull request #37703 from theanalyst/rgw/sal/init-quota-fixes
rgw: op: check for bucket existance as well in init_quota
Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
J. Eric Ivancich [Wed, 4 Nov 2020 15:02:18 +0000 (10:02 -0500)]
Merge pull request #37160 from linuxbox2/wip-rgwlc-tagfilter
rgwlc: fix clause counting in LCFilter_S3::decode_xml()
Reviewed-by: Casey Bodley <cbodley@redhat.com>
Reviewed-By: Abhishek Lekshmanan <abhishek@suse.com>
Yuval Lifshitz [Tue, 3 Nov 2020 18:02:00 +0000 (20:02 +0200)]
rpm/deb/cmake: remove the lua submodule
instead use the official lua-dev/el packages
Signed-off-by: Yuval Lifshitz <ylifshit@redhat.com>
J. Eric Ivancich [Wed, 4 Nov 2020 15:00:48 +0000 (10:00 -0500)]
Merge pull request #37066 from smanjara/wip-metadata-reshard
rgw: don't allow overwrites to BucketInfo's layout field when sync fetches bucket metadata
Reviewed-by: Casey Bodley <cbodley@redhat.com>
J. Eric Ivancich [Wed, 4 Nov 2020 15:00:03 +0000 (10:00 -0500)]
Merge pull request #37892 from IlsooByun/fix_bucket_sync_err
rgw: keep syncstopped flag when copying bucket shard headers
Reviewed-by: Casey Bodley <cbodley@redhat.com>
Reviewed-by: J. Eric Ivancich <ivancich@redhat.com>
Kefu Chai [Wed, 4 Nov 2020 14:40:32 +0000 (22:40 +0800)]
osd/PGLog: do not use unique_ptr explicitly
* do not use unique_ptr<> explicitly, use `seastar::do_with()` for
better readability
* use seastar::do_until() instead of seastar::repeat() for better
readability. plain boolean is simpler than
`seastar::stop_iteration::yes`
* do not capture variables using FuturizedStoreLogReader if we could
pass them by instant parameters.
* rename "start()" to "read()". as "read" is more specific in this
context.
Signed-off-by: Kefu Chai <kchai@redhat.com>
Kefu Chai [Wed, 4 Nov 2020 13:20:22 +0000 (21:20 +0800)]
osd/PGLog: move PGLog::read_log_and_missing_crimson() into .cc
to speed up the compilation. and for better readability.
Signed-off-by: Kefu Chai <kchai@redhat.com>
Kefu Chai [Wed, 4 Nov 2020 13:07:11 +0000 (21:07 +0800)]
osd/PGLog: drop template parameter of FuturizedStoreLogReader
there is no need for the generic type at this moment.
Signed-off-by: Kefu Chai <kchai@redhat.com>
Kefu Chai [Wed, 4 Nov 2020 12:59:54 +0000 (20:59 +0800)]
crimson/osd: use seastar:do_until() when appropriate
a plain boolean is easier to understand than
`seastar::stop_iteration::yes`.
Signed-off-by: Kefu Chai <kchai@redhat.com>
Kefu Chai [Wed, 4 Nov 2020 10:01:48 +0000 (18:01 +0800)]
crimson/osd: mark CyanStore::CyanOmapIterator methods final
this class is not intended to be inherited by classes, and these methods
are "final", so mark them "final".
Signed-off-by: Kefu Chai <kchai@redhat.com>
Kefu Chai [Wed, 4 Nov 2020 09:56:33 +0000 (17:56 +0800)]
crimson/osd: mark methods pure virtual
if the default implementation does not make sense in any case, just mark
it pure virtual.
Signed-off-by: Kefu Chai <kchai@redhat.com>
Kefu Chai [Wed, 4 Nov 2020 09:50:15 +0000 (17:50 +0800)]
crimson/osd: let OmapIterator mutators return future<>
instead of returning future<int> where the int represents an errno which
is not checked by any callers, we should just return a future<>, we
could erroratorize it later on, but returning an int is not the right
way to handle this, and it is not consistent with how we handle other
errors elsewhere in crimson.
Signed-off-by: Kefu Chai <kchai@redhat.com>
Volker Theile [Wed, 4 Nov 2020 13:39:40 +0000 (14:39 +0100)]
doc/mgr/orchestrator: Add hints related to custom containers to the docs
Fixes: https://tracker.ceph.com/issues/48113
Signed-off-by: Volker Theile <vtheile@suse.com>
zdover23 [Wed, 4 Nov 2020 12:01:53 +0000 (22:01 +1000)]
Merge pull request #37867 from zdover23/wip-doc-cephadm-install-oct-2020
doc/cephadm: improve install guide
Reviewed-by: Neha Ojha <nojha@redhat.com>
Kefu Chai [Wed, 4 Nov 2020 10:01:08 +0000 (18:01 +0800)]
Merge pull request #37944 from tchaikov/wip-crimson-recovery-cleanup
crimson/osd: extract read_omap_for_push_op()
Reviewed-by: Xuehan Xu <xxhdx1985126@gmail.com>
Reviewed-by: Samuel Just <sjust@redhat.com>
Kiefer Chang [Wed, 4 Nov 2020 03:00:21 +0000 (11:00 +0800)]
mgr/dashboard: disable cluster selection in NFS export editing form
We should not allow changing an export's cluster because an export ID
might live in one cluster but not in another one. Editing a non-existing
export in a cluster causes an error.
Fixes: https://tracker.ceph.com/issues/47373
Signed-off-by: Kiefer Chang <kiefer.chang@suse.com>
Xiubo Li [Fri, 5 Jun 2020 00:48:59 +0000 (20:48 -0400)]
mds: add dentry lease metric payload support
Fixes: https://tracker.ceph.com/issues/43423
Signed-off-by: Xiubo Li <xiubli@redhat.com>
Xiubo Li [Mon, 19 Oct 2020 06:44:06 +0000 (02:44 -0400)]
client: add _dentry_valid() helper support
Fixes: https://tracker.ceph.com/issues/43423
Signed-off-by: Xiubo Li <xiubli@redhat.com>
Kefu Chai [Wed, 4 Nov 2020 05:27:15 +0000 (13:27 +0800)]
crimson/osd: extract read_omap_for_push_op()
extract read_omap_for_push_op() out of build_push_op() for better
readability
Signed-off-by: Kefu Chai <kchai@redhat.com>
Kefu Chai [Tue, 3 Nov 2020 09:08:31 +0000 (17:08 +0800)]
crimson/osd: correct the function names in logging messages
it was a leftover of
fbfc53c7081ea0b99fbc519d7fac9f5637cf5425
Signed-off-by: Kefu Chai <kchai@redhat.com>
Patrick Donnelly [Wed, 4 Nov 2020 00:22:32 +0000 (16:22 -0800)]
Merge PR #37881 into master
* refs/pull/37881/head:
doc/mgr/orchestrator: Update about nfs add in rook
mgr/rook: Refactor nfs add/apply methods
mgr/rook: Udpate to mypy py3 type style in _create(), _update() and apply()
mgr/rook: Remove unused 'current' argument from update_func method
Reviewed-by: Michael Fritch <mfritch@suse.com>
Reviewed-by: Travis Nielsen <tnielsen@redhat.com>
Patrick Donnelly [Tue, 3 Nov 2020 18:01:55 +0000 (10:01 -0800)]
qa: avoid using ceph.dir.entries for empty check
This avoids a bug [1] in the kernel client.
[1] https://tracker.ceph.com/issues/48104
Fixes: https://tracker.ceph.com/issues/23718
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
Patrick Donnelly [Tue, 3 Nov 2020 21:06:12 +0000 (13:06 -0800)]
Merge PR #37825 into master
* refs/pull/37825/head:
doc: document MDS cache configuration
test: add DecayCounter test
Reviewed-by: Sidharth Anupkrishnan <sanupkri@redhat.com>
Patrick Donnelly [Tue, 3 Nov 2020 03:59:30 +0000 (19:59 -0800)]
qa: do not test dir size equals rbytes
Avoiding this failure:
2020-11-03T03:11:59.980 INFO:tasks.cephfs_test_runner:test_subvolume_resize_fail_quota_lt_used_size_no_shrink (tasks.cephfs.test_volumes.TestSubvolumes) ... FAIL
2020-11-03T03:11:59.981 INFO:tasks.cephfs_test_runner:
2020-11-03T03:11:59.981 INFO:tasks.cephfs_test_runner:======================================================================
2020-11-03T03:11:59.981 INFO:tasks.cephfs_test_runner:FAIL: test_subvolume_resize_fail_quota_lt_used_size_no_shrink (tasks.cephfs.test_volumes.TestSubvolumes)
2020-11-03T03:11:59.982 INFO:tasks.cephfs_test_runner:----------------------------------------------------------------------
2020-11-03T03:11:59.982 INFO:tasks.cephfs_test_runner:Traceback (most recent call last):
2020-11-03T03:11:59.982 INFO:tasks.cephfs_test_runner: File "/home/teuthworker/src/git.ceph.com_ceph-c_wip-pdonnell-testing-
20201102 .231317/qa/tasks/cephfs/test_volumes.py", line 1310, in test_subvolume_resize_fail_quota_lt_used_size_no_shrink
2020-11-03T03:11:59.982 INFO:tasks.cephfs_test_runner: self.assertEqual(usedsize, susedsize)
2020-11-03T03:11:59.982 INFO:tasks.cephfs_test_runner:AssertionError:
8912896 != 1
From: /ceph/teuthology-archive/pdonnell-2020-11-03_02:22:55-fs:volumes-wip-pdonnell-testing-
20201102 .231317-distro-basic-smithi/
5585383 /teuthology.log
Fixes: https://tracker.ceph.com/issues/23718
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
Patrick Donnelly [Mon, 2 Nov 2020 18:14:01 +0000 (10:14 -0800)]
qa: disable check for value kclient fails to get
See-also: https://tracker.ceph.com/issues/48075
Fixes: https://tracker.ceph.com/issues/23718
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
Patrick Donnelly [Mon, 2 Nov 2020 18:01:59 +0000 (10:01 -0800)]
qa: leave one standby available to avoid warning
Four file systems will use all MDS and generate this warning:
2020-11-02T03:48:33.407 INFO:teuthology.orchestra.run.smithi003.stdout:2020-11-02T03:24:21.817337+0000 mon.a (mon.0) 481 : cluster [WRN] Health check failed: insufficient standby MDS daemons available (MDS_INSUFFICIENT_STANDBY)
Fixes: https://tracker.ceph.com/issues/23718
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>