CInode.h: use static_cast instead of C-Style cast

Use static_cast<const T>() instead of C-Style cast. Change CInode* to
const, since it never changed.

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>

CDentry.h: use static_cast instead of C-Style cast

Use static_cast<T>() instead of C-Style cast.

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>

Merge branch 'wip-4222'

Fix for Bug 4222.  Add libcephfs-test.jar to the ceph-test package.

Signed-off-by: Gary Lowell <gary.lowell@inktank.com>

fix ceph-object-corpus submodule commit

Broken by 58f4cd53b9a29ec16c863fde8e790381dee20253

Signed-off-by: Sage Weil <sage@inktank.com>

doc: rbd-cloudstack: fix bullet list, missing words, change ! to .

ceph-test.install:  Add libcephfs-test.jar to package.

Signed-off-by: Gary Lowell <gary.lowell@inktank.com>

Merge branch 'wip-4281'

Reviewed-by: Sage Weil <sage@inktank.com>

doc: Consolidated Ubuntu and Ubuntu 12.10 requirements.

fixes: #4288

Signed-off-by: John Wilkins <john.wilkins@inktank.com>

mon: PaxosServices: don't ignore get_version(ver,bl) return value

get_version(version_t,bufferlist) can only return one of two values:
  -ENOENT iff the version doesn't exist
  zero iff it was successful

Any other value is incorrect.

Fixes: #4281
Signed-off-by: Joao Eduardo Luis <joao.luis@inktank.com>

doc: Added dependencies for ubuntu 12.10.

fixes: #4288

Signed-off-by: John Wilkins <john.wilkins@inktank.com>

debian: require cryptsetup-bin

This is needed for ceph-disk-prepare's dmcrypt support.

Signed-off-by: Sage Weil <sage@inktank.com>

vstart.sh: give mon. key mon = 'allow *' caps

This is needed for ceph-create-keys to do its thing.

Signed-off-by: Sage Weil <sage@inktank.com>

doc: fixed link and form edit.

Signed-off-by: John Wilkins <john.wilkins@inktank.com>

doc: Added auth entry to index.

Signed-off-by: John Wilkins <john.wilkins@inktank.com>

doc: Removed auth entries from general. Part of an auth-specific section now.

Signed-off-by: John Wilkins <john.wilkins@inktank.com>

doc: Added comment to enable message. Added link to Auth Config Reference.

Signed-off-by: John Wilkins <john.wilkins@inktank.com>

doc: Added Auth Config Reference as standalone config reference.

Signed-off-by: John Wilkins <john.wilkins@inktank.com>

osd: allow log trimming during recovery

We rely on min_last_complete_ondisk being accurate; as long as we have logs
from that point, the current replicas will be able to safely recovery via
their logs.  Bump the target size, just as we do with degraded.

Signed-off-by: Sage Weil <sage@inktank.com>
Reviewed-by: Samuel Just <sam.just@inktank.com>

ceph-fuse: add ceph options for all current fuse options

This will make it easier to disable these for end users, and for platforms
with old libfuse versions that don't support them.

Signed-off-by: Sage Weil <sage@inktank.com>

Merge pull request #81 from dalgaaf/wip-da-sca-style-1

Fix some smaller style issues

Reviewed-by: Sage Weil <sage@inktank.com>

mon: MonitorDBStore: return -ENOENT on get() if key doesn't exist

And adjust version_t get(string,string) so that, in case of -ENOENT, it
returns 0 (when a key doesn't exist, assumes its value is zero), and make
sure it asserts in all other negative return values.

Signed-off-by: Joao Eduardo Luis <joao.luis@inktank.com>

kv_flat_btree_async.cc: remove unused variables

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>

kv_flat_btree_async.cc: remove some unreachable break statements

Remove unreachable break statements after return calls in a switch.

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>

key_value_store/cls_kvs.cc: remove unused variable dupmap

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>

bloom_filter.hpp: check for self assignment

Check for self assignment in operator= to avoid problems with
dynamic memory (cppcheck).

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>

crush/builder.c: reduce scope of oldsize in crush_add_rule()

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>

debian: let dpkg calculate the shlibs dep for leveldb (if any)

Signed-off-by: Sage Weil <sage@inktank.com>

CrushCompiler.cc: remove duplicate if/else branches

Fix duplicate content of a if/else branch. Remove the
complete if/else around the content.

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>

common/secret.c: reduce the scope of some variables

Reduce the scope of error_buf to the place where it's used.

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>

pick_address.cc: pass const string by refrence

Pass 'const string networks' by reference to find_ip_in_subnet_list().

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>

obj_bencher.cc: use static_cast instead of C-Style cast

Use static_cast<T>() instead of C-Style cast.

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>

config.cc: remove unused variable 'val' from parse_injectargs()

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>

code_environment.cc: move variable ret in get_process_name()

Move 'ret' in get_process_name() to the correct block to suppress
warning about unused variable in cppcheck.

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>

ceph_context.cc: remove unused variable 'args' from do_command

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>

Merge pull request #79 from dalgaaf/wip-da-leveldb

Some fixes related to switch to system leveldb

Reviewed-by: Sage Weil <sage@inktank.com>

Merge pull request #80 from dalgaaf/wip-da-4261

ceph_argparse.cc: accept also 0/1 for boolean injectargs

Reviewed-by: Sage Weil <sage@inktank.com>

cls_crypto.cc: remove some unused variables

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>

cls_acl.cc: remove unused variables

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>

common/armor.c: reduce scope of some variables

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>

ceph_argparse.cc: accept also 0/1 for boolean injectargs

Accept also 0 (as false) and 1 (true) as arguments for
boolean option on injectargs.

Fixes: #4261
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>

TextTable: pass const string by refrence to define_column()

Pass 'const string heading' by reference to define_column().

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>

CephBroker.h: use static_cast instead of C-Style cast

Use static_cast<T>() instead of C-Style cast.

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>

SyntheticClient.cc: use static_cast instead of C-Style cast

Use static_cast<T>() instead of C-Style cast.

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>

debian/control: fix Depends

Remove request for libleveldb1 version > 1.2. Every libleveldb1 package
should work, otherwise the SO name/version of the library should change.

Fixes: #3945
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>

debian/control: add libleveldb-dev to Build-Depends:

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>

README: add leveldb-dev to package list needed for build

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>

ceph.spec.in: fix leveldb handling

There is no need to add leveldb as 'Requires:'. The RPM build system
will find this dependency by itself.

Add leveldb-devel to BuildRequires: since this is what the package
really needs to build ceph correctly with libleveldb1.

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>

configure.ac: check for libsnappy

Since libsnappy is needed by leveldb, check if the lib is installed
before check for leveldb.

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>

add src/leveldb to .gitignore

Add src/leveldb to .gitignore in master, since the directory
may get checked out by older branches. Ignore it since it's not
needed in master.

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>

remove leveldb from master branch

Since we now build against system leveldb and no longer
against a git submodule, drop the submodule from git master.

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>

Build: Change build to always use system leveldb

Dynamically link to the leveldb installed on the system rather than
statically linking ceph copy.  Remove the --with-system-leveldb config
option, and add a requirement for leveldb libraries for rpm and debian
packages.  Bug 3945.

Signed-off-by: Gary Lowell <gary.lowell@inktank.com>

ceph-test.install:  remove cepkfs-test.jar

This was merged prematurely to mast.

Signed-off-by: Gary Lowell <gary.lowell@inktank.com>

doc: fix rst for watch/notify internals

Signed-off-by: Sage Weil <sage@inktank.com>

OpRequest: rmw_flags may actually be 0

If the operation includes only an invalid method,
the flags will be 0.

Reviewed-by: Yehuda Sadeh <yehuda@inktank.com>
Signed-off-by: Samuel Just <sam.just@inktank.com>

Merge branch 'next'

ceph-test.install:  Add libcephfs-test.jar.

Signed-off-by: Gary Lowell <gary.lowell@inktank.com>

Merge pull request #78 from Elbandi/master

Some fixes and functions for libcephfs and client

Reviewed-by: Sage Weil <sage@inktank.com>

client: add some new functions: lchmod, fsetattr, lutime

Signed-off-by: Andras Elso <elso.andras@gmail.com>

client: allow change file owner or group only

Signed-off-by: Andras Elso <elso.andras@gmail.com>

client: use get_filehandle

Signed-off-by: Andras Elso <elso.andras@gmail.com>

client: fix log data

Signed-off-by: Andras Elso <elso.andras@gmail.com>

libcephfs: fix default parameters document for ceph_open_layout

Signed-off-by: Andras Elso <elso.andras@gmail.com>

Merge pull request #76 from dalgaaf/wip-da-sca-style

Fix some style related issues found by cppcheck

Reviewed-by: Sage Weil <sage@inktank.com>

Merge remote-tracking branch 'gh/wip-4256'

Reviewed-by: Sage Weil <sage@inktank.com>

PendingReleaseNotes: mention ceph-mon requiring the creation of data dir

Signed-off-by: Joao Eduardo Luis <joao.luis@inktank.com>

mon: give useful errors to user when store is missing

We used to assert() instead, which didn't shed enough light on the cause
and could confuse the user into believing something *terrible* had
happened.

Signed-off-by: Joao Eduardo Luis <joao.luis@inktank.com>

mon: Monitor: check for an argument to 'quorum' before reading the array

Fixes: #4218
Signed-off-by: Joao Eduardo Luis <joao.luis@inktank.com>

mon: Monitor: adjust sync start criteria considering a peon's bootstrap

Signed-off-by: Joao Eduardo Luis <joao.luis@inktank.com>

mon: Paxos: bootstrap if we have fallen behind when we start collecting

Fixes: #4256
Signed-off-by: Joao Eduardo Luis <joao.luis@inktank.com>
Reviewed-by: Sage Weil <sage@inktank.com>

librbd: fix rollback size

The duplicate calls to get_image_size() and get_snap_size() replaced
by 5806226cf0743bb44eaf7bc815897c6846d43233 uncovered this. The first
call was using the currently set snap_id instead of the snapshot being
rolled back to.

Fixes: #4272
Signed-off-by: Josh Durgin <josh.durgin@inktank.com>
Reviewed-by: Sage Weil <sage@inktank.com>

msg: fix entity_addr_t::is_same_host() for IPv6

We weren't checking the memcmp return value properly!  Aie...

Backport: bobtail
Signed-off-by: Sage Weil <sage@inktank.com>

mon: fix other debug dumps

These should only kick in at high debug levels.  Moving any "work" between
the dout() and dendl lines puts them inside the magical hidden if block
that makes this code a no-op at low debug.

Signed-off-by: Sage Weil <sage@inktank.com>

msgr: print dump before asserting (if that is enabled)

Signed-off-by: Sage Weil <sage@inktank.com>

msgr: dump corrupt message to log (at high debug levels)

Signed-off-by: Sage Weil <sage@inktank.com>

Merge remote-tracking branch 'gh/next'

osd: allow (some) log trim when degraded, but not during recovery

We allow some trim during degraded, although we keep more entries around to
improve our chances of a restarting OSD of doing log-based recovery.

Still disallow during recovery...

Signed-off-by: Sage Weil <sage@inktank.com>
Reviewed-by: Samuel Just <sam.just@inktank.com>

osd: restructure calc_trim

No functional change, except that we log more debug, yay!

Signed-off-by: Sage Weil <sage@inktank.com>
Reviewed-by: Samuel Just <sam.just@inktank.com>

osd: allow pg log trim during (non-classic) scrub

Chunky (and deep) scrub do not care about PG log trimming.  Classic scrub
still does.

Deep scrub can take a long time, so not trimming the log during that period
may eat lots of RAM; avoid that!

Might fix: #4179
Signed-off-by: Sage Weil <sage@inktank.com>
Reviewed-by: Samuel Just <sam.just@inktank.com>

Merge remote-tracking branch 'gh/wip_4257'

Reviewed-by: Sage Weil <sage@inktank.com>

mon: avoid expensive dump unless log will gather

Signed-off-by: Sage Weil <sage@inktank.com>

ceph_common.sh: tolerate missing mds, mon, osds in conf

With set -e this seems to fail (at least on some machines) if, say, there
is no MDS in the conf file.  This fixes it.

Tested-by: Mark Nelson <mark.nelson@inktank.com>
Signed-off-by: Sage Weil <sage@inktank.com>

Merge branch 'wip-4119'

Fix for bug 4119r, create directories under /var/lib/ceph.

testing: updating hadoop-internal test

Small tweaks to the hadoop-internal test
to better use existing environment varaibles
and in response to the recent teuthology
changes.

Signed-off-by: Joe Buck <jbbuck@gmail.com>
Reviewed-by: Noah Watkins <noahwatkins@gmail.com>

CephBroker.cc: fix condition

from cppcheck:
 Fix Suspicious condition (assignment + comparison); Clarify
 expression with parentheses.

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>

test: removing dead code

Signed-off-by: Joe Buck <jbbuck@gmail.com>

test: updating libcephfs-java tests

Recent changes in teuthology necessitate
changes to libcephfs-java test case.

Signed-off-by: Joe Buck <jbbuck@gmail.com>

Client.cc: reduce the scope of some variables

Reduce the scope of some variables.

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>

Client.cc: use static_cast instead of C-Style cast

Use static_cast<T>() instead of C-Style cast.

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>

Merge pull request #75 from alram/master

Typo: pool should be root in rados/operations/crush-map.rst

Reviewed-by: Sage Weil <sage@inktank.com>

Paxos.h: pass string name function parameter by reference

Pass 'const string name' function parameter by reference.

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>

Typo: pool should be root in rados/operations/crush-map.rst

Signed-off-by: Alexandre Marangone <alexandre.marangone@inktank.com>

Merge pull request #73 from dalgaaf/wip-da-sca-cppcheck-emptiness

fix more emptiness checks

Reviewed-by: Sage Weil <sage@inktank.com>

Merge pull request #74 from dalgaaf/wip-da-sca-misc

mds/journal.cc: fix assert in replay()

Let's see how many bugs this has been hiding... :)

Reviewed-by: Sage Weil <sage@inktank.com>

osd/ReplicatedPG.cc: remove unused variables

Remove unused variable declarations.

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>

osd_types.cc: add parenthesis around expression

Add parenthesis around expressions like (x && y & z).

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>

OSDMap.cc: add parenthesis around expression

Add parenthesis around expressions like (x && y & z).

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>

PGMonitor.cc: add parenthesis around expression

Add parenthesis around expressions like (x && y & z).

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>

Client.cc: add parenthesis around expression

Add parenthesis around expressions like (x && y & z).

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>

CephxProtocol.cc: catch end_of_buffer by reference

Follow 'Throw by value, catch by reference' to void copying and
potential slicing the exception.

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>

CephxProtocol.cc: catch error by reference

Follow 'Throw by value, catch by reference' to void copying and
potential slicing the exception.

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>