]>
git.apps.os.sepia.ceph.com Git - ceph.git/log
Mark Kogan [Wed, 30 Jul 2025 12:54:19 +0000 (12:54 +0000)]
rgw: add rate limit for LIST & DELETE ops
Add rate limiting specific to LIST ops,
similar to the current rate-limiting
(https://docs.ceph.com/en/latest/radosgw/admin/#rate-limit-management)
Example usage:
```
./bin/radosgw-admin ratelimit set --ratelimit-scope=user --uid=<UID> --max_list_ops=2
./bin/radosgw-admin ratelimit set --ratelimit-scope=user --uid=<UID> --max_delete_ops=2
./bin/radosgw-admin ratelimit enable --ratelimit-scope=user --uid=<UID>
./bin/radosgw-admin ratelimit get --ratelimit-scope=user --uid=<UID>
{
"user_ratelimit": {
"max_read_ops": 0,
"max_write_ops": 0,
"max_list_ops": 2,
"max_delete_ops": 2,
"max_read_bytes": 0,
"max_write_bytes": 0,
"enabled": true
}
}
pkill -9 radosgw
./bin/radosgw -c ./ceph.conf ...
aws --endpoint-url 'http://0:8000' s3 mb s3://bkt
aws --endpoint-url 'http://0:8000' s3 cp ./ceph.conf s3://bkt
aws --endpoint-url http://0:8000 s3api list-objects-v2 --bucket bkt --prefix 'ceph.conf' --delimiter '/'
{
"Contents": [
{
"Key": "ceph.conf",
"LastModified": "2025-07-30T13:59:38+00:00",
"ETag": "\"
13d11d431ae290134562c019d9e40c0e \"",
"Size": 32346,
"StorageClass": "STANDARD"
}
],
"RequestCharged": null
}
aws --endpoint-url http://0:8000 s3api list-objects-v2 --bucket bkt --prefix 'ceph.conf' --delimiter '/'
{
"Contents": [
{
"Key": "ceph.conf",
"LastModified": "2025-07-30T13:59:38+00:00",
"ETag": "\"
13d11d431ae290134562c019d9e40c0e \"",
"Size": 32346,
"StorageClass": "STANDARD"
}
],
"RequestCharged": null
}
aws --endpoint-url http://0:8000 s3api list-objects-v2 --bucket bkt --prefix 'ceph.conf' --delimiter '/'
argument of type 'NoneType' is not iterable
tail -F ./out/radosgw.8000.log | grep beast
...
beast: 0x7fffbbe09780: [30/Jul/2025:15:44:50.359 +0000] " GET /bkt?list-type=2&delimiter=%2F&prefix=ceph.conf&encoding-type=url HTTP/1.1" 200 535 - "aws-cli/2.15.31 Python/3.9.21 Linux/5.14.0-570.28.1.el9_6.x86_64 source/x86_64.rhel.9 prompt/off command/s3api.list-objects-v2" - latency=0.000999995s
beast: 0x7fffbbe09780: [30/Jul/2025:15:44:53.904 +0000] " GET /bkt?list-type=2&delimiter=%2F&prefix=ceph.conf&encoding-type=url HTTP/1.1" 200 535 - "aws-cli/2.15.31 Python/3.9.21 Linux/5.14.0-570.28.1.el9_6.x86_64 source/x86_64.rhel.9 prompt/off command/s3api.list-objects-v2" - latency=0.000999995s
vvv
beast: 0x7fffbbe09780: [30/Jul/2025:15:44:58.192 +0000] " GET /bkt?list-type=2&delimiter=%2F&prefix=ceph.conf&encoding-type=url HTTP/1.1" 503 228 - "aws-cli/2.15.31 Python/3.9.21 Linux/5.14.0-570.28.1.el9_6.x86_64 source/x86_64.rhel.9 prompt/off command/s3api.list-objects-v2" - latency=0.000000000s
beast: 0x7fffbbe09780: [30/Jul/2025:15:44:58.798 +0000] " GET /bkt?list-type=2&delimiter=%2F&prefix=ceph.conf&encoding-type=url HTTP/1.1" 503 228 - "aws-cli/2.15.31 Python/3.9.21 Linux/5.14.0-570.28.1.el9_6.x86_64 source/x86_64.rhel.9 prompt/off command/s3api.list-objects-v2" - latency=0.000999994s
beast: 0x7fffbbe09780: [30/Jul/2025:15:44:59.807 +0000] " GET /bkt?list-type=2&delimiter=%2F&prefix=ceph.conf&encoding-type=url HTTP/1.1" 503 228 - "aws-cli/2.15.31 Python/3.9.21 Linux/5.14.0-570.28.1.el9_6.x86_64 source/x86_64.rhel.9 prompt/off command/s3api.list-objects-v2" - latency=0.000000000s
s3cmd put ./ceph.conf s3://bkt/1
s3cmd put ./ceph.conf s3://bkt/2
s3cmd put ./ceph.conf s3://bkt/3
s3cmd rm s3://bkt/1
s3cmd rm s3://bkt/2
s3cmd rm s3://bkt/3
delete: 's3://bkt/1'
delete: 's3://bkt/2'
WARNING: Retrying failed request: /3 (503 (SlowDown))
WARNING: Waiting 3 sec...
WARNING: Retrying failed request: /3 (503 (SlowDown))
^^^
```
Fixes: https://tracker.ceph.com/issues/72894
Signed-off-by: Mark Kogan <mkogan@ibm.com>
Update PendingReleaseNotes
Co-authored-by: Yuval Lifshitz <yuvalif@yahoo.com>
Signed-off-by: Mark Kogan <31659604+mkogan1@users.noreply.github.com>
Update PendingReleaseNotes
Co-authored-by: Yuval Lifshitz <yuvalif@yahoo.com>
Signed-off-by: Mark Kogan <31659604+mkogan1@users.noreply.github.com>
Dan Mick [Tue, 26 Aug 2025 16:58:20 +0000 (09:58 -0700)]
Merge pull request #65222 from dmick/make-debs-remove-git-clean
Remove git clean -fdx
Matt Benjamin [Tue, 26 Aug 2025 16:21:57 +0000 (12:21 -0400)]
Merge pull request #63921 from pritha-srivastava/wip-rgw-d4n-iterate-connpool-pipeline
rgw/d4n: Integration of optimization in iterate, connection pool and pipelining
Casey Bodley [Tue, 26 Aug 2025 14:44:56 +0000 (10:44 -0400)]
Merge pull request #65130 from cbodley/wip-72643
rpm: default to gcc-toolset-13, not just for crimson
Reviewed-by: Matan Breizman <mbreizma@redhat.com>
afreen23 [Tue, 26 Aug 2025 12:56:41 +0000 (18:26 +0530)]
Merge pull request #65169 from afreen23/nfs-fix
mgr/dashboard: Dashboard nfs export editor rejects ipv6 addresses
Reviewed-by: Nizamudeen A <nia@redhat.com>
Zac Dover [Tue, 26 Aug 2025 12:43:18 +0000 (22:43 +1000)]
Merge pull request #65230 from anthonyeleven/bs-slow-op-alert
doc/rados/operations: Improve health-checks.rst
Reviewed-by: Zac Dover <zac.dover@proton.me>
Anthony D'Atri [Tue, 26 Aug 2025 11:38:58 +0000 (07:38 -0400)]
doc/rados/operations: Improve health-checks.rst
Signed-off-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
afreen23 [Tue, 26 Aug 2025 07:01:18 +0000 (12:31 +0530)]
Merge pull request #65019 from afreen23/ceph-status-api
Add /health/snapshot api
Reviewed-by: Nizamudeen A <nia@redhat.com>
Aashish Sharma [Tue, 26 Aug 2025 05:56:17 +0000 (11:26 +0530)]
Merge pull request #65208 from rhcs-dashboard/72717-test-host-tc-failing
mgr/dashboard: Fix test_host.py test case
Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Pritha Srivastava [Thu, 7 Aug 2025 05:09:10 +0000 (10:39 +0530)]
rgw/d4n: comment to suppress false positive
flagged by coverity
Signed-off-by: Pritha Srivastava <prsrivas@redhat.com>
Pritha Srivastava [Tue, 17 Jun 2025 06:07:16 +0000 (11:37 +0530)]
rgw/d4n: fix for rgw user create hanging when vstart
cluster starts when there is data in cache.
the cleaning thread sleeps when the entry for cleaning
has not expired, therefore radosgw-admin user create hangs
when vstart cluster comes up.
Signed-off-by: Pritha Srivastava <prsrivas@redhat.com>
Pritha Srivastava [Fri, 13 Jun 2025 11:35:44 +0000 (17:05 +0530)]
rgw/d4n: changes to integrate pipelining with connection pool.
Signed-off-by: Pritha Srivastava <prsrivas@redhat.com>
Pritha Srivastava [Tue, 22 Apr 2025 03:04:04 +0000 (08:34 +0530)]
rgw/d4n: add pipelining to PUT in write-cache
and read cache for data blocks directory entries
introduced a pipelined version of set command.
Signed-off-by: Pritha Srivastava <prsrivas@redhat.com>
Pritha Srivastava [Tue, 29 Apr 2025 11:12:18 +0000 (16:42 +0530)]
rgw/d4n: use boost::generic::response for bucket list operation.
1. test case to explore pipelining using boost::redis::generic_response
2. introduced a get method based on redis::generic_response
and used the same for Bucket::list.
Signed-off-by: Pritha Srivastava <prsrivas@redhat.com>
gal salomon [Wed, 11 Jun 2025 18:05:03 +0000 (21:05 +0300)]
the current connection setup is single and shared connection, the strand on that single connection may cause a serialization.
it should be noted that per s3-request there are several redis-operation that may run on co-routine.
the redis-connection pool implement the guarded acquire/release APIs.
adding configuration : rgw_redis_connection_pool_size.
re-factor of redis-exec* function.
shared pointer for Redis connection pool
adding branch predication optimization for redis-pool/single-shared-connection condition
adding a warning-report-method for the case there is a blocking state upon empty connection pool.
Signed-off-by: galsalomon66 <gal.salomon@gmail.com>
Dan Mick [Tue, 26 Aug 2025 00:45:21 +0000 (17:45 -0700)]
Remove git clean -fdx
either
1) a source tarball is supplied, in which case the local dir is
irrelevant, or
2) make-debs calls make-dist, which doesn't care about a dirty cwd
so it just punishes the unaware by removing things that they may
have wanted to keep.
Signed-off-by: Dan Mick <dan.mick@redhat.com>
Ilya Dryomov [Mon, 25 Aug 2025 22:19:09 +0000 (00:19 +0200)]
Merge pull request #64681 from athanatos/sjust/wip-rocky-10
rocky 10 build error fixes
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
Patrick Donnelly [Mon, 25 Aug 2025 18:34:30 +0000 (14:34 -0400)]
Merge PR #65217 into main
* refs/pull/65217/head:
.github: pass GITHUB_TOKEN to redmine-upkeep
.github/workflows: remove unnecessary permissions for leaving PR comments
script/redmine-upkeep: pass token to auth
script/redmine-upkeep: cleanup formatting for github comment
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Patrick Donnelly [Mon, 25 Aug 2025 16:07:40 +0000 (12:07 -0400)]
.github: pass GITHUB_TOKEN to redmine-upkeep
This was the actual problem preventing the script from leaving comments.
Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>
Patrick Donnelly [Thu, 21 Aug 2025 22:59:53 +0000 (18:59 -0400)]
.github/workflows: remove unnecessary permissions for leaving PR comments
https://docs.github.com/en/actions/reference/workflows-and-actions/workflow-syntax#permissions
Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>
Patrick Donnelly [Mon, 25 Aug 2025 15:02:31 +0000 (11:02 -0400)]
script/redmine-upkeep: pass token to auth
I believe I structured it this way originally because I had copied from
ptl-tool.py which used a personal github token.
Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>
Patrick Donnelly [Mon, 25 Aug 2025 16:19:34 +0000 (12:19 -0400)]
script/redmine-upkeep: cleanup formatting for github comment
Manually breaking the lines screws up the formatting of the comment in github.
Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>
John Mulligan [Mon, 25 Aug 2025 15:25:45 +0000 (11:25 -0400)]
Merge pull request #65190 from dmick/make-debs-no-tar-chown
make-debs.sh: invoke tar with --no-same-owner
Reviewed-by: John Mulligan <jmulligan@redhat.com>
Reviewed-by: David Galloway <david.galloway@ibm.com>
Anthony D'Atri [Mon, 25 Aug 2025 14:17:37 +0000 (09:17 -0500)]
Merge pull request #65180 from qiuxinyidian/doc
doc/dev:update blkin.rst doc for lttng trace
Abhishek Desai [Mon, 25 Aug 2025 14:11:45 +0000 (19:41 +0530)]
mgr/dashboard: Fix test_host.py test case
fixes: https://tracker.ceph.com/issues/72717
Signed-off-by: Abhishek Desai <abhishek.desai1@ibm.com>
Anthony D'Atri [Mon, 25 Aug 2025 14:09:45 +0000 (09:09 -0500)]
Merge pull request #64659 from anthonyeleven/fix-mds-units
Update CephFS option descriptions
Zac Dover [Mon, 25 Aug 2025 14:03:16 +0000 (00:03 +1000)]
Merge pull request #64074 from nh2/docs-config-more-commands
doc/rados/configuration: Mention show-with-defaults and ceph-conf
Reviewed-by: Zac Dover <zac.dover@proton.me>
Edwin Rodriguez [Mon, 25 Aug 2025 13:59:42 +0000 (09:59 -0400)]
Merge pull request #64969 from edwinzrodriguez/ceph-wip-72478
common/async:: Update delete operator in CompletionImpl
afreen23 [Mon, 25 Aug 2025 13:45:55 +0000 (19:15 +0530)]
Merge pull request #64827 from rhcs-dashboard/72408-rgw-crypt-kmip-addr-format-change
mgr/dashboard: rgw_crypt_kmip_addr in SSE-KMS kmip address input field validation updated
Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Ankush Behl <cloudbehl@gmail.com>
Casey Bodley [Mon, 25 Aug 2025 13:29:20 +0000 (09:29 -0400)]
Merge pull request #64440 from cbodley/wip-21128
rgw/s3: remove 'aws-chunked' from Content-Encoding response
Reviewed-by: Seena Fallah <seenafallah@gmail.com>
Matan Breizman [Mon, 25 Aug 2025 13:10:28 +0000 (16:10 +0300)]
Merge pull request #64993 from xxhdx1985126/wip-72539
crimson/os/seastore/object_data_handler: remove redundant indirect mappings at the end of ObjectDataHandler::clone()
Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Matan Breizman <mbreizma@redhat.com>
afreen23 [Mon, 25 Aug 2025 12:03:07 +0000 (17:33 +0530)]
Merge pull request #64951 from rhcs-dashboard/72522-remove-service-instances
mgr/dashboard : 72522 - Remove service instances column to imporve API perf
Reviewed-by: Afreen Misbah <afreen@ibm.com>
afreen23 [Mon, 25 Aug 2025 11:50:47 +0000 (17:20 +0530)]
Merge pull request #65102 from rhcs-dashboard/72608-optimize-host-api
mgr/dashboard : Optimized /host API to minimum resp
Reviewed-by: Nizamudeen A <nia@redhat.com>
Afreen Misbah [Wed, 13 Aug 2025 06:49:02 +0000 (12:19 +0530)]
mgr/dashboard: Add /health/snapshot api
Fixes https://tracker.ceph.com/issues/72609
- The current minimal API relies on fetching data from osdmap and pgmap.
- These commands produce large, detailed payloads that become a performance bottleneck and impact scalability, especially in large clusters.
- To address this, we propose switching to the ceph snapshot API using ceph status command, which retrieves essential information directly from the cluster map.
- ceph status is significantly more lightweight compared to osdmap/pgmap, reducing payload sizes and processing overhead.
- This change ensures faster response times, improves system efficiency in large deployments, and minimizes unnecessary data transfer.
- update tests
Signed-off-by: Afreen Misbah <afreen@ibm.com>
Afreen Misbah [Thu, 21 Aug 2025 09:41:43 +0000 (15:11 +0530)]
mgr/dashboard: Dashboard nfs export editor rejects ipv6 addresses
Fixes https://tracker.ceph.com/issues/72660
Signed-off-by: Afreen Misbah <afreen@ibm.com>
Aishwarya Mathuria [Mon, 25 Aug 2025 10:15:49 +0000 (15:45 +0530)]
Merge pull request #65165 from amathuria/wip-amat-splitting-fixes
crimson/osd: pg splitting fixes
Zac Dover [Mon, 25 Aug 2025 09:42:13 +0000 (19:42 +1000)]
Merge pull request #65185 from zdover23/wip-doc-2025-08-22-cephfs-troubleshooting
doc/cephfs: edit troubleshooting.rst (Slow MDS)
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Matan Breizman [Mon, 25 Aug 2025 08:21:33 +0000 (11:21 +0300)]
Merge pull request #65154 from chanyoung/fix-cbjournal-boundary-check
crimson/.../circular_journal_space: fix boundary check
Reviewed-by: Myoungwon Oh <ohmyoungwon@gmail.com>
Reviewed-by: Matan Breizman <mbreizma@redhat.com>
afreen23 [Mon, 25 Aug 2025 08:20:23 +0000 (13:50 +0530)]
Merge pull request #65027 from Hezko/nvmeof-cli-71983-fix
mgr/dashboard: fix missing gw group error
Reviewed-by: Nizamudeen A <nia@redhat.com>
Matan Breizman [Mon, 25 Aug 2025 08:20:09 +0000 (11:20 +0300)]
Merge pull request #65108 from zhscn/fix-assert
crimson/os/seastore/CBJournal: correct needs_roll condition
Reviewed-by: Myoungwon Oh <ohmyoungwon@gmail.com>
Matan Breizman [Mon, 25 Aug 2025 08:19:48 +0000 (11:19 +0300)]
Merge pull request #65070 from chanyoung/remove-redundant-memset
crimson/.../rbm_device: remove unnecessary zero fill in anonymous mmap
Reviewed-by: Myoungwon Oh <ohmyoungwon@gmail.com>
afreen23 [Mon, 25 Aug 2025 08:19:14 +0000 (13:49 +0530)]
Merge pull request #65028 from Hezko/nvmeof-cli-72060-fix
mgr/dashboard: catch broader exception to show relevant cli output
Reviewed-by: Nizamudeen A <nia@redhat.com>
Matan Breizman [Mon, 25 Aug 2025 08:18:40 +0000 (11:18 +0300)]
Merge pull request #64807 from myoungwon/wip-fix-report-rbm-block-size
crimson/os/seastore/rbm: fix incorrect reporting block size
Reviewed-by: Matan Breizman <mbreizma@redhat.com>
Matan Breizman [Mon, 25 Aug 2025 07:39:37 +0000 (10:39 +0300)]
Merge pull request #65007 from Matan-B/wip-matanb-crimson-docs-aug25
crimson: Simplify first time deployments
Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
Xuehan Xu [Tue, 12 Aug 2025 11:45:38 +0000 (19:45 +0800)]
crimson/os/seastore/object_data_handler: remove redundant indirect
mappings at the end of ObjectDataHandler::clone()
Fixes: https://tracker.ceph.com/issues/72539
Signed-off-by: Xuehan Xu <xuxuehan@qianxin.com>
Xuehan Xu [Fri, 22 Aug 2025 07:58:08 +0000 (07:58 +0000)]
crimson/os/seastore/lba_manager: add the interface method to remove
indirect mapping without touching the corresponding direct one
Signed-off-by: Xuehan Xu <xuxuehan@qianxin.com>
Dan Mick [Sat, 23 Aug 2025 18:43:44 +0000 (11:43 -0700)]
Merge pull request #65161 from dmick/uadk-arm64-date-time
uadk: remove __DATE__ and __TIME__ from compilation
Dan Mick [Sat, 23 Aug 2025 00:43:24 +0000 (17:43 -0700)]
make-debs.sh: invoke tar with --no-same-owner
When running as a normal user, tar does not attempt to preserve
owners set on the tar content files. When running as root, it does.
Containerized builds are running as root. Stop make-debs.sh from
trying to set other owners for files, and leaving files in the
host system with mapped UIDs other than the user running the container
(which causes jenkins to be unable to clear the workspace).
Signed-off-by: Dan Mick <dan.mick@redhat.com>
SrinivasaBharathKanta [Fri, 22 Aug 2025 23:45:13 +0000 (05:15 +0530)]
Merge pull request #64987 from aainscow/ceph-objectstore-tool-pgid-fix
tools: ceph-objectstore-tool check for invalid pgid
Ilya Dryomov [Fri, 22 Aug 2025 19:00:40 +0000 (21:00 +0200)]
Merge pull request #65177 from idryomov/wip-72692
mon/MonClient: post version request completions outside of monc_lock
Reviewed-by: Casey Bodley <cbodley@redhat.com>
Reviewed-by: Adam Emerson <aemerson@redhat.com>
John Mulligan [Fri, 22 Aug 2025 17:53:33 +0000 (13:53 -0400)]
Merge pull request #65178 from dmick/make-debs-keep-debug-pkgs
make-debs.sh: make "skip debug packages" conditional
Reviewed-by: John Mulligan <jmulligan@redhat.com>
Pritha Srivastava [Thu, 22 May 2025 11:11:55 +0000 (16:41 +0530)]
rgw/d4n: modified update method to optionally take a bool
for dirty flag, such that when a flag is not set, then the method
re-uses the old value of dirty flag using in-memory data structure.
This is helpful in eliminating a call to directory to fetch the
'dirty' flag in the flush() method.
Signed-off-by: Pritha Srivastava <prsrivas@redhat.com>
Pritha Srivastava [Thu, 22 May 2025 04:20:50 +0000 (09:50 +0530)]
rgw/d4n: avoid reading head block (attrs) from cache,
if they have already been read while reading permissions
for an object.
Signed-off-by: Pritha Srivastava <prsrivas@redhat.com>
Pritha Srivastava [Mon, 19 May 2025 11:27:15 +0000 (16:57 +0530)]
rgw/d4n: reading from local cache first in iterate()
method instead of checking directory first for existence
of cache blocks.
Signed-off-by: Pritha Srivastava <prsrivas@redhat.com>
Pritha Srivastava [Wed, 7 May 2025 06:05:13 +0000 (11:35 +0530)]
rgw/d4n: optimizing iterate method to align
last block also with max_chunk_size(object size
or rgw_max_chunk_size) and to perform checks
based on object size.
Signed-off-by: Pritha Srivastava <prsrivas@redhat.com>
Xuehan Xu [Fri, 22 Aug 2025 14:59:09 +0000 (22:59 +0800)]
crimson/os/seastore/transaction_manager: rewrite remove_mappings_in_range with coroutine
Signed-off-by: Xuehan Xu <xxhdx1985126@gmail.com>
Kefu Chai [Fri, 22 Aug 2025 12:57:40 +0000 (20:57 +0800)]
Merge pull request #63910 from tchaikov/wip-generate-test-instances
src: Fix memory leaks in generate_test_instance() by returning values instead of pointers
Reviewed-by: Casey Bodley <cbodley@redhat.com>
Ronen Friedman [Fri, 22 Aug 2025 08:41:06 +0000 (11:41 +0300)]
Merge pull request #65151 from ronen-fr/wip-rf-eccalc
osd/scrub: calculate EC digest map size only once
Reviewed-by: Jon Bailey <jonathan.bailey1@ibm.com>
Zac Dover [Fri, 22 Aug 2025 08:39:29 +0000 (18:39 +1000)]
doc/cephfs: edit troubleshooting.rst (Slow MDS)
Move the "Slow requests (MDS)" section immediately after the first
section in this document ("Slow/Stuck Operations"), because the first
procedure on the page directs the reader to undertake the operation in
"Slow requests (MDS)" before trying anything else.
Signed-off-by: Zac Dover <zac.dover@proton.me>
lizhipeng [Fri, 22 Aug 2025 03:53:52 +0000 (11:53 +0800)]
doc/dev:update blkin.rst doc for lttng trace
fixes:https://tracker.ceph.com/issues/72059
Signed-off-by: lizhipeng <qiuxinyidian@gmail.com>
Anthony D'Atri [Fri, 22 Aug 2025 04:19:35 +0000 (23:19 -0500)]
Merge pull request #64726 from anthonyeleven/funkycat
doc/man/8: Improve mount.ceph.rst
Samuel Just [Thu, 21 Aug 2025 23:05:10 +0000 (16:05 -0700)]
Merge pull request #65018 from athanatos/sjust/wip-store-bench-2
crimson/tool/crimson-store-bench: rework command line parsing, other fixes
Reviewed-by: Matan Breizman <mbreizma@redhat.com>
Anthony D'Atri [Wed, 23 Jul 2025 22:41:38 +0000 (18:41 -0400)]
Update CephFS option descriptions and unit
Signed-off-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
Anthony D'Atri [Thu, 21 Aug 2025 21:22:22 +0000 (16:22 -0500)]
Merge pull request #62017 from anthonyeleven/pg-target
src/common/options: Clarify mon_target_pg_per_osd in mgr.yaml.in
Anthony D'Atri [Thu, 21 Aug 2025 21:14:23 +0000 (16:14 -0500)]
Merge pull request #65052 from anthonyeleven/pending
doc: Improve PendingReleaseNotes
Anthony D'Atri [Thu, 21 Aug 2025 21:12:20 +0000 (16:12 -0500)]
Merge pull request #63858 from anthonyeleven/crimsoneye
src/crimson: Improve message
Anthony D'Atri [Thu, 21 Aug 2025 21:10:52 +0000 (16:10 -0500)]
Merge pull request #64053 from anthonyeleven/oompaloompa
doc: Improve central config log documentation
Anthony D'Atri [Thu, 14 Aug 2025 16:54:13 +0000 (09:54 -0700)]
doc: Improve PendingReleaseNotes
Signed-off-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
Dan Mick [Thu, 21 Aug 2025 20:00:43 +0000 (13:00 -0700)]
make-debs.sh: make "skip debug packages" conditional
Now that we're using make-debs.sh as a builder inside containers,
the default should be to build all the packages, including debug.
(Also, fix a typo.)
Signed-off-by: Dan Mick <dan.mick@redhat.com>
Tomer Haskalovitch [Tue, 12 Aug 2025 05:49:09 +0000 (08:49 +0300)]
mgr/dashboard: catch more exception to show relevant cli output
Signed-off-by: Tomer Haskalovitch <tomer.haska@ibm.com>
Tomer Haskalovitch [Mon, 11 Aug 2025 21:53:07 +0000 (00:53 +0300)]
mgr/dashboard: fix missing gw group error
Signed-off-by: Tomer Haskalovitch <tomer.haska@ibm.com>
Ilya Dryomov [Thu, 21 Aug 2025 19:39:29 +0000 (21:39 +0200)]
mon/MonClient: post version request completions outside of monc_lock
dispatch() is allowed to invoke the completion object in the current
thread, before control returns from dispatch(). This isn't desirable
when it comes to discarding version requests in MonClient::shutdown()
and MonClient::_reopen_session() because completion objects could then
be invoked under monc_lock. In case of MonClient::_reopen_session() in
particular, this leads to an attempt to acquire monc_lock once again in
MonClient::get_version() on a retry due to monc_errc::session_reset
that is converted to errc::resource_unavailable_try_again:
MonClient::ms_handle_reset
< takes monc_lock >
MonClient::_reopen_session
< invokes the completion object via dispatch() with ec == monc_errc::session_reset >
Objecter::CB_Objecter_GetVersion::operator() [ ec == errc::resource_unavailable_try_again ]
Objecter::_wait_for_latest_osdmap
MonClient::get_version
< attempts to take monc_lock in the body of the lambda >
The end result is either a lockup or some form of undefined behavior.
The best possible outcome here is an exception (std::system_error with
"Resource deadlock avoided" error) and a successive call to
std::terminate().
This is a regression introduced in commit
e81d4eae4e76 ("common/async:
Update `use_blocked` for newer asio"). Revert to posting version
request completions for the error cases in a way that is uniform with
the success case in MonClient::handle_get_version_reply().
Fixes: https://tracker.ceph.com/issues/72692
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
Igor Fedotov [Thu, 21 Aug 2025 19:13:21 +0000 (22:13 +0300)]
Merge pull request #63594 from ifed01/wip-ifed-max-perf-count
common/perf_counters: track maximum increment value for LONGRUNAVG perf
Reviewed-by: Ronnen Friedman <rfriedma@ibm.com>
Abhishek Desai [Mon, 11 Aug 2025 11:53:52 +0000 (17:23 +0530)]
mgr/dashboard : 72522 - Remove service instances column to imporve API perf
fixes : https://tracker.ceph.com/issues/72522
Signed-off-by: Abhishek Desai <abhishek.desai1@ibm.com>
Abhishek Desai [Sun, 17 Aug 2025 18:37:47 +0000 (00:07 +0530)]
mgr/dashboard : Optimized /host API to minimum resp
fixes : https://tracker.ceph.com/issues/72608
Signed-off-by: Abhishek Desai <abhishek.desai1@ibm.com>
Ronen Friedman [Thu, 21 Aug 2025 14:40:13 +0000 (09:40 -0500)]
test/osd/scrub: fix test_scrubber_be following EC Scrub b.e. changes
Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
Ronen Friedman [Tue, 12 Aug 2025 11:59:02 +0000 (06:59 -0500)]
osd/scrub: calculate EC digest map size only once
... and place the map itself in the scrub_chunk_t object.
Additionally - move object-specific scrub info out
of that chunk object.
Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
Ronen Friedman [Thu, 21 Aug 2025 18:13:12 +0000 (21:13 +0300)]
Merge pull request #65174 from JonBailey1993/fix-signed-compare-warning
erasure-code/consistency: Fixed signed-compare warning in Consistency Checker
Reviewed-by: Ronen Friedman <rfriedma@redhat.com>
Samuel Just [Tue, 12 Aug 2025 00:36:16 +0000 (17:36 -0700)]
crimson/.../store-bench: refactor arguments and workloads
- Adds a workload abstraction grouping arguments with associated
workload.
- Reworks argument parsing to occur prior to seastar app, allows
passing unparsed arguments to ceph.
- Refactors time usages as necessary to use std::chrono types.
- Removes LOG_PREFIX usages that don't currently have log lines.
- Other minor cleanups not worth separating out.
Signed-off-by: Samuel Just <sjust@redhat.com>
Matan Breizman [Mon, 11 Aug 2025 09:45:38 +0000 (09:45 +0000)]
crimson/tools/CMakeLists: store-bench to use lsan_suppressions
```
=================================================================
==598386==ERROR: LeakSanitizer: detected memory leaks
Direct leak of 8 byte(s) in 1 object(s) allocated from:
#0 0x7fc37fefd578 in operator new(unsigned long) (/lib64/libasan.so.8+0xfd578) (BuildId:
8843146064a37d00e17ca27fd774b31ebc6d40e2 )
#1 0x7fc37fa2fb71 in MallocExtension::Register(MallocExtension*) (/lib64/libtcmalloc.so.4+0x2fb71) (BuildId:
5fec9a5a81e329ba0c333f14020599650d07af6f )
SUMMARY: AddressSanitizer: 8 byte(s) leaked in 1 allocation(s).
```
Signed-off-by: Matan Breizman <mbreizma@redhat.com>
Matan Breizman [Mon, 11 Aug 2025 10:34:03 +0000 (10:34 +0000)]
crimson/tools/store_bench: bump up blocked_reactor_notify_ms
Signed-off-by: Matan Breizman <mbreizma@redhat.com>
Samuel Just [Thu, 24 Jul 2025 20:41:56 +0000 (13:41 -0700)]
spdk: update spdk submodule to include fix for rocky10 linker error
Signed-off-by: Samuel Just <sjust@redhat.com>
Samuel Just [Thu, 24 Jul 2025 21:44:39 +0000 (14:44 -0700)]
test/mds/TestQuiesceDb.cc: fix sequence point error for rocky 10
src/test/mds/TestQuiesceDb.cc:512:10: error: operation on 'q' may be undefined [-Werror=sequence-point]
Signed-off-by: Samuel Just <sjust@redhat.com>
Samuel Just [Thu, 21 Aug 2025 15:53:47 +0000 (08:53 -0700)]
Merge pull request #65017 from athanatos/sjust/wip-72579
crimson/.../fixed_kv_node: don't call copy_out if delta_buffer is empty
Reviewed-by: Xuehan Xu <xuxuehan@qianxin.com>
Jon [Thu, 21 Aug 2025 15:43:06 +0000 (16:43 +0100)]
erasure-code/consistency: Fixed signed-compare warning in ConsistencyChecker
Signed-off-by: Jon Bailey <jonathan.bailey1@ibm.com>
Aishwarya Mathuria [Thu, 21 Aug 2025 06:02:44 +0000 (06:02 +0000)]
crimson/osd: update snapmapper bits during pg splitting
SnapMapper bits for both parent and children PGs should be updated
during the splitting workflow
Signed-off-by: Aishwarya Mathuria <amathuri@redhat.com>
Aishwarya Mathuria [Thu, 21 Aug 2025 05:19:43 +0000 (05:19 +0000)]
crimson/osd: add snapmapper for split PGs
make_snapmapper_oid was missing for the new PGs created post-splitting.
This was causing a scrub error due to the missing snap mapper object in the children PGs.
Fixes: https://tracker.ceph.com/issues/72661
Signed-off-by: Aishwarya Mathuria <amathuri@redhat.com>
Aishwarya Mathuria [Fri, 1 Aug 2025 10:11:02 +0000 (10:11 +0000)]
crimson/osd/scrub: check if stats have been marked invalid
In case of splits/merges the PeeringState::split_into function will mark
the child and parent pgs stats invalid.
We need to check for this when scrub finishes, update the stats and mark them valid.
Fixes: https://tracker.ceph.com/issues/72676
Signed-off-by: Aishwarya Mathuria <amathuri@redhat.com>
Aishwarya Mathuria [Fri, 1 Aug 2025 10:13:56 +0000 (10:13 +0000)]
test_pg_splitting: add test for splitting with radosbench writes
Adds a test for splitting to start while a pool is being written to.
Signed-off-by: Aishwarya Mathuria <amathuri@redhat.com>
Aishwarya Mathuria [Fri, 1 Aug 2025 10:06:19 +0000 (10:06 +0000)]
crimson/osd/pg: discard ops in case of split
Clients will take care of re-sending the ops.
We can discard it here.
Signed-off-by: Aishwarya Mathuria <amathuri@redhat.com>
Jon Bailey [Thu, 21 Aug 2025 08:07:45 +0000 (09:07 +0100)]
Merge pull request #64564 from JonBailey1993/ceph_test_rados_io_sequence_set_optimisations_earlier
test/osd: Move initialisation of overwrites and optimisation earlier in ceph_test_rados_io_sequence
Reviewed-by: Ronen Friedman <rfriedma@redhat.com>
Zac Dover [Thu, 21 Aug 2025 07:50:56 +0000 (17:50 +1000)]
Merge pull request #65139 from zdover23/wip-doc-2025-08-20-releases-squid-indentation
doc/releases: remove RST-breaking indentation
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Kefu Chai [Mon, 9 Jun 2025 12:35:44 +0000 (20:35 +0800)]
src: Fix memory leaks in generate_test_instance() by returning values instead of pointers
Problem:
The current `generate_test_instance()` function returns `std::list<T*>`,
which creates memory management issues:
- Inconsistent lifecycle management of test instances
- Callers don't always properly clean up allocated memory
- Results in ASan memory leak reports in unit tests and ceph-dencoder
Solution:
Change `generate_test_instance()` to return `std::list<T>` instead of `std::list<T*>`:
Core Changes:
- Modified all classes with `generate_test_instance()` to return `std::list<T>`
- Use `emplace_back()` without parameters** to avoid copy/move
constructors for classes that don't define them
- Updated ceph-dencoder to handle the new return type
ceph-dencoder Adaptations:
Since `m_list` now holds `T` objects instead of `T*`, and we can't
assume `T` is copyable/moveable:
- Keep `m_object` as a pointer for flexibility
- Handle two scenarios:
1. `m_object` points to an element in `m_list`
2. `m_object` points to a decoded instance (requires manual cleanup)
- Introduce `make_ptr()` as a factory function to create a smart pointer
to conditionally free the managed pointer.
Additional Cleanup:
- Simplify DencoderBase constructor from template to plain
function (extra parameters were never used in derived classes)
With this change, object lifecycles are now managed by value semantics
instead of raw pointers, eliminating memory leaks.
Signed-off-by: Kefu Chai <tchaikov@gmail.com>
Kefu Chai [Thu, 21 Aug 2025 07:18:06 +0000 (15:18 +0800)]
Merge pull request #65075 from tchaikov/wip-transaction-set-unused
os/Transaction: initialize unused fields in TransactionData
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Reviewed-by: Bill Scales <bill_scales@uk.ibm.com>
Guillaume Abrioux [Thu, 21 Aug 2025 06:51:42 +0000 (08:51 +0200)]
Merge pull request #64833 from exkson/wip-exkson-ignore-invalid-loop-devices
ceph-volume: avoid RuntimeError on ceph-volume raw list with non-existent loop devices
Dan Mick [Wed, 20 Aug 2025 23:34:23 +0000 (16:34 -0700)]
Merge pull request #65156 from phlogistonjohn/jjm-make-rpm-nicer
build-with-container: improve source rpm detection
Dan Mick [Thu, 14 Aug 2025 19:04:39 +0000 (12:04 -0700)]
uadk: build with ceph fork (fix for __DATE__ usage)
Signed-off-by: Dan Mick <dan.mick@redhat.com>
John Mulligan [Wed, 20 Aug 2025 21:05:54 +0000 (17:05 -0400)]
Merge pull request #65055 from dmick/build-with-container-npmcache
pybind/mgr/dashboard/frontend: add NPM_CACHEDIR envvar, use in bwc
Reviewed-by: John Mulligan <jmulligan@redhat.com>
Adam King [Wed, 20 Aug 2025 20:55:33 +0000 (16:55 -0400)]
Merge pull request #65069 from phlogistonjohn/jjm-fix-ports-remotectl
smb: fix custom ports feature with remote-control sidecar
Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Anoop C S <anoopcs@samba.org>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Niklas Hambüchen [Sat, 21 Jun 2025 17:46:13 +0000 (19:46 +0200)]
doc/rados/configuration: Mention show-with-defaults and ceph-conf
A small improvement based on
"Why is it still so difficult to just dump all config and where it comes from?"
https://lists.ceph.io/hyperkitty/list/ceph-users@ceph.io/thread/EZSLRYBYEWDA6YIARQVMUKQUWHAE3PGR/
`show-with-defaults` is very useful, and `ceph-conf` is mentioned
so that it's clear that it's legacy, and the user doesn't have to
wonder if it's actually useful but was forgotten in the list.
Signed-off-by: Niklas Hambüchen <mail@nh2.me>