rgw: fix pipes zone wildcard match logic

and improve logging

Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>

rgw-admin: bucket sync status related fixes and improvements

Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>

rgw: use negative shard id when creating sync pair

negative shard id means the bucket has a single shard. This
is to be backward compatible.

Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>

rgw: remove unneeded #warnings

and other cleanups

Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>

rgw: sync: only update data log if bucket exports data

Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>

rgw: pubsub: user source bucket owner for event, not dest

Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>

rgw: remove a #warning with a comment

It's a nice to have, not crucial

Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>

rgw: sync: object sync info oid depends on pipe

The object sync info object (used in cloud sync module) depends on pipe. Different
oid is crafted if source and destination buckets are not the same.

Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>

rgw: data sync: guard against racing source object change

Source object might have changed since we tried to sync it,
and the decisions we made originally might be irrelevant.
After reading object header, check if the original dest params
are the same dest params we find now for this object, otherwise
need to retry.

Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>

rgw: sync: override dest object owner if needed

Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>

rgw: data sync: check user permission in user level sync

Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>

rgw: auth: api to create auth identity without req_state

Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>

rgw: api to check bucket and object permissions without need for req_state

Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>

rgw: sync: user mode sync pipes fetch objects using effective uid

Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>

rgw: prepare for system and user mode changes

Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>

rgw: data sync: handle preconfition failed error

Handle precondition failed error. This would happen in case we cannot
sync the object due to either newer local changes, or if the policy
doesn't allow syncing the specific object. Handle this as success, but
log a message.

Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>

rgw: http client: propagate errors in client callbacks

If one of the callbacks return error, stop the processing and set that
as the request error.

Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>

rgw: filter fetch remote obj after reading remote metadata

In the sync case: find the appropriate pipe params that match this
remote object (if matches tags / prefix), and adjust fetch if needed --
abort if doesn't match tags. Later will adjust acls as needed (if user
sync and not system).

Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>

rgw: find pipe rules param for specific obj changes

 - reuse RGWObjTags::tag_map_t instead of vector of strings
 - fix the prefix search

Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>

rgw: sync: add mode (system, user) as a pipe param

Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>

rgw-admin: add delimiter to tags parsing

Otherwise it will use '=' as a delimiter, and need to preserve it as
part of the tag initially.

Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>

rgw-admin: minor message fix

Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>

rgw: sync policy: reorganize a bit

Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>

ceph_json: json encoding filter

Can create and register a filter (that will be pointed at by the formatter
as an external feature), that could be then used to replace default
encoders for specific data types. This can be useful in cases where
we want to mutate the output (for example: translate zone ids to zone
names on the fly).

Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>

rgw, radosgw-admin: explicit zone id type

Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>

rgw: sync: resolve hints when initializing policy handler

Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>

rgw: modify zone_trace for bucket granularity info

Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>

rgw: data sync: incremental prefixes

Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>

rgw: sync: full sync checks for rules prefixes

Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>

rgw: use pipe handlers instead of pipes off pipe_set

Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>

rgw: sync: pipe rules handler

Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>

rgw: propagate sync pipe params down the stack

Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>

rgw-admin: add option to configure sync pipe prefix, tags

Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>

rgw: sync: extend data structures to extend bucket sync functionality

Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>

rgw: data sync: use hints when determining sync pipes

Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>

rgw: data sync: resolve pipes by bucket sync hints

Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>

rgw-admin: sync info shows and resolve bucket sync hints

Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>

rgw: manage bucket sync deps index

Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>

rgw: identify potential related (for sync) buckets on bucket update

Generate a diff off old and new bucket infos.

Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>

rgw: svc.zone: keep policy handler for all zones

So that we can use the correct policy handler when checking source bucket.
Also build list of source zones for data sync out of all potential zones,
and not just the ones that are enabled, because it can be enabled at the
bucket level.

Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>

rgw: sync: fixes

Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>

rgw: data sync: trigger per shard sync by source and target

and tie to data log sync

Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>

rgw: data sync: rework RGWGetBucketPeersCR

so that it returns pipes with bucket info

Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>

rgw: data sync: more work towards new policy integration

RGWGetBucketPeersCR will be able to return correct buckets
that need to sync, either by a target bucket, and/or a source
zone and a source bucket (partially implemented).

Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>

rgw: sync: bucket sync manager adjustments for new system

Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>

rgw: sync: encoding fixes

Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>

rgw: modify sync policy handler api

Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>

rgw: sync: bucket sync status changes

Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>

rgw: fix, cleanup

Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>

rgw: sync flow handler: integrate with flow manager

Convert zone names to zone ids, adjust interfaces.

Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>

rgw: sync flow: init zone level sync flow manager

Hold the zone level sync flow manager in the zone svc. Convert old
zonegroup sync config into new sync policy structure.

Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>

rgw: sync policy mgr: more fixes

Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>

rgw: move code around

Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>

rgw: sync policy: cleanups and fixes

Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>

rgw: rgw_bucket operator fixes

Fix smaller-than operator, ostream operator.

Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>

rgw: flow manager generates explicit pipes

Have multiple pipes instead of having a single pipe that can describe
 multiple different zones have multiple pipes, each point at a single
zone (or all zones).

Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>

rgw: use single entity in expanded sync determination

Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>

rgw: rename some datastructures to signify plurality

pipe -> pipes, entity -> entities

Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>

rgw: bucket flow manager initialization changes

Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>

rgw-admin: add 'sync info' command

Also move code into header so that flow manager could be used in radosgw-admin

Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>

rgw-admin: manage sync policy at the bucket level

Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>

rgw: move code around

Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>

rgw_admin: code cleanup

Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>

rgw-admin: sync group pipe create and remove

also rename sync group flow add to sync group flow create.

Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>

rgw-admin: sync group get command

Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>

rgw-admin: sync group flow remove command

and also some code cleanup.

Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>

rgw-admin: sync group flow add command

Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>

rgw: bucket sync, change "target" to "dest"

Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>

rgw: json dump sync groups map as vector

looks nicer

Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>

rgw-admin: sync group create/remove commands

Still incomplete

Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>

rgw: sync policy logic

Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>

rgw: redo policy definitions

Still incomplete

Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>

rgw: compilation fixes

Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>

rgw-admin: sync policy related commands

Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>

rgw: add sync policy to zonegroup

and move code around

Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>

rgw-admin: bucket sync info command

Dumps bucket sources

Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>

rgw: pass through bucket sync pairs

Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>

rgw: define bucket sync pipes

Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>

rgw: bucket sync: read local bucket sources

And also add functionality to get bucket sync policy handler (in cr).
Next we'll need to compare local bucket sources with what policy
handler defines, and act if it's different.

Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>

rgw: defined bucket sync sources manager

Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>

rgw: data sync: split RGWDataSyncEnv

Keep only the environment related fields in there, and have the
sync info related stuff in the containing RGWDataSyncCtx.

Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>

rgw: reduce use of sync_env->store

Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>

rgw: data sync: rename current bucket sync crs

Add the 'pipe' term as bucket can be synced on multiple pipes.

Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>

rgw: ctl.bucket: add bucket sync related methods

Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>

rgw: svc.bucket_sync: add new svc for dealing with bucket sync policy

svc.bucket_sync_sobj keeps a cache of bucket sync policies (per bucket
instance), and chains to the metadata cache.

Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>

rgw: rework sync policy

Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>

rgw: define sync policy structures

Defines sync policy for both zones and buckets.

Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>

rgw: remove unused variable

Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>

rgw: sync: separate source and dest bucket

This is still incomplete. The idea is that source bucket and destination
bucket do not need to reflect the same entity.

Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>

rgw: bucket sync: integrate bucket sync decisions

Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>

rgw: store data log entry if bucket sync policy not empty

Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>

rgw: bucket-granularity sync: define policy structure

Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>

rgw: test-multi: craft admin command line options differently

The problem was specifically with the "--rgw-cache-enabled false" param. This
doesn't work like that anymore, need to either pass --rgw-cache-enabled=false,
or --no-rgw-cache-enabled.

Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>

rgw-admin: dump command if not found

Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>

rgw-admin: split remove and delete aliases

Since "zonegroup remove" and "zonegroup delete" are different commands,
don't have them share the same aliases.

Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>

rgw-admin: add "zonegroup remove zone" command

Does the same as "zonegroup remove", but should be used instead of it
as we also have a different "zonegroup delete" command.

Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>

rgw-admin: cmdline, dump expected commands on error

Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>

rgw-admin: adjust commands

Add missing definitions needed for backward compatibility.

Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>

rgw-admin: use strongly typed enum for cmdline options

Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>

rgw-admin: cmdline, use generic std::any to hold value

Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>