crimson/os/alienstore: assert on failure

before we have a failure recovery, better off failing fast.

Signed-off-by: Kefu Chai <kchai@redhat.com>

crimson/os: pin the last cpu core for the alien worker threads

before this change, we assume that we have at least current_shared + 10
cores. but that's not always true. so in this change, the last core
is used for performing the alien tasks scheduled by reactor.

Signed-off-by: Kefu Chai <kchai@redhat.com>

Merge pull request #35657 from athanatos/sjust/wip-lba-replay

crimson/seastore: add extent replay support, implement for lba tree nodes

Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #35370 from tspmelo/wip-ng-modal

mgr/dashboard: Use ng-bootstrap for Modal

Reviewed-by: Stephan Müller <smueller@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>

Merge pull request #34532 from rhcs-dashboard/wip-45068-fix-parse-error

mgr/dashboard: Prometheus query error in the metrics of Pools, OSDs and RBD images

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Volker Theile <vtheile@suse.com>

Merge pull request #35576 from sebastian-philipp/cephadm-etc-ceph-ceph-conf

mgr/cephadm: Manage /etc/ceph/ceph.conf

Reviewed-by: Joshua Schmid <jschmid@suse.de>
Reviewed-by: Michael Fritch <mfritch@suse.com>

Merge pull request #35565 from bk201/wip-44985

mgr/dashboard: fix wal/db slots controls in the OSD form

Reviewed-by: Stephan Müller <smueller@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>

Merge pull request #35779 from votdev/show_yes_no

mgr/dashboard: Display check icon instead of true|false in various datatables

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Stephan Müller <smueller@suse.com>
Reviewed-by: Tiago Melo <tmelo@suse.com>

Merge pull request #35615 from ishanrai05/scss-linting

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Tiago Melo <tmelo@suse.com>

Merge PR #35826 into master

* refs/pull/35826/head:
mds: fix typo in MDSSocketHook

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

Merge pull request #35729 from rzarzynski/wip-bl-deprecate-claim

common/bl, *: deprecate bufferlist::claim() and switch to rvalue-taking operator=()

Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>

Merge pull request #35833 from smithfarm/wip-rn_14_2_10

doc/releases/nautilus: add 14.2.10 release notes

Reviewed-By: Abhishek Lekshmanan <abhishek@suse.com>

doc/releases/nautilus: add 14.2.10 release notes

Signed-off-by: Nathan Cutler <ncutler@suse.com>

Merge pull request #35786 from matthewoliver/cephadm_iscsi_remove_pool_cap

cephadm: ceph-iscsi remove pool from cap

Reviewed-by: Michael Fritch <mfritch@suse.com>

Merge pull request #35800 from jan--f/drive-groups-tidy-interface

py-common/deployment/translate: drop unneeded ctor arg

Reviewed-by: Sebastian Wagner <sebastian.wagner@suse.com>

Merge pull request #35781 from rhcs-dashboard/fix-bucket-list-columns-ui

mgr/dashboard: fix UI of the columns for rgw-bucket-list

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Volker Theile <vtheile@suse.com>

common/bl, *: deprecate list::claim() in favor of operator=(list&&).

The motivation is that `claim(list&)` seems to actually be a pre-C++11
counterpart of the already available `operator=(list&&)`.
This commit deprecates the `claim()` method but doesn't drop it yet.

All occurrences of `buffer::list::claim(list&)` are switched to
  * `list::operator=(list&&)` or
  * reworked to use `list::list(list&&)` instead.

Changes are applied to: rgw, osdc, osd, os/memstore, os/filestore,
os/bluestore, os, msg, mgr, messages, mds, librbd, librados, crimson,
common, cls, mon.

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>

mds: fix typo in MDSSocketHook

Signed-off-by: Xiubo Li <xiubli@redhat.com>

Merge pull request #34311 from cyx1231st/wip-seastar-fix-heartbeat-race

crimson/osd: support 1 lossy connection between a heartbeat peer

Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #35815 from inspur-wyq/wip-doc-radosgw-archive-sync-module

doc/radosgw/archive-sync-module: fix url of "Multisite Configuration"

Reviewed-by: Kefu Chai <kchai@redhat.com>

crimson/osd: improve readability of Heartbeat::Peer classes

* Add rationales to introduce Heartbeat::Peer class series.
* Find better names for internal interfaces.

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>

Merge pull request #35787 from tchaikov/wip-46208

install-deps,cmake: use boost v1.73

Reviewed-By: Josh Durgin <jdurgin@redhat.com>

Merge pull request #35771 from sebastian-philipp/mypy-0.782

qa,src: update mypy to 0.782

Reviewed-by: Alfonso Martínez <almartin@redhat.com>

Merge pull request #35763 from rzarzynski/wip-test-unused-var-in-test_ino_release_cb

test: fix unused variable warning in test_ino_release_cb.cc.

Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #35666 from inspur-wyq/wip-debian-cmake-version

debian: update cmake version to cmake_minimum_required(VERSION 3.10.2)

Reviewed-by: Kefu Chai <kchai@redhat.com>

doc/radosgw/archive-sync-module.rst: fix url of "Multisite Configuration"

Signed-off-by: wangyunqing <wangyunqing@inspur.com>

Merge pull request #35750 from rzarzynski/wip-common-config-dissect-boolcast

common, crimson: reuse the interpreter of Option::TYPE_BOOL

Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #35512 from ZhenLiu94/liuz02

src/mon/MonCommands.h: Remove the redundant right parenthesis in the help message

Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #35760 from tchaikov/wip-mgr-track-pending-module

mgr: avoid false alarm of MGR_MODULE_ERROR

Reviewed-By: Josh Durgin <jdurgin@redhat.com>

json_spirit: avoid using bind placeholders in global namespace

to silence the warning from boost v1.73, like

json_spirit/json_spirit_reader.cpp:7:
/opt/ceph/include/boost/bind.hpp:36:1: note: ‘#pragma message: The practice of declaring the Bind placeholders (_1, _2, ...) in the global namespace is deprecated. Please use <boost/bind/bind.hpp> +
using namespace boost::placeholders, or define BOOST_BIND_GLOBAL_PLACEHOLDERS to retain the current behavior.’
   36 | BOOST_PRAGMA_MESSAGE(
      | ^~~~~~~~~~~~~~~~~~~~

Signed-off-by: Kefu Chai <kchai@redhat.com>

make-dist: redistribute boost 1.73

Fixes: https://tracker.ceph.com/issues/46208
Signed-off-by: Kefu Chai <kchai@redhat.com>

py-common/deployment/translate: drop unneeded ctor arg

The DriveGroupSpec is already part of the DriveSelection.

Fixes: https://tracker.ceph.com/issues/46231
Signed-off-by: Jan Fajerski <jfajerski@suse.com>

Merge pull request #35490 from sseshasa/wip-grace-interval-timer-reset

mon/OSDMonitor: Reset grace period if failure interval exceeds a threshold.

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>

qa,src: update mypy to 0.782

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>

Merge pull request #35791 from tchaikov/wip-mock-rados

script/gen_static_command_descriptions: add mock for rados python binding

Reviewed-by: Sebastian Wagner <sebastian.wagner@suse.com>

script/gen_static_command_descriptions: add mock for rados python binding

to address issue like

Traceback (most recent call last):
  File "/home/jenkins-build/build/workspace/ceph-pr-docs/doc/scripts/../../src/script/gen_static_command_descriptions.py", line 168, in <module>
    print(json.dumps(gen_commands_dicts(), indent=2, sort_keys=True))
  File "/home/jenkins-build/build/workspace/ceph-pr-docs/doc/scripts/../../src/script/gen_static_command_descriptions.py", line 163, in gen_commands_dicts
    comms = from_mon_commands_h() + from_mgr_modules()
  File "/home/jenkins-build/build/workspace/ceph-pr-docs/doc/scripts/../../src/script/gen_static_command_descriptions.py", line 85, in from_mgr_modules
    comms = sum([list_mgr_module(name) for name in names], [])
  File "/home/jenkins-build/build/workspace/ceph-pr-docs/doc/scripts/../../src/script/gen_static_command_descriptions.py", line 85, in <listcomp>
    comms = sum([list_mgr_module(name) for name in names], [])
  File "/home/jenkins-build/build/workspace/ceph-pr-docs/doc/scripts/../../src/script/gen_static_command_descriptions.py", line 65, in list_mgr_module
    mgr_mod = __import__(m_name, globals(), locals(), [], 0)
  File "/home/jenkins-build/build/workspace/ceph-pr-docs/src/pybind/mgr/volumes/__init__.py", line 2, in <module>
    from .module import Module
  File "/home/jenkins-build/build/workspace/ceph-pr-docs/src/pybind/mgr/volumes/module.py", line 8, in <module>
    from .fs.nfs import NFSCluster, FSExport
  File "/home/jenkins-build/build/workspace/ceph-pr-docs/src/pybind/mgr/volumes/fs/nfs.py", line 6, in <module>
    from rados import TimedOut
ImportError: cannot import name 'TimedOut'

Signed-off-by: Kefu Chai <kchai@redhat.com>

cmake: download and build boost 1.73 if it is not installed

Fixes: https://tracker.ceph.com/issues/46208
Signed-off-by: Kefu Chai <kchai@redhat.com>

cmake: update FindBoost.cmake for 1.73

adapted from
https://github.com/Kitware/CMake/blob/master/Modules/FindBoost.cmake
commit b76b4dea1cd60e9899fd641602901ded9e0d7a7b

Fixes: https://tracker.ceph.com/issues/46208
Signed-off-by: Kefu Chai <kchai@redhat.com>

install-deps.sh: use ceph-libboost1.73

Fixes: https://tracker.ceph.com/issues/46208
Signed-off-by: Kefu Chai <kchai@redhat.com>

Merge pull request #34744 from ceph/rhbz-1827349

ceph-volume: handle idempotency with batch and explicit scenarios

Merge pull request #35468 from guits/guits-raw_dmcrypt

ceph-volume: add dmcrypt support in raw mode

mgr/dashboard: run lint and fix scripts in parallel

use npm-run-all package to run all the lint scripts and fix
scripts in parallel

Fixes: https://tracker.ceph.com/issues/46108
Signed-off-by: Ishan Rai <ishanrai05@gmail.com>

Merge pull request #35770 from tchaikov/wip-install-deps

install-deps.sh: drop el7 bits and uninstall python-sphinx if sphinx-build is in python2

Reviewed-by: Lenz Grimmer <lgrimmer@suse.com>
Reviewed-by: Laura Paduano <lpaduano@suse.com>
Reviewed-by: Deepika Upadhyay <dupadhya@redhat.com>

cephadm: ceph-iscsi remove pool from cap

When we create a ceph-iscsi daemon/continer in cephadm we create a user
and set some caps. Turns out we were a little too restrictive.

We were locking down to only access the pool that was given in the spec,
which happens to be the pool the iscsi config is stored. But in reality
we need to be able  to attach any rbd images which could exist in other
pools.

So this patch removes the `pool=` from the osd cap, so from:

   osd = allow rwx pool={spec.pool}

To:

   osd = allow rwx

Fixes: https://tracker.ceph.com/issues/46138
Signed-off-by: Matthew Oliver <moliver@suse.com>

Merge PR #31726 into master

* refs/pull/31726/head:
mds: MDS-MDS message classes inherit from MMDSOp
mds: MMDSOp implementation and detect unversioned messages

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

Merge PR #34878 into master

* refs/pull/34878/head:
libcephfs: mark ceph_stat() family functions deprecated

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Jeff Layton <jlayton@redhat.com>

Merge PR #35323 into master

* refs/pull/35323/head:
tool: change coding style, indent with two spaces

Reviewed-by: Zheng Yan <zyan@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge PR #35420 into master

* refs/pull/35420/head:
mgr/volumes: Fix pool removal on volume deletion

Reviewed-by: Ramana Raja <rraja@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Jos Collin <jcollin@redhat.com>

Merge PR #35624 into master

* refs/pull/35624/head:
include: cleanup lru con/des

Reviewed-by: Jos Collin <jcollin@redhat.com>

Merge PR #35664 into master

* refs/pull/35664/head:
qa: add omit_sudo=False for commands ran with sudo

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Xiubo Li <xiubli@redhat.com>

ceph-volume: remove unused function

This function is never called in raw context, let's remove it.

Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>

ceph-volume: add raw testing coverage

This commit adds testing against `ceph-volume raw` subcommand.

Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>

ceph-volume: add dmcrypt support in raw mode

This commit adds the dmcrypt support in `ceph-volume raw` mode.

Note about `ceph-volume raw list` change:
Given `lsblk -J` (json output) option isn't available on all OS, I came up with
adding '--inverse' option to the existing command which allows us to get the
mapper devices list in that command output. Not listing root devices containing
partitions shouldn't have side effect since we are in `ceph-volume raw`
context.

example:
running `lsblk --paths --nodeps --output=NAME --noheadings` doesn't allow to
get the mapper list because the output is like following :

$ lsblk --paths --nodeps --output=NAME --noheadings
/dev/sda
/dev/sdb
/dev/sdc
/dev/sdd

the dmcrypt mappers are hidden because of the `--nodeps` given they are
displayed as a dependency.

$ lsblk --paths --output=NAME --noheadings
/dev/sda
|-/dev/mapper/ceph-3b52c90d-6548-407d-bde1-efd31809702f-sda-block-dmcrypt
`-/dev/mapper/ceph-3b52c90d-6548-407d-bde1-efd31809702f-sda-db-dmcrypt
/dev/sdb
/dev/sdc
/dev/sdd

adding `--inverse` is a trick to get around this issue, the counterpart is that
we can't list root devices if they contain at least one partition but this
shouldn't be an issue in `ceph-volume raw` context given we only deal with
raw devices.

Fixes: https://tracker.ceph.com/issues/45959
Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>

Merge PR #35757 into master

* refs/pull/35757/head:
doc: update cephfs metadata pool recovery procedure

Reviewed-by: Douglas Fuller <dfuller@redhat.com>

Merge pull request #35537 from sebastian-philipp/cephadm-yaml-ordered-readable

mgr/orch: increase readability for yaml representation

Merge pull request #35274 from jmolmo/issue_45726

cephadm: error trying to get ceph auth entry for crash daemon

Reviewed-by: Sebastian Wagner <sebastian.wagner@suse.com>

Merge pull request #35773 from theanalyst/master-rgw-cors-fixes

rgw: sanitize newlines in s3 CORSConfiguration's ExposeHeader

Reviewed-By: Casey Bodley <cbodley@redhat.com>
Reviewed-By: Abhishek Lekshmanan <abhishek@suse.com>
Reviewed-By: Josh Durgin <jdurgin@redhat.com>

mgr/dashboard: fix UI of the columns for rgw-bucket-list

Fixes: https://tracker.ceph.com/issues/46210
Signed-off-by: Avan Thakkar <athakkar@redhat.com>

doc: update cephfs metadata pool recovery procedure

This is mostly clarifying a few things after personally experimenting
with this.

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>

Merge pull request #35695 from sebastian-philipp/mypy-rm-global-ignore-imports

mypy.ini: Remove global `ignore_missing_imports = True`

Reviewed-by: Thomas Bechtold <tbechtold@suse.com>

Merge pull request #35762 from sebastian-philipp/doc-dev-rm-confusing.txt

doc/dev: remove confusing.txt

Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #35503 from sebastian-philipp/rm-daemon-ok-to-stop

mgr/cephadm: move ok_to_stop to CephadmService

Reviewed-by: Kyr Shatskyy <kyrylo.shatskyy@suse.com>
Reviewed-by: Michael Fritch <mfritch@suse.com>

Merge pull request #35761 from sebastian-philipp/qa-cephad-upgrade-no-rgw

qa/cephadm/upgrade: Exclude RGW for now

Reviewed-by: Michael Fritch <mfritch@suse.com>

Merge pull request #33228 from galsalomon66/s3select_integration_into_RGW_2

rgw: add s3select support

mgr/dashboard: Display check icon instead of true|false in various datatables

- Convert the boolean values true|false to a check icon in datatable columns.
- Remove unused code in the user management list.

Fixes: https://tracker.ceph.com/issues/46209
Signed-off-by: Volker Theile <vtheile@suse.com>

Merge pull request #35593 from p-se/wip-pse-cephadm-grafana-fix-version

mgr/cephadm: use fixed Grafana version

Reviewed-by: Sebastian Wagner <sebastian.wagner@suse.com>

mgr/cephadm: Manage /etc/ceph/ceph.conf

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>

mgr/tests: _ceph_get_module_option returns proper type now.

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>

mgr/cephadm: config_notify now provides a hook

reason is, we want to use this hook to schedule a
ceph.conf update for all hosts.

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>

mgr/cephadm: refactor _run_cephadm

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>

python-common: Add simple str(HostSpec)

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>

mgr/cephadm: add type hints for _refresh_host_*()

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>

mgr/dashboard: Use ng-bootstrap for Modal

Fixes: https://tracker.ceph.com/issues/45759
Signed-off-by: Tiago Melo <tmelo@suse.com>

Merge pull request #34606 from rhcs-dashboard/wip-45011-bucket-usage-feature

mgr/dashboard: Display users current bucket quota usage

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Stephan Müller <smueller@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>

rgw: sanitize newlines in s3 CORSConfiguration's ExposeHeader

the values in the <ExposeHeader> element are sent back to clients in a
Access-Control-Expose-Headers response header. if the values are allowed
to have newlines in them, they can be used to inject arbitrary response
headers

this issue only affects s3, which gets these values from an xml document

in swift, they're given in the request header
X-Container-Meta-Access-Control-Expose-Headers, so the value itself
cannot contain newlines

Signed-off-by: Casey Bodley <cbodley@redhat.com>
Reported-by: Adam Mohammed <amohammed@linode.com>

install-deps.sh: always use python3-sphinx to build the docs

python-sphinx creates a symlink pointing ../share/sphinx/scripts/python2/sphinx-build
to /usr/bin/sphinx-build even if python3-sphinx is already installed.
in that case, if python-sphinx is installed after python3-sphinx,
sphinx-build is in python2. and it breaks the build of master, as we are
using python3 syntax in conf.py since
e9e17b9ceff0c862c8f29d629ad54a1dc401ed73.

and we are still using python2 as well as "python-sphinx" when building nautilus,
so if a build slave happen to compile nautilus before it is scheduled to
build master or a wip- branch, the doc build fails.

in this change, python-sphinx is uninstalled, if /usr/bin/sphinx-build
is found to be written in python2.

Signed-off-by: Kefu Chai <kchai@redhat.com>

install-deps.sh: always use dnf on RHEL/CentOS

as we don't build master on el7 anymore.

Signed-off-by: Kefu Chai <kchai@redhat.com>

install-deps.sh: drop bits enabling DTS repo

since GCC offered by RHEL8/CentOS8 is able to compile ceph, there is no
need to add repos providing devtoolset anymore.

Signed-off-by: Kefu Chai <kchai@redhat.com>

Merge pull request #35419 from votdev/issue_45897_add_host_labels

Reviewed-by: Kiefer Chang <kiefer.chang@suse.com>
Reviewed-by: Laura Paduano <lpaduano@suse.com>
Reviewed-by: Stephan Müller <smueller@suse.com>

Merge pull request #35767 from tchaikov/wip-rpm-scikit-learn

ceph.spec.in: Requires python3-scikit-learn only on fedora and suse

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>

python-common: service_spec.from_json: Add docstring explaining histroy

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>

qa/cephadm: Add test for --format=yaml

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>

mgr/orchestrator: Add test for readable yaml

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>

pybind/mgr: move test_orchestrator to orchestrator module

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>

mgr/orch: make YAML of ServiceDescription readable

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>

mgr/orch: YAML of DaemonDescription readable

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>

python-common: Make YAML or OSD Specs readable

* Changes: An empty OSD Spec is now invalid.
* OSDSpec.validate() now fails, if service-id is empty

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>

python-common: make YAML representaition of ServiceSpec readable

* Add test for new yaml representation

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>

ceph.spec.in: Requires python3-scikit-learn only on fedora and suse

so far, python3-scikit-learn is not packaged by RHEL8/CentOS8 or EPEL8.

see
https://src.fedoraproject.org/rpms/python-scikit-learn/branches?branchname=master

this change should address the regression introduced by
d13b441cdb63e37ad3b8ba36cbd3edc33b1e4bbd

Signed-off-by: Kefu Chai <kchai@redhat.com>

test: fix unused variable warning in test_ino_release_cb.cc.

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>

qa/cephadm/upgrade: use quay.ceph.io

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>

qa/cephadm/upgrade: Exclude RGW for now

tasks/cephadm.py gained RGW support very recently and
I'm now facing a dilemman:

* Either we set the upgrade start to 15.2.4 and thus
  no longer upgrade from an old version, or
* Disable RGW upgrade for now.

I think doing both would be optinal, but for now, let's
disable RGW, in order to keep the coverage for everything
else.

Fixes: https://tracker.ceph.com/issues/46157
Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>

Merge pull request #35292 from s0nea/wip-dashboard-telemetry-notification

Reviewed-by: Stephan Müller <smueller@suse.com>
Reviewed-by: Tiago Melo <tmelo@suse.com>

doc/dev: remove confusing.txt

* Last change was from 2011
* the file is not referenced anywhere
* the referenced file `cephconfig.jpg` doesn't exist

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>

Merge pull request #35648 from ideepika/fix-44948

ceph.spec: fix mgr diskprediction_local dependency

Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #35722 from ideepika/drop-el7

ceph.spec: drop support for el7 rpm builds

Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #35534 from varshar16/wip-doc-fix-SyntaxWarning

doc/scripts/gen_state_diagram.py: Fix literal comparison syntax warnings

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #35677 from sebastian-philipp/_refresh_hosts_and_daemons_forall_hosts

mgr/cephadm: speedup _refresh_hosts_and_daemons by 10x

Reviewed-by: Michael Fritch <mfritch@suse.com>

mgr/dashboard: Display users current bucket quota usage
Fixes: https://tracker.ceph.com/issues/45011
Signed-off-by: Avan Thakkar <athakkar@redhat.com>
(cherry picked from commit 966d887f7a5e0765b4210ab4edcb1cea3e03ac35)

mgr: avoid false alarm of MGR_MODULE_ERROR

mgr sends healthy report periodically, the report includes the
information whether the always-on modules are loaded or not. but the
modules are loaded with two steps:

1. load the options and command exposed by modules. the options and
   commands are registered using static methods of the subclasss of
   MgrModule.
2. create an instance of the subclass of MgrModule. this is performed
   in background by a Finisher thread. upon finishing of the construction
   of the instance, ActivePyModules::start_one() adds the module which
   successfully creates the class to `modules`.

but there is chance that when mgr sends healthy report, the always-on
module is still creating its instance of MgrModule subclass, or that
task is still pending in the finisher thread. in that case, mgr would
add a false error message like
```
4 mgr modules have failed (MGR_MODULE_ERROR)
```
in the healthy report

in this change, the number of modules in pending state is tracked,
and mgr will not take the missing always-on modules into account unless
the number of pending modules is 0.

Signed-off-by: Kefu Chai <kchai@redhat.com>