Merge pull request #65643 from dang/wip-dang-dedup

RGW - Fix dedup build

Reviewed by: Casey Bodley <cbodley@redhat.com>

Merge pull request #65593 from smanjara/wip-fix-period-pull

rgw/multisite: fix period pull command

Merge pull request #65631 from phlogistonjohn/jjm-fix-71992

mgr/smb: fix error handling for fundamental resource parsing

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Anoop C S <anoopcs@samba.org>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>

Merge pull request #65309 from joscollin/wip-72683-peer-add-deprecate

cephfs_mirror: deprecate peer_add command

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

Merge pull request #65567 from rkachach/fix_issue_certs_migration

mgr/cephadm: cleaning up old migration logic and improving upgrade handling with certmgr

Reviewed-by: Adam King <adking@redhat.com>

Merge pull request #65599 from bachmanity1/cephadm-support-custom-distro

cephadm: support custom distros by falling back to `ID_LIKE`

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: John Mulligan <jmulligan@redhat.com>

Merge pull request #65469 from Kushal-deb/remove-unreachable-code-path

mgr/rgw: fix unreachable code path

Reviewed-by: Adam King <adking@redhat.com>

Merge pull request #64194 from ShwetaBhosale1/fix_issue_71707_allow_ingress_matrics_via_https

mgr/cephadm: Allow Ingress service to expose the metrics via HTTPS

Reviewed-by: Redouane Kachach <rkachach@redhat.com>

Merge pull request #65652 from rhcs-dashboard/storage-capacity-fix

mgr/dashboard: Blank entry for Storage Capacity in dashboard under Cluster > Expand Cluster > Review

Reviewed-by: Afreen Misbah <afreen@ibm.com>

Merge pull request #65443 from dmick/pip-vcs

various: update pip+https URLs to new form.

mgr/cephadm: Fixed stats frontend to always enable health url

Fixes: https://tracker.ceph.com/issues/71707
Signed-off-by: Shweta Bhosale <Shweta.Bhosale1@ibm.com>

mgr/cephadm: Allow Ingress service to expose the metrics via HTTPS also add fields in spec to accept monitor ips/ monitor networks

Fixes: https://tracker.ceph.com/issues/71707
Signed-off-by: Shweta Bhosale <Shweta.Bhosale1@ibm.com>

mgr/cephadm: Adding genric cert/key name support for get certificates

Fixes: https://tracker.ceph.com/issues/71707
Signed-off-by: Shweta Bhosale <Shweta.Bhosale1@ibm.com>

RGW - Fix dedup build

Dedup is RadosStore specific, so move it to driver/rados, and only start
it if radosstore is being built.

Signed-off-by: Daniel Gryniewicz <dang@fprintf.net>

mgr/cephadm: Remove Grafana self-signed certificate migration logic

Remove the code used to migrate Grafana self-signed certificates, as
it is no longer needed. The certmgr logic now handles generating new
certificates during the upgrade, eliminating the need for any migration
code or logic.

Signed-off-by: Redouane Kachach <rkachach@ibm.com>

mgr/cephadm: Remove SSL RGW migration logic

Remove the special-case code used for RGW service migration, as it is no
longer needed. The certmgr logic now handles populating the certstore
with the corresponding certificate and key entries by reading their values
directly from the spec. During RGW service redeployment as part of the
upgrade, certmgr will ensure the certstore is updated accordingly.

Signed-off-by: Redouane Kachach <rkachach@ibm.com>

mgr/cephadm: Fix RGW spec validation for deprecated rgw cert field

Starting from Tentacle, the rgw_frontend_ssl_certificate field has been
deprecated in favor of the new ssl_cert and ssl_key fields. Update the
validation logic to run after this field is automatically transformed into
the new fields, ensuring proper validation of RGW specs.

Signed-off-by: Redouane Kachach <rkachach@ibm.com>

mgr/cephadm: Include mgmt-gateway/oauth2-proxy in upgrade process

Add the new mgmt-gateway and oauth2-proxy services to the list of
services upgraded by cephadm, ensuring they are updated alongside the
rest of the cephadm-managed services.

Signed-off-by: Redouane Kachach <rkachach@ibm.com>

Merge pull request #65354 from sunyuechi/main

inline_memory: optimize mem_is_zero for riscv using RISC-V Vector (RVV) intrinsics

mgr/smb: fix error handling for fundamental resource parsing

When an smb resource is input to the smb mgr module in YAML or JSON the
fundamental parsing/deserialization is handled by resourcelib. This
module tries to be largely independent of smb mgr module and defines a
few basic exception types. When these exception types were raised the
`ceph` command line would print out a long traceback. Avoid printing
a traceback by catching these errors with a new contextmanager
(decorator) that is automatically called when using the smb ceph
mgr command api.

Fixes: https://tracker.ceph.com/issues/71992
Signed-off-by: John Mulligan <jmulligan@redhat.com>

Merge pull request #65551 from adk3798/cephadm-migration-logging

mgr/cephadm: fix migrations logging

Reviewed-by: Redouane Kachach <rkachach@ibm.com>

Merge pull request #65424 from xxhdx1985126/wip-72902

crimson/os/seastore/transaction_manager: read_pin_by_type read the whole extent if it's not fully loaded

Reviewed-by: Matan Breizman <mbreizma@redhat.com>

Merge pull request #64755 from cloudbehl/grafana-rate-irate-fix

ceph-mixin: Update monitoring mixin

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: SuperQ <superq@gmail.com>

Merge pull request #65243 from myoungwon/wip-corouint-state-device

crimson/os/seastore/rbm: switch to coroutine in state_device

Reviewed-by: Matan Breizman <mbreizma@redhat.com>

Merge pull request #65503 from Hezko/nvmeof-cli-ns-add-nsid-param

mgr/dashboard: add nsid param to ns add command

Reviewed-by: Nizamudeen A <nia@redhat.com>

Merge pull request #65504 from Hezko/nvmeof-cli-fix-subsys-group-add

mgr/dashboard: --no-group-append default value to False, aligned with old cli

Reviewed-by: Nizamudeen A <nia@redhat.com>

Merge pull request #65646 from zmc/pr-checklist

.github/workflows/pr-checklist.yml: Update

Merge pull request #65396 from ceph/wip-uadk-main-fix

uadk: Build with ceph fork (for FORTIFY_SOURCE fix)

.github/workflows/pr-checklist.yml: Update

To pull in these changes:
https://github.com/ceph/ceph-pr-checklist-action/pull/5
https://github.com/ceph/ceph-pr-checklist-action/pull/6

Signed-off-by: Zack Cerza <zack@cerza.org>

Merge pull request #65634 from ljflores/wip-tracker-71182

qa: suppress OpenSSL valgrind leaks

Merge pull request #65268 from rhcs-dashboard/fix-multiple-user-deletion

mgr/dashboard: add multiple ceph users deletion

Reviewed-by: Afreen Misbah <afreen@ibm.com>

Merge pull request #65119 from rhcs-dashboard/72635-skip-secure-monitoring-stack

mgr/dashboard : Skip calls until secure_monitoring_stack is enabled

Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Redouane Kachach <rkachach@ibm.com>

Merge pull request #65600 from rhcs-dashboard/nfs-command

mgr/dashboard: FS - Attach Command showing undefined for MountData

Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Ankush Behl <cloudbehl@gmail.com>

Merge pull request #65561 from rhcs-dashboard/fix-72810-main

monitoring: fix "In" OSDs in Cluster-Advanced grafana panel. Also change units from decbytes to bytes wherever used in the panel

Merge pull request #65409 from rhcs-dashboard/pool-configuration-new

 mgr/dashboard: Handle pool creation in tiering local storage class creation

Reviewed-by: Pedro Gonzalez Gomez <pegonzal@ibm.com>

mgr/dashboard: Blank entry for Storage Capacity in dashboard under Cluster > Expand Cluster > Review

https://tracker.ceph.com/issues/73220

Signed-off-by: Naman Munet <naman.munet@ibm.com>

Merge pull request #65519 from Hezko/fix-force-param-in-ns-add-host

mgr/dashboard: fix None force param handling in ns add_host so it won't raise exceptions

Reviewed-by: Nizamudeen A <nia@redhat.com>

Merge pull request #65487 from rhcs-dashboard/72989-notification-form

mgr/dashboard: Form retains old data when switching from edit to create mode

Reviewed-by: Afreen Misbah <afreen@ibm.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>

Merge pull request #65265 from UtkarshBhatthere/fix/cephfsmir/mgrclireq

pybind/mgr/mirroring: modifies the cli command type to read

Reviewed-by: Venky Shankar <vshankar@redhat.com>

qa: suppress OpenSSL valgrind leaks

These leaks started happening when OpenSSL v3.5.0
was released. We determined they are safe to suppress.

Fixes: https://tracker.ceph.com/issues/71182
Signed-off-by: Laura Flores <lflores@ibm.com>

Merge pull request #65576 from rhcs-dashboard/smb-bugfixes

mgr/dashboard: fix smb button and table column

Merge pull request #64933 from soumyakoduri/wip-skoduri-restore-progress

rgw/restore: Persistently store the restore state for cloud-s3 tier

Reviewed-by: Jiffin Tony Thottan <thottanjiffin@gmail.com>
Reviewed-by: Matt Benjamin <mbenjamin@redhat.com>

Merge PR #65569 into main

* refs/pull/65569/head:
script/redmine-upkeep: do not try to update status if open subtasks exist

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>

Merge PR #65547 into main

* refs/pull/65547/head:
.github/workflows/redmine-upkeep: remove concurrency limit

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>

Merge PR #65555 into main

* refs/pull/65555/head:
script/redmine-upkeep: include each issue changed in summary
.github/workflows/redmine-upkeep: use smaller limit for testing push

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>

pybind/mgr/mirroring: modifies the cli command type to read

The command fs snapshot mirror ls is used to present state data to
client. This does not require Write semantics.

Signed-off-by: Utkarsh Bhatt <utkarsh.bhatt@canonical.com>

Merge pull request #65412 from rhcs-dashboard/fix-72893-main

mgr/progress: expose API from CLI

Merge pull request #65537 from rhcs-dashboard/total-capacity-fix

mgr/dashboard: fix total capacity value in dashboard

Merge pull request #64858 from rhcs-dashboard/edit-nfs-export

mgr/dashboard:[NFS] Missing Subvolume Groups and Subvolumes on Edit NFS Export.

Reviewed-by: Naman Munet <naman.munet@ibm.com>

Merge pull request #64559 from rhcs-dashboard/inline-table-edit

mgr/dashboard: support inline edit for datatable

Reviewed-by: Afreen Misbah <afreen@ibm.com>
Reviewed-by: Pedro Gonzalez Gomez <pegonzal@ibm.com>

Merge pull request #65441 from linuxbox2/wip-72915

rgw: fix policy enforcement for GetObjectAttributes

mgr/dashboard: Local storage class creation via dashboard doesn't handle creation of pool.

Fixes: https://tracker.ceph.com/issues/72569
Signed-off-by: Dnyaneshwari <dtalweka@redhat.com>
mgr/dashboard: handle creation of new pool

Commit includes:
1) Provide link to create a new pool
2) Refactored validation on ACL mapping, removed required validator as default
3) fixed runtime error on console due to ACL length due to which the details section was not opening
4) Used rxjs operators to make API calls and making form ready once all data is available, fixing the form patch issues
5) Refactored some part of code to improve the performance
6) Added zone and pool information in details section for local storage class

Fixes: https://tracker.ceph.com/issues/72569
Signed-off-by: Naman Munet <naman.munet@ibm.com>

Merge pull request #65633 from adk3798/cephadm-pin-cheroot

pybind/mgr: pin cheroot version in requirements-required.txt

Reviewed-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
Reviewed-by: John Mulligan <jmulligan@redhat.com>

Merge pull request #65198 from xxhdx1985126/wip-72701

crimson/os/seastore/cache: clear extents_index when the booting is done

Reviewed-by: Samuel Just <sjust@redhat.com>

Merge pull request #65234 from xxhdx1985126/wip-72706

crimson/osd/recovery_backend: interrupt all recovery_waiter unconditionally when cleaning up the recovery backend

Reviewed-by: Samuel Just <sjust@redhat.com>

Merge pull request #65283 from xxhdx1985126/wip-72763

crimson/osd/osd_operations/client_request: rely on the checks in PG::do_recover_missing() to determine whether to recover clone objects

Reviewed-by: Matan Breizman <mbreizma@redhat.com>

Merge pull request #65317 from xxhdx1985126/wip-72790

crimson/osd/pg_backend: tolerate enoent for both head and clone when doing rollback

Reviewed-by: Matan Breizman <mbreizma@redhat.com>

Merge pull request #65353 from xxhdx1985126/wip-72844

crimson/osd/pg: tolerate NULL PG::pglog_based_recovery_op when cancelling pglog based recovery

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Matan Breizman <mbreizma@redhat.com>

Merge pull request #65197 from myoungwon/wip-fix-allocator-alloc-handling

crimson/os/seastore/rbm: handle no-space case properly

Reviewed-by: Samuel Just <sjust@redhat.com>

pybind/mgr: pin cheroot version in requirements-required.txt

With python 3.10 (didn't seem to happen with python 3.12) the
pybind/mgr/cephadm/tests/test_node_proxy.py test times out.
This appears to be related to a new release of the cheroot
package and a github issues describing the same problem
we're seeing has been opened by another user
https://github.com/cherrypy/cheroot/issues/769

It is worth noting that the workaround described in that
issue does also work for us. If you add

```
import cheroot
cheroot.server.HTTPServer._serve_unservicable = lambda: None
```

after the existing imports in test_node_proxy.py the
test hanging issue also disappears. Also worth noting the
particular pin of

cheroot~=10.0

was chosen as it matches the existing pin being used
in pybind/mgr/dashboard/constraints.txt

Signed-off-by: Adam King <adking@redhat.com>

Merge pull request #65204 from ifed01/wip-ifed-fix-ec-contiguous

erasure-code: make bufferlist contiguous in ErasureCode::encode_prepare

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Reviewed-by: Alex Ainscow <aainscow@uk.ibm.com>

rgw/restore: Fixing teuthology restore tests

This includes
* fixing `rgw_cloudtier.py` qa script
* enabling `debug_rgw_restore` for cloud-transition suite
* adding few debug statements

Signed-off-by: Soumya Koduri <skoduri@redhat.com>

rgw/restore: Mark the restore entry status as `None` first time

While adding the restore entry to the FIFO, mark its status as `None`
so that restore thread knows that the entry is being processed for
the first time. Incase the restore is still in progress and the entry
needs to be re-added to the queue, its status then will be marked
`InProgress`.

Signed-off-by: Soumya Koduri <skoduri@redhat.com>

qa/rgw: Include rgw_restore_processor_period in s3tests

Signed-off-by: Soumya Koduri <skoduri@redhat.com>

rgw/restore: Persistently store the restore state for cloud-s3 tier

In order to resume IN_PROGRESS restore operations post RGW service
restarts, store the entries of the objects being restored from `cloud-s3`
tier persistently. This is already being done for `cloud-s3-glacier`
tier and now the same will be applied to `cloud-s3` tier too.

With this change, when `restore-object` is performed on any object,
it will be marked RESTORE_ALREADY_IN_PROGRESS and added to a restore FIFO queue.
This queue is later processed by Restore worker thread which will try to
fetch the objects from Cloud or Glacier/Tape S3 services. Hence all the
restore operations are now handled asynchronously (for both `cloud-s3`,
`cloud-s3-glacier` tiers).

Signed-off-by: Soumya Koduri <skoduri@redhat.com>

cephadm: support custom distros by falling back to ID_LIKE

This change enables cephadm to work on custom or derivative distributions
that are based on supported distros without requiring code changes for
each new custom/derivative distro.

Signed-off-by: bachmanity1 <bachmanity138@gmail.com>

Merge pull request #65566 from rhcs-dashboard/fix-73077-main

mgr/dashboard: Allow FQDN in Connect Cluster form -> Cluster API URL

Reviewed-by: Nizamudeen A <nia@redhat.com>

Merge pull request #65579 from rhcs-dashboard/fix-73105-main

mgr/dashboard: fix zone update API forcing STANDARD storage class

Reviewed-by: Nizamudeen A <nia@redhat.com>

mgr/dashboard: FS - Attach Command showing undefined for MountData

Fixes: https://tracker.ceph.com/issues/73137
Signed-off-by: Dnyaneshwari Talwekar <dtalwekar@redhat.com>

fix unreachable code path

Signed-off-by: Kushal Deb <Kushal.Deb@ibm.com>

Merge pull request #65613 from cybozu/doc-fix-osd-min-size

doc: fix osd min size

doc: fix osd min size

Exact 5 GiB block devices are also considered
as an available device.

Signed-off-by: Satoru Takeuchi <satoru.takeuchi@gmail.com>

Merge pull request #65489 from shraddhaag/wip-shraddhaag-availability-format

mon/OSDMonitor.cc: optionally display availability status in json

Reviewed-by: Nitzan Mordhai<nmordech@ibm.com>

Merge pull request #65527 from chanyoung/fix-coll-refs

crimson/.../store-bench: fix coll_refs index error

Reviewed-by: Matan Breizman <mbreizma@redhat.com>

Merge pull request #65484 from ronen-fr/wip-rf-oneauth

osd/scrub: modify repair_object() to accept a single auth peer

Reviewed-by: Samuel Just <sjust@redhat.com>

rgw/multisite: empty realm_id and period_id passed into do_period_pull()
was causing remote zone to respond with 404 error during a period pull.

Signed-off-by: Shilpa Jagannath <smanjara@redhat.com>

Merge pull request #62887 from clwluvw/copy-obj-remote

rgw: report copy obj progress from the frontend CR

Reviewed-by: Adam C. Emerson <aemerson@redhat.com>

Merge pull request #65415 from kchheda3/wip-re-create-bucket

rgw/create-bucket: Do not re-create the bucket instance & bucket index shard object if if bucket already exist..

Merge pull request #64152 from cbodley/wip-63323

rgw: support S3 Object Ownership controls to disable object ACLs

Reviewed-by: Adam Emerson <aemerson@redhat.com>

Merge PR #65392 into main

* refs/pull/65392/head:

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Dhairya Parmar <dparmar@redhat.com>

mgr/dashboard: support inline edit for datatable

adding a new celltransformation that will transform the cell to a form
control when you click on the edit button which is inside a cell.

Added a new CellTemplate `editing` which if set to a cell, then it'll
add the edit button. You can also add validators to the control by using
the `customTemplateConfig` like
```
customTemplateConfig: {
          validators: [Validators.required]
        }
```

Also using a `EditState` to keep track of the different cells I can edit
simultaneously in a single time.

Fixes: https://tracker.ceph.com/issues/72171
Signed-off-by: Nizamudeen A <nia@redhat.com>

mgr/dashboard: fix zone update API forcing STANDARD storage class

The zone update REST API (`edit_zone`) always attempted to configure a
placement target for the `STANDARD` storage class, even when the request
was intended for a different storage class name.
This caused failures in deployments where `STANDARD` is not defined.

Changes:
Club add placement target and add storage class methods into one single
add_placement_targets_storage_class_zone method which takes the storage
class as a param as well alongside the rest of the placement params.

Fixes: https://tracker.ceph.com/issues/73105
Signed-off-by: Aashish Sharma <aasharma@redhat.com>

Merge PR #65577 into main

* refs/pull/65577/head:

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@ibm.com>

Merge pull request #64893 from zer0def/bug-57939

cephadm: pass wal/db slot count to ceph-volume

Reviewed-by: Guillaume Abrioux <gabrioux@ibm.com>

Merge pull request #63170 from adk3798/cephadm-nvmeof-stray

mgr/cephadm: don't mark nvmeof daemons without pool and group in name as stray

Reviewed-by: Redouane Kachach <rkachach@ibm.com>

Merge pull request #65548 from EncoreTechnologies/cephadmin-vir-ip-networks-interfaces-check

mgr/cephadm: Add check for virtual_interface_networks

Reviewed-by: Adam King <adking@redhat.com>

Merge pull request #65373 from phlogistonjohn/jjm-cephadm-build-ensure-byte-comp

cephadm: fail the script if byte-compile step fails

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Redouane Kachach <rkachach@ibm.com>

Merge pull request #65155 from phlogistonjohn/jjm-py-common-fmt-black

python-common: enable consistent code formatting with 'black'

Reviewed-by: Adam King <adking@redhat.com>

Merge pull request #63962 from adk3798/cephadm-signal-containerized-daemon

cephadm: add command to send signals to daemons

Reviewed-by: John Mulligan <jmulligan@redhat.com>

cephfs-journal-tool:: Don't reset the journal trim position

If the fs had to go through journal recovery and reset,
the cephfs-journal-tool resets the journal trim position
because of which the old unused journal objects just stay
forever in the metadata pool. The patch fixes the issue.
Now, the old stale journal objects are trimmed during the
regular trimming cycle helping to recover space in the
metadata pool.

Fixes: https://tracker.ceph.com/issues/69708
Signed-off-by: Kotresh HR <khiremat@redhat.com>

qa: Validate cephfs-journal-tool reset trim

Validates that the cephfs-journal-tool reset
doesn't reset the trim position so that the
journal trim takes care of trimming the older
unused journal objects helping to recover the
space in metadata pool.

Fixes: https://tracker.ceph.com/issues/69708
Signed-off-by: Kotresh HR <khiremat@redhat.com>

Merge pull request #65510 from anthonyeleven/eugen

src/cephadm/cephadmlib/daemons: Fix typos in ceph.py and elsewhere

Reviewed-by: Adam King <adking@redhat.com>

Merge pull request #65322 from ShwetaBhosale1/fix_issue_72345_set_healthwarning_for_ssh_timeout_during_refresh

mgr/cephadm: set health warning for host SSH timeout

Reviewed-by: Adam King <adking@redhat.com>

Merge pull request #65291 from ShwetaBhosale1/fix_issue_72774_spec_reapply_causing_osd_to_apply_in_every_serve_loop

mgr/cephadm: After reapplying the osd spec, the OSD services are continuously applied in each serve loop iteration

Reviewed-by: Adam King <adking@redhat.com>

Merge pull request #65149 from ShwetaBhosale1/fix_issue_72652_max_num_of_osds_to_upgrade_in_single_iteration

mgr/cephadm: Config parameter to set the max number of OSDs to upgrade in single iteration

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Redouane Kachach <rkachach@ibm.com>

Merge pull request #64642 from ShwetaBhosale1/fix_issue_72206_Allow_registry_credentials_to_define_multiple_container_registries

mgr/cephadm: Allow registry credentials to define multiple container registries

Reviewed-by: Adam King <adking@redhat.com>

Merge pull request #65398 from smanjara/wip-fix-zg-api-name

rgw/multisite: update api_name during a zonegroup rename

Merge pull request #64018 from 9401adarsh/wip-adashoka-71677

rgw/notifications: add support for sharded persistent bucket notifications

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Reviewed-by: Yuval Lifshitz <ylifshit@redhat.com>

Merge pull request #65366 from cbodley/wip-72847

rgw/admin: allow listing account's root users

Reviewed-by: Adam Emerson <aemerson@redhat.com>

doc: add format option in docs

Fixes: https://tracker.ceph.com/issues/71546
Signed-off-by: Shraddha Agrawal <shraddhaag@ibm.com>