mgr/dashboard: Fix variable capitalization in embedded rbd-details panel

Fix capitalization of image and pool variables in embedded grafana rbd-details panel

Fixes: https://tracker.ceph.com/issues/67849
Signed-off-by: Juan Ferrer Toribio <22457707+juan-ferrer-toribio@users.noreply.github.com>

Merge pull request #59368 from xxhdx1985126/wip-crimson-backfill-cancel-part2

crimson/osd: support backfill cancellation ---- part2

Reviewed-by: Matan Breizman <mbreizma@redhat.com>
Reviewed-by: Radosław Zarzyński <rzarzyns@redhat.com>

Merge pull request #59554 from rhcs-dashboard/WrongUIDForUSer

mgr/dashboard: Wrong(half) uid is observed in dashboard

Reviewed-by: Afreen Misbah <afreen23.git@gmail.com>

Merge pull request #59178 from VallariAg/wip-nvmeof-teuthology-v6

qa: add namespace and scale testing for nvmeof teuthology suite

Merge pull request #59478 from idryomov/wip-67752

rbd: amend "rbd {group,} rename" and "rbd mirror pool" command descriptions

Reviewed-by: Ramana Raja <rraja@redhat.com>
Reviewed-by: N Balachandran <nibalach@redhat.com>

qa/suites/nvmeof: wait for service "nvmeof.mypool.mygroup0"

This is because nvmeof gateway group names are now
part of service id.

Signed-off-by: Vallari Agrawal <val.agl002@gmail.com>

qa/suites/nvmeof: increase hosts in cluster setup

In "nvmeof" task, change "client" config to "installer"
which allows to take inputs like "host.a".

nvmeof/basic: change 2-gateway-2-initiator to
       4-gateway-2-inititator cluster
nvmeof/thrash: change 3-gateway-1-initiator to
        4-gateway-1-inititaor cluster

Signed-off-by: Vallari Agrawal <val.agl002@gmail.com>

Merge pull request #58478 from rhcs-dashboard/carbon-forms-fs

mgr/dashboard: carbonize fs forms

Reviewed-by: afreen23 <NOT@FOUND>
Reviewed-by: ivoalmeida <NOT@FOUND>
Reviewed-by: sayaleeraut <NOT@FOUND>

Merge pull request #59496 from rhcs-dashboard/ws-carbon-table

mgr/dashboard: carbon datatable minor bug fixes

Reviewed-by: afreen23 <NOT@FOUND>
Reviewed-by: Ankush Behl <cloudbehl@gmail.com>
Reviewed-by: ivoalmeida <NOT@FOUND>

qa: move nvmeof shell scripts to qa/workunits/nvmeof

Move all scripts qa/workunits/rbd/nvmeof_*.sh
to qa/workunits/nvmeof/*.sh

Signed-off-by: Vallari Agrawal <val.agl002@gmail.com>

mgr/dashboard: Wrong(half) uid is observed in dashboard

Fixes: https://tracker.ceph.com/issues/67850
Signed-off-by: Dnyaneshwari Talwekar <dtalweka@redhat.com>

Merge pull request #59556 from mcv21/patch-2

doc: Correct link to Prometheus docs

Reviewed-by: Zac Dover <zac.dover@proton.me>

Merge pull request #58543 from rishabh-d-dave/tracker-65808

cephfs: disallow removing root_squash via "fs authorize" cmd

Reviewed-by: Venky Shankar <vshankar@redhat.com>

doc: Correct link to Prometheus docs

The link is to the `#http_sd_config` anchor in the prometheus config docs; that link only works without the trailing `/`.

This correction would ideally get backported to at least reef & squid.

Signed-off-by: Matthew Vernon <mvernon@wikimedia.org>

mgr/dashboard: carbon datatable minor bug fixes

- fixes empty white spaces in the table
- fixes some tables detail component where it didn't had carbon table
- fix the multi-site details view table not showing up
- fix the nvmeof modals like namespace deletion not getting opened
- fix the cached reload button status not showing correctly in rgw table
- fix show button in the rgw users detail page broken
- fix the multi-cluster list component issue where details component is
  not following carbon attributes
- fixing the configuration page where it does a page reload on form
  submit. instead doing a table refresh

- additionally fixed a validation issue in the service form

fixes the test failures

Fixes: https://tracker.ceph.com/issues/67788
Fixes: https://tracker.ceph.com/issues/67552
Signed-off-by: Nizamudeen A <nia@redhat.com>

mgr/dashboard: carbonize cephfs forms

This commit also covers the nfs form

Fixes: https://tracker.ceph.com/issues/67663
Signed-off-by: Nizamudeen A <nia@redhat.com>

Merge pull request #59547 from gbregman/main

Revert SPDK rpc fields in nvmeof configuration

mgr/cephadm: revert SPDK RPC fields in nvmeof configuration
Fixes https://tracker.ceph.com/issues/67844

Signed-off-by: Gil Bregman <gbregman@il.ibm.com>

python-common/ceph/deployment: revert SPDK RPC fields in nvmeof configuration
Fixes https://tracker.ceph.com/issues/67844

Signed-off-by: Gil Bregman <gbregman@il.ibm.com>

Merge pull request #59544 from VallariAg/wip-teuthology-workflow

doc: update tests-integration-testing-teuthology-workflow.rst

Reviewed-by: Zac Dover <zac.dover@proton.me>
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

doc: update tests-integration-testing-teuthology-workflow.rst

* add "Infrastructure" section.

* move "Naming the ceph-ci branch" section under
   "Getting binaries - Build Ceph". Also mention
   about centos9-only trick.

* in "Teuthology Archives", mention about developer
   playground machines and ceph log files.

Signed-off-by: Vallari Agrawal <val.agl002@gmail.com>

Merge pull request #59512 from bugwz/alerts-receivers

mgr/dashboard: alerts module supports setting multiple email recipients

Merge pull request #59508 from rkhudov/src-test-rgw-bucket_notification-update-documentation

src/test/rgw/bucket_notification/README.rst: update RabbitMQ documentation for RGW notification tests

test/crimson: verify the backfill cancellation & resumption

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>

test/crimson: add event-type-checking next_round2() to BackfillFixture

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>

crimson/osd: wire up backfill resumption

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>

crimson/osd: BackfillMachine does support cancel and resume now

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>

Merge pull request #59531 from nbalacha/wip-nbalacha-unit-test-fix

test/rbd-mirror: fix BootstrapReplayer tests that use expect_is_linked()

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>

Merge pull request #59528 from zdover23/wip-doc-2024-08-30-ceph-volume-lvm-newdb-bluefs-spillover

doc/ceph-volume: add spillover fix procedure

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

Merge pull request #59484 from shraddhaag/add-email-contact

mailmap, githubmap, organisationmap: Add Shraddha Agrawal

Reviewed-by: Neha Ojha <nojha@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

Merge pull request #59448 from rhcs-dashboard/improve-prometheus-service

mgr/dashboard: improve prometheus service request handling

Reviewed-by: Afreen Misbah <afreen23.git@gmail.com>

Merge PR #59309 into main

* refs/pull/59309/head:
qa: ignore warnings variations

Reviewed-by: Rishabh Dave <ridave@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>

tests/rbd-mirror: fixes BootstrapReplayer test

When run with debug_rbd_mirror >= 10, is_linked() is also
called as part of a log message. This causes the tests using
expect_is_linked() to fail.

Signed-off-by: N Balachandran <nibalach@redhat.com>

rbd: mention namespace in "rbd mirror pool" command descriptions

Commit 5e64748927d0 ("doc/rbd: add namespace information for mirror
commands") did this for the man page, update the built-in help as well.

The "by default" bit in the description of "rbd mirror pool enable" and
"rbd mirror pool disable" commands is specific to pool mode which is in
turn specific to journal-based mirroring, so it's removed.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>

doc/ceph-volume: add spillover fix procedure

Add a procedure that explains how, after an upgrade, to move bytes that
have spilled over to a relatively slow device back to the faster device.

This procedure was developed by Chris Dunlop on the [ceph-users] mailing
list, here: https://lists.ceph.io/hyperkitty/list/ceph-users@ceph.io/message/POPUFSZGXR3P2RPYPJ4WJ4HGHZ3QESF6/

Eugen Block requested the addition of this procedure to the
documentation on 30 Aug 2024.

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>

Merge PR #58547 into main

* refs/pull/58547/head:
qa: failfast mount for better performance

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

Merge pull request #59510 from afreen23/main

mgr/dashboard: Fix banner and scroll issue

Reviewed-by: Nizamudeen A <nia@redhat.com>

Merge pull request #59182 from zhscn/wip-4k-laddr

crimson/os/seastore: make laddr_t block aligned

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>

Merge pull request #59507 from nbalacha/wip-nbalacha-rbd-manpage

doc/rbd: add namespace information for mirror commands

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>

Merge PR #58950 into main

* refs/pull/58950/head:
mds: add the event when creating the batch head
mds: print the path depth to help debug mds issue

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

Merge PR #59310 into main

* refs/pull/59310/head:
qa: load all dirfrags before testing altname recovery

Reviewed-by: Rishabh Dave <ridave@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Milind Changire <mchangir@redhat.com>

mgr/dashboard: alerts module supports setting multiple email recipients

Signed-off-by: bugwz <xbugwz@gmail.com>

doc/rbd: add namespace information for mirror commands

Updates the rbd man page to clarify  that some mirror commands
can apply to pools and namespaces.

Signed-off-by: N Balachandran <nibalach@redhat.com>

Merge pull request #59469 from smanjara/fix-multisite-script-default-realm

test-rgw-multisite: create default realm in multisite test script

Reviewed-by: Casey Bodley <cbodley@redhat.com>

examples/rgw/boto3/README.md: update documentation for boto3 extension installation. Fixes: https://tracker.ceph.com/issues/67768

Signed-off-by: rkhudov <rhudov@gmail.com>

src/test/rgw/bucket_notification/README.rst: use systemctl, update rabbitmq installation process. Fixes: https://tracker.ceph.com/issues/67768

Signed-off-by: rkhudov <rhudov@gmail.com>

src/test/rgw/bucket_notification/README.rst: update RabbitMQ documentation. Fixes: https://tracker.ceph.com/issues/67768

Signed-off-by: rkhudov <rhudov@gmail.com>

mgr/dashboard: Fix banner and scroll issue

- includes fix to make banner visible again
- includes fix to allow scrolling on longer pages like, expand cluster and upgrade

Fixes https://tracker.ceph.com/issues/67795

Signed-off-by: Afreen Misbah <afreen23.git@gmail.com>

Merge pull request #59363 from adk3798/cephadm-mount-nvmeof-certs

cephadm: mount nvmeof certs into container

Reviewed-by: Alexander Indenbaum <aindenba@redhat.com>
Reviewed-by: John Mulligan <jmulligan@redhat.com>

Merge pull request #58778 from rhcs-dashboard/fix-67103-main

mgr/dashboard: Zone details showing incorrect data for data pool values and compression info for Storage Classes

Reviewed-by: Afreen Misbah <afreen23.git@gmail.com>

Merge pull request #59495 from zhscn/fix-fmt-missing-arg

crimson/osd/pg: fix missing priority argument

Reviewed-by: Xuehan Xu <xuxuehan@qianxin.com>
Reviewed-by: Matan Breizman <mbreizma@redhat.com>

Merge pull request #59391 from cyx1231st/wip-seastore-more-reports2

crimson/os/seastore/cache: report dirty cache usage and rewrite stats

Reviewed-by: Xuehan Xu <xuxuehan@qianxin.com>

Merge branch 'main' into add-email-contact

crimson/osd/pg: fix missing priority argument

Signed-off-by: Zhang Song <zhangsong02@qianxin.com>

Merge pull request #59390 from ceph/wip-oozmen-67656

doc/rgw/account: Handling notification topics when migrating an existing user into an account

Reviewed-by: Casey Bodley <cbodley@redhat.com>
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Reviewed-by: Yuval Lifshitz <ylifshit@ibm.com>

Merge pull request #53915 from pritha-srivastava/wip-rgw-sts-update-oidc-provider

rgw/iam: add AddClientIdToOIDCProvider/UpdateOidcProviderThumbprint

Reviewed-by: Matt Benjamin <mbenjamin@redhat.com>
Reviewed-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #59249 from pritha-srivastava/wip-rgw-sts-err-message

rgw/sts: correcting the error message returned for an sts key

Reviewed-by: Casey Bodley <cbodley@redhat.com>

mailmap, githubmap, organisationmap: Add Shraddha Agrawal

Signed-off-by: Shraddha Agrawal <shraddhaag@ibm.com>

Merge PR #59300 into main

* refs/pull/59300/head:
client: calls to _ll_fh_exists() should hold client_lock

Reviewed-by: Xiubo Li <xiubli@redhat.com>
Reviewed-by: Dhairya Parmar <dparmar@redhat.com>

Merge pull request #59419 from phlogistonjohn/jjm-smb-ctdb-vips

smb: cluster public ip addresses support

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Anoop C S <anoopcs@cryptolab.net>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Michael Adam <obnox@samba.org>

qa/suites/nvmeof/basic: add nvmeof_scalability test

Add test to upscale/downscale nvmeof
gateways.

Signed-off-by: Vallari Agrawal <val.agl002@gmail.com>

qa: Expand nvmeof thrasher and add nvmeof_namespaces.yaml job

1. qa/tasks/nvmeof.py: add other methods to stop nvmeof daemons
2. add qa/workunits/rbd/nvmeof_namespace_test.sh which adds and
   deletes new namespaces. It is run in nvmeof_namespaces.yaml
   job where fio happens to other namespaces in background.

Signed-off-by: Vallari Agrawal <val.agl002@gmail.com>

Merge pull request #59434 from VallariAg/fix-nvmeof-apply-teuthology

qa/tasks/nvmeof.py: add nvmeof gw-group to deployment

Merge pull request #59385 from leonidc/wip-leonidc-20242108-fixing-gw-bugs

mon: handle gw fast-reboot, proper handle of gw delete scenarios

Merge pull request #59240 from leonidc/wip-leonidc-20241508-upgrade-rules-centos9-only

upgrade rules for NVMeofGW monitors and gateways

rbd: clarify "rbd {group,} rename" command description

Make it clearer that, despite a full image or group spec being taken
for source and destination, an image or a group can be renamed only
within its pool or namespace.

Rename across pools or namespaces within the same pool is unsupported.

Fixes: https://tracker.ceph.com/issues/67752
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>

Merge pull request #59401 from nbalacha/wip-nbalacha-check-mirror-ns

rbd-mirror: use correct ioctx for namespace

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
Reviewed-by: Ramana Raja <rraja@redhat.com>

mgr/dashboard: Zone details showing incorrect data for data pool values and compression info for Storage Classes

Fixes: https://tracker.ceph.com/issues/67103
Signed-off-by: Aashish Sharma <aasharma@redhat.com>

Merge pull request #57876 from Suyashd999/rgw-false-positives

rgw: rgw_auth.cc: disable false use-after-move clang-tidy warning

Reviewed-By: Ronen Friedman <rfriedma@ibm.com>, Yuval Lifshitz <ylifshit@ibm.com>

Merge pull request #58959 from rhcs-dashboard/fix-67192-main

mgr/dashboard: Add Performance Details grafana charts for individual clusters in Manage-clusters page

Reviewed-by: Nizamudeen A <nia@redhat.com>

qa/suites/orch: add test for smb with ctdb and cluster public ips

Signed-off-by: John Mulligan <jmulligan@redhat.com>

doc: add documentation for (cluster_)public_addrs options

Document the spec and resource options (they're basically the same) for
specifying public addresses that will be managed automatically
by CTDB.

Signed-off-by: John Mulligan <jmulligan@redhat.com>

mgr/smb: add cluster public ip information to service spec

Signed-off-by: John Mulligan <jmulligan@redhat.com>

mgr/smb: extend cluster resource type to define public ip addrs

When a cluster defines public IPs it will pass this information along to
the smb service spec.

Signed-off-by: John Mulligan <jmulligan@redhat.com>

mgr/cephadm: pass public addresses for a cluster to cephadm binary

Add the strictly-formed public addresses list as one of the config blobs
we pass to the binary for smb container deployment.

Signed-off-by: John Mulligan <jmulligan@redhat.com>

python-common/deployment: add a cluster public ip spec for smb

This spec can be used to define one or more public addresses that will
be automatically assigned to hosts by CTDB. The address can be specified
in the "interface" form - an address plus prefix length.  Optionally,
networks to bind to can be specified. The network value will be
converted to a network device name later by cephadm.

Signed-off-by: John Mulligan <jmulligan@redhat.com>

test/multisite: create default realm in multisite config

Signed-off-by: Shilpa Jagannath <smanjara@redhat.com>

qa: ignore warnings variations

Fixes: https://tracker.ceph.com/issues/67601
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>

Merge pull request #58380 from adk3798/squid-base-mds-upgrade-sequence-cephadm

qa/suites/fs: pull compiled cephadm for squid branch in mds_upgrade_sequence

Reviewed-by: John Mulligan <jmulligan@redhat.com>

Merge pull request #59421 from phlogistonjohn/jjm-teuth-cephadm-from-ctr

qa/tasks: add a new cephadm_from_container feature to cephadm task

Reviewed-by: Adam King <adking@redhat.com>

Merge PR #59171 into main

* refs/pull/59171/head:
client: use vectors for context lists

Reviewed-by: Venky Shankar <vshankar@redhat.com>

Merge PR #59176 into main

* refs/pull/59176/head:
mds: encode quiesce payload on demand
mds: print quiesce message name in debug log

Reviewed-by: Venky Shankar <vshankar@redhat.com>

Merge PR #58419 into main

* refs/pull/58419/head:
mds: generate correct path for unlinked snapped files
qa: add test for cephx path check on unlinked snapped dir tree
mds: add debugging for stray_prior_path

Reviewed-by: Milind Changire <mchangir@redhat.com>

Merge PR #58987 into main

* refs/pull/58987/head:
qa/cephfs: update ignorelist

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

Merge PR #59088 into main

* refs/pull/59088/head:
mds: add compile time checks for sortedness
mds: sort conf keys

Reviewed-by: Dhairya Parmar <dparmar@redhat.com>

Merge PR #59095 into main

* refs/pull/59095/head:
qa: wait for file creation before changing mode

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

Merge PR #59162 into main

* refs/pull/59162/head:
client: Prevent race condition when printing Inode in ll_sync_inode

Reviewed-by: Xiubo Li <xiubli@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

Merge PR #59173 into main

* refs/pull/59173/head:
mds: fix spelling typo

Reviewed-by: Jos Collin <jcollin@redhat.com>
Reviewed-by: Kotresh Hiremath Ravishankar <khiremat@redhat.com>
Reviewed-by: Neeraj Pratap Singh <neesingh@redhat.com>

Merge pull request #59423 from idryomov/wip-67698

rbd: "rbd bench" always writes the same byte

Reviewed-by: Mykola Golub <mgolub@suse.com>

Merge pull request #59409 from adk3798/teuth-reinstall-nvme-cli

qa/distros: reinstall nvme-cli on centos 9 nodes

Reviewed-by: Guillaume Abrioux <gabrioux@ibm.com>

Merge pull request #57952 from NitzanMordhai/wip-nitzan-bench-osd-admin-command

crimson: Add support for bench osd command

Reviewed-by: Matan Breizman <mbreizma@redhat.com>

Merge pull request #59189 from xxhdx1985126/wip-67508

crimson/osd/recovery_backend: restart object pulls that are blocked by down osds

Reviewed-by: Matan Breizman <mbreizma@redhat.com>

Merge pull request #59085 from VallariAg/update-default-nvmeof-img

mgr/cephadm: bump DEFAULT_NVMEOF_IMAGE to 1.2.17

mgr/dashboard: improve prometheus service request handling

Fixes: https://tracker.ceph.com/issues/67067
Signed-off-by: Naman Munet <nmunet@redhat.com>

Merge pull request #59433 from idryomov/wip-drop-xmlstarlet-variable

qa: drop XMLSTARLET variable, use xmlstarlet directly

Reviewed-by: Ramana Raja <rraja@redhat.com>

crimson/os/seastore: ensure the block size of device is always greater than laddr_t::UNIT_SIZE

Signed-off-by: Zhang Song <zhangsong02@qianxin.com>

rbd-mirror: use correct ioctx for namespace

The PoolReplayer uses the ioctx for the default namespace
to check if other namespaces are enabled for mirroring, causing
it to incorrectly conclude that they are all enabled.

Fixes: https://tracker.ceph.com/issues/67676
Signed-off-by: N Balachandran <nibalach@redhat.com>

crimson/osd/pg: add logs for repeating pulls

Signed-off-by: Xuehan Xu <xuxuehan@qianxin.com>

Merge pull request #58870 from rhcs-dashboard/fix-67194-main

mgr/dashboard: fix typo in Multi-Cluster > Manager Cluster to Manage Clusters

Reviewed-by: Afreen Misbah <afreen23.git@gmail.com>

Merge pull request #59376 from rhcs-dashboard/Upgrade-page-scroll-issue

mgr/dashboard: can't scroll to the end of the page

Reviewed-by: Afreen Misbah <afreen23.git@gmail.com>