tests: aio_write/aio_discard have been refactored

Signed-off-by: Jason Dillaman <dillaman@redhat.com>

librbd: refactor AIO request handling

Move aio_read/write/discard/flush to new AioImageRequest classes
in support of a unified aio queue / journaling.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>

librbd: AIO submissions processed by new AioImageRequestWQ

New work queue has the ability to suspend write operations, which
should occur when exclusive locking is enabled and the client doesn't
own the lock.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>

librbd: rename AioRequest classes to AioObjectRequest

This better reflects the fact that these represent requests against
an object extent and helps differentiate it from the future
AioImageRequest classes.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>

librbd: rename C_AioWrite to C_AioRequest

This context is used for more than just write requests. It is always
tied to an AioCompletion, so moved request reference counting
management within class.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>

librbd: removed unused method declarations and definitions

Signed-off-by: Jason Dillaman <dillaman@redhat.com>

librbd: add support for dynamically enabling/disabling journaling

Signed-off-by: Jason Dillaman <dillaman@redhat.com>

pybind/rbd.py: add new journaling feature code

Signed-off-by: Jason Dillaman <dillaman@redhat.com>

librbd: add new RBD_FEATURE_JOURNALING feature code

When enabled, all mutable operations against an RBD image
will be recorded to a journal prior to changing the underlying
RBD image.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>

Merge branch 'wip-13504' of https://github.com/trociny/ceph

rbd: API: options on image create

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Conflicts:
src/test/librbd/test_librbd.cc (trivial, two tests added at end of file)

librbd: API: options on image create: update tests

Signed-off-by: Mykola Golub <mgolub@mirantis.com>

librbd: API: options on image create

Pass options as key/value configuration pairs on image create instead
of expanding rbd_create/rbd_clone/rbd_copy for every possible
configuration override.

Fixes: #13504
Signed-off-by: Mykola Golub <mgolub@mirantis.com>

Merge pull request #6557 from ceph/wip-rbd-cmake-fixes

cmake: librbd and libjournal build fixes

Reviewed-by: Jason Dillaman <dillaman@redhat.com>

Merge pull request #6556 from athanatos/wip-cmake-nss

cmake: add nss as a suffix for pk11pub.h

cmake: add nss as a suffix for pk11pub.h

Signed-off-by: Samuel Just <sjust@redhat.com>

librbd: provide an out-of-class definition for MAX_DESCRIPTION_OFFSET

std::min() takes its parameters by reference, so provide a definition
for OptionPrinter::MAX_DESCRIPTION_OFFSET constant.

Signed-off-by: Ilya Dryomov <idryomov@redhat.com>

cmake: fix librbd and add src/journal

librbd was missing a recently added file, src/journal was missing
entirely - this brings the build back.

Signed-off-by: Ilya Dryomov <idryomov@redhat.com>

Merge pull request #6517 from kylinstorage/wip-trivial-bug

osd: fix bug in last_* PG state timestamps

Reviewed-by: Sage Weil <sage@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #6552 from trociny/wip-journal

journal: incremental improvements and fixes

Reviewed-by: Jason Dillaman <dillaman@redhat.com>

Merge pull request #6462 from javacruft/wip/ec-modules

Build internal plugins and classes as modules

Reviewed-by: Loic Dachary <ldachary@redhat.com>

journal: update allocated tid when skipping committed entry in player

Otherwise, if on image open, there are no any uncommitted entries in
journal, allocated tid is not updated to the latest commited and
recording always starts from tid=0.

Signed-off-by: Mykola Golub <mgolub@mirantis.com>

Merge pull request #6539 from yehudasa/wip-cmake-fix

cmake: fix files list

Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #6316 from dillaman/wip-13494

rbd: dynamically generated bash completion

Reviewed-by: Josh Durgin <jdurgin@redhat.com>

Merge remote-tracking branch 'origin/jewel'

cmake: fix files list

Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>

cls::journal: fixup: constify dump functions

Signed-off-by: Mykola Golub <mgolub@mirantis.com>

journal: call metadata shutdown on journal remove

This fixes error observed when disabling journal:

  JournalMetadata: journal watch error: (107) Transport endpoint is not connected

Signed-off-by: Mykola Golub <mgolub@mirantis.com>

journal: don't use object_number when comparing positions

Only tid does matter.

Signed-off-by: Mykola Golub <mgolub@mirantis.com>

journal: make commit and flush params configurable

Signed-off-by: Mykola Golub <mgolub@mirantis.com>

journal: allow alternate pool for journal objects

Signed-off-by: Mykola Golub <mgolub@mirantis.com>

journal: output operators for journal types

They are going to be used for diagnostic.

Signed-off-by: Mykola Golub <mgolub@mirantis.com>

Merge pull request #6471 from mslovy/wip-check-reply-guard-again

osd: avoid double-check for replaying and can_checkpoint() in FileStore::_check_replay_guard

Reviewed-by: Josh Durgin <jdurgin@redhat.com>

Merge pull request #6426 from xiexingguo/xxg-wip-13642

librados: fix rare race where pool op callback may hang forever

Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #6407 from renhwztetecs/renhw-wip-13627

mon: initialize recorded election epoch properly even when standalone

Reviewed-by: Joao Eduardo Luis <joao@suse.de>
Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #6385 from Vicente-Cheng/mkfs-does-not-decode-an-existing-superblock

osd: fix reactivate (check OSDSuperblock in mkfs() when we already have the superblock)

Reviewed-by: Loic Dachary <ldachary@redhat.com>

Merge pull request #6373 from liewegas/wip-promoteon2ndread-ec

librados: fix PromoteOn2ndRead test for EC

Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #6520 from trociny/fix-rbd-apply_changes

rbd: make config changes actually apply

Reviewed-by: Jason Dillaman <dillaman@redhat.com>

Merge pull request #6347 from xiexingguo/xxg-wip-13566

osd: fixes for several cases where op result code was not checked or set

Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #5168 from majianpeng/dynamic-control-optracker

common: allow enable/disable of optracker at runtime

Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #6089 from SUSE/wip-init-ceph-getopt

init-ceph: use getopt to make option processing more flexible

Reviewed-by: Kefu Chai <kchai@redhat.com>

src/init-ceph.in: remove unused variables

Signed-off-by: Nathan Cutler <ncutler@suse.com>

src/init-ceph.in: improve usage message

Signed-off-by: Nathan Cutler <ncutler@suse.com>

src/init-ceph.in: process command-line options using getopt

http://tracker.ceph.com/issues/3015 Fixes: #3015

Signed-off-by: Nathan Cutler <ncutler@suse.com>

rbd: RBD::clone2: fix tracepoint

Signed-off-by: Mykola Golub <mgolub@mirantis.com>

Merge pull request #6516 from trociny/wip-13719

librbd: perf section name: use hyphen to separate components

Reviewed-by: Josh Durgin <jdurgin@redhat.com>

rbd: make config changes actually apply

Signed-off-by: Mykola Golub <mgolub@mirantis.com>

tests: rbd/admin_socket: use xmlstarlet when parsing perf dump

Signed-off-by: Mykola Golub <mgolub@mirantis.com>

librbd: perf section name: use hyphen to separate components

"/" and "@" characters make invalid xml format output.

Fixes: #13719
Signed-off-by: Mykola Golub <mgolub@mirantis.com>

doc: Adding --cluster option to rbd man page.

Fixes #13457
Signed-off-by: Vikhyat Umrao <vumrao@redhat.com>
Reviewed-by: Josh Durgin <jdurgin@redhat.com>

Merge pull request #6519 from kylinstorage/wip-revise-organization

revise organization

Reviewed-by: Loic Dachary <ldachary@redhat.com>

Merge pull request #6525 from dillaman/wip-13636-jewel

WorkQueue: new PointerWQ base class for ContextWQ

Reviewed-by: Josh Durgin <jdurgin@redhat.com>

Merge branch 'wip-11286' of https://github.com/dillaman/ceph

Reviewed-by: Josh Durgin <jdurgin@redhat.com>

Merge pull request #5987 from dillaman/wip-rbd-refactor

rbd: refactor cli command handling

Reviewed-by: Josh Durgin <jdurgin@redhat.com>

rbd: dynamically generated bash completion

The rbd CLI bash completion is now dynamically generated by extracting
the available commands and command options from the CLI application.

Fixes: #13494
Signed-off-by: Jason Dillaman <dillaman@redhat.com>

rbd: hidden 'bash-completion' command dumps all available commands

It also extracts all available options for a given command for use
which can be used by an improved bash completion script.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>

tests: updated rbd CLI --image-feature optional

Signed-off-by: Jason Dillaman <dillaman@redhat.com>

ceph_test_rados_api_tier: fix PromoteOn2ndRead for EC case

The ec and non-ec cases are copy&pasted code.  Yuck.  This duplicates the
non-ec fix from 347ac0f8.

Signed-off-by: Sage Weil <sage@redhat.com>

rbd: corrected handling of '--image-feature' optional

Signed-off-by: Jason Dillaman <dillaman@redhat.com>

Merge pull request #6488 from xiexingguo/xxg-wip-rados-cleanup

librados: do cleanup

Reviewed-by: Sebastien Ponce <sebastien.ponce@cern.ch>
Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #6523 from dillaman/wip-13740

librbd: perf counters might not be initialized on error

Reviewed-by: Josh Durgin <jdurgin@redhat.com>

WorkQueue: new PointerWQ base class for ContextWQ

The existing work queues do not properly function if added to a running
thread pool.  librbd uses a singleton thread pool which requires
dynamically adding/removing work queues as images are opened and closed.

Fixes: #13636
Signed-off-by: Jason Dillaman <dillaman@redhat.com>

librbd: perf counters might not be initialized on error

Fixes: #13740
Signed-off-by: Jason Dillaman <dillaman@redhat.com>

PendingReleaseNotes: document updated rbd CLI options

Signed-off-by: Jason Dillaman <dillaman@redhat.com>

Merge pull request #6522 from branch-predictor/bp-temporary-mon-fix

mon: revert MonitorDBStore's WholeStoreIteratorImpl::get

Reviewed-by: Loic Dachary <ldachary@redhat.com>

mon: revert MonitorDBStore's WholeStoreIteratorImpl::get

Revert MonitorDBStore's WholeStoreIteratorImpl::get method to state
before commit 66b7b920cf5a0a9c71212573ef47fb2c7ea9b5ff until better,
long-term solution for #13742 will be provided.

Signed-off-by: Piotr Dałek <piotr.dalek@ts.fujitsu.com>

revise organization

Signed-off-by: Li Wang <li.wang@kylin-cloud.com>

osd: fix trivial bug

Signed-off-by: Li Wang <li.wang@kylin-cloud.com>
Reported-by: Jie Wang <jie.wang@kylin-cloud.com>

Merge pull request #6394 from dillaman/wip-13560

krbd: remove deprecated --quiet param from udevadm

Reviewed-by: Josh Durgin <jdurgin@redhat.com>

Merge pull request #6508 from dillaman/wip-13726

librbd: deadlock while attempting to flush AIO requests

Reviewed-by: Josh Durgin <jdurgin@redhat.com>

Merge pull request #6447 from dillaman/wip-13674

librbd: resize should only update image size within header

Reviewed-by: Josh Durgin <jdurgin@redhat.com>

internal: remove unused local variables

Remove unused variables bl and bl2 in snap_list and ictx_refresh.
Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>

librados: cast oid to object explicitly before call ioctx methods
Cast oid to object explicitly before call ioctx methods.
Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>

Merge pull request #6513 from ceph/revert-6419-wip-openssl

Revert 0374bb4a2f5054d606e4aba2d97b5e6765e781b0

IoCtxImpl: remove unused variable sName

remove unused local variable sName in rollback.
Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>

Revert 0374bb4a2f5054d606e4aba2d97b5e6765e781b0

Merge pull request #6419 from ceph/wip-openssl

rgw: link against system openssl (instead of dlopen at runtime)

Reviewed-by: Yehuda Sadeh <yehuda@redhat.com>

Merge pull request #6453 from trociny/wip-2468

librbd: flush and invalidate cache via admin socket

Reviewed-by: Jason Dillaman <dillaman@redhat.com>

Merge pull request #6511 from liewegas/wip-fix-kv

kv: fix bug in kv key optimization

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Piotr Dałek <piotr.dalek@ts.fujitsu.com>

Merge branch 'wip-12955'

rgw: fix modification to index attrs when setting acls

Fixes: #12955
 - add ACL change after initial population
 - populate bufferlist with object attributes

Signed-off-by: Brian Felton <bjfelton@gmail.com>

kv: fix string ctor usage

When constructing a string from a char* there is only a single
length argument, no offset.  The 3 argument variant we were using
was converting to a std::string first (an prematurely terminating
on \0).

Signed-off-by: Sage Weil <sage@redhat.com>

Merge pull request #6047 from Sandy4999/wip-13140

rgw: fix swift API returning incorrect account metadata

Reviewed-by: Yehuda Sadeh <yehuda@redhat.com>

Merge pull request #6504 from dillaman/wip-13727

tests: fix typo in TestClsRbd.snapshots test case

Reviewed-by: Josh Durgin <jdurgin@redhat.com>

librbd: fixed deadlock while attempting to flush AIO requests

In-flight AIO requests might force a flush if a snapshot was created
out-of-band.  The flush completion was previously invoked asynchronously,
potentially via the same thread worker handling the AIO request. This
resulted in the flush operation deadlocking since it can't complete.

Fixes: #13726
Backport: infernalis, hammer
Signed-off-by: Jason Dillaman <dillaman@redhat.com>

tests: new test case to catch deadlock on RBD image refresh

Signed-off-by: Jason Dillaman <dillaman@redhat.com>

tests: librbd: admin socket commands to flush and invalidate cache

Signed-off-by: Mykola Golub <mgolub@mirantis.com>

librbd: flush and invalidate cache via admin socket

Fixes: #2468
Signed-off-by: Mykola Golub <mgolub@mirantis.com>

librbd: perf counter for cache invalidates

Signed-off-by: Mykola Golub <mgolub@mirantis.com>

Merge pull request #6312 from liewegas/wip-kv

kv: optimize and clean up internal key/value interface

Reviewed-by: Piotr Dałek <piotr.dalek@ts.fujitsu.com>

tests: fix typo in TestClsRbd.snapshots test case

Fixes: #13727
Signed-off-by: Jason Dillaman <dillaman@redhat.com>

Merge pull request #6300 from XinzeChi/wip-throttle-max

common: fix reset max in Throttle using perf reset command

Reviewed-by: Loic Dachary <ldachary@redhat.com>

Merge pull request #6364 from dillaman/wip-13491

osd: fix broken balance / localized read handling

Reviewed-by: Kefu Chai <kchai@redhat.com>

tracing: fix librados signed/unsigned warnings

Signed-off-by: Sage Weil <sage@redhat.com>

os/osd: disable extra iterator validation

In a number of loops using ObjectMapIterator, the iterator is validated
twice, first as an loop break condition, then during iter->next() call.
Suppress the validation in next() method in those cases for better
performance.

Signed-off-by: Piotr Dałek <piotr.dalek@ts.fujitsu.com>

os/KeyValueDB: don't call self.valid() from next() and prev()

In most loops using ObjectMapIteratorImpl, there is a call to valid()
followed by a call to next(), which calls valid() again. Calling
valid() alone is particularly expensive, so don't do it twice if
possible.

Signed-off-by: Piotr Dałek <piotr.dalek@ts.fujitsu.com>

mon/MonitorDBStore: use single-key LevelDB::get() method

Make MonitorDBStore use single-key ::get() method for some performance
increase in heavy K/V workloads.

Signed-off-by: Piotr Dałek <piotr.dalek@ts.fujitsu.com>

os/DBObjectMap: use single-key LevelDB::get method

Make FileStore use single-key ::get() method for some performance
increase in k/v-heavy workloads.

Signed-off-by: Piotr Dałek <piotr.dalek@ts.fujitsu.com>

kv/LevelDBStore: simpler code for single-key fetches

Often there's a need to fetch value for a specified, single key. Publish
a new method in LevelDB that takes key and prefix and puts just value at
specified address, without the need for interim keysets or resultsets.

Signed-off-by: Piotr Dałek <piotr.dalek@ts.fujitsu.com>

os/LevelDBStore: faster LevelDBTransactionImpl::set

This patch builds on Sage's idea to reduce bufferlist copying on
::set() calls. Initial patch reduced LevelDB's Slice generation
time from ~57ns to ~5ns in best-case scenario (bufferlist with
single bufferptr or contiguous bufferptrs), this patch reduces
slice generation time from ~57ns to ~11ns in worst case scenario
(under assumption that entire value length is at most 128KB),
leaving old code path for extremely-bad cases.

Signed-off-by: Piotr Dałek <piotr.dalek@ts.fujitsu.com>

kv/RocksDBStore: do not Delete before Put

A put implicitly overwrites the previous value.

Signed-off-by: Sage Weil <sage@redhat.com>