rgw: failing to reshard, restore old indexes

Signed-off-by: Shilpa Jagannath <smanjara@redhat.com>

rgw: allow clean_index to take const bucket_index_layout_generation&

fix bi_get() to get objects after being resharded

Signed-off-by: Shilpa Jagannath <smanjara@redhat.com>

rgw: - take non-optional gen_id in svc_bi_rados functions

     - call init_index() on target layout during reshard process.
       Takes const rgw::bucket_index_layout_generation&

Signed-off-by: Shilpa Jagannath <smanjara@redhat.com>

rgw: make RGWBucketInfo non-const in functions using guard_reshard()

 - remove unused 'instance_id' from cls_rgw_reshard_entry
 - other minor fixes

Signed-off-by: Shilpa Manjarabad Jagannath <smanjara@redhat.com>

rgw: target_layout to be optional

Signed-off-by: Shilpa Manjarabad Jagannath <smanjara@redhat.com>

rgw: use rgw::BucketReshardState for reshard state change

Signed-off-by: Shilpa Jagannath <smanjara@redhat.com>

rgw: fetch updated bucketinfo rather than bucket_id in guard_reshard

To be able to read the updated layout.

Signed-off-by: Shilpa Jagannath <smanjara@redhat.com>

rgw: use BucketReshardState states in appropriate places

This replaces cls_rgw_reshard_status.

Remove unused parameters in cls_rgw_bucket_instance_entry.
Other minor cleanup fixes.

Signed-off-by: Shilpa Jagannath <smanjara@redhat.com>

rgw/dynamic-resharding: Allow clean_index to take generation number

Signed-off-by: Shilpa Jagannath <smanjara@redhat.com>

rgw/dynamic-resharding: reshard bucket using the same instance id

Signed-off-by: Shilpa Jagannath <smanjara@redhat.com>

rgw/dynamic-resharding: remove creation of new bucket instance

Signed-off-by: Shilpa Jagannath <smanjara@redhat.com>

test/rgw: add --gen to radosgw-admin/help.t

Signed-off-by: Casey Bodley <cbodley@redhat.com>

rgw: add generations to error repo with binary format

adds a backward-compatible binary encoding for error repo keys that can
contain a generation number along with the bucket and shard

Signed-off-by: Casey Bodley <cbodley@redhat.com>

rgw: add generation support to BILog admin APIs

Signed-off-by: Shilpa Jagannath <smanjara@redhat.com>

rgw: remove rgw_bucket_shard_sync_info::full_marker

Signed-off-by: Casey Bodley <cbodley@redhat.com>

rgw: disable backoff on data sync error_retry_time

this backoff is triggered often by the per-bucket lease for full sync,
and causes tests to fail with checkpoint timeouts

Signed-off-by: Casey Bodley <cbodley@redhat.com>

qa/rgw: rgw_multisite_tests task loads default plugins

the ability to filter tests by attribute is provided by the
nose.plugins.attrib plugin, which wasn't being loaded by default

Signed-off-by: Casey Bodley <cbodley@redhat.com>

qa/rgw: disable multisite tests for 'bucket sync disable'

Signed-off-by: Casey Bodley <cbodley@redhat.com>

qa/rgw: add missing meta checkpoint to test_multipart_object_sync

if metadata sync hasn't finished, the 'bucket checkpoint' commands may
not find its bucket info

Signed-off-by: Casey Bodley <cbodley@redhat.com>

rgw: RGWSyncBucketCR holds lease over Init state too

Signed-off-by: Casey Bodley <cbodley@redhat.com>

rgw: fix up BucketShardIncrementalSync log message

Signed-off-by: Casey Bodley <cbodley@redhat.com>

rgw: move full sync from SyncBucketShard to SyncBucket

renamed ListBucketShardCR to ListRemoteBucketCR and removed the shard-id
parameter

renamed BucketFullSyncShardMarkerTrack to BucketFullSyncMarkerTrack,
which now updates the bucket-level rgw_bucket_sync_status

renamed BucketShardFullSyncCR to BucketFullSyncCR

BucketSyncCR now takes a bucket-wide lease during full sync

Signed-off-by: Casey Bodley <cbodley@redhat.com>

radosgw-admin: 'bucket sync checkpoint' waits for full sync

Signed-off-by: Casey Bodley <cbodley@redhat.com>

radosgw-admin: 'bucket sync status' displays new full sync status

Signed-off-by: Casey Bodley <cbodley@redhat.com>

rgw: add rgw_read_bucket_full_sync_status()

Signed-off-by: Casey Bodley <cbodley@redhat.com>

rgw: InitBucketShardSyncStatus always sets state to Incremental

full sync happens as the bucket level, so the shards will always start
in StateIncrementalSync

Signed-off-by: Casey Bodley <cbodley@redhat.com>

rgw: split SyncBucket from SyncBucketShard

Signed-off-by: Casey Bodley <cbodley@redhat.com>

rgw: add InitBucketFullSyncStatusCR

a coroutine to initialize a bucket for full sync using a new bucket-wide
sync status object

Signed-off-by: Casey Bodley <cbodley@redhat.com>

rgw: RGWSimpleRadosWriteAttrsCR supports exclusive create

Signed-off-by: Casey Bodley <cbodley@redhat.com>

rgw: system objects can set exclusive on set_attrs()

Signed-off-by: Casey Bodley <cbodley@redhat.com>

rgw: add exclusive flag to RGWSimpleRadosWriteCR

Signed-off-by: Casey Bodley <cbodley@redhat.com>

rgw: generalize error handling in RGWShardCollectCR

RGWShardCollectCR was hard-coded to ignore ENOENT errors and print a
'failed to fetch log status' error message. this moves that logic into a
handle_result() virtual function. it also exposes the member variables
'status' and 'max_concurrent' as protected, so they can be consulted or
modified by overrides of handle_result() and spawn_next()

Signed-off-by: Casey Bodley <cbodley@redhat.com>

rgw: add sync_bucket_shard_cr() factory function

allows other code to spawn this coroutine without having the class
definition

Signed-off-by: Casey Bodley <cbodley@redhat.com>

rgw: rename to RGWSyncBucketShardCR

Signed-off-by: Casey Bodley <cbodley@redhat.com>

rgw: add full_status_oid() for buckets

Signed-off-by: Casey Bodley <cbodley@redhat.com>

rgw: use const for string constants in rgw_data_sync.cc

Signed-off-by: Casey Bodley <cbodley@redhat.com>

rgw: rename to inc_status_oid

Signed-off-by: Casey Bodley <cbodley@redhat.com>

rgw: add data structures for bucket sync status

Signed-off-by: Casey Bodley <cbodley@redhat.com>

rgw: rename to rgw_read_bucket_inc_sync_status

Signed-off-by: Casey Bodley <cbodley@redhat.com>

rgw: remove unused RGWRunBucketsSyncBySourceCR

Signed-off-by: Casey Bodley <cbodley@redhat.com>

rgw: RGWSimpleRadosReadCR copies out objv_tracker

Signed-off-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #44833 from fstachura/wip-doc-more-pdf-links

doc: Fix links to CRUSH, RADOS and DSP research papers

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>

doc: Fix links to CRUSH, RADOS and DSP research papers.

Signed-off-by: Franciszek Stachura <fbstachura@gmail.com>

Merge pull request #44707 from liumiaomiaoIntel/qatdoc

doc/radosgw: update QAT acceleration to specify the configuration

Reviewed-by: Kefu Chai <tchaikov@gmail.com>

doc/radosgw: update QAT acceleration to specify the configuration

add and change the configuration steps to enable latest version of QAT
driver on QAT based encryption and compression

Signed-off-by: Miaomiao Liu <miaomiao.liu@intel.com>

Merge pull request #44816 from cbodley/wip-rgw-cmake-system

cmake/rgw: src/rgw and src/rgw/services are not system headers

Reviewed-by: Adam C. Emerson <aemerson@redhat.com>

Merge pull request #44801 from sebastian-philipp/doc-cephadm-count-per-host

doc/cephadm: Co-location of daemons

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by:Anthony D'Atri <anthony.datri@gmail.com>

Merge pull request #44823 from andriytk/fix-install-deps2

install-deps.sh: fix cortx-motr installation condition

install-deps.sh: fix cortx-motr installation condition

Don't try to install cortx-motr if it is already installed
or not needed. (Currently, it installs on any run from an
interactive terminal session).

Signed-off-by: Andriy Tkachuk <andriy.tkachuk@seagate.com>

Merge pull request #44711 from zdover23/wip-doc-2022-01-21-rados-bluestore-cache-autotune-interval-rewrite-2

src/rados: rewrite bs cache autotune instructions

Reviewed-by: Laura Flores <lflores@redhat.com>

Merge pull request #44703 from phlogistonjohn/jjm-issue46773

cephadm: validate that the constructed YumDnf baseurl is usable

Reviewed-by: Michael Fritch <mfritch@suse.com>

Merge pull request #44517 from adk3798/agent-cache

mgr/cephadm: store agent metadata in its own cache

Reviewed-By: Sebastian Wagner <sewagner@redhat.com>

cmake/rgw: src/rgw and src/rgw/services are not system headers

include these with -I instead of -isystem so we don't hide their
compiler warnings

Signed-off-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #44719 from zdover23/wip-doc-2021-01-22-man-page-radosgw-multitenancy-remove-double-quotes

doc/radosgw: replace double quotes with single

Reviewed-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #44379 from andriytk/add-motr-rgw-sal

rgw: add CORTX Motr SAL implementation

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
Reviewed-by: Casey Bodley <cbodley@redhat.com>
Reviewed-by: Soumya Koduri <skoduri@redhat.com>
Reviewed-by: Matt Benjamin <mbenjami@redhat.com>

Merge pull request #44654 from rhcs-dashboard/page-title-feature

mgr/dashboard: Page title should indicate current location

Reviewed-by: Sarthak0702 <NOT@FOUND>
Reviewed-by: Waad Alkhoury <walkhour@redhat.com>
Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>

Merge pull request #44793 from anthonyeleven/anthonyeleven/cephfs-mirroring

doc/cephfs: Clean up mirroring

Reviewed-by: Venky Shankar <vshankar@redhat.com>

rgw: add CORTX Motr SAL implementation

To build with Motr backend, use -DWITH_RADOSGW_MOTR=YES cmake
option. cortx-motr-devel rpm should be installed beforehand.

To connect to Motr cluster, add the following configuration
parameters to ceph.conf:

    [client]
            ...
            rgw backend store = motr
            motr profile fid  = 0x7000000000000001:0x4f
            motr ha endpoint  = inet:tcp:10.0.0.1@2001
    ...
    [client.rgw.8000]
            ...
            motr my endpoint  = inet:tcp:10.0.0.1@5001
            motr my fid       = 0x7200000000000001:0x29

The correct values for the Motr connection parameters can be
taken from `hctl status` cmd output after Motr cluster is
bootstrapped. In the example above, the values were taken from
the following output:

    Profile:
        0x7000000000000001:0x4f
    Services:
        centos8n1
        [started] hax       0x7200000000000001:0x6  inet:tcp:10.0.0.1@5001
        ...
        [unknown] m0_client 0x7200000000000001:0x29 inet:tcp:10.0.0.1@5001

Motr pkgs for the build/run can be taken from
https://github.com/Seagate/cortx-motr/releases/tag/2.0.0-rgw.

Co-authored-by: Sining Wu <sining.wu@seagate.com>
Signed-off-by: Andriy Tkachuk <andriy.tkachuk@seagate.com>

mgr/dashboard: Page title should indicate current location

Added titleService to BreadcrumbsComponent.

Fixes: https://tracker.ceph.com/issues/36587
Signed-off-by: Sarthak0702 <sarthak.0702@gmail.com>

doc/cephadm: Co-location of daemons

Signed-off-by: Sebastian Wagner <sewagner@redhat.com>

Merge pull request #44693 from rhcs-dashboard/configuration-test

mgr/dashboard: navigation page e2e fix

Reviewed-by: Waad Alkhoury <walkhour@redhat.com>
Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>

Merge pull request #44748 from cyx1231st/wip-crimson-improve-log-tm

crimson/os/seastore/transaction_manager: cleanups and logs

Reviewed-by: Samuel Just <sjust@redhat.com>

Merge pull request #44760 from mgfritch/fixup-asyncssh-mypy

mgr/cephadm: improve asyncssh type checking

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: John Mulligan <jmulligan@redhat.com>
Reviewed-by: Melissa Li <melissali@redhat.com>

Merge pull request #44792 from Matan-B/wip-matanb-email-contact

mailmap: Add Matan Breizman

Reviewed-by: Neha Ojha <nojha@redhat.com>

doc/cephfs: Clean up mirroring

Signed-off-by: Anthony D'Atri <anthony.datri@gmail.com>

mailmap: Add Matan Breizman

Add Matan Breizman to mailmap.

Signed-off-by: Matan Breizman <mbreizma@redhat.com>

Merge pull request #44304 from guits/guits-fix-cv-batch-mpath

ceph-volume: improve mpath devices support

Merge pull request #44782 from liu-chunmei/crimson-fix-content-corrupt

crimson: fix qa/RadosModel content corrupt

reviewed by: Samuel Just <sjust@redhat.com>

Merge pull request #44718 from liu-chunmei/crimson-fix-split_pin_right-assert

crimson: fix split_pin_left assert_aligned

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
Reviewed-by: Samuel Just <sjust@redhat.com>

crimson: fix qa/RadosModel content corrupt

RadosModel test read more length than object size, if truncate
not append zero to bufferlist, RadosMode will read more data and
it will check if there is content after the object size. So append
zero after truncate size to end of extent.

Signed-off-by: chunmei-liu <chunmei.liu@intel.com>

crimson: eliminate warning for unused variable

Signed-off-by: chunmei-liu <chunmei.liu@intel.com>

crimson: fix split_pin_left assert_aligned

hint passed to lba alloc_extent may not be block size aligned
in a certain case, this hint insert lba tree as key, so make
laddr in lba tree is not aligned.

Signed-off-by: chunmei-liu <chunmei.liu@intel.com>

ceph-volume: fix typo in tests

This fixes 2 typo in ceph-volume tests.

Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>

doc/ceph-volume: fix a typo

This fixes a typo in ceph-volume documentation.

Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>

ceph-volume: add a test `test_mpath_device_is_device`

This test checks that Device.is_device() returns True for a mpath device.

Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>

ceph-volume: improve mpath devices support

ee8887f4c0ff4f91117f31b621b95c8d08019130 was intended for adding
mpath devices support in ceph-volume but it has missed the lvm batch scenario.
This also fixes the zapping of mpath devices prepared with `ceph-volume raw`

Fixes: https://tracker.ceph.com/issues/52908
Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>

Merge pull request #44549 from melissa-kun-li/remove-iscsi

mgr/cephadm/iscsi: use `mon_command` in `post_remove` instead of `check_mon_command`

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Michael Fritch <mfritch@suse.com>

Merge pull request #44682 from sebastian-philipp/cephadm-ipv6-parse-ipv6-addr-wo-route

cephadm: _parse_ipv6_route: Fix parsing ifs w/o route

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Laura Flores <lflores@redhat.com>

mgr/cephadm: improve asyncssh type checking

asyncssh 2.9.0 introduces additional type hints

Fixes: https://tracker.ceph.com/issues/54003
Signed-off-by: Michael Fritch <mfritch@suse.com>

Merge pull request #44735 from neha-ojha/wip-reduce-cephadm

qa/suites/rados: reduce the number of cephadm tests

Reviewed-by: Adam King adking@redhat.com
Reviewed-by: Yuri Weinstein <yweinste@redhat.com>

Merge pull request #44662 from guits/cv-shared_ceph_folder

cephadm: add shared_ceph_folder opt to ceph-volume subcommand

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Sebastian Wagner <sewagner@redhat.com>

Merge pull request #44695 from liewegas/fix-cephadm-pretty-timedelta

pybind/mgr/mgr_util: fix to_pretty_timedelta()

Reviewed-by: Sebastian Wagner <sewagner@redhat.com>

Merge pull request #44459 from adk3798/misc-args

mgr/cephadm: allow miscellaneous container args at service level

Reviewed-by: John Mulligan <jmulligan@redhat.com>
Reviewed-by: Sebastian Wagner <sewagner@redhat.com>

Merge pull request #44192 from liuqinfei/docfix

doc: typo fixes in ceph-volume and install

cephadm: add shared_ceph_folder opt to ceph-volume subcommand

This commit adds the `--shared_ceph_folder` option to `ceph-volume`
subcommand, just like `shell` and `bootstrap` subcommands.

Fixes: https://tracker.ceph.com/issues/53931
Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>

Merge pull request #44282 from orozery/qa-qemu-nbd-ide-interface

qa/tasks/qemu: switch nbd devices from virtio to ide

Reviewed-by: Mykola Golub <mgolub@suse.com>
Reviewed-by: Deepika Upadhyay <dupadhya@redhat.com>
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>

Merge pull request #44066 from guits/guits-fix-rollback-osd

ceph-volume: zap osds in rollback_osd()

Merge pull request #44755 from ronen-fr/wip-rf-be2-clang1

osd/scrub: fix ceph::mutex usage

Reviewed-by: Aishwarya Mathuria <amathuri@redhat.com>
Reviewed-by: Willem Jan Withagen <wjw@digiware.nl>

Merge pull request #44740 from liu-chunmei/crimson-fix-remove_from_lru-assert

crimson: fix remove_from_lru assert

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Xuehan Xu <xxhdx1985126@gmail.com>

Merge pull request #44653 from cyx1231st/wip-crimson-osd-empty-transaction

crimson/osd: ShardServices::dispatch_context_transaction to flush

Reviewed-by: Samuel Just <sjust@redhat.com>

crimson/os/seastore/transaction_manager: consolidate logs in levels

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>

crimson/os/seastore/transaction_manager: abort when error

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>

crimson/os/seastore/transaction_manager: drop the extent metrics

These metrics won't distinguish extent operations from invalidated and
successful transactions.

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>

cephadm: fully replace agent files when writing them

otherwise, if the new file is shorter than the old one
we will end up with a malformed file retaining the end bit
of the old version

Signed-off-by: Adam King <adking@redhat.com>

mgr/cephadm: store agent metadata in its own cache

To avoid having the host cache getting too big
due to having to store this additional info

Fixes: https://tracker.ceph.com/issues/53624
Signed-off-by: Adam King <adking@redhat.com>

Merge pull request #44761 from mgfritch/cephadm-asyncssh-2_8

mgr/cephadm: require asyncssh 2.8

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Melissa Li <melissali@redhat.com>
Reviewed-by: John Mulligan <jmulligan@redhat.com>

mgr/cephadm: require asyncssh 2.8

Fixes: https://tracker.ceph.com/issues/54003
Signed-off-by: Michael Fritch <mfritch@suse.com>

osd/scrub: fix clang compilation issues

Issues created by the scrub-backend refactoring PR.

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>

Merge pull request #44737 from adamemerson/wip-wrong-modelines

cleanup: Change incorrect modelines

Reviewed-by: Kefu Chai <tchaikov@gmail.com>

crimson: fix remove_from_lru assert

RETIRED_PLACEHOLDER extent also put into retired set, when do
commit_retire_extent need check if it is RETIRED_PLACEHOLDER,
otherwise will cause remove_from_lru assert.

Signed-off-by: chunmei-liu <chunmei.liu@intel.com>