common: bufferlist: handle EINTR, check close rval

Signed-off-by: Colin McCabe <colinm@hq.newdream.net>

common: bufferlist::read_file: return read errors

Don't ignore errors when reading a file with buffer::list.

Signed-off-by: Colin McCabe <colinm@hq.newdream.net>

qa: rbd: small optimization to script

Signed-off-by: Colin McCabe <colinm@hq.newdream.net>

qa: rbd: Update rbd test to use the new rbd sysfs

Signed-off-by: Colin McCabe <colinm@hq.newdream.net>

qa: rbd: disable automatic keyring discovery

Signed-off-by: Colin McCabe <colinm@hq.newdream.net>

cconf: code cleanup

cconf: add a better usage() message, with examples. Give more helpful
error messages when the usage is wrong. Put different actions into
different functions. Eliminate unecessary globals.

Signed-off-by: Colin McCabe <colinm@hq.newdream.net>

auth: Fix buggy parsing of g_conf.keyring

Previously, we weren't correctly handling comma-separated lists of
values in g_conf.keyring.

Signed-off-by: Colin McCabe <colinm@hq.newdream.net>

common: str_list: const cleanup

Signed-off-by: Colin McCabe <colinm@hq.newdream.net>

osd, librados: configurable notify timeout

osd: watch request doesn't use version

also fix watch-notify to send the current user_version

qa/rbd: minor fixes

* qa/rbd/common: create tempdir for script

* qa/rbd/common: try harder to find monhost (try "mon addr" and also
"mon.a addr")

* qa/rbd/rbd.sh: honor $mnt parameter

Signed-off-by: Colin McCabe <colinm@hq.newdream.net>

makefile: ignore mkdir -p errors in install

Signed-off-by: Colin McCabe <colinm@hq.newdream.net>

cleanup: don't use __PRETTY_FUNCTION__

Its output isn't as pretty as I had hoped.

Signed-off-by: Colin McCabe <colinm@hq.newdream.net>

logging: clean up some error handling

Signed-off-by: Colin McCabe <colinm@hq.newdream.net>

osd: PG::Info::History: init last_epoch_clean

It seems that we have not been zeroing
PG::Info::History:last_epoch_clean when the History structure is
created. This led to some very interesting log output (and bugs!)

Signed-off-by: Colin McCabe <colinm@hq.newdream.net>

signals: handle_fatal_signal: use SA_NODEFER

SA_RESETHAND | SA_NODEFER allows the "re-trigger default signal handler"
trick to work for signals other than SIGSEGV.

Signed-off-by: Colin McCabe <colinm@hq.newdream.net>

signals: backtrace some more exotic fatal signals

We're not likely to see these, but if we do, we want it in the logs!

Signed-off-by: Colin McCabe <colinm@hq.newdream.net>

signals: test infinite_recursion

Signed-off-by: Colin McCabe <colinm@hq.newdream.net>

common: make generic_usage a little prettier

Signed-off-by: Colin McCabe <colinm@hq.newdream.net>

signals: Handle SIGILL, SIGBUS, SIGFPE.

Print out a backtrace when we get SIGILL, SIGBUS, or SIGFPE. Fix a bug
where we failed to install a SIGABRT handler.

Signed-off-by: Colin McCabe <colinm@hq.newdream.net>

test: add TestSignalHandlers

Signed-off-by: Colin McCabe <colinm@hq.newdream.net>

rgw_admin: fix compile error in usage

generic_usage was changed in c4b5c33b123edfc7770e156b4b7f183f8b0af0c9
but this use was not updated.  Should call generic_client_usage.

librados: Fix compile error by adding std:: namespace

No idea how this got left out or passed any testing?

Signed-off-by: Greg Farnum <gregf@hq.newdream.net>

objectcacher: Fix erroneous reference to "lock" with "flock."

This looks to be an old bug introduced years ago in
267679abc7e29e73655da7367d87e22a0a0d2375, and left
undiscovered due to code unuse.
Discovered by inspection while searching for clues to other issues.

Signed-off-by: Greg Farnum <gregf@hq.newdream.net>

mds: issue caps on regular files created via MKNOD

Give the client some caps to write with.  This is similar to the current
MKDIR behavior, but with different bits.

Signed-off-by: Sage Weil <sage@newdream.net>

mds: set a writeable client range on regular files created via MKNOD

If the client reexports ceph via nfs, file creations come through as
a MKNOD followed by OPEN.  If it's a MKNOD on a normal file, assume that
the client will probably write to it and set them up with the caps and
client_range to do so without asking us again first.

Signed-off-by: Sage Weil <sage@newdream.net>

mds: set layout on files created by MKNOD instead of CREATE

Signed-off-by: Sage Weil <sage@newdream.net>

cephx: fix uninitialized value

Signed-off-by: Sage Weil <sage@newdream.net>

osd: refactor _get_pool / _put_pool a little bit

Signed-off-by: Colin McCabe <colinm@hq.newdream.net>

osd: OSD::_lookup_pool: avoid double lookup

Signed-off-by: Colin McCabe <colinm@hq.newdream.net>

test: create test_pools.sh

Signed-off-by: Colin McCabe <colinm@hq.newdream.net>

logging: eliminate out-of-range dout calls

Eliminate calls to dout that use non-existent log levels, like negative
levels less than -1. Also trigger a compiler error in the future if they
get re-added. -1 is the highest priority dout level; putting lower
priorities into the output buffer will just cause errors.

Signed-off-by: Colin McCabe <colinm@hq.newdream.net>

common: more cerr -> derr conversions

cmds: cerr -> derr

DoutStreambuf: primitive_log: just write to the stdout fd rather than cerr

assert: don't write output to stderr manually (dout will do that
automatically). Do _dout_lock.Lock rather than TryLock. Failing to wait
for the lock is potentially buggy and provides no benefit in that code.

Signed-off-by: Colin McCabe <colinm@hq.newdream.net>

gceph,ceph: replace cerr->derr

Signed-off-by: Colin McCabe <colinm@hq.newdream.net>

cosd: replace cerr with derr

Signed-off-by: Colin McCabe <colinm@hq.newdream.net>

osd: FileJournal: use derr

Use derr to announce errors in FileJournal.

Handle EINTR where necessary (still haven't fixed
read/write/pread/pwrite uses).

Signed-off-by: Colin McCabe <colinm@hq.newdream.net>

logging: re-introduce derr

Re-introduce derr as a special log level (level -1) which will show up
in all logs, and on stderr. These messages are the only messages which
will show up on stderr.

Signed-off-by: Colin McCabe <colinm@hq.newdream.net>

osd: send notify message only to unexpired watchers

osd: timed out watcher is added to unconnected map

logging: close file when reloading global config

Signed-off-by: Colin McCabe <colinm@hq.newdream.net>

osd: fix watch timer, locking

tools: don't start msgr thread before daemonize

Calling messenger->add_dispatcher_head() has the side-effect of starting
the messenger thread. So we must not do it before calling
messenger->start(), which sometimes calls daemonize.

Signed-off-by: Colin McCabe <colinm@hq.newdream.net>

Merge branch 'objecter' into unstable

objecter: check for pg mapping changes in each incremental; refactor misc resubmission code

We need to detect when a pg mapping changes but the primary stays the same.
That means we can't just look at the final osdmap and see what is says; we
have to look at each intervening map and check each request to see if
something switched and the osd has thrown our request out.

Also refactor and clean up the linger vs normal op stuff some more.

Signed-off-by: Sage Weil <sage@newdream.net>

objecter: add reopen_session helper

Signed-off-by: Sage Weil <sage@newdream.net>

objecter: cleanup: rename op maps

Signed-off-by: Sage Weil <sage@newdream.net>

objecter: track pending requests by osd, not pg

This is a big cleanup.  Also
 - switch to keeping per-osd Connection *'s
 - make requests time out independently (not very efficiently yet)

Signed-off-by: Sage Weil <sage@newdream.net>

mds: fix inode ancestor attr encoding

Signed-off-by: Sage Weil <sage@newdream.net>

msgr: mark down by Connection*

Signed-off-by: Sage Weil <sage@newdream.net>

automake: ignore rmdir errors during uninstall

We don't want to fail "make distcheck" for a silly reason.

Signed-off-by: Colin McCabe <colinm@hq.newdream.net>

osd: send pending notification for reconnected watcher

automake: add osd/Watch.h to noinst_HEADERS

Signed-off-by: Colin McCabe <colinm@hq.newdream.net>

logging: use Mutex::Locker

Use Mutex::Locker to make logging exception-safe. That is, if you are
doing "dout() << foo() << dendl;" and foo throws an exception, the dout
mutex will not be left in a locked state.

Signed-off-by: Colin McCabe <colinm@hq.newdream.net>

logger: Fix DoutStreambuf::create_rank_symlink

Signed-off-by: Colin McCabe <colinm@hq.newdream.net>

cephtool: rename tools files

Rename tools files to be more consistent. For example, the main()
function for ./ceph should be in ceph.cc.

Signed-off-by: Colin McCabe <colinm@hq.newdream.net>

Merge branch 'sync2' into unstable

librados: drop watch_lock

Use the existing lock to do protect all of this.

Signed-off-by: Sage Weil <sage@newdream.net>

objecter: drop linger_info_mutex

Signed-off-by: Sage Weil <sage@newdream.net>

objecter: simplify linger register

Drop single-use helper; make unregister_linger part of the public
interface.

Signed-off-by: Sage Weil <sage@newdream.net>

objecter: fix up linger ack/commit to trigger first time only

We only want the user-provided ack/commit callbacks to trigger the first
time we register the lingering op.  Same goes for the eversion_t *objver.

Signed-off-by: Sage Weil <sage@newdream.net>

objecter: clean up linger interface

Put LingerOp on heap.  Use xlist to attach to PGs.  Add in/out bufferlists.

Signed-off-by: Sage Weil <sage@newdream.net>

Merge remote branch 'origin/unstable' into sync2

Conflicts:
src/auth/Crypto.cc
src/osd/ReplicatedPG.cc
src/osd/ReplicatedPG.h
src/osd/osd_types.h

logging: Fix use-before-access in debug.cc

Signed-off-by: Vangelis Koukis <vkoukis@cslab.ece.ntua.gr>
Signed-off-by: Constantinos Venetsanopoulos <cven@cslab.ece.ntua.gr>
Signed-off-by: Colin McCabe <colinm@hq.newdream.net>

osd: return ENOSPC for non-mds if full flag is set in osdmap

Signed-off-by: Sage Weil <sage@newdream.net>

Merge remote branch 'origin/syslog' into unstable

Conflicts:
src/mon/Paxos.cc
src/osd/PG.cc

Merge branch 'gceph' into unstable

gceph: Add gceph to rpm, deb

Signed-off-by: Colin McCabe <colinm@hq.newdream.net>

gceph: run shutdown functions at exit

Signed-off-by: Colin McCabe <colinm@hq.newdream.net>

gceph: fix compile

Signed-off-by: Colin McCabe <colinm@hq.newdream.net>

gceph: add -h argument

Signed-off-by: Colin McCabe <colinm@hq.newdream.net>

ceph tool: Create gceph

Put the gui into a separate binary.

Signed-off-by: Colin McCabe <colinm@hq.newdream.net>

librados, objecter: fix unwatch operation

rpm: update changelog

Signed-off-by: Colin McCabe <colinm@hq.newdream.net>

rpm: fix ceph.spec to work with gcephtool

Don't try to package gui_resources unless we are building the GUI.
Get GUI dependencies correct.

Signed-off-by: Colin McCabe <colinm@hq.newdream.net>

objecter: resend_linger copies ops

Fix overflow in FileJournal::_open_file()

[ The following text is in the "iso-8859-7" character set. ]
    [ Your display is set for the "iso-8859-1" character set.  ]
    [ Some special characters may be displayed incorrectly. ]

Running the unstable branch, mkcephfs fails when trying to create
a 3GB journal file on the OSDs.

Relevant messages from the osd logfile:

2010-12-09 19:03:54.419737 7fdde4d51720 journal _open_file: unable to extend journal to 18446744072560312320 bytes
2010-12-09 19:03:54.419789 7fdde4d51720 filestore(/osd) mkjournal error creating journal on /osd/journal

The problem is that the calculation of the journal size in bytes
overflows, in FileJournal::_open_file().

Signed-off-by: Vangelis Koukis <vkoukis@cslab.ece.ntua.gr>
Signed-off-by: Sage Weil <sage@newdream.net>

ReplicatedPG.cc: Fixes a bug in snap_trimmer where a pointer to a stack
Cond is left in the mode.waiting_cond list.

Signed-off-by: Samuel Just <samuelj@hq.newdream.net>

ReplicatedPG: snap_trimmer now acquires a read lock on the osd map
before calling share_pg_info.

Signed-off-by: Samuel Just <samuelj@hq.newdream.net>

rpm: don't try to package radosacl

radosacl is just a test binary, so unless we build with --with-debug, we
won't get it.

Signed-off-by: Colin McCabe <colinm@hq.newdream.net>

rpm: add pkgconfig to BuildRequires

You can't build without pkgconfig.

Signed-off-by: Colin McCabe <colinm@hq.newdream.net>

rpm: set files-attr for radosgw

Signed-off-by: Colin McCabe <colinm@hq.newdream.net>

filejournal: reset last_commited_seq if we find journal to be invalid

If we read an event that's later than our expected entry, we set read_pos
to -1 and discard the journal.  If that happens we also need to reset
last_committed_seq to avoid a crash like

2010-12-08 17:04:39.246950 7f269d138910 journal commit_finish thru 16904
2010-12-08 17:04:39.246961 7f269d138910 journal committed_thru 16904 < last_committed_seq 37778589
os/FileJournal.cc: In function 'virtual void FileJournal::committed_thru(uint64_t)':
os/FileJournal.cc:854: FAILED assert(seq >= last_committed_seq)
 ceph version 0.24~rc (commit:fe10300317383ec29948d7dbe3cb31b3aa277e3c)
 1: (FileJournal::committed_thru(unsigned long)+0xad) [0x588e7d]
 2: (JournalingObjectStore::commit_finish()+0x8c) [0x57f2ec]
 3: (FileStore::sync_entry()+0xcff) [0x5764cf]
 4: (FileStore::SyncThread::entry()+0xd) [0x506d9d]
 5: (Thread::_entry_func(void*)+0xa) [0x4790ba]
 6: /lib/libpthread.so.0 [0x7f26a2f8373a]
 7: (clone()+0x6d) [0x7f26a1c2569d]

Fixes #631

Signed-off-by: Sage Weil <sage@newdream.net>

objecter: create a new op for resending lingering requests

logger: tweak cmon log output a bit

Make the output of cmon on stderr a little bit less verbose.

Signed-off-by: Colin McCabe <colinm@hq.newdream.net>

logging: DoutStreambuf: handle daemonizing better

Signed-off-by: Colin McCabe <colinm@hq.newdream.net>

objecter: a few lingering fixes

mon: use helper for clock drift check; log relative instead of absolute time

Signed-off-by: Sage Weil <sage@newdream.net>

logging: debug.h: use DoutStreambuf

Signed-off-by: Colin McCabe <colinm@hq.newdream.net>

logging: Remove _dout_check_log

_dout_check_log is unneeded, since every invocation of dout makes the
same check.

Signed-off-by: Colin McCabe <colinm@hq.newdream.net>

logging: debug.h: minor cleanup

Don't put std::ostream into the global namespace. Copyright update.

Signed-off-by: Colin McCabe <colinm@hq.newdream.net>

logging: eliminate dbeginl

Signed-off-by: Colin McCabe <colinm@hq.newdream.net>

logging: Implement rank symlinks

Signed-off-by: Colin McCabe <colinm@hq.newdream.net>

logging: Support isym_path

Support instance symlinks, which are activated when we are using
g_conf.log_per_instance.

Signed-off-by: Colin McCabe <colinm@hq.newdream.net>

logging: rename_output_file -> handle_pid_change

Signed-off-by: Colin McCabe <colinm@hq.newdream.net>

logging: _calculate_opath: use g_conf.log_dir

Signed-off-by: Colin McCabe <colinm@hq.newdream.net>

logging: DoutStreambuf: better debug output

Signed-off-by: Colin McCabe <colinm@hq.newdream.net>

logging: create_symlink:sometimes use rel symlinks

Signed-off-by: Colin McCabe <colinm@hq.newdream.net>

logging: implement get_dirname, move get_basename

Signed-off-by: Colin McCabe <colinm@hq.newdream.net>

logging: fix normalize_relative

Signed-off-by: Colin McCabe <colinm@hq.newdream.net>

mds: sync->mix replica state is sync->mix(2)

When auth first moves to sync->mix,
 - auth sends AC_MIX to replicas
 - replicas go to sync->mix
 - replicas finish gather, send AC_SYNCACK, move to sync->mix(2)
 - auth gets all acks, sends AC_MIX again
 - replica moves to MIX

So any new replica should just get sync->mix(2), so that it is not confused
by the second AC_MIX.

Signed-off-by: Sage Weil <sage@newdream.net>