]>
git.apps.os.sepia.ceph.com Git - ceph.git/log
Sage Weil [Thu, 31 Aug 2017 13:31:53 +0000 (09:31 -0400)]
doc/man/8/ceph: remove old 'ceph pg ' force_create_pg, set_[near]full_ratio
Signed-off-by: Sage Weil <sage@redhat.com>
Sage Weil [Thu, 31 Aug 2017 02:35:03 +0000 (22:35 -0400)]
ceph-object-corpus: PGMap encoding change
Signed-off-by: Sage Weil <sage@redhat.com>
Sage Weil [Tue, 29 Aug 2017 03:53:18 +0000 (23:53 -0400)]
mon: do not join quorum unless luminous upgrade has completed
Signed-off-by: Sage Weil <sage@redhat.com>
Sage Weil [Tue, 29 Aug 2017 03:43:06 +0000 (23:43 -0400)]
mon/OSDMonitor: encode without MIMIC if require_osd_release < mimic
Signed-off-by: Sage Weil <sage@redhat.com>
Sage Weil [Mon, 28 Aug 2017 21:18:00 +0000 (17:18 -0400)]
mon: remove mon_osd_allow_primary_{temp,affinity}
These are covered by require_osd_release in the OSDMap.
Signed-off-by: Sage Weil <sage@redhat.com>
Sage Weil [Mon, 28 Aug 2017 21:18:16 +0000 (17:18 -0400)]
mon/Elector: drop pre-luminous elector compat
Signed-off-by: Sage Weil <sage@redhat.com>
Sage Weil [Mon, 28 Aug 2017 21:14:10 +0000 (17:14 -0400)]
mon/PGMap: remove old PGMapUpdater methods
These were used by PGMonitor.
Signed-off-by: Sage Weil <sage@redhat.com>
Sage Weil [Mon, 28 Aug 2017 21:11:20 +0000 (17:11 -0400)]
osd/OSDMap: remove unused static
Signed-off-by: Sage Weil <sage@redhat.com>
Sage Weil [Mon, 28 Aug 2017 21:11:07 +0000 (17:11 -0400)]
mon/PGMap: remove legacy encode/decode methods
These were used by PGMonitor when stored in per-pg and per-osd k/v
pairs.
Signed-off-by: Sage Weil <sage@redhat.com>
Sage Weil [Mon, 28 Aug 2017 21:08:47 +0000 (17:08 -0400)]
mon/PGMap: streamline encoding
The only user left is 'pg getmap' and ceph-dencoder; we can drop
the compat cruft.
Signed-off-by: Sage Weil <sage@redhat.com>
Sage Weil [Mon, 28 Aug 2017 21:07:59 +0000 (17:07 -0400)]
mon/PGMap: remove unused functions
These are left over from health cleanup
Signed-off-by: Sage Weil <sage@redhat.com>
Sage Weil [Mon, 28 Aug 2017 21:07:09 +0000 (17:07 -0400)]
mon/PGMap: remove Incremental encode/decode
Unused!
Signed-off-by: Sage Weil <sage@redhat.com>
Sage Weil [Mon, 28 Aug 2017 21:03:08 +0000 (17:03 -0400)]
mon/PGMap: remove osd_epochs
This was used for the min_last_epoch_clean tracking; we don't need
it now.
Signed-off-by: Sage Weil <sage@redhat.com>
Sage Weil [Mon, 28 Aug 2017 20:54:45 +0000 (16:54 -0400)]
mon/PGMap: remove min_last_epoch_clean
Signed-off-by: Sage Weil <sage@redhat.com>
Sage Weil [Mon, 28 Aug 2017 20:37:04 +0000 (16:37 -0400)]
osd/OSDMap: remove get_full_osd_util
Signed-off-by: Sage Weil <sage@redhat.com>
Sage Weil [Mon, 28 Aug 2017 20:43:14 +0000 (16:43 -0400)]
mon/PGMap: remove full osd tracking
Also drop compat PGMap encoding since we are >= luminous and this is
local to the mgr anyway.
Signed-off-by: Sage Weil <sage@redhat.com>
Sage Weil [Mon, 28 Aug 2017 20:34:30 +0000 (16:34 -0400)]
mon: remove PGStatService
Signed-off-by: Sage Weil <sage@redhat.com>
Sage Weil [Mon, 28 Aug 2017 20:33:09 +0000 (16:33 -0400)]
mon: drop pgservice member
Just use mgrstatmon() directly.
Signed-off-by: Sage Weil <sage@redhat.com>
Sage Weil [Mon, 28 Aug 2017 20:31:59 +0000 (16:31 -0400)]
mon: make MgrStatMonitor implement PGStatService directly
Avoid the intermediate glue class, simplify.
Signed-off-by: Sage Weil <sage@redhat.com>
Sage Weil [Mon, 28 Aug 2017 20:23:09 +0000 (16:23 -0400)]
mon/PGStatService: prune interface
Remove now unused methods
Signed-off-by: Sage Weil <sage@redhat.com>
Sage Weil [Mon, 28 Aug 2017 20:25:04 +0000 (16:25 -0400)]
mon/OSDMonitor: drop pre-luminous PGStatService users
These are no longer relevant now that we are >= luminous.
Signed-off-by: Sage Weil <sage@redhat.com>
Sage Weil [Mon, 28 Aug 2017 20:21:13 +0000 (16:21 -0400)]
mon: drop PGMapStatService
There is only one user and one implementation; this just makes the
code hard to read.
Signed-off-by: Sage Weil <sage@redhat.com>
Sage Weil [Mon, 28 Aug 2017 19:45:41 +0000 (15:45 -0400)]
mon/OSDMonitor: drop legacy 'osd df'
Signed-off-by: Sage Weil <sage@redhat.com>
Sage Weil [Mon, 28 Aug 2017 19:43:50 +0000 (15:43 -0400)]
mon: add MIMIC mon feature
Signed-off-by: Sage Weil <sage@redhat.com>
Sage Weil [Sat, 26 Aug 2017 19:22:15 +0000 (15:22 -0400)]
mon: drop hide_mgr_flag behavior
Signed-off-by: Sage Weil <sage@redhat.com>
Sage Weil [Sat, 26 Aug 2017 19:13:54 +0000 (15:13 -0400)]
mon: collapse MonPGStatService into PGStatService
Signed-off-by: Sage Weil <sage@redhat.com>
Sage Weil [Sat, 26 Aug 2017 19:13:01 +0000 (15:13 -0400)]
mon: remove some upgrade-specific bits of PGStatService
Signed-off-by: Sage Weil <sage@redhat.com>
Sage Weil [Sat, 26 Aug 2017 18:51:32 +0000 (14:51 -0400)]
mon: remove PGMonitor
Signed-off-by: Sage Weil <sage@redhat.com>
Sage Weil [Fri, 25 Aug 2017 22:38:49 +0000 (18:38 -0400)]
mon: remove OldHealthMonitor
The only service this provided was mon space notifications, which
are now handled explicitly by the new HealthMonitor's
check_member_health(), and communited by the new MMonHealthChecks.
Signed-off-by: Sage Weil <sage@redhat.com>
Sage Weil [Fri, 25 Aug 2017 22:31:54 +0000 (18:31 -0400)]
mon: remove legacy get_health infrastructure
Signed-off-by: Sage Weil <sage@redhat.com>
Sage Weil [Mon, 28 Aug 2017 19:24:46 +0000 (15:24 -0400)]
mon: CEPH_MON_FEATURE_INCOMPAT_MIMIC
Signed-off-by: Sage Weil <sage@redhat.com>
Sage Weil [Mon, 28 Aug 2017 19:23:46 +0000 (15:23 -0400)]
mon: require SERVER_LUMINOUS from mons, osds
Signed-off-by: Sage Weil <sage@redhat.com>
Orit Wasserman [Wed, 6 Sep 2017 07:23:30 +0000 (10:23 +0300)]
Merge pull request #16145 from yehudasa/wip-20234
rgw: add tail tag to track tail instance
Reviewed-by: Orit Wasserman <owasserm@redhat.com>
Mykola Golub [Wed, 6 Sep 2017 07:14:04 +0000 (10:14 +0300)]
Merge pull request #17502 from dillaman/wip-21248
librbd: rename of non-existent image results in seg fault
Reviewed-by: Nathan Cutler <ncutler@suse.com>
Mykola Golub [Wed, 6 Sep 2017 06:27:38 +0000 (09:27 +0300)]
Merge pull request #17375 from liupan1111/wip-final-fix-nbd
rbd-nbd: fix generic option issue
Reviewed-by: Mykola Golub <mgolub@mirantis.com>
Jos Collin [Wed, 6 Sep 2017 04:18:39 +0000 (04:18 +0000)]
Merge pull request #17507 from batrick/githubmap-update
githubmap: add some known Ceph reviewers
Reviewed-by: Jos Collin <jcollin@redhat.com>
Patrick Donnelly [Wed, 6 Sep 2017 03:49:54 +0000 (20:49 -0700)]
Merge PR #17319 into master
* refs/remotes/upstream/pull/17319/head:
qa: whitelist expected rstat warning
qa: sync whitelist with fs/basic_functional
qa: whitelist expected MDS_CACHE_OVERSIZED
Reviewed-by: Zheng Yan <zyan@redhat.com>
Patrick Donnelly [Wed, 6 Sep 2017 03:49:19 +0000 (20:49 -0700)]
Merge PR #17301 into master
* refs/remotes/upstream/pull/17301/head:
mds: fix "1 filesystem is have a..." message
Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Patrick Donnelly [Wed, 6 Sep 2017 03:45:35 +0000 (20:45 -0700)]
Merge PR #17263 into master
* refs/remotes/upstream/pull/17263/head:
mds: remove unused method
mds: move EMetaBlob cons to header
Reviewed-by: Zheng Yan <zyan@redhat.com>
Patrick Donnelly [Wed, 6 Sep 2017 03:44:39 +0000 (20:44 -0700)]
Merge PR #17178 into master
* refs/remotes/upstream/pull/17178/head:
ceph-dencoder: simplify decoding/encoding cephfs inode
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Sage Weil <sage@redhat.com>
Patrick Donnelly [Wed, 6 Sep 2017 03:44:04 +0000 (20:44 -0700)]
Merge PR #17095 into master
* refs/remotes/upstream/pull/17095/head:
client: reset unmounting flag to false when starting a new mount
client: add mountedness check inside client_lock
client: rework Client::get_local_osd() return codes
client: remove misleading comment in get_cap_ref
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Douglas Fuller <dfuller@redhat.com>
Patrick Donnelly [Wed, 6 Sep 2017 03:43:28 +0000 (20:43 -0700)]
Merge PR #16562 into master
* refs/remotes/upstream/pull/16562/head:
cephfs/fuse: set big_writes default is false
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Patrick Donnelly [Wed, 6 Sep 2017 03:42:30 +0000 (20:42 -0700)]
Merge PR #16305 into master
* refs/remotes/upstream/pull/16305/head:
qa/cephfs: test CephFS recovery pools
qa/cephfs: support CephFS recovery pools
qa/ceph_test_case: support CephFS recovery pools
qa/cephfs: Allow deferred fs creation
qa/cephfs: Refactor alternate pool test
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Patrick Donnelly [Tue, 5 Sep 2017 21:54:06 +0000 (14:54 -0700)]
githubmap: add some known GitHub reviewers
Selection from [1] where the GitHub username is available.
[1] http://pad.ceph.com/p/reviewers
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
Kefu Chai [Wed, 6 Sep 2017 03:16:08 +0000 (11:16 +0800)]
Merge pull request #17447 from tchaikov/wip-freebsd-coredump
test/coredumpctl: support freebsd
Reviewed-by: Willem Jan Withagen <wjw@digiware.nl>
Patrick Donnelly [Tue, 5 Sep 2017 19:48:41 +0000 (12:48 -0700)]
Merge PR #17373 into master
* refs/remotes/upstream/pull/17373/head:
doc/cephfs: add info on using EC pools with CephFS
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Jason Dillaman [Tue, 5 Sep 2017 16:11:45 +0000 (12:11 -0400)]
librbd: rename of non-existent image results in seg fault
Fixes: http://tracker.ceph.com/issues/21248
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
Casey Bodley [Tue, 5 Sep 2017 15:39:12 +0000 (11:39 -0400)]
Merge pull request #17141 from theanalyst/doc-civetweb-ports
doc: rgw: mention the civetweb support for binding to multiple ports
Reviewed-by: Casey Bodley <cbodley@redhat.com>
Jason Dillaman [Tue, 5 Sep 2017 14:13:50 +0000 (10:13 -0400)]
Merge pull request #17436 from ashishkumsingh/wip-doc-fix-snapshot-flatten-example
doc: Fixes rbd snapshot flatten example
Reviewed-by: Jason Dillaman <dillaman@redhat.com>
Sage Weil [Tue, 5 Sep 2017 14:05:46 +0000 (09:05 -0500)]
Merge pull request #17457 from batrick/githubmap
githubmap: add map for GitHub contributor lookup
Reviewed-by: Sage Weil <sage@redhat.com>
Jos Collin [Tue, 5 Sep 2017 12:12:30 +0000 (12:12 +0000)]
Merge pull request #17489 from mychoxin/yuanxin_deep_copy
include/buffer.h: fix typo in comment
Reviewed-by: Jos Collin <jcollin@redhat.com>
xin.yuan [Tue, 5 Sep 2017 11:25:39 +0000 (19:25 +0800)]
include/buffer.h: fix comment 'no not allow' -> 'do not allow'
Signed-off-by: mychoxin <mychoxin@gmail.com>
Kefu Chai [Tue, 5 Sep 2017 05:43:05 +0000 (13:43 +0800)]
Merge pull request #17430 from Songweibin/wip-osd-misc
osd: misc cleanups
Reviewed-by: xie xingguo <xie.xingguo@zte.com.cn>
Kefu Chai [Tue, 5 Sep 2017 05:02:03 +0000 (13:02 +0800)]
Merge pull request #16476 from renhwztetecs/renhw-wip-mgr-standby-ip
mgr: add the ip addr of standbys
Reviewed-by: John Spray <john.spray@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
Kefu Chai [Tue, 5 Sep 2017 04:52:57 +0000 (12:52 +0800)]
Merge pull request #17431 from tchaikov/wip-da-SCA-
20170510
Coverity and SCA fixes
Reviewed-by: Jason Dillaman <dillaman@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
Kefu Chai [Mon, 4 Sep 2017 08:12:55 +0000 (16:12 +0800)]
test/coredumpctl: support freebsd
setrlimit() on platforms without prctl()
Signed-off-by: Kefu Chai <kchai@redhat.com>
Kefu Chai [Tue, 5 Sep 2017 02:05:09 +0000 (10:05 +0800)]
Merge pull request #17437 from tchaikov/wip-refactor-build_initial_pg_history
osd: update info only if new_interval
Reviewed-by: xie xingguo <xie.xingguo@zte.com.cn>
Kefu Chai [Tue, 5 Sep 2017 01:33:24 +0000 (09:33 +0800)]
Merge pull request #17393 from tchaikov/wip-cmake-disable-vta
cmake: disable VTA on options.cc
Reviewed-by: Sage Weil <sage@redhat.com>
Patrick Donnelly [Mon, 4 Sep 2017 19:08:08 +0000 (12:08 -0700)]
githubmap: add map for GitHub contributor lookup
Idea of this is to allow scripts to lookup the contributor name/email by GitHub
username. This is useful in particular for adding appropriate "Reviewed-by"s
for each GitHub style "review".
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
Pan Liu [Sun, 3 Sep 2017 04:12:15 +0000 (12:12 +0800)]
rbd-nbd: fix generic option issue
Fixes: http://tracker.ceph.com/issues/20426
Signed-off-by: Pan Liu <wanjun.lp@alibaba-inc.com>
Xie Xingguo [Mon, 4 Sep 2017 11:53:14 +0000 (19:53 +0800)]
Merge pull request #15705 from xiexingguo/wip-fix-blob-tracker-check
os/bluestore: pass strict flag to bluestore_blob_use_tracker_t::equal()
Reviewed-by: Sage Weil <sage@redhat.com>
Reviewed-by: Igor Fedotov <ifedotov@mirantis.com>
Ashish Singh [Mon, 4 Sep 2017 11:12:09 +0000 (16:42 +0530)]
doc: Fixes rbd snapshot flatten example
Snapshot flatten example has incorrect image name, fixing the same.
Fixes: #17723
Signed-off-by: Ashish Singh <assingh@redhat.com>
Xie Xingguo [Mon, 4 Sep 2017 11:01:59 +0000 (19:01 +0800)]
Merge pull request #15363 from ShiqiCooperation/master
test/unittest_bluefs: check whether rmdir success
Reviewed-by: Sage Weil <sage@redhat.com>
Kefu Chai [Mon, 4 Sep 2017 05:51:34 +0000 (13:51 +0800)]
osd: update info only if new_interval
refactor OSD::build_initial_pg_history() so we update the info only if a
new interval is identified. also, this is consistent with
OSD::build_past_intervals_parallel().
Signed-off-by: Kefu Chai <kchai@redhat.com>
Haomai Wang [Mon, 4 Sep 2017 05:33:43 +0000 (22:33 -0700)]
Merge pull request #17435 from liupan1111/wip-fix-spdk-perf
bluestore/NVMEDevice: accurate the latency perf counter of queue latency
Reviewed-by: Haomai Wang <haomai@xsky.com>
Pan Liu [Mon, 4 Sep 2017 03:33:03 +0000 (11:33 +0800)]
bluestore/NVMEDevice: accurate the latency of queue latency.
Signed-off-by: Pan Liu <wanjun.lp@alibaba-inc.com>
Signed-off-by: Ziye Yang <optimistyzy@gmail.com>
Pan Liu [Mon, 4 Sep 2017 03:14:18 +0000 (11:14 +0800)]
bluestore/NVMEDevice: remove mm_pause according to the example givn by
spdk.
Signed-off-by: Pan Liu <wanjun.lp@alibaba-inc.com>
Signed-off-by: Ziye Yang <optimistyzy@gmail.com>
huanwen ren [Wed, 30 Aug 2017 08:47:24 +0000 (16:47 +0800)]
mgr: add the ip addr of standbys
we need to manage the ip addr of the "standbys" state,
because the hostname/gid is insufficient to locate the
Standby node. we add ip of the mgr standby to metadata.
Signed-off-by: huanwen ren <ren.huanwen@zte.com.cn>
Pan Liu [Mon, 4 Sep 2017 02:57:24 +0000 (10:57 +0800)]
bluestore/NVMEDevice: rename the perf counter *aio_write* to *write*,
because it will also statistic the latency of sync write
Signed-off-by: Pan Liu <wanjun.lp@alibaba-inc.com>
Signed-off-by: Ziye Yang <optimistyzy@gmail.com>
Pan Liu [Mon, 4 Sep 2017 02:49:11 +0000 (10:49 +0800)]
bluestore/NVMEDevice.cc: rename the thread from ceph-osd to
nvme-device-manager, to avoid name duplication with main thread
"ceph-osd"
Signed-off-by: Pan Liu <wanjun.lp@alibaba-inc.com>
Signed-off-by: Ziye Yang <optimistyzy@gmail.com>
Xie Xingguo [Mon, 4 Sep 2017 01:20:40 +0000 (09:20 +0800)]
Merge pull request #17409 from liewegas/wip-21207
os/bluestore: separate finisher for deferred_try_submit
Reviewed-by: xie xingguo <xie.xingguo@zte.com.cn>
Reviewed-by: Varada Kari <varada.kari@sandisk.com>
Xie Xingguo [Mon, 4 Sep 2017 01:18:20 +0000 (09:18 +0800)]
Merge pull request #17395 from theanalyst/cli-rados-stat2
cli: rados: support for high precision time using stat2
Reviewed-by: Kefu Chai <kchai@redhat.com>
Xie Xingguo [Mon, 4 Sep 2017 01:17:07 +0000 (09:17 +0800)]
Merge pull request #17100 from mychoxin/yuanxin_vstart_default_bluestore
vstart.sh: use bluestore as default osd objectstore backend
Reviewed-by: xie xingguo <xie.xingguo@zte.com.cn>
Yehuda Sadeh [Sun, 3 Sep 2017 05:25:42 +0000 (08:25 +0300)]
Merge pull request #16855 from amitkumar50/rgw_module
rgw: Initializes uninitialized members
Reviewed-by: Jos Collin <jcollin@redhat.com>
Reviewed-by: Casey Bodley <cbodley@redhat.com>
Yehuda Sadeh [Sun, 3 Sep 2017 05:23:59 +0000 (08:23 +0300)]
Merge pull request #17129 from C2python/clear_para
rgw: Remove unused Parameter in Function RGWConf::init()
Reviewed-by: Jos Collin <jcollin@redhat.com>
Reviewed-by: Yehuda Sadeh <yehuda@redhat.com>
Sage Weil [Sat, 2 Sep 2017 18:37:37 +0000 (13:37 -0500)]
Merge pull request #15341 from chardan/jfw-wip-rand_makes_puppies_cry
common: implement random number generator (following N3551)
Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Adam Emerson <aemerson@redhat.com>
Sage Weil [Sat, 2 Sep 2017 18:36:53 +0000 (13:36 -0500)]
Merge pull request #15565 from gmayyyha/ceph-osd-help-output
ceph-osd: some flags are not documented in the help output
Reviewed-by: Sage Weil <sage@redhat.com>
Sage Weil [Sat, 2 Sep 2017 18:36:08 +0000 (13:36 -0500)]
Merge pull request #16942 from jcsp/wip-20888
mon: rate limit on health check update logging
Reviewed-by: Sage Weil <sage@redhat.com>
Sage Weil [Sat, 2 Sep 2017 18:35:51 +0000 (13:35 -0500)]
Merge pull request #17404 from rzarzynski/wip-bs-ldout-in-stupid
os/bluestore: replace dout with ldout in StupidAllocator.
Sage Weil [Sat, 2 Sep 2017 18:35:26 +0000 (13:35 -0500)]
Merge pull request #17406 from liewegas/wip-21206
qa/tasks/ceph_manager: revive osds before doing final rerr reset
Sage Weil [Sat, 2 Sep 2017 18:35:15 +0000 (13:35 -0500)]
Merge pull request #17416 from xiexingguo/wip-handle-small-block
os/bluestore: handle small main device properly
Reviewed-by: Sage Weil <sage@redhat.com>
Sage Weil [Sat, 2 Sep 2017 18:34:41 +0000 (13:34 -0500)]
Merge pull request #17423 from liewegas/wip-21203
osd: fix build_initial_pg_history
Reviewed-by: Sage Weil <sage@redhat.com>
Danny Al-Gaaf [Tue, 30 May 2017 10:31:19 +0000 (12:31 +0200)]
test/librados/aio.cc: silence coverity with scope_guard
Fix for:
CID
1313405 (#1 of 1): Resource leak (RESOURCE_LEAK)
leaked_storage: Variable my_completion2 going out of scope
leaks the storage it points to.
CID
1219522 (#1 of 1): Resource leak (RESOURCE_LEAK)
leaked_storage: Variable my_completion going out of scope
leaks the storage it points to.
CID
1219501 (#1 of 1): Resource leak (RESOURCE_LEAK)
leaked_storage: Variable my_completion going out of scope
leaks the storage it points to.
CID
1313406 (#1 of 1): Resource leak (RESOURCE_LEAK)
leaked_storage: Variable my_completion2 going out of scope
leaks the storage it points to.
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
Danny Al-Gaaf [Tue, 30 May 2017 10:27:57 +0000 (12:27 +0200)]
c_read_operations.cc: silence coverity with scope_guard
CID
1219593 (#1 of 1): Resource leak (RESOURCE_LEAK)
leaked_storage: Variable completion going out of scope leaks
the storage it points to.
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
Danny Al-Gaaf [Tue, 30 May 2017 10:01:58 +0000 (12:01 +0200)]
LibradosTestStub.cc: memset struct sockaddr_in
Fix for:
CID
1402624 (#1 of 1): Uninitialized scalar variable (UNINIT)
uninit_use: Using uninitialized value sin. Field sin.sin_zero is
uninitialized.
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
Danny Al-Gaaf [Tue, 30 May 2017 09:29:42 +0000 (11:29 +0200)]
common/Timer.h: ~SafeTimer needs to be virtual
Fix for:
CID
1396232 (#1 of 1): Non-virtual destructor (VIRTUAL_DTOR)
nonvirtual_dtor: Class librbd::<unnamed>::SafeTimerSingleton has a
destructor and a pointer to it is upcast to class SafeTimer which
doesn't have a virtual destructor.
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
Danny Al-Gaaf [Tue, 30 May 2017 08:56:23 +0000 (10:56 +0200)]
test_ipaddr.cc: memset with 0 and not '0'
Fix for:
CID
1405070 (#1 of 1): Memset fill value of '0' (NO_EFFECT)
CID
1405071 (#1 of 1): Memset fill value of '0' (NO_EFFECT)
CID
1405073 (#1 of 1): Memset fill value of '0' (NO_EFFECT)
CID
1405074 (#1 of 1): Memset fill value of '0' (NO_EFFECT)
CID
1405075 (#1 of 1): Memset fill value of '0' (NO_EFFECT)
CID
1405077 (#1 of 1): Memset fill value of '0' (NO_EFFECT)
CID
1405083 (#1 of 1): Memset fill value of '0' (NO_EFFECT)
CID
1405086 (#1 of 1): Memset fill value of '0' (NO_EFFECT)
CID
1405087 (#1 of 1): Memset fill value of '0' (NO_EFFECT)
bad_memset: "memset" with fill value "'0'" (the zero character).
memset(&net, 48, 28UL). (CWE-665)
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
Danny Al-Gaaf [Thu, 11 May 2017 14:37:26 +0000 (16:37 +0200)]
client/MetaRequest.h: fix UNINIT_CTOR
Fix for:
CID 717207 (#1 of 1): Uninitialized pointer field (UNINIT_CTOR)
uninit_member: Non-static class member dirp is not initialized
in this constructor nor in any functions that it calls.
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
Danny Al-Gaaf [Thu, 11 May 2017 14:34:48 +0000 (16:34 +0200)]
client/Client.cc: fix UNINIT_CTOR
Fix for:
CID
1406088 (#1 of 1): Uninitialized pointer field (UNINIT_CTOR)
uninit_member: Non-static class member root_ancestor is not
initialized in this constructor nor in any functions that it calls.
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
Danny Al-Gaaf [Thu, 11 May 2017 13:29:56 +0000 (15:29 +0200)]
crush/CrushCompiler.cc: fix error handling
calloc() does not take negative values, check return value from
get_max_buckets() and handle it correctly.
Fix for:
CID
1405301 (#1 of 1): Argument cannot be negative (NEGATIVE_RETURNS)
negative_returns: arg_map.size is passed to a parameter that cannot
be negative.
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
Danny Al-Gaaf [Wed, 10 May 2017 18:42:36 +0000 (20:42 +0200)]
client/Client.cc: fix USE_AFTER_FREE
Don't call put_request() twice, it's already called by
unregister_request()
Fix for:
CID
1405360 (#1 of 1): Use after free (USE_AFTER_FREE)
deref_arg: Calling put_request dereferences freed pointer request
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
Danny Al-Gaaf [Wed, 10 May 2017 14:52:54 +0000 (16:52 +0200)]
tools/rbd/Utils.cc: yank features_set_specified and related logic
since it isn't used
Fix for:
CID
1394854 (#1 of 1): 'Constant' variable guards dead code (DEADCODE)
dead_error_line: Execution cannot reach this statement:
opts->set(RBD_IMAGE_OPTION_....
Local variable features_set_specified is assigned only once, to a
constant value, making it effectively constant throughout its scope.
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
Sage Weil [Sat, 2 Sep 2017 02:07:33 +0000 (21:07 -0500)]
Merge pull request #17304 from kungf/calc_replicated_acting
osd/PG: remove unused parameter in calc_ec_acting
Reviewed-by: Kefu Chai <kchai@redhat.com>
Sage Weil [Sat, 2 Sep 2017 02:06:36 +0000 (21:06 -0500)]
Merge pull request #17088 from zmedico/interval_set_intersection_of_optimization
interval_set: optimize intersection_of
Reviewed-by: Kefu Chai <kchai@redhat.com>
Sage Weil [Fri, 1 Sep 2017 21:28:03 +0000 (16:28 -0500)]
Merge pull request #15816 from chardan/jfw-wip-consolidate-spinlocks
common: consolidate spinlocks
Reviewed-by: Adam Emerson <aemerson@redhat.com>
Sage Weil [Fri, 1 Sep 2017 21:27:42 +0000 (16:27 -0500)]
Merge pull request #17265 from zmedico/interval-set-intersection-insert-optimization
interval_set: optimize intersect_of insert operations
Reviewed-by: Adam Emerson <aemerson@redhat.com>
Sage Weil [Fri, 1 Sep 2017 21:26:50 +0000 (16:26 -0500)]
Merge pull request #17391 from myoungwon/wip-proxywrite-cleanup
osd: remove unused variable in do_proxy_write
Reviewed-by: xie xingguo <xie.xingguo@zte.com.cn>
Sage Weil [Fri, 1 Sep 2017 21:26:24 +0000 (16:26 -0500)]
Merge pull request #17394 from Songweibin/wip-common-cleanup
common: drop unused variables "bluestore_csum_*_block" in opts
Reviewed-by: xie xingguo <xie.xingguo@zte.com.cn>
Sage Weil [Fri, 1 Sep 2017 21:25:53 +0000 (16:25 -0500)]
Merge pull request #17398 from xiexingguo/wip-21175
os/bluestore: don't re-initialize csum-setting for existing blobs
Reviewed-by: Sage Weil <sage@redhat.com>
Josh Durgin [Fri, 1 Sep 2017 21:19:48 +0000 (14:19 -0700)]
Merge pull request #17160 from ceph/wip-luminous-x-master
qa: add upgrade/luminous-x suite
Reviewed-by: Sage Weil <sage@redhat.com>
Reviewed-by: Josh Durgin <jdurgin@redhat.com>