]> git.apps.os.sepia.ceph.com Git - ceph.git/log
ceph.git
16 months agoqa: verify labelled replication perf metrics 55640/head
Venky Shankar [Wed, 14 Feb 2024 18:18:23 +0000 (13:18 -0500)]
qa: verify labelled replication perf metrics

Signed-off-by: Venky Shankar <vshankar@redhat.com>
(cherry picked from commit f29dd57cd0a1f609f54d62f97025ec2d67979472)

 Conflicts:
qa/tasks/cephfs/test_mirroring.py

test_mirroring.py does not use run_ceph_cmd() in reef, so, adjust
for that.

16 months agoqa: test per-client labelled perf counters
Venky Shankar [Tue, 13 Feb 2024 16:13:28 +0000 (11:13 -0500)]
qa: test per-client labelled perf counters

Signed-off-by: Venky Shankar <vshankar@redhat.com>
(cherry picked from commit 36e24585d562d0023398196e715522cc8cf74fb3)

Conflicts:
    qa/tasks/cephfs/test_admin.py

Use time.sleep() instead of sleep() (via import).

16 months agomds: export per-client metrics as labelled perf counters
Venky Shankar [Mon, 12 Feb 2024 07:21:08 +0000 (02:21 -0500)]
mds: export per-client metrics as labelled perf counters

Signed-off-by: Venky Shankar <vshankar@redhat.com>
(cherry picked from commit 164c547edcff86ed7dbb0d398b6db54f71e3f9b8)

16 months agocephfs_mirror: add labeled replication performance metrics
Venky Shankar [Wed, 14 Feb 2024 12:28:58 +0000 (07:28 -0500)]
cephfs_mirror: add labeled replication performance metrics

Fixes: http://tracker.ceph.com/issues/63945
Signed-off-by: Jos Collin <jcollin@redhat.com>
Signed-off-by: Venky Shankar <vshankar@redhat.com>
(cherry picked from commit 658ee6c40116e07f45085ad0df7ef33d3c8ed78e)

16 months agocephfs-mirror: typo ending bracket
Venky Shankar [Wed, 14 Feb 2024 12:27:39 +0000 (07:27 -0500)]
cephfs-mirror: typo ending bracket

Signed-off-by: Venky Shankar <vshankar@redhat.com>
(cherry picked from commit 4c14f143b59c96ecb2c23e5142829d47e2c03e22)

16 months agoMerge pull request #55635 from zdover23/wip-doc-2024-02-19-backport-55633-to-reef
Anthony D'Atri [Mon, 19 Feb 2024 12:57:16 +0000 (07:57 -0500)]
Merge pull request #55635 from zdover23/wip-doc-2024-02-19-backport-55633-to-reef

reef: doc/man: edit "manipulating the omap key"

16 months agoMerge PR #52751 into wip-61794-reef
Milind Changire [Mon, 19 Feb 2024 12:06:34 +0000 (17:36 +0530)]
Merge PR #52751 into wip-61794-reef

* refs/pull/52751/head:
PendingReleaseNotes: support for subvolumes and subvolume groups in snap_schedule
snap_schedule/tests: fix db upgrade issue
qa: add yaml for on demand subvol version testing
qa: add test cases for testing --subvol and --group arguments
mgr/volumes: conditionalize subvolume upgrade
mgr/volumes: ensure correct init of v1 subvol
mgr/snap_schedule: add subvol and subvol group arguments to cli
mds/snap_schedule: add subvolume group column management
mgr/volumes: add remote helper methods to fetch subvolume info
mgr/snap_schedule: catch all exceptions for cli

Reviewed-by: Venky Shankar <vshankar@redhat.com>
16 months agodoc/man: edit "manipulating the omap key" 55635/head
Zac Dover [Sun, 18 Feb 2024 06:01:46 +0000 (16:01 +1000)]
doc/man: edit "manipulating the omap key"

Edit the section "Manipulating the Object Map Key" in
doc/man/8/ceph-objectstore-tool.rst.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 44ec668d43951c2710271fb3ca1799c4c4ded940)

17 months agoMerge pull request #55630 from zdover23/wip-doc-2024-02-18-backport-55626-to-reef
Anthony D'Atri [Sun, 18 Feb 2024 04:59:23 +0000 (23:59 -0500)]
Merge pull request #55630 from zdover23/wip-doc-2024-02-18-backport-55626-to-reef

reef: doc/rados: add PG definition

17 months agodoc/rados: add PG definition 55630/head
Zac Dover [Sat, 17 Feb 2024 05:28:24 +0000 (15:28 +1000)]
doc/rados: add PG definition

Add a definition of Placement Groups to
doc/rados/operations/placement-groups.rst.

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 39c809b33fe27064277292b721639cbb144fac6a)

17 months agoMerge PR #55590 into reef
Patrick Donnelly [Fri, 16 Feb 2024 15:22:03 +0000 (10:22 -0500)]
Merge PR #55590 into reef

* refs/pull/55590/head:
qa: do upgrades from quincy and older reef minor releases

Reviewed-by: Venky Shankar <vshankar@redhat.com>
17 months agoMerge pull request #55613 from zdover23/wip-doc-2024-02-16-backport-55539-to-reef
Anthony D'Atri [Fri, 16 Feb 2024 14:58:36 +0000 (09:58 -0500)]
Merge pull request #55613 from zdover23/wip-doc-2024-02-16-backport-55539-to-reef

reef: doc/glossary: improve OSD definitions

17 months agoMerge pull request #55611 from zdover23/wip-doc-2024-02-16-backport-55585-to-reef
Anthony D'Atri [Fri, 16 Feb 2024 14:58:01 +0000 (09:58 -0500)]
Merge pull request #55611 from zdover23/wip-doc-2024-02-16-backport-55585-to-reef

reef: doc/rados: add link to pg blog post

17 months agodoc/glossary: improve OSD definitions 55613/head
Zac Dover [Mon, 12 Feb 2024 13:08:27 +0000 (23:08 +1000)]
doc/glossary: improve OSD definitions

Remove expletive construction from three OSD-id-related terms.

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit dec3d3730712bbc0994f5cbd1989761d64f93019)

17 months agodoc/rados: add link to pg blog post 55611/head
Zac Dover [Wed, 14 Feb 2024 15:32:40 +0000 (01:32 +1000)]
doc/rados: add link to pg blog post

Add a link in the "Placement Groups" section that links to Sage Weil's
April 5, 2019 blog post "New in Nautilus: PG merging and autotuning".

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 9344893e0857be8c6ae134f6d4d5e9057e2cb99e)

17 months agoMerge PR #54952 into reef
Patrick Donnelly [Thu, 15 Feb 2024 20:22:42 +0000 (15:22 -0500)]
Merge PR #54952 into reef

* refs/pull/54952/head:
qa: configure balancer for multi-mds workloads
qa: create qa subvolumes in named subvolumegroup
qa: do not rely on default max_mds value
qa: add automate_balance to dashboard qa schema
doc/cephfs: add docs for balance_automate
doc/cephfs: use bash prompt for shell code
mds: add balance_automate fs setting

Reviewed-by: Milind Changire <mchangir@redhat.com>
17 months agoMerge pull request #55603 from zdover23/wip-doc-2024-02-16-backport-55566-to-reef
Anthony D'Atri [Thu, 15 Feb 2024 19:54:12 +0000 (14:54 -0500)]
Merge pull request #55603 from zdover23/wip-doc-2024-02-16-backport-55566-to-reef

reef: doc/cephadm: correct nfs config pool name

17 months agoMerge pull request #55557 from zdover23/wip-doc-2024-02-13-backport-55546-to-reef
zdover23 [Thu, 15 Feb 2024 17:55:23 +0000 (03:55 +1000)]
Merge pull request #55557 from zdover23/wip-doc-2024-02-13-backport-55546-to-reef

reef: doc/glossary: Add link to CRUSH paper

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
17 months agodoc/cephadm: correct nfs config pool name 55603/head
Zac Dover [Tue, 13 Feb 2024 17:04:26 +0000 (03:04 +1000)]
doc/cephadm: correct nfs config pool name

s/nfs-ganesha/.nfs/ in doc/cephadm/services/nfs, in accordance with
information given to me by John Mulligan over Slack.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 574421aeec3bdd502c64e87102846e5181b18415)

17 months agoMerge pull request #55026 from idryomov/wip-63607-reef
Yuri Weinstein [Thu, 15 Feb 2024 17:02:29 +0000 (09:02 -0800)]
Merge pull request #55026 from idryomov/wip-63607-reef

reef: librados: make querying pools for selfmanaged snaps reliable

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
17 months agoMerge pull request #54595 from idryomov/wip-53593-reef
Yuri Weinstein [Thu, 15 Feb 2024 17:01:33 +0000 (09:01 -0800)]
Merge pull request #54595 from idryomov/wip-53593-reef

reef: osd: don't require RWEXCL lock for stat+write ops.

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
17 months agoMerge pull request #54373 from batrick/wip-63456-reef
Yuri Weinstein [Thu, 15 Feb 2024 17:00:50 +0000 (09:00 -0800)]
Merge pull request #54373 from batrick/wip-63456-reef

reef: common: resolve config proxy deadlock using refcounted pointers

Reviewed-by: Aishwarya Mathuria <amathuri@redhat.com>
17 months agoMerge pull request #55538 from guits/reef-node-proxy-handle-fetch-oob-error
Guillaume Abrioux [Thu, 15 Feb 2024 14:35:38 +0000 (15:35 +0100)]
Merge pull request #55538 from guits/reef-node-proxy-handle-fetch-oob-error

(reef) node-proxy: improve http error handling in fetch_oob_details

17 months agoqa: do upgrades from quincy and older reef minor releases 55590/head
Patrick Donnelly [Thu, 15 Feb 2024 02:49:17 +0000 (21:49 -0500)]
qa: do upgrades from quincy and older reef minor releases

Fixes: https://tracker.ceph.com/issues/64441
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
17 months agotools/rados: just return instead of exit(1) in "rados cppool" handler 55026/head
Ilya Dryomov [Fri, 24 Nov 2023 18:53:48 +0000 (19:53 +0100)]
tools/rados: just return instead of exit(1) in "rados cppool" handler

Otherwise an occasional segfault occurs.  This instance was missed in
commit 2c149262888c ("tools/rados: always call rados.shutdown() before
exit()").

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit de6635582b7615eb54800a616711073a3c7b0dbd)

17 months agoqa: make sure "rados cppool" requires --yes-i-really-mean-it for RBD
Ilya Dryomov [Thu, 23 Nov 2023 19:24:24 +0000 (20:24 +0100)]
qa: make sure "rados cppool" requires --yes-i-really-mean-it for RBD

Safeguards in rados CLI tool isn't really the subject of this test, but
it fits nicely.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit 2b135a2eb60e0dd5ab22d213d3d2435608c6a9d3)

17 months agolibrados: make querying pools for selfmanaged snaps reliable
Ilya Dryomov [Wed, 22 Nov 2023 13:39:13 +0000 (14:39 +0100)]
librados: make querying pools for selfmanaged snaps reliable

If get_pool_is_selfmanaged_snaps_mode() is invoked on a fresh RADOS
client instance that still lacks an osdmap, it returns false, same as
for "this pool is not in selfmanaged snaps mode".  The same happens if
the pool in question doesn't exist since the signature doesn't allow to
return an error.

The motivation for this API was to prevent users from running "rados
cppool" on a pool with unmanaged snapshots and deleting the original
thinking that they have a full copy.  Unfortunately, it's exactly
"rados cppool" that fell into this trap, so no warning is printed and
--yes-i-really-mean-it flag isn't enforced.

Fixes: https://tracker.ceph.com/issues/63607
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit 0999e63bfbbee46b8e19c3f05881eee64dba8b5e)

Conflicts:
PendingReleaseNotes [ moved to >=18.2.2 section ]

17 months agolibrados: clarify get_pool_is_selfmanaged_snaps_mode() semantics
Ilya Dryomov [Thu, 23 Nov 2023 19:35:41 +0000 (20:35 +0100)]
librados: clarify get_pool_is_selfmanaged_snaps_mode() semantics

Refer to the commit message of 8a9769a1d5fd ("librados: add
get_pool_is_selfmanaged_snaps_mode() function").

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit 54edc7955b0593423d2c03ca308b5e5fcdc528a3)

17 months agoMerge pull request #55474 from idryomov/wip-47287-reef
Yuri Weinstein [Wed, 14 Feb 2024 16:19:08 +0000 (08:19 -0800)]
Merge pull request #55474 from idryomov/wip-47287-reef

reef: librbd: return ENOENT from Snapshot::get_timestamp for nonexistent snap_id

Reviewed-by: Ramana Raja <rraja@redhat.com>
17 months agoMerge pull request #55427 from idryomov/wip-63341-reef
Yuri Weinstein [Wed, 14 Feb 2024 16:18:25 +0000 (08:18 -0800)]
Merge pull request #55427 from idryomov/wip-63341-reef

reef: librbd: improve rbd_diff_iterate2() performance in fast-diff mode

Reviewed-by: Mykola Golub <mgolub@suse.com>
17 months agoMerge pull request #55424 from petrutlucian94/wip-64294-reef
Yuri Weinstein [Wed, 14 Feb 2024 16:17:25 +0000 (08:17 -0800)]
Merge pull request #55424 from petrutlucian94/wip-64294-reef

reef: msg: update MOSDOp() to use ceph_tid_t instead of long

Reviewed-by: Ilya Dryomov <idryomov@redhat.com>
17 months agoMerge pull request #55571 from aaSharma14/wip-64048-reef
Nizamudeen A [Wed, 14 Feb 2024 09:47:04 +0000 (15:17 +0530)]
Merge pull request #55571 from aaSharma14/wip-64048-reef

reef: mgr/dashboard: increase the number of plottable graphs in charts

Reviewed-by: afreen23 <NOT@FOUND>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
17 months agomgr/cephadm: add fullreport in ceph orch CLI (node-proxy) 55538/head
Guillaume Abrioux [Wed, 14 Feb 2024 09:02:50 +0000 (09:02 +0000)]
mgr/cephadm: add fullreport in ceph orch CLI (node-proxy)

This adds the `fullreport` category to the `ceph orch hardware status` CLI.

Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
(cherry picked from commit 056d4f7a3d4ca8564b374880551a574858e68395)

17 months agomgr/cephadm: conditionally deploy node-proxy
Guillaume Abrioux [Mon, 12 Feb 2024 16:20:42 +0000 (16:20 +0000)]
mgr/cephadm: conditionally deploy node-proxy

Only attempt to deploy the node-proxy agent when oob details
are provided for a given host.

Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
(cherry picked from commit 3ae32c44a7d1ea15bd3459a266b2dbf3c9f9a408)

17 months agonode-proxy: call time.sleep() after each reporter iteration
Guillaume Abrioux [Mon, 12 Feb 2024 14:25:24 +0000 (14:25 +0000)]
node-proxy: call time.sleep() after each reporter iteration

This makes sure time.sleep() is always call in the reporter loop.

Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
(cherry picked from commit 6fc3d861c5785aad76aa6bde6944e2bb317df4f3)

17 months agonode-proxy: improve http error handling in fetch_oob_details
Guillaume Abrioux [Mon, 12 Feb 2024 12:22:41 +0000 (12:22 +0000)]
node-proxy: improve http error handling in fetch_oob_details

This makes the daemon handle the error nicer in fetch_oob_details()

Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
(cherry picked from commit 7bfe445e690d13eec8552f2ba88c9ff25ed3cf92)

17 months agoPendingReleaseNotes: support for subvolumes and subvolume groups in snap_schedule 52751/head
Milind Changire [Thu, 14 Dec 2023 07:25:08 +0000 (12:55 +0530)]
PendingReleaseNotes: support for subvolumes and subvolume groups in snap_schedule

Signed-off-by: Milind Changire <mchangir@redhat.com>
(cherry picked from commit b3ff5f794985c173ba87926f34e6d9793c5d5c67)
Signed-off-by: Milind Changire <mchangir@redhat.com>
17 months agosnap_schedule/tests: fix db upgrade issue
Milind Changire [Tue, 17 Oct 2023 04:36:48 +0000 (10:06 +0530)]
snap_schedule/tests: fix db upgrade issue

Signed-off-by: Milind Changire <mchangir@redhat.com>
(cherry picked from commit dfc35a4679495a3d7136927374e838409c29ab4a)
Signed-off-by: Milind Changire <mchangir@redhat.com>
17 months agoqa: add yaml for on demand subvol version testing
Milind Changire [Thu, 14 Dec 2023 11:01:05 +0000 (16:31 +0530)]
qa: add yaml for on demand subvol version testing

Signed-off-by: Milind Changire <mchangir@redhat.com>
(cherry picked from commit 2533ac5b90f367dd55f61c1e95dee0e154940930)
Signed-off-by: Milind Changire <mchangir@redhat.com>
17 months agoqa: add test cases for testing --subvol and --group arguments
Milind Changire [Mon, 20 Nov 2023 10:39:57 +0000 (16:09 +0530)]
qa: add test cases for testing --subvol and --group arguments

Signed-off-by: Milind Changire <mchangir@redhat.com>
(cherry picked from commit 006c68f492044327594fbf7204774d7d7d4ee518)
Signed-off-by: Milind Changire <mchangir@redhat.com>
17 months agomgr/volumes: conditionalize subvolume upgrade
Milind Changire [Thu, 7 Dec 2023 08:31:42 +0000 (14:01 +0530)]
mgr/volumes: conditionalize subvolume upgrade

Signed-off-by: Milind Changire <mchangir@redhat.com>
(cherry picked from commit 0c5804ab4e5eb284d127044c5e51fbc870f5727a)
Signed-off-by: Milind Changire <mchangir@redhat.com>
17 months agomgr/volumes: ensure correct init of v1 subvol
Milind Changire [Wed, 22 Nov 2023 09:50:17 +0000 (15:20 +0530)]
mgr/volumes: ensure correct init of v1 subvol

Signed-off-by: Milind Changire <mchangir@redhat.com>
(cherry picked from commit 614d112cff522439c08e554a14472f1f391dd125)
Signed-off-by: Milind Changire <mchangir@redhat.com>
17 months agomgr/snap_schedule: add subvol and subvol group arguments to cli
Milind Changire [Thu, 9 Nov 2023 07:55:02 +0000 (13:25 +0530)]
mgr/snap_schedule: add subvol and subvol group arguments to cli

Signed-off-by: Milind Changire <mchangir@redhat.com>
(cherry picked from commit 5b250907d03196bf99fe4a56ea00245a4c830264)
Signed-off-by: Milind Changire <mchangir@redhat.com>
17 months agomds/snap_schedule: add subvolume group column management
Milind Changire [Thu, 9 Nov 2023 07:08:48 +0000 (12:38 +0530)]
mds/snap_schedule: add subvolume group column management

Signed-off-by: Milind Changire <mchangir@redhat.com>
(cherry picked from commit ffa197c03159e2acb7c3892f09a1ed616b9c1cd8)
Signed-off-by: Milind Changire <mchangir@redhat.com>
17 months agomgr/volumes: add remote helper methods to fetch subvolume info
Milind Changire [Thu, 7 Dec 2023 08:33:39 +0000 (14:03 +0530)]
mgr/volumes: add remote helper methods to fetch subvolume info

  * add remote method to fetch subvolume path
  * add remote method to list subvolumes
  * add remote method to fetch subvolume attributes

Signed-off-by: Milind Changire <mchangir@redhat.com>
(cherry picked from commit d2205bf8247edec08a456377c1e8988428e9ba29)
Signed-off-by: Milind Changire <mchangir@redhat.com>
17 months agomgr/snap_schedule: catch all exceptions for cli
Milind Changire [Wed, 26 Apr 2023 07:04:10 +0000 (12:34 +0530)]
mgr/snap_schedule: catch all exceptions for cli

Any unknown exception causes the module to be unloaded and unresponsive.
So, it'll be ideal to catch all exceptions during command-line interaction
and report them instead of crashing with a traceback.

Fixes: https://tracker.ceph.com/issues/58195
Signed-off-by: Milind Changire <mchangir@redhat.com>
(cherry picked from commit 651fb2e3b515c80e9dc4a24638c9d1a0d487c729)

Conflicts:
src/pybind/mgr/snap_schedule/module.py
- minor conflicts due to changed variable names

17 months agomgr/dashboard: Fix issue with Object's Overview page 55571/head
Afreen [Wed, 24 Jan 2024 15:09:54 +0000 (20:39 +0530)]
mgr/dashboard: Fix issue with Object's Overview page

Fixes https://tracker.ceph.com/issues/64150

Issue: Due to absence of null checks, the overview page was failing to
load.

Fix: Added, null check at relevant places to ensure data availability
before accessing the data.

Signed-off-by: Afreen <afreen23.git@gmail.com>
17 months agomgr/dashboard: increase the number of plottable graphs in charts
Aashish Sharma [Tue, 5 Dec 2023 05:58:25 +0000 (11:28 +0530)]
mgr/dashboard: increase the number of plottable graphs in charts

Fixes: https://tracker.ceph.com/issues/64024
Signed-off-by: Aashish Sharma <aasharma@redhat.com>
17 months agoMerge pull request #55544 from rhcs-dashboard/wip-61657-reef
Nizamudeen A [Tue, 13 Feb 2024 16:55:36 +0000 (22:25 +0530)]
Merge pull request #55544 from rhcs-dashboard/wip-61657-reef

reef: mgr/dashboard: change deprecated grafana URL in daemon logs

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: ivoalmeida <NOT@FOUND>
17 months agoMerge pull request #55515 from afreen23/wip-64367-reef
Nizamudeen A [Tue, 13 Feb 2024 11:05:10 +0000 (16:35 +0530)]
Merge pull request #55515 from afreen23/wip-64367-reef

reef: mgr/dashboard: fix error while accessing roles tab when policy attached

Reviewed-by: Nizamudeen A <nia@redhat.com>
17 months agoMerge pull request #55542 from rhcs-dashboard/wip-61714-reef
Nizamudeen A [Tue, 13 Feb 2024 05:24:21 +0000 (10:54 +0530)]
Merge pull request #55542 from rhcs-dashboard/wip-61714-reef

reef: mgr/dashboard: fix the jsonschema issue in install-deps

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: ivoalmeida <NOT@FOUND>
17 months agodoc/glossary: Add link to CRUSH paper 55557/head
Zac Dover [Mon, 12 Feb 2024 15:06:05 +0000 (01:06 +1000)]
doc/glossary: Add link to CRUSH paper

Add a link in the CRUSH definition to the original CRUSH paper.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit aa1e6352d0c2c77c299a16f93e16e83903fb9d54)

17 months agoMerge pull request #55497 from guits/wip-64357-reef
Guillaume Abrioux [Mon, 12 Feb 2024 15:15:42 +0000 (16:15 +0100)]
Merge pull request #55497 from guits/wip-64357-reef

reef: ceph-volume: Fix migration from WAL to data with no DB

17 months agomgr/dashboard: change deprecated grafana URL in daemon logs 55544/head
Nizamudeen A [Thu, 8 Jun 2023 06:43:54 +0000 (12:13 +0530)]
mgr/dashboard: change deprecated grafana URL in daemon logs

See https://github.com/grafana/grafana/issues/51276

I am also increasting the height of the panel

Fixes: https://tracker.ceph.com/issues/61618
Signed-off-by: Nizamudeen A <nia@redhat.com>
(cherry picked from commit f428b1468844345915b4cf607a104732b1b967f3)

17 months agomgr/dashboard: fix the jsonschema issue in install-deps 55542/head
Nizamudeen A [Fri, 16 Jun 2023 09:08:52 +0000 (14:38 +0530)]
mgr/dashboard: fix the jsonschema issue in install-deps

Fixes: https://tracker.ceph.com/issues/61690
Signed-off-by: Nizamudeen A <nia@redhat.com>
(cherry picked from commit a6a123d3b498c6fa8a09339ed5e7d5b95581419b)

 Conflicts:
src/pybind/mgr/dashboard/requirements-test.txt
  - accept the incoming changes

17 months agoMerge pull request #55517 from rhcs-dashboard/wip-64370-reef
Pedro Gonzalez Gomez [Mon, 12 Feb 2024 12:36:18 +0000 (13:36 +0100)]
Merge pull request #55517 from rhcs-dashboard/wip-64370-reef

reef: mgr/dashboard: dashboard area chart unit test

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
17 months agoMerge pull request #55511 from zdover23/wip-doc-2024-02-09-backport-55465-to-reef
zdover23 [Fri, 9 Feb 2024 15:39:25 +0000 (01:39 +1000)]
Merge pull request #55511 from zdover23/wip-doc-2024-02-09-backport-55465-to-reef

reef: doc: add description of metric fields for cephfs-top

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
17 months agoMerge pull request #55505 from zdover23/wip-doc-2024-02-09-backport-55490-to-reef
zdover23 [Fri, 9 Feb 2024 15:38:34 +0000 (01:38 +1000)]
Merge pull request #55505 from zdover23/wip-doc-2024-02-09-backport-55490-to-reef

reef: doc:start.rst fix typo in hw-recs

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
17 months agomgr/dashboard: dashboard area chart unit test 55517/head
Pedro Gonzalez Gomez [Thu, 19 Oct 2023 09:29:36 +0000 (11:29 +0200)]
mgr/dashboard: dashboard area chart unit test

Fixes: https://tracker.ceph.com/issues/63243
Signed-off-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
(cherry picked from commit 445724fa61a27071bce02afa084bfc1437acd271)

17 months agomgr/dashboard: fix error while accessing roles tab when policy attached 55515/head
Afreen [Tue, 6 Feb 2024 09:43:58 +0000 (15:13 +0530)]
mgr/dashboard: fix error while accessing roles tab when policy attached

Fixes https://tracker.ceph.com/issues/64270

Issue:
======
Accessing Object->Users-Roles tab causing 500 internal servor error.
This is due to the "PermissionPolicies" which are attached to role and
backend was not handling this field for rgw roles.

Fix:
====
Added "PermissionPolicies" as the valid field in backend and updated
frontend to render the attached policy in formatted JSON

Signed-off-by: Afreen <afreen23.git@gmail.com>
(cherry picked from commit 5247d7d19455a5ab7d1bb56b9586c6b08843b15d)

 Conflicts:
src/pybind/mgr/dashboard/frontend/src/app/shared/models/crud-table-metadata.ts

17 months agoMerge pull request #55224 from rhcs-dashboard/wip-64077-reef
Pedro Gonzalez Gomez [Fri, 9 Feb 2024 12:36:07 +0000 (13:36 +0100)]
Merge pull request #55224 from rhcs-dashboard/wip-64077-reef

reef: mgr/dashboard: chartjs and ng2-charts version upgrade

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
17 months agoMerge pull request #55477 from guits/wip-64337-reef
Guillaume Abrioux [Fri, 9 Feb 2024 08:03:54 +0000 (09:03 +0100)]
Merge pull request #55477 from guits/wip-64337-reef

reef: ceph-volume: fix zap_partitions() in devices.lvm.zap

17 months agoMerge pull request #55489 from rhcs-dashboard/wip-64245-reef
Nizamudeen A [Fri, 9 Feb 2024 07:06:24 +0000 (12:36 +0530)]
Merge pull request #55489 from rhcs-dashboard/wip-64245-reef

reef: mgr/dashboard: create cephfs snapshot clone

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
17 months agodoc: add description of metric fields for cephfs-top 55511/head
neeraj pratap singh [Tue, 6 Feb 2024 12:12:50 +0000 (17:42 +0530)]
doc: add description of metric fields for cephfs-top

Fixes: https://tracker.ceph.com/issues/63991
Signed-off-by: Neeraj Pratap Singh <neesingh@redhat.com>
(cherry picked from commit 956f644f86c0790c17976b98df112747d66837df)

17 months agodoc:start.rst fix typo in hw-recs 55505/head
Eduardo Roldan [Thu, 8 Feb 2024 06:40:21 +0000 (03:40 -0300)]
doc:start.rst fix typo in hw-recs

s/power less/power loss/

Signed-off-by: Eduardo Roldan <trazor@gmail.com>
(cherry picked from commit b80c12d080275e3c221a1e305c345fbc1caa3c8e)

17 months agoMerge pull request #55369 from afreen23/wip-64239-reef
Nizamudeen A [Thu, 8 Feb 2024 15:02:05 +0000 (20:32 +0530)]
Merge pull request #55369 from afreen23/wip-64239-reef

reef: mgr/dashboard: Create subvol of same name in different group

Reviewed-by: Nizamudeen A <nia@redhat.com>
17 months agoceph-volume: Fix migration from WAL to data with no DB 55497/head
Igor Fedotov [Wed, 31 Jan 2024 12:45:26 +0000 (15:45 +0300)]
ceph-volume: Fix migration from WAL to data with no DB

Fixes: https://tracker.ceph.com/issues/64260
Signed-off-by: Igor Fedotov <igor.fedotov@croit.io>
(cherry picked from commit 88466b3e7daad51a93ef1ccdbced1f33337c4eec)

17 months agoMerge pull request #55491 from rkachach/fix_issue_64339
Redouane Kachach [Thu, 8 Feb 2024 12:56:22 +0000 (13:56 +0100)]
Merge pull request #55491 from rkachach/fix_issue_64339

backport mgr/prometheus: fix orch check to prevent Prometheus crash

17 months agobackport mgr/prometheus: fix orch check to prevent Prometheus crash 55491/head
Redouane Kachach [Thu, 8 Feb 2024 07:25:37 +0000 (08:25 +0100)]
backport mgr/prometheus: fix orch check to prevent Prometheus crash
https://tracker.ceph.com/issues/64339

Signed-off-by: Redouane Kachach <rkachach@redhat.com>
17 months agomgr/dashboard: create cephfs snapshot clone 55489/head
Nizamudeen A [Tue, 23 Jan 2024 16:47:46 +0000 (22:17 +0530)]
mgr/dashboard: create cephfs snapshot clone

Fixes: https://tracker.ceph.com/issues/64175
Signed-off-by: Nizamudeen A <nia@redhat.com>
(cherry picked from commit 129f1db734777f3df551965c35f40ee0ab7d467a)

 Conflicts:
src/pybind/mgr/dashboard/controllers/cephfs.py
  - Left the snapshot scheduler controller out

17 months agoMerge pull request #55484 from zdover23/wip-doc-2024-02-08-backport-55475-to-reef
Anthony D'Atri [Wed, 7 Feb 2024 20:15:51 +0000 (15:15 -0500)]
Merge pull request #55484 from zdover23/wip-doc-2024-02-08-backport-55475-to-reef

reef: doc/radosgw: add confval directives

17 months agodoc/radosgw: add confval directives 55484/head
Zac Dover [Wed, 7 Feb 2024 13:18:35 +0000 (23:18 +1000)]
doc/radosgw: add confval directives

Add confval directives to the documentation of "quota cache" options.
This addresses a request made by Antony D'Atri in https://github.com/ceph/ceph/pull/55075/files#r1444006246.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 6504732e1b5b34756a119bc1547d22c07bd6458a)

17 months agoMerge pull request #55482 from zdover23/wip-doc-2024-02-08-backport-55476-to-reef
Anthony D'Atri [Wed, 7 Feb 2024 19:02:35 +0000 (14:02 -0500)]
Merge pull request #55482 from zdover23/wip-doc-2024-02-08-backport-55476-to-reef

reef: doc/cephadm - edit t11ing.

17 months agoMerge pull request #55454 from guits/node-proxy-subthread-bkp-reef
Adam King [Wed, 7 Feb 2024 15:29:32 +0000 (10:29 -0500)]
Merge pull request #55454 from guits/node-proxy-subthread-bkp-reef

reef: node-proxy: refactor entrypoint (backport)

Reviewed-by: Adam King <adking@redhat.com>
17 months agoMerge pull request #55460 from zdover23/wip-doc-2024-02-06-backport-55447-to-reef
zdover23 [Wed, 7 Feb 2024 15:17:02 +0000 (01:17 +1000)]
Merge pull request #55460 from zdover23/wip-doc-2024-02-06-backport-55447-to-reef

reef: doc/rados: update PG guidance

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
17 months agodoc/cephadm - edit t11ing. 55482/head
Zac Dover [Wed, 7 Feb 2024 13:32:53 +0000 (23:32 +1000)]
doc/cephadm - edit t11ing.

Edit "Running Repeated Debugging Sessions" in
doc/cephadm/troubleshooting.rst. Improve grammar. Fix a misspelling.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit f5b8afe981650f5072294303b0e488b91fc65fe8)

17 months agoceph-volume: fix zap_partitions() in devices.lvm.zap 55477/head
Guillaume Abrioux [Tue, 30 Jan 2024 14:17:35 +0000 (14:17 +0000)]
ceph-volume: fix zap_partitions() in devices.lvm.zap

The current logic is unable to find the holders for the
partition being zapped.

This commit fixes this issue.

Fixes: https://tracker.ceph.com/issues/64248
Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
(cherry picked from commit 36c83bf5424308214228b1c86d8e1d215b8519c5)

17 months agolibrbd: return ENOENT from Snapshot::get_timestamp for nonexistent snap_id 55474/head
jagombar [Tue, 30 Jan 2024 18:25:53 +0000 (18:25 +0000)]
librbd: return ENOENT from Snapshot::get_timestamp for nonexistent snap_id

Fixes: https://tracker.ceph.com/issues/47287
Signed-off-by: John Agombar <agombar@uk.ibm.com>
(cherry picked from commit 2a2d3d4c6b38a917f465680e9321e810426555ea)

17 months agoMerge pull request #55290 from ceph/revert-54865-wip-63782-reef
Venky Shankar [Tue, 6 Feb 2024 13:25:09 +0000 (18:55 +0530)]
Merge pull request #55290 from ceph/revert-54865-wip-63782-reef

Revert "reef: qa: add support/qa for cephfs-shell on CentOS 9 / RHEL9"

Reviewed-by: Milind Changire <mchangir@redhat.com>
17 months agodoc/rados: update PG guidance 55460/head
Zac Dover [Sun, 4 Feb 2024 15:36:10 +0000 (01:36 +1000)]
doc/rados: update PG guidance

Update the "Creating a Pool" section of doc/rados/operations/pools.rst
so that the documentation no longer insists that the user change the
values of "osd_pool_default_pg_num" and "osd_pool_default_pgp_num".

See also: https://github.com/ceph/ceph/pull/55419

Tracker: https://tracker.ceph.com/issues/64259

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 5ad241442d2c141ba508faba61f39d70f3f09679)

17 months agoRevert "reef: qa: add support/qa for cephfs-shell on CentOS 9 / RHEL9" 55290/head
Venky Shankar [Wed, 24 Jan 2024 06:19:27 +0000 (11:49 +0530)]
Revert "reef: qa: add support/qa for cephfs-shell on CentOS 9 / RHEL9"

Signed-off-by: Venky Shankar <vshankar@redhat.com>
17 months agoMerge pull request #55237 from joscollin/wip-64073-reef
Yuri Weinstein [Mon, 5 Feb 2024 15:25:26 +0000 (07:25 -0800)]
Merge pull request #55237 from joscollin/wip-64073-reef

reef: pybind/mgr/mirroring: drop mon_host from peer_list

Reviewed-by: Venky Shankar <vshankar@redhat.com>
17 months agoMerge pull request #55208 from mchangir/wip-62842-reef
Yuri Weinstein [Mon, 5 Feb 2024 15:24:47 +0000 (07:24 -0800)]
Merge pull request #55208 from mchangir/wip-62842-reef

reef: mgr/snap_schedule: add support for monthly snapshots

Reviewed-by: Venky Shankar <vshankar@redhat.com>
17 months agoMerge pull request #55057 from vshankar/wip-63922-reef
Yuri Weinstein [Mon, 5 Feb 2024 15:24:08 +0000 (07:24 -0800)]
Merge pull request #55057 from vshankar/wip-63922-reef

reef: mds: change priority of mds rss perf counter to useful

Reviewed-by: Milind Changire <mchangir@redhat.com>
17 months agoMerge pull request #55002 from leonid-s-usov/bp/renameat2/reef
Yuri Weinstein [Mon, 5 Feb 2024 15:23:28 +0000 (07:23 -0800)]
Merge pull request #55002 from leonid-s-usov/bp/renameat2/reef

reef: client/fuse: handle case of renameat2 with non-zero flags

Reviewed-by: Milind Changire <mchangir@redhat.com>
17 months agoMerge pull request #54911 from lxbsz/wip-63809
Yuri Weinstein [Mon, 5 Feb 2024 15:22:45 +0000 (07:22 -0800)]
Merge pull request #54911 from lxbsz/wip-63809

reef: mds: set the loner to true for LOCK_EXCL_XSYN

Reviewed-by: Milind Changire <mchangir@redhat.com>
17 months agoMerge pull request #54899 from neesingh-rh/wip-63810-reef
Yuri Weinstein [Mon, 5 Feb 2024 15:22:06 +0000 (07:22 -0800)]
Merge pull request #54899 from neesingh-rh/wip-63810-reef

reef: mds: scrub repair does not clear earlier damage health status

Reviewed-by: Milind Changire <mchangir@redhat.com>
17 months agoMerge pull request #54895 from mchangir/wip-63416-reef
Yuri Weinstein [Mon, 5 Feb 2024 15:21:01 +0000 (07:21 -0800)]
Merge pull request #54895 from mchangir/wip-63416-reef

reef: mds: do not simplify fragset

Reviewed-by: Venky Shankar <vshankar@redhat.com>
17 months agoMerge pull request #54766 from vshankar/wip-53418-reef
Yuri Weinstein [Mon, 5 Feb 2024 15:19:42 +0000 (07:19 -0800)]
Merge pull request #54766 from vshankar/wip-53418-reef

reef: qa: use exisitng ignorelist override list for fs:mirror[-ha]

Reviewed by: Milind Changire <mchangir@redhat.com>
Reviewed-by: Jos Collin <jcollin@redhat.com>
17 months agoMerge pull request #54716 from batrick/wip-63676-reef
Yuri Weinstein [Mon, 5 Feb 2024 15:17:55 +0000 (07:17 -0800)]
Merge pull request #54716 from batrick/wip-63676-reef

reef: mds: revert standby-replay trimming changes

Reviewed-by: Milind Changire <mchangir@redhat.com>
17 months agoMerge pull request #54714 from mchangir/wip-63575-reef
Yuri Weinstein [Mon, 5 Feb 2024 15:17:15 +0000 (07:17 -0800)]
Merge pull request #54714 from mchangir/wip-63575-reef

reef: qa: use correct imports to resolve fuse_mount and kernel_mount

Reviewed-by: Venky Shankar <vshankar@redhat.com>
17 months agoMerge pull request #54493 from leonid-s-usov/bp/balance-after-stop/reef
Yuri Weinstein [Mon, 5 Feb 2024 15:16:21 +0000 (07:16 -0800)]
Merge pull request #54493 from leonid-s-usov/bp/balance-after-stop/reef

reef: mds/MDBalancer: ignore queued callbacks if MDS is not active

Reviewed-by: Milind Changire <mchangir@redhat.com>
17 months agoMerge pull request #54466 from lxbsz/wip-63273
Yuri Weinstein [Mon, 5 Feb 2024 15:15:31 +0000 (07:15 -0800)]
Merge pull request #54466 from lxbsz/wip-63273

reef: client: queue a delay cap flushing if there are ditry caps/snapcaps

Reviewed-by: Milind Changire <mchangir@redhat.com>
17 months agonode-proxy: refactor entrypoint 55454/head
Guillaume Abrioux [Sun, 4 Feb 2024 19:11:41 +0000 (19:11 +0000)]
node-proxy: refactor entrypoint

This commit introduces a major refactor of the main
entrypoint.

- subclass threading.Thread:
  - Introduce a new class `BaseThread()` that is a
    `threading.Thread()` abstraction class in order
    to monitor the different threads.
  - `BaseSystem()` inherits from `BaseThread()`.
  - Handle `SIGTERM` signal in order to gracefully shutdown
    node-proxy (make threads exit gracefully, log out from RedFish API, etc.)

Additionally, this:
  - drops the class `Logger()` from util.py which
was not adding value. It is now replaced with a simple `get_logger()`
function.
  - changes the node-proxy API port from 8080 to 9456
    (8080 being widely used for frontend apps...)
  - changes the container entrypoint in order to use the
    `ceph-node-proxy` binary from the packaging

Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
(cherry picked from commit ebf05d5d6cf0532d321a668a4444d2069f995d4a)

17 months agoMerge pull request #54404 from joscollin/wip-63474-reef
Yuri Weinstein [Mon, 5 Feb 2024 10:47:45 +0000 (02:47 -0800)]
Merge pull request #54404 from joscollin/wip-63474-reef

reef: client: call _getattr() for -ENODATA returned _getvxattr() calls

Reviewed-by: Milind Changire <mchangir@redhat.com>
17 months agoMerge pull request #53359 from k0ste/wip-62004-reef
Yuri Weinstein [Mon, 5 Feb 2024 10:45:41 +0000 (02:45 -0800)]
Merge pull request #53359 from k0ste/wip-62004-reef

reef: client: readdir_r_cb: get rstat for dir only if using rbytes for size

Reviewed-by: Milind Changire <mchangir@redhat.com>
17 months agoMerge pull request #55445 from zdover23/wip-doc-2024-02-05-backport-55434-to-reef
Anthony D'Atri [Sun, 4 Feb 2024 19:52:20 +0000 (14:52 -0500)]
Merge pull request #55445 from zdover23/wip-doc-2024-02-05-backport-55434-to-reef

reef: src/common/options: Correct typo in rgw.yaml.in

17 months agosrc/common/options: Correct typo in rgw.yaml.in 55445/head
Anthony D'Atri [Sat, 3 Feb 2024 07:18:25 +0000 (02:18 -0500)]
src/common/options: Correct typo in rgw.yaml.in

Signed-off-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
(cherry picked from commit 1796022aa4778226c2d7e04c1cb989ab9d025272)

17 months agoMerge pull request #55438 from zdover23/wip-doc-2024-02-04-backport-55419-to-reef
Anthony D'Atri [Sun, 4 Feb 2024 00:09:04 +0000 (19:09 -0500)]
Merge pull request #55438 from zdover23/wip-doc-2024-02-04-backport-55419-to-reef

reef: doc/rados: update config for autoscaler

17 months agodoc/rados: update config for autoscaler 55438/head
Zac Dover [Fri, 2 Feb 2024 01:53:45 +0000 (11:53 +1000)]
doc/rados: update config for autoscaler

Update doc/rados/configuration/pool-pg-config-ref.rst to account for the
behavior of autoscaler.

Previously, this file was last meaningfully altered in 2013, prior to
the invention of autoscaler. A recent confusion was brought to my
attention on the Ceph Slack whereby a user attempted to alter the
default values of a Quincy cluster, as suggested in this documentation.
That alteration caused Ceph to throw the error "Error ERANGE: 'pgp_num'
must be greater than 0 and lower or equal than 'pg_num', which in this
case is one" and a related "rgw_init_ioctx ERROR" reading in part
"Numerical result out of range". The user removed the
"osd_pool_default_pgp_num" configuration line from ceph.conf and the
cluster worked as expected. I presume that this is because the removal
of this configuration line allowed autoscaler to work as intended.

Fixes: https://tracker.ceph.com/issues/64259
Co-authored-by: David Orman <ormandj@corenode.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 4dc12092be584da44baca14e31ca33231164235f)