]>
git.apps.os.sepia.ceph.com Git - ceph.git/log
Rishabh Dave [Thu, 30 Mar 2023 19:34:24 +0000 (01:04 +0530)]
doc/cephfs: add doc for fs authorize since it can now also update caps
Signed-off-by: Rishabh Dave <ridave@redhat.com>
Rishabh Dave [Wed, 9 Jun 2021 08:22:13 +0000 (13:52 +0530)]
qa/cephfs: add tests for updation of caps via fs authorize
Add tests for the case where "fs authorize" subcommand upgrades the caps
for the client.
Signed-off-by: Rishabh Dave <ridave@redhat.com>
Rishabh Dave [Wed, 9 Jun 2021 08:09:12 +0000 (13:39 +0530)]
AuthMonitor: update caps when no caps are present in keyring
If "fs authorize" subcommand is executed for a client that already has
a keyring but with no caps present in it, the command should update the
keyring with the caps supplied instead of quitting with an error message.
Example -
$ ./bin/ceph auth add client.x
added key for client.x
$ ./bin/ceph auth get client.x
[client.x]
key = AQCqOrJgtsJDHBAARGzbd1sj+ycRtWHOAcWz1w==
exported keyring for client.x
Before this commit -
$ ./bin/ceph fs authorize a client.x / rw
Error EINVAL: client.x already has fs capabilities that differ from those supplied. To generate a new auth key for client.x, first remove client.x from configuration files, execute 'ceph auth rm client.x', then execute this command again.
After this commit -
$ ./bin/ceph fs authorize a client.x1 / rw
updated caps for client.x1
Signed-off-by: Rishabh Dave <ridave@redhat.com>
Rishabh Dave [Wed, 9 Jun 2021 08:08:57 +0000 (13:38 +0530)]
AuthMonitor: allow "fs authorize" to update caps
When "fs authorize" subcommand is executed for the second time with
different caps, the subcommand exits with error. Modify the behaviour so
that the caps passed every subsequent time is incorporated in to the caps
that are already present in the entity's keyring.
Behaviour before this commit -
$ ./bin/ceph fs authorize a client.x1 / rw
[client.x1]
key = AQBirqxg5KHeFxAAgOm6lHMYych6OTI+y1HJKw==
$ ./bin/ceph fs authorize b client.x1 / rw
Error EINVAL: client.x1 already has fs capabilities that differ from those supplied. To generate a new auth key for client.x1, first remove client.x1 from configuration files, execute 'ceph auth rm client.x1', then execute this command again.
$ ./bin/ceph auth get client.x1
[client.x1]
key = AQBirqxg5KHeFxAAgOm6lHMYych6OTI+y1HJKw==
caps mds = "allow rw fsname=a"
caps mon = "allow r fsname=a"
caps osd = "allow rw tag cephfs data=a"
exported keyring for client.x1
After this commit -
$ ./bin/ceph fs authorize a client.x1 / rw
[client.x1]
key = AQDvrqxgU3I3FBAAJWwF6ZtcOVeHH8TA8CwWmQ==
$ ./bin/ceph fs authorize b client.x1 / rw
updated caps for client.x1
$ ./bin/ceph auth get client.x1
[client.x1]
key = AQDvrqxgU3I3FBAAJWwF6ZtcOVeHH8TA8CwWmQ==
caps mds = "allow rw fsname=a, allow rw fsname=b"
caps mon = "allow r fsname=a, allow r fsname=b"
caps osd = "allow rw tag cephfs data=a, allow rw tag cephfs data=b"
exported keyring for client.x1
Fixes: https://tracker.ceph.com/issues/47264
Signed-off-by: Rishabh Dave <ridave@redhat.com>
MDSAuthCaps: bug fixes
Signed-off-by: Rishabh Dave <ridave@redhat.com>
Rishabh Dave [Thu, 29 Jun 2023 09:17:44 +0000 (14:47 +0530)]
AuthMonitor: rename a variable to an appropriate name
Rename varaible "wanted_caps" to "newcaps" because this variable holds
the (new) caps passed by the user that needs to be added to the entity's
keyring.
wanted caps = new caps passed by user + caps previously granted to entity
Signed-off-by: Rishabh Dave <ridave@redhat.com>
Neha Ojha [Mon, 24 Jul 2023 17:06:23 +0000 (10:06 -0700)]
Merge pull request #52601 from idryomov/wip-doc-redundant-tiering-note
doc/rados: remove redundant cache tiering deprecation note
Reviewed-by: Neha Ojha <nojha@redhat.com>
Rishabh Dave [Mon, 24 Jul 2023 16:14:27 +0000 (21:44 +0530)]
Merge pull request #51934 from kotreshhr/fix-assert-rename
mds: Fix the linkmerge assert check
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Dhairya Parmar <dparmar@redhat.com>
Reviewed-by: Rishabh Dave <ridave@redhat.com>
Yuval Lifshitz [Mon, 24 Jul 2023 16:11:44 +0000 (19:11 +0300)]
Merge pull request #52473 from vedanshbhartia/null_deref
rgw: add coverity annotations and asserts for null dereferences
Yuval Lifshitz [Mon, 24 Jul 2023 16:11:01 +0000 (19:11 +0300)]
Merge pull request #52437 from vedanshbhartia/coverity_missing_break
rgw: Add coverity annotation for missing break statement in switch
Yuval Lifshitz [Mon, 24 Jul 2023 16:10:08 +0000 (19:10 +0300)]
Merge pull request #52436 from vedanshbhartia/coverity_logical_dead
rgw: Remove logically dead code
Yuval Lifshitz [Mon, 24 Jul 2023 16:08:06 +0000 (19:08 +0300)]
Merge pull request #52434 from vedanshbhartia/coverity_1511179
rgw: Fix potential null pointer dereference in rgw_user.cc
Yuval Lifshitz [Mon, 24 Jul 2023 16:07:31 +0000 (19:07 +0300)]
Merge pull request #52433 from vedanshbhartia/coverity_1510266
rgw: When finding bucket owner info, handle account name being empty
Yuval Lifshitz [Mon, 24 Jul 2023 16:06:42 +0000 (19:06 +0300)]
Merge pull request #52432 from vedanshbhartia/coverity_1511177
rgw: Fix potential null dereference error in bucket name parsing
Yuval Lifshitz [Mon, 24 Jul 2023 16:05:04 +0000 (19:05 +0300)]
Merge pull request #52253 from vedanshbhartia/coverity_1515338
rgw: Init res id with cls_2pc_reservation::NO_ID
Yuval Lifshitz [Mon, 24 Jul 2023 16:04:08 +0000 (19:04 +0300)]
Merge pull request #51648 from vedanshbhartia/coverity_1510684
rgw: refactor D3nDataCache::d3n_io_write to avoid resource leaks
Casey Bodley [Mon, 24 Jul 2023 14:30:39 +0000 (10:30 -0400)]
Merge pull request #51772 from caisan/multisite-hang-period-update
rgw:multisite hang when update and commit period
Reviewed-by: Shilpa Jagannath <smanjara@redhat.com>
Casey Bodley [Mon, 24 Jul 2023 14:28:14 +0000 (10:28 -0400)]
Merge pull request #52056 from cbodley/wip-56993
rgw: s3 object lock avoids overflow in retention date
Reviewed-by: Matt Benjamin <mbenjamin@redhat.com>
Casey Bodley [Mon, 24 Jul 2023 14:27:57 +0000 (10:27 -0400)]
Merge pull request #52036 from adamemerson/wip-rgw-mdlog-yield
rgw: Thread optional_yield through RGWMetadataLog operations
Reviewed-by: Matt Benjamin <mbenjamin@redhat.com>
Matan Breizman [Mon, 24 Jul 2023 13:54:17 +0000 (16:54 +0300)]
Merge pull request #52529 from xxhdx1985126/wip-61943
crimson/osd/osd_operations: add pipeline to LogMissingRequest to sync it
Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Matan Breizman <mbreizma@redhat.com>
Ilya Dryomov [Mon, 24 Jul 2023 13:01:26 +0000 (15:01 +0200)]
doc/rados: remove redundant cache tiering deprecation note
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
Ali Masarwa [Mon, 24 Jul 2023 07:06:36 +0000 (10:06 +0300)]
Merge pull request #52439 from AliMasarweh/wip-alimasa-persistant-q-observability
RGW: fix issue in observability over the persistent topics queue
Xuehan Xu [Wed, 19 Jul 2023 07:52:22 +0000 (15:52 +0800)]
crimson/osd/osd_operations: add pipeline to LogMissingRequest to sync it
with ReplicateRequest
This commit is a follow-up for
e14142894922b403344d7f08315b67a291b9a27a
and
f4d336a2dbf864fe798ca7f500d44576d3f626d5
Fixes: https://tracker.ceph.com/issues/61943
Signed-off-by: Xuehan Xu <xuxuehan@qianxin.com>
Yingxin [Mon, 24 Jul 2023 01:56:37 +0000 (09:56 +0800)]
Merge pull request #52221 from xxhdx1985126/wip-collection-bug-fix
crimson/os/seastore/collection_manager: fill CollectionNode::decoded on clean reads
Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
Yingxin [Mon, 24 Jul 2023 01:55:54 +0000 (09:55 +0800)]
Merge pull request #52446 from xxhdx1985126/wip-seastore-lazy-read-patch
crimson/os/seastore/transaction_manager: data loss issues
Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
Reviewed-by: Xinyu Huang <xinyu.huang@intel.com>
Soumya Koduri [Sun, 23 Jul 2023 17:41:14 +0000 (23:11 +0530)]
Merge pull request #52445 from soumyakoduri/wip-skoduri-syncpolicy-fixes
rgw/sync-policy: Correct "sync status" & "sync group" commands
Reviewed-by: Casey Bodley <cbodley@redhat.com>
Soumya Koduri [Wed, 5 Jul 2023 12:15:39 +0000 (17:45 +0530)]
rgw: Read `sync status` from only the zones allowed to sync from
Using multisite sync policy, zones within a zonegroup can be configured
not to sync from certain zones. Filter such zones while reading sync
status.
Fixes: https://tracker.ceph.com/issues/62014
Signed-off-by: Soumya Koduri <skoduri@redhat.com>
Soumya Koduri [Fri, 14 Jul 2023 05:38:18 +0000 (11:08 +0530)]
rgw/sync-policy: Do not allow empty group names
Fixes: https://tracker.ceph.com/issues/62015
Signed-off-by: Soumya Koduri <skoduri@redhat.com>
zdover23 [Sun, 23 Jul 2023 12:11:24 +0000 (22:11 +1000)]
Merge pull request #52587 from zdover23/wip-doc-2023-07-22-rados-configuration-ceph-conf-4-of-x
doc/rados: edit ceph-conf.rst (4 of x)
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Zac Dover [Sat, 22 Jul 2023 03:57:51 +0000 (13:57 +1000)]
doc/rados: edit ceph-conf.rst (4 of x)
Edit doc/rados/configuration/ceph-conf.rst.
Signed-off-by: Zac Dover <zac.dover@proton.me>
Igor Fedotov [Sat, 22 Jul 2023 14:38:13 +0000 (17:38 +0300)]
Merge pull request #51820 from ifed01/wip-ifed-fragmentation-info
os/bluestore: introduce allocator state histogram
Reviewed-by: Adam Kupczyk <akupczyk@ibm.com>
zdover23 [Sat, 22 Jul 2023 05:25:32 +0000 (15:25 +1000)]
Merge pull request #52542 from zdover23/wip-doc-2023-07-19-rados-configuration-ceph-conf-3-of-x
doc/rados: edit ceph-conf.rst (3 of x)
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Zac Dover [Wed, 19 Jul 2023 13:00:38 +0000 (23:00 +1000)]
doc/rados: edit ceph-conf.rst (3 of x)
Edit doc/rados/configuration/ceph-conf.rst.
Signed-off-by: Zac Dover <zac.dover@proton.me>
Casey Bodley [Fri, 21 Jul 2023 14:18:33 +0000 (10:18 -0400)]
Merge pull request #52475 from yuvalif/wip-yuval-multisite-vstart-params
rgw/test: allow passing vstart parameters to multisite tests script
Reviewed-by: Casey Bodley <cbodley@redhat.com>
Ilya Dryomov [Fri, 21 Jul 2023 10:14:57 +0000 (12:14 +0200)]
Merge pull request #52057 from nbalacha/tracker-61672
rbd-mirror: fix race preventing local image deletion
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
Reviewed-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
Reviewed-by: Mykola Golub <mgolub@suse.com>
Yuri Weinstein [Thu, 20 Jul 2023 21:46:56 +0000 (17:46 -0400)]
Merge pull request #52025 from rzarzynski/wip-ec-drop-unused-requires_overwrite
osd: drop the unused ECTransaction::requires_overwrite()
Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Matan Breizman <Matan.Brz@gmail.com>
Ilya Dryomov [Thu, 20 Jul 2023 20:56:21 +0000 (22:56 +0200)]
Merge pull request #52491 from cbodley/wip-61566
valgrind: replace suppression for EVP_DecryptFinal_ex
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Ilya Dryomov [Thu, 20 Jul 2023 19:03:19 +0000 (21:03 +0200)]
Merge pull request #52427 from petrutlucian94/fix_win32_boost
win32_deps_build: skip patching removed boost files
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
Reviewed-by: Adam Emerson <aemerson@redhat.com>
Casey Bodley [Thu, 20 Jul 2023 18:51:05 +0000 (14:51 -0400)]
Merge pull request #52143 from cbodley/wip-61567
test/pybind: replace nose with pytest
Reviewed-by: Ilya Dryomov <idryomov@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Anthony D'Atri [Thu, 20 Jul 2023 17:54:43 +0000 (13:54 -0400)]
Merge pull request #52563 from zdover23/wip-doc-2023-07-21-governance-orman-email-update
doc: governance.rst - update D Orman
Zac Dover [Thu, 20 Jul 2023 17:35:52 +0000 (03:35 +1000)]
doc: governance.rst - update D Orman
Update David Orman's email address in doc/governance.rst.
Signed-off-by: Zac Dover <zac.dover@proton.me>
Laura Flores [Thu, 20 Jul 2023 17:19:41 +0000 (12:19 -0500)]
Merge pull request #52544 from rhcs-dashboard/debug-make-check
install-deps: remove the legacy resolver flags
Casey Bodley [Thu, 20 Jul 2023 13:23:52 +0000 (09:23 -0400)]
valgrind: remove stale openssl suppressions
years ago in commit
fe97a000990632dbe9734e0d3a96df627f104f7a , the
signature of authenticated_decrypt_update_final() changed and this
suppression no longer matches its mangled form:
- fun:_ZN4ceph6crypto6onwire25AES128GCM_OnWireRxHandler34authenticated_decrypt_update_finalEONS_6buffer7v*4listEj
+ fun:_ZN4ceph6crypto6onwire25AES128GCM_OnWireRxHandler34authenticated_decrypt_update_finalERNS_6buffer7v15_2_04listE
the fact that we didn't notice must mean that we don't need the
suppressions anymore
Signed-off-by: Casey Bodley <cbodley@redhat.com>
Yuri Weinstein [Thu, 20 Jul 2023 14:26:10 +0000 (10:26 -0400)]
Merge pull request #52374 from rosinL/wip-cleanup
crush/CrushLocation: remove useless flag
Reviewed-by: Samuel Just <sjust@redhat.com>
Casey Bodley [Wed, 19 Jul 2023 17:19:46 +0000 (13:19 -0400)]
valgrind: suppress uninitialized value in OpenSSL
Fixes: https://tracker.ceph.com/issues/61566
Signed-off-by: Casey Bodley <cbodley@redhat.com>
Nizamudeen A [Wed, 19 Jul 2023 14:05:05 +0000 (19:35 +0530)]
install-deps: remove the legacy resolver flags
This was a workaround that was introduced long time ago. This will be
something that could be deprectaed at some point [1]. And its preventing some of the dependencies to be
downloaded or stored into the wheelhouse. Deps like jsonschema, parse,
mypy, cryptography etc.
[1] https://pip.pypa.io/en/latest/user_guide/#deprecation-timeline
Fixes: https://tracker.ceph.com/issues/62082
Signed-off-by: Nizamudeen A <nia@redhat.com>
Yuri Weinstein [Wed, 19 Jul 2023 16:10:32 +0000 (12:10 -0400)]
Merge pull request #49332 from shreyanshjain7174/stuck_peering
mon: stuck peering since warning is misleading
Reviewed-by: Kamoltat (Junior) Sirivadhna <ksirivad@redhat.com>
Yuri Weinstein [Wed, 19 Jul 2023 16:06:32 +0000 (12:06 -0400)]
Merge pull request #51438 from NitzanMordhai/wip-nitzan-cbt-perf-ci
cbt perf ci
Reviewed-by: Samuel Just <sjust@redhat.com>
Yuri Weinstein [Wed, 19 Jul 2023 16:06:05 +0000 (12:06 -0400)]
Merge pull request #50301 from liuqinfei/support_compile_on_openeuler_main
ceph.spec.in: add support for openEuler OS
Reviewed-by: Rongqi Sun <sunrongqi@huawei.com>
Reviewed-by: Ilya Dryomov <idryomov@redhat.com>
Reviewed-by: Laura Flores <lflores@redhat.com>
Yuri Weinstein [Wed, 19 Jul 2023 16:04:08 +0000 (12:04 -0400)]
Merge pull request #49480 from flyingcircusio/fix-mon-delete-iterator
mon: fix iterator mishandling in PGMap::apply_incremental
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Yuri Weinstein [Wed, 19 Jul 2023 16:00:45 +0000 (12:00 -0400)]
Merge pull request #52021 from xxhdx1985126/wip-61650
osd/PeeringState: recheck pg readability when renewing leases for no-replica pools
Reviewed-by: Samuel Just <sjust@redhat.com>
Yuri Weinstein [Wed, 19 Jul 2023 15:33:28 +0000 (11:33 -0400)]
Merge pull request #50441 from cbodley/wip-qa-distros-centos9
qa/distros: add centos stream 9 as supported distro
Reviewed-by: Ilya Dryomov <idryomov@redhat.com>
Reviewed-by: Yuri Weinstein <yweinste@redhat.com>
Reviewed-by: Ken Dreyer <kdreyer@redhat.com>
Ilya Dryomov [Wed, 19 Jul 2023 09:41:55 +0000 (11:41 +0200)]
Merge pull request #52124 from idryomov/wip-61733
mon/MonClient: resurrect original client_mount_timeout handling
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Matan [Wed, 19 Jul 2023 07:45:15 +0000 (10:45 +0300)]
Merge pull request #52266 from amathuria/wip-crimson-amat-fix-config-show
crimson/mgr: Fix config show command
Reviewed-by: Matan Breizman <mbreizma@redhat.com>
Reviewed-by: Samuel Just <sjust@redhat.com>
Venky Shankar [Tue, 18 Jul 2023 14:45:24 +0000 (20:15 +0530)]
Merge PR #51539 into main
* refs/pull/51539/head:
doc: users now need to provide scrub_mdsdir and recursive flags
qa: add recursive flag to test_flag_scrub_mdsdir
mds: remove code to bypass dumping empty header scrub info
mds: dump_values no more needed
mds: enqueue ~mdsdir at the time of enqueing root
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Casey Bodley [Tue, 18 Jul 2023 13:28:48 +0000 (09:28 -0400)]
Merge pull request #51700 from cfsnyder/wip-cfsnyder-put-404
rgw: fix consistency bug with OLH objects
Reviewed-by: Casey Bodley <cbodley@redhat.com>
Lucian Petrut [Fri, 14 Jul 2023 10:16:47 +0000 (10:16 +0000)]
test/common: skip unittest_back_trace with mingw-gcc
We're getting an ICE when trying to compile this test using
mingw-gcc and recent Boost versions. Note that mingw-llvm works fine.
during IPA pass: inline
/mnt/data/workspace/ceph.pr/src/test/common/test_back_trace.cc:44:1:
internal compiler error: Segmentation fault
44 | }
| ^
0x7f9c4a86c51f ???
./signal/../sysdeps/unix/sysv/linux/x86_64/libc_sigaction.c:0
0x7f9c4a853d8f __libc_start_call_main
../sysdeps/x86/libc-start.c:58
0x7f9c4a853e3f __libc_start_main_impl
../sysdeps/nptl/libc_start_call_main.h:392
For now, we'll just skip the test when using mingw-gcc. Note
that we're planing to switch to mingw-llvm anyway:
https://github.com/ceph/ceph/pull/51197
Signed-off-by: Lucian Petrut <lpetrut@cloudbasesolutions.com>
Lucian Petrut [Thu, 13 Jul 2023 10:48:14 +0000 (10:48 +0000)]
win32_deps_build: skip patching removed boost files
We're attempting to patch some Python files that have been removed
from recent Boost versions.
Now that the Boost version has been bumped, we'll need to address
this in order to unblock the Windows build.
Signed-off-by: Lucian Petrut <lpetrut@cloudbasesolutions.com>
Adam Kupczyk [Tue, 18 Jul 2023 12:27:24 +0000 (14:27 +0200)]
Merge pull request #52193 from aclamk/wip-aclamk-fix-55260
os/bluestore: Fixes ceph-bluestore-tool bluefs-bdev-new-db
Venky Shankar [Tue, 18 Jul 2023 10:40:24 +0000 (16:10 +0530)]
Merge PR #52173 into main
* refs/pull/52173/head:
mds: MDLog::_recovery_thread: handle the errors gracefully
Reviewed-by: Kotresh Hiremath Ravishankar <khiremat@redhat.com>
Reviewed-by: Xiubo Li <xiubli@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Xuehan Xu [Wed, 28 Jun 2023 07:18:27 +0000 (15:18 +0800)]
crimson/os/seastore/collection_manager: fill CollectionNode::decoded on
clean reads
Otherwise, deltas of collection nodes can't be replayed correctly,
because the data of nodes is not loaded to CollectionNode::decoded
Signed-off-by: Xuehan Xu <xuxuehan@qianxin.com>
Casey Bodley [Wed, 21 Jun 2023 12:08:58 +0000 (08:08 -0400)]
qa/suites: install pytest for pybind tasks
Signed-off-by: Casey Bodley <cbodley@redhat.com>
Ali Masarwa [Thu, 13 Jul 2023 11:17:48 +0000 (14:17 +0300)]
RGW: fix issue in observability over the persistent topics queue
when releasing entires, we don't decrease them in the urgent data
Signed-off-by: Ali Masarwa <ali.saed.masarwa@gmail.com>
Igor Fedotov [Mon, 29 May 2023 14:11:37 +0000 (17:11 +0300)]
os/bluestore: do not include single AU allocations to allocation
fragmentation stats.
The rationale is that such allocations always get single framgent.
Signed-off-by: Igor Fedotov <igor.fedotov@croit.io>
Igor Fedotov [Thu, 22 Jun 2023 13:18:03 +0000 (16:18 +0300)]
test/allocator_replay: introduce allocator fragmentation histogram.
Signed-off-by: Igor Fedotov <igor.fedotov@croit.io>
Igor Fedotov [Thu, 22 Jun 2023 13:16:32 +0000 (16:16 +0300)]
os/bluestore: implement allocator fragmentation histogram
Signed-off-by: Igor Fedotov <igor.fedotov@croit.io>
zdover23 [Mon, 17 Jul 2023 13:19:46 +0000 (23:19 +1000)]
Merge pull request #52483 from bluikko/patch-15
doc/mgr/rgw.rst: add missing "ceph" command in cli specification
Reviewed-by: Zac Dover <zac.dover@proton.me>
Ville Ojamo [Mon, 17 Jul 2023 13:05:39 +0000 (20:05 +0700)]
doc/mgr/rgw.rst: add missing "ceph" command in cli specification
The line begins with a prompt so I would
expect it to be a "complete" command,
including the `ceph` binary to run with all
the various listed arguments.
Signed-off-by: Ville Ojamo <14869000+bluikko@users.noreply.github.com>
Venky Shankar [Mon, 17 Jul 2023 08:29:40 +0000 (13:59 +0530)]
Merge PR #51383 into main
* refs/pull/51383/head:
client: clean up the queue_cap_snap() code to remove unnecessary check
client: always add one new capsnap if Fb is used and Fw is not used
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Venky Shankar [Mon, 17 Jul 2023 08:27:41 +0000 (13:57 +0530)]
Merge PR #51850 into main
* refs/pull/51850/head:
client: do not send metrics until the MDS rank is ready
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Dhairya Parmar <dparmar@redhat.com>
Guillaume Abrioux [Mon, 17 Jul 2023 07:21:34 +0000 (09:21 +0200)]
Merge pull request #52422 from guits/cv-add-raw-osd-id-param
ceph-volume: add --osd-id option to raw prepare
zdover23 [Mon, 17 Jul 2023 06:50:14 +0000 (16:50 +1000)]
Merge pull request #52476 from bluikko/patch-14
doc/mgr/rgw.rst: fix multisite typed wrong
Reviewed-by: Rongqi Sun (Svelar) <sunrongqi@huawei.co>
Ville Ojamo [Mon, 17 Jul 2023 03:35:46 +0000 (10:35 +0700)]
doc/mgr/rgw.rst: multisite typed wrong
Multisite is typed wrong as mutlisite so fix the spelling.
Signed-off-by: Ville Ojamo <14869000+bluikko@users.noreply.github.com>
Xuehan Xu [Fri, 14 Jul 2023 03:59:06 +0000 (11:59 +0800)]
crimson/os/seastore/object_data_handler: add ObjectDataHandler(extent_len_t)
Signed-off-by: Xuehan Xu <xuxuehan@qianxin.com>
Yuval Lifshitz [Sun, 16 Jul 2023 16:52:47 +0000 (16:52 +0000)]
rgw/test: allow passing vstart parameters to multisite tests script
via the VSTART_PARAMETERS env variable
Signed-off-by: Yuval Lifshitz <ylifshit@ibm.com>
Vedansh Bhartia [Thu, 6 Jul 2023 05:57:43 +0000 (11:27 +0530)]
rgw: add coverity annotations and asserts for null dereferences
Signed-off-by: Vedansh Bhartia <vedanshbhartia@gmail.com>
Vedansh Bhartia [Sun, 16 Jul 2023 15:49:17 +0000 (21:19 +0530)]
rgw: refactor D3nDataCache::d3n_io_write to avoid resource leaks
1. D3nChunkDataInfo was allocated at the beginning of the function on
the heap, and was not freed in case of errors. This memory allocation
has been moved to where it is being utilised.
2. cache_file file descriptor was not closed if the write to the file
failed. To avoid such issues, cache_file is declared as a unique_ptr
with a custom deleter that closes the descriptor when the ptr goes
out of scope.
Signed-off-by: Vedansh Bhartia <vedanshbhartia@gmail.com>
zdover23 [Sun, 16 Jul 2023 09:16:32 +0000 (19:16 +1000)]
Merge pull request #52465 from zdover23/wip-doc-2023-07-15-rados-configuration-ceph-conf-2-of-x
doc/rados: edit ceph-conf.rst (2 of x)
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Zac Dover [Sat, 15 Jul 2023 01:09:20 +0000 (11:09 +1000)]
doc/rados: edit ceph-conf.rst (2 of x)
Edit doc/rados/configuration/ceph-conf.rst.
Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
Vedansh Bhartia [Sun, 16 Jul 2023 05:06:22 +0000 (10:36 +0530)]
rgw: Remove logically dead code
Signed-off-by: Vedansh Bhartia <vedanshbhartia@gmail.com>
Vedansh Bhartia [Thu, 13 Jul 2023 11:58:24 +0000 (17:28 +0530)]
rgw: Add coverity annotation for missing break statement in switch
Signed-off-by: Vedansh Bhartia <vedanshbhartia@gmail.com>
Vedansh Bhartia [Sun, 16 Jul 2023 04:52:42 +0000 (10:22 +0530)]
rgw: When finding bucket owner info, handle account name being empty
Signed-off-by: Vedansh Bhartia <vedanshbhartia@gmail.com>
Rishabh Dave [Sat, 15 Jul 2023 02:35:56 +0000 (08:05 +0530)]
Merge pull request #51317 from rishabh-d-dave/mdscaps-combinations
mds: allow all types of mds capsq
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Yuri Weinstein [Fri, 14 Jul 2023 20:31:56 +0000 (16:31 -0400)]
Merge pull request #52185 from YiteGu/raise-prio-before-queue-op
osd/perf_counters: raise prio of before queue op perfcounter
Reviewed-by: Samuel Just <sjust@redhat.com>
Yuri Weinstein [Fri, 14 Jul 2023 20:30:39 +0000 (16:30 -0400)]
Merge pull request #52088 from gazdi31/fix_1
mon/ConfigMonitor: update crush_location from osd entity
Reviewed-by: Samuel Just <sjust@redhat.com>
Yuri Weinstein [Fri, 14 Jul 2023 20:30:12 +0000 (16:30 -0400)]
Merge pull request #50393 from rhcs-dashboard/mirror-con
msgr: AsyncMessenger faulted connections metrics
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Reviewed-by: Ilya Dryomov <idryomov@redhat.com>
Reviewed-by: Laura Flores <lflores@redhat.com>
Yuri Weinstein [Fri, 14 Jul 2023 20:28:40 +0000 (16:28 -0400)]
Merge pull request #50291 from batrick/i55606
pybind/mgr: reopen database handle on blocklist
Reviewed-by: Ramana Raja <rraja@redhat.com>
Yuri Weinstein [Fri, 14 Jul 2023 20:26:00 +0000 (16:26 -0400)]
Merge pull request #51947 from alimaredia/wip-counter-dump-array-add
common: `counter dump` command revision
Reviewed-by: Ilya Dryomov <idryomov@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Shilpa Jagannath [Fri, 14 Jul 2023 20:11:53 +0000 (16:11 -0400)]
Merge pull request #51493 from smanjara/wip-data-sync-fairness
rgw: data sync fairness
Casey Bodley [Fri, 14 Jul 2023 14:34:30 +0000 (10:34 -0400)]
Merge pull request #52431 from ronen-fr/wip-rf-fix-opsfmt
OSD, common: fix fmtlib v8 handling of OpSchedItem
Reviewed-by: Radosław Zarzyński <rzarzyns@redhat.com>
Reviewed-by: Samuel Just <sjust@redhat.com>
Adam Kupczyk [Fri, 14 Jul 2023 14:02:40 +0000 (16:02 +0200)]
Merge pull request #51941 from Posrabi/wip-disk-frag-simulator
test/objectstore: Fragmentation Simulator
Rishabh Dave [Tue, 9 May 2023 12:32:17 +0000 (18:02 +0530)]
src/tests/mds: improve test coverage in TestMDSAuthCaps
Currently we check if the right caps parse successfully and the wrong
caps fail to parse. Increase the test coverage by adding one more
tests -- dump the right caps in to a string after the parsing is
successfully and then re-parse the caps and check if re-parsed caps
dumps to the exact same string.
Signed-off-by: Rishabh Dave <ridave@redhat.com>
Rishabh Dave [Tue, 9 May 2023 09:00:37 +0000 (14:30 +0530)]
src/tests/mds: add tests for all combinations of MDS caps
Signed-off-by: Rishabh Dave <ridave@redhat.com>
Rishabh Dave [Sun, 30 Apr 2023 13:01:00 +0000 (18:31 +0530)]
mds: allow all types of MDS caps
MDS caps can contain 5 components: name of a CephFS, a path inside
CephFS, a flag for enabling root squashing mechanism, a UID and list of
GIDs. These 5 components result in 31 combinations, so there can be 31
types of MDS caps. Out of these, the current main branch only allows 11
combinations. This restriction is strange and inappropriate. Ideally,
all combinations should be allowed.
This strange restriction must've been created unintentionally by
previous developers while adding FS name and root squash to MDS caps. A
TODO for a allowing a subset of these combination was also left in
codebase:
https://github.com/ceph/ceph/blob/reef/src/mds/MDSAuthCaps.cc#L69
Fixes: https://tracker.ceph.com/issues/59388
Signed-off-by: Rishabh Dave <ridave@redhat.com>
N Balachandran [Fri, 14 Jul 2023 12:56:15 +0000 (18:26 +0530)]
rbd-mirror: fix race preventing local image deletion
On primary image deletion, a race between InstanceReplayer::release_image()
(which calls ImageReplayer::stop())and ImageReplayer::handle_bootstrap()
may prevent the non-primary image from being deleted. Because
ImageReplayer::handle_bootstrap() checks if the start has been canceled
before processing -ENOLINK, m_delete_requested is not set to true and the
local image is not deleted.
This commit sets m_delete_requested to true before checking if the
start has been canceled to ensure that the image is deleted during shut_down,
and updates ImageReplayer::bootstrap() to cancel the BootstrapRequest
and prevent a potentially long time spent in an image sync if ImageReplayer
stop is requested.
Fixes: https://tracker.ceph.com/issues/61672
Signed-off-by: N Balachandran <nibalach@redhat.com>
Cory Snyder [Wed, 12 Jul 2023 14:08:07 +0000 (14:08 +0000)]
rgw: fix/improve test_rgw_versioning.py tests
Signed-off-by: Cory Snyder <csnyder@1111systems.com>
Nizamudeen A [Fri, 14 Jul 2023 11:00:03 +0000 (16:30 +0530)]
Merge pull request #51879 from cloudbehl/pool-creation
mgr/dashboard: Create Default pool for Ceph Block
Reviewed-by: Nizamudeen A <nia@redhat.com>
zdover23 [Fri, 14 Jul 2023 09:04:23 +0000 (19:04 +1000)]
Merge pull request #52402 from zdover23/wip-doc-2023-07-12-rados-operations-add-or-rm-osds-2-of-x
doc/rados: edit add-or-rm-osds (2 of x)
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Zac Dover [Tue, 11 Jul 2023 21:58:59 +0000 (07:58 +1000)]
doc/rados: edit add-or-rm-osds (2 of x)
Edit doc/rados/operations/add-or-rm-osds.rst (2 of x).
Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
zdover23 [Fri, 14 Jul 2023 07:57:19 +0000 (17:57 +1000)]
Merge pull request #52423 from zdover23/wip-doc-2023-07-13-rados-configuration-ceph-conf-1-of-x
doc/rados: edit ceph-conf.rst
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Nizamudeen A [Fri, 14 Jul 2023 07:24:23 +0000 (12:54 +0530)]
Merge pull request #51831 from rhcs-dashboard/disable-promote
mgr/dashboard: disable promote on mirroring not enabled
Reviewed-by: Nizamudeen A <nia@redhat.com>