osd/OSDMap: include cleanup

Signed-off-by: Max Kellermann <max.kellermann@ionos.com>

osd/osd_types: include cleanup

Signed-off-by: Max Kellermann <max.kellermann@ionos.com>

osd/OSDMapMapping: add missing include

Signed-off-by: Max Kellermann <max.kellermann@ionos.com>

osd/PGPeeringEvent: add missing includes

Signed-off-by: Max Kellermann <max.kellermann@ionos.com>

osd/ECUtil: add missing includes

Signed-off-by: Max Kellermann <max.kellermann@ionos.com>

OSD/osd_internal_types: add missing include

Signed-off-by: Max Kellermann <max.kellermann@ionos.com>

osd/PrimaryLogPG: add missing include

Signed-off-by: Max Kellermann <max.kellermann@ionos.com>

osd/ReplicatedBackend: add missing includes

Signed-off-by: Max Kellermann <max.kellermann@ionos.com>

osd/Watch: add missing include

Signed-off-by: Max Kellermann <max.kellermann@ionos.com>

osd/OSD: add missing includes

Signed-off-by: Max Kellermann <max.kellermann@ionos.com>

osd/PG: add missing include

Signed-off-by: Max Kellermann <max.kellermann@ionos.com>

osd/ECBackend: include cleanup

Signed-off-by: Max Kellermann <max.kellermann@ionos.com>

osd/scheduler: add missing includes

Signed-off-by: Max Kellermann <max.kellermann@ionos.com>

osd/PGStateUtils: add missing includes

Signed-off-by: Max Kellermann <max.kellermann@ionos.com>

osd/SnapMapper: add missing includes

Signed-off-by: Max Kellermann <max.kellermann@ionos.com>

osd/scrubber: add missing includes

Signed-off-by: Max Kellermann <max.kellermann@ionos.com>

osd/scrubber/ScrubStore: remove `using std::ostringstream` directive

This name is never used.

Signed-off-by: Max Kellermann <max.kellermann@ionos.com>

osd/PGLog: add missing include

Signed-off-by: Max Kellermann <max.kellermann@ionos.com>

include/object: include cleanup

Signed-off-by: Max Kellermann <max.kellermann@ionos.com>

Merge pull request #62550 from tchaikov/fmt-formattable

src: migrate to fmt::formattable for format support

Reviewed-by: Ronen Friedman <rfriedma@redhat.com>

Merge pull request #62509 from rzarzynski/wip-bug-69724

osd: fix the tiering agent's shutdown wrt the OSD fast shutdown

Reviewed-by: Brad Hubbard <bhubbard@redhat.com>

src: migrate to fmt::formattable for format support

Replace custom has_formatter concept with fmtlib's fmt::formattable

- Deprecate usage of fmt::has_formatter
- Resolve compiler warnings with recent fmtlib versions

The custom concept of has_formatter is no longer necessary with
recent updates to the fmtlib library, as fmt::formattable was introduced
in fmtlib v11.0.0. By switching to fmt::formattable, we simplify our
code and stop using the deprecated `fmt::has_formatter` template.

Signed-off-by: Kefu Chai <tchaikov@gmail.com>

Merge pull request #62474 from tchaikov/openssl-engine

common: disable OpenSSL engine support if it is disabled

Reviewed-by: Adam Emerson <aemerson@redhat.com>
Reviewed-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #62141 from baum/nvmeof_cluster_alloc

NvmeofServiceSpec: ceph connection allocation strategies

Merge pull request #62480 from tchaikov/erasure-code-free

erasure-code: use new/delete to alloc/free coefficients array

Reviewed-by: Alex Ainscow <aainscow@redhat.com>

Merge pull request #62174 from ifed01/wip-ifed-fix-bluefs-reserved2

os/bluestore: use block size (4K) as minimal allocation unit for dedicated DB/WAL volumes

Reviewed-by: Adam Kupczyk <akupczyk@ibm.com>

Merge pull request #62251 from ifed01/wip-ifed-print-discard-threads

blk/kernel: New perf counter to view amount of discard threads.

Reviewed-by: Yite Gu <yitegu0@gmail.com>

Merge pull request #62546 from tchaikov/crimson-rados-qa

qa: add missing .qa links for crimson-rados tests

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>

Merge pull request #62537 from zdover23/wip-doc-2025-03-27-mon_warn_pg_not_scrubbed_ratio-guidance

src/common: add guidance for mon_warn_pg_not_scrubbed

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

Merge pull request #62471 from YiteGu/fix-invalid-iterator-usge-after-erase

blk/kerneldevice: fix invalid iterator usage after erase in discard_q…

Merge pull request #62273 from aclamk/wip-aclamk-osd-superblock-corruption-resilient

osd/OSD.cc: make osd_superblock recovery more robust

Merge pull request #62476 from rhcs-dashboard/fix-70646-main

mgr/dashboard: fix bucket form encryption checkbox

Reviewed-by: Nizamudeen A <nia@redhat.com>

NvmeofServiceSpec: ceph connection allocation strategies

Co-authored-by: Adam King <47704447+adk3798@users.noreply.github.com>
Signed-off-by: Alexander Indenbaum <aindenba@redhat.com>

qa: add missing .qa links for crimson-rados tests

follow the suggestion by src/script/verify-qa to address the
failure of qa-symlink.yml workflow. without this change, the
workflow consistently fails.

Signed-off-by: Kefu Chai <tchaikov@gmail.com>

common: disable OpenSSL engine support if it is disabled

OpenSSL 3.0 documentation recommends moving from the ENGINE API to the
Providers API. Recent distributions may compile OpenSSL without engine
support by default, necessitating more flexible configuration handling.

So, in this change:

- Add a CMake option `WITH_OPENSSL_ENGINE` to explicitly control engine support
- Respect `openssl_engine_opts` when engine support is enabled
- Provide clear error messaging when engine options are set but support is disabled

See also:
- OpenSSL 3.0 documentation:
https://wiki.openssl.org/index.php/OpenSSL_3.0#Engines_and_.22METHOD.22_APIs

Fixes: https://tracker.ceph.com/issues/68059
Signed-off-by: Kefu Chai <tchaikov@gmail.com>

Merge pull request #62521 from idryomov/wip-rbd-mirror-pool-status-fixups

rbd: "rbd mirror pool status --verbose" output fixups

Reviewed-by: Ramana Raja <rraja@redhat.com>

Merge pull request #60351 from rhcs-dashboard/ngb-popover

mgr/dashboard: replace ngb-popover with carbon popover

Reviewed-by: Afreen Misbah <afreen@ibm.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Naman Munet <nmunet@redhat.com>

src/common: add guidance for mon_warn_pg_not_scrubbed

Add an explanation of how to set the value of
"mon_warn_pg_not_scrubbed_ratio" to the confval definition of that
variable. Although this variable contains the string "mon", it is set on
the Manager. I have added a note to direct users to set this value on
the Manager.

This issue was pointed out by Petr Tlapa on Slack in late March of 2025.

This issue is part of a small project that also encompasses
https://github.com/ceph/ceph/pull/62459, which is associated with commit
aeef59a50ee31072648ba0c7436b6522137614cd

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>

Merge pull request #62105 from xhernandez/configure-case-sensitivity

pybind/mgr/volumes: configure case sensitivity

Reviewed-by: Avan Thakkar <athakkar@redhat.
Reviewed-by: Patrick Donnelly <pdonnell@ibm.com>
Reviewed-by: Anoop C S <anoopcs@cryptolab.net>

mgr/dashboard: fix bucket form encryption checkbox

The condition to disable/enable encryption checkbox on bucket form is broken because of the new structure of the get encryption config API response.

Fixes: https://tracker.ceph.com/issues/70646
Signed-off-by: Aashish Sharma <aasharma@redhat.com>

Merge pull request #61649 from Hezko/nvmeof-response-handling

mgr/dashboard: introduce "convert_to_model" and "pick" decorators

Merge pull request #62373 from myoungwon/wip-qa-seastore-rbm-remaining

qa/suites/crimson-rados: add seastore with RBM test under the remaining tests

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>

Merge pull request #62489 from rhcs-dashboard/fix-70653-main

mgr/dashboard: fix image filter's query on rbd-details grafana panel

Reviewed-by: Nizamudeen A <nia@redhat.com>

Merge pull request #62392 from ceph/fix-70557-main

mgr/dashboard: fix blockUI implementation

Merge pull request #62493 from tchaikov/clang-as-gcc

common/ceph_context: Fix std::atomic<std::shared_ptr> compatibility

Reviewed-by: Patrick Donnelly <pdonnell@ibm.com>
Reviewed-by: Max Kellermann <max.kellermann@ionos.com>

Merge pull request #62458 from AliMasarweh/wip-alimasa-bn-list-fix

RGW|Bucket Notification: fix for v2 topics rgw-admin list operation

Reviewed-by: yuvalif<ylifshit@redhat.com>

mgr/dashboard: introduce "convert_to_model" util

fixes: https://tracker.ceph.com/issues/62705

Signed-off-by: Tomer Haskalovitch <il033030@Tomers-MacBook-Pro.local>

common/ceph_context: Fix std::atomic<std::shared_ptr> compatibility

Previously, we relied on the __GNUC__ macro to check for std::atomic<std::shared_ptr>
support, which was inaccurate. This approach failed with Clang builds using libstdc++,
even when the feature was implemented. The warning looks like:

```
/usr/lib/gcc/x86_64-redhat-linux/15/../../../../include/c++/15/bits/shared_ptr_atomic.h:131:5: note: 'atomic_load_explicit<std::vector<entity_addrvec_t>>' has been explicitly marked deprecated here
  131 |     _GLIBCXX20_DEPRECATED_SUGGEST("std::atomic<std::shared_ptr<T>>")
      |     ^
```

This change uses a standard-compliant feature test macro (__cpp_lib_atomic_shared_ptr)
to correctly detect support for std::atomic<std::shared_ptr>. This resolves compilation
issues and improves portability across different compilers and standard library
implementations.

Refs 5b0d849730ce20d68ffafcb612c5f6fc8b87dd9a

Signed-off-by: Kefu Chai <tchaikov@gmail.com>

Merge pull request #62520 from Thingee/update-slack-invite-link

doc: Update Slack invite links

Merge pull request #62324 from phlogistonjohn/jjm-bwc-fix-70470-clang-2

 build-with-container: fix container build on docker and clang setup on ubuntu jammy  [v2]

Merge pull request #62463 from cbodley/wip-qa-rgw-lockdep

qa/rgw: enable lockdep config for radosgw

Reviewed-by: Adam Emerson <aemerson@redhat.com>

Merge pull request #61761 from phlogistonjohn/jjm-list_daemons-refactor

cephadm: refactor the core of list_daemons

Reviewed-by: Adam King <adking@redhat.com>

RGW|Bucket Notification: fix for v2 topics rgw-admin list operation

Signed-off-by: Ali Masarwa <amasarwa@redhat.com>

rbd: mirror_uuids -> mirror_uuid in remote mirror peer listing

... in "rbd mirror image status" and "rbd mirror pool status --verbose"
formatted outputs.  In unformatted outputs this value is shown in place
of a name in case a site name isn't available.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>

rbd: extend use of "none" placeholder to IMAGES section

Currently if there are no mirror-enabled images, IMAGES section
in "rbd mirror pool status --verbose" output isn't terminated:

  $ rbd mirror pool status data --verbose
  health: OK
  daemon health: OK
  image health: OK
  images: 0 total

  DAEMONS
  service 4388:
    ...
    health: OK

  IMAGES$

DAEMONS section has a "none" placeholder for when there are no
rbd-mirror daemons running.  Fix some issues with the separator logic
and employ the placeholder in IMAGES section:

  $ rbd mirror pool status data --verbose
  health: OK
  daemon health: OK
  image health: OK
  images: 0 total

  DAEMONS
  service 4388:
    ...
    health: OK

  IMAGES
    none
  $

  $ rbd mirror pool status data --verbose
  health: UNKNOWN
  daemon health: UNKNOWN
  image health: OK
  images: 0 total

  DAEMONS
    none

  IMAGES
    none
  $

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>

rbd: drop redundant separator between DAEMONS and IMAGES sections

... in "rbd mirror pool status --verbose" output.  Before:

  DAEMONS
  service 4388:
    ...
    health: OK

  IMAGES
  a1:
    global_id:   8f5531db-0ec5-41da-907b-95f457f1b316
    state:       up+stopped
    ...

After:

  DAEMONS
  service 4388:
    ...
    health: OK

  IMAGES
  a1:
    global_id:   8f5531db-0ec5-41da-907b-95f457f1b316
    state:       up+stopped
    ...

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>

Merge pull request #62515 from rzarzynski/wip-ftbfs-rgwzoneplctier

rgw: fix the version in DECODE_START() of RGWZoneGroupPlacementTier

Reviewed-by: Kefu Chai <tchaikov@gmail.com>
Reviewed-by: Casey Bodley <cbodley@redhat.com>
Reviewed-by: Bill Scales <bill_scales@uk.ibm.com>

doc: Update Slack invite links

The invite links expire after 30 days. Here's a new one.

Signed-off-by: Mike Perez <thingee@gmail.com>

rgw: fix the version in DOCODE_START() of RGWZoneGroupPlacementTier

This commit fixes an undetected merge conflict between PRs #61745
and #60159. The dencoding problem has been introduced very recently,
it is straightforward and causes failures of the make check bot
everywhere, therefore -- if no objections -- I want to merge this
patch without the Teuthology testing.

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>

Merge pull request #62452 from tchaikov/librbd-std-variant

librbd: migrate from boost::variant to std::variant

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>

Merge pull request #62484 from idryomov/wip-70640

mgr/rbd_support: always parse interval and start_time in Schedules::remove()

Reviewed-by: Ramana Raja <rraja@redhat.com>

mgr/dashboard: replace ngb-popover with carbon popover

Fixes: https://tracker.ceph.com/issues/68259
Signed-off-by: Prachi Goel <prachi@li-f0e8f2cc-27e0-11b2-a85c-b2772164128d.ibm.com>
Below are the changes from bootstrap popover to carbon popover:
1. Dashboard v3
2. Health Component
3. RGW sync data component
4. RGW sync metadata component
5. Upgrade component

Merge pull request #62512 from anthonyeleven/iptableswarn

doc/rados/configuration: Add iptables change admonition to network-config.rst

doc/rados/configuration: Add iptables change admonition to network-config.rst

Signed-off-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>

Merge pull request #62475 from tchaikov/literal-operator

common: remove spaces before literal operator

Reviewed-by: Patrick Donnelly <pdonnell@ibm.com>

osd: fix the tiering agent's shutdown wrt the OSD fast shutdown

Fixes: https://tracker.ceph.com/issues/69724
Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>

Merge pull request #60277 from rzarzynski/wip-tools-rados-omap-listbench

tools/rados: generalize the OMAP benchmarking to cover listing as well

Reviewed-by: Igor Fedotov <igor.fedotov@croit.io>

Merge pull request #60159 from rzarzynski/wip-denc-ctcheck-struct_v

dencoding: check struct_v against DECODE_START(v, ...) at compile-time

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
Reviewed-by: Greg Farnum <gfarnum@redhat.com>
Reviewed-by: Jesse Williamson <jwilliamson@suse.de>
Reviewed-by: Adam Kupczyk <akupczyk@redhat.com>
Reviewed-by: Nitzan Mordechai <nmordech@redhat.com>

Merge pull request #62459 from zdover23/wip-doc-2025-03-24-mon_warn_pg_not_deep_scrubbed-guidance

src/common: add guidance for deep-scrubbing ratio warning

Reviewed-by: David Galloway <david.galloway@ibm.com>

Merge PR #62465 into main

* refs/pull/62465/head:
qa: add test for `mgr status` command
mgr: add status command

Reviewed-by: Laura Flores <lflores@redhat.com>
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>

Merge pull request #62215 from rkachach/fix_mgmt_gw_ha

mgr/cephadm: refactor oauth2-proxy certs and cookie-secret handling

Reviewed-by: Adam King <adking@redhat.com>

Merge pull request #62477 from rhcs-dashboard/upgrade-grafana-10.4.16

mgr/cephadm: upgrade grafana to 10.4.16

Reviewed-by: Afreen Misbah <afreen@ibm.com>

Merge pull request #62229 from phlogistonjohn/jjm-teuth-ctdb-sebool

qa/cephadm/smb: set virt_sandbox_use_netlink selinux bool on ctdb tests

Reviewed-by: Adam King <adking@redhat.com>

Merge pull request #61824 from ShwetaBhosale1/fix_issue_69942_prometheus_not_adding_host_url_in_mgr_when_first_enabled

mgr/cephadm: Deploying prometheus service for the first time, does not update PROMETHEUS_API_HOST url under mgr module

Reviewed-by: Adam King <adking@redhat.com>

Merge PR #62303 into main

* refs/pull/62303/head:
test/libcephfs: add missing cleanup

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Christopher Hoffman <choffman@redhat.com>

Merge PR #62406 into main

* refs/pull/62406/head:
client: process path without inode anchor
test/client: add ll_walk test with cwd and root path

Reviewed-by: Dhairya Parmar <dparmar@redhat.com>

Merge pull request #62423 from afreen23/wip-ns-kb

mgr/dashboard: KiB not supported size for namespace creation

Reviewed-by: Afreen Misbah <afreen@ibm.com>

Merge pull request #61727 from Kushal-deb/fix_issue_2330954-RGW_is_not_adding_a_SAN

cephadm: Ensure wildcard SAN is included in RGW self-signed certs

Reviewed-by: Adam King <adking@redhat.com>

Merge pull request #61209 from Kushal-deb/fix_issue-2253832-osd_service_issue

cephadm: link new OSDs to existing managed services

Reviewed-by: Adam King <adking@redhat.com>

Merge pull request #62199 from ShwetaBhosale1/fix_issue_70373_enable_logrotate_timer

cephadm: Enable logroate.timer service in bootstrap process

Reviewed-by: Adam King <adking@redhat.com>

Merge pull request #62485 from zdover23/wip-doc-2025-03-25-cephadm-certmgr

doc/cephadm: format "Configuration" in cephadm.rst

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

doc: update documentation for normalization and case sensitivity

Signed-off-by: Xavi Hernandez <xhernandez@gmail.com>

qa: add tests for case sensitivity configuration on subvolume creation

Signed-off-by: Xavi Hernandez <xhernandez@gmail.com>

pybind/mgr: add option to set case sensitivity to a subvolume

Add an option to explicitly set the case sensitivity of a CephFS
subvolume.

Signed-off-by: Xavi Hernandez <xhernandez@gmail.com>

qa: add tests for normalization configuration on subvolume creation

Signed-off-by: Xavi Hernandez <xhernandez@gmail.com>

pybind/mgr: add option to set unicode normalization to a subvolume

Add an option to explicitly set the unicode normalization form to use on
a CephFS subvolume.

Signed-off-by: Xavi Hernandez <xhernandez@gmail.com>

pybind/mgr: create normalization xattr in subvolumes

When a new subvolume is created, optionally set the
ceph.dir.normalization xattr to the root directory.

Signed-off-by: Xavi Hernandez <xhernandez@gmail.com>

qa: add test for `mgr status` command

Fixes: https://tracker.ceph.com/issues/70571
Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>

Merge pull request #62282 from adk3798/cephadm-ganesha-fix-server-scope

mgr/cephadm: fix Server_Scope in ganesha.conf

Reviewed-by: John Mulligan <jmulligan@redhat.com>

Merge pull request #62329 from NitzanMordhai/wip-nitzan-suite-rados-cephadmn-still-running-ignore

suites/rados/cephadm: add still running warning to the ignore list

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Laura Flores <lflores@ibm.com>
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>

librbd: migrate from boost::variant to std::variant

migrate from boost::variant to std::variant

Complete migration started in commit 017f3339c, replacing boost::variant with
std::variant throughout the librbd codebase. This change is part of our ongoing
effort to reduce third-party dependencies by leveraging C++ standard library
alternatives where possible.

Benefits include:
- Improved code readability and maintainability
- Reduced external dependency surface
- More consistent API usage with other components

Signed-off-by: Kefu Chai <tchaikov@gmail.com>

mgr/dashboard: fix image filter's query on rbd-details grafana panel

The image filter on the RBD Details grafana panel is using a query with a type "label_values(ceph_rbd_read_ops{cluster=~\"$cluster\", , pool=\"$pool\"}, image)". The extra comma needs to be removed.

Fixes: https://tracker.ceph.com/issues/70653
Signed-off-by: Aashish Sharma <aasharma@redhat.com>

common/interval_set: erase() func should be return an iterator

Signed-off-by: Yite Gu <guyite@bytedance.com>

blk/kerneldevice: fix invalid iterator usage after erase in discard_queued traversal

fixes: https://tracker.ceph.com/issues/70636

Signed-off-by: Yite Gu <guyite@bytedance.com>

doc/cephadm: format "Configuration" in cephadm.rst

Improve the formatting in the section "Configuration" in
doc/cephadm/certmgr/cephadm.rst.

Signed-off-by: Zac Dover <zac.dover@proton.me>

mgr/rbd_support: always parse interval and start_time in Schedules::remove()

Commit 1b62447071a9 ("mgr/rbd_support: fix schedule remove") addressed
the issue that it was concerned with in a rather suboptimal way: instead
of moving the parsing of interval and start_time upfront to be able to
bail early, it wrapped from_string() constructors with try/finally and
left the conditional behavior in place.

Fixes: https://tracker.ceph.com/issues/70640
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>

Merge pull request #62411 from rhcs-dashboard/notification-icon-fix

mgr/dashboard: fix notification icon size

Merge pull request #62410 from rhcs-dashboard/custom-pool-dashboard

mgr/dashboard: use existing pools for cephfs vol creation

Merge pull request #62027 from rhcs-dashboard/admin-ops-api-for-rgw-accounts

mgr/dashboard: Use admin ops API for rgw accounts

Merge pull request #62415 from rhcs-dashboard/tenanted-bucket-lifecycle-fix

mgr/dashboard: tenanted bucket lifecycle management fix