add setlayout, setdirlayout, setxattr check_access

Signed-off-by: Jashan Kamboj <jashank42@gmail.com>

add readdir check_access

Signed-off-by: Jashan Kamboj <jashank42@gmail.com>

mds/Server: clean up check_access a bit

Signed-off-by: Sage Weil <sage@redhat.com>

MDSAuthCaps: add logic for group bits check

Signed-off-by: Nishtha Rai <nishtha3rai@gmail.com>

test_auth_caps: add test for user bits

Signed-off-by: Nishtha Rai <nishtha3rai@gmail.com>

mds/MDSAuthCaps: add permissions for user bits

Signed-off-by: Nishtha Rai <nishtha3rai@gmail.com>

Makefile: include ceph-fuse in base target

Signed-off-by: Sage Weil <sage@redhat.com>

client: behave if we can't getattr parents of mount point

If our cap locks us into a subdirectory (e.g., /foo), we will fail to
getattr on its parents (e.g., /).  This is expected.  Tolerate this case,
and warn that quotas may misbehave in that case (if they are set on one of
those parents).

Signed-off-by: Sage Weil <sage@redhat.com>

test_auth_caps: Move trap and cleanup to the top

test_auth_caps: Added test logic for world bits

MDSAuthCaps: add world bits check logic

Signed-off-by: Nishtha Rai <nishtha3rai@gmail.com>

client: pass uid, gid to lookup

The MDS cares about who is performing lookup, too!

Signed-off-by: Sage Weil <sage@redhat.com>

add unlink, rmdir check_access test

Signed-off-by: Jashan Kamboj <jashank42@gmail.com>

add unlink, rmdir check_access

Signed-off-by: Jashan Kamboj <jashank42@gmail.com>

add symlink test

Signed-off-by: Jashan Kamboj <jashank42@gmail.com>

add symlink check_access

Signed-off-by: Jashan Kamboj <jashank42@gmail.com>

Add mknod check_access

Signed-off-by: Jashan Kamboj <jashank42@gmail.com>

qa/workunits/fs/test_path_caps: tolerate existing directories

Signed-off-by: Sage Weil <sage@redhat.com>

functional test of mds cap path restriction

Signed-off-by: Jashan Kamboj <jashank42@gmail.com>

mds/Server.cc: drop leading / from path in is_capable check

Signed-off-by: Jashan Kamboj <jashank42@gmail.com>

unittest_mds_authcap: test lists of allow grants

Signed-off-by: Sage Weil <sage@redhat.com>

mds: mkdir check_access

Signed-off-by: Jashan Kamboj <jashank42@gmail.com>

mds/MDSAuthCaps: fix parse error message

Signed-off-by: Sage Weil <sage@redhat.com>

mds: whitespace

Signed-off-by: Sage Weil <sage@redhat.com>

mds: log to cluster log if mds cap parse fails

It's an admin error; tell an admin.

Signed-off-by: Sage Weil <sage@redhat.com>

mds/MDSAuthCaps: debug is_capable

Signed-off-by: Sage Weil <sage@redhat.com>

mds/MDSAuthCap: fix debug prefix

Signed-off-by: Sage Weil <sage@redhat.com>

mds/MDSAuthCap: drop leading / in paths

Signed-off-by: Sage Weil <sage@redhat.com>

mds/MDSAuthCaps: fix allow_all

Empty path is '', not '/'.

Signed-off-by: Sage Weil <sage@redhat.com>

mds/MDSAuthCaps: add cct for debug context

signed-off-by: Nishtha Rai <nishtha3rai@gmail.com>
Signed-off-by: Sage Weil <sage@redhat.com>

mds: calculate path in check_access()

Signed-off-by: Jashan Kamboj <jashank42@gmail.com>

mds/MDSAuthCaps: normalize path, drop useless constant.

Use an empty string for no path--this is more efficient.  This generalizes
to losing any leading '/' character.

Signed-off-by: Sage Weil <sage@redhat.com>

mds/MDSAuthCaps: pass down inode uid.gid and mode

We will need this to evaluate the unix permissions.

Signed-off-by: Sage Weil <sage@redhat.com>

mds/Server: add a few access checks

(incomplete coverage!)

Signed-off-by: Sage Weil <sage@redhat.com>

mds/Server: add check_access() hook

For now, we are doing a very basic permission check.  No callers yet.

Signed-off-by: Sage Weil <sage@redhat.com>

mds/MDSAuthCap: fix uid and gid types

int64_t for uid, so we can do a negative "none" value.
gid_t (uint32_t) for gid.

Signed-off-by: Sage Weil <sage@redhat.com>

mds/MDSAuthCaps: cosmetic

Signed-off-by: Sage Weil <sage@redhat.com>

mds/MDSAuthCaps: use bitmask for is_capable()

Signed-off-by: Sage Weil <sage@redhat.com>

mds/MDSAuthCap: fix path match

Signed-off-by: Sage Weil <sage@redhat.com>

mds/MDSAuthCaps: move allows() into MDSCapSpec

Also, fix this so that 'any' implies that we can read or write.

Signed-off-by: Sage Weil <sage@redhat.com>

mds/MDSAuthCaps: parse optional gid list

Signed-off-by: Sage Weil <sage@redhat.com>

mds/MDSAuthCaps: whitespace

Signed-off-by: Sage Weil <sage@redhat.com>

Merge pull request #5951 from guangyy/doc-pool

doc: update doc for with new pool settings

Reviewed-by: Loic Dachary <ldachary@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #5853 from branch-predictor/bp-rados-fix-noverify

common/obj_bencher.cc: fix verification crashing when there's no objects

Reviewed-by: Loic Dachary <ldachary@redhat.com>

Merge pull request #6009 from theanalyst/scripts/orig-issue

scripts: release_notes can track original issue

Reviewed-by: Loic Dachary <ldachary@redhat.com>

Merge pull request #5211 from 0003ydlom/smc3

MOSDOp/do_op/handle_op: Simple Messenger optimization

Reviewed-by: Sage Weil <sage@redhat.com>
Reviewed-by: Greg Farnum <gfarnum@redhat.com>
Tested-by: Kefu Chai <kchai@redhat.com>

Merge pull request #6127 from wido/mirror-docs-fixes

docs: Fix styling of newly added mirror docs

Merge pull request #6109 from liewegas/wip-13214

init-rbdmap: fix CMDPARAMS

Reviewed-by: Nathan Cutler <ncutler@suse.com>

init-rbdmap: fix CMDPARAMS

Fixes: #13214
Reported-by: Wyllys Ingersoll <wyllys.ingersoll@keepertech.com>
Signed-off-by: Sage Weil <sage@redhat.com>

docs: Fix styling of newly added mirror docs

cleanup: make the pool setting GET decription point to SET description

Signed-off-by: Guang Yang yguang@yahoo-inc.com

doc: update doc for with new pool settings

Signed-off-by: Guang Yang yguang@yahoo-inc.com

Merge remote-tracking branch 'gh/infernalis'

Merge pull request #6101 from liewegas/wip-fs

os/fs: fix do loop

Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #6103 from SUSE/wip-re-redrop-fdupes

ceph.spec.in: re-re-drop fdupes

Reviewed-by: Boris Ranto <branto@redhat.com>

test/test_rados_tool.sh: implement regression test for bench verify crash

Truncate all objects after format test, then check whether rados bench rand/seq
still works, or just crashes.

Signed-off-by: Piotr Dałek <piotr.dalek@ts.fujitsu.com>

common/obj_bencher.cc: fix verification crashing when there's no objects

When specified pool is empty or doesn't contain valid bench objects, rados
can crash because it attempts to memcmp through NULL pointer. Added check
for valid object size (which also fixes the case when objects are there, but
they're truncated), and made object_size being size_t instead of int.
In seq_read_bench, there's a missing lock.Lock() which causes rados to trigger
assert when object reading fails. Moved lock.Lock() before completion_ret()
call.

Signed-off-by: Piotr Dałek <piotr.dalek@ts.fujitsu.com>

ceph.spec.in: re-re-drop fdupes

The %fdupes call was dropped by 53072b9019caf72e0313b2804ea174237ed7da33
Later, it got accidentally reinstated by ceb93e8e69e125c9358f63b0099e7509b6624bcf

Signed-off-by: Nathan Cutler <ncutler@suse.com>

Merge pull request #6025 from ukernel/wip-13167

journaler: detect unexpected holes in journal objects

Reviewed-by: Greg Farnum <gfarnum@redhat.com>

Merge pull request #5849 from ukernel/wip-32bits-ceph-fuse

Wip 32bits ceph fuse

Reviewed-by: Greg Farnum <gfarnum@redhat.com>

Merge pull request #4791 from ceph/wip-11783

cephfs: detect completed cap flushes

Reviewed-by: Greg Farnum <gfarnum@redhat.com>

Merge pull request #6070 from jcsp/wip-reformat-subtreemaptest

Fix reformatting journals containing SUBTREEMAP_TEST events

Merge pull request #6082 from jcsp/wip-client-quota-roots

Fix quota enforcement on subdir mounts

os/fs: fix aio submit method

continue in a do while(false) will always eval false and break
out.  To repeat, we need while (true) and an explicit break.

Reported-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
Signed-off-by: Sage Weil <sage@redhat.com>

Merge pull request #6078 from H3C/wip-13208

Objecter: maybe access wild pointer(op) in _op_submit_with_budget.

Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #6064 from H3C/wip-rbd-bugfix1

Objecter: misc fix for segmentation fault.

Reviewed-by: Sage Weil <sage@redhat.com>

Merge pull request #6084 from liewegas/wip-revert-scrub

Revert "osd: new pool settings: scrub intervals"

Reviewed-by: Mykola Golub <mgolub@mirantis.com>

Merge pull request #5832 from SUSE/wip-drop-dup-rcceph

ceph.spec.in: refrain from duplicating %{_sbindir}/rcceph

Reviewed-by: Ken Dreyer <kdreyer@redhat.com>

Merge pull request #6098 from liewegas/wip-crash-replay-interval

don't assume crash_replay_itnerval == 45

Reviewed-by: Samuel Just <sjust@redhat.com>

qa/workunits/cephtool/test.sh: don't assume crash_replay_interval=45

e.g., it's 5 in teuthology's ceph.conf.

Signed-off-by: Sage Weil <sage@redhat.com>

Merge pull request #6076 from liewegas/wip-scrub-fix

osd/PG: compensate for sloppy hobject scrub bounds from hammer

Reviewed-by: Kefu Chai <kchai@redhat.com>

MOSDOp::decode : Splitting message decoding, new version

Signed-off-by: Jacek J. Lakis <jacek.lakis@intel.com>

handle_op/do_op: Moving couple of checks from dispatcher to parallelized workers

Signed-off-by: Jacek J. Lakis <jacek.lakis@intel.com>

Merge pull request #6086 from stiopaa1/librados_missingsemicolon

examples/librados/hello_world.cc:missing semicolon

Reviewed-by: Loic Dachary <ldachary@redhat.com>

examples/librados/hello_world.cc:missing semicolon

Signed-off-by: Michal Jarzabek <stiopa@gmail.com>

Merge pull request #6068 from dachary/wip-12936-shec

erasure-code: shec must compare for equality with epsilon

Reviewed-by: Sage Weil <sage@redhat.com>

Merge pull request #6052 from liewegas/wip-13098

osd: fix full request handling

Reviewed-by: Josh Durgin <jdurgin@redhat.com>

Merge pull request #6075 from liewegas/wip-osd-getmap

osd: avoid duplicate MMonGetOSDMap requests

Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #6077 from liewegas/wip-qa

qa: http://ceph.com/qa -> http://download.ceph.com/qa
also some ceph.com/git -> git.ceph.com and a few line-endings - dmick

Reviewed-by: Dan Mick <dmick@redhat.com>

Revert "osd: new pool settings: scrub intervals"

This reverts commit 30810da4b573b3c7e679bc66eaa29b70246538cb.

After some discussion we have decided it is better to build a generic
dictionary in pg_pool_t to store infrequently used per-pool properties.

Signed-off-by: Sage Weil <sage@redhat.com>

Merge pull request #6083 from jcsp/wip-mds-allow-star

ceph-create-keys: set mds "allow *"

Reviewed-by: Greg Farnum <gfarnum@redhat.com>

ceph-create-keys: set mds "allow *"

So that 'tell' works out of the box.

Signed-off-by: John Spray <john.spray@redhat.com>

erasure-code: shec must compare for equality with epsilon

When comparing two double for strict inequality, a test for equality
using epsilon must also be done to ensure the results do not vary cross
platform.

http://tracker.ceph.com/issues/12936 Fixes: #12936

Signed-off-by: Loic Dachary <ldachary@redhat.com>

Merge pull request #5959 from mslovy/wip-current-dev

mon: Fix unnecessary at/near max target warn in ceph -s

Reviewed-by: Sage Weil <sage@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #5356 from majianpeng/code-cleanup

osd: cleanup code when met crc error.

Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #5972 from Jerry7X/master

unsigned type is short for journal max_size,use uint64_t instead

Reviewed-by: Sage Weil <sage@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge remote-tracking branch 'gh/infernalis'

Merge pull request #6048 from XinzeChi/wip-filestore-qlock

filestore: fix peek_queue for OpSequencer

Reviewed-by: Sage Weil <sage@redhat.com>

Merge pull request #6040 from liewegas/wip-mon-kv

mon: some fixes for kv backend failures

Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Joao Eduardo Luis <joao@suse.de>

Merge pull request #6022 from jdurgin/wip-13032

msg: randomize client nonces

Reviewed-by: Sage Weil <sage@redhat.com>

Merge pull request #6012 from liewegas/wip-mon

mon: misc scaling fixes

Reviewed-by: Joao Eduardo Luis <joao@suse.de>
Reviewed-by: Kefu Chai <kchai@redhat.com>

client: fix quote enforcement on subdir mounts

While we don't allow setting quotas on the global
filesystem root, the inode which is root from the
client mount's point of view might have a quota.

Signed-off-by: John Spray <john.spray@redhat.com>

client: refactor quota check functions

Generalise the path traversal into check_quota_condition
and then call that from each of file_exceeded, bytes_exceeded,
bytes_approaching with the appropriate lambda function.

Motivated by fixing the path traversal and wanting to
only fix it in one place.

Signed-off-by: John Spray <john.spray@redhat.com>

Merge pull request #6027 from wido/mirror-docs

docs: Update docs to make it clear that there are mirrors worldwide

Reviewed-by: Kefu Chai <kchai@redhat.com>

Objecter: repeated free op->ontimeout.

repeated free op->ontimeout in SafeTimer::timer_thread::callback->complete

Fixes: #13208
Signed-off-by: Ruifeng Yang <yangruifeng.09209@h3c.com>

Objecter: maybe access wild pointer(op) in _op_submit_with_budget.

look at "after giving up session lock it can be freed at any time by response handler" in _op_submit,
so the _op_submit_with_budget::op maybe is wild after call _op_submit.

Fixes: #13208
Signed-off-by: Ruifeng Yang <yangruifeng.09209@h3c.com>

osd/ReplicatedPG: fix ENOSPC checking

1. We need to return ENOSPC *before* we apply our side-effects to the obc
cache in finish_ctx().

2. Consider object count changes too, not just bytes.

3. Consider cluster full flag, not just the pool flag.

4. Reply only if FULL_TRY; silently drop ops that were sent despite the
full flag.

Fixes: #13098
Signed-off-by: Sage Weil <sage@redhat.com>

osd/osd_types: remove [pool_]last_epoch_marked_full from OSDSuperblock

This is no longer used or needed.

Signed-off-by: Sage Weil <sage@redhat.com>

osd: remove buggy [pool_]last_map_marked_full tracking

This is buggy (we reset the pool epoch each time it remains full instead
of only on the initial transition from non-full to full) and now unused.

Signed-off-by: Sage Weil <sage@redhat.com>

osd: do full check in do_op

1. The current pool_last_map_marked_full tracking is buggy.
2. We need to recheck this each time we consider the op, not just when it
is received off the wire.  Otherwise, we might get a message, queue it
for some reason, get a map indicating the cluster or pool is full, and
then requeue and process the op instead of discarding it.
3. For now, silently drop ops when failsafe check fails. This will lead to
stalled client IO.  This needs a more robust fix.

Signed-off-by: Sage Weil <sage@redhat.com>