Merge pull request #39586 from liewegas/bug-45441

qa/suites/rados/singletone: ignorelist MON_DOWN when injecting msgr errors

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
Reviewed-by: Brad Hubbard <bhubbard@redhat.com>

Merge pull request #39587 from dillaman/wip-test-neorados

cmake: libneoradostest-support should be static

Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #39591 from tchaikov/wip-mgr-diskpred-ann

mgr/diskprediction_local: add typing annotations and cleanups

Reviewed-by: Sebastian Wagner <sebastian.wagner@suse.com>

Merge pull request #39539 from lixiaoy1/enable_pwl

cmake: enable write-back cache in spec

Reviewed-by: Jason Dillaman <dillaman@redhat.com>

Merge pull request #39567 from lixiaoy1/fix_read_ios

librbd/cache/pwl: wait for the completion of reads

Reviewed-by: Jason Dillaman <dillaman@redhat.com>

Merge pull request #39522 from trociny/wip-49284

mgr/rbd_support: mirror snapshot schedule should skip non-primary images

Reviewed-by: Jason Dillaman <dillaman@redhat.com>

Merge pull request #39451 from trociny/wip-49282

librbd: allow disabling journaling for snapshot based mirroring image

Reviewed-by: Jason Dillaman <dillaman@redhat.com>

Merge pull request #39481 from trociny/wip-luks-encryption-test-sudo

qa/workunits/rbd: make luks-encryption test work on vstart cluster

Reviewed-by: Jason Dillaman <dillaman@redhat.com>

Merge PR #39582 into master

* refs/pull/39582/head:
mon: fix INCOMPAT_QUINCY ondisk compatset feature bit

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>

Merge pull request #39590 from tchaikov/wip-49395

ceph.spec.in: s/%cmake/cmake/

Reviewed-by: Jason Dillaman <dillaman@redhat.com>

Merge pull request #39592 from tchaikov/wip-crimson-read-exactly

crimson/net: throw read_eof if short read

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>

crimson/net: throw read_eof if short read

as per the implementation and the document of input_stream::read_exactly():

/// stream and returns them. If the end of stream is reached before n
/// bytes were read, fewer than n bytes will be returned - so despite
/// the method's name, the caller must not assume the returned buffer
/// will always contain exactly n bytes.

Signed-off-by: Kefu Chai <kchai@redhat.com>

mgr/diskprediction_local: add typing annotations

Signed-off-by: Kefu Chai <kchai@redhat.com>

mgr/diskprediction_local: raise if Predictor cannot be initialized

simpler this way.

Signed-off-by: Kefu Chai <kchai@redhat.com>

mgr/diskprediction_local: add Predictor abstract class

to make the interface more explicit, also pave the road to mypy.

Signed-off-by: Kefu Chai <kchai@redhat.com>

mgr/diskprediction_local: drop unused COMMANDS

the base class of `MgrModule` already has it

Signed-off-by: Kefu Chai <kchai@redhat.com>

mgr/diskprediction_local: use "int" for interval options

Signed-off-by: Kefu Chai <kchai@redhat.com>

mgr/diskprediction_local: define options using Option

Signed-off-by: Kefu Chai <kchai@redhat.com>

mgr/diskprediction_local: add to flake8

Signed-off-by: Kefu Chai <kchai@redhat.com>

Merge pull request #39588 from athanatos/sjust/wip-fix-store-nbd

crimson/tools/store-nbd: fix invalid buffer access on connection termination

Reviewed-by: Kefu Chai <kchai@redhat.com>

ceph.spec.in: s/%cmake/cmake/

this change partially reverts da7030db79c5dbd480040eb249a76638caf52707
which use %cmake rpm macro in the place of "cmake". but

%cmake sets BUILD_SHARED_LIBS=ON. so quite a few internal libraries
defined using add_library() are now compiled into shared libraries which
are not installed or packagesd. when we are installing the rpm packages
compiled with this option, rpm compiles because the linked libraries are
missing, for instance, `libgmock.so.1.10.0` was compiled as a static
library before da7030db79c5dbd480040eb249a76638caf52707, and was
included by the test executables. but after that change it's compiled
as a shared library.

so we need to either package the linked shared libraries or just link
against them statically. at this moment, the latter approach is simpler,
albeit larger size of exectuable and dbg symbols.

Fixes: https://tracker.ceph.com/issues/49395
Signed-off-by: Kefu Chai <kchai@redhat.com>

crimson/tools/store-nbd: actually check magic

Signed-off-by: Samuel Just <sjust@redhat.com>

Merge pull request #39573 from weixinwei/master

librbd: memory is not preallocated in rbd c++ read api

Reviewed-by: Jason Dillaman <dillaman@redhat.com>

crimson/tools/store-nbd: check length of buffer

read_exactly does not return an error if the stream
has ended.

Signed-off-by: Samuel Just <sjust@redhat.com>

Merge pull request #39585 from ivancich/wip-clean-rgw-warnings-1

rgw: clean up some compiler warnings

Reviewed-by: Ali Maredia <amaredia@redhat.com>

cmake: libneoradostest-support should be static

Some builds seem to be creating a libneoradostest-support.so dynamic
library instead, which results in unresolved dependencies when installing
ceph-test.

See: https://tracker.ceph.com/issues/38611
Signed-off-by: Jason Dillaman <dillaman@redhat.com>

cmake: enable write-back cache in spec

Signed-off-by: Li, Xiaoyan <xiaoyan.li@intel.com>

qa/suites/rados/singletone: whitelist MON_DOWN when injecting msgr errors

add a 'none.yaml' facet which doesn't whitelist so we hopefully capture
other causes of MON_DOWN.

This fixes at least one source of https://tracker.ceph.com/issues/45441

Fixes: https://tracker.ceph.com/issues/45441
Signed-off-by: Sage Weil <sage@newdream.net>

rgw: clean up some compiler warnings

Minimal changes to clean up a few compiler warnings.

Signed-off-by: J. Eric Ivancich <ivancich@redhat.com>

Merge PR #39561 into master

* refs/pull/39561/head:
qa/valgrind.supp: suppress free[] warnings
qa/suites: do not use notcmalloc flavor

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: Jason Dillaman <dillaman@redhat.com>

mon: fix INCOMPAT_QUINCY ondisk compatset feature bit

This was overlapping with pacific.

Fixes: https://tracker.ceph.com/issues/49143
Signed-off-by: Sage Weil <sage@newdream.net>

Merge pull request #39501 from rhcs-dashboard/fix-tooltip-position

mgr/dashboard: fix tooltip for Provisioned/Total Provisioned fields

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>

Merge PR #38763 into master

* refs/pull/38763/head:
doc/cephfs: improve fs-nfs-exports.rst
doc/cephfs: improve nfs.rst

Reviewed-by: Varsha Rao <varao@redhat.com>
Reviewed-by: Jos Collin <jcollin@redhat.com>

Merge pull request #39575 from zdover23/wip-doc-dev-t8y-intro-remove-upgrade-link-19-Feb-2021

doc/dev: intro: removing ceph-deploy mention

Reviewed-by: Josh Durgin <jdurgin@redhat.com>

Merge pull request #39569 from yanghonggang/wip-multisite-etag-misidentify

rgw: multisite: fix single-part-MPU object etag misidentify problem

Reviewed-by: Casey Bodley <cbodley@redhat.com>

doc/dev: intro: removing ceph-deploy mention

This removes a mention of the ceph-deploy manpage.
We also no longer direct people to use horses as
a primary form of transportation.

Signed-off-by: Zac Dover <zac.dover@gmail.com>

librbd: memory is not preallocated in rbd c++ read api

Signed-off-by: weixinwei <weixw3@lenovo.com>

Merge PR #39566 into master

* refs/pull/39566/head:
cmake: build static libs if they are internal ones

Reviewed-by: Sage Weil <sage@redhat.com>

Merge pull request #39472 from sebastian-philipp/doc-cephadm-host-labels

doc/orch: Host labels

Reviewed-by: Juan Miguel Olmo Martínez <jolmomar@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

Merge pull request #39571 from sebastian-philipp/doc-remove-upstart-from-freebsd

doc/install: Remove Upstart from Freebsd deployment

Reviewed-by: Willem Jan Withagen <wjw@digiware.nl>

Merge pull request #39546 from zdover23/wip-doc-dev-teuthology-intro-suites-inventory-rewrite-18-Feb-2021

doc/dev: t5logy: rewrite "suites inventory"

Reviewed-by: Neha Ojha <nojha@redhat.com>

doc/install: Remove Upstart from Freebsd deployment

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>

Merge pull request #39406 from weixinwei/master

os/bluestore/BlueFS: use iterator_impl::copy instead of bufferlist::c_str() to avoid bufferlist rebuild

Reviewed-by: Igor Fedotov <ifedotov@suse.com>

Merge pull request #39471 from sebastian-philipp/rados-rm-manage-upstart

doc/rados/operations: Remove upstart

Reviewed-by: Brad Hubbard <bhubbard@redhat.com>

Merge pull request #39565 from badone/wip-fix-json-calls

test/osd: Use get_data() to simplify calls

Reviewed-by: Kefu Chai <kchai@redhat.com>

rgw multisite: fix single-part-MPU object etag misidentify problem

The single-part-MPU object is treated as a Atomic object.
Because its part_size is 0.

As MPU object's start_part_num is not 0 which can be used to
distinguish MPU object and Atomic object.

Fixes: https://tracker.ceph.com/issues/49357
Signed-off-by: Yang Honggang <yanghonggang@kuaishou.com>

librbd/cache/pwl: wait for the completion of reads

Shut down PWL after the read IOs are completed.

Signed-off-by: Li, Xiaoyan <xiaoyan.li@intel.com>

cmake: build static libs if they are internal ones

there are chances that user or build script set `BUILD_SHARED_LIBS`,
so these convenience libraries (using the autotools' terminology)
are built and linked by never get installed.

Fixes: https://tracker.ceph.com/issues/38611
Fixes: https://tracker.ceph.com/issues/49080
Signed-off-by: Kefu Chai <kchai@redhat.com>

test/osd: Use get_data() to simplify calls

Signed-off-by: Brad Hubbard <bhubbard@redhat.com>

Merge pull request #39556 from zdover23/wip-doc-dev-t8y-intro-how-integration-tests-are-run-rewrite-2021-Feb-19

doc/dev: t8y intro: edit "how to run int. tests"

Reviewed-by: Josh Durgin <jdurgin@redhat.com>

Merge pull request #39554 from zdover23/wip-doc-dev-t7gy-intro-testing-priority-n-2021-Feb-19

doc/dev: t7gy s/Priority/N/

Reviewed-by: Josh Durgin <jdurgin@redhat.com>

Merge pull request #39293 from mcv21/rgw-admin-error-message

rgw/radosgw-admin clarify error when email address already in use

Merge pull request #38917 from joke-lee/rgw_sts_get_session_token_check_duration_always_failed

rgw: fix sts get_session_token duration check failed

qa/valgrind.supp: suppress free[] warnings

This is apparently not going to get fixed any time soon.

https://github.com/gperftools/gperftools/issues/792

Signed-off-by: Sage Weil <sage@newdream.net>

Merge PR #39304 into master

* refs/pull/39304/head:
qa/tasks/ceph: set ctx.ceph[cluster_name].fsid
qa/tasks/rgw: pass fsid to rgw daemon
qa/suites/upgrade/octopus-x: reenable ragweed
qa/suites/upgarde/octopus-x: rename yaml file

Reviewed-by: Yehuda Sadeh <yehuda@redhat.com>

doc/dev: t8y intro: edit "how to run int. tests"

This PR gives a bit more form to the section called
"how integration tests are run".

Signed-off-by: Zac Dover <zac.dover@gmail.com>

doc/dev: t7gy s/Priority/N/

"N" just looks better in this table than does
"Priority". I've been thinking about this all
day, and I just decided to make this change.

Signed-off-by: Zac Dover <zac.dover@gmail.com>

qa/suites: do not use notcmalloc flavor

teuthology now knows how to run valgrind against a tcmalloc binary

Signed-off-by: Sage Weil <sage@newdream.net>

Merge pull request #39548 from pkubaj/master

crc32c: fix build on ppc64le with clang

Reviewed-by: Kefu Chai <kchai@redhat.com>

crc32c: fix build on ppc64le with clang

Ceph uses assembly files from https://github.com/antonblanchard/crc32-vpmsum
Update them to the newest versions, which fixes build with Clang.

Signed-off-by: Piotr Kubaj <pkubaj@FreeBSD.org>

doc/orch: Host labels

Fixes: https://tracker.ceph.com/issues/45833
Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>

Merge pull request #38881 from ceph/default_images

mgr/cephadm: Put together default container images references

Reviewed-by: Patrick Seidensal <pseidensal@suse.com>
Reviewed-by: Sebastian Wagner <sebastian.wagner@suse.com>

Merge pull request #39330 from sebastian-philipp/orch-rm-apply-funcs

mgr/orch: remove a bunch of duplicated code

Reviewed-by: Michael Fritch <mfritch@suse.com>
Reviewed-by: Varsha Rao <varao@redhat.com>

doc/dev: t5logy: rewrite "suites inventory"

This really just re-organizes this information into
a table. I think tables are easier to read than what
was here before.

Signed-off-by: Zac Dover <zac.dover@gmail.com>

Merge pull request #39542 from tchaikov/wip-devicehealth-flake8

mgr/devicehealth: silence flake8 warnings

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>

Merge pull request #39514 from ceph/fix_buffer_overflow

rgw: fix buffer overflow in s3 select op

Merge pull request #39356 from xxhdx1985126/wip-crimson-client-request-idempotent

crimson/osd: make client_requests idempotent

Reviewed-by: Kefu Chai <kchai@redhat.com>

crimson/osd: make client_requests idempotent

When redoing client requests, they might have already taken effect
on the underlying disk. This commit deals with that situation by
making those requests immediately reply to clients if they are already
done

Signed-off-by: Xuehan Xu <xxhdx1985126@gmail.com>

mgr/devicehealth: silence flake8 warnings

turns out 4840507cfcdd5182003671994d0bc9604d072e3e was racing with
99805d9cff87f7fe264bbadc235cb8cc311fd460. so we failed to identify this
before merging the former.

Signed-off-by: Kefu Chai <kchai@redhat.com>

Merge pull request #39413 from ronen-fr/wip-ronenf-blue-log

os/bluestore: reduce number of wasted checks for low-priority logs

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: Igor Fedotov <ifedotov@suse.com>

Merge pull request #39365 from liewegas/mgr-ssd-used

mgr/devicehealth: extract and present SSD wear %

Reviewed-by: Yaarit Hatuka <yaarithatuka@gmail.com>

Merge pull request #39346 from tchaikov/wip-ipv6-lo

common/ipaddr: Allow binding ipv6 addr on lo

Reviewed-by: Neha Ojha <nojha@redhat.com>

Merge pull request #39374 from tchaikov/wip-ceph-health-newline

mon/Monitor: add newline at end of output "ceph health -f json"

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>

Merge pull request #39391 from tchaikov/wip-mgr-more-flake8

pybind/mgr: add more modules to flake8

Reviewed-by: Sebastian Wagner <sebastian.wagner@suse.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>

Merge pull request #39528 from zdover23/wip-doc-dev-teuthology-intro-testing-priority-2021-Feb-17

doc/dev: intro: rewrite "testing priority"

Reviewed-by: Josh Durgin <jdurgin@redhat.com>

Merge pull request #39516 from rzarzynski/wip-crimson-6threads-in-alienstore

crimson/osd: tune the default for crimson_alien_op_num_threads.

Reviewed-by: Chunmei Liu <chunmei.liu@intel.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #39506 from tchaikov/wip-rpm-multi-thread-xz

ceph.spec.in: use multi-threaded xz compression and cleanups

Reviewed-by: David Galloway <dgallowa@redhat.com>

Merge pull request #39456 from cbodley/wip-qa-rgw-multisite-upgrade

qa/rgw: run multisite tests with mixed cluster versions

Reviewed-by: Yuri Weinstein <yweins@redhat.com>

qa/tasks/ceph: set ctx.ceph[cluster_name].fsid

Signed-off-by: Sage Weil <sage@newdream.net>

qa/tasks/rgw: pass fsid to rgw daemon

Fixes: https://tracker.ceph.com/issues/48754
Signed-off-by: Sage Weil <sage@newdream.net>

qa/suites/upgrade/octopus-x: reenable ragweed

Signed-off-by: Sage Weil <sage@newdream.net>

qa/suites/upgarde/octopus-x: rename yaml file

We're installing octopus, not pacific

Signed-off-by: Sage Weil <sage@newdream.net>

doc/dev: intro: rewrite "testing priority"

This PR improves the English in the "Testing
Priority" section and makes a few structural
changes to make the intent clearer.

Signed-off-by: Zac Dover <zac.dover@gmail.com>

Merge pull request #39363 from rhcs-dashboard/fix-orch-host-e2e

mgr/dashboard: check .badge instead of text for expected label

Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>

Merge PR #38610 into master

* refs/pull/38610/head:
ceph-volume: pass --filter-for-batch from drive-group subcommand

Reviewed-by: Guillaume Abrioux <gabrioux@redhat.com>
Reviewed-by: Rishabh Dave <ridave@redhat.com>

mgr/rbd_support: mirror snapshot schedule should skip non-primary images

And while here, suppress error messages for ENOENT errors.

Fixes: https://tracker.ceph.com/issues/49284
Signed-off-by: Mykola Golub <mgolub@suse.com>

qa/rgw: add pacific-x upgrade suite for multisite

Signed-off-by: Casey Bodley <cbodley@redhat.com>

qa/rgw: add octopus-x upgrade suite for multisite

Signed-off-by: Casey Bodley <cbodley@redhat.com>

qa/rgw: add 'branch' option to rgw-multisite-tests task

Fixes: https://tracker.ceph.com/issues/49330
Signed-off-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #39467 from sebastian-philipp/doc-cephadm-mon-quorum

doc/cephadm: Restoring the MON quorum

Reviewed-by: Juan Miguel Olmo Martínez <jolmomar@redhat.com>

Merge pull request #39496 from liewegas/cephadm-refresh-health-update

mgr/cephadm: fix host refresh

Reviewed-by: Sebastian Wagner <sebastian.wagner@suse.com>

doc/cephfs: improve fs-nfs-exports.rst

Signed-off-by: Rishabh Dave <ridave@redhat.com>

Merge pull request #39372 from rhcs-dashboard/avoid-document-write

mgr/dashboard: avoid using document.write()

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>

Merge pull request #39462 from rhcs-dashboard/fix-alerts-mtuMismatch

mgr/dashboard: fix MTU Mismatch alert

Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>

ceph.spec.in: use %make_install macro

hide buildroot in the implementation of this macro

Signed-off-by: Kefu Chai <kchai@redhat.com>

ceph.spec.in: use %make_build instead of "make"

so we can hide the `_smp_mflags` in `%make_build` macro

Signed-off-by: Kefu Chai <kchai@redhat.com>

ceph.spec.in: use a macro helper to limit number of jobs

so it can work with the rpm macros better.

Signed-off-by: Kefu Chai <kchai@redhat.com>

crimson/osd: tune the default for crimson_alien_op_num_threads.

This commit tries to optimize the default size of AlienStore's
thread pool. Recent testing has shown the intial value, which
is `16`, is far from being optimal while the optimum is close
to `4`:

  https://gist.github.com/rzarzynski/c851212f4b0baef4097a6087533ba17b

Further testing by Mark Nelson suggests that the sweet spot is
closer to `8` taking into account 4 KB writes with lower queue
depths:

  https://docs.google.com/spreadsheets/d/1IR9ysWRkaGdX5e9w_YV8kfeeglR2pEY3V9hovY0ECV8/edit#gid=1884533182

As a kind of compromise `6` is proposed in this commit.

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>

mgr/dashboard: check .badge instead of text for expected label

this change fixes a regression introduced by
8c5e31ec1a13bc53394eb2cb6880d74db169fac4 which broke the 01-hosts.e2e-spec.ts test
driven by test_dashboard_e2e.sh

Fixes: https://tracker.ceph.com/issues/49205
Signed-off-by: Nizamudeen A <nia@redhat.com>

Merge pull request #39464 from sebastian-philipp/doc-cephadm-unmanaged

doc/cephadm: Disable automatic deployment of daemons

Reviewed-by: Juan Miguel Olmo Martínez <jolmomar@redhat.com>
Reviewed-by: Zac Dover <zac.dover@gmail.com>