]> git.apps.os.sepia.ceph.com Git - ceph.git/log
ceph.git
3 years agoCommenting out cpu logic in spec file for testing dgalloway-comment-cpus
David Galloway [Mon, 1 Nov 2021 20:21:12 +0000 (16:21 -0400)]
Commenting out cpu logic in spec file for testing

Signed-off-by: David Galloway <dgallowa@redhat.com>
3 years agoMerge PR #43101 into master
Sage Weil [Mon, 1 Nov 2021 19:27:13 +0000 (15:27 -0400)]
Merge PR #43101 into master

* refs/pull/43101/head:
mgr/rook: implement apply rbd-mirror

Reviewed-by: Juan Miguel Olmo <jolmomar@redhat.com>
3 years agoMerge pull request #43687 from ifed01/wip-ifed-fix-omap-upgrade
Neha Ojha [Mon, 1 Nov 2021 19:13:28 +0000 (12:13 -0700)]
Merge pull request #43687 from ifed01/wip-ifed-fix-omap-upgrade

os/bluestore: fix invalid omap name conversion when upgrading to per-pg.

Reviewed-by: Sage Weil <sage@redhat.com>
Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-By: Neha Ojha <nojha@redhat.com>
3 years agoMerge PR #43296 into master
Patrick Donnelly [Mon, 1 Nov 2021 18:48:06 +0000 (14:48 -0400)]
Merge PR #43296 into master

* refs/pull/43296/head:
mds: improve mds_bal_fragment_size_max config option

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Jeff Layton <jlayton@redhat.com>
3 years agoMerge PR #40514 into master
Patrick Donnelly [Mon, 1 Nov 2021 16:36:21 +0000 (12:36 -0400)]
Merge PR #40514 into master

* refs/pull/40514/head:
cephfs-top: add read/write average io sizes support
cephfs-top: add read/write io speed support
mds: add read/write io size metric support

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
3 years agoMerge PR #43582 into master
Patrick Donnelly [Mon, 1 Nov 2021 16:35:02 +0000 (12:35 -0400)]
Merge PR #43582 into master

* refs/pull/43582/head:
mgr/volumes/fs/operations/versions: fix various flake8 issues

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Varsha Rao <rvarsha016@gmail.com>
3 years agoMerge PR #43590 into master
Patrick Donnelly [Mon, 1 Nov 2021 16:34:14 +0000 (12:34 -0400)]
Merge PR #43590 into master

* refs/pull/43590/head:
qa: test that new mounts of same fs function after old mount is evicted
qa: remove REQUIRE_KCLIENT_REMOTE

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Xiubo Li <xiubli@redhat.com>
3 years agoMerge PR #43595 into master
Patrick Donnelly [Mon, 1 Nov 2021 16:33:06 +0000 (12:33 -0400)]
Merge PR #43595 into master

* refs/pull/43595/head:
client: do not defer releasing caps when revoking

Reviewed-by: Jeff Layton <jlayton@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
3 years agoMerge PR #43717 into master
Patrick Donnelly [Mon, 1 Nov 2021 15:53:20 +0000 (11:53 -0400)]
Merge PR #43717 into master

* refs/pull/43717/head:
script: update ceph-debug-docker for centos:stream

Reviewed-by: Brad Hubbard <bhubbard@redhat.com>
3 years agoMerge pull request #43751 from cbodley/wip-rgw-ops-log-cond
Casey Bodley [Mon, 1 Nov 2021 15:13:26 +0000 (11:13 -0400)]
Merge pull request #43751 from cbodley/wip-rgw-ops-log-cond

rgw: fix debug build of OpsLogFile

Reviewed-by: Cory Snyder <csnyder@iland.com>
Reviewed-by: Willem Jan Withagen <wjw@digiware.nl>
Reviewed-by: Matt Benjamin <mbenjamin@redhat.com>
3 years agoMerge pull request #43647 from adk3798/agent-on-off-tests
Sebastian Wagner [Mon, 1 Nov 2021 14:43:10 +0000 (15:43 +0100)]
Merge pull request #43647 from adk3798/agent-on-off-tests

qa/suites/orch/cephadm: test with agent on/off

Reviewed-by: Sebastian Wagner <sewagner@redhat.com>
3 years agoMerge pull request #43454 from Daniel-Pivonka/cephadm-daemon-postactions-bydaemon
Sebastian Wagner [Mon, 1 Nov 2021 14:27:26 +0000 (15:27 +0100)]
Merge pull request #43454 from Daniel-Pivonka/cephadm-daemon-postactions-bydaemon

mgr/cephadm: track daemon deployment post actions by daemon name instead of type

Reviewed-by: Michael Fritch <mfritch@suse.com>
Reviewed-by: Sebastian Wagner <sewagner@redhat.com>
3 years agoMerge pull request #42838 from Daniel-Pivonka/cephadm-apply-spec-traceback
Sebastian Wagner [Mon, 1 Nov 2021 13:49:02 +0000 (14:49 +0100)]
Merge pull request #42838 from Daniel-Pivonka/cephadm-apply-spec-traceback

cephadm: fix tracebacks that could occur during apply spec

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Dimitri Savineau <dsavinea@redhat.com>
Reviewed-by: Sebastian Wagner <sewagner@redhat.com>
3 years agoMerge pull request #43127 from majianpeng/librbd-pwl-flush-reorder
Deepika Upadhyay [Mon, 1 Nov 2021 07:01:04 +0000 (12:31 +0530)]
Merge pull request #43127 from majianpeng/librbd-pwl-flush-reorder

librbd/cache/pwl: fix reorder when flush cache-data to osd.

Reviewed-by: Deepika Upadhyay <dupadhya@redhat.com>
3 years agoMerge pull request #43749 from tchaikov/wip-seastore-cleanup
Kefu Chai [Mon, 1 Nov 2021 04:39:06 +0000 (12:39 +0800)]
Merge pull request #43749 from tchaikov/wip-seastore-cleanup

crimson/os/seastore: minor cleanups

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
3 years agolibrbd/cache/pwl: fix reorder when flush cache-data to osd. 43127/head
Jianpeng Ma [Mon, 1 Nov 2021 01:25:52 +0000 (09:25 +0800)]
librbd/cache/pwl: fix reorder when flush cache-data to osd.

Consider the following workload:
writeA(0, 4096)
writeB(0, 512).
pwl can makre sure writeA persist to cache before writeB.
But when flush to osd, it use async-read to read data from cache and in
the callback function they issue write to osd.
So although we by order issue aio-read(4096), aio-read(512). But we
can't make sure the return order.
If aio-read(512) firstly return, the write order to next layer is
writeB(0, 512)
writeA(0, 4096).
This is wrong from the user point.

To avoid this occur, we should firstly read all data from cache. And
then send write by order.

Fiexs: https://tracker.ceph.com/issues/52511

Tested-by: Feng Hualong <hualong.feng@intel.com>
Signed-off-by: Jianpeng Ma <jianpeng.ma@intel.com>
3 years agoMerge pull request #43676 from zdover23/wip-doc-2021-10-26-rados-config-storage_devices
zdover23 [Sun, 31 Oct 2021 05:17:33 +0000 (15:17 +1000)]
Merge pull request #43676 from zdover23/wip-doc-2021-10-26-rados-config-storage_devices

doc/rados: storage-devices.rst rewrite

Reviewed-by: Neha Ojha <nojha@redhat.com>
3 years agorgw: fix debug build of OpsLogFile 43751/head
Casey Bodley [Sun, 31 Oct 2021 00:26:21 +0000 (20:26 -0400)]
rgw: fix debug build of OpsLogFile

can't use ceph::mutex locks with std::condition_variable::wait() in
debug builds. use the ceph::condition_variable wrapper instead

Signed-off-by: Casey Bodley <cbodley@redhat.com>
3 years agoMerge PR #43734 into master
Sage Weil [Sat, 30 Oct 2021 19:51:31 +0000 (15:51 -0400)]
Merge PR #43734 into master

* refs/pull/43734/head:
cephadm: --config-json overrides --config or --keyring args

Reviewed-by: Adam King <adking@redhat.com>
3 years agoMerge PR #43743 into master
Sage Weil [Sat, 30 Oct 2021 19:51:04 +0000 (15:51 -0400)]
Merge PR #43743 into master

* refs/pull/43743/head:
mgr/nfs/export: use tool_exec() instead of private _exec()
pybind/mgr/mgr_module: add tool_exec() command

Reviewed-by: Sage Weil <sage@redhat.com>
3 years agoMerge pull request #43654 from adk3798/limit-info
Sebastian Wagner [Sat, 30 Oct 2021 18:47:32 +0000 (20:47 +0200)]
Merge pull request #43654 from adk3798/limit-info

mgr/cephadm: inform users if limit set for data devices is not met

Reviewed-by: Sebastian Wagner <sewagner@redhat.com>
3 years agoMerge pull request #43606 from adk3798/suppress-tls-error
Sebastian Wagner [Sat, 30 Oct 2021 18:46:48 +0000 (20:46 +0200)]
Merge pull request #43606 from adk3798/suppress-tls-error

mgr/cephadm: suppress TLSV1_ALERT_DECRYPT_ERROR from cherrypy

Reviewed-by: Sebastian Wagner <sewagner@redhat.com>
3 years agocrimson/os/seastore: minor cleanups 43749/head
Kefu Chai [Sat, 30 Oct 2021 07:40:40 +0000 (15:40 +0800)]
crimson/os/seastore: minor cleanups

* pass string by reference. more consistent this way.
* set a bl using list::append(), simpler this way.

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
3 years agoMerge pull request #43657 from liu-chunmei/osd_meta_to_file
Samuel Just [Sat, 30 Oct 2021 06:46:24 +0000 (23:46 -0700)]
Merge pull request #43657 from liu-chunmei/osd_meta_to_file

crimson: osd meta read from/write to file.

Reviewed-by: Samuel Just <sjust@redhat.com>
3 years agotest/crimson/seastore/test_transaction_manager_test_state: add mock MDStore 43657/head
Samuel Just [Thu, 28 Oct 2021 09:50:16 +0000 (02:50 -0700)]
test/crimson/seastore/test_transaction_manager_test_state: add mock MDStore

Signed-off-by: Samuel Just <sjust@redhat.com>
3 years agocrimson/os/seastore/seastore: factor out MDStore interface
Samuel Just [Thu, 28 Oct 2021 08:37:13 +0000 (01:37 -0700)]
crimson/os/seastore/seastore: factor out MDStore interface

Signed-off-by: Samuel Just <sjust@redhat.com>
3 years agocrimson: check mkfs_done before seastore do mkfs
chunmei-liu [Wed, 27 Oct 2021 03:23:27 +0000 (20:23 -0700)]
crimson: check mkfs_done before seastore do mkfs

Signed-off-by: chunmei-liu <chunmei.liu@intel.com>
3 years agocrimson: write some other osd metas
chunmei-liu [Sun, 24 Oct 2021 22:06:28 +0000 (15:06 -0700)]
crimson: write some other osd metas

Signed-off-by: chunmei-liu <chunmei.liu@intel.com>
3 years agocrimson: osd meta data read from and write to files
chunmei-liu [Sun, 24 Oct 2021 21:41:32 +0000 (14:41 -0700)]
crimson: osd meta data read from and write to files

Signed-off-by: chunmei-liu <chunmei.liu@intel.com>
3 years agomgr/nfs/export: use tool_exec() instead of private _exec() 43743/head
Sage Weil [Fri, 29 Oct 2021 15:27:50 +0000 (11:27 -0400)]
mgr/nfs/export: use tool_exec() instead of private _exec()

Fixes: https://tracker.ceph.com/issues/53096
Signed-off-by: Sage Weil <sage@newdream.net>
Signed-off-by: Michael Fritch <mfritch@suse.com>
3 years agopybind/mgr/mgr_module: add tool_exec() command
Sage Weil [Thu, 28 Oct 2021 22:11:38 +0000 (18:11 -0400)]
pybind/mgr/mgr_module: add tool_exec() command

Run a (ceph) tool with the appropriate keyring and entity name.

Signed-off-by: Sage Weil <sage@newdream.net>
3 years agoMerge pull request #43625 from alimaredia/wip-marcus-teuthvault-2
Casey Bodley [Fri, 29 Oct 2021 19:14:03 +0000 (15:14 -0400)]
Merge pull request #43625 from alimaredia/wip-marcus-teuthvault-2

qa/rgw: Fix vault token file access.

Reviewed-by: Casey Bodley <cbodley@redhat.com>
3 years agoMerge PR #43736 into master
Sage Weil [Fri, 29 Oct 2021 18:55:02 +0000 (14:55 -0400)]
Merge PR #43736 into master

* refs/pull/43736/head:
Revert "Merge pull request #41325 from rhcs-dashboard/wip-cephadm_box-master"

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Sebastian Wagner <sewagner@redhat.com>
3 years agoMerge pull request #43738 from rishabh-d-dave/mgr-dash-pyfakefs
Ernesto Puerta [Fri, 29 Oct 2021 16:52:44 +0000 (18:52 +0200)]
Merge pull request #43738 from rishabh-d-dave/mgr-dash-pyfakefs

mgr/dashboard: all pyfakefs must be pinned on same version

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: ljflores <NOT@FOUND>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: rishabh-d-dave <NOT@FOUND>
3 years agoMerge pull request #43733 from neha-ojha/wip-fix-octopusx
Yuri Weinstein [Fri, 29 Oct 2021 16:45:37 +0000 (09:45 -0700)]
Merge pull request #43733 from neha-ojha/wip-fix-octopusx

qa/suites/upgrade/octopus-x: exclude ceph-volume

Reviewed-by: Yuri Weinstein <yweinste@redhat.com>
3 years agoMerge pull request #43329 from cfsnyder/wip-48752-generalize-ops-log-socket
Matt Benjamin [Fri, 29 Oct 2021 16:19:59 +0000 (12:19 -0400)]
Merge pull request #43329 from cfsnyder/wip-48752-generalize-ops-log-socket

rgw: add abstraction for ops log destination and add file logger

3 years agomgr/dashboard: all pyfakefs must be pinned on same version 43738/head
Rishabh Dave [Fri, 29 Oct 2021 15:04:12 +0000 (20:34 +0530)]
mgr/dashboard: all pyfakefs must be pinned on same version

Without this patch execution of install-deps.sh fails with an error.

Fixes: https://tracker.ceph.com/issues/53088
Signed-off-by: Rishabh Dave <ridave@redhat.com>
3 years agoRevert "Merge pull request #41325 from rhcs-dashboard/wip-cephadm_box-master" 43736/head
Sage Weil [Fri, 29 Oct 2021 14:53:43 +0000 (09:53 -0500)]
Revert "Merge pull request #41325 from rhcs-dashboard/wip-cephadm_box-master"

This reverts commit 78d6ac0d35e8db037bb0f42935528cc9fecf2d84, reversing
changes made to 9a8de97f7af473a6a773323a463dc6603d7f4d39.

This broke cephadm (infers config when it should not)

Signed-off-by: Sage Weil <sage@newdream.net>
3 years agocephadm: --config-json overrides --config or --keyring args 43734/head
Sage Weil [Fri, 29 Oct 2021 14:49:17 +0000 (09:49 -0500)]
cephadm: --config-json overrides --config or --keyring args

These args aren't normally combined, but if --fsid and --name are
provided, they may be inferred.

Signed-off-by: Sage Weil <sage@newdream.net>
3 years agoMerge pull request #43706 from neha-ojha/wip-doc-corr
Neha Ojha [Fri, 29 Oct 2021 14:34:41 +0000 (07:34 -0700)]
Merge pull request #43706 from neha-ojha/wip-doc-corr

doc/releases/pacific.rst: add note about data corruption bug

Reviewed-by: Igor Fedotov <igor.fedotov@croit.io>
Reviewed-by: Laura Flores <lflores@redhat.com>
3 years agoMerge pull request #43714 from ceph/wip-yuriw-crontab-master
Yuri Weinstein [Fri, 29 Oct 2021 14:15:31 +0000 (07:15 -0700)]
Merge pull request #43714 from ceph/wip-yuriw-crontab-master

qa/tests: added back octopus-x run on master

Reviewed-by: Neha Ojha <nojha@redhat.com>
3 years agoMerge PR #43709 into master
Sage Weil [Fri, 29 Oct 2021 13:54:01 +0000 (09:54 -0400)]
Merge PR #43709 into master

* refs/pull/43709/head:
qa/tasks/cephfs/test_nfs: wait for fs to come up before exporting

Reviewed-by: Sebastian Wagner <sewagner@redhat.com>
3 years agoMerge pull request #43602 from sebastian-philipp/cephadm-rgw-ipv6
Sebastian Wagner [Fri, 29 Oct 2021 10:23:19 +0000 (12:23 +0200)]
Merge pull request #43602 from sebastian-philipp/cephadm-rgw-ipv6

mgr/cephadm: Fix RGW ipv6 frontend configuration

Reviewed-by: Casey Bodley <cbodley@redhat.com>
Reviewed-by: Sage Weil <sage@newdream.net>
3 years agoMerge pull request #43260 from cfsnyder/wip-43692-repave-osds
Sebastian Wagner [Fri, 29 Oct 2021 08:02:11 +0000 (10:02 +0200)]
Merge pull request #43260 from cfsnyder/wip-43692-repave-osds

mgr/orchestrator: add --zap flag to 'orch osd rm'

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Sebastian Wagner <sewagner@redhat.com>
3 years agoscript: update ceph-debug-docker for centos:stream 43717/head
Patrick Donnelly [Fri, 29 Oct 2021 02:13:50 +0000 (22:13 -0400)]
script: update ceph-debug-docker for centos:stream

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
3 years agoMerge pull request #43539 from orozery/ms-nocrc
Samuel Just [Fri, 29 Oct 2021 01:37:26 +0000 (18:37 -0700)]
Merge pull request #43539 from orozery/ms-nocrc

msg/async: support disabling data crc for protocol v2

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Reviewed-by: Chunmei Liu <chunmei.liu@intel.com>
Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
3 years agoqa/tests: added pacific-x suite to run on master 43714/head
Yuri Weinstein [Thu, 28 Oct 2021 23:11:50 +0000 (16:11 -0700)]
qa/tests: added pacific-x suite to run on master

Signed-off-by: Yuri Weinstein <yweinste@redhat.com>
3 years agoMerge pull request #31877 from rosinL/wip-fix-dpdk-link
Kefu Chai [Thu, 28 Oct 2021 22:58:20 +0000 (06:58 +0800)]
Merge pull request #31877 from rosinL/wip-fix-dpdk-link

cmake: link against DPDK shared libraries to avoid DPDK EAL double initialization

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
3 years agoqa/suites/upgrade/octopus-x: exclude ceph-volume 43733/head
Neha Ojha [Thu, 28 Oct 2021 22:26:34 +0000 (22:26 +0000)]
qa/suites/upgrade/octopus-x: exclude ceph-volume

To fix failure like

Failure Reason:
Command failed on smithi085 with status 1: 'sudo yum -y install ceph-volume'

Signed-off-by: Neha Ojha <nojha@redhat.com>
3 years agoMerge pull request #43693 from batrick/i53074
Sebastian Wagner [Thu, 28 Oct 2021 22:25:59 +0000 (00:25 +0200)]
Merge pull request #43693 from batrick/i53074

pybind/mgr/cephadm: upgrade MDS if no MDS is "up"

Reviewed-by: Sebastian Wagner <sewagner@redhat.com>
3 years agoMerge pull request #43293 from pcuzner/granular-alerts
Sebastian Wagner [Thu, 28 Oct 2021 22:23:24 +0000 (00:23 +0200)]
Merge pull request #43293 from pcuzner/granular-alerts

mgr/prometheus: expose ceph healthchecks as metrics

Reviewed-by: Boris Ranto <branto@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Sebastian Wagner <sewagner@redhat.com>
3 years agoqa/tests: added back octopus-x run on master
Yuri Weinstein [Thu, 28 Oct 2021 22:13:04 +0000 (15:13 -0700)]
qa/tests: added back octopus-x run on master

Signed-off-by: Yuri Weinstein <yweinste@redhat.com>
3 years agoMerge PR #43583 into master
Sage Weil [Thu, 28 Oct 2021 20:13:32 +0000 (16:13 -0400)]
Merge PR #43583 into master

* refs/pull/43583/head:
changes to logging code requested by Adam
remove allocation file after rollback to real-fm
bug-fix close db when umount failed to store allocation file
Bug-Fix: When restoring allocation from file use a temp allocator and only copy the allocation to the shared-allocator after the file was verified and all extents were cleared

Reviewed-by: Adam Kupczyk <akucpzyk@redhat.com>
3 years agoMerge PR #43645 into master
Sage Weil [Thu, 28 Oct 2021 20:12:36 +0000 (16:12 -0400)]
Merge PR #43645 into master

* refs/pull/43645/head:
os/bluestore: Disable compaction then no-column-b is storing allocations to bluefs file

Reviewed-by: Igor Fedotov <ifedotov@suse.com>
Reviewed-by: Gabriel Benhanokh <gbenhano@redhat.com>
3 years agomgr/rook: implement apply rbd-mirror 43101/head
Joseph Sawaya [Wed, 8 Sep 2021 13:36:26 +0000 (09:36 -0400)]
mgr/rook: implement apply rbd-mirror

This commit implements `orch apply rbd-mirror` in the rook orchestrator,
it creates a CR with a default name if the service_id isn't specified in
the spec, else it sets the name of the CR to the service_id in the spec.
This commit also adds `orch apply rbd-mirror` to the rook QA. This commit
also implements `orch rm rbd-mirror`.

Signed-off-by: Joseph Sawaya <jsawaya@redhat.com>
3 years agoFix vault token file access. 43625/head
Marcus Watts [Fri, 17 Sep 2021 09:28:53 +0000 (05:28 -0400)]
Fix vault token file access.

Put the vault token file in a location that ceph can read.
Make it readable only by ceph.

On rhel8 (and indeed, any vanilla rhel machine), $HOME is liable to be
mode 700.  This means the ceph user can't read things in that user's
directory.  This causes radosgw to emit the confusing message "ERROR:
Vault token file ... not found" even though the teuthology log will
plainly show it was created and made readable by ceph.

Fixes: http://tracker.ceph.com/issues/51539
Signed-off-by: Marcus Watts <mwatts@redhat.com>
3 years agoqa/tasks/cephfs/test_nfs: wait for fs to come up before exporting 43709/head
Sage Weil [Thu, 28 Oct 2021 15:23:21 +0000 (11:23 -0400)]
qa/tasks/cephfs/test_nfs: wait for fs to come up before exporting

Signed-off-by: Sage Weil <sage@newdream.net>
3 years agodoc/releases/pacific.rst: add note about data corruption bug 43706/head
Neha Ojha [Thu, 28 Oct 2021 16:56:13 +0000 (16:56 +0000)]
doc/releases/pacific.rst: add note about data corruption bug

Warn users upgrading their clusters from nautilus/octopus to pacific about
https://tracker.ceph.com/issues/53062

Signed-off-by: Neha Ojha <nojha@redhat.com>
3 years agoMerge pull request #41325 from rhcs-dashboard/wip-cephadm_box-master
Ernesto Puerta [Thu, 28 Oct 2021 14:59:47 +0000 (16:59 +0200)]
Merge pull request #41325 from rhcs-dashboard/wip-cephadm_box-master

cephadm: add cephadm sandbox (Docker in Docker)

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Guillaume Abrioux <gabrioux@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
Reviewed-by: sebastian-philipp <NOT@FOUND>
3 years agoMerge pull request #43692 from liewegas/misc-rook-1
Sebastian Wagner [Thu, 28 Oct 2021 14:56:23 +0000 (16:56 +0200)]
Merge pull request #43692 from liewegas/misc-rook-1

mgr/orchestrator: log exception from wrapper

Reviewed-by: Sebastian Wagner <sewagner@redhat.com>
3 years agomgr/cephadm: unit test for daemon post actions missing in cache 43454/head
Daniel Pivonka [Tue, 26 Oct 2021 19:39:17 +0000 (15:39 -0400)]
mgr/cephadm: unit test for daemon post actions missing in cache

Signed-off-by: Daniel Pivonka <dpivonka@redhat.com>
3 years agoMerge pull request #43330 from sebastian-philipp/CEPHADM_STRAY_DAEMON
Sebastian Wagner [Thu, 28 Oct 2021 13:05:58 +0000 (15:05 +0200)]
Merge pull request #43330 from sebastian-philipp/CEPHADM_STRAY_DAEMON

doc/cephadm/operations: extend CEPHADM_STRAY_DAEMON

Reviewed-by: Adam King <adking@redhat.com>
3 years agoos/bluestore: fix invalid omap name conversion when upgrading to per-pg. 43687/head
Igor Fedotov [Wed, 27 Oct 2021 10:59:34 +0000 (13:59 +0300)]
os/bluestore: fix invalid omap name conversion when upgrading to per-pg.

Fixes: https://tracker.ceph.com/issues/53062
Signed-off-by: Igor Fedotov <igor.fedotov@croit.io>
3 years agotest/store_test: add a UT for omap format upgrade.
Igor Fedotov [Wed, 27 Oct 2021 15:58:52 +0000 (18:58 +0300)]
test/store_test: add a UT for omap format upgrade.

Signed-off-by: Igor Fedotov <igor.fedotov@croit.io>
3 years agoos/bluestore: permit legacy omap naming scheme in mkfs.
Igor Fedotov [Tue, 9 Feb 2021 15:37:41 +0000 (18:37 +0300)]
os/bluestore: permit legacy omap naming scheme in mkfs.

Primarily for debug purposes...

Signed-off-by: Igor Fedotov <ifedotov@suse.com>
3 years agoMerge pull request #43601 from sebastian-philipp/doc-cephadm-osd-similar-disk-layout
Sebastian Wagner [Thu, 28 Oct 2021 10:14:57 +0000 (12:14 +0200)]
Merge pull request #43601 from sebastian-philipp/doc-cephadm-osd-similar-disk-layout

doc/cephadm: improve "Deploying OSDs on multiple similar hosts"

Reviewed-by: Joao Eduardo Luis <joao@suse.com>
Reviewed-by: Michael Fritch <mfritch@suse.com>
3 years agoMerge pull request #43622 from Daniel-Pivonka/cephadm-doc-osd-replace-host
Sebastian Wagner [Thu, 28 Oct 2021 10:13:23 +0000 (12:13 +0200)]
Merge pull request #43622 from Daniel-Pivonka/cephadm-doc-osd-replace-host

doc/cephadm: note that replacment osd needs to be on same host as removed osd

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Michael Fritch <mfritch@suse.com>
3 years agoMerge pull request #43681 from cyx1231st/wip-seastore-fix-test-setup-teardown
Samuel Just [Thu, 28 Oct 2021 10:11:05 +0000 (03:11 -0700)]
Merge pull request #43681 from cyx1231st/wip-seastore-fix-test-setup-teardown

crimson/os/seastore: initialize tests in seastar reactor

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Chunmei Liu <chunmei.liu@intel.com>
3 years agocephadm/box: add no-tmpfs flag prepare osd bluestore 41325/head
Pere Diaz Bou [Wed, 27 Oct 2021 11:20:04 +0000 (13:20 +0200)]
cephadm/box: add no-tmpfs flag prepare osd bluestore

Signed-off-by: Pere Diaz Bou <pdiazbou@redhat.com>
3 years agopybind/mgr/cephadm: upgrade MDS if no MDS is "up" 43693/head
Patrick Donnelly [Thu, 28 Oct 2021 00:26:55 +0000 (20:26 -0400)]
pybind/mgr/cephadm: upgrade MDS if no MDS is "up"

The upgrade process can get stuck if an MDS crashes. This should be rare
when straddling v16.2.5 where the compatset of the file system inherits
the FSMap "default". The MDS from pre-v16.2.5 do not yet share a
compatset with the mons so the mons will do no promotions, causing
upgrade task to get stuck.

Fixes: https://tracker.ceph.com/issues/53074
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
3 years agoMerge pull request #43689 from rzarzynski/wip-auth-drop-get_supported_con_modes
Kefu Chai [Thu, 28 Oct 2021 00:25:06 +0000 (08:25 +0800)]
Merge pull request #43689 from rzarzynski/wip-auth-drop-get_supported_con_modes

auth: drop unused get_supported_con_modes() from AuthServer.

Reviewed-by: Kefu Chai <tchaikov@gmail.com>
3 years agomgr/orchestrator: log exception from wrapper 43692/head
Sage Weil [Fri, 15 Oct 2021 15:44:59 +0000 (10:44 -0500)]
mgr/orchestrator: log exception from wrapper

This lets us see a proper traceback when we are calling across
modules.

Signed-off-by: Sage Weil <sage@newdream.net>
3 years agoauth: drop unused get_supported_con_modes() from AuthServer. 43689/head
Radoslaw Zarzynski [Wed, 27 Oct 2021 16:04:11 +0000 (16:04 +0000)]
auth: drop unused get_supported_con_modes() from AuthServer.

In 2d530938753313a776258ff9fa8208db637c9d96 its last user has
been removed.

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
3 years agoqa/suites/orch/cephadm: test with agent on/off 43647/head
Adam King [Wed, 27 Oct 2021 14:56:23 +0000 (10:56 -0400)]
qa/suites/orch/cephadm: test with agent on/off

Signed-off-by: Adam King <adking@redhat.com>
3 years agoMerge pull request #43684 from ybwang0211/doc-host
zdover23 [Wed, 27 Oct 2021 14:26:17 +0000 (00:26 +1000)]
Merge pull request #43684 from ybwang0211/doc-host

doc: The description of "Host" on the page is inconsistent

Signed-off-by: wangyingbin ybwang0211@163.com
Reviewed-by: Zac Dover <zac.dover@gmail.com>
3 years agodoc/rados: storage-devices.rst rewrite 43676/head
Zac Dover [Tue, 26 Oct 2021 18:14:53 +0000 (04:14 +1000)]
doc/rados: storage-devices.rst rewrite

This commit is a minor improvement to the
English syntax of storage-devices.rst.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
3 years agoMerge pull request #43581 from cbodley/wip-52800
J. Eric Ivancich [Wed, 27 Oct 2021 13:33:08 +0000 (09:33 -0400)]
Merge pull request #43581 from cbodley/wip-52800

rgw: fix lock scope in ObjectCache::get()

Reviewed-by: Adam C. Emerson <aemerson@redhat.com>
3 years agoMerge pull request #43170 from thotz/removeusercaps-in-modifyuser
J. Eric Ivancich [Wed, 27 Oct 2021 13:31:12 +0000 (09:31 -0400)]
Merge pull request #43170 from thotz/removeusercaps-in-modifyuser

rgw: remove dead code for user-caps from RGWOp_User_Modify

Reviewed-by: Casey Bodley <cbodley@redhat.com>
3 years agoMerge pull request #43153 from ivancich/wip-add-bucket-listing-log
J. Eric Ivancich [Wed, 27 Oct 2021 13:30:22 +0000 (09:30 -0400)]
Merge pull request #43153 from ivancich/wip-add-bucket-listing-log

rgw: add logging to bucket listing so calls are better understood

Reviewed-by: Adam C. Emerson <aemerson@redhat.com>
Reviewed-by: Ali Maredia <amaredia@redhat.com>
3 years agoMerge pull request #42704 from wzbxqt327/patch-1
J. Eric Ivancich [Wed, 27 Oct 2021 13:28:47 +0000 (09:28 -0400)]
Merge pull request #42704 from wzbxqt327/patch-1

rgw,doc: fix command problem

Reviewed-by: Pritha Srivastava <prsrivas@redhat.com>
Reviewed-by: Casey Bodley <cbodley@redhat.com>
3 years agoMerge pull request #41323 from pkalever/cookie
Mykola Golub [Wed, 27 Oct 2021 12:44:16 +0000 (15:44 +0300)]
Merge pull request #41323 from pkalever/cookie

rbd-nbd: generate and send device cookie with netlink connect request

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
Reviewed-by: Mykola Golub <mgolub@suse.com>
3 years agoMerge pull request #43584 from rhcs-dashboard/add-multiple-hosts-at-once
Ernesto Puerta [Wed, 27 Oct 2021 12:41:35 +0000 (14:41 +0200)]
Merge pull request #43584 from rhcs-dashboard/add-multiple-hosts-at-once

mgr/dashboard: Cluster Creation Add multiple hosts at once

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
3 years agoMerge pull request #43605 from rhcs-dashboard/bonding-metrics
Ernesto Puerta [Wed, 27 Oct 2021 12:00:29 +0000 (14:00 +0200)]
Merge pull request #43605 from rhcs-dashboard/bonding-metrics

monitoring: ethernet bonding filter in Network Load.

Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
3 years agoMerge pull request #43603 from rhcs-dashboard/fix-gather-facts-fetch-UI
Ernesto Puerta [Wed, 27 Oct 2021 11:18:52 +0000 (13:18 +0200)]
Merge pull request #43603 from rhcs-dashboard/fix-gather-facts-fetch-UI

mgr/dashboard: fetch host facts only if get_facts orch feature available

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
3 years agoMerge pull request #43661 from rhcs-dashboard/review-page-fix
Ernesto Puerta [Wed, 27 Oct 2021 10:23:04 +0000 (12:23 +0200)]
Merge pull request #43661 from rhcs-dashboard/review-page-fix

mgr/dashboard: Cluster expansion review page minor bug fixes

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
3 years agocrimson/os/seastore: initialize tests in seastar reactor 43681/head
Yingxin Cheng [Wed, 27 Oct 2021 06:39:10 +0000 (14:39 +0800)]
crimson/os/seastore: initialize tests in seastar reactor

testing::Test from gtest is constructed and destructed outside seastar
application. It is unexpected for most seastore components, and causing
undefined behaviors.

For example, when registering metrics during construction, the logic
needs to be called inside seastar reactor thread because metrics are
maintained in reactor thread-local variables.

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
3 years agocrimson/os/seastore: cleanup transaction_manager_test_state
Yingxin Cheng [Wed, 27 Oct 2021 06:37:54 +0000 (14:37 +0800)]
crimson/os/seastore: cleanup transaction_manager_test_state

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
3 years agocrimson/os/seastore/randomblock-manager: cleanup unit test
Yingxin Cheng [Wed, 27 Oct 2021 06:33:41 +0000 (14:33 +0800)]
crimson/os/seastore/randomblock-manager: cleanup unit test

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
3 years agocrimson/os/seastore/cache: get block-size from reader
Yingxin Cheng [Mon, 25 Oct 2021 08:39:29 +0000 (16:39 +0800)]
crimson/os/seastore/cache: get block-size from reader

Cache cannot get the correct block size before SegmentManager is
mounted.

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
3 years agocrimson/os/seastore/store-nbd: cleanup headers
Yingxin Cheng [Wed, 27 Oct 2021 06:23:02 +0000 (14:23 +0800)]
crimson/os/seastore/store-nbd: cleanup headers

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
3 years agocrimson/os/seastore/journal: proper close journal when test finishes
Yingxin Cheng [Tue, 26 Oct 2021 06:19:33 +0000 (14:19 +0800)]
crimson/os/seastore/journal: proper close journal when test finishes

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
3 years agodoc: The description of "Host" on the page is inconsistent 43684/head
wangyingbin [Wed, 27 Oct 2021 07:44:19 +0000 (15:44 +0800)]
doc: The description of "Host" on the page is inconsistent

In the "https://docs.ceph.com/en/latest/radosgw/adminops/#radosgw-admin-ops" page, the description of "Host" is not uniform, so I changed it.

Signed-off-by: wangyingbin <ybwang0211@163.com>
3 years agomonitoring: ethernet bonding filter in Network Load 43605/head
Pere Diaz Bou [Thu, 21 Oct 2021 09:14:29 +0000 (11:14 +0200)]
monitoring: ethernet bonding filter in Network Load

Signed-off-by: Pere Diaz Bou <pdiazbou@redhat.com>
3 years agoMerge pull request #43630 from kkang-wr/master
Kefu Chai [Wed, 27 Oct 2021 01:26:05 +0000 (09:26 +0800)]
Merge pull request #43630 from kkang-wr/master

cmake: add support for python 3.10

Reviewed-by: Kefu Chai <tchaikov@gmail.com>
3 years agoMerge pull request #43648 from rzarzynski/wip-crimson-proper-addrs-for-hbmsgrs
Kefu Chai [Wed, 27 Oct 2021 01:09:01 +0000 (09:09 +0800)]
Merge pull request #43648 from rzarzynski/wip-crimson-proper-addrs-for-hbmsgrs

crimson/osd: fix network address selection for hearbeat's messengers.

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
Reviewed-by: Chunmei Liu <chunmei.liu@intel.com>
3 years agoMerge pull request #43671 from javicacheiro/python_data_as_binary
Kefu Chai [Wed, 27 Oct 2021 01:04:18 +0000 (09:04 +0800)]
Merge pull request #43671 from javicacheiro/python_data_as_binary

doc/rbd: correct sample code to use byte string for data

Reviewed-by: Kefu Chai <tchaikov@gmail.com>
3 years agoMerge pull request #43674 from rzarzynski/wip-crimson-net-honor_listen_type
Kefu Chai [Wed, 27 Oct 2021 01:01:44 +0000 (09:01 +0800)]
Merge pull request #43674 from rzarzynski/wip-crimson-net-honor_listen_type

crimson/net: FixedCPUServerSocket::accept() respects the listening addr's type.

Reviewed-by: Kefu Chai <tchaikov@gmail.com>
3 years agomgr/prometheus: remove cmake tests 43293/head
Paul Cuzner [Tue, 26 Oct 2021 20:58:17 +0000 (09:58 +1300)]
mgr/prometheus: remove cmake tests

Temporary removal of the cmake test integration

Signed-off-by: Paul Cuzner <pcuzner@redhat.com>
3 years agocrimson/net: FixedCPUServerSocket::accept() respects the listening addr's type. 43674/head
Radoslaw Zarzynski [Tue, 26 Oct 2021 18:03:31 +0000 (18:03 +0000)]
crimson/net: FixedCPUServerSocket::accept() respects the listening addr's type.

For the sake of compliance with the classical OSD where the type
of the listening address is being reflected in the address type
of an accepted connection:

```
int PosixServerSocketImpl::accept(ConnectedSocket *sock, const SocketOptions &opt, entity_addr_t *out, Worker *w) {
  // ...
  sockaddr_storage ss;
  // ...
  int sd = accept_cloexec(_fd, (sockaddr*)&ss, &slen);
  if (sd < 0) {
    return -ceph_sock_errno();
  }

  // ...

  out->set_type(addr_type);
  out->set_sockaddr((sockaddr*)&ss);
  handler.set_priority(sd, opt.priority, out->get_family());
}
```

In Rook crimson binds explicitly to v2 address:

```
INFO  2021-10-26 17:55:08,116 [shard 0] osd - picked address v2:0.0.0.0:0/0
ERROR 2021-10-26 17:55:08,116 [shard 0] none - Falling back to public interface
INFO  2021-10-26 17:55:08,116 [shard 0] osd - picked address v2:0.0.0.0:0/0
```

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
3 years agoMerge PR #43627 into master
Sage Weil [Tue, 26 Oct 2021 17:18:41 +0000 (13:18 -0400)]
Merge PR #43627 into master

* refs/pull/43627/head:
Revert "Merge pull request #42099 from aclamk/wip-bluefs-fine-grain-locking-2"

Reviewed-by: Neha Ojha <nojha@redhat.com>