]> git.apps.os.sepia.ceph.com Git - ceph.git/log
ceph.git
2 months agomgr/dashboard: fix Input field goes black after selecting an input from browser history issue/70720/input--field-goes-black
Sulochan Khadka [Mon, 7 Apr 2025 11:57:46 +0000 (17:27 +0530)]
mgr/dashboard: fix Input field goes black after selecting an input from browser history

This commit fixes the input field going black on selecting the input from browser history and the abrupt change of background color and font color. The fix includes fixing it with adding css input:-webkit-autofill,
input:-webkit-autofill:hover,
input:-webkit-autofill:focus,
input:-webkit-autofill:active {
  transition: background-color 5000s ease-in-out 0s;
}
Fixes: https://tracker.ceph.com/issues/70720
Signed-off-by: Sulochan Khadka <sulochankhadka25@gmail.com>
Co-authored-by: Afreen Misbah <afreen@ibm.com>
2 months agoMerge pull request #63301 from zdover23/wip-doc-2025-05-15-mgr-dashboard-62782-followup
Anthony D'Atri [Thu, 15 May 2025 15:45:54 +0000 (11:45 -0400)]
Merge pull request #63301 from zdover23/wip-doc-2025-05-15-mgr-dashboard-62782-followup

doc/mgr: edit dashboard.rst

2 months agoMerge pull request #61637 from Matan-B/wip-matanb-cmake-rel
Matan Breizman [Thu, 15 May 2025 13:38:02 +0000 (16:38 +0300)]
Merge pull request #61637 from Matan-B/wip-matanb-cmake-rel

CMakeLists: Fallback to RelWithDebInfo

Reviewed-by: Radosław Zarzyński <rzarzyns@redhat.com>
2 months agodoc/mgr: edit dashboard.rst 63301/head
Zac Dover [Thu, 15 May 2025 13:24:58 +0000 (23:24 +1000)]
doc/mgr: edit dashboard.rst

Edit doc/mgr/crash.rst. Add prompts.

This changes eighty-nine prompts. Because this makes so many changes,
all other edits included in https://github.com/ceph/ceph/pull/63255 will
be made in a separate commit. This done for the sake of the patience of
the reviewers (probably Anthony, if history is any guide).

This commit is part of a project to separate out the twenty-five files
that were committed to https://github.com/ceph/ceph/pull/63255.

Signed-off-by: Zac Dover <zac.dover@proton.me>
2 months agoMerge pull request #63256 from zdover23/wip-doc-2025-05-13-dev-cephfs-mirroring-63237...
Zac Dover [Thu, 15 May 2025 12:59:59 +0000 (22:59 +1000)]
Merge pull request #63256 from zdover23/wip-doc-2025-05-13-dev-cephfs-mirroring-63237-followup-1-of-x

doc/dev/cephfs-mirroring: edit file 1 of x

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2 months agoMerge pull request #63163 from bluikko/doc-dynreshard-cosmetic-radosgw
Anthony D'Atri [Thu, 15 May 2025 07:28:54 +0000 (03:28 -0400)]
Merge pull request #63163 from bluikko/doc-dynreshard-cosmetic-radosgw

doc/radosgw: Cosmetic improvements in dynamicresharding.rst

2 months agoMerge pull request #62926 from ankitk18/add/size-input
afreen23 [Thu, 15 May 2025 06:33:45 +0000 (12:03 +0530)]
Merge pull request #62926 from ankitk18/add/size-input

mgr/dashboard:Added a dropdown menu for all size inputs.

Reviewed-by: Afreen Misbah <afreen@ibm.com>
2 months agodoc/radosgw: Cosmetic improvements in dynamicresharding.rst 63163/head
Ville Ojamo [Wed, 7 May 2025 09:48:24 +0000 (16:48 +0700)]
doc/radosgw: Cosmetic improvements in dynamicresharding.rst

Make reference to config section a hyperlink.

Capitalization consistency: use title case in section titles, fix two
invalid capitalizations in text.

Promptify CLI example commands.

A JSON key-value pair is a "property" and not an "object".

Use an ordered list instead of inline code with hardcoded list numbers.

Use the American "canceled" (majority of occurrences in doc/) instead of
"cancelled".

Use admonitions instead of spelling out "Note:".
Clarify language on sharding cleanup for multisite.

Format JSON keys as inline code.

Indent example JSON output from radosgw-admin correctly (same as real
output) with 4 spaces.

Use colon instead of full stop at the end of text that describes the
following example command. Move admonition to after such example
command.

Signed-off-by: Ville Ojamo <14869000+bluikko@users.noreply.github.com>
2 months agoMerge pull request #63226 from Matan-B/wip-matanb-crimson-thrash-stale-osdmaps
Matan Breizman [Wed, 14 May 2025 07:58:35 +0000 (10:58 +0300)]
Merge pull request #63226 from Matan-B/wip-matanb-crimson-thrash-stale-osdmaps

qa/suites/crimson-rados: disable chance_trim_stale_osdmaps

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
2 months agodoc/dev/cephfs-mirroring: edit file 1 of x 63256/head
Zac Dover [Tue, 13 May 2025 06:31:42 +0000 (16:31 +1000)]
doc/dev/cephfs-mirroring: edit file 1 of x

Add prompts (and perform necessary corrections to glaring grammatical
errors) to doc/dev/cephfs-mirroring.rst, as requested by Jos Collin in https://github.com/ceph/ceph/pull/63237/files#r2085886075.

This commit edits the first quarter of the doc/dev/cephfs-mirroring.rst
file. This commit encompasses about one-hundred lines of RST.

Signed-off-by: Zac Dover <zac.dover@proton.me>
2 months agoMerge PR #63221 into main
Patrick Donnelly [Tue, 13 May 2025 15:35:19 +0000 (11:35 -0400)]
Merge PR #63221 into main

* refs/pull/63221/head:
script: ignore main branch when cleaning ci

Reviewed-by: Casey Bodley <cbodley@redhat.com>
Reviewed-by: John Mulligan <jmulligan@redhat.com>
2 months agoMerge pull request #63255 from zdover23/wip-doc-2025-05-13-mgr-crash-62782-followup
Anthony D'Atri [Tue, 13 May 2025 14:07:09 +0000 (10:07 -0400)]
Merge pull request #63255 from zdover23/wip-doc-2025-05-13-mgr-crash-62782-followup

doc/mgr: edit crash.rst

2 months agoMerge pull request #63259 from zdover23/wip-doc-2025-05-13-dev-cephfs-mirroring-63237...
Anthony D'Atri [Tue, 13 May 2025 14:05:26 +0000 (10:05 -0400)]
Merge pull request #63259 from zdover23/wip-doc-2025-05-13-dev-cephfs-mirroring-63237-followup-2-of-x

doc/dev/cephfs-mirroring: edit file 2 of x

2 months agoMerge pull request #63253 from zdover23/wip-doc-2025-05-13-monitoring-index
Anthony D'Atri [Tue, 13 May 2025 14:03:11 +0000 (10:03 -0400)]
Merge pull request #63253 from zdover23/wip-doc-2025-05-13-monitoring-index

doc/monitoring: correct list formatting

2 months agoMerge pull request #63254 from zdover23/wip-doc-2025-05-13-cephfs-link-fix
Anthony D'Atri [Tue, 13 May 2025 14:01:43 +0000 (10:01 -0400)]
Merge pull request #63254 from zdover23/wip-doc-2025-05-13-cephfs-link-fix

doc/cephfs: correct reference structure in fs-volumes.rst

2 months agoMerge pull request #63252 from zdover23/wip-doc-2025-05-13-mgr-dashboard-prompt-corre...
Anthony D'Atri [Tue, 13 May 2025 14:01:04 +0000 (10:01 -0400)]
Merge pull request #63252 from zdover23/wip-doc-2025-05-13-mgr-dashboard-prompt-correction

doc/mgr/dashboard: s/promt/prompt/ in dashboard.rst.

2 months agoMerge pull request #63233 from Matan-B/wip-matanb-crimson-error-reply
Matan Breizman [Tue, 13 May 2025 13:01:52 +0000 (16:01 +0300)]
Merge pull request #63233 from Matan-B/wip-matanb-crimson-error-reply

crimson/osd/pg: set log_entry_update_waiting_on prior to sending requests

Reviewed-by: Samuel Just <sjust@redhat.com>
2 months agoMerge PR #63194 into main
Venky Shankar [Tue, 13 May 2025 12:58:44 +0000 (18:28 +0530)]
Merge PR #63194 into main

* refs/pull/63194/head:
tools/cephfs/first-damage: default conf if CEPH_CONF not set

Reviewed-by: Patrick Donnelly <pdonnell@ibm.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: John Mulligan <jmulligan@redhat.com>
2 months agoMerge pull request #62841 from cloudbehl/grafana-application-overview
afreen23 [Tue, 13 May 2025 12:27:57 +0000 (17:57 +0530)]
Merge pull request #62841 from cloudbehl/grafana-application-overview

mgr/dashboard: Add application overview page to grafana

Reviewed-by: Afreen Misbah <afreen@ibm.com>
Reviewed-by: Aashish Sharma <aasharma@redhat.com>
2 months agoMerge PR #62025 into main
Venky Shankar [Tue, 13 May 2025 10:21:10 +0000 (15:51 +0530)]
Merge PR #62025 into main

* refs/pull/62025/head:
client: disallow unprivileged users to escalate root privileges

Reviewed-by: Milind Changire <mchangir@redhat.com>
2 months agomgr/dashboard: Add application overview page to grafana 62841/head
Ankush Behl [Wed, 16 Apr 2025 07:53:57 +0000 (13:23 +0530)]
mgr/dashboard: Add application overview page to grafana

fixes: https://tracker.ceph.com/issues/70944

Signed-off-by: Ankush Behl <cloudbehl@gmail.com>
2 months agoMerge pull request #63231 from rhcs-dashboard/skip-cephfs-tests
Nizamudeen A [Tue, 13 May 2025 07:08:24 +0000 (12:38 +0530)]
Merge pull request #63231 from rhcs-dashboard/skip-cephfs-tests

qa/tests: skipping test_cephfs_clients_get_after_mds_down in test_cephfs

2 months agoqa/suites/crimson-rados: disable chance_trim_stale_osdmaps 63226/head
Matan Breizman [Mon, 12 May 2025 08:23:39 +0000 (08:23 +0000)]
qa/suites/crimson-rados: disable chance_trim_stale_osdmaps

Avoid "no valid command" in teuthology logs.
trim stale osdmaps is not planned to be introduce soon:
See: https://tracker.ceph.com/issues/65288

Signed-off-by: Matan Breizman <mbreizma@redhat.com>
2 months agodoc/dev/cephfs-mirroring: edit file 2 of x 63259/head
Zac Dover [Tue, 13 May 2025 06:58:39 +0000 (16:58 +1000)]
doc/dev/cephfs-mirroring: edit file 2 of x

Add prompts (and perform necessary corrections to glaring grammatical
errors) to doc/dev/cephfs-mirroring.rst, as requested by Jos Collin in
https://github.com/ceph/ceph/pull/63237/files#r2085886075.

This commit edits the second quarter of the doc/dev/cephfs-mirroring.rst
file. This commit encompasses about one-hundred lines of RST.

Signed-off-by: Zac Dover <zac.dover@proton.me>
2 months agodoc/mgr: edit crash.rst 63255/head
Zac Dover [Tue, 13 May 2025 06:17:39 +0000 (16:17 +1000)]
doc/mgr: edit crash.rst

Edit doc/mgr/crash.rst. Add prompts and correct some of the inelegant
English present in the file.

This commit is part of a project to separate out the twenty-five files
that were committed to https://github.com/ceph/ceph/pull/62782.

Credit for this initiative should go to Ville Ojamo.

Signed-off-by: Zac Dover <zac.dover@proton.me>
2 months agodoc/cephfs: correct reference structure in fs-volumes.rst 63254/head
Zac Dover [Tue, 13 May 2025 05:58:57 +0000 (15:58 +1000)]
doc/cephfs: correct reference structure in fs-volumes.rst

Correct the links to cross-references in the cases of the following two
directives:

1. pause-clone-threads
2. pause-purge-threads

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit e59364f152847eabbedfe7fc72dfb66e7378b72b)

2 months agodoc/monitoring: correct list formatting 63253/head
Zac Dover [Tue, 13 May 2025 05:30:07 +0000 (15:30 +1000)]
doc/monitoring: correct list formatting

Correct list formatting in doc/monitoring/index.rst.

Signed-off-by: Zac Dover <zac.dover@proton.me>
2 months agoMerge pull request #63039 from afreen23/update-transifex-tool
afreen23 [Tue, 13 May 2025 05:25:46 +0000 (10:55 +0530)]
Merge pull request #63039 from afreen23/update-transifex-tool

mgr/dashboard: deprecate `transifex-i18ntool` and support transifex cli

Reviewed-by: Nizamudeen A <nia@redhat.com>
2 months agodoc/mgr/dashboard: s/promt/prompt/ in dashboard.rst. 63252/head
Zac Dover [Tue, 13 May 2025 05:18:51 +0000 (15:18 +1000)]
doc/mgr/dashboard: s/promt/prompt/ in dashboard.rst.

res ipsa loquitur

Signed-off-by: Zac Dover <zac.dover@proton.me>
2 months agoMerge pull request #63183 from ronen-fr/wip-rf-pool-max
Ronen Friedman [Tue, 13 May 2025 05:17:32 +0000 (08:17 +0300)]
Merge pull request #63183 from ronen-fr/wip-rf-pool-max

osd/scrub: fix deadline calculations

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2 months agoMerge pull request #63237 from joscollin/wip-dev-doc-allign
Zac Dover [Tue, 13 May 2025 05:10:05 +0000 (15:10 +1000)]
Merge pull request #63237 from joscollin/wip-dev-doc-allign

doc: fix formatting in cephfs_mirror dev doc

Reviewed-by: Zac Dover <zac.dover@proton.me>
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2 months agoMerge pull request #63174 from afreen23/fix-nvme-combobox
afreen23 [Mon, 12 May 2025 19:00:11 +0000 (00:30 +0530)]
Merge pull request #63174 from afreen23/fix-nvme-combobox

mgr/dashboard: Add default state when gateway groups are empty

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Ankush Behl <cloudbehl@gmail.com>
Reviewed-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
2 months agoMerge pull request #63165 from afreen23/fix-listener
afreen23 [Mon, 12 May 2025 18:53:48 +0000 (00:23 +0530)]
Merge pull request #63165 from afreen23/fix-listener

mgr/dashboard: Fix delete listener

Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
2 months agoMerge pull request #63137 from athanatos/sjust/wip-vstart-crimson-pin-71096
Samuel Just [Mon, 12 May 2025 17:08:05 +0000 (10:08 -0700)]
Merge pull request #63137 from athanatos/sjust/wip-vstart-crimson-pin-71096

crimson: simplify vstart crimson-osd reactor pinning

Reviewed-by: Jose Juan Palacios-Perez <perezjos@uk.ibm.com>
Reviewed-by: Matan Breizman <mbreizma@redhat.com>
2 months agoMerge pull request #63138 from athanatos/sjust/wip-crimson-perf-defaults
Samuel Just [Mon, 12 May 2025 16:59:26 +0000 (09:59 -0700)]
Merge pull request #63138 from athanatos/sjust/wip-crimson-perf-defaults

crimson: bump defaults to be more appropriate

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
Reviewed-by: Matan Breizman <mbreizma@redhat.com>
2 months agoMerge pull request #63215 from athanatos/sjust/wip-cancel-pglog-recovery-70337
Samuel Just [Mon, 12 May 2025 16:56:58 +0000 (09:56 -0700)]
Merge pull request #63215 from athanatos/sjust/wip-cancel-pglog-recovery-70337

crimson/osd/pg_recovery: only reset_pglog_based_recovery_op if complete

Reviewed-by: Matan Breizman <mbreizma@redhat.com>
2 months agomgr/dashboard: Fix delete listener 63165/head
Afreen Misbah [Tue, 6 May 2025 14:27:03 +0000 (19:57 +0530)]
mgr/dashboard: Fix delete listener

- pass gw_group to delete API in frontend
- when more than one gw groups present delete listener failing with error message: Multiple NVMe-oF gateway groups are configured. Please specify the 'gw_group' parameter in the request.
- added missing types, i18n

Fixes https://tracker.ceph.com/issues/71236

Signed-off-by: Afreen Misbah <afreen@ibm.com>
2 months agomgr/dashboard: Add default state when gateway groups are empty 63174/head
Afreen Misbah [Thu, 8 May 2025 04:09:59 +0000 (09:39 +0530)]
mgr/dashboard: Add default state when gateway groups are empty

Fixes https://tracker.ceph.com/issues/71247

- after upgrades the nvmeof service spec does not contain `group` field
- this causes UI combobox internal errors
- checking for `group` in spec and disabling the selector

Signed-off-by: Afreen Misbah <afreen@ibm.com>
2 months agoMerge PR #62250 into main
Venky Shankar [Mon, 12 May 2025 13:02:40 +0000 (18:32 +0530)]
Merge PR #62250 into main

* refs/pull/62250/head:
qa/cephfs: increase data to be delay data sync by mirror daemon
cephfs-mirror: integrate blockdiff API for regular file transfers
mds: dout snapdiff snapid's before validation check
cephfs-mirror: current sync mechanism uses sync mechanism subclass'ing
qa: add test for syncing already existing snapshots
cephfs_mirror: avoid latest changes on the source fs to enable mirroring

Reviewed-by: Jos Collin <jcollin@redhat.com>
2 months agoMerge PR #62414 into main
Venky Shankar [Mon, 12 May 2025 13:01:14 +0000 (18:31 +0530)]
Merge PR #62414 into main

* refs/pull/62414/head:
mds: introduce BLOCKDIFF feature bit

Reviewed-by: Dhairya Parmar <dparmar@redhat.com>
2 months agodoc: fix formatting in cephfs_mirror dev doc 63237/head
Jos Collin [Mon, 12 May 2025 12:42:36 +0000 (18:12 +0530)]
doc: fix formatting in cephfs_mirror dev doc

Signed-off-by: Jos Collin <jcollin@redhat.com>
2 months agocrimson/osd/../client_request: add logs around get_obc stage 63233/head
Matan Breizman [Mon, 12 May 2025 11:16:26 +0000 (11:16 +0000)]
crimson/osd/../client_request: add logs around get_obc stage

If this stage is in use by other operation we would keep waiting for it
to finish. Add logs before entering the stage and after to keep track of
stuck requests.

Signed-off-by: Matan Breizman <mbreizma@redhat.com>
2 months agocrimson/osd/pg: set log_entry_update_waiting_on prior to sending requests
Matan Breizman [Mon, 12 May 2025 11:14:47 +0000 (11:14 +0000)]
crimson/osd/pg: set log_entry_update_waiting_on prior to sending requests

Before this patch, we would first send the MOSDPGUpdateLogMissing to
all peers and only then insert this rep_tid to log_entry_update_waiting_on.

This could have resulted in race where we receive the reply prior to
actually inserting the rep_tid.
The reply would have been discarded with "reply on unknown tid" (which
is now aborting).
The unhandled reply would have not let submit_error to return and would
keep holding the lock on this obc.

Fixes: https://tracker.ceph.com/issues/71204
Signed-off-by: Matan Breizman <mbreizma@redhat.com>
2 months agoqa/tests: skipping test_cephfs_clients_get_after_mds_down in test_cephfs 63231/head
Nizamudeen A [Mon, 12 May 2025 10:02:07 +0000 (15:32 +0530)]
qa/tests: skipping test_cephfs_clients_get_after_mds_down in test_cephfs

Skipping this in all PRs except the dashboard

Fixes: https://tracker.ceph.com/issues/70791
Signed-off-by: Nizamudeen A <nia@redhat.com>
2 months agoMerge pull request #63209 from bluikko/doc-vault-cosmetic-radosgw
Zac Dover [Mon, 12 May 2025 09:11:21 +0000 (19:11 +1000)]
Merge pull request #63209 from bluikko/doc-vault-cosmetic-radosgw

doc/radosgw: Cosmetic and formatting improvements in vault.rst

Reviewed-by: Zac Dover <zac.dover@proton.me>
2 months agomgr/dashboard: deprecate `transifex-i18ntool` and support transifex cli 63039/head
Afreen Misbah [Tue, 29 Apr 2025 10:47:37 +0000 (16:17 +0530)]
mgr/dashboard: deprecate `transifex-i18ntool` and support transifex cli

- transifex-i18ntool is no longer maintained
- transifex officialy supports now a tool https://github.com/transifex/cli
- doc update

Fixes https://tracker.ceph.com/issues/71127

Signed-off-by: Afreen Misbah <afreen@ibm.com>
2 months agoMerge pull request #63175 from rhcs-dashboard/multisite-sync-status-alignment
afreen23 [Mon, 12 May 2025 07:25:04 +0000 (12:55 +0530)]
Merge pull request #63175 from rhcs-dashboard/multisite-sync-status-alignment

mgr/dashboard: Multi-site-sync-status UI distortion for status in data sync

Reviewed-by: Afreen Misbah <afreen@ibm.com>
Reviewed-by: Aashish Sharma <aasharma@redhat.com>
2 months agodoc/radosgw: Cosmetic and formatting improvements in vault.rst 63209/head
Ville Ojamo [Fri, 9 May 2025 10:15:02 +0000 (17:15 +0700)]
doc/radosgw: Cosmetic and formatting improvements in vault.rst

Use generated "contents" instead of repeating section titles in an
ordered list.

Use Title Case for section titles.

Capitalize consistently "Ceph" and "Object Gateway", "Vault".

Use consistently all caps for acronyms.

Change one entry of "kms" to "SSE-KMS", seems obvious from the context.
Use "certificates" instead of "certs".

Use double backticks for file paths, commands, config options etc.

Improve language in one sentence, several words missing.

Call it consistently "the Object Gateway" and not sometimes "the
Gateway".

Add pre-formatted block for CLI command examples where missing (should
be promptified in the future).

Signed-off-by: Ville Ojamo <14869000+bluikko@users.noreply.github.com>
2 months agoMerge pull request #63127 from rishabh-d-dave/vols-snappath-v1-and-legacy
Rishabh Dave [Mon, 12 May 2025 05:51:14 +0000 (11:21 +0530)]
Merge pull request #63127 from rishabh-d-dave/vols-snappath-v1-and-legacy

mgr/vol: make "snapshot getpath" cmd work with v1 and legacy

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
2 months agoMerge pull request #63145 from tchaikov/no-using-std
Kefu Chai [Mon, 12 May 2025 03:59:20 +0000 (11:59 +0800)]
Merge pull request #63145 from tchaikov/no-using-std

tools/ceph_dedup: remove 'using namespace std'

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
Reviewed-by: Myoungwon Oh <myoungwon.oh@samsung.com>
2 months agoMerge pull request #62969 from zhscn/fix-cache-lru-size-metric
Yingxin Cheng [Mon, 12 May 2025 02:02:40 +0000 (10:02 +0800)]
Merge pull request #62969 from zhscn/fix-cache-lru-size-metric

crimson/os/seastore/cache/LRU: account the empty extent when adding it to LRU

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
Reviewed-by: Samuel Just <sjust@redhat.com>
2 months agoscript: ignore main branch when cleaning ci 63221/head
Patrick Donnelly [Mon, 12 May 2025 01:41:41 +0000 (21:41 -0400)]
script: ignore main branch when cleaning ci

Addresses failures like:

     Deleting refs: refs/heads/main refs/heads/wip-athakkar-testing-2025-02-11-1344 refs/heads/wip-choffman-fscrypt-021225 refs/heads/wip-dang-68336 refs/heads/wip-leonidc-7_1_hotfix refs/heads/wip-nia-testing-2025-02-12-0101 refs/heads/wip-nitzan-gil-perf-count-and-contention-detect refs/heads/wip-rf-perf-sections refs/heads/wip-sseshasa-test-stuck-backfill-squid-feb11-2024 refs/heads/wip-sseshasa-test-stuck-backfill-squid-feb12-2024 refs/heads/wip-yuri8-testing-2025-02-10-2350
    To https://github.com/ceph/ceph-ci
     - [deleted]           wip-athakkar-testing-2025-02-11-1344
     - [deleted]           wip-choffman-fscrypt-021225
     - [deleted]           wip-dang-68336
     - [deleted]           wip-leonidc-7_1_hotfix
     - [deleted]           wip-nia-testing-2025-02-12-0101
     - [deleted]           wip-nitzan-gil-perf-count-and-contention-detect
     - [deleted]           wip-rf-perf-sections
     - [deleted]           wip-sseshasa-test-stuck-backfill-squid-feb11-2024
     - [deleted]           wip-sseshasa-test-stuck-backfill-squid-feb12-2024
     - [deleted]           wip-yuri8-testing-2025-02-10-2350
     ! [remote rejected]   main (refusing to delete the current branch: refs/heads/main)
    error: failed to push some refs to 'https://github.com/ceph/ceph-ci'
    Error: Process completed with exit code 1.

Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>
2 months agoqa/standalone/scrub: no 'deadline' checks in osd-scrub-test.sh 63183/head
Ronen Friedman [Sun, 11 May 2025 12:22:58 +0000 (07:22 -0500)]
qa/standalone/scrub: no 'deadline' checks in osd-scrub-test.sh

As the 'deadline' attribute was removed from the scrub jobs.

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
2 months agoosd/scrub: remove the 'deadline' attribute from the scrub job
Ronen Friedman [Sun, 11 May 2025 05:24:33 +0000 (00:24 -0500)]
osd/scrub: remove the 'deadline' attribute from the scrub job

The scrub job's 'overdue' attribute is no longer calculated -
the only 'scrub is overdue' status remaining after latest
scheduling refactor, is the one performed in PGMap.cc (the
one affecting the 'health warning' status of the cluster).
Thus - there is no longer any reason to maintain any 'deadline'
attribute for the scrub scheduler.

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
2 months agoosd/scrub: remove the deep-scrubs deadline attribute
Ronen Friedman [Fri, 9 May 2025 12:46:26 +0000 (07:46 -0500)]
osd/scrub: remove the deep-scrubs deadline attribute

As it is no longer meaningful in the context of the new
scrub scheduling design.

The change mandates fixes to the way 'schedule-[deeps]crub'
commands are implemented. The offset to use when forcing the
last-scrub timestamp to a new value in now calculated in
ScrubJob::guaranteed_offset(), as ScrubJob is where all
schedule adjustments (which employ the same logic) are
implemented.

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
2 months agocrimson/osd/pg_recovery: only reset_pglog_based_recovery_op if complete 63215/head
Samuel Just [Fri, 9 May 2025 16:46:48 +0000 (16:46 +0000)]
crimson/osd/pg_recovery: only reset_pglog_based_recovery_op if complete

ce4e9aaad, as part of the start_recovery_ops changed the call to
reset_pglog_based_recovery_op to occur unconditionally rather than only
if recovery has completed.

Note, this fix only restores the prior behavior.  There's actually still
a race here where a DeferRecovery could be processed between the call to
reset_pglog_based_recovery_op and the RequestBackfill or
AllReplicasRecovered being processed.

Introduced: ce4e9aaad8f2cafae24511fe1687c61dc41affc1
Related: https://tracker.ceph.com/issues/71267
Fixes: https://tracker.ceph.com/issues/70337
Signed-off-by: Samuel Just <sjust@redhat.com>
2 months agotools/ceph_dedup: remove 'using namespace std' 63145/head
Kefu Chai [Wed, 7 May 2025 01:09:00 +0000 (09:09 +0800)]
tools/ceph_dedup: remove 'using namespace std'

Remove 'using namespace std' from common.h to maintain consistent coding
practices. Although common.h is only used by ceph_dedup implementation,
keeping namespace declarations out of header files prevents potential
name conflicts and follows best practices for C++ code organization.

This change improves code clarity and reduces the risk of symbol collisions
when standard library elements are used alongside custom
implementations.

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
2 months agoMerge pull request #63143 from ceph/wip-retrigger-rtd2
David Galloway [Fri, 9 May 2025 13:42:50 +0000 (09:42 -0400)]
Merge pull request #63143 from ceph/wip-retrigger-rtd2

.github: Fix RTD build retrigger

2 months agoMerge pull request #63203 from bluikko/doc-archsync-ref-radosgw
Anthony D'Atri [Fri, 9 May 2025 12:29:24 +0000 (08:29 -0400)]
Merge pull request #63203 from bluikko/doc-archsync-ref-radosgw

doc/radosgw: Use ref for hyperlink in archive-sync-module.rst

2 months agoMerge pull request #63205 from bluikko/doc-group-a-ref-radosgw
Anthony D'Atri [Fri, 9 May 2025 12:26:35 +0000 (08:26 -0400)]
Merge pull request #63205 from bluikko/doc-group-a-ref-radosgw

doc/radosgw: Use ref for hyperlinks, 1st batch

2 months agoMerge pull request #63084 from zdover23/wip-doc-2025-05-01-mgr-administrator-62782...
Zac Dover [Fri, 9 May 2025 08:26:06 +0000 (18:26 +1000)]
Merge pull request #63084 from zdover23/wip-doc-2025-05-01-mgr-administrator-62782-followup

doc/mgr: edit administrator.rst

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2 months agodoc/radosgw: Use ref for hyperlinks, 1st batch 63205/head
Ville Ojamo [Fri, 9 May 2025 08:17:00 +0000 (15:17 +0700)]
doc/radosgw: Use ref for hyperlinks, 1st batch

Use validated ":ref:" hyperlinks instead of "external links" in "target
definitions" when linking within the Ceph docs:
- Add a label at beginning of referenced files if missing.
- Remove unused "target definitions".

The rendered PR should look the same as the old docs, only differing in
the source RST.

Signed-off-by: Ville Ojamo <14869000+bluikko@users.noreply.github.com>
2 months agodoc/radosgw: Use ref for hyperlink in archive-sync-module.rst 63203/head
Ville Ojamo [Fri, 9 May 2025 07:06:44 +0000 (14:06 +0700)]
doc/radosgw: Use ref for hyperlink in archive-sync-module.rst

Use validated ":ref:" hyperlinks instead of "external links" in "target
definitions" when linking within the Ceph docs.

Signed-off-by: Ville Ojamo <14869000+bluikko@users.noreply.github.com>
2 months agoMerge pull request #63173 from zdover23/wip-doc-2025-05-08-mgr-alerts-62782-followup
Zac Dover [Fri, 9 May 2025 05:25:09 +0000 (15:25 +1000)]
Merge pull request #63173 from zdover23/wip-doc-2025-05-08-mgr-alerts-62782-followup

doc/mgr: edit alerts.rst

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2 months agoMerge pull request #63172 from zdover23/wip-doc-2025-05-08-mgr-ceph-api-index-62782...
Zac Dover [Fri, 9 May 2025 05:18:42 +0000 (15:18 +1000)]
Merge pull request #63172 from zdover23/wip-doc-2025-05-08-mgr-ceph-api-index-62782-followup

doc/mgr/ceph_api: edit index.rst

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2 months agotools/cephfs/first-damage: default conf if CEPH_CONF not set 63194/head
Dan van der Ster [Fri, 9 May 2025 02:46:02 +0000 (19:46 -0700)]
tools/cephfs/first-damage: default conf if CEPH_CONF not set

If $CEPH_CONF isn't set, you get:

unable to get monitor info from DNS SRV with service name: ceph-mon
2025-05-08T22:40:06.091-0400 7f604286f1c0 -1 failed for service _ceph-mon._tcp
2025-05-08T22:40:06.091-0400 7f604286f1c0 -1 monclient: get_monmap_and_config cannot identify monitors to contact
Traceback (most recent call last):
  File "/root/first-damage.py", line 144, in <module>
    R.connect()
  File "rados.pyx", line 690, in rados.Rados.connect
rados.ObjectNotFound: [errno 2] RADOS object not found (error connecting to the cluster)

Make it default to /etc/ceph/ceph.conf if the env isn't set.

Signed-off-by: Dan van der Ster <dan.vanderster@clyso.com>
2 months agotools/contrib: remove balance_cpu and helpers 63137/head
Samuel Just [Thu, 1 May 2025 19:13:48 +0000 (19:13 +0000)]
tools/contrib: remove balance_cpu and helpers

Replaced by assign_crimson_cores.

Signed-off-by: Samuel Just <sjust@redhat.com>
2 months agovstart.sh: simplify crimson core assignment, use assign_crimson_cores.py
Samuel Just [Thu, 24 Apr 2025 22:13:04 +0000 (15:13 -0700)]
vstart.sh: simplify crimson core assignment, use assign_crimson_cores.py

This commit simplifies the internal flow in a few ways:
- core assignment is entirely handled by prep_balance_cpu and
  do_balance_cpu.  The latter simply does as the cpu_table
  instructs.
- assign_crimson_cores calls lscpu and taskset internally, no
  need for temp files.

It also changes some defaults:
- if crimson-balance-cpu is unset or set to none, crimson-osd will not
  pin cpus at all rather than using the simple sequential allocation
  scheme, which could be much less efficient on platforms where
  cpuids 0,1,2,3,... are on socket 0,1,2,3,...  "osd" and "socket"
  options provide numa aware assignments when requested.

New features:
- Alienstore cores are now assigned with assign_crimson_cores
  using the same balance strategy using
  --crimson-alien-num-cores.
- --crimson-reactor-physical-only and
  --crimson-alienstore-physical-only will cause reactor or
  alienstore cpus respectively to be allocated with one
  cpu per physical core rather than including smt siblings.

Fixes: https://tracker.ceph.com/issues/71096
Signed-off-by: Samuel Just <sjust@redhat.com>
2 months agoMerge pull request #63103 from jdurgin/wip-crimson-gen-state-diagram
Josh Durgin [Thu, 8 May 2025 22:32:01 +0000 (15:32 -0700)]
Merge pull request #63103 from jdurgin/wip-crimson-gen-state-diagram

doc/script/gen_state_diagram.py: adapt for crimson BackfillMachine

Reviewed-by: Matan Breizman <mbreizma@redhat.com>
2 months agoqa/cephfs: increase data to be delay data sync by mirror daemon 62250/head
Venky Shankar [Fri, 21 Mar 2025 17:09:58 +0000 (22:39 +0530)]
qa/cephfs: increase data to be delay data sync by mirror daemon

Signed-off-by: Venky Shankar <vshankar@redhat.com>
2 months agocephfs-mirror: integrate blockdiff API for regular file transfers
Venky Shankar [Fri, 28 Feb 2025 04:57:46 +0000 (04:57 +0000)]
cephfs-mirror: integrate blockdiff API for regular file transfers

Fixes: http://tracker.ceph.com/issues/70225
Signed-off-by: Venky Shankar <vshankar@redhat.com>
2 months agomds: dout snapdiff snapid's before validation check
Venky Shankar [Wed, 12 Mar 2025 05:11:57 +0000 (05:11 +0000)]
mds: dout snapdiff snapid's before validation check

As a debug aid when the snapdiff request is erroring out.

Signed-off-by: Venky Shankar <vshankar@redhat.com>
2 months agocephfs-mirror: current sync mechanism uses sync mechanism subclass'ing
Jos Collin [Thu, 30 Jan 2025 12:02:30 +0000 (17:32 +0530)]
cephfs-mirror: current sync mechanism uses sync mechanism subclass'ing

Fixes: https://tracker.ceph.com/issues/69671
Signed-off-by: Jos Collin <jcollin@redhat.com>
Signed-off-by: Venky Shankar <vshankar@redhat.com>
2 months agoqa: add test for syncing already existing snapshots
Jos Collin [Tue, 28 Jan 2025 11:07:39 +0000 (16:37 +0530)]
qa: add test for syncing already existing snapshots

Fixes: https://tracker.ceph.com/issues/68567
Signed-off-by: Jos Collin <jcollin@redhat.com>
2 months agocephfs_mirror: avoid latest changes on the source fs to enable mirroring
Jos Collin [Mon, 27 Jan 2025 12:42:34 +0000 (18:12 +0530)]
cephfs_mirror: avoid latest changes on the source fs to enable mirroring

This avoids considering latest changes from the source filesystem for
the mirroring of already existing snapshots. Thus the destination
filesystem and snapshots would be created based only on the source snapshots.
The destination fs would be a replica of the last snapshot taken.

Fixes: https://tracker.ceph.com/issues/68567
Signed-off-by: Jos Collin <jcollin@redhat.com>
2 months agomds: introduce BLOCKDIFF feature bit 62414/head
Venky Shankar [Thu, 20 Mar 2025 13:27:08 +0000 (13:27 +0000)]
mds: introduce BLOCKDIFF feature bit

Fixes: http://tracker.ceph.com/issues/70584
Signed-off-by: Venky Shankar <vshankar@redhat.com>
2 months agoclient: disallow unprivileged users to escalate root privileges 62025/head
Xiubo Li [Wed, 3 Apr 2024 11:02:08 +0000 (19:02 +0800)]
client: disallow unprivileged users to escalate root privileges

An unprivileged user can `chmod 777` a directory owned by root
and gain access. Fix this bug and also add a test case for the
same.

Signed-off-by: Xiubo Li <xiubli@redhat.com>
Signed-off-by: Venky Shankar <vshankar@redhat.com>
2 months agoMerge pull request #63126 from rhcs-dashboard/rgw-site-test-skip
Ernesto Puerta [Thu, 8 May 2025 20:48:51 +0000 (22:48 +0200)]
Merge pull request #63126 from rhcs-dashboard/rgw-site-test-skip

qa/tests: skip rgw site tests in api

2 months agocrimson: bump seastore_max_concurrent_transactions size from 8->128, clarify description 63138/head
Samuel Just [Fri, 25 Apr 2025 17:42:49 +0000 (17:42 +0000)]
crimson: bump seastore_max_concurrent_transactions size from 8->128, clarify description

Retain old value for qa coverage.

Signed-off-by: Samuel Just <sjust@redhat.com>
2 months agocrimson: bump lru size from 64M->1G, clarify description
Samuel Just [Fri, 25 Apr 2025 17:42:19 +0000 (17:42 +0000)]
crimson: bump lru size from 64M->1G, clarify description

Retain old value for qa coverage.

Signed-off-by: Samuel Just <sjust@redhat.com>
2 months agodoc/rados/operations/pools.rst: changes to scrub parameters
Ronen Friedman [Thu, 8 May 2025 14:27:16 +0000 (09:27 -0500)]
doc/rados/operations/pools.rst: changes to scrub parameters

Following Tentacle changes to the operation of the cluster/pool
options that affect the determination of the 'max allowed time
to a scrub'.

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
2 months ago.github: Fix RTD build retrigger 63143/head
David Galloway [Tue, 6 May 2025 21:31:03 +0000 (17:31 -0400)]
.github: Fix RTD build retrigger

Fixes: https://tracker.ceph.com/issues/70430
Signed-off-by: David Galloway <david.galloway@ibm.com>
2 months agoMerge pull request #63088 from spuiuk/doc-provider
Anthony D'Atri [Thu, 8 May 2025 16:06:03 +0000 (12:06 -0400)]
Merge pull request #63088 from spuiuk/doc-provider

doc/mgr/smb: document the 'provider' option for smb share

2 months agoMerge pull request #63180 from afreen23/fix-tox
Nizamudeen A [Thu, 8 May 2025 15:37:56 +0000 (21:07 +0530)]
Merge pull request #63180 from afreen23/fix-tox

mgr/dashboard: fix make check tests

2 months agoosd/scrub: fix deadline calculations
Ronen Friedman [Thu, 8 May 2025 13:45:23 +0000 (08:45 -0500)]
osd/scrub: fix deadline calculations

The scrub scheduling deadlines are calculated based on pool and OSD
configuration parameters. The specifics of the calculations are
modified to match the new scrub scheduling design.

Comments and documentation are updated to reflect the fact that
the deadlines no longer have any meaningful effect on scrub
scheduling.

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
2 months agodoc/mgr/smb: document the 'provider' option for smb share 63088/head
Sachin Prabhu [Thu, 1 May 2025 10:59:54 +0000 (11:59 +0100)]
doc/mgr/smb: document the 'provider' option for smb share

Signed-off-by: Sachin Prabhu <sp@spui.uk>
2 months agoMerge pull request #63090 from ceph/wip-yuriw-18.2.7-release.notes-main
Yuri Weinstein [Thu, 8 May 2025 14:19:21 +0000 (07:19 -0700)]
Merge pull request #63090 from ceph/wip-yuriw-18.2.7-release.notes-main

doc: reef 18.2.7 release notes

Reviewed-by: Laura Flores <lflores@redhat.com>
Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: Igor Fedotov <ifedotov@suse.com>
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2 months agocommon/version: --version to output BUILD_TYPE 61637/head
Matan Breizman [Mon, 17 Mar 2025 09:40:39 +0000 (09:40 +0000)]
common/version: --version to output BUILD_TYPE

```
$ ceph-osd --version
ceph version 20.0.0-514-g7a036c6b017 (7a036c6b01769b300ead54db2a3b42182cc59442) tentacle (dev - Debug)
```

Signed-off-by: Matan Breizman <mbreizma@redhat.com>
2 months agodo_cmake.sh: update build type warning
Matan Breizman [Sun, 23 Mar 2025 16:05:02 +0000 (16:05 +0000)]
do_cmake.sh: update build type warning

also, use printf instead of cat<<

Signed-off-by: Matan Breizman <mbreizma@redhat.com>
2 months agoCMakeLists: Fallback to RelWithDebInfo
Matan Breizman [Tue, 4 Feb 2025 10:24:43 +0000 (10:24 +0000)]
CMakeLists: Fallback to RelWithDebInfo

Currently, if .git exists, we set CMAKE_BUILD_TYPE=Debug.
Otherwise, we leave it empty and no optimization flags will
be used.
With this change, the fallback CMAKE_BUILD_TYPE is set
to RelWithDebInfo instead.

From CMAKE_BUILD_TYPE manual:
The default value is often an empty string, but this is usually not
desirable and one of the other standard build types is usually more appropriate.

Note: One notable change is that -DNDEBUG will now be defined.

Signed-off-by: Matan Breizman <mbreizma@redhat.com>
2 months agoMerge pull request #62745 from VallariAg/fix-2279225
Vallari Agrawal [Thu, 8 May 2025 12:16:22 +0000 (17:46 +0530)]
Merge pull request #62745 from VallariAg/fix-2279225

mgr/cephadm/module.py: Run ok_to_stop logic for stop

2 months agoqa/cephfs: use "snapshot getpath" cmd instead of constructing... 63127/head
Rishabh Dave [Tue, 6 May 2025 17:53:28 +0000 (23:23 +0530)]
qa/cephfs: use "snapshot getpath" cmd instead of constructing...

the path to a specific snapshot wherever possible.

Signed-off-by: Rishabh Dave <ridave@redhat.com>
2 months agoqa/cephfs: add tests for "snapshot getpath" cmd against v1 and...
Rishabh Dave [Mon, 5 May 2025 16:45:42 +0000 (22:15 +0530)]
qa/cephfs: add tests for "snapshot getpath" cmd against v1 and...

legacy subvolumes.

Signed-off-by: Rishabh Dave <ridave@redhat.com>
2 months agoMerge pull request #62815 from aclamk/aclamk-bs-debug-print-shards
Adam Kupczyk [Thu, 8 May 2025 09:05:15 +0000 (11:05 +0200)]
Merge pull request #62815 from aclamk/aclamk-bs-debug-print-shards

os/bluestore: Add printing shards to Onode::printer

2 months agomgr/dashboard: fix make check tests 63180/head
Afreen Misbah [Thu, 8 May 2025 08:53:07 +0000 (14:23 +0530)]
mgr/dashboard: fix make check tests

Fixes https://tracker.ceph.com/issues/71246

Pr are failing with errors import errors running pylint

Signed-off-by: Afreen Misbah <afreen@ibm.com>
2 months agoMerge pull request #63001 from tchaikov/librbd-tools-std-variant
Ilya Dryomov [Thu, 8 May 2025 07:15:37 +0000 (09:15 +0200)]
Merge pull request #63001 from tchaikov/librbd-tools-std-variant

librbd, tools: migrate from boost::variant to std::variant

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
2 months agoFixes:https://tracker.ceph.com/issues/71248 63175/head
Prachi [Thu, 8 May 2025 05:44:25 +0000 (11:14 +0530)]
Fixes:https://tracker.ceph.com/issues/71248

Signed-off-by: Prachi <prgoel@redhat.com>
Changes:
Fixes for RGW multi-site-sync-status UI distortion in data sync

2 months agodoc/mgr: edit alerts.rst 63173/head
Zac Dover [Thu, 8 May 2025 02:29:25 +0000 (12:29 +1000)]
doc/mgr: edit alerts.rst

Edit doc/mgr/alerts.rst as part of the project to determine where the
error is in https://github.com/ceph/ceph/pull/62782 that prevents the
Jenkins tests from passing.

This commit adds to the work done in
https://github.com/ceph/ceph/pull/62782 by correcting some of the
English that was present in that PR.

This is a change to one of twenty-five files in
https://github.com/ceph/ceph/pull/62782, and this commit represents one
of what will be at least twenty-five other commits made to track this
error down.

Signed-off-by: Zac Dover <zac.dover@proton.me>
2 months agodoc/mgr/ceph_api: edit index.rst 63172/head
Zac Dover [Thu, 8 May 2025 00:08:06 +0000 (10:08 +1000)]
doc/mgr/ceph_api: edit index.rst

Edit doc/mgr/ceph_api/index.rst as part of the project to determine
where the error is in https://github.com/ceph/ceph/pull/62782 that
prevents the Jenkins tests from passing.

This is a change to one of twenty-five files in
https://github.com/ceph/ceph/pull/62782, and this commit represents one
of what will be at least twenty-five other commits made to track this
error down.

Signed-off-by: Zac Dover <zac.dover@proton.me>
2 months agoMerge pull request #63171 from dmick/shut-up-do-cmake
Dan Mick [Wed, 7 May 2025 23:21:50 +0000 (16:21 -0700)]
Merge pull request #63171 from dmick/shut-up-do-cmake

do_cmake.sh: remove --progress, it's just noise