cls/cas/cls_cas_internal: add chunk_refs_t operator=, copy ctor

For ceph-dencoder's benefit

Signed-off-by: Sage Weil <sage@newdream.net>

cls_cas: improve dynamic_encode accuracy a bit

- no default arg
- account for extra padding
- adjust test to target 512 bytes, which sounds reasonable?

Signed-off-by: Sage Weil <sage@newdream.net>

cls_cas: chunk_obj_refcount -> chunk_refs_t

Adjusted attr name too (chunk_refcount -> chunk_refs).

Signed-off-by: Sage Weil <sage@newdream.net>

cls/cas/cls_cas_internal: dynamically drop precision for refs_by_hash

Enable reduced precision via shrink().

Update test to
- verify encode/decode are consistent
- adjust pool id at the right times so that we get coverage of all
  encoding types.

Signed-off-by: Sage Weil <sage@newdream.net>

cls/cas/cls_cas_internal: varint for refs_by_hash

Signed-off-by: Sage Weil <sage@newdream.net>

ceph_test_cls_cas: vary pool in chunk_obj_refcount test

Signed-off-by: Sage Weil <sage@newdream.net>

cls/cas/cls_cas_internal: use denc for refs_by_pool

varint it helpful here

Signed-off-by: Sage Weil <sage@newdream.net>

cls/cas/cls_cas_internal: use DENC for refs_by_hash

In order to make the refs_t subtypes coexist with different encoding
schemes, I had to move things into the .cc file (probably better anyway)
and make them standalone classes (not subclasses).

Signed-off-by: Sage Weil <sage@newdream.net>

ceph-dedup-tool: fix scrub

This is less comprehensive: it only detects errors, and only sometimes,
because the ref representation may not enumerate objects explicitly.

Signed-off-by: Sage Weil <sage@newdream.net>

cls_cas: 0 on dup get of same ref

1- This makes the state reconverge if

 A takes ref
 A drops ref (but request is lost)
 A retakes ref

The alternative would mean handling in all of the get_ref callers to
handle EEXIST.  Instead, they must ensure they reference hobject_t is
truly unique.

2- Fixes the dedup scrub test, which does a manifest promote (but doesn't
drop ref) and then triggers a flush (which would fail/loop due to EEXIST).

Signed-off-by: Sage Weil <sage@newdream.net>

cls_cas: dynamically adjust resolution of chunk_obj_refcount

Most objects will have few refs, but some will have many.  Retain as much
information about references as we can for both cases, without exploding
the size of encoded refs.

Signed-off-by: Sage Weil <sage@newdream.net>

ceph_test_cls_cas: fix warning

Signed-off-by: Sage Weil <sage@newdream.net>

cls_cas: remove ops that expose internal ref representation

The internal representation may change, and we've dropped all the users.

Signed-off-by: Sage Weil <sage@newdream.net>

ceph-dedup-tool: disable chunk scrub

Signed-off-by: Sage Weil <sage@newdream.net>

ceph-dedup-tool: get-chunk-ref -> dump-chunk-refs

Signed-off-by: Sage Weil <sage@newdream.net>

ceph-dedup-tool: --add-chunk-ref -> --chunk-get-ref (and -put-ref)

Signed-off-by: Sage Weil <sage@newdream.net>

ceph-dedup-tool: make --add-chunk-ref use get_ref (not read_refs + set_refs)

Signed-off-by: Sage Weil <sage@newdream.net>

ceph_test_rados_api_tier_pp: manipulate refcount attr directly

Signed-off-by: Sage Weil <sage@newdream.net>

cls_cas: renames, cleanups

- add write_or_get method
- fix PrimaryPG caller ot use write_or_get
- remove old method it previously called that did weird things
- cls_chunk_refcount_* -> cls_cas_chunk_*
- add _ref suffix for get and put to avoid confusion (get/put could mean
  read/write)
- some comments
- move (internal) refcount representation into separate header

Signed-off-by: Sage Weil <sage@newdream.net>

cls/cas/cls_cas_ops: remove dup type

Signed-off-by: Sage Weil <sage@newdream.net>

Merge PR #35267 into master

* refs/pull/35267/head:
vstart_runner: set mounted to True at the end of mount()

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Zheng Yan <zyan@redhat.com>

Merge pull request #34974 from dungdm93/patch-1

pybind/ceph_volume_client: Fix PEP-8 SyntaxWarning

Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #35012 from tchaikov/wip-45147

qa/tasks/mgr: skip test_diskprediction_local on python>=3.8

Reviewed-by: Yuri Weinstein <yuriw@redhat.com>
Reviewed-by: Josh Durgin <jdurgin@redhat.com>

Merge pull request #35033 from badone/wip-test-the-right-rocksdb-version

qa/workunits/rados/test_envlibrados_rocksdb: Build correct rocksdb

Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #35032 from badone/wip-update-rocksdb-to-v6.8.1

rocksdb: Updated to v6.8.1

Reviewed-by: Mark Nelson <mnelson@redhat.com>
Reviewed-by: Adam Kupczyk <akupczyk@redhat.com>

Merge pull request #35111 from agayev/hm-smr

os/bluestore: Enable writing data to HM-SMR hard drives.

Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #35097 from matthewoliver/cephadm_iscsi_api_user_password

cephadm: Make ceph-iscsi api user and password mandatory

Reviewed-by: Michael Fritch <mfritch@suse.com>

Merge pull request #35079 from liewegas/wip-dedup-tool

ceph-dedup-tool: add new FastCDC chunker, and make estimate test a range of chunk sizes

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Myoungwon Oh <myoungwon.oh@samsung.com>

Merge pull request #35198 from varshar16/wip-cephadm-module-error

qa/tasks/mgr: Don't disable cephadm module

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Sebastian Wagner <sebastian.wagner@suse.com>

Merge pull request #35128 from yuvalif/fix-amqp-urls-with-vhosts

rgw/url: fix amqp urls with vhosts

common/rabin: remove

The implementation is buggy, and slower than FastCDC.

Signed-off-by: Sage Weil <sage@newdream.net>

ceph-dedup-tool: default to fastcdc

Signed-off-by: Sage Weil <sage@newdream.net>

common/FastCDC: better behavior if TARGET_WINDOW_BITS==0

Skip the middle scan call entirely in that case.

Signed-off-by: Sage Weil <sage@newdream.net>

common/FastCDC: add some comments

Map terms back to those in the paper.

Signed-off-by: Sage Weil <sage@newdream.net>

common/CDC: make calc_chunks const

Signed-off-by: Sage Weil <sage@newdream.net>

common/CDC: take const bufferlist

Signed-off-by: Sage Weil <sage@newdream.net>

common/FastCDC: use bufferlist iterator

More complex, but we avoid a buffer copy/rebuild if it is non-contiguous.

Signed-off-by: Sage Weil <sage@newdream.net>

common/FastCDC: simplify initial fingerprint calc

Signed-off-by: Sage Weil <sage@newdream.net>

common/FastCDC: refactor scan into a helper

Signed-off-by: Sage Weil <sage@newdream.net>

unittest_cdc: generate fragmented buffers

Signed-off-by: Sage Weil <sage@newdream.net>

unittest_cdc: add test with a specific chunking result

Canary for alg changes

Signed-off-by: Sage Weil <sage@newdream.net>

ceph-dedup-tool: show object count explosion too

Also show dedup ratio as dedup_size/original_size (1.0 = no dedup,
.9 = 10%, etc.)

Signed-off-by: Sage Weil <sage@newdream.net>

ceph-dedup-tool: show estimate progress

Signed-off-by: Sage Weil <sage@newdream.net>

ceph-dedup-tool: test a range of chunk sizes at once

Signed-off-by: Sage Weil <sage@newdream.net>

ceph-dedup-tool: add --max-seconds

Signed-off-by: Sage Weil <sage@newdream.net>

ceph-dedup-tool: timeout -> report_period

Signed-off-by: Sage Weil <sage@newdream.net>

ceph-dedup-tool: use CDC class for chunking

Signed-off-by: Sage Weil <sage@newdream.net>

ceph-dedup-tool: useful error messages

Signed-off-by: Sage Weil <sage@newdream.net>

ceph-dedup-tool: EstimateThread -> CrawlerThread

Signed-off-by: Sage Weil <sage@newdream.net>

ceph-dedup-tool: remove rabin-specific options

We don't want to fiddle with these.

Signed-off-by: Sage Weil <sage@newdream.net>

unittest_cdc: adjust tests a bit

Seed random buffers!

Include average in histogram, and do the binning slightly differently.

Signed-off-by: Sage Weil <sage@newdream.net>

common/FixedCDC: add 'fixed' chunker

Signed-off-by: Sage Weil <sage@newdream.net>

common/FastCDC: initial implementation

Loosely based on the paper, but with a few changes.

Signed-off-by: Sage Weil <sage@newdream.net>

common/CDC: add abstract interface

Signed-off-by: Sage Weil <sage@newdream.net>

ceph-dedup-tool: warn on hash collision

Signed-off-by: Sage Weil <sage@newdream.net>

unittest_rabin_chunk: add unit test

This includes a "shift" test that shows that the rabin chunking misbehaves
when 5+ bytes are inserted at the front (many chunk boundaries shift!)

Signed-off-by: Sage Weil <sage@newdream.net>

common/rabin: add helper set_target_bits()

Sets key chunking parameters in one easy call.

Signed-off-by: Sage Weil <sage@newdream.net>

common/rabin: some cleanups

Signed-off-by: Sage Weil <sage@newdream.net>

ceph-dedup-tool: rename var

Signed-off-by: Sage Weil <sage@newdream.net>

ceph-dedup-tool: larger default op size

If we don't read the entire object the rabin calculation won't work.  Avoid
this by default by just using a sufficiently large chunk size.

Signed-off-by: Sage Weil <sage@newdream.net>

Merge pull request #34902 from p-se/wip-pse-doc-prom-security

mgr/dashboard: document Prometheus' security model

Reviewed-by: Alexandra Settle <asettle@suse.com>
Reviewed-by: Lenz Grimmer <lgrimmer@suse.com>
Reviewed-by: Tatjana Dehler <tdehler@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>

vstart_runner: set mounted to True at the end of mount()

Not doing so prevents cleanup methods from running.

Fixes: https://tracker.ceph.com/issues/45723
Signed-off-by: Rishabh Dave <ridave@redhat.com>

Merge pull request #34863 from rhcs-dashboard/45310-add-grafana-rgw-sync-info

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Laura Paduano <lpaduano@suse.com>
Reviewed-by: Stephan Müller <smueller@suse.com>

Merge pull request #34321 from jan--f/c-v-manage-lv_tags-bulk

ceph-volume: add and delete lvm tags in a single lvchange call.

Merge pull request #35235 from sebastian-philipp/qa-cephadm-mirror

qa/cephadm: Add local dockerhub mirror

Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Kyr Shatskyy <kyrylo.shatskyy@suse.com>

Merge pull request #34931 from trociny/wip-45072-2

rbd-mirror: wait for in-flight start/stop/restart

Reviewed-by: Jason Dillaman <dillaman@redhat.com>

Merge pull request #35245 from ivancich/wip-remove-unused-func

rgw: remove unused function obj_force_ns

Reviewed-by: Casey Bodley <cbodley@redhat.com>

qa/cephadm: Add local registry mirror

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>

rgw: remove unused function obj_force_ns

Removing the function eliminates a compiler warning.

Signed-off-by: J. Eric Ivancich <ivancich@redhat.com>

Merge pull request #35089 from trociny/wip-test-quiesce_watch_timeout

test/librbd: improve TestLibRBD.QuiesceWatchTimeout

Reviewed-by: Jason Dillaman <dillaman@redhat.com>

Merge pull request #35209 from wjwithagen/wjw-fix-librbd-CephContext

librbd: fix compile error with CephContext declaration

Reviewed-by: Jason Dillaman <dillaman@redhat.com>

Merge pull request #35228 from changchengx/rwl

rbd/rwl: correct m_perfcounter access scope

Reviewed-by: Jason Dillaman <dillaman@redhat.com>

Merge pull request #34294 from ishanrai05/copy-button

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Tiago Melo <tmelo@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>

Merge pull request #34973 from liewegas/doc-pingan

doc/foundation: PingAn canceled general membership

Merge pull request #35172 from yuvalif/add-flags-to-rgw-operate

rgw/tools: add flags to rgw_rados_operate api

Reviewed-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #35200 from rzarzynski/wip-crimson-ertr-assert_all

crimson: bring assert_all to errorator

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #34079 from ishanrai05/login

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Sebastian Krah <skrah@suse.com>
Reviewed-by: Tatjana Dehler <tdehler@suse.com>
Reviewed-by: Tiago Melo <tmelo@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>

Merge PR #34507 into master

* refs/pull/34507/head:
mds: preserve ESlaveUpdate::OP_PREPARE logevent before doing commit

Reviewed-by: Zheng Yan <zyan@redhat.com>

mgr/dashboard: document Prometheus' security model

Fixes: https://tracker.ceph.com/issues/45377
Signed-off-by: Patrick Seidensal <pseidensal@suse.com>

rbd/rwl: correct m_perfcounter access scope

There's no m_perfcounter in SyncPoint. Its scope is in
ReplicatedWriteLog.

Signed-off-by: Changcheng Liu <changcheng.liu@intel.com>

rgw/url: fix commensts from review #34717

Signed-off-by: Yuval Lifshitz <ylifshit@redhat.com>
Fixes: https://tracker.ceph.com/issues/45269

src/rgw/rgw_url.cc, also cope with a vhost appended to a AMQP-URL

Signed-off-by: Yuval Lifshitz <ylifshit@redhat.com>
Fixes: https://tracker.ceph.com/issues/45269

crimson/common: discard_all::operator() returns void now.

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>

crimson/os/seastore: switch to crimson::ct_error::assert_all.

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>

crimson/common: extend errorator with assert_all{}.

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>

Merge pull request #34953 from s0nea/wip-dashboard-telemetry-url

Reviewed-by: Kiefer Chang <kiefer.chang@suse.com>
Reviewed-by: Laura Paduano <lpaduano@suse.com>
Reviewed-by: Stephan Müller <smueller@suse.com>

Merge pull request #35196 from tspmelo/wip-logout

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Tatjana Dehler <tdehler@suse.com>

Merge pull request #35129 from smithfarm/wip-fix-PendingReleaseNotes-headings

doc/releases/octopus.rst: move still-pending release notes to official v15.2.0 release notes

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: Abhishek Lekshmanan <abhishek@suse.com>

doc/releases/octopus: use fixed-width font for "ceph fs dump"

We are using fixed-width font to render commands elsewhere, so
let's do so in this release note, too - just for the sake of uniformity.

Signed-off-by: Nathan Cutler <ncutler@suse.com>

Merge pull request #35142 from mgfritch/cephadm-validate-mds-fsname

mgr/orch: allow MDS with explicit naming

Reviewed-by: Sebastian Wagner <sebastian.wagner@suse.com>

Merge pull request #34174 from theanalyst/doc/active-releases-oct

doc: move luminous to archived releases & octopus to active

Reviewed-by: Nathan Cutler <ncutler@suse.com>

librbd: fix compile error with CephContext declaration

Clang complains:
/home/jenkins/workspace/ceph-master/src/librbd/plugin/Types.h:9:1: error: declaration conflicts with target of using declaration already in scope
struct CephContext;
^
/home/jenkins/workspace/ceph-master/src/include/common_fwd.h:10:9: note: target of using declaration
class CephContext;
^
/home/jenkins/workspace/ceph-master/src/include/common_fwd.h:22:24: note: using declaration
using TOPNSPC::common::CephContext;
^

fixes: https://github.com/ceph/ceph/pull/35158
tracker: https://tracker.ceph.com/issues/45668
Signed-off-by: Willem Jan Withagen <wjw@digiware.nl>

Merge pull request #35219 from tchaikov/wip-crimson-cleanups

crimson/osd,test/crimson: avoid using variadic future and s/apply/invoke/

Reviewed-by: Ronen Friedman <rfriedma@redhat.com>

crimson/osd: avoid using variadic future

see also 3cee25ba41069e9e9b4855f99be20910759440ca

Signed-off-by: Kefu Chai <kchai@redhat.com>

test/crimson: use invoke instead of apply

it's an oversight in 33af821baafbb2e9c4ebea2e377db665e210701f

Signed-off-by: Kefu Chai <kchai@redhat.com>

Merge pull request #35204 from tchaikov/wip-tools-cephfs

tools/cephfs/MetaTool: print buffer::error::what()

Reviewed-by: Brad Hubbard <bhubbard@redhat.com>

Merge pull request #35207 from tchaikov/wip-crimson-remove-vardiadict-future

crimson/osd: avoid using variadic future and cleanup

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>

crimson/osd: remove redundant std::move()

this should address following warning:

../src/crimson/osd/ops_executer.cc:821:6:   required from here
../src/crimson/osd/ops_executer.cc:818:37: warning: redundant move in return statement [-Wredundant-move]
  818 |             return std::move(entries);
      |                                     ^
../src/crimson/osd/ops_executer.cc:818:37: note: remove ‘std::move’ call

Signed-off-by: Kefu Chai <kchai@redhat.com>

crimson/osd: avoid using variadic future

Signed-off-by: Kefu Chai <kchai@redhat.com>

Merge pull request #35205 from Huber-ming/zsm_doc

doc: replace https://ceph.com/ with http://download.ceph.com/

Reviewed-by: Kefu Chai <kchai@redhat.com>