qa/workunits: partial revert of commit 5b486d9

Testing for disk usage and diff extents for a sparsely written
imported RBD image cannot generically be handled across different
OSD object stores and RBD image features.

The only alternatives would include grepping the rbd CLI
debug log for specific invocations of aio_write or mocking
the rbd CLI for unit testing.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>

rbd: import-diff was attempting to write empty chunks

Signed-off-by: Jason Dillaman <dillaman@redhat.com>

rbd: corrected typo in rbd export v2 section header

Signed-off-by: Jason Dillaman <dillaman@redhat.com>

Merge pull request #14306 from liewegas/wip-bluestore-throttle-model

os/bluestore: unify throttling model

Reviewed-by: Igor Fedotov <ifedotov@mirantis.com>
Reviewed-by: J. Eric Ivancich <ivancich@redhat.com>

os/bluestore: make deferred_aggressive a counter

Multiple threads may run _osr_drain_preceding; use a count to
prevent the first finisher from prematurely disabling
aggressive mode.

Fixes: http://tracker.ceph.com/issues/19542
Signed-off-by: Sage Weil <sage@redhat.com>

Merge pull request #14387 from wjwithagen/wip-wjw-test-osd-dup

test/osd/CMakeLists.txt: osd-dup.sh require BlueStore/AIO

Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #14348 from rzarzynski/wip-bs-bitmap-no-virts-in-hotspot

os/bluestore: avoid the VTABLE-related burden in BitMapAllocator's hotspot

Reviewed-by: Sage Weil <sage@redhat.com>

Merge pull request #14366 from wjin/clean_mgr

mgr: remove unused function declarations

Reviewed-by: Kefu Chai <kchai@redhat.com>

test/osd/CMakeLists.txt: osd-dup.sh require BlueStore/AIO

Signed-off-by: Willem Jan Withagen <wjw@digiware.nl>

Merge pull request #14029 from dachary/wip-osd-crushmap

mon: osd crush set crushmap need sanity check

Reviewed-by: Sage Weil <sage@redhat.com>

Merge pull request #14334 from tchaikov/wip-cmake-ctags

cmake: Add simple recursive ctags target for Ceph source only

Reviewed-by: Dan Mick <dmick@redhat.com>

Merge pull request #14320 from Adirl/poll_blocking

msg/async/rdma: Make poll_blocking() poll for async events in additio…

Reviewed-by: Haomai Wang <haomai@xsky.com>

Merge pull request #14340 from oritwas/wip-rgw-fix-zone-create

radosgw-admin: use zone id when creating a zone

Reviewed-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #14262 from guihecheng/rgw_file-fix-rmdir

rgw_file: fix missing unlock in unlink

Merge pull request #14216 from dongbula/add-multi-zonegroup-for-test

rgw: add --num-zonegroups option for multi test

Reviewed-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #14354 from mogeb/cmake-lttng

cmake: build tracepoint libraries for vstart target

Reviewed-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #14115 from liewegas/wip-bluestore-metadata

os/bluestore: implement collect_metadata

Merge pull request #14304 from rchagam/18576_bug_fix

tracing: fix segv

Reviewed-by: Sage Weil <sage@redhat.com>

Merge pull request #14328 from liewegas/wip-mgrmap-features

mgr: fix several init/re-init bugs

Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #14333 from liewegas/wip-bluestore-misc

os/bluestore: misc fixes

Reviewed-by: Igor Fedotov <ifedotov@mirantis.com>

msg/async/rdma: Make poll_blocking() poll for async events in addition to tx/rx

Issue: 995322
Change-Id: I62e75f4c4e574ba97e24b20a4d7b94c56c605bb5
Signed-off-by: Amir Vadai <amir@vadai.me>

Merge pull request #14210 from liewegas/wip-osd-dup

os: allow offline conversion of filestore -> bluestore (or anything else)

Reviewed-by: David Zafman <dzafman@redhat.com>

Merge pull request #12175 from dongbula/fix-slavezonegroup-cannot-enable-bucket-versioning

rgw: fix slave zonegroup cannot enable the bucket versioning

Reviewed-by: Casey Bodley <cbodley@redhat.com>
Reviewed-by: Orit Wasserman <owasserm@redhat.com>

Merge pull request #14342 from theanalyst/cleanup/rgw/rgw-lc-inc

rgw_lc: drop a bunch of unused headers

Merge pull request #13622 from zhangsw/feature-lifecycle-multipart

rgw: add support for multipart upload expiration.

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>

Merge pull request #14337 from smithfarm/wip-19492

common: support s390 and unknown architectures in spin-wait loop

Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Brad Hubbard <bhubbard@redhat.com>

Merge pull request #14339 from haklein/master

add RGW ldap auth documentation

cmake: build tracepoint libraries for vstart target

Avoid a segfault in TracepointProvider::verify_config() when building
for the 'vstart' target. TracepointProvider tries to load the tracepoint
providers libraries at runtime, but these aren't built as part of the
'vstart' target.

Signed-off-by: Mohamad Gebai <mgebai@suse.com>

mgr: clean nonused function declaration

Signed-off-by: Wei Jin <wjin.cn@gmail.com>

common: support s390 and unknown architectures in spin-wait loop

This fixes the s390 build which was broken by 34481768cbce0991bfba1d511dad81893a9004a9

It also reinstates the previous architecture-independent for-loop
implementation as a catch-all for "unknown" (not-explicitly-supported)
architectures.

Fixes: http://tracker.ceph.com/issues/19492
Signed-off-by: Nathan Cutler <ncutler@suse.com>

Merge pull request #14240 from dillaman/wip-rbd-mirror-peer-uuids

rbd-mirror: pool watcher should track mirror uuid

Reviewed-by: Mykola Golub <mgolub@mirantis.com>

Merge pull request #14293 from badone/wip-ceph-disk-list-selinux

ceph-disk: Populate mount options when running "list"

Reviewed-by: Loic Dachary <ldachary@redhat.com>

cmake: Add simple recursive ctags target for Ceph source only

Excludes submodules and random JavaScript.

Signed-off-by: Dan Mick <dan.mick@redhat.com>
Signed-off-by: Kefu Chai <kchai@redhat.com>

Merge pull request #14032 from joscollin/wip-18511-returntype

librbd: changed the return type of ImageRequestWQ::discard()

Reviewed-by: Jason Dillaman <dillaman@redhat.com>

Merge pull request #13957 from wangzhengyong/import

rbd: error out if import image format failed

Reviewed-by: Jason Dillaman <dillaman@redhat.com>

Merge pull request #13836 from gaurav36/bug-14535-rbd-snap-pool-name-validatation

rbd: validate pool and snap name optionals

Reviewed-by: Jason Dillaman <dillaman@redhat.com>

Merge pull request #14282 from wjwithagen/wip-wjw-freebsd-ceph-fuse

build: let FreeBSD build ceph-fuse

Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #14308 from badone/SyntheticClient_random_walk_warning

client/SyntheticClient.cc: Fix warning in random_walk

Reviewed-by: Sage Weil <sage@redhat.com>

Merge pull request #10146 from yonghengdexin735/wip-zzz-filestore-write

os/filestore: handle error returned from write_fd()

Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Sage Weil <sage@redhat.com>

Merge pull request #13815 from theanalyst/cleanup/rgw/rest-read-input

rgw: don't read all user input for a few param requests

Reviewed-by: Casey Bodley <cbodley@redhat.com>

mon/MgrMonitor: make debug prefix useful

Signed-off-by: Sage Weil <sage@redhat.com>

os/bluestore: don't use virtual for accessing BitMapZone::is_exhausted.

Signed-off-by: Radoslaw Zarzynski <rzarzynski@mirantis.com>

os/bluestore: do not wake kv thread if only deferred events pending

No need to wake up if there is only deferred work; we can do
it lazily.

Signed-off-by: Sage Weil <sage@redhat.com>

os/bluestore: bluestore_deferred_batch_ops = 32 (not 8)

A bit more batching.

Signed-off-by: Sage Weil <sage@redhat.com>

os/bluestore: unify throttling model

Implement a super simple model for the cost of a transaction
for the purposes of throttling.  This replaces two independent
throttles (one for transaction ops, one for bytes) and puts
them both under the 'bytes' throttle.  The txc model cost is
expressed in terms of bytes as this is probably the simplest
thing for users to reason about.

Signed-off-by: Sage Weil <sage@redhat.com>

os/bluestore: release throttle before commit

Signed-off-by: Sage Weil <sage@redhat.com>

ceph_test_objectstore: error via derr too

This helps establish timing relative to the log.

Signed-off-by: Sage Weil <sage@redhat.com>

os/bluestore: increase aio queue depth

We've seen some reports of the aio EAGAIN backoff in logs; use a larger
aio ring buffer to reduce the risk of this.

Signed-off-by: Sage Weil <sage@redhat.com>

os/bluestore: reduce some debug level

Signed-off-by: Sage Weil <sage@redhat.com>

os/bluestore: put fsck structures in mempools

This lets us track them individually in debug mode.

Signed-off-by: Sage Weil <sage@redhat.com>

mempool: do not skip first 2 mempools

This broke when we sorted the pool definitions in the header.

Signed-off-by: Sage Weil <sage@redhat.com>

os/bluestore: flush osr even on failure in _deferred_replay

This is one less thing for fsck to worry about.

Signed-off-by: Sage Weil <sage@redhat.com>

os/bluestore: trim cache during fsck

Signed-off-by: Sage Weil <sage@redhat.com>

os/bluestore: be noisy about bitmap init (it's slow!)

Signed-off-by: Sage Weil <sage@redhat.com>

Merge pull request #14316 from liewegas/wip-bluestore-fsck-unused

os/bluestore: fsck: verify blob.unused field

Reviewed-by: Igor Fedotov <ifedotov@mirantis.com>

os/bluestore: use typedef for blob unused (uint16_t)

Signed-off-by: Sage Weil <sage@redhat.com>

os/bluestore: fsck: verify blob.unused field

Two checks:

- verify that no logical extents reference the portion of the
  blob marked unused, and
- verify that the csum (if present) is zero for any unused
  region.

Signed-off-by: Sage Weil <sage@redhat.com>

Merge pull request #14157 from liewegas/wip-19379

os/bluestore: fix deferred writes vs collection split race

Reviewed-by: Igor Fedotov <ifedotov@mirantis.com>

Merge pull request #14258 from liewegas/wip-bluestore-tool

ceph-bluestore-tool: rename from bluefs-tool; improve usage

Merge pull request #14294 from tchaikov/wip-check-last-osd-report-if-luminous

mon/OSDMonitor: check last_osd_report only when the whole cluster is lu…

Reviewed-by: Sage Weil <sage@redhat.com>

Merge pull request #14303 from liewegas/wip-more-mgr-commands

mgr: move 'osd perf' and 'osd blocked-by' to mgr

Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #14010 from zhangsw/fix-rgw-fetchremote-bug

rgw: version id doesn't work in fetch_remote_obj

Reviewed-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #13310 from ceph/wip-ceph-disk-fix

ceph-disk: Add fix subcommand

Reviewed-by: Loic Dachary <ldachary@redhat.com>

rgw_lc: drop a bunch of unused headers

Dropping headers that are already included as a part of rgw_common

Signed-off-by: Abhishek Lekshmanan <abhishek@suse.com>

rgw: add support for multipart upload expiration.

Fixes: http://tracker.ceph.com/issues/19088
Signed-off-by: Zhang Shaowen <zhangshaowen@cmss.chinamobile.com>

radosgw-admin: use zone id when creating a zone

Fixes: http://tracker.ceph.com/issues/19498
Signed-off-by: Orit Wasserman <owasserm@redhat.com>

add RGW ldap auth documentation

Signed-off-by: Harald Klein <hari@vt100.at>

Merge pull request #14314 from rzarzynski/wip-rgw-bulkupload-freebsd

rgw: switch to std::array in RGWBulkUploadOp due to C++11 and FreeBSD.
Reviewed-by: Orit Wasserman <owasserm@redhat.com>

Merge pull request #14252 from cbodley/wip-19409

radosgw-admin: new 'global quota' commands update period config
Reviewed-by: Orit Wasserman <owasserm@redhat.com>

Merge pull request #14109 from cbodley/wip-rgw-stat-manifest

rgw: stat requests skip compression, manifest handling, etc
Reviewed-by: Orit Wasserman <owasserm@redhat.com>

os/bluestore/KernelDevice: assume rotational if we can't get devname

Signed-off-by: Sage Weil <sage@redhat.com>

Merge pull request #14281 from tchaikov/wip-19429

qa/tasks/workunit.py: use "overrides" as the default settings of workunit

Reviewed-by: Josh Durgin <jdurgin@redhat.com>

Merge pull request #14297 from Adirl/ibport

msg/async/rdma: Make port number an attribute of the Connection not o…

Reviewed-by: Haomai Wang <haomai@xsky.com>

Merge pull request #13766 from dachary/wip-18962-ceph-disk-zap

ceph-disk: Write 10M to all partitions before zapping

Reviewed-by: Sébastien Han <seb@redhat.com>

Merge pull request #13998 from wangzhengyong/aio_complete

rgw: fix memory leak in delete_obj_aio

Reviewed-by: Yehuda Sadeh <yehuda@redhat.com>
Reviewed-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #12883 from mslovy/wip-rbd-import

rbd: import real thin-provision image

Reviewed-by: Jason Dillaman <dillaman@redhat.com>

Merge pull request #14327 from cbodley/wip-12863

rgw: switch from "timegm()" to "internal_timegm()" for better portability

Reviewed-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #14190 from idryomov/wip-respect-epoch-barrier

osdc/Objecter: respect epoch barrier in _op_submit()

Reviewed-by: John Spray <john.spray@redhat.com>

Merge pull request #14220 from jcsp/wip-19407

mon: update mgrmap when active goes offline

Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Sage Weil <sage@redhat.com>

mgr/Mgr: log something at end of handle_mgr_digest

Saw a run that showed the notify_all pg_summary as the last
message for this thread; hopefully we can see if it is
blocked in notify_all() or not.

Signed-off-by: Sage Weil <sage@redhat.com>

mgr/Mgr: drop lock while fetching config-keys

This avoids a deadlock if some other message arrives before
the command reply and needs to take the mgr lock in dispatch.

Signed-off-by: Sage Weil <sage@redhat.com>

Merge pull request #12437 from idealguo/remove-duplicate-flush

rgw: remove duplicate flush formatter

Reviewed-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #13934 from chuang-he/fix_copy_obj_data

rgw: fix configurable write obj window size

Reviewed-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #11963 from zhangsw/fix-rgw-lifecycle-bug

rgw: LCWorker's worktime is not the same as config rgw_lifecycle_work_time.

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>

mgr/Mgr: fix map waits in init

If we go active multiple times we may already have an fsmap
subscription registered via MonClient, which means that we
won't receive a net new FSMap during the init phase.  This is
trivial to reproduce; just 'ceph mgr fail x' and when it
activates the second time init() will get stuck waiting.

The core issue is that monc subs are stateful, but we forget
the various maps with the previous Mgr incarnation.  Sipmle
workaround is to reset the mon connection as we init.

Signed-off-by: Sage Weil <sage@redhat.com>

mgr/Mgr: use cond (not context) for FSMap wait

This is simpler.

Signed-off-by: Sage Weil <sage@redhat.com>

Switch from "timegm()" to "internal_timegm()"

Changed timegm() to internal_timegm() for better portability

Fixes: http://tracker.ceph.com/issues/12863
Signed-off-by: Rishabh Kumar <kris.kr296@gmail.com>

Merge pull request #14042 from pritha-srivastava/wip-rgw-fix-accounting

rgw: Added code to correctly account for bytes sent/ received during a 'PUT' operation.

Reviewed-by: Radoslaw Zarzynski <rzarzynski@mirantis.com>
Reviewed-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #14125 from zhangsw/fix-rgw-cache-normalname-bug

rgw: add pool namespace to cache's key so that system obj can have unique key

Reviewed-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #14072 from trociny/wip-notify

librbd: Notifier::notify API improvement

Reviewed-by: Jason Dillaman <dillaman@redhat.com>

mon/MgrMonitor: encode MgrMap with mon quroum features

Fixes: http://tracker.ceph.com/issues/19491
Signed-off-by: Sage Weil <sage@redhat.com>

Merge pull request #14160 from Liuchang0812/wip-19363-fix-lc-two-response

rgw/lifecycle: do not send lifecycle rules when GetLifeCycle failed

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
Reviewed-by: Casey Bodley <cbodley@redhat.com>

rgw: switch to std::array in RGWBulkUploadOp due to C++11 and FreeBSD.

Before this patch RGWBulkUploadOp::terminal_errors was declared as
std::initializer_list<int>. Unfortunately, a constexpr constructor
for it is available since C++14, not C++11. This was causing build
failures on FreeBSD.

Signed-off-by: Radoslaw Zarzynski <rzarzynski@mirantis.com>

os/bluestore: do not extend blobs with unused bitmap

If we resize the blob we need to adjust the resolution of the
unused bitmap, and that is only possible for some bit patterns.
For now just ignore blobs with unused blocks.

Add an assert in add_tail() so that we don't forget that
add_tail is (probably) where we'd would do that adjustment.

Signed-off-by: Sage Weil <sage@redhat.com>

os/bluestore: some whitespace

Signed-off-by: Sage Weil <sage@redhat.com>

os/bluestore: mark_used for wctx->writes

The refactored blob reuse code needs to mark blobs used when
processing wctx->writes.

Signed-off-by: Sage Weil <sage@redhat.com>

Bug fix for http://tracker.ceph.com/issues/18576
Refer to http://lttng.org/docs/v2.9/ on dlclose side effects. Workaround is to use
RTLD_NODELETE flag when calling dlopen.

Signed-off-by: Anjaneya Chagam <anjaneya.chagam@intel.com>

os/bluestore: prefix fsck errors with 'fsck error:'

Greppable!

Signed-off-by: Sage Weil <sage@redhat.com>

msg/async/rdma: Make port number an attribute of the Connection not of the Device

Since multiple connections on different ports could exist, shouldn't use
device->active_port, instead use conn->ibport.
Or in other words, now Device object doesn't have an active_port,
instead every port specific action (create_qp, get_lid, get_gid etc.)
need to specify the port number. The information about the port number
is known to the connection (RDMAConnectedSocket*) who is the caller of
those actions.

Issue: 995322
Change-Id: I482cb87c04ba99845dc44f6dd0547835fe814ebf
Signed-off-by: Amir Vadai <amir@vadai.me>

Merge pull request #14310 from tchaikov/wip-yield-for-ppc

common/simple_spin: use __ppc_yield() on all powerpc archs

Reviewed-by: Brad Hubbard <bhubbard@redhat.com>
Tested-by: Andrew Solomon <asolomon@us.ibm.com>