common: add new line break when get command descriptions

Signed-off-by: songweibin <song.weibin@zte.com.cn>

rbd: adding newline operation when only '--format' used

Signed-off-by: songweibin <song.weibin@zte.com.cn>

rbd: '--pretty-format' should return error if '--format' not used

Signed-off-by: songweibin <song.weibin@zte.com.cn>

Merge pull request #16620 from cfanz/master

common: use std::move() for better performance

Reviewed-by: Jos Collin <jcollin@redhat.com>

Merge pull request #16526 from TsaiJin/wip-fix-msg-typo

msg/async: fix the bug of inaccurate calculation of l_msgr_send_bytes

Reviewed-by: Pan Liu <wanjun.lp@alibaba-inc.com>
Reviewed-by: Jos Collin <jcollin@redhat.com>
Reviewed-by: Haomai Wang <haomai@xsky.com>

Merge pull request #16666 from scienceluo/wip-luo-auth-branch

auth: Remove unused function in AuthSessionHandler

Reviewed-by: Jos Collin <jcollin@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #16622 from dillaman/wip-cmpext-dne

osd: cmpext operator should ignore -ENOENT on read

Reviewed-by: David Zafman <dzafman@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Josh Durgin <jdurgin@redhat.com>

Merge pull request #16677 from tchaikov/wip-20785

osd: do not send pg_created unless luminous

Reviewed-by: Greg Farnum <gfarnum@redhat.com>

Merge pull request #16663 from dzafman/wip-ec-enoent

osd: EC read handling: don't grab an objectstore error to use as the read error

Reviewed-by: Greg Farnum <gfarnum@redhat.com>

Merge pull request #16681 from shun-s/wip-doc-config

doc: fix typos in config.rst

Reviewed-by: Jos Collin <jcollin@redhat.com>

Merge pull request #16695 from tchaikov/wip-cmake-disable-vta

cmake: disable -fvar-tracking-assignments for config.cc

Reviewed-by: Greg Farnum <gfarnum@redhat.com>

Merge pull request #16697 from wjwithagen/wip-wjw-ENODATA-HashIndex.cc

HashIndex.cc: add compat.h for ENODATA

Reviewed-by: Greg Farnum <gfarnum@redhat.com>

Merge pull request #16689 from pritha-srivastava:wip-rgw-policy-parse-error

rgw: Fix for Policy Parse exception in case of multiple statements.

Reviewed-by: Adam C. Emerson <aemerson@redhat.com>

Merge pull request #16661 from adamemerson/wip-throttle-minimal

throttle: Minimal destructor fix for Luminous

Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Greg Farnum <gfarnum@redhat.com>

throttle: Minimal destructor fix for Luminous

Get rid of the undefined behavior of destroying condition variables
while they're being waited on.

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>

Merge pull request #16547 from dillaman/wip-dashboard-iscsi

mgr/dashboard: RBD iSCSI daemon status page

Reviewed-by: John Spray <john.spray@redhat.com>

doc: fix sevral typos

  fix sevral typos

Signed-off-by: Song Shun <song.shun3@zte.com.cn>

Merge pull request #16670 from Yan-waller/wip-walle-0729rbdcompile

cls/rbd: silence warning from -Wunused-variable

Reviewed-by: Jason Dillaman <dillaman@redhat.com>

Merge pull request #16583 from lxbsz/ws_macro

librbd: add LIBRBD_SUPPORTS_WRITESAME support

Reviewed-by: Jason Dillaman <dillaman@redhat.com>

cls/rbd: silence warning from -Wunused-variable

Signed-off-by: Yan Jun <yan.jun8@zte.com.cn>

Merge pull request #16694 from Songweibin/wip-doc-rbd

rbd: modified some commands' description into imperative sentence

Reviewed-by: Jason Dillaman <dillaman@redhat.com>

HashIndex.cc: add compat.h for ENODATA

Signed-off-by: Willem Jan Withagen <wjw@digiware.nl>

mon/OSDMonitor: assert(pg in creating_pgs.pg) in send_pg_creates()

and mark OSDMonitor::send_pg_creates() a const method.

See-also: http://tracker.ceph.com/issues/20785
Signed-off-by: Kefu Chai <kchai@redhat.com>

Merge pull request #16686 from amitkumar50/cov-1351525-1

rbd: fixed coverity 'Argument cannot be negative' warning

Reviewed-by: Jason Dillaman <dillaman@redhat.com>

cmake: disable -fvar-tracking-assignments for config.cc

there are too many variables involved in config.cc, but
-fvar-tracking-assignments is enabled by default, when the compiler
finds that the number of variables exceeds the limit
"max-vartrack-size", it gives up, and tries again disabling this
option.

this change avoids the recompilation of config.cc and also
silences the warning of

src/common/config.cc:77:1: note: variable tracking size limit exceeded
with -fvar-tracking-assignments, retrying without
 md_config_t::md_config_t(bool is_daemon)
 ^

Signed-off-by: Kefu Chai <kchai@redhat.com>

rbd: 1351525 Argument cannot be negative

Fixed:

** CID 1351525 (#1 of 1): Argument cannot be negative (NEGATIVE_RETURNS)
7. negative_returns: sd is passed to a parameter that cannot be negative.

Signed-off-by: Amit Kumar amitkuma@redhat.com

rbd: modified some commands' description into imperative sentence

Signed-off-by: songweibin <song.weibin@zte.com.cn>

Merge pull request #16660 from nrdmn/patch-2

doc: added mgr caps to manual deployment documentation

Reviewed-by: John Spray <john.spray@redhat.com>

rgw: Fix for Policy Parse exception in case of multiple statements.

Signed-off-by: Pritha Srivastava <prsrivas@redhat.com>

auth: Remove unused function in AuthSessionHandler

Signed-off-by: Luo Kexue <luo.kexue@zte.com.cn>

Merge pull request #16627 from liewegas/wip-objecter-eagain

osdc/Objecter: unify disparate EAGAIN handling paths into one

Reviewed-by: Greg Farnum <gfarnum@redhat.com>

Merge pull request #16668 from Yan-waller/wip-walle-0729configoption

common: fix Option set_long_description

Reviewed-by: xie xingguo <xie.xingguo@zte.com.cn>
Reviewed-by: Kefu Chai <kchai@redhat.com>

mon/OSDMonitor: more verbose message for pg creation

See-also: http://tracker.ceph.com/issues/20785
Signed-off-by: Kefu Chai <kchai@redhat.com>

osd: do not send pg_created unless luminous

See-also: http://tracker.ceph.com/issues/20785
Signed-off-by: Kefu Chai <kchai@redhat.com>

Merge pull request #16669 from Yan-waller/wip-walle-0729testpglogcompile

test/osd: kill compile warning

Reviewed-by: xie xingguo <xie.xingguo@zte.com.cn>

test/osd: kill compile warning

Signed-off-by: Yan Jun <yan.jun8@zte.com.cn>

Merge pull request #16667 from tchaikov/wip-objclass-omap

objclass: modify omap_get_{keys,vals} api

Reviewed-by: Sage Weil <sage@redhat.com>

common: fix Option set_long_description

Signed-off-by: Yan Jun <yan.jun8@zte.com.cn>

librados_test_stub: use omap_get_vals2() and modify stubs

Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>
Signed-off-by: Casey Bodley <cbodley@redhat.com>

cls_kvs: adjust objclass api

Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>

cls_{rbd, journal, lua}: adjust api

Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>

cls/lua: add 'more' param for cls_cxx_map_get_vals()

Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>

cls/*: adjust use of cls_cxx_map_get_vals()

Now that objclass call gets a new 'more' param.

Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>

objclass: add 'more' param to omap listing

Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>

osd: cmpext operator should ignore -ENOENT on read

The operator already handles the case where the object is truncated. If
an RBD user performs a read + cmpext/write of a sparse image, the read
of the missing object would return a zeroed buffer. Using that zeroed
buffer for the cmpext test would fail since it wasn't ignoring the
-ENOENT read failure.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>

osd: EC read handling: don't grab an objectstore error to use as the read error

Signed-off-by: David Zafman <dzafman@redhat.com>

Merge pull request #16617 from dillaman/wip-20783

osd: moved OpFinisher logic from OSDOp to OpContext

Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #16590 from LianneWang/master

ceph_test_rados: max_stride_size must be more than min_stride_size

Reviewed-by: Sage Weil <sage@redhat.com>

Merge pull request #16615 from tchaikov/wip-no-vla-in-cxx

kv/RocksDBStore: use vector instead of VLA for holding slices

Reviewed-by: Haomai Wang <haomai@xsky.com>
Reviewed-by: Willem Jan Withagen <wjw@digiware.nl>

Merge pull request #16655 from liewegas/wip-osd-warning

osd/PG: fix warning so we discard_event() on a no-op state change

Reviewed-by: Greg Farnum <gfarnum@redhat.com>

added mgr caps to manual deployment documentation

Signed-off-by: Nick Erdmann <n@nirf.de>

Merge PR #16640 into master

* refs/remotes/upstream/pull/16640/head:
qa: fix wait for wrong health message

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

Merge PR #16550 into master

* refs/remotes/upstream/pull/16550/head:
cephfs/ceph-fuse: add and modify ceph-fuse mount hint

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

Merge PR #16413 into master

* refs/remotes/upstream/pull/16413/head:
qa/cephfs: lsof if umount fails

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

Merge PR #16410 into master

* refs/remotes/upstream/pull/16410/head:
mds: refuse 'export dir' request when mds is stopping

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

osd/PG: fix warning

Introduced by 4af49a886679ceb8e8afba47f04e828e5911e325

Signed-off-by: Sage Weil <sage@redhat.com>

Merge pull request #16645 from tchaikov/wip-bluefs-allocator-is-dev-only-option

common/options: make "blue{fs,store}_allocator" LEVEL_DEV

Reviewed-by: Sage Weil <sage@redhat.com>

Merge pull request #16489 from liewegas/wip-bluestore-options

common/options.cc: document bluestore config options

Merge pull request #16520 from xiexingguo/wip-application-warn

mon/OSDMonitor: issue pool application related warning

Reviewed-by: Sage Weil <sage@redhat.com>

Merge pull request #16568 from liewegas/wip-application-warn

qa,doc: document and fix tests for pool application warnings

Merge pull request #16634 from neha-ojha/wip-default-device-class

osd: add default_device_class to metadata

Reviewed-by: xie xingguo <xie.xingguo@zte.com.cn>
Reviewed-by: Sage Weil <sage@redhat.com>

Merge pull request #16638 from liewegas/wip-20804

osd/PG: ignore CancelRecovery in NotRecovering

Reviewed-by: Greg Farnum <gfarnum@redhat.com>

Merge pull request #16646 from tchaikov/wip-qa-run-standalone-work-with-gnu-find

qa/run-standalone.sh: fix the find option to be compatible with GNU find

Reviewed-by: Willem Jan Withagen <wjw@digiware.nl>

Merge pull request #16487 from liewegas/wip-mgr-module-health

mgr: mgr_module interface to report health alerts

Reviewed-by: John Spray <john.spray@redhat.com>

Merge pull request #16641 from liewegas/wip-mgr-configs

mgr/PyState: shut up about get_config on nonexistent keys

Reviewed-by: John Spray <john.spray@redhat.com>

Merge pull request #16582 from liewegas/wip-20633

mon/MgrMonitor: reset mgrdigest timer with new subscription

Reviewed-by: Kefu Chai <kchai@redhat.com>

qa/run-standalone.sh: fix the find option to be compatible with GNU find

also re-indent to be consistent with other part of this script

Signed-off-by: Kefu Chai <kchai@redhat.com>

common/options: make "blue{fs,store}_allocator" LEVEL_DEV

See-also: http://tracker.ceph.com/issues/20660
Signed-off-by: Kefu Chai <kchai@redhat.com>

Merge pull request #16599 from liewegas/wip-standalone-fixes

qa/workunits: adjust path to ceph-helpers.sh

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #16482 from tchaikov/wip-opt

common/options: refactors to set the properties in a more structured way

Reviewed-by: John Spray <john.spray@redhat.com>

Merge pull request #16589 from Yan-waller/wip-walle-0726testwatchnotify

test/rados: fix wrong parameter order of RETURN1_IF_NOT_VAL

Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #16609 from wjwithagen/wip-wjw-FreeBSD-group-wheel

ceph_disk/main.py: FreeBSD root has wheel for group

Reviewed-by: Sage Weil <sage@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #16593 from shangzhong/wip-20660

os/bluestore/StupidAllocator: rounded down len to an align boundary

Reviewed-by: Sage Weil <sage@redhat.com>

common/options: document bluestore options

Signed-off-by: Sage Weil <sage@redhat.com>

compressor: accept 'none' or '' for none

This makes the parse and output methods match up.

Signed-off-by: Sage Weil <sage@redhat.com>

os/bluestore: observe bluestore_compression_required_ratio

Signed-off-by: Sage Weil <sage@redhat.com>

doc/dev/config: some guidance around defining config options

Signed-off-by: Sage Weil <sage@redhat.com>

Merge PR #16435 into master

* refs/remotes/upstream/pull/16435/head:
qa: whitelist trim error during powercycle tests

Reviewed-by: Kefu Chai <kchai@redhat.com>

mgr/PyState: shut up about get_config on nonexistent keys

Signed-off-by: Sage Weil <sage@redhat.com>

qa: fix wait for wrong health message

Fixes: http://tracker.ceph.com/issues/20805
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>

Merge pull request #16450 from markhpc/wip-rocksdb-bloomsettings

kv/RocksDBStore: Table options for indexing and filtering

Reviewed-by: Sage Weil <sage@redhat.com>

Merge pull request #16281 from badone/wip-PG-cluster-log-audit

osd: Log audit

Reviewed-by: Josh Durgin <jdurgin@redhat.com>

Merge pull request #16514 from liewegas/wip-20744

qa/tasks/ceph: wait for mgr to activate and pg stats to flush in health()

Reviewed-by: John Spray <john.spray@redhat.com>

osd/PG: ignore CancelRecovery in NotRecovering

It's possible to get >1 CancelRecovery events in the queue.
The first will transition us from Recovering to NotRecovering.
Currently the second will make us crash.

This is harmless; instead just swallow the event.

Fixes: http://tracker.ceph.com/issues/20804
Signed-off-by: Sage Weil <sage@redhat.com>

qa: whitelist trim error during powercycle tests

Fixes: http://tracker.ceph.com/issues/20566
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>

Merge pull request #16635 from dzafman/wip-fix-test-pidfile

test: test_pidfile running 2nd mon has unreliable log output

Reviewed-by: Sage Weil <sage@redhat.com>

osd: silence coverity warning in async read operation contexts

Coverity doesn't know that the context is deleted via the "complete"
method and the embedded context is therefore also destructed when
it's completed.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>

test: test_pidfile running 2nd mon has unreliable log output

Signed-off-by: David Zafman <dzafman@redhat.com>

osd: add default_device_class to metadata

Signed-off-by: Neha Ojha <nojha@redhat.com>

osd: moved OpFinisher logic from OSDOp to OpContext

This allows the memory lifetime of the OpFinisher to be tightly
controlled since the OpContext cannot be copied.

Fixes: http://tracker.ceph.com/issues/20783
Signed-off-by: Jason Dillaman <dillaman@redhat.com>

Merge pull request #16629 from johnwilkins/wip-doc-remove-contractions

Remove contractions from the documentation.

Reviewed-by: Greg Farnum <gfarnum@redhat.com>

Merge pull request #16572 from liewegas/wip-pidfile

test: add separate ceph-helpers-based smoke test

Reviewed-by: Kefu Chai <kchai@redhat.com>

doc/cephfs: Removed contractions for ESL speakers.

Signed-off-by: John Wilkins <jowilkin@redhat.com>

doc/start: Removed contractions for ESL speakers.

Signed-off-by: John Wilkins <jowilkin@redhat.com>

doc/man: Removed contractions for ESL speakers.

Signed-off-by: John Wilkins <jowilkin@redhat.com>

doc/install: Removed contractions for ESL speakers.

Signed-off-by: John Wilkins <jowilkin@redhat.com>

doc/rgw: Removed contractions for ESL speakers.

Signed-off-by: John Wilkins <jowilkin@redhat.com>

doc/rbd: Removed contractions for ESL speakers.

Signed-off-by: John Wilkins <jowilkin@redhat.com>

doc/rados: Removed contractions to improve readabilty for ESL speakers.

Signed-off-by: John Wilkins <jowilkin@redhat.com>

Merge pull request #16569 from liewegas/wip-set-not-put

mon: 'config-key put' -> 'config-key set'

Reviewed-by: Joao Eduardo Luis <joao@suse.de>