qa: Fix broken test_activate_osd() due to missing space

Signed-off-by: David Zafman <dzafman@redhat.com>

qa: Fix races with waiting for scrubs

The trigger_scrub sets the last_scrub_stamp backwards to
force a scheduled scrub.  In a small window this stamp could get propagated
to the mgr.  A test failure occurred because wait_for_scrub() was confused
by seeing a backward moving date.

The most critical change is having wait_for_scrub() make sure that the
date advances past the previous in value.

A test failed because the random backoff kept delayed triggered scrub, so
set osd_scrub_backoff throughout.

Signed-off-by: David Zafman <dzafman@redhat.com>

qa: Testing of ceph-helpers.sh, teardown on fail to dump logs, save cores

Signed-off-by: David Zafman <dzafman@redhat.com>

osd: Avoid confusion over legacy snaps when head_exists corrupt

Signed-off-by: David Zafman <dzafman@redhat.com>

osd: Fix Paxos shutdown handling for commit_finish race

Fixes: http://tracker.ceph.com/issues/20921
Signed-off-by: David Zafman <dzafman@redhat.com>

qa: Add support for core dumps

Save core dumps when running tests locally
Dump logs to output whenever cores seen

Signed-off-by: David Zafman <dzafman@redhat.com>

qa: For FreeBSD skip osd-dup.sh because there is no bluestore

Signed-off-by: David Zafman <dzafman@redhat.com>

qa: Raise mon-data-avail-warn to pass tests with less space

Signed-off-by: David Zafman <dzafman@redhat.com>

qa: Add common generalized inject_eio() to ceph-helpers.sh

Retry for a while to allow pool to appear

Signed-off-by: David Zafman <dzafman@redhat.com>

qa: osd-scrub-repair.sh handle older versions of jq

Signed-off-by: David Zafman <dzafman@redhat.com>

qa: Add support for specifying sub-tests with run-standalone.sh

Fix test-ceph-helpers.sh to pass additional arguments on

Signed-off-by: David Zafman <dzafman@redhat.com>

qa: ceph-helpers.sh fixes

Add missing teardown to cleanup test directory
Fix pgid due to elimination of initial default pool
Testing could never fail because run_tests return ignored

Signed-off-by: David Zafman <dzafman@redhat.com>

qa: Skip ceph-helpers.sh which is tested through test-ceph-helpers.sh

Signed-off-by: David Zafman <dzafman@redhat.com>

qa: Add create_pool() which sleeps 1 second like python variant

wait_for_clean() can miss the new pool if it races with pool create.

Fixes: http://tracker.ceph.com/issues/20465
Signed-off-by: David Zafman <dzafman@redhat.com>

qa: Add special test_failure.sh script (not run by default)

Signed-off-by: David Zafman <dzafman@redhat.com>

qa: run-standalone.sh improvements

Signed-off-by: David Zafman <dzafman@redhat.com>

qa: Dump logs after daemons are killed to make sure everything is flushed

Signed-off-by: David Zafman <dzafman@redhat.com>

Merge pull request #16827 from liewegas/wip-more-more-more

qa/suites/rados/basic/tasks/rados_python: POOL_APP_NOT_ENABLED

qa/suites/rados/basic/tasks/rados_python: POOL_APP_NOT_ENABLED

Signed-off-by: Sage Weil <sage@redhat.com>

Merge pull request #16724 from amitkumar50/cov-1403249

librbd: Uninitialized variable used handle_refresh()

Reviewed-by: Jason Dillaman <dillaman@redhat.com>

Merge pull request #16742 from scienceluo/wip-luo-coverity-fix-branch

test/librbd/fsx: Add break in case OP_WRITESAME and OP_COMPARE_AND_WRITE

Reviewed-by: Jason Dillaman <dillaman@redhat.com>

Merge pull request #16729 from amitkumar50/cov-1402141

rbd: Drop unused member variable reopen in C_OpenComplete

Reviewed-by: Jason Dillaman <dillaman@redhat.com>

Merge pull request #16769 from liewegas/wip-20295-b

os/bluestore: allow multiple DeferredBatches in flight at once

Reviewed-by: xie xingguo <xie.xingguo@zte.com.cn>

Merge pull request #16787 from liewegas/wip-bluestore-docs

doc/release-notes: fix bluestore links

Reviewed-by: Abhishek Lekshmanan <abhishek@suse.com>

Merge pull request #16632 from ceph/wip-volume

ceph-volume: initial take on ceph-volume CLI tool

Reviewed-by: Sage Weil <sage@redhat.com>
Reviewed-by: Andrew Schoen <aschoen@redhat.com>

ceph-volume lvm trigger should check for root

Signed-off-by: Alfredo Deza <adeza@redhat.com>

ceph-volume lvm prepare should check for root

Signed-off-by: Alfredo Deza <adeza@redhat.com>

ceph-volume lvm create should check for root

Signed-off-by: Alfredo Deza <adeza@redhat.com>

ceph-volume lvm activate should check for root

Signed-off-by: Alfredo Deza <adeza@redhat.com>

ceph-volume: decorators should call the wrapped func

Signed-off-by: Alfredo Deza <adeza@redhat.com>

ceph-volume: systemd script should handle type-data format as argument

Signed-off-by: Alfredo Deza <adeza@redhat.com>

ceph-volume: lvm add the actual trigger subcommand handler

Signed-off-by: Alfredo Deza <adeza@redhat.com>

ceph-volume: lvm: add a trigger sub-command to parent parser

Signed-off-by: Alfredo Deza <adeza@redhat.com>

ceph-volume: tests update argument parsing for systemd

Signed-off-by: Alfredo Deza <adeza@redhat.com>

ceph-volume: tests add an lvm trigger for the systemd argument parsing

Signed-off-by: Alfredo Deza <adeza@redhat.com>

ceph-volume remove activate utilities, not needed with 'osd new'

Signed-off-by: Alfredo Deza <adeza@redhat.com>

ceph-volume lvm.activate remove unused import for activate utils

Signed-off-by: Alfredo Deza <adeza@redhat.com>

ceph-volume: systemd should retry several times to activate a device

Allows environment variables to tweak the retries and intervals,
defaulting to 30 tries at 5 second intervals.

Signed-off-by: Alfredo Deza <adeza@redhat.com>

ceph-volume: devices chown the journal when activating

Signed-off-by: Alfredo Deza <adeza@redhat.com>

ceph-volume: systemd script should pass pre-configured log args

Signed-off-by: Alfredo Deza <adeza@redhat.com>

ceph-volume: prevent missing conf values for logging config

Signed-off-by: Alfredo Deza <adeza@redhat.com>

ceph-volume: systemd: add helpers for the ceph-volume systemd unit

Signed-off-by: Alfredo Deza <adeza@redhat.com>

ceph-volume: util prepare should pass -i to consume stdin

Signed-off-by: Alfredo Deza <adeza@redhat.com>

ceph-volume: lvm consume the JSON secrets for preparing

Signed-off-by: Alfredo Deza <adeza@redhat.com>

ceph-volume: lvm remove the creation of the osd so early in the prepare process

Signed-off-by: Alfredo Deza <adeza@redhat.com>

ceph-volume: lvm: activate should not use the bootstrap-osd to auth add the keyring

Signed-off-by: Alfredo Deza <adeza@redhat.com>

ceph-volume: util: use osd new for creating osds

Signed-off-by: Alfredo Deza <adeza@redhat.com>

ceph-volume: process: allow stdin to be used

Signed-off-by: Alfredo Deza <adeza@redhat.com>

ceph-volume: main: slice args for main and subcommands differently

Signed-off-by: Alfredo Deza <adeza@redhat.com>

ceph-volume: devices.lvm add create module for the sub-command support

Signed-off-by: Alfredo Deza <adeza@redhat.com>

ceph-volume: devices.lvm add the create sub-command

Signed-off-by: Alfredo Deza <adeza@redhat.com>

ceph-volume: devices.lvm create a common module for sharing parsers

Signed-off-by: Alfredo Deza <adeza@redhat.com>

ceph-volume: devices: update coverage comments

Signed-off-by: Alfredo Deza <adeza@redhat.com>

ceph-volume: tests: add lvm api tests

Signed-off-by: Alfredo Deza <adeza@redhat.com>

ceph-volume: tests: update coverage comments

Signed-off-by: Alfredo Deza <adeza@redhat.com>

ceph-volume: devices.lvm: update print and import for py3 support

Signed-off-by: Alfredo Deza <adeza@redhat.com>

ceph-volume: lvm.main: update imports for py3 support

Signed-off-by: Alfredo Deza <adeza@redhat.com>

ceph-volume: tests: create capture fixture for tests

Signed-off-by: Alfredo Deza <adeza@redhat.com>

ceph-volume: devices: update imports to support py3

Signed-off-by: Alfredo Deza <adeza@redhat.com>

ceph-volume: main: py3 support fixes with print

Signed-off-by: Alfredo Deza <adeza@redhat.com>

ceph-volume: lvm.api: add parse_tags for VolumeGroup, cleanup json loads

Signed-off-by: Alfredo Deza <adeza@redhat.com>

ceph-volume: process: decode non-str streams from subprocess

Signed-off-by: Alfredo Deza <adeza@redhat.com>

ceph-volume: lvm.prepare: print help and return before parsing args if no args

Signed-off-by: Alfredo Deza <adeza@redhat.com>

ceph-volume: lvm: print help and return before parsing args if no args

Signed-off-by: Alfredo Deza <adeza@redhat.com>

ceph-volume: tets: use the new validation in conf

Signed-off-by: Alfredo Deza <adeza@redhat.com>

ceph-volume: tests: add tests for lvm devices and API

Signed-off-by: Alfredo Deza <adeza@redhat.com>

ceph-volume: configuration: introduce lazy validation in configuration

Signed-off-by: Alfredo Deza <adeza@redhat.com>

ceph-volume: tests: add tests for the system utility

Signed-off-by: Alfredo Deza <adeza@redhat.com>

ceph-volume: util: remove ceph_user option, it is the default

Signed-off-by: Alfredo Deza <adeza@redhat.com>

ceph-volume: util: use the chown argument for mkdir_p

Signed-off-by: Alfredo Deza <adeza@redhat.com>

ceph-volume: systemd: ensure osd_id is digit-like

Signed-off-by: Alfredo Deza <adeza@redhat.com>

ceph-volume: tests: add systemd tests

Signed-off-by: Alfredo Deza <adeza@redhat.com>

ceph-volume: tests: add tests for main/cli handling

Signed-off-by: Alfredo Deza <adeza@redhat.com>

ceph-volume: tests: add tests for decorators

Signed-off-by: Alfredo Deza <adeza@redhat.com>

ceph-volume: tests: add configuration tests

Signed-off-by: Alfredo Deza <adeza@redhat.com>

ceph-volume: main: changes to sys.argv handling for better testing

Signed-off-by: Alfredo Deza <adeza@redhat.com>

ceph-volume: tests: add terminal tests

Signed-off-by: Alfredo Deza <adeza@redhat.com>

ceph-volume: main: if no args are passed mention the --help usage, print some information

Signed-off-by: Alfredo Deza <adeza@redhat.com>

ceph-volume: lvm: use argparse, report help as early as possible

Signed-off-by: Alfredo Deza <adeza@redhat.com>

ceph-volume: terminal: add CLI dispatching helpers

Signed-off-by: Alfredo Deza <adeza@redhat.com>

ceph-volume: main: use argparse, add global flags, improve main help

Signed-off-by: Alfredo Deza <adeza@redhat.com>

ceph-volume: lvm.prepare: initial pass at a working prepare

Signed-off-by: Alfredo Deza <adeza@redhat.com>

ceph-volume: lvm.activate: register the osd with the mon as part of activation

Signed-off-by: Alfredo Deza <adeza@redhat.com>

ceph-volume: lvm.api: fix issue with tags not being set always

Signed-off-by: Alfredo Deza <adeza@redhat.com>

ceph-volume: util.system: allow recursive and single-level chown

Signed-off-by: Alfredo Deza <adeza@redhat.com>

ceph-volume: util: create the module with prepare, activate, and system utilities

Signed-off-by: Alfredo Deza <adeza@redhat.com>

ceph-volume: terminal: add colored stderr/stdout

Signed-off-by: Alfredo Deza <adeza@redhat.com>

ceph-volume: main: add log path inferring into main for --help reporting

Signed-off-by: Alfredo Deza <adeza@redhat.com>

ceph-volume: log: remove log file inferring logic to main

Signed-off-by: Alfredo Deza <adeza@redhat.com>

ceph-volume: configuration: allow splitting by other chars for getting a list

Signed-off-by: Alfredo Deza <adeza@redhat.com>

ceph-volume: init: define a few conf attributes

Signed-off-by: Alfredo Deza <adeza@redhat.com>

ceph-volume: process: do not block logging on subprocess prompts

Signed-off-by: Alfredo Deza <adeza@redhat.com>

ceph-volume: main: store ceph conf and load it in the conf module

Signed-off-by: Alfredo Deza <adeza@redhat.com>

ceph-volume: configuration: create a module to load/parse ceph configs

Signed-off-by: Alfredo Deza <adeza@redhat.com>

ceph-volume: log: use new config module

Signed-off-by: Alfredo Deza <adeza@redhat.com>

ceph-volume: init: define the configuration modules

Signed-off-by: Alfredo Deza <adeza@redhat.com>

ceph-volume: exceptions: add configuration errors

Signed-off-by: Alfredo Deza <adeza@redhat.com>

ceph-volume: lvm.activate: udpdate the help to normalize representations

Signed-off-by: Alfredo Deza <adeza@redhat.com>

ceph-volume: exceptions: add error for multiple volume groups

Signed-off-by: Alfredo Deza <adeza@redhat.com>

ceph-volume: lvm.activate: add object store type support for the flags

Signed-off-by: Alfredo Deza <adeza@redhat.com>